@platformatic/kafka 2.4.0 → 2.5.0

package/dist/network/connection.js

@@ -50,6 +50,7 @@ export class Connection extends TypedEventEmitter {
     #responseReader;
     #socket;
     #socketMustBeDrained;
+    #detectMissingTLS;
     #reauthenticationTimeout;
     constructor(clientId, options = {}) {
         super();
@@ -75,6 +76,7 @@ export class Connection extends TypedEventEmitter {
         this.#responseBuffer = new DynamicBuffer();
         this.#responseReader = new Reader(this.#responseBuffer);
         this.#socketMustBeDrained = false;
+        this.#detectMissingTLS = !this.#options.tls;
         notifyCreation('connection', this);
     }
     /* c8 ignore next 3 - Simple getter */
@@ -120,6 +122,7 @@ export class Connection extends TypedEventEmitter {
                 return callback[kCallbackPromise];
             }
             this.#status = ConnectionStatuses.CONNECTING;
+            this.#detectMissingTLS = !this.#options.tls;
             const connectionOptions = {
                 timeout: this.#options.connectTimeout
             };
@@ -259,7 +262,7 @@ export class Connection extends TypedEventEmitter {
     }
     send(apiKey, apiVersion, createPayload, responseParser, hasRequestHeaderTaggedFields, hasResponseHeaderTaggedFields, callback) {
         // Correlation ID is a 32-bit integer in the protocol, so we need to wrap around after 2^31 - 1
-        const correlationId = (this.#correlationId + 1) & 0x7FFFFFFF;
+        const correlationId = (this.#correlationId + 1) & 0x7fffffff;
         this.#correlationId = correlationId;
         const diagnostic = createDiagnosticContext({
             connection: this,
@@ -467,6 +470,27 @@ export class Connection extends TypedEventEmitter {
         correlation_id => INT32
     */
     #onData(chunk) {
+        if (this.#detectMissingTLS) {
+            this.#detectMissingTLS = false;
+            if (this.#isTLSRecord(chunk)) {
+                const error = new UserError('Broker requires TLS.');
+                this.#status = ConnectionStatuses.ERROR;
+                for (const request of this.#afterDrainRequests) {
+                    if (!request.noResponse) {
+                        clearTimeout(request.timeoutHandle);
+                        request.callback(error, undefined);
+                    }
+                }
+                this.#afterDrainRequests = [];
+                for (const request of this.#inflightRequests.values()) {
+                    clearTimeout(request.timeoutHandle);
+                    request.callback(error, undefined);
+                }
+                this.#inflightRequests.clear();
+                this.#socket.destroy();
+                return;
+            }
+        }
         this.#responseBuffer.append(chunk);
         // There is at least one message size to add
         // Note that here the initial position is always 0
@@ -547,6 +571,12 @@ export class Connection extends TypedEventEmitter {
         this.#socketMustBeDrained = false;
         this.emit('drain');
     }
+    #isTLSRecord(chunk) {
+        return (chunk.length >= 3 &&
+            (chunk[0] === 0x14 || chunk[0] === 0x15 || chunk[0] === 0x16 || chunk[0] === 0x17) &&
+            chunk[1] === 0x03 &&
+            chunk[2] <= 0x04);
+    }
     #onClose() {
         this.#status = ConnectionStatuses.CLOSED;
         this.emit('close');

package/dist/version.js

@@ -1,2 +1,2 @@
 export const name = "@platformatic/kafka";
-export const version = "2.4.0";
+export const version = "2.5.0";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@platformatic/kafka",
-  "version": "2.4.0",
+  "version": "2.5.0",
   "description": "Modern and performant client for Apache Kafka",
   "homepage": "https://github.com/platformatic/kafka",
   "author": "Platformatic Inc. <oss@platformatic.dev> (https://platformatic.dev)",