@platformatic/kafka 1.17.0 → 1.17.1

package/dist/clients/consumer/consumer.js

@@ -2,6 +2,7 @@ import { createPromisifiedCallback, kCallbackPromise, runConcurrentCallbacks } f
 import { FetchIsolationLevels, FindCoordinatorKeyTypes } from "../../apis/enumerations.js";
 import { consumerCommitsChannel, consumerConsumesChannel, consumerFetchesChannel, consumerGroupChannel, consumerHeartbeatChannel, consumerOffsetsChannel, createDiagnosticContext } from "../../diagnostic.js";
 import { UserError } from "../../errors.js";
+import { INT32_SIZE } from "../../protocol/definitions.js";
 import { Reader } from "../../protocol/reader.js";
 import { Writer } from "../../protocol/writer.js";
 import { Base, kAfterCreate, kCheckNotClosed, kClearMetadata, kClosed, kCreateConnectionPool, kFetchConnections, kFormatValidationErrors, kGetApi, kGetBootstrapConnection, kGetConnection, kMetadata, kOptions, kPerformDeduplicated, kPerformWithRetry, kPrometheus, kValidateOptions } from "../base/base.js";
@@ -25,7 +26,6 @@ export class Consumer extends Base {
     #heartbeatInterval;
     #lastHeartbeat;
     #streams;
-    #partitionsAssigner;
     /*
       The following requests are blocking in Kafka:
   
@@ -60,7 +60,6 @@ export class Consumer extends Base {
         this.#heartbeatInterval = null;
         this.#lastHeartbeat = null;
         this.#streams = new Set();
-        this.#partitionsAssigner = this[kOptions].partitionAssigner ?? roundRobinAssigner;
         this.#validateGroupOptions(this[kOptions], groupIdAndOptionsValidator);
         // Initialize connection pool
         this[kFetchConnections] = this[kCreateConnectionPool]();
@@ -482,8 +481,8 @@ export class Consumer extends Base {
     #leaveGroup(force, callback) {
         consumerGroupChannel.traceCallback(this.#performLeaveGroup, 1, createDiagnosticContext({ client: this, operation: 'leaveGroup', force }), this, force, callback);
     }
-    #syncGroup(callback) {
-        consumerGroupChannel.traceCallback(this.#performSyncGroup, 1, createDiagnosticContext({ client: this, operation: 'syncGroup' }), this, null, callback);
+    #syncGroup(partitionsAssigner, callback) {
+        consumerGroupChannel.traceCallback(this.#performSyncGroup, 2, createDiagnosticContext({ client: this, operation: 'syncGroup' }), this, partitionsAssigner, null, callback);
     }
     #heartbeat(options) {
         const eventPayload = { groupId: this.groupId, memberId: this.memberId, generationId: this.generationId };
@@ -635,7 +634,7 @@ export class Consumer extends Base {
                 this.#members.set(member.memberId, this.#decodeProtocolSubscriptionMetadata(member.memberId, member.metadata));
             }
             // Send a syncGroup request
-            this.#syncGroup((error, response) => {
+            this.#syncGroup(options.partitionAssigner, (error, response) => {
                 if (!this.#membershipActive) {
                     callback(null, undefined);
                     return;
@@ -721,7 +720,7 @@ export class Consumer extends Base {
             callback(null);
         });
     }
-    #performSyncGroup(assignments, callback) {
+    #performSyncGroup(partitionsAssigner, assignments, callback) {
         if (!this.#membershipActive) {
             callback(null, []);
             return;
@@ -745,7 +744,7 @@ export class Consumer extends Base {
                         callback(this.#handleMetadataError(error), undefined);
                         return;
                     }
-                    this.#performSyncGroup(this.#createAssignments(metadata), callback);
+                    this.#performSyncGroup(partitionsAssigner, this.#createAssignments(partitionsAssigner, metadata), callback);
                 });
                 return;
             }
@@ -844,6 +843,9 @@ export class Consumer extends Base {
     #decodeProtocolAssignment(buffer) {
         const reader = Reader.from(buffer);
         reader.skip(2); // Ignore Version information
+        if (reader.remaining < INT32_SIZE) {
+            return [];
+        }
         return reader.readArray(r => {
             return {
                 topic: r.readString(false),
@@ -851,7 +853,7 @@ export class Consumer extends Base {
             };
         }, false, false);
     }
-    #createAssignments(metadata) {
+    #createAssignments(partitionsAssigner, metadata) {
         const partitionTracker = new Map();
         // First of all, layout topics-partitions in a list
         for (const [topic, partitions] of metadata.topics) {
@@ -872,7 +874,8 @@ export class Consumer extends Base {
             return [{ memberId: this.memberId, assignment: this.#encodeProtocolAssignment(assignments) }];
         }
         const encodedAssignments = [];
-        for (const member of this.#partitionsAssigner(this.memberId, this.#members, new Set(this.topics.current), metadata)) {
+        partitionsAssigner ??= this[kOptions].partitionAssigner ?? roundRobinAssigner;
+        for (const member of partitionsAssigner(this.memberId, this.#members, new Set(this.topics.current), metadata)) {
             encodedAssignments.push({
                 memberId: member.memberId,
                 assignment: this.#encodeProtocolAssignment(Array.from(member.assignments.values()))

package/dist/version.js

@@ -1,2 +1,2 @@
 export const name = "@platformatic/kafka";
-export const version = "1.17.0";
+export const version = "1.17.1";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@platformatic/kafka",
-  "version": "1.17.0",
+  "version": "1.17.1",
   "description": "Modern and performant client for Apache Kafka",
   "homepage": "https://github.com/platformatic/kafka",
   "author": "Platformatic Inc. <oss@platformatic.dev> (https://platformatic.dev)",