@platformatic/basic 3.0.0-alpha.8 → 3.0.0-rc.2

package/config.d.ts

@@ -98,6 +98,7 @@ export interface PlatformaticBasicConfig {
     };
     startTimeout?: number;
     restartOnError?: boolean | number;
+    exitOnUnhandledErrors?: boolean;
     gracefulShutdown?: {
       runtime: number | string;
       application: number | string;

package/lib/capability.js

@@ -458,6 +458,11 @@ export class BaseCapability extends EventEmitter {
       this.basePath = path
     })
 
+    this.childManager.on('event', event => {
+      globalThis[kITC].notify('event', event)
+      this.emit('application:worker:event', config)
+    })
+
     // This is not really important for the URL but sometimes it also a sign
     // that the process has been replaced and thus we need to update the client WebSocket
     this.childManager.on('url', (url, clientWs) => {
@@ -543,6 +548,7 @@ export class BaseCapability extends EventEmitter {
       isEntrypoint: this.isEntrypoint,
       runtimeBasePath: this.runtimeConfig?.basePath ?? null,
       wantsAbsoluteUrls: meta.gateway?.wantsAbsoluteUrls ?? false,
+      exitOnUnhandledErrors: this.runtimeConfig.exitOnUnhandledErrors ?? true,
       /* c8 ignore next 2 - else */
       port: (this.isEntrypoint ? this.serverConfig?.port || 0 : undefined) ?? true,
       host: (this.isEntrypoint ? this.serverConfig?.hostname : undefined) ?? true,
@@ -719,7 +725,7 @@ export class BaseCapability extends EventEmitter {
       help: 'Number of active resources keeping the event loop alive',
       registers: [registry]
     })
-    globalThis.platformatic.onActiveResourcesEventLoop = (val) => activeResourcesEventLoopMetric.set(val)
+    globalThis.platformatic.onActiveResourcesEventLoop = val => activeResourcesEventLoopMetric.set(val)
   }
 
   async #invalidateHttpCache (opts = {}) {

package/lib/worker/child-process.js

@@ -112,7 +112,11 @@ export class ChildProcess extends ITC {
 
     this.listen()
     this.#setupLogger()
-    this.#setupHandlers()
+
+    if (globalThis.platformatic.exitOnUnhandledErrors) {
+      this.#setupHandlers()
+    }
+
     this.#setupServer()
     this.#setupInterceptors()
 
@@ -288,7 +292,7 @@ export class ChildProcess extends ITC {
       help: 'Number of active resources keeping the event loop alive',
       registers: [registry]
     })
-    globalThis.platformatic.onActiveResourcesEventLoop = (val) => activeResourcesEventLoopMetric.set(val)
+    globalThis.platformatic.onActiveResourcesEventLoop = val => activeResourcesEventLoopMetric.set(val)
   }
 
   async #getMetrics ({ format } = {}) {
@@ -404,6 +408,14 @@ export class ChildProcess extends ITC {
 
     process.on('uncaughtException', handleUnhandled.bind(this, 'uncaught exception'))
     process.on('unhandledRejection', handleUnhandled.bind(this, 'unhandled rejection'))
+
+    process.on('newListener', event => {
+      if (event === 'uncaughtException' || event === 'unhandledRejection') {
+        this.#logger.warn(
+          `A listener has been added for the "process.${event}" event. This listener will be never triggered as Watt default behavior will kill the process before.\n To disable this behavior, set "exitOnUnhandledErrors" to false in the runtime config.`
+        )
+      }
+    })
   }
 
   #notifyConfig (config) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@platformatic/basic",
-  "version": "3.0.0-alpha.8",
+  "version": "3.0.0-rc.2",
   "description": "",
   "main": "index.js",
   "types": "index.d.ts",
@@ -25,10 +25,10 @@
     "split2": "^4.2.0",
     "undici": "^7.0.0",
     "ws": "^8.18.0",
-    "@platformatic/itc": "3.0.0-alpha.8",
-    "@platformatic/foundation": "3.0.0-alpha.8",
-    "@platformatic/telemetry": "3.0.0-alpha.8",
-    "@platformatic/metrics": "3.0.0-alpha.8"
+    "@platformatic/foundation": "3.0.0-rc.2",
+    "@platformatic/metrics": "3.0.0-rc.2",
+    "@platformatic/itc": "3.0.0-rc.2",
+    "@platformatic/telemetry": "3.0.0-rc.2"
   },
   "devDependencies": {
     "cleaner-spec-reporter": "^0.5.0",

package/schema.json

@@ -1,5 +1,5 @@
 {
-  "$id": "https://schemas.platformatic.dev/@platformatic/basic/3.0.0-alpha.8.json",
+  "$id": "https://schemas.platformatic.dev/@platformatic/basic/3.0.0-rc.2.json",
   "$schema": "http://json-schema.org/draft-07/schema#",
   "title": "Platformatic Basic Config",
   "type": "object",
@@ -563,6 +563,10 @@
             }
           ]
         },
+        "exitOnUnhandledErrors": {
+          "default": true,
+          "type": "boolean"
+        },
         "gracefulShutdown": {
           "type": "object",
           "properties": {

package/lib/worker/child-transport.js

@@ -1,59 +0,0 @@
-import { ensureLoggableError } from '@platformatic/foundation'
-import { generateRequest, sanitize } from '@platformatic/itc/lib/index.js'
-import { once } from 'node:events'
-import { platform } from 'node:os'
-import { workerData } from 'node:worker_threads'
-import build from 'pino-abstract-transport'
-import { WebSocket } from 'ws'
-import { getSocketPath } from './child-manager.js'
-
-/* c8 ignore next 5 */
-function logDirectError (message, error) {
-  process._rawDebug(`Logger thread for child process of application ${workerData.id} ${message}.`, {
-    error: ensureLoggableError(error)
-  })
-}
-
-/* c8 ignore next 4 */
-function handleUnhandled (type, error) {
-  logDirectError(`threw an ${type}`, error)
-  process.exit(6)
-}
-
-process.on('uncaughtException', handleUnhandled.bind(null, 'uncaught exception'))
-process.on('unhandledRejection', handleUnhandled.bind(null, 'unhandled rejection'))
-
-export default async function () {
-  try {
-    /* c8 ignore next */
-    const protocol = platform() === 'win32' ? 'ws+unix:' : 'ws+unix://'
-    const socket = new WebSocket(`${protocol}${getSocketPath(process.env.PLT_MANAGER_ID)}`)
-
-    await once(socket, 'open')
-
-    // Do not process responses but empty the socket inbound queue
-    socket.on('message', () => {})
-
-    /* c8 ignore next 3 */
-    socket.on('error', error => {
-      logDirectError('threw a socket error', error)
-    })
-
-    return build(
-      async function (source) {
-        for await (const obj of source) {
-          socket.send(JSON.stringify(sanitize(generateRequest('log', { logs: [obj] }))))
-        }
-      },
-      {
-        close (_, cb) {
-          socket.close()
-          cb()
-        }
-      }
-    )
-    /* c8 ignore next 3 */
-  } catch (error) {
-    logDirectError('threw a connection error', error)
-  }
-}