@platform-modules/civil-aviation-authority 2.3.304 → 2.3.305

package/dist/models/DepartmentsModel.d.ts

@@ -4,5 +4,6 @@ export declare class Departments extends BaseModel {
     department_arabic_name: string | null;
     department_code: string;
     department_description: string;
+    DG_department_id: number | null;
     constructor(department_name: string, department_code: string, department_description: string);
 }

package/dist/models/DepartmentsModel.js

@@ -37,6 +37,10 @@ __decorate([
     (0, typeorm_1.Column)({ nullable: false }),
     __metadata("design:type", String)
 ], Departments.prototype, "department_description", void 0);
+__decorate([
+    (0, typeorm_1.Column)({ type: 'integer', nullable: true, name: 'DG_department_id' }),
+    __metadata("design:type", Object)
+], Departments.prototype, "DG_department_id", void 0);
 exports.Departments = Departments = __decorate([
     (0, typeorm_1.Entity)({ name: 'departments' }),
     __metadata("design:paramtypes", [String, String, String])

package/package.json

@@ -1,6 +1,6 @@
 {
  "name": "@platform-modules/civil-aviation-authority",
-  "version": "2.3.304",
+  "version": "2.3.305",
  "main": "dist/index.js",
  "types": "dist/index.d.ts",
   "scripts": {

package/scripts/sync-sla-reports-sql.js

@@ -1,7 +1,7 @@
 /**
  * Applies SLA report views + stored procedures to PostgreSQL (idempotent CREATE OR REPLACE).
  *
- * Env (shared_models/.env or Reports_Service/.env):
+ * Env from shared_models/.env only:
  *   DB_HOST / TYPEORM_HOST
  *   DB_PORT / TYPEORM_PORT
  *   DB_USER / TYPEORM_USERNAME
@@ -20,31 +20,25 @@ const { Client } = require('pg');
 function loadEnvFiles() {
   const dotenv = require('dotenv');
   const packageRoot = path.resolve(__dirname, '..');
-  const cwdEnv = path.join(process.cwd(), '.env');
   const packageEnv = path.join(packageRoot, '.env');
-  const reportsEnv = path.resolve(packageRoot, '..', 'Reports_Service', '.env');
 
-  if (fs.existsSync(cwdEnv)) {
-    dotenv.config({ path: cwdEnv });
-  }
-  if (fs.existsSync(packageEnv)) {
-    dotenv.config({ path: packageEnv, override: true });
-  }
-  if (fs.existsSync(reportsEnv)) {
-    dotenv.config({ path: reportsEnv, override: true });
+  if (!fs.existsSync(packageEnv)) {
+    throw new Error(`Missing env file: ${packageEnv}`);
   }
+
+  dotenv.config({ path: packageEnv, override: true });
 }
 
 function getDbConfig() {
-  const host = (process.env.TYPEORM_HOST || process.env.DB_HOST || '').trim();
-  const port = parseInt(process.env.TYPEORM_PORT || process.env.DB_PORT || '5432', 10);
-  const user = (process.env.TYPEORM_USERNAME || process.env.DB_USER || '').trim();
-  const password = process.env.TYPEORM_PASSWORD || process.env.DB_PASS || '';
-  const database = (process.env.TYPEORM_DATABASE || process.env.DB_NAME || '').trim();
+  const host = (process.env.DB_HOST || process.env.TYPEORM_HOST || '').trim();
+  const port = parseInt(process.env.DB_PORT || process.env.TYPEORM_PORT || '5432', 10);
+  const user = (process.env.DB_USER || process.env.TYPEORM_USERNAME || '').trim();
+  const password = process.env.DB_PASS || process.env.TYPEORM_PASSWORD || '';
+  const database = (process.env.DB_NAME || process.env.TYPEORM_DATABASE || '').trim();
 
   if (!host || !user || !database) {
     throw new Error(
-      'Missing DB config. Set TYPEORM_* in Reports_Service/.env or DB_* in shared_models/.env'
+      'Missing DB config. Set DB_HOST, DB_USER, DB_NAME (and DB_PASS) in shared_models/.env'
     );
   }
 

package/sql/README.md

@@ -10,7 +10,7 @@ Applied in order by `npm run sync:sla-sql` (see `sla-reports-sync.manifest.json`
 | `sla_reports_approvals_workbook.sql` | Approvals Excel workbook (Requests + Approvals per sub-service) |
 | `sla_reports_admin_procedures.sql` | Admin SLA report functions (requires procedures file) |
 
-From **shared_models** (uses `shared_models/.env`, or `Reports_Service/.env` when present in monorepo):
+From **shared_models** (reads DB config from `shared_models/.env` only — `DB_HOST`, `DB_USER`, `DB_PASS`, `DB_NAME`):
 
 ```bash
 cd shared_models && npm run sync:sla-sql

package/sql/alter_sla_requests_status_to_varchar.sql

@@ -1,18 +1,25 @@
 -- Migrate sla_requests.status from PostgreSQL enum to varchar(64) in-place (preserves data).
--- Drops SLA views only when converting from enum (safe for sync:sla-sql manifest runs).
+-- Drops SLA views when a type change is required (recreated by later sync:sla-sql files).
 -- Idempotent when status is already varchar(64).
 
 DO $$
 DECLARE
     status_udt text;
+    status_len integer;
 BEGIN
-    SELECT c.udt_name
-    INTO status_udt
+    SELECT c.udt_name, c.character_maximum_length
+    INTO status_udt, status_len
     FROM information_schema.columns c
     WHERE c.table_schema = 'public'
       AND c.table_name = 'sla_requests'
       AND c.column_name = 'status';
 
+    IF status_udt IS NULL THEN
+        RAISE NOTICE 'sla_requests.status not found — skip type migration';
+        RETURN;
+    END IF;
+
+    -- Enum -> varchar(64)
     IF status_udt = 'sla_requests_status_enum' THEN
         DROP VIEW IF EXISTS vw_sla_approvals CASCADE;
         DROP VIEW IF EXISTS vw_sla_my_requests CASCADE;
@@ -21,9 +28,16 @@ BEGIN
             ALTER COLUMN status TYPE varchar(64) USING status::text;
 
         DROP TYPE IF EXISTS sla_requests_status_enum;
-    ELSIF status_udt = 'varchar' THEN
+
+    -- Already varchar but not length 64 (views block ALTER TYPE)
+    ELSIF status_udt = 'varchar' AND status_len IS DISTINCT FROM 64 THEN
+        DROP VIEW IF EXISTS vw_sla_approvals CASCADE;
+        DROP VIEW IF EXISTS vw_sla_my_requests CASCADE;
+
         ALTER TABLE sla_requests
             ALTER COLUMN status TYPE varchar(64);
+
+    -- Already varchar(64) — nothing to do
     END IF;
 END $$;
 

package/sql/caa_api_payload_changes_2026_07.sql

@@ -139,3 +139,7 @@ ALTER TABLE followup_report_items
   ADD COLUMN IF NOT EXISTS file_name VARCHAR(255),
   ADD COLUMN IF NOT EXISTS file_type VARCHAR(100),
   ADD COLUMN IF NOT EXISTS file_size BIGINT;
+
+-- 10. Departments: optional parent DG department reference (self FK to departments.id)
+ALTER TABLE departments
+  ADD COLUMN IF NOT EXISTS "DG_department_id" INTEGER NULL;

package/sql/sla_reports_admin_procedures.sql

@@ -22,6 +22,8 @@ $$;
 -- ADMIN — my requests Excel (optional p_target_user_id)
 -- Per sub-service Requests + Approvals sheets (same as user my-requests download)
 -- ---------------------------------------------------------------------------
+DROP FUNCTION IF EXISTS sp_sla_admin_my_requests_excel_export(INT, INT[], INT[], TEXT[], DATE, DATE, TEXT, TEXT, TEXT);
+
 CREATE OR REPLACE FUNCTION sp_sla_admin_my_requests_excel_export(
   p_target_user_id    INT      DEFAULT NULL,
   p_service_ids       INT[]    DEFAULT NULL,
@@ -31,7 +33,8 @@ CREATE OR REPLACE FUNCTION sp_sla_admin_my_requests_excel_export(
   p_to_date           DATE     DEFAULT NULL,
   p_search_text       TEXT     DEFAULT NULL,
   p_sort_by           TEXT     DEFAULT 'created_at',
-  p_sort_order        TEXT     DEFAULT 'DESC'
+  p_sort_order        TEXT     DEFAULT 'DESC',
+  p_extra_filter_sql  TEXT     DEFAULT 'TRUE'
 )
 RETURNS TABLE (
   sheet_order         INT,
@@ -63,7 +66,11 @@ DECLARE
   v_sheet_order       INT := 0;
   v_user_filter       TEXT;
 BEGIN
-  v_user_filter := CASE WHEN p_target_user_id IS NULL THEN 'TRUE' ELSE format('v.user_id = %s', p_target_user_id) END;
+  v_user_filter := format(
+    '(%s) AND (%s)',
+    CASE WHEN p_target_user_id IS NULL THEN 'TRUE' ELSE format('v.user_id = %s', p_target_user_id) END,
+    COALESCE(NULLIF(trim(p_extra_filter_sql), ''), 'TRUE')
+  );
 
   v_sort_col := CASE lower(trim(p_sort_by))
     WHEN 'updated_at'  THEN 'v.created_at'
@@ -199,6 +206,10 @@ DROP FUNCTION IF EXISTS sp_sla_approvals_excel_export_internal(
   TEXT, BOOLEAN, INT, INT[], INT[], TEXT[], TEXT[], DATE, DATE, TEXT, TEXT, TEXT
 );
 
+DROP FUNCTION IF EXISTS sp_sla_approvals_excel_export(
+  INT, INT[], INT[], TEXT[], TEXT[], DATE, DATE, TEXT, TEXT, TEXT
+);
+
 CREATE OR REPLACE FUNCTION sp_sla_approvals_excel_export(
   p_approver_user_id    INT,
   p_service_ids         INT[]    DEFAULT NULL,
@@ -209,7 +220,8 @@ CREATE OR REPLACE FUNCTION sp_sla_approvals_excel_export(
   p_to_date             DATE     DEFAULT NULL,
   p_search_text         TEXT     DEFAULT NULL,
   p_sort_by             TEXT     DEFAULT 'created_at',
-  p_sort_order          TEXT     DEFAULT 'DESC'
+  p_sort_order          TEXT     DEFAULT 'DESC',
+  p_extra_filter_sql    TEXT     DEFAULT 'TRUE'
 )
 RETURNS TABLE (
   sheet_order INT, sub_service_id INT, sub_service_name TEXT, sheet_name TEXT, headers JSONB, rows JSONB
@@ -219,7 +231,11 @@ STABLE
 AS $$
 DECLARE
   v_exists TEXT := sla_approval_queue_exists_sql(p_approver_user_id);
-  v_own    TEXT := format('sr.user_id != %s', p_approver_user_id);
+  v_own    TEXT := format(
+    '(%s) AND (%s)',
+    format('sr.user_id != %s', p_approver_user_id),
+    COALESCE(NULLIF(trim(p_extra_filter_sql), ''), 'TRUE')
+  );
 BEGIN
   RETURN QUERY
   SELECT * FROM sp_sla_approvals_workbook_excel_export(
@@ -243,6 +259,10 @@ $$;
 -- Per sub-service Requests + Approvals; optional approver_user_id (NULL = all queues)
 -- Does not exclude own requests (unlike user approvals download)
 -- ---------------------------------------------------------------------------
+DROP FUNCTION IF EXISTS sp_sla_admin_approvals_excel_export(
+  INT, INT[], INT[], TEXT[], TEXT[], DATE, DATE, TEXT, TEXT, TEXT
+);
+
 CREATE OR REPLACE FUNCTION sp_sla_admin_approvals_excel_export(
   p_target_approver_user_id INT      DEFAULT NULL,
   p_service_ids             INT[]    DEFAULT NULL,
@@ -253,7 +273,8 @@ CREATE OR REPLACE FUNCTION sp_sla_admin_approvals_excel_export(
   p_to_date                 DATE     DEFAULT NULL,
   p_search_text             TEXT     DEFAULT NULL,
   p_sort_by                 TEXT     DEFAULT 'created_at',
-  p_sort_order              TEXT     DEFAULT 'DESC'
+  p_sort_order              TEXT     DEFAULT 'DESC',
+  p_extra_filter_sql        TEXT     DEFAULT 'TRUE'
 )
 RETURNS TABLE (
   sheet_order INT, sub_service_id INT, sub_service_name TEXT, sheet_name TEXT, headers JSONB, rows JSONB
@@ -263,7 +284,7 @@ STABLE
 AS $$
 DECLARE
   v_exists TEXT := sla_approval_queue_exists_sql_optional(p_target_approver_user_id);
-  v_own    TEXT := 'TRUE';
+  v_own    TEXT := COALESCE(NULLIF(trim(p_extra_filter_sql), ''), 'TRUE');
 BEGIN
   RETURN QUERY
   SELECT * FROM sp_sla_approvals_workbook_excel_export(

package/sql/sla_reports_procedures.sql

@@ -700,6 +700,8 @@ $$;
 -- MY REQUESTS — Excel workbook payload (one result row per sub-service sheet)
 -- Uses vw_sla_my_requests; flattening and dynamic columns are built in the database.
 -- ---------------------------------------------------------------------------
+DROP FUNCTION IF EXISTS sp_sla_my_requests_excel_export(INT, INT[], INT[], TEXT[], DATE, DATE, TEXT, TEXT, TEXT);
+
 CREATE OR REPLACE FUNCTION sp_sla_my_requests_excel_export(
   p_user_id           INT,
   p_service_ids       INT[]    DEFAULT NULL,
@@ -709,7 +711,8 @@ CREATE OR REPLACE FUNCTION sp_sla_my_requests_excel_export(
   p_to_date           DATE     DEFAULT NULL,
   p_search_text       TEXT     DEFAULT NULL,
   p_sort_by           TEXT     DEFAULT 'created_at',
-  p_sort_order        TEXT     DEFAULT 'DESC'
+  p_sort_order        TEXT     DEFAULT 'DESC',
+  p_extra_filter_sql  TEXT     DEFAULT 'TRUE'
 )
 RETURNS TABLE (
   sheet_order         INT,
@@ -739,7 +742,10 @@ DECLARE
   v_all_rows          JSONB;
   v_k                 TEXT;
   v_sheet_order       INT := 0;
+  v_extra             TEXT;
 BEGIN
+  v_extra := COALESCE(NULLIF(trim(p_extra_filter_sql), ''), 'TRUE');
+
   v_sort_col := CASE lower(trim(p_sort_by))
     WHEN 'updated_at'  THEN 'v.created_at'
     WHEN 'id'          THEN 'v.sla_request_id'
@@ -758,6 +764,7 @@ BEGIN
       INNER JOIN sla_requests sr ON sr.id = v.sla_request_id AND COALESCE(sr.is_deleted, false) = false
       LEFT JOIN caa_sub_services subsvc ON subsvc.id = sr.sub_service_id
       WHERE v.user_id = %1$s
+        AND (%2$s)
         AND v.status = ANY($1)
         AND ($2 IS NULL OR cardinality($2) = 0 OR sr.service_id = ANY($2))
         AND ($3 IS NULL OR cardinality($3) = 0 OR sr.sub_service_id = ANY($3))
@@ -765,24 +772,28 @@ BEGIN
         AND ($5 IS NULL OR v.created_at::date <= $5)
         AND ($6 IS NULL OR trim($6) = '' OR CAST(v.request_id AS TEXT) ILIKE '%%' || trim($6) || '%%')
       ORDER BY sub_service_name ASC
-    $q$, p_user_id)
+    $q$, p_user_id, v_extra)
     USING p_statuses, p_service_ids, p_sub_service_ids, p_from_date, p_to_date, p_search_text
   LOOP
     v_sheet_order := v_sheet_order + 1;
 
-    SELECT COALESCE(array_agg(DISTINCT keys.k ORDER BY keys.k), ARRAY[]::TEXT[])
+    EXECUTE format($q$
+      SELECT COALESCE(array_agg(DISTINCT keys.k ORDER BY keys.k), ARRAY[]::TEXT[])
+      FROM vw_sla_my_requests v
+      INNER JOIN sla_requests sr ON sr.id = v.sla_request_id AND COALESCE(sr.is_deleted, false) = false
+      CROSS JOIN LATERAL jsonb_object_keys(COALESCE(v.request_fields, '{}'::jsonb)) AS keys(k)
+      WHERE v.user_id = %1$s
+        AND (%2$s)
+        AND v.status = ANY($1)
+        AND ($2 IS NULL OR cardinality($2) = 0 OR sr.service_id = ANY($2))
+        AND ($3 IS NULL OR cardinality($3) = 0 OR sr.sub_service_id = ANY($3))
+        AND ($4 IS NULL OR v.created_at::date >= $4)
+        AND ($5 IS NULL OR v.created_at::date <= $5)
+        AND ($6 IS NULL OR trim($6) = '' OR CAST(v.request_id AS TEXT) ILIKE '%%' || trim($6) || '%%')
+        AND COALESCE(sr.sub_service_id, 0) = %3$s
+    $q$, p_user_id, v_extra, v_sub.sub_service_id_num)
     INTO v_dyn_keys
-    FROM vw_sla_my_requests v
-    INNER JOIN sla_requests sr ON sr.id = v.sla_request_id AND COALESCE(sr.is_deleted, false) = false
-    CROSS JOIN LATERAL jsonb_object_keys(COALESCE(v.request_fields, '{}'::jsonb)) AS keys(k)
-    WHERE v.user_id = p_user_id
-      AND v.status = ANY(p_statuses)
-      AND (p_service_ids IS NULL OR cardinality(p_service_ids) = 0 OR sr.service_id = ANY(p_service_ids))
-      AND (p_sub_service_ids IS NULL OR cardinality(p_sub_service_ids) = 0 OR sr.sub_service_id = ANY(p_sub_service_ids))
-      AND (p_from_date IS NULL OR v.created_at::date >= p_from_date)
-      AND (p_to_date IS NULL OR v.created_at::date <= p_to_date)
-      AND (p_search_text IS NULL OR trim(p_search_text) = '' OR CAST(v.request_id AS TEXT) ILIKE '%' || trim(p_search_text) || '%')
-      AND COALESCE(sr.sub_service_id, 0) = v_sub.sub_service_id_num;
+    USING p_statuses, p_service_ids, p_sub_service_ids, p_from_date, p_to_date, p_search_text;
 
     v_dyn_labels := ARRAY[]::TEXT[];
     IF v_dyn_keys IS NOT NULL THEN
@@ -815,15 +826,16 @@ BEGIN
         INNER JOIN sla_requests sr ON sr.id = v.sla_request_id AND COALESCE(sr.is_deleted, false) = false
         LEFT JOIN users u ON u.id = v.user_id AND COALESCE(u.is_deleted, false) = false
         WHERE v.user_id = %1$s
+          AND (%2$s)
           AND v.status = ANY($1)
           AND ($2 IS NULL OR cardinality($2) = 0 OR sr.service_id = ANY($2))
           AND ($3 IS NULL OR cardinality($3) = 0 OR sr.sub_service_id = ANY($3))
           AND ($4 IS NULL OR v.created_at::date >= $4)
           AND ($5 IS NULL OR v.created_at::date <= $5)
           AND ($6 IS NULL OR trim($6) = '' OR CAST(v.request_id AS TEXT) ILIKE '%%' || trim($6) || '%%')
-          AND COALESCE(sr.sub_service_id, 0) = %2$s
-        ORDER BY %3$s %4$s, v.sla_request_id ASC
-      $q$, p_user_id, v_sub.sub_service_id_num, v_sort_col, v_sort_dir)
+          AND COALESCE(sr.sub_service_id, 0) = %3$s
+        ORDER BY %4$s %5$s, v.sla_request_id ASC
+      $q$, p_user_id, v_extra, v_sub.sub_service_id_num, v_sort_col, v_sort_dir)
       USING p_statuses, p_service_ids, p_sub_service_ids, p_from_date, p_to_date, p_search_text
     LOOP
       v_cells := ARRAY[
@@ -859,7 +871,7 @@ BEGIN
   RETURN QUERY
   SELECT *
   FROM sla_my_requests_approvals_excel_sheet(
-    format('v.user_id = %s', p_user_id),
+    format('v.user_id = %s AND (%s)', p_user_id, v_extra),
     p_statuses,
     p_service_ids,
     p_sub_service_ids,

package/src/models/DepartmentsModel.ts

@@ -16,6 +16,9 @@ export class Departments extends BaseModel {
     @Column({ nullable: false })
     department_description: string;
 
+    @Column({ type: 'integer', nullable: true, name: 'DG_department_id' })
+    DG_department_id: number | null;
+
     constructor(     
         department_name: string,
         department_code: string,