@planu/cli 5.3.3 → 5.3.5

package/dist/tools/update-status/evidence-gate.js

@@ -68,7 +68,7 @@ import { captureValidationFreshnessLease } from '../../engine/validation/validat
 import { computeDurableValidationBindings, toValidationReceiptBindings, } from '../../engine/validation/durable-validation.js';
 import { checkReconciliationFreshness } from '../../engine/evidence-gates/reconciliation-freshness.js';
 import { extractCanonicalFileOwnership } from '../../engine/handoff-packager.js';
-import { generateDiscoverySkeleton, generateTaskPlanSkeleton, writeEvidenceSkeleton, } from '../../engine/evidence-gates/evidence-skeletons.js';
+import { generateTaskPlanSkeleton, writeEvidenceSkeleton, } from '../../engine/evidence-gates/evidence-skeletons.js';
 import { extractSection } from '../../engine/spec-format/markdown-sections.js';
 const CANONICAL_SCOPE_PATH = /(?:src|tests|scripts|website)\/[\w/.@-]+\.\w+/g;
 /** SPEC-1356: repo-relative paths mentioned in the spec's Problem/Technical prose also count
@@ -187,28 +187,21 @@ function isArtifactAbsent(artifacts, label) {
     return !artifacts.invalidArtifacts.some((entry) => entry.startsWith(label));
 }
 /**
- * SPEC-1356: self-heal missing (not malformed) discovery/task-plan handoff evidence by
- * generating a schema-valid skeleton and persisting it, instead of blocking the transition
- * on a manual authoring step. Malformed existing artifacts still fail the gate as before.
+ * SPEC-1356: self-heal missing (not malformed) task-plan handoff evidence by generating a
+ * schema-valid skeleton and persisting it, instead of blocking the transition on a manual
+ * authoring step. Malformed existing artifacts still fail the gate as before.
+ *
+ * SPEC-1406 (DEFECT 3): discovery evidence for `approved` is intentionally NOT self-healed —
+ * writing a skeleton here made the blocking discovery gate self-certify by fabricating the
+ * evidence it was supposed to require. `checkLifecycleEvidenceGate` (lifecycle-gate.ts) reports
+ * `discovery_missing` with the specific missing fields named when discovery is absent, and that
+ * is the intended, honest outcome.
  */
 async function autofillMissingEvidenceSkeletons(args) {
     if (args.spec.scope === 'trivial') {
         return args.artifacts;
     }
     let artifacts = args.artifacts;
-    if (args.transition === 'approved' &&
-        !artifacts.discovery &&
-        isArtifactAbsent(artifacts, 'Discovery evidence')) {
-        const skeleton = generateDiscoverySkeleton({ spec: args.spec, body: args.body });
-        await writeEvidenceSkeleton({
-            projectId: args.projectId,
-            specId: args.specId,
-            filename: 'discovery.json',
-            artifact: skeleton,
-        });
-        console.warn('[planu:evidence-skeleton]', { specId: args.specId, filename: 'discovery.json' });
-        artifacts = { ...artifacts, discovery: skeleton };
-    }
     if (args.transition === 'implementing' &&
         !artifacts.taskPlan &&
         isArtifactAbsent(artifacts, 'Task plan evidence')) {

package/dist/tools/update-status/transition-guard.js

@@ -7,7 +7,7 @@ import { scoreAmbiguityFromPath } from '../../engine/ambiguity-scorer.js';
 import { checkSpecReadiness } from '../../engine/readiness-checker.js';
 import { validateEnglishOnlySpecText } from '../../engine/spec-language/english-only.js';
 import { checkGroundedSpecContract } from '../../engine/spec-grounding/contract.js';
-import { checkGenericSpecOutput } from '../../engine/spec-quality/generic-output-gate.js';
+import { checkGenericSpecOutput, STRUCTURAL_INTERPOLATION_KIND, } from '../../engine/spec-quality/generic-output-gate.js';
 import { formatKeyValue } from '../output-formatter.js';
 import { getResolvedChallengeEvidence, requiredResolvedChallenges, } from '../challenge-spec/challenge-report.js';
 import { evaluateSpecDependencies } from '../../engine/dependency-evaluator.js';
@@ -319,14 +319,22 @@ export async function checkReadinessGate(spec, newStatus, forceApprove) {
         };
     }
     const genericOutputGate = checkGenericSpecOutput(body);
-    if (!genericOutputGate.passed) {
+    // SPEC-1406: structural-interpolation findings warn instead of block here — the
+    // `create_spec` call site is where this new detector is blocking; ~1100 already-persisted
+    // specs must stay transitionable at update_status even if their rendered body still
+    // contains an interpolated-list pattern.
+    const blockingGenericOutputIssues = genericOutputGate.issues.filter((issue) => issue.kind !== STRUCTURAL_INTERPOLATION_KIND);
+    const structuralInterpolationWarnings = genericOutputGate.issues
+        .filter((issue) => issue.kind === STRUCTURAL_INTERPOLATION_KIND)
+        .map((issue) => `${issue.phrase}: ${issue.reason}`);
+    if (blockingGenericOutputIssues.length > 0) {
         return {
             blockResult: {
                 content: [
                     {
                         type: 'text',
                         text: `Spec quality gate blocked transition to ${newStatus}. ` +
-                            genericOutputGate.issues
+                            blockingGenericOutputIssues
                                 .slice(0, 3)
                                 .map((issue) => `${issue.phrase}: ${issue.reason}`)
                                 .join('; '),
@@ -336,11 +344,15 @@ export async function checkReadinessGate(spec, newStatus, forceApprove) {
                 structuredContent: {
                     error: 'GENERIC_SPEC_OUTPUT_BLOCKED',
                     sddConstitutionRuleId: 'sdd.no-generic-output',
-                    issues: genericOutputGate.issues,
+                    issues: blockingGenericOutputIssues,
                     fixHint: 'Replace generic criteria or placeholder references with grounded, testable behavior before review or approval.',
                 },
             },
-            qualityWarnings: [],
+            // SPEC-1406 (AC3, round 2): the offending section must be named in the output on
+            // every return path, not only the success path — this blockResult already fired
+            // for a different reason, but any structural-interpolation warnings computed above
+            // are still real findings and must not be dropped.
+            qualityWarnings: structuralInterpolationWarnings,
         };
     }
     let readiness;
@@ -350,7 +362,7 @@ export async function checkReadinessGate(spec, newStatus, forceApprove) {
     catch (error) {
         /* reliability-optional: READINESS_EVALUATION_FAILED — transition fails closed below */
         reportClassifiedDegradation('READINESS_EVALUATION_FAILED', error);
-        return readinessUnavailable('READINESS_EVALUATION_FAILED', error instanceof Error ? error.message : 'readiness evaluation failed');
+        return readinessUnavailable('READINESS_EVALUATION_FAILED', error instanceof Error ? error.message : 'readiness evaluation failed', structuralInterpolationWarnings);
     }
     const { score } = readiness;
     const blockers = [...readiness.issues.blockers];
@@ -377,7 +389,7 @@ export async function checkReadinessGate(spec, newStatus, forceApprove) {
                         fixHint: 'Add at least 3 testable acceptance criteria before moving to review.',
                     },
                 },
-                qualityWarnings: [],
+                qualityWarnings: structuralInterpolationWarnings,
             };
         }
         const question = {
@@ -412,11 +424,11 @@ export async function checkReadinessGate(spec, newStatus, forceApprove) {
                     interactiveQuestions: [question],
                 },
             },
-            qualityWarnings: [],
+            qualityWarnings: structuralInterpolationWarnings,
         };
     }
     if (readiness.ready) {
-        return { blockResult: null, qualityWarnings: [] };
+        return { blockResult: null, qualityWarnings: structuralInterpolationWarnings };
     }
     const diagnostic = score < 70
         ? `score ${String(score)}/100 is below the 70 threshold`
@@ -442,13 +454,13 @@ export async function checkReadinessGate(spec, newStatus, forceApprove) {
                     fixHint: 'Complete the spec before moving from draft to review.',
                 },
             },
-            qualityWarnings: [],
+            qualityWarnings: structuralInterpolationWarnings,
         };
     }
     // Score < 70
     if (forceApprove) {
         // Caller wants to force through — proceed with warnings attached
-        return { blockResult: null, qualityWarnings: issues };
+        return { blockResult: null, qualityWarnings: [...issues, ...structuralInterpolationWarnings] };
     }
     const question = {
         header: 'Readiness gate',
@@ -486,7 +498,7 @@ export async function checkReadinessGate(spec, newStatus, forceApprove) {
                 interactiveQuestions: [question],
             },
         },
-        qualityWarnings: [],
+        qualityWarnings: structuralInterpolationWarnings,
     };
 }
 function gateUnavailableResult(code, message) {
@@ -496,8 +508,8 @@ function gateUnavailableResult(code, message) {
         structuredContent: { error: code, message, retryable: true },
     };
 }
-function readinessUnavailable(code, message) {
-    return { blockResult: gateUnavailableResult(code, message), qualityWarnings: [] };
+function readinessUnavailable(code, message, qualityWarnings = []) {
+    return { blockResult: gateUnavailableResult(code, message), qualityWarnings };
 }
 /**
  * SPEC-964: Challenge gate — block 'review' if challenge_spec was never run

package/dist/types/reconcile.d.ts

@@ -1,58 +1,46 @@
-/**
- * Sections whose values do not appear as literal text in spec.md body —
- * applied/verified at the metadata layer, never via string-replace.
- * Shared by apply-changes.ts (skip) and verify-write.ts (skip).
- */
-export declare const RECONCILE_METADATA_SECTIONS: ReadonlySet<string>;
-/** A single failed post-write verification entry (Bug D). */
+export declare const SECTIONS_WITHOUT_LITERAL_BODY_TEXT: ReadonlySet<string>;
 export interface VerifyWriteFailure {
     section: string;
     newValue: string;
     reason: string;
 }
-/** Result of verifyWriteSucceeded (Bug D). */
 export interface VerifyWriteResult {
     verified: boolean;
     missingChanges: VerifyWriteFailure[];
 }
-/** A change that could not be applied to spec.md body (Bug D). */
 export interface SkippedChange {
     section: string;
     originalValue: string;
     reason: string;
+    reasonCategory: 'skipped' | 'ambiguous';
 }
-/** Result of applyChangesToSpec (Bug D). */
 export interface ApplyChangesResult {
     applied: number;
     skipped: SkippedChange[];
     fileWritten: boolean;
 }
-/** Body bounds of a markdown section, used by apply-changes' anchoring. */
+export interface ApplyChangesToSpecFilesResult {
+    auditWritten: boolean;
+}
 export interface SectionBounds {
     start: number;
     end: number;
 }
-/** Parsed snapshot of status.json used by status-reconciler (Bug G). */
 export interface CurrentStatus {
     totalSpecs: number;
     content: Record<string, unknown>;
-    /** True when status.json exists; false when missing (ENOENT). */
     exists: boolean;
-    /** True when status.json existed but could not be parsed/read for non-ENOENT reasons. */
     corrupt: boolean;
 }
-/** Result of reconcileStatusFromDisk (Bug G). */
 export interface StatusReconcileResult {
     reconciled: boolean;
     before: number;
     after: number;
 }
 import type { ProjectKnowledge } from './project/core.js';
-/** Result when a project was resolved via resolveProjectFromPath (Bug F). */
 export interface ResolvedProject {
     projectId: string;
     knowledge: ProjectKnowledge;
-    /** True when knowledge was recovered from disk fingerprint. */
     recovered: boolean;
 }
 //# sourceMappingURL=reconcile.d.ts.map

package/dist/types/reconcile.js

@@ -1,10 +1,4 @@
-// types/reconcile.ts — SPEC-1011: Types for reconcile engine modules
-/**
- * Sections whose values do not appear as literal text in spec.md body —
- * applied/verified at the metadata layer, never via string-replace.
- * Shared by apply-changes.ts (skip) and verify-write.ts (skip).
- */
-export const RECONCILE_METADATA_SECTIONS = new Set([
+export const SECTIONS_WITHOUT_LITERAL_BODY_TEXT = new Set([
     'estimation',
     'cost',
     'status',

package/dist/types/spec-quality.d.ts

@@ -35,7 +35,12 @@ export interface SpecQualityReport {
         risk: QualityDimensionDetail;
     };
 }
-export type GenericSpecOutputIssueKind = 'generic-criterion' | 'unsupported-verification' | 'placeholder-reference' | 'generic-technical-reference';
+export type GenericSpecOutputIssueKind = 'generic-criterion' | 'unsupported-verification' | 'placeholder-reference' | 'generic-technical-reference'
+/** SPEC-1406: dedicated kind for structural-interpolation findings (checkInterpolatedSections).
+ * Kept distinct from 'generic-technical-reference' — severity routing in transition-guard.ts
+ * and sdd-rules-registry.ts filters BY KIND, so aliasing the two would silently downgrade
+ * whichever kind collides the day something else emits the shared value. */
+ | 'structural-interpolation';
 export interface GenericSpecOutputIssue {
     kind: GenericSpecOutputIssueKind;
     phrase: string;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@planu/cli",
-  "version": "5.3.3",
+  "version": "5.3.5",
   "description": "Planu — MCP Server for Spec Driven Development with native Rust acceleration for hot paths. Cross-platform (Linux/macOS/Windows, x64/arm64, glibc/musl).",
   "type": "module",
   "main": "dist/index.js",
@@ -35,14 +35,14 @@
     "packageName": "@planu/core"
   },
   "optionalDependencies": {
-    "@planu/core-darwin-arm64": "5.3.3",
-    "@planu/core-darwin-x64": "5.3.3",
-    "@planu/core-linux-arm64-gnu": "5.3.3",
-    "@planu/core-linux-arm64-musl": "5.3.3",
-    "@planu/core-linux-x64-gnu": "5.3.3",
-    "@planu/core-linux-x64-musl": "5.3.3",
-    "@planu/core-win32-arm64-msvc": "5.3.3",
-    "@planu/core-win32-x64-msvc": "5.3.3"
+    "@planu/core-darwin-arm64": "5.3.5",
+    "@planu/core-darwin-x64": "5.3.5",
+    "@planu/core-linux-arm64-gnu": "5.3.5",
+    "@planu/core-linux-arm64-musl": "5.3.5",
+    "@planu/core-linux-x64-gnu": "5.3.5",
+    "@planu/core-linux-x64-musl": "5.3.5",
+    "@planu/core-win32-arm64-msvc": "5.3.5",
+    "@planu/core-win32-x64-msvc": "5.3.5"
   },
   "engines": {
     "node": ">=24.0.0"

package/planu-native.json

@@ -1,7 +1,7 @@
 {
   "name": "dev.planu.native",
   "displayName": "Planu Native Lightweight Surface",
-  "version": "5.3.3",
+  "version": "5.3.5",
   "packageName": "@planu/cli",
   "modes": {
     "lightweight": {

package/planu-plugin.json

@@ -2,7 +2,7 @@
   "name": "dev.planu.cli",
   "displayName": "Planu — Spec Driven Development",
   "description": "Manage software specs, estimations, and autonomous SDD workflows. Language-agnostic MCP server for Claude Code.",
-  "version": "5.3.3",
+  "version": "5.3.5",
   "icon": "assets/plugin/icon.svg",
   "command": ["npx", "@planu/cli@latest"],
   "packageName": "@planu/cli",