@plannotator/pi-extension 0.27.10 → 0.27.11

package/server/serverReview.ts

@@ -6,7 +6,8 @@ import { basename, resolve as resolvePath } from "node:path";
 
 import { SingleFlight } from "../generated/single-flight.ts";
 import { contentHash, deleteDraft } from "../generated/draft.ts";
-import { loadConfig, saveConfig, detectGitUser, getServerConfig, parseReviewAnalysisConfig, resolveAIEnabled, resolveSharingEnabled, resolveCursorSandbox, resolveGuideHistory, resolveGuideShareUrl } from "../generated/config.ts";
+import { loadConfig, saveConfig, detectGitUser, getServerConfig, parseReviewAnalysisConfig, resolveAIEnabled, resolveSharingEnabled, resolveCursorSandbox, resolveFeedbackHistory, resolveGuideHistory, resolveGuideShareUrl } from "../generated/config.ts";
+import { appendFeedbackRecord, countChangedFiles, deriveFeedbackProject, type FeedbackDecision, type FeedbackReviewTarget } from "../generated/feedback-archive.ts";
 import { isFaviconStyle, type FaviconStyle } from "../generated/favicon.ts";
 
 export type {
@@ -295,6 +296,15 @@ export async function startReviewServer(options: {
 	 * once a pool checkout is ready.
 	 */
 	prPatchIncomplete?: boolean;
+	/**
+	 * Detected project name, used to key the durable feedback archive
+	 * (`feedback/{project}/`). Mirrors the annotate server's `project` option.
+	 * Callers should pass `detectProjectName()`; without it the server falls
+	 * back to deriving a name from the review's working directory, which is
+	 * wrong in PR mode (no `gitContext`, and `--local` points `agentCwd` at a
+	 * `pool/pr-<n>` checkout, so records would bucket under `pr-123`).
+	 */
+	project?: string;
 	/** Working directory for agent processes (e.g., --local worktree). Independent of diff pipeline. */
 	agentCwd?: string;
 	/** Local parent directory containing multiple child VCS repositories. */
@@ -828,6 +838,77 @@ export async function startReviewServer(options: {
 		return `${draftKey}:${currentDiffType}${isPRMode ? `:${currentPRDiffScope}` : ""}${currentContextRevision ? `:${currentContextRevision}` : ""}`;
 	}
 
+	// --- Durable feedback archive (Node mirror of packages/server/review.ts) ---
+	//
+	// Code review persisted nothing on submit: the draft was deleted, the
+	// decision promise settled, and a timed-out agent meant the review existed
+	// nowhere. Every submission now appends one record to
+	// feedback/{project}/index.jsonl BEFORE the draft is deleted, carrying diff
+	// IDENTITY (refs, view, snapshot id, size) but never the patch bytes.
+	// Project bucketing: prefer the caller's detected project name. The cwd
+	// fallback is only right for a plain local review — PR mode has no
+	// gitContext, and `--local` sets agentCwd to a `pool/pr-<n>` checkout, so
+	// deriving from cwd there would file every PR review under `pr-123`.
+	//
+	// Known limitation, deliberately not chased here: a caller that passes no
+	// project AND reviews a moved/renamed working directory buckets under the
+	// new directory name, exactly like the rest of the data dir does.
+	const feedbackProject = (): string =>
+		options.project?.trim()
+			? options.project
+			: deriveFeedbackProject(options.gitContext?.cwd ?? options.agentCwd ?? process.cwd());
+
+	const feedbackReviewTarget = (): FeedbackReviewTarget => {
+		const target: FeedbackReviewTarget = {
+			diffType: String(currentDiffType),
+			base: currentBase,
+			gitRef: currentGitRef,
+			snapshotId: currentSnapshotId(),
+			changedFiles: countChangedFiles(currentPatch),
+			patchBytes: currentPatch.length,
+		};
+		if (sessionVcsType) target.vcsType = sessionVcsType;
+		else if (workspace) target.vcsType = "workspace";
+		const cwd = options.gitContext?.cwd ?? options.agentCwd;
+		if (cwd) target.cwd = cwd;
+		if (prMeta) {
+			target.pr = {
+				provider: prMeta.platform,
+				repo:
+					prMeta.platform === "github"
+						? `${prMeta.owner}/${prMeta.repo}`
+						: prMeta.projectPath,
+				number: prMeta.platform === "github" ? prMeta.number : prMeta.iid,
+			};
+		}
+		return target;
+	};
+
+	/**
+	 * Returns whether the draft delete may proceed: false only when a durable
+	 * write was expected and failed, so the draft stays as the recovery copy.
+	 */
+	const archiveReviewSubmission = (
+		feedback: unknown,
+		annotations: unknown,
+		decision: FeedbackDecision,
+	): boolean => {
+		if (!resolveFeedbackHistory(loadConfig())) return true;
+		const feedbackText = typeof feedback === "string" ? feedback : "";
+		const annotationList = Array.isArray(annotations) ? annotations : [];
+		const hasContent = feedbackText.trim().length > 0 || annotationList.length > 0;
+		const written = appendFeedbackRecord({
+			project: feedbackProject(),
+			origin: options.origin ?? "pi",
+			surface: "review",
+			decision,
+			target: { review: feedbackReviewTarget() },
+			feedback: feedbackText,
+			annotations: annotationList,
+		});
+		return written !== null || !hasContent;
+	};
+
 	function buildCurrentAiReviewContext(
 		patch: string = currentPatch,
 		base: string = currentBase,
@@ -3269,17 +3350,35 @@ export async function startReviewServer(options: {
 			handleApiNotFound(res, url.pathname);
 			return;
 		} else if (url.pathname === "/api/exit" && req.method === "POST") {
+			// Decision-only line: dismissal rate is behavior data, and a
+			// contentless failure must not change the legacy draft behavior.
+			archiveReviewSubmission("", [], "dismissed");
 			deleteDraft(draftKey, readDraftGenerationFromUrl(req));
 			resolveDecision({ approved: false, feedback: '', annotations: [], exit: true });
 			json(res, { ok: true });
 		} else if (url.pathname === "/api/feedback" && req.method === "POST") {
 			try {
 				const body = await parseBody(req);
-				deleteDraft(draftKey, readDraftGenerationFromBody(body));
+				// Archive BEFORE the draft delete: a failed write keeps the
+				// draft as the reviewer's recovery copy (#678 ordering).
+				// Defensive on the body's own types: a malformed value must
+				// degrade to the legacy behavior (settle + 200), never throw.
+				const approved = (body.approved as boolean) ?? false;
+				const feedbackText = (body.feedback as string) || "";
+				const annotationList = (body.annotations as unknown[]) || [];
+				const hasContent =
+					(typeof feedbackText === "string" && feedbackText.trim().length > 0) ||
+					(Array.isArray(annotationList) && annotationList.length > 0);
+				const durable = archiveReviewSubmission(
+					feedbackText,
+					annotationList,
+					approved ? (hasContent ? "approved-with-notes" : "lgtm") : "feedback",
+				);
+				if (durable) deleteDraft(draftKey, readDraftGenerationFromBody(body));
 				resolveDecision({
-					approved: (body.approved as boolean) ?? false,
-					feedback: (body.feedback as string) || "",
-					annotations: (body.annotations as unknown[]) || [],
+					approved,
+					feedback: feedbackText,
+					annotations: annotationList,
 					agentSwitch: body.agentSwitch as string | undefined,
 				});
 				json(res, { ok: true });