@plannotator/pi-extension 0.16.5 → 0.16.6

package/server/serverPlan.ts

@@ -1,3 +1,4 @@
+import { randomUUID } from "node:crypto";
 import { createServer } from "node:http";
 
 import { contentHash, deleteDraft } from "../generated/draft.js";
@@ -45,11 +46,21 @@ import {
 	handleObsidianVaultsRequest,
 } from "./reference.js";
 
+export interface PlanReviewDecision {
+	approved: boolean;
+	feedback?: string;
+	savedPath?: string;
+	agentSwitch?: string;
+	permissionMode?: string;
+}
+
 export interface PlanServerResult {
+	reviewId: string;
 	port: number;
 	portSource: "env" | "remote-default" | "random";
 	url: string;
-	waitForDecision: () => Promise<{ approved: boolean; feedback?: string; savedPath?: string; agentSwitch?: string; permissionMode?: string }>;
+	waitForDecision: () => Promise<PlanReviewDecision>;
+	onDecision: (listener: (result: PlanReviewDecision) => void | Promise<void>) => () => void;
 	waitForDone?: () => Promise<void>;
 	stop: () => void;
 }
@@ -114,22 +125,24 @@ export async function startPlanReviewServer(options: {
 				}
 			: null;
 
-	let resolveDecision!: (result: {
-		approved: boolean;
-		feedback?: string;
-		savedPath?: string;
-		agentSwitch?: string;
-		permissionMode?: string;
-	}) => void;
-	const decisionPromise = new Promise<{
-		approved: boolean;
-		feedback?: string;
-		savedPath?: string;
-		agentSwitch?: string;
-		permissionMode?: string;
-	}>((r) => {
+	const reviewId = randomUUID();
+	let resolveDecision!: (result: PlanReviewDecision) => void;
+	const decisionListeners = new Set<(result: PlanReviewDecision) => void | Promise<void>>();
+	let decisionSettled = false;
+	const decisionPromise = new Promise<PlanReviewDecision>((r) => {
 		resolveDecision = r;
 	});
+	const publishDecision = (result: PlanReviewDecision): boolean => {
+		if (decisionSettled) return false;
+		decisionSettled = true;
+		resolveDecision(result);
+		for (const listener of decisionListeners) {
+			Promise.resolve(listener(result)).catch((error) => {
+				console.error("[Plan Review] Decision listener failed:", error);
+			});
+		}
+		return true;
+	};
 
 	// Draft key for annotation persistence
 	const draftKey = options.mode !== "archive" ? contentHash(options.plan) : "";
@@ -324,6 +337,10 @@ export async function startPlanReviewServer(options: {
 			}
 			json(res, { ok: true, results });
 		} else if (url.pathname === "/api/approve" && req.method === "POST") {
+			if (decisionSettled) {
+				json(res, { ok: true, duplicate: true });
+				return;
+			}
 			let feedback: string | undefined;
 			let agentSwitch: string | undefined;
 			let requestedPermissionMode: string | undefined;
@@ -390,7 +407,7 @@ export async function startPlanReviewServer(options: {
 			}
 			deleteDraft(draftKey);
 			const effectivePermissionMode = requestedPermissionMode || options.permissionMode;
-			resolveDecision({
+			publishDecision({
 				approved: true,
 				feedback,
 				savedPath,
@@ -399,6 +416,10 @@ export async function startPlanReviewServer(options: {
 			});
 			json(res, { ok: true, savedPath });
 		} else if (url.pathname === "/api/deny" && req.method === "POST") {
+			if (decisionSettled) {
+				json(res, { ok: true, duplicate: true });
+				return;
+			}
 			let feedback = "Plan rejected by user";
 			let planSaveEnabled = true;
 			let planSaveCustomPath: string | undefined;
@@ -425,7 +446,7 @@ export async function startPlanReviewServer(options: {
 				);
 			}
 			deleteDraft(draftKey);
-			resolveDecision({ approved: false, feedback, savedPath });
+			publishDecision({ approved: false, feedback, savedPath });
 			json(res, { ok: true, savedPath });
 		} else {
 			html(res, options.htmlContent);
@@ -435,10 +456,17 @@ export async function startPlanReviewServer(options: {
 	const { port, portSource } = await listenOnPort(server);
 
 	return {
+		reviewId,
 		port,
 		portSource,
 		url: `http://localhost:${port}`,
 		waitForDecision: () => decisionPromise,
+		onDecision: (listener) => {
+			decisionListeners.add(listener);
+			return () => {
+				decisionListeners.delete(listener);
+			};
+		},
 		...(donePromise && { waitForDone: () => donePromise }),
 		stop: () => server.close(),
 	};

package/server/serverReview.ts

@@ -95,8 +95,8 @@ const reviewRuntime: ReviewGitRuntime = {
 	},
 };
 
-export function getGitContext(): Promise<GitContext> {
-	return getGitContextCore(reviewRuntime);
+export function getGitContext(cwd?: string): Promise<GitContext> {
+	return getGitContextCore(reviewRuntime, cwd);
 }
 
 export function runGitDiff(