@planningo/duul 1.0.0 → 1.1.0

package/build/tools/code-review.js

@@ -1,8 +1,8 @@
 import { CodeReviewInputSchema, CodeReviewOutputSchema, CodeReviewMcpOutputSchema, } from '../schemas/code-review.js';
 import { getCodeReviewSystemPrompt, formatCodeReviewUserMessage } from '../prompts/code-review-system.js';
 import { callReview } from '../services/reviewer.js';
-import { resolveWorkspaceScope, getGitDiff } from '../services/filesystem.js';
-import { computeIterationMeta, isIterationLimitExceeded } from '../services/review-limits.js';
+import { resolveWorkspaceScope, getGitDiff, resolveInlineOrFile } from '../services/filesystem.js';
+import { computeIterationMeta, isIterationLimitExceeded, computeCostWarning } from '../services/review-limits.js';
 import { logUsage } from '../services/usage-logger.js';
 import { applyGates } from '../services/review-gates.js';
 const MAX_INLINE_DIFF_CHARS = 50_000;
@@ -10,14 +10,55 @@ const ZERO_USAGE = { input_tokens: 0, output_tokens: 0, total_tokens: 0, api_cal
 export function registerCodeReviewTool(server) {
     server.registerTool('request_code_review', {
         title: 'DUUL Code Review (Strict QA)',
-        description: 'DUUL Phase 2: Submit code for review by an LLM acting as a Strict QA Engineer. ' +
-            'Requires the approved plan for context. Returns blocking issues, vulnerabilities, ' +
-            'and optionally an optimized code snippet, or approval.',
+        description: 'DUUL Phase 2: Submit code for strict QA review. ' +
+            'Provide the code EITHER inline via `code` OR (preferred for large content) via `code_file`, and the ' +
+            'Phase 1 plan EITHER inline via `approved_plan` OR via `approved_plan_file` (relative paths, e.g. ".duul/code.md" / ".duul/plan.md") plus `workspace_root`. ' +
+            'Exactly one of code/code_file and one of approved_plan/approved_plan_file are required. ' +
+            'Optional: workspace_root, file_path, changed_files, artifact_refs, previous_review_id, iteration_count. ' +
+            'Returns blocking issues, vulnerabilities, optimized snippet, or APPROVE verdict.',
         inputSchema: CodeReviewInputSchema,
         outputSchema: CodeReviewMcpOutputSchema,
     }, async (input) => {
         try {
             const args = input;
+            const scope = resolveWorkspaceScope(args);
+            // Resolve code and approved_plan from inline values or *_file escape hatches.
+            let codeText;
+            let approvedPlanText;
+            try {
+                codeText = await resolveInlineOrFile({ inline: args.code, file: args.code_file, scope, label: 'code' });
+                approvedPlanText = await resolveInlineOrFile({
+                    inline: args.approved_plan,
+                    file: args.approved_plan_file,
+                    scope,
+                    label: 'approved_plan',
+                });
+            }
+            catch (readErr) {
+                const reason = readErr instanceof Error ? readErr.message : String(readErr);
+                console.error(`[duul] code-review file read failed: ${reason}`);
+                return {
+                    content: [{ type: 'text', text: `ERROR: could not read a *_file argument. ${reason}` }],
+                    isError: true,
+                };
+            }
+            if (typeof codeText !== 'string' ||
+                codeText.trim().length < 5 ||
+                typeof approvedPlanText !== 'string' ||
+                approvedPlanText.trim().length < 20) {
+                const message = 'ERROR: `code` and `approved_plan` are both required. ' +
+                    '`code` must contain the actual code being reviewed (min 5 chars). ' +
+                    '`approved_plan` must contain the full plan text approved in Phase 1 (min 20 chars). ' +
+                    'You called request_code_review without usable content. ' +
+                    'Inline them — { "code": "<your code>", "approved_plan": "<plan text>", ... } — or, for large content, ' +
+                    'write each to a file and pass { "code_file": ".duul/code.md", "approved_plan_file": ".duul/plan.md", "workspace_root": "<absolute path>" }. ' +
+                    'Do NOT call this tool again with an empty input.';
+                console.error(`[duul] code-review rejected: missing/empty code or approved_plan content`);
+                return {
+                    content: [{ type: 'text', text: message }],
+                    isError: true,
+                };
+            }
             const iterMeta = computeIterationMeta('code', args.iteration_count, args.max_review_iterations);
             // Short-circuit if iteration limit exceeded
             if (isIterationLimitExceeded('code', args.iteration_count, args.max_review_iterations)) {
@@ -44,6 +85,7 @@ export function registerCodeReviewTool(server) {
                     gates_tripped: null,
                     review_id: '',
                     ...iterMeta,
+                    cost_warning: null,
                     token_usage: ZERO_USAGE,
                 };
                 return {
@@ -51,7 +93,6 @@ export function registerCodeReviewTool(server) {
                     structuredContent: limitResult,
                 };
             }
-            const scope = resolveWorkspaceScope(args);
             // Auto-generate git diff if not provided
             let gitDiff = args.git_diff;
             if (!gitDiff && scope?.root && args.changed_files?.length) {
@@ -68,7 +109,7 @@ export function registerCodeReviewTool(server) {
                 }
             }
             const systemPrompt = getCodeReviewSystemPrompt();
-            const userMessage = formatCodeReviewUserMessage(args.code, args.approved_plan, args.file_path, args.dependencies, args.relevant_code, args.notes_to_reviewer, {
+            const userMessage = formatCodeReviewUserMessage(codeText, approvedPlanText, args.file_path, args.dependencies, args.relevant_code, args.notes_to_reviewer, {
                 workingDirectories: args.working_directories,
                 linkedRoots: args.linked_roots,
                 changedFiles: args.changed_files,
@@ -89,6 +130,7 @@ export function registerCodeReviewTool(server) {
                 outputSchema: CodeReviewOutputSchema,
                 workspaceScope: scope,
                 previousReviewId: args.previous_review_id,
+                toolName: 'code',
                 reviewerConfig: args.reviewer_config,
                 createFallback: (reason, usedTools) => ({
                     verdict: 'REVISE',
@@ -147,6 +189,7 @@ export function registerCodeReviewTool(server) {
                 gates_tripped: gates.tripped.length > 0 ? gates.tripped : null,
                 review_id: reviewId,
                 ...iterMeta,
+                cost_warning: computeCostWarning(iterMeta, usage.estimated_cost_usd),
                 token_usage: usage,
             };
             logUsage('code_review', result.token_usage, {

package/build/tools/execution-partition.js

@@ -1,21 +1,59 @@
 import { ExecutionPartitionInputSchema, ExecutionPartitionOutputSchema, ExecutionPartitionMcpOutputSchema, } from '../schemas/execution-partition.js';
 import { getExecutionPartitionSystemPrompt, formatExecutionPartitionUserMessage } from '../prompts/execution-partition-system.js';
 import { callReview } from '../services/reviewer.js';
-import { resolveWorkspaceScope } from '../services/filesystem.js';
-import { computeIterationMeta, isIterationLimitExceeded } from '../services/review-limits.js';
+import { resolveWorkspaceScope, resolveInlineOrFile } from '../services/filesystem.js';
+import { computeIterationMeta, isIterationLimitExceeded, computeCostWarning } from '../services/review-limits.js';
 import { logUsage } from '../services/usage-logger.js';
 const ZERO_USAGE = { input_tokens: 0, output_tokens: 0, total_tokens: 0, api_calls: 0, provider: 'none', model: 'none', estimated_cost_usd: null };
 export function registerExecutionPartitionTool(server) {
     server.registerTool('request_execution_partition', {
         title: 'DUUL Execution Partition (Project Manager)',
-        description: 'DUUL optional: Partition an approved plan into executable subtasks with dependency graph, ' +
-            'spawn strategy, and handoff contracts. Use after plan review approval to ' +
-            'determine whether work can be parallelized across multiple agents/workspaces.',
+        description: 'DUUL optional: Partition an approved plan into executable subtasks. ' +
+            'Provide the plan EITHER inline via `approved_plan` OR (preferred for large plans) via `approved_plan_file` ' +
+            '(relative path, e.g. ".duul/plan.md"). `workspace_root` (absolute path) is required. ' +
+            'Exactly one of approved_plan/approved_plan_file is required. ' +
+            'Optional: working_directories, changed_files, entrypoints, artifact_refs, max_parallelism, iteration_count. ' +
+            'Returns dependency graph, spawn strategy, and handoff contracts.',
         inputSchema: ExecutionPartitionInputSchema,
         outputSchema: ExecutionPartitionMcpOutputSchema,
     }, async (input) => {
         try {
             const args = input;
+            const scope = resolveWorkspaceScope(args);
+            // Resolve approved_plan from inline value or approved_plan_file escape hatch.
+            let approvedPlanText;
+            try {
+                approvedPlanText = await resolveInlineOrFile({
+                    inline: args.approved_plan,
+                    file: args.approved_plan_file,
+                    scope,
+                    label: 'approved_plan',
+                });
+            }
+            catch (readErr) {
+                const reason = readErr instanceof Error ? readErr.message : String(readErr);
+                console.error(`[duul] execution-partition approved_plan_file read failed: ${reason}`);
+                return {
+                    content: [{ type: 'text', text: `ERROR: could not read approved_plan_file. ${reason}` }],
+                    isError: true,
+                };
+            }
+            if (typeof approvedPlanText !== 'string' ||
+                approvedPlanText.trim().length < 20 ||
+                typeof args.workspace_root !== 'string' ||
+                args.workspace_root.trim().length === 0) {
+                const message = 'ERROR: `approved_plan` and `workspace_root` are both required. ' +
+                    '`approved_plan` must contain the full plan text (min 20 chars) — inline it, or pass approved_plan_file (e.g. ".duul/plan.md"). ' +
+                    '`workspace_root` must be an absolute path. ' +
+                    'You called request_execution_partition with missing or empty content. ' +
+                    'Retry with: { "approved_plan": "<plan text>", "workspace_root": "<absolute path>" }. ' +
+                    'Do NOT call this tool again with an empty input.';
+                console.error(`[duul] execution-partition rejected: missing/empty approved_plan or workspace_root`);
+                return {
+                    content: [{ type: 'text', text: message }],
+                    isError: true,
+                };
+            }
             const iterMeta = computeIterationMeta('partition', args.iteration_count, args.max_review_iterations);
             // Short-circuit if iteration limit exceeded
             if (isIterationLimitExceeded('partition', args.iteration_count, args.max_review_iterations)) {
@@ -31,7 +69,7 @@ export function registerExecutionPartitionTool(server) {
                     subtasks: [{
                             id: 'full-plan',
                             title: 'Execute full plan serially (limit reached)',
-                            goal: args.approved_plan.slice(0, 200) + '...',
+                            goal: approvedPlanText.slice(0, 200) + '...',
                             can_run_in_parallel: false,
                             depends_on: [],
                             workspace_name_hint: 'main',
@@ -58,6 +96,7 @@ export function registerExecutionPartitionTool(server) {
                     },
                     review_id: '',
                     ...iterMeta,
+                    cost_warning: null,
                     token_usage: ZERO_USAGE,
                 };
                 return {
@@ -65,9 +104,8 @@ export function registerExecutionPartitionTool(server) {
                     structuredContent: limitResult,
                 };
             }
-            const scope = resolveWorkspaceScope(args);
             const systemPrompt = getExecutionPartitionSystemPrompt();
-            const userMessage = formatExecutionPartitionUserMessage(args.approved_plan, args.constraints, {
+            const userMessage = formatExecutionPartitionUserMessage(approvedPlanText, args.constraints, {
                 changedFiles: args.changed_files,
                 entrypoints: args.entrypoints,
                 artifactRefs: args.artifact_refs,
@@ -80,6 +118,7 @@ export function registerExecutionPartitionTool(server) {
                 outputSchema: ExecutionPartitionOutputSchema,
                 workspaceScope: scope,
                 previousReviewId: args.previous_review_id,
+                toolName: 'partition',
                 reviewerConfig: args.reviewer_config,
                 createFallback: (_reason, _usedTools) => ({
                     execution_mode: 'serial',
@@ -92,7 +131,7 @@ export function registerExecutionPartitionTool(server) {
                     subtasks: [{
                             id: 'full-plan',
                             title: 'Execute full plan serially',
-                            goal: args.approved_plan.slice(0, 200) + '...',
+                            goal: approvedPlanText.slice(0, 200) + '...',
                             can_run_in_parallel: false,
                             depends_on: [],
                             workspace_name_hint: 'main',
@@ -119,7 +158,13 @@ export function registerExecutionPartitionTool(server) {
                     },
                 }),
             });
-            const result = { ...parsed, review_id: reviewId, ...iterMeta, token_usage: usage };
+            const result = {
+                ...parsed,
+                review_id: reviewId,
+                ...iterMeta,
+                cost_warning: computeCostWarning(iterMeta, usage.estimated_cost_usd),
+                token_usage: usage,
+            };
             logUsage('execution_partition', result.token_usage, {
                 review_id: reviewId,
                 iteration_count: iterMeta.iteration_count,

package/build/tools/plan-review.js

@@ -1,8 +1,8 @@
 import { PlanReviewInputSchema, PlanReviewOutputSchema, PlanReviewMcpOutputSchema, } from '../schemas/plan-review.js';
 import { getPlanReviewSystemPrompt, formatPlanReviewUserMessage } from '../prompts/plan-review-system.js';
 import { callReview } from '../services/reviewer.js';
-import { resolveWorkspaceScope, getGitDiff } from '../services/filesystem.js';
-import { computeIterationMeta, isIterationLimitExceeded } from '../services/review-limits.js';
+import { resolveWorkspaceScope, getGitDiff, resolveInlineOrFile } from '../services/filesystem.js';
+import { computeIterationMeta, isIterationLimitExceeded, computeCostWarning } from '../services/review-limits.js';
 import { logUsage } from '../services/usage-logger.js';
 import { applyGates } from '../services/review-gates.js';
 const MAX_INLINE_DIFF_CHARS = 50_000;
@@ -10,13 +10,43 @@ const ZERO_USAGE = { input_tokens: 0, output_tokens: 0, total_tokens: 0, api_cal
 export function registerPlanReviewTool(server) {
     server.registerTool('request_plan_review', {
         title: 'DUUL Plan Review (Senior Architect)',
-        description: 'DUUL Phase 1: Submit a development plan for review by an LLM acting as a Senior Architect. ' +
-            'Returns structured feedback with blocking issues, edge cases, and implementation checklist, or approval.',
+        description: 'DUUL Phase 1: Submit an implementation plan for senior-architect review. ' +
+            'Provide the plan EITHER inline via `plan` OR (preferred for large plans) by writing it to a file ' +
+            'and passing `plan_file` (relative path, e.g. ".duul/plan.md") plus `workspace_root`. ' +
+            'Exactly one of plan/plan_file is required. ' +
+            'Optional: project_context, changed_files, artifact_refs, user_original_request, previous_review_id, iteration_count. ' +
+            'Returns blocking issues, edge cases, implementation checklist, or APPROVE verdict.',
         inputSchema: PlanReviewInputSchema,
         outputSchema: PlanReviewMcpOutputSchema,
     }, async (input) => {
         try {
             const args = input;
+            const scope = resolveWorkspaceScope(args);
+            // Resolve the plan from inline `plan` or from `plan_file` (large-plan escape hatch).
+            let planText;
+            try {
+                planText = await resolveInlineOrFile({ inline: args.plan, file: args.plan_file, scope, label: 'plan' });
+            }
+            catch (readErr) {
+                const reason = readErr instanceof Error ? readErr.message : String(readErr);
+                console.error(`[duul] plan-review plan_file read failed: ${reason}`);
+                return {
+                    content: [{ type: 'text', text: `ERROR: could not read plan_file. ${reason}` }],
+                    isError: true,
+                };
+            }
+            if (typeof planText !== 'string' || planText.trim().length < 20) {
+                const message = 'ERROR: a plan is required and must contain the full plan markdown (at least 20 chars). ' +
+                    'You called request_plan_review without usable plan content. ' +
+                    'Either inline it — { "plan": "<your complete plan text>", ... } — or, for a large plan, ' +
+                    'write it to a file first and pass { "plan_file": ".duul/plan.md", "workspace_root": "<absolute path>" }. ' +
+                    'Always include workspace_root and user_original_request. Do NOT call this tool again with an empty input.';
+                console.error(`[duul] plan-review rejected: missing/empty plan content`);
+                return {
+                    content: [{ type: 'text', text: message }],
+                    isError: true,
+                };
+            }
             const iterMeta = computeIterationMeta('plan', args.iteration_count, args.max_review_iterations);
             // Short-circuit if iteration limit exceeded
             if (isIterationLimitExceeded('plan', args.iteration_count, args.max_review_iterations)) {
@@ -46,6 +76,7 @@ export function registerPlanReviewTool(server) {
                     gates_tripped: null,
                     review_id: '',
                     ...iterMeta,
+                    cost_warning: null,
                     token_usage: ZERO_USAGE,
                 };
                 return {
@@ -53,7 +84,6 @@ export function registerPlanReviewTool(server) {
                     structuredContent: limitResult,
                 };
             }
-            const scope = resolveWorkspaceScope(args);
             // Auto-generate git diff if not provided
             let gitDiff = args.git_diff;
             if (!gitDiff && scope?.root && args.changed_files?.length) {
@@ -70,7 +100,7 @@ export function registerPlanReviewTool(server) {
                 }
             }
             const systemPrompt = getPlanReviewSystemPrompt();
-            const userMessage = formatPlanReviewUserMessage(args.plan, args.project_context, args.constraints, args.notes_to_reviewer, {
+            const userMessage = formatPlanReviewUserMessage(planText, args.project_context, args.constraints, args.notes_to_reviewer, {
                 workingDirectories: args.working_directories,
                 linkedRoots: args.linked_roots,
                 changedFiles: args.changed_files,
@@ -91,6 +121,7 @@ export function registerPlanReviewTool(server) {
                 outputSchema: PlanReviewOutputSchema,
                 workspaceScope: scope,
                 previousReviewId: args.previous_review_id,
+                toolName: 'plan',
                 reviewerConfig: args.reviewer_config,
                 createFallback: (reason, usedTools) => ({
                     verdict: 'REVISE',
@@ -152,6 +183,7 @@ export function registerPlanReviewTool(server) {
                 gates_tripped: gates.tripped.length > 0 ? gates.tripped : null,
                 review_id: reviewId,
                 ...iterMeta,
+                cost_warning: computeCostWarning(iterMeta, usage.estimated_cost_usd),
                 token_usage: usage,
             };
             logUsage('plan_review', result.token_usage, {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@planningo/duul",
-  "version": "1.0.0",
+  "version": "1.1.0",
   "description": "DUUL — Dual-phase Upfront-plan & Unit-verify Loop. MCP server for LLM peer review of plans and code.",
   "type": "module",
   "main": "build/index.js",