@planningcenter/tapestry-migration-cli 3.1.0-rc.9 → 3.1.0

package/src/components/text-area/transforms/mergeFieldIntoTextArea.ts

@@ -1,227 +1,5 @@
-import { JSXElement, JSXText, Transform } from "jscodeshift"
+import { mergeFieldFactory } from "../../shared/transformFactories/mergeFieldFactory"
 
-import { addComment } from "../../shared/actions/addComment"
-import {
-  getImportName,
-  removeImportFromDeclaration,
-} from "../../shared/transformFactories/helpers/manageImports"
-
-const SCOPE = "mergeFieldIntoTextArea"
-
-const transform: Transform = (fileInfo, api) => {
-  const j = api.jscodeshift
-  const source = j(fileInfo.source)
-
-  const fieldLocalName = getImportName(
-    "Field",
-    "@planningcenter/tapestry-react",
-    { j, source }
-  )
-  if (!fieldLocalName) return null
-
-  const textAreaLocalName = getImportName(
-    "TextArea",
-    "@planningcenter/tapestry-react",
-    { j, source }
-  )
-  if (!textAreaLocalName) return null
-
-  let hasChanges = false
-  let anyFieldRemoved = false
-
-  source.find(j.JSXElement).forEach((path) => {
-    const el = path.value
-    const opening = el.openingElement
-
-    if (opening.name.type !== "JSXIdentifier") return
-    if (opening.name.name !== fieldLocalName) return
-
-    const elementChildren = (el.children || []).filter(
-      (child) =>
-        child.type !== "JSXText" || (child as JSXText).value.trim() !== ""
-    )
-
-    const textAreaChildren = elementChildren.filter((child) => {
-      if (child.type !== "JSXElement") return false
-      const childOpening = (child as JSXElement).openingElement
-      return (
-        childOpening.name.type === "JSXIdentifier" &&
-        childOpening.name.name === textAreaLocalName
-      )
-    }) as JSXElement[]
-
-    // Case: exactly 1 child and it is a TextArea — merge props and unwrap
-    if (elementChildren.length === 1 && textAreaChildren.length === 1) {
-      const textAreaEl = textAreaChildren[0]
-      const fieldAttrs = opening.attributes || []
-
-      // Bail out if Field has spread props — we can't know what they contain
-      const hasFieldSpreads = fieldAttrs.some(
-        (attr) => attr.type === "JSXSpreadAttribute"
-      )
-      if (hasFieldSpreads) {
-        addComment({
-          element: textAreaEl,
-          j,
-          scope: SCOPE,
-          source,
-          text: "Field has spread props that cannot be auto-merged into TextArea. Please migrate manually.",
-        })
-        hasChanges = true
-        return
-      }
-
-      for (const attr of fieldAttrs) {
-        if (attr.type !== "JSXAttribute") continue
-        if (attr.name.type !== "JSXIdentifier") continue
-
-        const attrName = attr.name.name
-        const textAreaAttrs = textAreaEl.openingElement.attributes || []
-
-        if (attrName === "label") {
-          const hasLabel = textAreaAttrs.some(
-            (a) =>
-              a.type === "JSXAttribute" &&
-              a.name?.type === "JSXIdentifier" &&
-              a.name.name === "label"
-          )
-          if (hasLabel) {
-            addComment({
-              element: textAreaEl,
-              j,
-              scope: SCOPE,
-              source,
-              text: "Field had label prop but TextArea already has label. Please migrate manually.",
-            })
-          } else {
-            textAreaEl.openingElement.attributes.push(attr)
-          }
-        } else if (attrName === "feedbackText") {
-          const hasDescription = textAreaAttrs.some(
-            (a) =>
-              a.type === "JSXAttribute" &&
-              a.name?.type === "JSXIdentifier" &&
-              a.name.name === "description"
-          )
-          if (hasDescription) {
-            addComment({
-              element: textAreaEl,
-              j,
-              scope: SCOPE,
-              source,
-              text: "Field had feedbackText prop but TextArea already has description. Please migrate manually.",
-            })
-          } else {
-            const newAttr = j.jsxAttribute(
-              j.jsxIdentifier("description"),
-              attr.value
-            )
-            textAreaEl.openingElement.attributes.push(newAttr)
-          }
-        } else if (attrName === "state") {
-          const hasState = textAreaAttrs.some(
-            (a) =>
-              a.type === "JSXAttribute" &&
-              a.name?.type === "JSXIdentifier" &&
-              a.name.name === "state"
-          )
-          if (hasState) {
-            addComment({
-              element: textAreaEl,
-              j,
-              scope: SCOPE,
-              source,
-              text: "Field had state prop but TextArea already has state. Please migrate manually.",
-            })
-          } else {
-            textAreaEl.openingElement.attributes.push(attr)
-          }
-        } else if (attrName === "key") {
-          const hasKey = textAreaAttrs.some(
-            (a) =>
-              a.type === "JSXAttribute" &&
-              a.name?.type === "JSXIdentifier" &&
-              a.name.name === "key"
-          )
-          if (!hasKey) {
-            textAreaEl.openingElement.attributes.push(attr)
-          }
-        } else {
-          // Unsupported prop — add comment to TextArea
-          addComment({
-            element: textAreaEl,
-            j,
-            scope: SCOPE,
-            source,
-            text: `Field prop '${attrName}' is not supported by TextArea. Please migrate manually.`,
-          })
-        }
-      }
-
-      const parent = path.parent?.value
-      if (parent?.children) {
-        const idx = parent.children.indexOf(el)
-        if (idx === -1) return
-        parent.children.splice(idx, 1, ...(el.children || []))
-      } else {
-        // Root JSX (e.g. directly inside return parens) — use path.replace
-        const nonWsChildren = (el.children || []).filter(
-          (child) =>
-            child.type !== "JSXText" || (child as JSXText).value.trim() !== ""
-        )
-        if (nonWsChildren.length === 1) {
-          path.replace(nonWsChildren[0])
-        } else {
-          path.replace(
-            j.jsxFragment(
-              j.jsxOpeningFragment(),
-              j.jsxClosingFragment(),
-              el.children || []
-            )
-          )
-        }
-      }
-      hasChanges = true
-      anyFieldRemoved = true
-      return
-    }
-
-    // Case: more than 1 non-whitespace child — comment each TextArea child, leave Field
-    if (elementChildren.length > 1) {
-      for (const child of textAreaChildren) {
-        addComment({
-          element: child,
-          j,
-          scope: SCOPE,
-          source,
-          text: "Field has multiple children and cannot be auto-merged into TextArea. Please migrate manually.",
-        })
-        hasChanges = true
-      }
-      return
-    }
-
-    // Case: exactly 1 child but not a TextArea — skip without comment
-  })
-
-  // Remove Field from imports only if all Field usages were converted
-  if (anyFieldRemoved) {
-    const stillUsesField =
-      source.find(j.JSXOpeningElement, {
-        name: { name: fieldLocalName },
-      }).length > 0
-
-    if (!stillUsesField) {
-      const fieldImports = source.find(j.ImportDeclaration, {
-        source: { value: "@planningcenter/tapestry-react" },
-      })
-      for (let i = 0; i < fieldImports.length; i++) {
-        removeImportFromDeclaration(fieldImports.at(i), "Field")
-      }
-    }
-  }
-
-  return hasChanges ? source.toSource() : null
-}
-
-export default transform
+export default mergeFieldFactory({
+  targetComponent: "TextArea",
+})

package/src/index.ts

@@ -17,6 +17,7 @@ const COMPONENTS_SET = new Set([
   "input",
   "link",
   "radio",
+  "select",
   "text-area",
   "toggle-switch",
 ])
@@ -26,7 +27,7 @@ program
   .description("Run a migration of a component from Tapestry React to Tapestry")
   .argument(
     "<component-name>",
-    "The name of the component to migrate (button, checkbox, input, link, radio, text-area, toggle-switch)"
+    "The name of the component to migrate (button, checkbox, input, link, radio, select, text-area, toggle-switch)"
   )
   .requiredOption(
     "-p, --path <path>",