@planningcenter/tapestry-migration-cli 2.4.0-rc.9 → 2.4.1-rc.0

package/src/components/checkbox/transforms/convertStyleProps.test.ts

@@ -0,0 +1,161 @@
+import jscodeshift from "jscodeshift"
+import { describe, expect, it } from "vitest"
+
+import transform from "./convertStyleProps"
+
+const j = jscodeshift.withParser("tsx")
+
+function applyTransform(source: string, options = {}) {
+  const fileInfo = { path: "test.tsx", source }
+  const result = transform(
+    fileInfo,
+    { j, jscodeshift: j, report: () => {}, stats: () => {} },
+    options
+  ) as string | null
+  return result || source
+}
+
+describe("convertStyleProps transform", () => {
+  describe("visible prop - handled by theme system", () => {
+    it("should convert visible={false} to display: none", () => {
+      const source = `
+        import { Checkbox } from "@planningcenter/tapestry-react"
+
+        export function TestComponent() {
+          return <Checkbox visible={false} label="Hidden Checkbox" />
+        }
+      `
+
+      const result = applyTransform(source)
+
+      expect(result).toContain("style={{")
+      expect(result).toContain('display: "none"')
+      expect(result).not.toContain("visible={false}")
+    })
+
+    it("should remove visible={true} with no style changes (true is default)", () => {
+      const source = `
+        import { Checkbox } from "@planningcenter/tapestry-react"
+
+        export function TestComponent() {
+          return <Checkbox visible={true} label="Visible Checkbox" />
+        }
+      `
+
+      const result = applyTransform(source)
+
+      // visible={true} is default behavior, so it should be removed with no style added
+      expect(result).not.toContain("visible={true}")
+      expect(result).not.toContain("style={{") // No style should be added
+      expect(result).toContain('<Checkbox label="Visible Checkbox" />')
+    })
+
+    it("should handle visible expressions", () => {
+      const source = `
+        import { Checkbox } from "@planningcenter/tapestry-react"
+
+        export function TestComponent() {
+          const isVisible = true
+          return <Checkbox visible={isVisible} label="Variable Checkbox" />
+        }
+      `
+
+      const result = applyTransform(source)
+
+      // Note: visible expressions are handled by handleVisibleExpressions transform,
+      // not convertStyleProps, so the visible prop should remain
+      expect(result).toContain("visible: isVisible")
+      expect(result).toContain("style={{") // Style should be added for expressions
+    })
+  })
+
+  describe("style prop removal", () => {
+    it("should remove alignItems prop", () => {
+      const source = `
+        import { Checkbox } from "@planningcenter/tapestry-react"
+
+        export function TestComponent() {
+          return <Checkbox alignItems="center" label="Test" />
+        }
+      `
+
+      const result = applyTransform(source)
+
+      expect(result).not.toContain("alignItems=")
+    })
+
+    it("should remove marginTop prop", () => {
+      const source = `
+        import { Checkbox } from "@planningcenter/tapestry-react"
+
+        export function TestComponent() {
+          return <Checkbox marginTop={16} label="Test" />
+        }
+      `
+
+      const result = applyTransform(source)
+
+      expect(result).not.toContain("marginTop=")
+    })
+
+    it("should remove multiple style props", () => {
+      const source = `
+        import { Checkbox } from "@planningcenter/tapestry-react"
+
+        export function TestComponent() {
+          return <Checkbox alignItems="center" marginTop={16} label="Test" />
+        }
+      `
+
+      const result = applyTransform(source)
+
+      expect(result).not.toContain("alignItems=")
+      expect(result).not.toContain("marginTop=")
+    })
+  })
+
+  describe("combination of style props", () => {
+    it("should handle combination of visible and style props", () => {
+      const source = `
+        import { Checkbox } from "@planningcenter/tapestry-react"
+
+        export function TestComponent() {
+          return (
+            <Checkbox
+              visible={false}
+              alignItems="center"
+              marginTop={16}
+              label="Combined Checkbox"
+            />
+          )
+        }
+      `
+
+      const result = applyTransform(source)
+
+      expect(result).toContain("style={{")
+      expect(result).toContain('display: "none"') // from visible={false}
+      expect(result).not.toContain("visible={false}")
+      expect(result).not.toContain("alignItems=")
+      expect(result).not.toContain("marginTop=")
+    })
+  })
+
+  describe("import handling", () => {
+    it("should not affect imports", () => {
+      const source = `
+        import { Checkbox } from "@planningcenter/tapestry-react"
+
+        export function TestComponent() {
+          return <Checkbox visible={false} label="Test" />
+        }
+      `
+
+      const result = applyTransform(source)
+
+      expect(result).toContain(
+        'import { Checkbox } from "@planningcenter/tapestry-react"'
+      )
+    })
+  })
+})

package/src/components/checkbox/transforms/convertStyleProps.ts

@@ -0,0 +1,10 @@
+import { stackViewPlugin } from "../../../stubs/stackViewPlugin"
+import { stylePropTransformFactory } from "../../shared/transformFactories/stylePropTransformFactory"
+
+export default stylePropTransformFactory({
+  plugin: stackViewPlugin,
+  stylesToKeep: ["visible"],
+  stylesToRemove: [],
+  targetComponent: "Checkbox",
+  targetPackage: "@planningcenter/tapestry-react",
+})

package/src/components/checkbox/transforms/innerRefToRef.test.ts

@@ -0,0 +1,161 @@
+import jscodeshift from "jscodeshift"
+import { describe, expect, it } from "vitest"
+
+import transform from "./innerRefToRef"
+
+const j = jscodeshift.withParser("tsx")
+
+function applyTransform(source: string): string {
+  const fileInfo = { path: "test.tsx", source }
+  const result = transform(
+    fileInfo,
+    { j, jscodeshift: j, report: () => {}, stats: () => {} },
+    {}
+  ) as string | null
+  return result || source
+}
+
+describe("innerRefToRef transform", () => {
+  describe("innerRef to ref conversion", () => {
+    it("should convert innerRef to ref", () => {
+      const input = `
+import { Checkbox } from "@planningcenter/tapestry-react"
+
+function Test() {
+  const checkboxRef = React.useRef()
+  return <Checkbox innerRef={checkboxRef} label="Test" />
+}
+      `.trim()
+
+      const result = applyTransform(input)
+      expect(result).toContain("ref={checkboxRef}")
+      expect(result).not.toContain("innerRef=")
+    })
+
+    it("should convert innerRef with expression", () => {
+      const input = `
+import { Checkbox } from "@planningcenter/tapestry-react"
+
+function Test() {
+  return <Checkbox innerRef={myRef} label="Test" />
+}
+      `.trim()
+
+      const result = applyTransform(input)
+      expect(result).toContain("ref={myRef}")
+      expect(result).not.toContain("innerRef=")
+    })
+
+    it("should convert innerRef with callback", () => {
+      const input = `
+import { Checkbox } from "@planningcenter/tapestry-react"
+
+function Test() {
+  return <Checkbox innerRef={(el) => console.log(el)} label="Test" />
+}
+      `.trim()
+
+      const result = applyTransform(input)
+      expect(result).toContain("ref={(el) => console.log(el)}")
+      expect(result).not.toContain("innerRef=")
+    })
+
+    it("should not affect existing ref props", () => {
+      const input = `
+import { Checkbox } from "@planningcenter/tapestry-react"
+
+function Test() {
+  const checkboxRef = React.useRef()
+  return <Checkbox ref={checkboxRef} label="Test" />
+}
+      `.trim()
+
+      const result = applyTransform(input)
+      expect(result).toContain("ref={checkboxRef}")
+      expect(result).not.toContain("innerRef=")
+    })
+
+    it("should handle multiple checkboxes", () => {
+      const input = `
+import { Checkbox } from "@planningcenter/tapestry-react"
+
+function Test() {
+  const ref1 = React.useRef()
+  const ref2 = React.useRef()
+  return (
+    <div>
+      <Checkbox innerRef={ref1} label="First" />
+      <Checkbox innerRef={ref2} label="Second" />
+    </div>
+  )
+}
+      `.trim()
+
+      const result = applyTransform(input)
+      expect(result).toContain("ref={ref1}")
+      expect(result).toContain("ref={ref2}")
+      expect(result).not.toContain("innerRef=")
+    })
+  })
+
+  describe("edge cases", () => {
+    it("should not affect other components", () => {
+      const input = `
+import { Button, Checkbox } from "@planningcenter/tapestry-react"
+
+function Test() {
+  const buttonRef = React.useRef()
+  const checkboxRef = React.useRef()
+  return (
+    <div>
+      <Button innerRef={buttonRef}>Click me</Button>
+      <Checkbox innerRef={checkboxRef} label="Test" />
+    </div>
+  )
+}
+      `.trim()
+
+      const result = applyTransform(input)
+      expect(result).toContain("<Button innerRef={buttonRef}>Click me</Button>")
+      expect(result).toContain("ref={checkboxRef}")
+    })
+
+    it("should handle checkbox without innerRef", () => {
+      const input = `
+import { Checkbox } from "@planningcenter/tapestry-react"
+
+function Test() {
+  return <Checkbox label="Test" />
+}
+      `.trim()
+
+      const result = applyTransform(input)
+      expect(result).toContain('<Checkbox label="Test" />')
+    })
+
+    it("should preserve other props", () => {
+      const input = `
+import { Checkbox } from "@planningcenter/tapestry-react"
+
+function Test() {
+  const checkboxRef = React.useRef()
+  return (
+    <Checkbox 
+      innerRef={checkboxRef} 
+      label="Test" 
+      checked 
+      disabled 
+    />
+  )
+}
+      `.trim()
+
+      const result = applyTransform(input)
+      expect(result).toContain("ref={checkboxRef}")
+      expect(result).toContain('label="Test"')
+      expect(result).toContain("checked")
+      expect(result).toContain("disabled")
+      expect(result).not.toContain("innerRef=")
+    })
+  })
+})

package/src/components/checkbox/transforms/innerRefToRef.ts

@@ -0,0 +1,14 @@
+import { transformAttributeName } from "../../shared/actions/transformAttributeName"
+import { hasAttribute } from "../../shared/conditions/hasAttribute"
+import { attributeTransformFactory } from "../../shared/transformFactories/attributeTransformFactory"
+
+const transform = attributeTransformFactory({
+  condition: hasAttribute("innerRef"),
+  targetComponent: "Checkbox",
+  targetPackage: "@planningcenter/tapestry-react",
+  transform: (element) => {
+    return transformAttributeName("innerRef", "ref", { element })
+  },
+})
+
+export default transform

package/src/components/checkbox/transforms/moveCheckboxImport.test.ts

@@ -0,0 +1,182 @@
+import jscodeshift from "jscodeshift"
+import { describe, expect, it } from "vitest"
+
+import transform from "./moveCheckboxImport"
+
+const j = jscodeshift.withParser("tsx")
+
+function applyTransform(source: string): string {
+  const fileInfo = { path: "test.tsx", source }
+  const result = transform(
+    fileInfo,
+    { j, jscodeshift: j, report: () => {}, stats: () => {} },
+    {}
+  ) as string | null
+  return result || source
+}
+
+describe("moveCheckboxImport transform", () => {
+  describe("import migration", () => {
+    it("should change import from tapestry-react to tapestry", () => {
+      const input = `
+import { Checkbox } from "@planningcenter/tapestry-react"
+
+function Test() {
+  return <Checkbox label="Test" />
+}
+      `.trim()
+
+      const result = applyTransform(input)
+      expect(result).toContain(
+        'import { Checkbox } from "@planningcenter/tapestry"'
+      )
+      expect(result).not.toContain("@planningcenter/tapestry-react")
+    })
+
+    it("should handle multiple imports", () => {
+      const input = `
+import { Button, Checkbox } from "@planningcenter/tapestry-react"
+
+function Test() {
+  return (
+    <div>
+      <Button>Click</Button>
+      <Checkbox label="Test" />
+    </div>
+  )
+}
+      `.trim()
+
+      const result = applyTransform(input)
+      expect(result).toContain(
+        'import { Button } from "@planningcenter/tapestry-react"'
+      )
+      expect(result).toContain(
+        'import { Checkbox } from "@planningcenter/tapestry"'
+      )
+    })
+
+    it("should handle default import", () => {
+      const input = `
+import Checkbox from "@planningcenter/tapestry-react"
+
+function Test() {
+  return <Checkbox label="Test" />
+}
+      `.trim()
+
+      const result = applyTransform(input)
+      expect(result).toContain(
+        'import Checkbox from "@planningcenter/tapestry-react"'
+      )
+    })
+
+    it("should handle mixed imports", () => {
+      const input = `
+import { Button } from "@planningcenter/tapestry-react"
+import { Checkbox } from "@planningcenter/tapestry-react"
+
+function Test() {
+  return (
+    <div>
+      <Button>Click</Button>
+      <Checkbox label="Test" />
+    </div>
+  )
+}
+      `.trim()
+
+      const result = applyTransform(input)
+      expect(result).toContain(
+        'import { Button } from "@planningcenter/tapestry-react"'
+      )
+      expect(result).toContain(
+        'import { Checkbox } from "@planningcenter/tapestry-react"'
+      )
+    })
+
+    it("should not affect other components", () => {
+      const input = `
+import { Button } from "@planningcenter/tapestry-react"
+
+function Test() {
+  return <Button>Click me</Button>
+}
+      `.trim()
+
+      const result = applyTransform(input)
+      expect(result).toContain(
+        'import { Button } from "@planningcenter/tapestry-react"'
+      )
+    })
+  })
+
+  describe("edge cases", () => {
+    it("should handle already migrated imports", () => {
+      const input = `
+import { Checkbox } from "@planningcenter/tapestry"
+
+function Test() {
+  return <Checkbox label="Test" />
+}
+      `.trim()
+
+      const result = applyTransform(input)
+      expect(result).toContain(
+        'import { Checkbox } from "@planningcenter/tapestry"'
+      )
+    })
+
+    it("should handle no imports", () => {
+      const input = `
+function Test() {
+  return <div>No imports</div>
+}
+      `.trim()
+
+      const result = applyTransform(input)
+      expect(result).toBe(input)
+    })
+
+    it("should handle checkbox not used", () => {
+      const input = `
+import { Checkbox } from "@planningcenter/tapestry-react"
+
+function Test() {
+  return <div>No checkbox used</div>
+}
+      `.trim()
+
+      const result = applyTransform(input)
+      expect(result).toContain(
+        'import { Checkbox } from "@planningcenter/tapestry-react"'
+      )
+    })
+
+    it("should preserve other attributes", () => {
+      const input = `
+import { Checkbox } from "@planningcenter/tapestry-react"
+
+function Test() {
+  return (
+    <Checkbox 
+      label="Test" 
+      checked 
+      disabled 
+      onChange={() => {}}
+    />
+  )
+}
+      `.trim()
+
+      const result = applyTransform(input)
+      expect(result).toContain(
+        'import { Checkbox } from "@planningcenter/tapestry"'
+      )
+      expect(result).toContain('label="Test"')
+      expect(result).toContain("checked")
+      expect(result).toContain("disabled")
+      expect(result).toContain("onChange={() => {}}")
+    })
+  })
+})

package/src/components/checkbox/transforms/moveCheckboxImport.ts

@@ -0,0 +1,13 @@
+import { Transform } from "jscodeshift"
+
+import { componentTransformFactory } from "../../shared/transformFactories/componentTransformFactory"
+
+const transform: Transform = componentTransformFactory({
+  condition: () => true,
+  fromComponent: "Checkbox",
+  fromPackage: "@planningcenter/tapestry-react",
+  toComponent: "Checkbox",
+  toPackage: "@planningcenter/tapestry",
+})
+
+export default transform