@planning-inspectorate/dynamic-forms 3.3.1 → 3.3.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@planning-inspectorate/dynamic-forms",
-  "version": "3.3.1",
+  "version": "3.3.2",
   "description": "This package is for building GDS forms using a configuration-based approach.",
   "main": "./src/index.js",
   "type": "module",

package/src/controller.js

@@ -1,6 +1,7 @@
 import { SECTION_STATUS } from './section.js';
 import questionUtils from './components/utils/question-utils.js';
 import { answerObjectForManageListSaving } from '#src/components/manage-list/utils.js';
+import { booleanToYesNoValue } from '#src/components/boolean/question.js';
 
 /**
  * @typedef {import('./journey/journey.js').Journey} Journey
@@ -258,6 +259,12 @@ export function buildSave(saveData, redirectToTaskListOnSuccess) {
 				answers = answerObjectForManageListSaving(journeyResponse, manageListQuestion, req.params);
 			}
 			for (const [k, v] of Object.entries(data?.answers || {})) {
+				if (typeof v === 'boolean') {
+					// boolean answers are saved at booleans, but stored in session and
+					// checked by display logic as yes/no
+					answers[k] = booleanToYesNoValue(v);
+					continue;
+				}
 				answers[k] = v;
 			}
 			// move to the next question

package/src/controller.test.js

@@ -6,6 +6,7 @@ import { Journey } from './journey/journey.js';
 import { SECTION_STATUS } from './section.js';
 
 import { mockReq, mockRes } from '#test/utils/utils.js';
+import { BOOLEAN_OPTIONS } from '#src/components/boolean/question.js';
 
 const res = mockRes();
 const mockBaseUrl = '/manage-appeals/questionnaire';
@@ -501,7 +502,10 @@ describe('dynamic-form/controller', () => {
 				...sampleQuestionObj
 			};
 			sampleQuestionObjWithActions.getDataToSave.mock.mockImplementationOnce(() => ({
-				answers: { [sampleQuestionObj.fieldName]: 'my-answer' }
+				answers: {
+					[sampleQuestionObj.fieldName]: 'my-answer',
+					aBooleanToTest: true
+				}
 			}));
 
 			req.params = {
@@ -528,6 +532,8 @@ describe('dynamic-form/controller', () => {
 			assert.strictEqual(res.redirect.mock.calls[0].arguments[0], expectedUrl);
 			// journey response should be edited if redirecting to next question
 			assert.strictEqual(res.locals.journeyResponse.answers?.sampleFieldName, 'my-answer');
+			// booleans must be strings in journey response
+			assert.strictEqual(res.locals.journeyResponse.answers?.aBooleanToTest, BOOLEAN_OPTIONS.YES);
 		});
 
 		it('should redirect to task list if configured', async () => {