@plainconceptsplatform/workflows 1.17.0 → 1.17.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
|
@@ -845,10 +845,19 @@ timeout-minutes: 180
|
|
|
845
845
|
the code you changed (web: `pnpm exec vitest related --run <changed files>`; .NET:
|
|
846
846
|
`dotnet test <the test project> --filter <the test classes>`). Do not run integration,
|
|
847
847
|
end-to-end, mutation or coverage suites here, and do not run the whole test suite to be safe:
|
|
848
|
-
the repository's CI runs
|
|
849
|
-
|
|
850
|
-
|
|
851
|
-
|
|
848
|
+
the repository's CI runs them, on a runner that has the database and the browsers this
|
|
849
|
+
sandbox lacks. The verification commands above are the repository's quick check for that
|
|
850
|
+
reason. A full suite in the agent is the slowest part of a run and repeats what CI does
|
|
851
|
+
anyway.
|
|
852
|
+
|
|
853
|
+
**Not running the end-to-end tests does not make them someone else's.** When your change
|
|
854
|
+
moves, renames or removes something a person clicks or reads (a button, a label, a heading, a
|
|
855
|
+
route, a table), or changes what happens after a click, search the end-to-end tests for it
|
|
856
|
+
(their selectors, the text they assert, the routes they open) and update every test that
|
|
857
|
+
uses it in this pull request. Do this even when the repository runs those tests only at night
|
|
858
|
+
or on a schedule: then nothing on the pull request fails, and the suite breaks the morning
|
|
859
|
+
after the merge with no author attached. Pliny-Bot #1506 was ten journeys broken that way by
|
|
860
|
+
Bot Studio changes that merged without their end-to-end tests.
|
|
852
861
|
|
|
853
862
|
**Run them once, on the final tree.** They are slow: Pliny-Bot's `pnpm verify` is about
|
|
854
863
|
twenty minutes of work on this runner. `pc-plan-apply` runs them in its verify step, and
|