@plainconceptsplatform/workflows 1.0.8 → 1.0.10

package/loops/actions/collect-app-errors/query-app-errors.sh

@@ -48,7 +48,7 @@ let thrown =
     AppExceptions
     | where TimeGenerated > window
     | extend Problem = ProblemId, Kind = ExceptionType, Stack = Details,
-             Msg = outerMessage, Category = "";
+             Msg = OuterMessage, Category = "";
 let logged =
     AppTraces
     | where TimeGenerated > window

package/loops/templates/agentics/agentics-app-errors.yml

@@ -1,8 +1,9 @@
 # Managed by @plainconceptsplatform/workflows. Source: loops/templates/agentics/agentics-app-errors.yml. Update with `workflows update --force`; consumer edits may be overwritten.
 name: "Agentics: App Errors"
 
-# Once a day, ask Application Insights what the deployed application actually threw, and file
-# the distinct problems as issues here, labelled so refine sizes them and implement fixes them.
+# Every eight hours, ask Application Insights what the deployed application actually threw,
+# and file the distinct problems as issues here, labelled so refine sizes them and implement
+# fixes them.
 #
 # THIS REPORT STAYS IN THIS REPOSITORY. That is the design constraint, and it is the opposite
 # of the one in agentics-error-report.yml. That workflow exists to carry a *workflow* failure
@@ -28,14 +29,14 @@ name: "Agentics: App Errors"
 #     --role "Monitoring Reader" \
 #     --scope "$(az monitor log-analytics workspace show -g "$AZURE_RG" -n "$WORKSPACE" --query id -o tsv)"
 
-run-name: "App errors: ${{ github.event.inputs.app-env || 'pre' }}, last ${{ github.event.inputs.lookback-hours || '24' }}h"
+run-name: "App errors: ${{ github.event.inputs.app-env || 'pre' }}, last ${{ github.event.inputs.lookback-hours || '8' }}h"
 
 on:
   schedule:
-    # An hour after the workflow error report, so a morning's reading arrives together. This
-    # runs on a GitHub-hosted runner and never touches the agent fleet, so there is no slot to
-    # stagger against other repositories.
-    - cron: "41 7 * * *"
+    # Every eight hours: a failure should surface the same working day, not tomorrow morning.
+    # This runs on a GitHub-hosted runner and never touches the agent fleet, so there is no
+    # slot to stagger against other repositories.
+    - cron: "17 1,9,17 * * *"
   workflow_dispatch:
     inputs:
       app-env:
@@ -47,7 +48,7 @@ on:
         description: "How far back to look"
         required: false
         type: string
-        default: '24'
+        default: '8'
       dry-run:
         description: "Work out what would be filed and file nothing"
         required: false
@@ -64,7 +65,7 @@ env:
   APP_ENV: "pre"
   # Matches the cron. A window wider than the schedule counts the same problem twice; a
   # narrower one loses whatever happened in the gap.
-  LOOKBACK_HOURS: "24"
+  LOOKBACK_HOURS: "8"
   # The floor. A problem below this is real but not yet news, and a belt buried under
   # single-occurrence reports is a belt somebody switches off.
   MIN_OCCURRENCES: "5"

package/loops/workflows/agent-implement.md

@@ -314,11 +314,16 @@ jobs:
       # The signal is the item counter, not `code_push_failure_count`. gh-aw treats the fallback
       # as a *successful* outcome for the item -- the dogfood run logged `Status: success`,
       # `Successful: 1` and a resolved `GH_AW_CODE_PUSH_FAILURE_COUNT: 0` while filing #11 -- so
-      # gating on that count posted the wrong message. `create_pull_request` is the only safe
-      # output this worker permits, so one succeeded item with no pull request number can only
-      # mean the push fell back to an issue. Nothing produced at all leaves the counter at 0.
+      # gating on that count posted the wrong message.
+      #
+      # The counter alone is not enough, though: a `noop` also counts as one succeeded item, so
+      # "items_succeeded != 0 with no PR number" is true for a run that produced nothing to do as
+      # well as for a run whose push fell back to an issue. Telling a person their patch was filed
+      # as a separate issue when the agent actually said "already fixed on main" is the bug this
+      # comment exists to prevent (Odyssey #226). Distinguish them the same way the steps below
+      # do: gate on whether the agent actually asked for a pull request.
       - name: Flag a patch that could not be pushed
-        if: needs.safe_outputs.outputs.created_pr_number == '' && needs.safe_outputs.outputs.process_safe_outputs_items_succeeded != '0' && needs.safe_outputs.outputs.process_safe_outputs_items_succeeded != ''
+        if: needs.safe_outputs.outputs.created_pr_number == '' && needs.safe_outputs.outputs.process_safe_outputs_items_succeeded != '0' && needs.safe_outputs.outputs.process_safe_outputs_items_succeeded != '' && contains(needs.agent.outputs.output_types, 'create_pull_request')
         uses: ./.github/actions/add-issue-labels
         with:
           token: ${{ steps.app-token.outputs.token }}
@@ -327,7 +332,7 @@ jobs:
             ${{ env.REVIEW_LABEL }}
             ${{ env.STALLED_LABEL }}
       - name: Say where the patch went
-        if: needs.safe_outputs.outputs.created_pr_number == '' && needs.safe_outputs.outputs.process_safe_outputs_items_succeeded != '0' && needs.safe_outputs.outputs.process_safe_outputs_items_succeeded != ''
+        if: needs.safe_outputs.outputs.created_pr_number == '' && needs.safe_outputs.outputs.process_safe_outputs_items_succeeded != '0' && needs.safe_outputs.outputs.process_safe_outputs_items_succeeded != '' && contains(needs.agent.outputs.output_types, 'create_pull_request')
         uses: ./.github/actions/create-issue-comment
         with:
           token: ${{ steps.app-token.outputs.token }}
@@ -368,7 +373,7 @@ jobs:
             ${{ env.OUTPUT_NOT_APPLIED_COMMENT }}
             [View this workflow run](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})
       - name: Release an issue the agent found nothing to do on
-        if: needs.safe_outputs.outputs.created_pr_number == '' && (needs.safe_outputs.outputs.process_safe_outputs_items_succeeded == '0' || needs.safe_outputs.outputs.process_safe_outputs_items_succeeded == '') && !contains(needs.agent.outputs.output_types, 'create_pull_request') && contains(needs.agent.outputs.output_types, 'noop')
+        if: needs.safe_outputs.outputs.created_pr_number == '' && !contains(needs.agent.outputs.output_types, 'create_pull_request') && contains(needs.agent.outputs.output_types, 'noop')
         uses: ./.github/actions/add-issue-labels
         with:
           token: ${{ steps.app-token.outputs.token }}
@@ -376,14 +381,14 @@ jobs:
           labels: |-
             ${{ env.REVIEW_LABEL }}
       - name: Take the implement label off a decided issue
-        if: needs.safe_outputs.outputs.created_pr_number == '' && (needs.safe_outputs.outputs.process_safe_outputs_items_succeeded == '0' || needs.safe_outputs.outputs.process_safe_outputs_items_succeeded == '') && !contains(needs.agent.outputs.output_types, 'create_pull_request') && contains(needs.agent.outputs.output_types, 'noop')
+        if: needs.safe_outputs.outputs.created_pr_number == '' && !contains(needs.agent.outputs.output_types, 'create_pull_request') && contains(needs.agent.outputs.output_types, 'noop')
         uses: ./.github/actions/remove-issue-labels
         with:
           token: ${{ steps.app-token.outputs.token }}
           issue-number: ${{ inputs.issue-number }}
           labels: ${{ env.IMPLEMENT_LABEL }}
       - name: Say there was nothing to do
-        if: needs.safe_outputs.outputs.created_pr_number == '' && (needs.safe_outputs.outputs.process_safe_outputs_items_succeeded == '0' || needs.safe_outputs.outputs.process_safe_outputs_items_succeeded == '') && !contains(needs.agent.outputs.output_types, 'create_pull_request') && contains(needs.agent.outputs.output_types, 'noop')
+        if: needs.safe_outputs.outputs.created_pr_number == '' && !contains(needs.agent.outputs.output_types, 'create_pull_request') && contains(needs.agent.outputs.output_types, 'noop')
         uses: ./.github/actions/create-issue-comment
         with:
           token: ${{ steps.app-token.outputs.token }}
@@ -393,7 +398,7 @@ jobs:
             ${{ env.NOOP_COMMENT }}
             [View this workflow run](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})
       - name: Flag a patch nobody asked to publish
-        if: needs.safe_outputs.outputs.created_pr_number == '' && (needs.safe_outputs.outputs.process_safe_outputs_items_succeeded == '0' || needs.safe_outputs.outputs.process_safe_outputs_items_succeeded == '') && !contains(needs.agent.outputs.output_types, 'create_pull_request') && !contains(needs.agent.outputs.output_types, 'noop') && needs.agent.outputs.has_patch == 'true'
+        if: needs.safe_outputs.outputs.created_pr_number == '' && !contains(needs.agent.outputs.output_types, 'create_pull_request') && !contains(needs.agent.outputs.output_types, 'noop') && needs.agent.outputs.has_patch == 'true'
         uses: ./.github/actions/add-issue-labels
         with:
           token: ${{ steps.app-token.outputs.token }}
@@ -402,7 +407,7 @@ jobs:
             ${{ env.REVIEW_LABEL }}
             ${{ env.STALLED_LABEL }}
       - name: Say the patch was never asked for
-        if: needs.safe_outputs.outputs.created_pr_number == '' && (needs.safe_outputs.outputs.process_safe_outputs_items_succeeded == '0' || needs.safe_outputs.outputs.process_safe_outputs_items_succeeded == '') && !contains(needs.agent.outputs.output_types, 'create_pull_request') && !contains(needs.agent.outputs.output_types, 'noop') && needs.agent.outputs.has_patch == 'true'
+        if: needs.safe_outputs.outputs.created_pr_number == '' && !contains(needs.agent.outputs.output_types, 'create_pull_request') && !contains(needs.agent.outputs.output_types, 'noop') && needs.agent.outputs.has_patch == 'true'
         uses: ./.github/actions/create-issue-comment
         with:
           token: ${{ steps.app-token.outputs.token }}
@@ -412,7 +417,7 @@ jobs:
             ${{ env.PATCH_WITHOUT_REQUEST_COMMENT }}
             [View this workflow run](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})
       - name: Flag a run that produced nothing
-        if: needs.safe_outputs.outputs.created_pr_number == '' && (needs.safe_outputs.outputs.process_safe_outputs_items_succeeded == '0' || needs.safe_outputs.outputs.process_safe_outputs_items_succeeded == '') && !contains(needs.agent.outputs.output_types, 'create_pull_request') && !contains(needs.agent.outputs.output_types, 'noop') && needs.agent.outputs.has_patch != 'true'
+        if: needs.safe_outputs.outputs.created_pr_number == '' && !contains(needs.agent.outputs.output_types, 'create_pull_request') && !contains(needs.agent.outputs.output_types, 'noop') && needs.agent.outputs.has_patch != 'true'
         uses: ./.github/actions/add-issue-labels
         with:
           token: ${{ steps.app-token.outputs.token }}
@@ -421,7 +426,7 @@ jobs:
             ${{ env.REVIEW_LABEL }}
             ${{ env.STALLED_LABEL }}
       - name: Say the run produced nothing
-        if: needs.safe_outputs.outputs.created_pr_number == '' && (needs.safe_outputs.outputs.process_safe_outputs_items_succeeded == '0' || needs.safe_outputs.outputs.process_safe_outputs_items_succeeded == '') && !contains(needs.agent.outputs.output_types, 'create_pull_request') && !contains(needs.agent.outputs.output_types, 'noop') && needs.agent.outputs.has_patch != 'true'
+        if: needs.safe_outputs.outputs.created_pr_number == '' && !contains(needs.agent.outputs.output_types, 'create_pull_request') && !contains(needs.agent.outputs.output_types, 'noop') && needs.agent.outputs.has_patch != 'true'
         uses: ./.github/actions/create-issue-comment
         with:
           token: ${{ steps.app-token.outputs.token }}

package/loops/workflows/agent-refine.md

@@ -138,12 +138,19 @@ jobs:
   # needs-maintainer while this run waited in a queue, the issue now carries review and
   # the verdict must stand: the reserve step clears review blindly, so eligibility has to
   # catch it first (Pliny-Bot #372).
+  #
+  # BUT: when mode is rerefine, the trigger was a human comment answering a question the
+  # bot asked and then parked for review. That comment IS the human review the label was
+  # waiting for, so refusing to run would silence exactly the feedback the bot asked for
+  # (Odyssey #226: the bot asked a question, the user answered, and the review label
+  # made the router skip the answer). In rerefine mode the label is cleared and the
+  # refine proceeds; in first mode the triage verdict still stands.
   eligibility:
     needs: [still_open]
     if: needs.still_open.outputs.open == 'true'
     runs-on: agents-arc
     permissions:
-      issues: read
+      issues: write
     outputs:
       eligible: ${{ steps.check.outputs.eligible }}
     steps:
@@ -152,11 +159,21 @@ jobs:
         env:
           GH_TOKEN: ${{ github.token }}
           ISSUE_NUMBER: ${{ inputs.issue-number }}
+          MODE: ${{ inputs.mode }}
         run: |
           set -euo pipefail
           labels=$(gh issue view "$ISSUE_NUMBER" --repo "$GITHUB_REPOSITORY" --json labels \
             --jq '[.labels[].name]')
           if jq -e 'index("review")' >/dev/null <<<"$labels"; then
+            if [ "$MODE" = "rerefine" ]; then
+              # A rerefine is triggered by a human comment on an issue the bot parked for
+              # review. The comment is the review: clear the label and proceed.
+              gh issue edit "$ISSUE_NUMBER" --remove-label "review" 2>/dev/null ||
+                echo "::notice::review label already gone on #$ISSUE_NUMBER"
+              echo "eligible=true" >> "$GITHUB_OUTPUT"
+              echo "::notice::Issue #$ISSUE_NUMBER had review label; cleared it for rerefine (user answered the bot)."
+              exit 0
+            fi
             echo "eligible=false" >> "$GITHUB_OUTPUT"
             echo "::notice::Issue #$ISSUE_NUMBER has the review label. Automated refinement skipped."
             exit 0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@plainconceptsplatform/workflows",
-  "version": "1.0.8",
+  "version": "1.0.10",
   "description": "Install and update Platform GitHub agentic workflows.",
   "keywords": [
     "github-actions",