@plainconceptsplatform/workflows 0.6.1 → 0.16.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (58) hide show
  1. package/README.md +107 -88
  2. package/dist/catalog-installation.d.ts +39 -2
  3. package/dist/catalog-installation.js +172 -109
  4. package/dist/index.js +128 -73
  5. package/dist/package-baseline.d.ts +25 -0
  6. package/dist/package-baseline.js +138 -0
  7. package/dist/route-processing.d.ts +0 -2
  8. package/dist/route-processing.js +22 -91
  9. package/dist/stack-defaults.js +18 -12
  10. package/dist/tui.js +27 -43
  11. package/dist/worker-env.d.ts +46 -0
  12. package/dist/worker-env.js +179 -0
  13. package/dist/workflow-catalog.d.ts +4 -2
  14. package/dist/workflow-catalog.js +5 -3
  15. package/loops/actions/add-issue-labels/action.yml +20 -0
  16. package/loops/actions/audit-close/action.yml +180 -128
  17. package/loops/actions/classify-route/classify-route.sh +8 -2
  18. package/loops/actions/housekeeping/action.yml +251 -0
  19. package/loops/actions/merge-agent-pr/action.yml +13 -0
  20. package/loops/actions/report-workflow-errors/action.yml +414 -0
  21. package/loops/actions/validate-merge-gate-output/validate-merge-gate-output.sh +13 -1
  22. package/loops/actions/validate-triage-output/action.yml +1 -1
  23. package/loops/actions/validate-triage-output/validate-triage-output.sh +9 -5
  24. package/loops/actions/verify-composite-actions/verify-composite-actions.sh +53 -0
  25. package/loops/actions/verify-route-matrix/verify-route-matrix.sh +911 -170
  26. package/loops/templates/agentics/agentics-error-report.yml +98 -0
  27. package/loops/templates/opencode/opencode.ci.json +1 -1
  28. package/loops/workflows/agent-apply-review.md +438 -469
  29. package/loops/workflows/agent-audit.md +200 -213
  30. package/loops/workflows/agent-implement.md +591 -640
  31. package/loops/workflows/agent-merge-gate.md +826 -844
  32. package/loops/workflows/agent-refine.md +590 -633
  33. package/loops/workflows/agent-release.md +244 -258
  34. package/loops/workflows/agent-triage.md +476 -447
  35. package/loops/workflows/authorize-bot-work.yml +26 -6
  36. package/loops/workflows/shared/platform-defaults.md +18 -1
  37. package/loops/workflows/work-router.yml +1185 -1038
  38. package/package.json +9 -8
  39. package/dist/action-validation.test.d.ts +0 -1
  40. package/dist/action-validation.test.js +0 -87
  41. package/dist/catalog-installation.test.d.ts +0 -1
  42. package/dist/catalog-installation.test.js +0 -485
  43. package/dist/catalog-listing.test.d.ts +0 -1
  44. package/dist/catalog-listing.test.js +0 -150
  45. package/dist/index.test.d.ts +0 -1
  46. package/dist/index.test.js +0 -273
  47. package/dist/repository-inspection.test.d.ts +0 -1
  48. package/dist/repository-inspection.test.js +0 -77
  49. package/dist/route-processing.test.d.ts +0 -1
  50. package/dist/route-processing.test.js +0 -283
  51. package/dist/stack-defaults.test.d.ts +0 -1
  52. package/dist/stack-defaults.test.js +0 -266
  53. package/dist/tui.test.d.ts +0 -1
  54. package/dist/tui.test.js +0 -249
  55. package/dist/workflow-catalog.test.d.ts +0 -1
  56. package/dist/workflow-catalog.test.js +0 -29
  57. package/loops/actions/stale-recovery/action.yml +0 -288
  58. package/loops/actions/update-changelog/action.yml +0 -113
@@ -1,469 +1,438 @@
1
- ---
2
- # Managed by @plainconceptsplatform/workflows. Source: loops/workflows/agent-apply-review.md. Update with `workflows update --force`; consumer edits may be overwritten.
3
- env:
4
- # Printed by the prompt as the verification block. Consumers set their own commands.
5
- VERIFY_COMMANDS: ""
6
- REPO_RULES: "Apply only actionable outstanding reviewer feedback to the selected bot pull request. Make minimal changes that address each comment. Preserve architecture and do not weaken tests. Run full verification after changes."
7
- WORKING_LABEL: bot-working
8
- REVIEW_LABEL: review
9
- PR_PENDING_LABEL: pr-pending
10
- REVIEW_MARKER: "<!-- agent-apply-review -->"
11
- INCOMPLETE_COMMENT: "Automated review feedback ended without an outcome. The issue remains for a retry."
12
- ISSUE_CONTEXT_PATH: /tmp/gh-aw/agent/issue-context.json
13
- GH_AW_ALLOWED_BOTS: "platform-devbox[bot],github-actions[bot]"
14
- GIT_AUTHOR_NAME: "github-actions[bot]"
15
- GIT_AUTHOR_EMAIL: "github-actions[bot]@users.noreply.github.com"
16
- GIT_COMMITTER_NAME: "github-actions[bot]"
17
- GIT_COMMITTER_EMAIL: "github-actions[bot]@users.noreply.github.com"
18
- description: |
19
- Applies reviewer feedback to an open pull request the bot authored, then pushes the fixes to
20
- the same branch. Called by the Work Router; does not trigger on public events.
21
-
22
- `target: triggering` is enough for the push here, so unlike the merge gate this needs no
23
- wildcard fetch: the event is the pull request and gh-aw has already checked out its head.
24
-
25
- name: "Agent: Apply Review"
26
-
27
- # Router-only worker. The Work Router owns triggers, classification, and rung 1-2 checks.
28
- # This workflow receives the classified inputs and runs rung 3+.
29
- imports:
30
- - github/gh-aw/.github/workflows/shared/opencode.md@v0.87.5
31
- - shared/platform-defaults.md
32
- - shared/opencode-ci.md
33
-
34
- on:
35
- workflow_call:
36
- inputs:
37
- pr-number:
38
- description: Pull request number to apply review feedback on.
39
- required: true
40
- type: string
41
- linked-issue:
42
- description: Issue number the pull request closes. May be empty.
43
- required: false
44
- type: string
45
-
46
- # Rung 4. Router has classified the event; this job validates PR ownership and checks for
47
- # substantive feedback. A custom job, not `on.steps`, because the prompt needs these values.
48
- jobs:
49
- subject:
50
- runs-on: agents-arc
51
- permissions:
52
- contents: read
53
- issues: read
54
- pull-requests: read
55
- outputs:
56
- found: ${{ steps.subject.outputs.found }}
57
- pr: ${{ steps.subject.outputs.pr }}
58
- issue: ${{ steps.subject.outputs.issue }}
59
- unresolved: ${{ steps.subject.outputs.unresolved }}
60
- steps:
61
- - name: Confirm this is our pull request and the feedback is substantive
62
- id: subject
63
- env:
64
- GH_TOKEN: ${{ github.token }}
65
- REPO: ${{ github.repository }}
66
- PR: ${{ inputs.pr-number }}
67
- LINKED_ISSUE: ${{ inputs.linked-issue }}
68
- run: |
69
- set -euo pipefail
70
-
71
- none() {
72
- echo "found=false" >> "$GITHUB_OUTPUT"
73
- echo "$1"
74
- exit 0
75
- }
76
-
77
- pr=$(gh pr view "$PR" --repo "$REPO" --json number,state,author,title,body)
78
- [ "$(printf '%s' "$pr" | jq -r '.state')" = "OPEN" ] || none "PR #$PR is not open"
79
-
80
- # Use GitHub's bot flag because App login formats differ across APIs.
81
- author=$(printf '%s' "$pr" | jq -r '.author.login')
82
- is_bot=$(printf '%s' "$pr" | jq -r '.author.is_bot')
83
- [ "$is_bot" = "true" ] || \
84
- none "PR #$PR was authored by $author, a human. Never push to a human's branch."
85
-
86
- # The issue this pull request closes, preferring the router-provided linked issue.
87
- if [ -n "$LINKED_ISSUE" ]; then
88
- issue="$LINKED_ISSUE"
89
- else
90
- issue=$(printf '%s' "$pr" | jq -r '.body // ""' \
91
- | grep -oiE '(close[sd]?|fixe?[sd]?|resolve[sd]?) +#[0-9]+' \
92
- | grep -oE '[0-9]+' | head -n 1 || true)
93
- fi
94
-
95
- # Unresolved review threads, from the API rather than from the model's reading of it.
96
- unresolved=$(gh api graphql -f query='
97
- query($owner:String!, $name:String!, $number:Int!) {
98
- repository(owner:$owner, name:$name) {
99
- pullRequest(number:$number) {
100
- reviewThreads(first:100) { nodes { isResolved isOutdated } }
101
- }
102
- }
103
- }' \
104
- -f owner="${REPO%/*}" -f name="${REPO#*/}" -F number="$PR" \
105
- --jq '[.data.repository.pullRequest.reviewThreads.nodes[]
106
- | select(.isResolved == false and .isOutdated == false)] | length')
107
-
108
- {
109
- echo "found=true"
110
- echo "pr=$PR"
111
- echo "issue=${issue:-}"
112
- echo "unresolved=$unresolved"
113
- } >> "$GITHUB_OUTPUT"
114
- echo "PR #$PR has $unresolved unresolved thread(s)"
115
-
116
- reserve:
117
- needs: subject
118
- if: needs.subject.outputs.found == 'true' && needs.subject.outputs.issue != ''
119
- runs-on: agents-arc
120
- permissions:
121
- contents: read
122
- issues: write
123
- steps:
124
- - name: Checkout workflow actions
125
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
126
- with:
127
- persist-credentials: false
128
- - name: Create bot token
129
- id: app-token
130
- uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
131
- with:
132
- client-id: ${{ secrets.BOT_APP_ID }}
133
- private-key: ${{ secrets.BOT_PRIVATE_KEY }}
134
- - name: Mark the linked issue as in progress
135
- uses: ./.github/actions/add-issue-labels
136
- with:
137
- token: ${{ steps.app-token.outputs.token }}
138
- issue-number: ${{ needs.subject.outputs.issue }}
139
- labels: ${{ env.WORKING_LABEL }}
140
- - name: Clear the human-needed flag
141
- uses: ./.github/actions/remove-issue-labels
142
- with:
143
- token: ${{ steps.app-token.outputs.token }}
144
- issue-number: ${{ needs.subject.outputs.issue }}
145
- labels: ${{ env.REVIEW_LABEL }}
146
- validate_output:
147
- needs: [activation, subject, agent, safe_outputs]
148
- if: always() && needs.agent.result == 'success' && needs.safe_outputs.result == 'success'
149
- runs-on: agents-arc
150
- permissions:
151
- contents: read
152
- pull-requests: read
153
- outputs:
154
- valid: ${{ steps.validate.outputs.valid }}
155
- outcome: ${{ steps.validate.outputs.outcome }}
156
- steps:
157
- - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
158
- with:
159
- persist-credentials: false
160
- - id: output
161
- uses: ./.github/actions/download-agent-output
162
- with:
163
- artifact-name: ${{ needs.activation.outputs.artifact_prefix }}agent
164
- - name: Load unresolved review threads
165
- env:
166
- GH_TOKEN: ${{ github.token }}
167
- REPO: ${{ github.repository }}
168
- PR: ${{ needs.subject.outputs.pr }}
169
- run: |
170
- set -euo pipefail
171
- gh api graphql -f query='
172
- query($owner:String!, $name:String!, $number:Int!) {
173
- repository(owner:$owner, name:$name) {
174
- pullRequest(number:$number) {
175
- reviewThreads(first:100) { nodes { id isResolved isOutdated } }
176
- }
177
- }
178
- }' -f owner="${REPO%/*}" -f name="${REPO#*/}" -F number="$PR" \
179
- --jq '.data.repository.pullRequest.reviewThreads.nodes' > /tmp/review-threads.json
180
- - id: validate
181
- uses: ./.github/actions/validate-review-output
182
- with:
183
- output-file: ${{ steps.output.outputs.output-file }}
184
- pr-number: ${{ needs.subject.outputs.pr }}
185
- review-threads-file: /tmp/review-threads.json
186
- conclude:
187
- needs: [activation, subject, agent, safe_outputs, validate_output]
188
- if: >
189
- needs.agent.result == 'success' &&
190
- needs.safe_outputs.result == 'success' &&
191
- needs.validate_output.outputs.valid == 'true'
192
- runs-on: agents-arc
193
- permissions:
194
- contents: write
195
- issues: write
196
- pull-requests: write
197
- steps:
198
- - name: Create bot token
199
- id: app-token
200
- uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
201
- with:
202
- client-id: ${{ secrets.BOT_APP_ID }}
203
- private-key: ${{ secrets.BOT_PRIVATE_KEY }}
204
- - name: Checkout repository
205
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
206
- with:
207
- token: ${{ steps.app-token.outputs.token }}
208
- fetch-depth: 0
209
- - name: Apply agent output
210
- uses: ./.github/actions/apply-agent-output
211
- with:
212
- artifact-name: ${{ needs.activation.outputs.artifact_prefix }}agent
213
- token: ${{ steps.app-token.outputs.token }}
214
- push-to-branch: 'true'
215
- apply-labels: 'false'
216
- - name: Release implemented review
217
- if: needs.validate_output.outputs.outcome == 'implemented'
218
- uses: ./.github/actions/remove-issue-labels
219
- with:
220
- token: ${{ steps.app-token.outputs.token }}
221
- issue-number: ${{ needs.subject.outputs.issue }}
222
- labels: ${{ env.WORKING_LABEL }}
223
- - name: Flag review outcome
224
- if: needs.validate_output.outputs.outcome != 'implemented'
225
- uses: ./.github/actions/add-issue-labels
226
- with:
227
- token: ${{ steps.app-token.outputs.token }}
228
- issue-number: ${{ needs.subject.outputs.issue }}
229
- labels: ${{ env.REVIEW_LABEL }}
230
- - name: Release review outcome
231
- if: needs.validate_output.outputs.outcome != 'implemented'
232
- uses: ./.github/actions/remove-issue-labels
233
- with:
234
- token: ${{ steps.app-token.outputs.token }}
235
- issue-number: ${{ needs.subject.outputs.issue }}
236
- labels: |
237
- ${{ env.WORKING_LABEL }}
238
- ${{ env.PR_PENDING_LABEL }}
239
- incomplete:
240
- needs: [subject, agent, safe_outputs, validate_output]
241
- if: >
242
- always() &&
243
- needs.subject.outputs.found == 'true' &&
244
- (needs.agent.result != 'success' || needs.safe_outputs.result != 'success' || needs.validate_output.outputs.valid != 'true')
245
- runs-on: agents-arc
246
- permissions:
247
- contents: read
248
- issues: write
249
- steps:
250
- - name: Checkout workflow actions
251
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
252
- with:
253
- persist-credentials: false
254
- - name: Create bot token
255
- id: app-token
256
- uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
257
- with:
258
- client-id: ${{ secrets.BOT_APP_ID }}
259
- private-key: ${{ secrets.BOT_PRIVATE_KEY }}
260
- - name: Release the issue
261
- uses: ./.github/actions/remove-issue-labels
262
- with:
263
- token: ${{ steps.app-token.outputs.token }}
264
- issue-number: ${{ needs.subject.outputs.issue }}
265
- labels: ${{ env.WORKING_LABEL }}
266
- - name: Flag for human review
267
- uses: ./.github/actions/add-issue-labels
268
- with:
269
- token: ${{ steps.app-token.outputs.token }}
270
- issue-number: ${{ needs.subject.outputs.issue }}
271
- labels: ${{ env.REVIEW_LABEL }}
272
- - name: Report missing review feedback outcome
273
- uses: ./.github/actions/create-issue-comment
274
- with:
275
- token: ${{ steps.app-token.outputs.token }}
276
- issue-number: ${{ needs.subject.outputs.issue }}
277
- body: |
278
- ${{ env.REVIEW_MARKER }}
279
- ${{ env.INCOMPLETE_COMMENT }}
280
- [View this workflow run](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})
281
-
282
- if: needs.subject.outputs.found == 'true'
283
-
284
- runs-on: agents-arc
285
- runs-on-slim: agents-arc
286
-
287
- secrets:
288
- OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
289
-
290
- engine:
291
- id: opencode
292
- version: "1.2.14"
293
- env:
294
- OPENAI_BASE_URL: https://forge.plainconcepts.com/v1
295
-
296
- model: openai/glm-5-3
297
-
298
- max-turns: 300
299
- max-turn-cache-misses: 3000
300
- max-ai-credits: 5000
301
-
302
-
303
- permissions: read-all
304
-
305
- # Rung 3. A reviewer often makes one point across several comments, so the agent needs the
306
- # whole conversation, not just the one that triggered it. Fetching all of it is deterministic.
307
- steps:
308
- - name: Load the issue context
309
- uses: ./.github/actions/load-issue-context
310
- with:
311
- token: ${{ github.token }}
312
- issue-number: ${{ needs.subject.outputs.issue }}
313
- output-path: ${{ env.ISSUE_CONTEXT_PATH }}
314
- - name: Fetch the whole review conversation and the diff
315
- env:
316
- GH_TOKEN: ${{ github.token }}
317
- REPO: ${{ github.repository }}
318
- PR: ${{ inputs.pr-number }}
319
- run: |
320
- set -euo pipefail
321
- mkdir -p /tmp/gh-aw/agent
322
- gh pr diff "$PR" --repo "$REPO" > /tmp/gh-aw/agent/diff.patch
323
- gh api "repos/$REPO/pulls/$PR/comments" --paginate \
324
- --jq '[.[] | {id, path, line, author: .user.login, body, in_reply_to_id}]' \
325
- > /tmp/gh-aw/agent/review-comments.json
326
- gh api "repos/$REPO/issues/$PR/comments" --paginate \
327
- --jq '[.[] | {author: .user.login, body}]' \
328
- > /tmp/gh-aw/agent/conversation.json
329
- gh api graphql -f query='
330
- query($owner:String!, $name:String!, $number:Int!) {
331
- repository(owner:$owner, name:$name) {
332
- pullRequest(number:$number) {
333
- reviewThreads(first:100) {
334
- nodes { id
335
- isResolved isOutdated path
336
- comments(first:50) { nodes { author { login } body } }
337
- }
338
- }
339
- }
340
- }
341
- }' \
342
- -f owner="${REPO%/*}" -f name="${REPO#*/}" -F number="$PR" \
343
- --jq '.data.repository.pullRequest.reviewThreads.nodes' \
344
- > /tmp/gh-aw/agent/review-threads.json
345
-
346
- safe-outputs:
347
- # A failed run is already a red run. An issue per failure buries the real backlog
348
- # under noise nobody closes.
349
- report-failure-as-issue: false
350
- threat-detection: false
351
- # target "*" because these workers are dispatched, not triggered by the pull request:
352
- # the default "triggering" target has no pull request in context and rejects the push
353
- # with "requires pull request context", so the agent's fix is computed and discarded.
354
- push-to-pull-request-branch:
355
- target: "*"
356
- add-comment:
357
- target: "*"
358
-
359
-
360
- timeout-minutes: 45
361
- ---
362
-
363
- 1. You are applying review feedback to pull request
364
- **#${{ needs.subject.outputs.pr }}**, which has
365
- **${{ needs.subject.outputs.unresolved }}** unresolved review thread(s).
366
-
367
- It has already been confirmed that this pull request is open, that we authored it, and that
368
- the reviewer has write access. Do not re-check any of that.
369
-
370
- 2. Read `${{ env.ISSUE_CONTEXT_PATH }}`. It contains the issue body and discussion this pull
371
- request closes. The acceptance criteria there define what the implementation must still
372
- satisfy after the feedback is applied.
373
-
374
- 3. Read the whole conversation, not just the comment that triggered you. It is already on disk:
375
-
376
- - `/tmp/gh-aw/agent/review-threads.json` , every thread with its resolved and outdated state
377
- - `/tmp/gh-aw/agent/review-comments.json` , every inline comment with its file and line
378
- - `/tmp/gh-aw/agent/conversation.json` , every conversation comment
379
- - `/tmp/gh-aw/agent/diff.patch` , the current diff
380
-
381
- A reviewer often makes one point across several comments. Applying them one at a time
382
- produces contradictory commits, so read everything before changing anything.
383
-
384
- 4. Work out which items are genuinely actionable and still outstanding. Skip anything already
385
- addressed by a later commit, anything a bot wrote, anything from the pull request author,
386
- and anything that is a question rather than a request. You must account for every unresolved
387
- human review thread by its `PRRT_...` ID. Do not claim feedback was implemented when no branch
388
- change is needed: that requires reviewer confirmation.
389
-
390
- 5. Load only skills required by the feedback, then apply it. Make only changes the feedback
391
- justifies: a review comment is not licence for unrelated refactoring. Never read outside this
392
- repository root. Follow repository documentation and established conventions. Keep changes
393
- focused, protect secrets, and do not modify generated files unless the feedback requires it.
394
- Adhere to ${{ env.REPO_RULES }}.
395
-
396
- 6. Run the repository verification commands below. The issue context at
397
- `${{ env.ISSUE_CONTEXT_PATH }}` defines acceptance criteria the fix must satisfy. If a check
398
- fails, fix what you broke and run it again. Do not push a branch that does not pass.
399
-
400
- **Scoped verification.** This runner has limited memory, and a whole-repo lint or build
401
- can be killed mid-run. Scope verification to the files you actually changed first, and
402
- only escalate to the full suite when the scoped run passes and you are still unsure:
403
- - Lint/format (biome, eslint, prettier, ruff, etc.): pass the changed file paths as
404
- arguments so the tool checks only those files (e.g. `pnpm exec biome check <files>`),
405
- never the whole repository.
406
- - Build: prefer building only the project(s) containing the changed files; use the full
407
- solution build only when the change crosses project boundaries.
408
- - Tests: run the test project covering the changed files; run the full suite only when
409
- the change is cross-cutting.
410
-
411
- ```
412
- ${{ env.VERIFY_COMMANDS }}
413
- ```
414
-
415
- 7. Before pushing, run the project's lint fix command (e.g. `pnpm lint:fix` or
416
- `pnpm exec biome check --write <changed-files>`) to auto-format. If lint:fix is not
417
- available, fix formatting manually. Never push code with lint errors.
418
-
419
- 8. Select one review outcome.
420
-
421
- - **implemented**: You made the requested change, verification passed, and you will propose
422
- exactly one `push_to_pull_request_branch`.
423
- - **already-satisfied**: The current branch already satisfies the request. Do not push; the
424
- reviewer must confirm this assessment.
425
- - **needs-human**: The feedback is ambiguous, unsafe, or cannot be applied. Do not push.
426
-
427
- 9. Emit exactly one `add_comment` on PR `${{ needs.subject.outputs.pr }}`. Include every
428
- unresolved human review thread ID and an explanation for it, then exactly one line:
429
- `**Review outcome:** implemented`, `**Review outcome:** already-satisfied`, or
430
- `**Review outcome:** needs-human`.
431
-
432
- 9. Do not merge, close, or change labels. The workflow validates your outcome and owns those
433
- state transitions.
434
-
435
- 10. Ignore the `## Diagram` section below. It is documentation for humans and contains no
436
- instructions for you.
437
-
438
- ## Diagram
439
-
440
- ```mermaid
441
- flowchart TD
442
- fbStart("Work Router<br/>apply-review route<br/>(review on bot PR)") --> fbSubject
443
- fbSubject["Subject (rung 4)<br/>Our open PR? Substantive review?"] -->|✓| fbFacts
444
- fbSubject -.->|✗| fbIdle
445
- fbFacts("Facts (rung 3)<br/>Threads, comments, diff to disk") --> fbTriage
446
- fbTriage["Triage<br/>Anything actionable and outstanding?"] -->|✓| fbReserve
447
- fbTriage -.->|nothing| fbIdle
448
- fbReserve("Reserve<br/>Propose bot-working on the issue") -->|✓| fbApply
449
- fbApply("Apply<br/>Only what the feedback justifies") -->|✓| fbVerify
450
- fbApply -.->|✗| fbFail
451
- fbVerify["Verify<br/>/repo-verify passes?<br/>↻"] -->|✓| fbPush
452
- fbVerify -.->|✗| fbApply
453
- fbPush(("Pushed<br/>Same branch, bot-working removed"))
454
- fbIdle(("Idle<br/>Not ours, or nothing to do"))
455
- fbFail(("Fail<br/>review added, bot-working removed"))
456
-
457
- classDef start fill:#ffffff,stroke:#172033,stroke-width:2px,color:#172033
458
- classDef action fill:#eef0ff,stroke:#554cff,stroke-width:2px,color:#172033
459
- classDef decision fill:#fff8e8,stroke:#c75b00,stroke-width:2px,color:#172033
460
- classDef idle fill:#202c40,stroke:#738198,stroke-width:2px,color:#ffffff
461
- classDef failure fill:#fff0f0,stroke:#ef2929,stroke-width:2px,color:#8b1a1a
462
- classDef success fill:#e8f8ec,stroke:#18883c,stroke-width:2px,color:#145a32
463
- class fbStart start
464
- class fbFacts,fbReserve,fbApply action
465
- class fbSubject,fbTriage,fbVerify decision
466
- class fbIdle idle
467
- class fbFail failure
468
- class fbPush success
469
- ```
1
+ ---
2
+ # Managed by @plainconceptsplatform/workflows. Source: loops/workflows/agent-apply-review.md. Update with `workflows update --force`; consumer edits may be overwritten.
3
+ env:
4
+ # Printed by the prompt as the verification block. Consumers set their own commands.
5
+ VERIFY_COMMANDS: ""
6
+ REPO_RULES: "Apply only actionable outstanding reviewer feedback to the selected bot pull request. Make minimal changes that address each comment. Preserve architecture and do not weaken tests. Run full verification after changes."
7
+ WORKING_LABEL: bot-working
8
+ REVIEW_LABEL: review
9
+ # Marks a park the machine caused — a crash, a timeout, an empty output — as opposed to one it
10
+ # decided on. The janitor retries these after a while and never touches a decision park, because
11
+ # re-running a decision produces the same decision. Created idempotently where it is applied.
12
+ STALLED_LABEL: stalled
13
+ PR_PENDING_LABEL: pr-pending
14
+ REVIEW_MARKER: "<!-- agent-apply-review -->"
15
+ INCOMPLETE_COMMENT: "Applying the review feedback ended without an outcome. This worker has no retry of its own: it runs again when somebody reviews or comments on the pull request, and the issue is flagged so it is not lost until then."
16
+ ISSUE_CONTEXT_PATH: /tmp/gh-aw/agent/issue-context.json
17
+ GH_AW_ALLOWED_BOTS: "platform-devbox[bot],github-actions[bot]"
18
+ GIT_AUTHOR_NAME: "github-actions[bot]"
19
+ GIT_AUTHOR_EMAIL: "github-actions[bot]@users.noreply.github.com"
20
+ GIT_COMMITTER_NAME: "github-actions[bot]"
21
+ GIT_COMMITTER_EMAIL: "github-actions[bot]@users.noreply.github.com"
22
+ description: |
23
+ Applies reviewer feedback to an open pull request the bot authored, then pushes the fixes to
24
+ the same branch. Called by the Work Router; does not trigger on public events.
25
+
26
+ `target: triggering` is enough for the push here, so unlike the merge gate this needs no
27
+ wildcard fetch: the event is the pull request and gh-aw has already checked out its head.
28
+
29
+ name: "Agent: Apply Review"
30
+
31
+ # Router-only worker. The Work Router owns triggers, classification, and rung 1-2 checks.
32
+ # This workflow receives the classified inputs and runs rung 3+.
33
+ imports:
34
+ - github/gh-aw/.github/workflows/shared/opencode.md@v0.87.5
35
+ - shared/platform-defaults.md
36
+ - shared/opencode-ci.md
37
+
38
+ on:
39
+ workflow_call:
40
+ inputs:
41
+ pr-number:
42
+ description: Pull request number to apply review feedback on.
43
+ required: true
44
+ type: string
45
+ linked-issue:
46
+ description: Issue number the pull request closes. May be empty.
47
+ required: false
48
+ type: string
49
+
50
+ # Rung 4. Router has classified the event; this job validates PR ownership and checks for
51
+ # substantive feedback. A custom job, not `on.steps`, because the prompt needs these values.
52
+ jobs:
53
+ subject:
54
+ runs-on: agents-arc
55
+ permissions:
56
+ contents: read
57
+ issues: read
58
+ pull-requests: read
59
+ outputs:
60
+ found: ${{ steps.subject.outputs.found }}
61
+ pr: ${{ steps.subject.outputs.pr }}
62
+ issue: ${{ steps.subject.outputs.issue }}
63
+ unresolved: ${{ steps.subject.outputs.unresolved }}
64
+ steps:
65
+ - name: Confirm this is our pull request and the feedback is substantive
66
+ id: subject
67
+ env:
68
+ GH_TOKEN: ${{ github.token }}
69
+ REPO: ${{ github.repository }}
70
+ PR: ${{ inputs.pr-number }}
71
+ LINKED_ISSUE: ${{ inputs.linked-issue }}
72
+ run: |
73
+ set -euo pipefail
74
+
75
+ none() {
76
+ echo "found=false" >> "$GITHUB_OUTPUT"
77
+ echo "$1"
78
+ exit 0
79
+ }
80
+
81
+ pr=$(gh pr view "$PR" --repo "$REPO" --json number,state,author,title,body)
82
+ [ "$(printf '%s' "$pr" | jq -r '.state')" = "OPEN" ] || none "PR #$PR is not open"
83
+
84
+ # Use GitHub's bot flag because App login formats differ across APIs.
85
+ author=$(printf '%s' "$pr" | jq -r '.author.login')
86
+ is_bot=$(printf '%s' "$pr" | jq -r '.author.is_bot')
87
+ [ "$is_bot" = "true" ] || \
88
+ none "PR #$PR was authored by $author, a human. Never push to a human's branch."
89
+
90
+ # The issue this pull request closes, preferring the router-provided linked issue.
91
+ if [ -n "$LINKED_ISSUE" ]; then
92
+ issue="$LINKED_ISSUE"
93
+ else
94
+ issue=$(printf '%s' "$pr" | jq -r '.body // ""' \
95
+ | grep -oiE '(close[sd]?|fixe?[sd]?|resolve[sd]?) +#[0-9]+' \
96
+ | grep -oE '[0-9]+' | head -n 1 || true)
97
+ fi
98
+
99
+ # Unresolved review threads, from the API rather than from the model's reading of it.
100
+ unresolved=$(gh api graphql -f query='
101
+ query($owner:String!, $name:String!, $number:Int!) {
102
+ repository(owner:$owner, name:$name) {
103
+ pullRequest(number:$number) {
104
+ reviewThreads(first:100) { nodes { isResolved isOutdated } }
105
+ }
106
+ }
107
+ }' \
108
+ -f owner="${REPO%/*}" -f name="${REPO#*/}" -F number="$PR" \
109
+ --jq '[.data.repository.pullRequest.reviewThreads.nodes[]
110
+ | select(.isResolved == false and .isOutdated == false)] | length')
111
+
112
+ {
113
+ echo "found=true"
114
+ echo "pr=$PR"
115
+ echo "issue=${issue:-}"
116
+ echo "unresolved=$unresolved"
117
+ } >> "$GITHUB_OUTPUT"
118
+ echo "PR #$PR has $unresolved unresolved thread(s)"
119
+
120
+ reserve:
121
+ needs: subject
122
+ if: needs.subject.outputs.found == 'true' && needs.subject.outputs.issue != ''
123
+ runs-on: agents-arc
124
+ permissions:
125
+ contents: read
126
+ issues: write
127
+ steps:
128
+ - name: Checkout workflow actions
129
+ uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
130
+ with:
131
+ persist-credentials: false
132
+ - name: Create bot token
133
+ id: app-token
134
+ uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
135
+ with:
136
+ client-id: ${{ secrets.BOT_APP_ID }}
137
+ private-key: ${{ secrets.BOT_PRIVATE_KEY }}
138
+ - name: Mark the linked issue as in progress
139
+ uses: ./.github/actions/add-issue-labels
140
+ with:
141
+ token: ${{ steps.app-token.outputs.token }}
142
+ issue-number: ${{ needs.subject.outputs.issue }}
143
+ labels: ${{ env.WORKING_LABEL }}
144
+ - name: Clear the human-needed flag
145
+ uses: ./.github/actions/remove-issue-labels
146
+ with:
147
+ token: ${{ steps.app-token.outputs.token }}
148
+ issue-number: ${{ needs.subject.outputs.issue }}
149
+ labels: |-
150
+ ${{ env.REVIEW_LABEL }}
151
+ ${{ env.STALLED_LABEL }}
152
+ validate_output:
153
+ needs: [activation, subject, agent, safe_outputs]
154
+ if: always() && needs.agent.result == 'success' && needs.safe_outputs.result == 'success'
155
+ runs-on: agents-arc
156
+ permissions:
157
+ contents: read
158
+ pull-requests: read
159
+ outputs:
160
+ valid: ${{ steps.validate.outputs.valid }}
161
+ outcome: ${{ steps.validate.outputs.outcome }}
162
+ steps:
163
+ - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
164
+ with:
165
+ persist-credentials: false
166
+ - id: output
167
+ uses: ./.github/actions/download-agent-output
168
+ with:
169
+ artifact-name: ${{ needs.activation.outputs.artifact_prefix }}agent
170
+ - name: Load unresolved review threads
171
+ env:
172
+ GH_TOKEN: ${{ github.token }}
173
+ REPO: ${{ github.repository }}
174
+ PR: ${{ needs.subject.outputs.pr }}
175
+ run: |
176
+ set -euo pipefail
177
+ gh api graphql -f query='
178
+ query($owner:String!, $name:String!, $number:Int!) {
179
+ repository(owner:$owner, name:$name) {
180
+ pullRequest(number:$number) {
181
+ reviewThreads(first:100) { nodes { id isResolved isOutdated } }
182
+ }
183
+ }
184
+ }' -f owner="${REPO%/*}" -f name="${REPO#*/}" -F number="$PR" \
185
+ --jq '.data.repository.pullRequest.reviewThreads.nodes' > /tmp/review-threads.json
186
+ - id: validate
187
+ uses: ./.github/actions/validate-review-output
188
+ with:
189
+ output-file: ${{ steps.output.outputs.output-file }}
190
+ pr-number: ${{ needs.subject.outputs.pr }}
191
+ review-threads-file: /tmp/review-threads.json
192
+ conclude:
193
+ needs: [activation, subject, agent, safe_outputs, validate_output]
194
+ if: >
195
+ needs.agent.result == 'success' &&
196
+ needs.safe_outputs.result == 'success' &&
197
+ needs.validate_output.outputs.valid == 'true'
198
+ runs-on: agents-arc
199
+ permissions:
200
+ contents: write
201
+ issues: write
202
+ pull-requests: write
203
+ steps:
204
+ - name: Create bot token
205
+ id: app-token
206
+ uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
207
+ with:
208
+ client-id: ${{ secrets.BOT_APP_ID }}
209
+ private-key: ${{ secrets.BOT_PRIVATE_KEY }}
210
+ - name: Checkout repository
211
+ uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
212
+ with:
213
+ token: ${{ steps.app-token.outputs.token }}
214
+ fetch-depth: 0
215
+ - name: Apply agent output
216
+ uses: ./.github/actions/apply-agent-output
217
+ with:
218
+ artifact-name: ${{ needs.activation.outputs.artifact_prefix }}agent
219
+ token: ${{ steps.app-token.outputs.token }}
220
+ push-to-branch: 'true'
221
+ apply-labels: 'false'
222
+ - name: Release implemented review
223
+ if: needs.validate_output.outputs.outcome == 'implemented'
224
+ uses: ./.github/actions/remove-issue-labels
225
+ with:
226
+ token: ${{ steps.app-token.outputs.token }}
227
+ issue-number: ${{ needs.subject.outputs.issue }}
228
+ labels: ${{ env.WORKING_LABEL }}
229
+ - name: Flag review outcome
230
+ if: needs.validate_output.outputs.outcome != 'implemented'
231
+ uses: ./.github/actions/add-issue-labels
232
+ with:
233
+ token: ${{ steps.app-token.outputs.token }}
234
+ issue-number: ${{ needs.subject.outputs.issue }}
235
+ labels: ${{ env.REVIEW_LABEL }}
236
+ # Only the reservation comes off. pr-pending says a pull request for this issue is open and
237
+ # waiting, which is still true on both outcomes that reach here: already-satisfied and
238
+ # needs-human both leave the pull request open. Stripping it made the board show issues
239
+ # with open pull requests as having none — the exact bug the merge gate's own comment warns
240
+ # about, in the one file the route matrix was not checking.
241
+ - name: Release review outcome
242
+ if: needs.validate_output.outputs.outcome != 'implemented'
243
+ uses: ./.github/actions/remove-issue-labels
244
+ with:
245
+ token: ${{ steps.app-token.outputs.token }}
246
+ issue-number: ${{ needs.subject.outputs.issue }}
247
+ labels: ${{ env.WORKING_LABEL }}
248
+ incomplete:
249
+ needs: [subject, agent, safe_outputs, validate_output]
250
+ if: >
251
+ always() &&
252
+ needs.subject.outputs.found == 'true' &&
253
+ (needs.agent.result != 'success' || needs.safe_outputs.result != 'success' || needs.validate_output.outputs.valid != 'true')
254
+ runs-on: agents-arc
255
+ permissions:
256
+ contents: read
257
+ issues: write
258
+ steps:
259
+ - name: Checkout workflow actions
260
+ uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
261
+ with:
262
+ persist-credentials: false
263
+ - name: Create bot token
264
+ id: app-token
265
+ uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
266
+ with:
267
+ client-id: ${{ secrets.BOT_APP_ID }}
268
+ private-key: ${{ secrets.BOT_PRIVATE_KEY }}
269
+ - name: Release the issue
270
+ uses: ./.github/actions/remove-issue-labels
271
+ with:
272
+ token: ${{ steps.app-token.outputs.token }}
273
+ issue-number: ${{ needs.subject.outputs.issue }}
274
+ labels: ${{ env.WORKING_LABEL }}
275
+ - name: Flag for human review
276
+ uses: ./.github/actions/add-issue-labels
277
+ with:
278
+ token: ${{ steps.app-token.outputs.token }}
279
+ issue-number: ${{ needs.subject.outputs.issue }}
280
+ labels: |-
281
+ ${{ env.REVIEW_LABEL }}
282
+ ${{ env.STALLED_LABEL }}
283
+ - name: Report missing review feedback outcome
284
+ uses: ./.github/actions/create-issue-comment
285
+ with:
286
+ token: ${{ steps.app-token.outputs.token }}
287
+ issue-number: ${{ needs.subject.outputs.issue }}
288
+ body: |
289
+ ${{ env.REVIEW_MARKER }}
290
+ ${{ env.INCOMPLETE_COMMENT }}
291
+ [View this workflow run](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})
292
+
293
+ if: needs.subject.outputs.found == 'true'
294
+
295
+ runs-on: agents-arc
296
+ runs-on-slim: agents-arc
297
+
298
+ secrets:
299
+ OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
300
+
301
+ engine:
302
+ id: opencode
303
+ version: "1.2.14"
304
+ env:
305
+ OPENAI_BASE_URL: https://forge.plainconcepts.com/v1
306
+
307
+ model: openai/glm-5-3
308
+
309
+ max-turns: 300
310
+ max-turn-cache-misses: 3000
311
+ max-ai-credits: 5000
312
+
313
+
314
+ permissions: read-all
315
+
316
+ # Rung 3. A reviewer often makes one point across several comments, so the agent needs the
317
+ # whole conversation, not just the one that triggered it. Fetching all of it is deterministic.
318
+ steps:
319
+ - name: Load the issue context
320
+ uses: ./.github/actions/load-issue-context
321
+ with:
322
+ token: ${{ github.token }}
323
+ issue-number: ${{ needs.subject.outputs.issue }}
324
+ output-path: ${{ env.ISSUE_CONTEXT_PATH }}
325
+ - name: Fetch the whole review conversation and the diff
326
+ env:
327
+ GH_TOKEN: ${{ github.token }}
328
+ REPO: ${{ github.repository }}
329
+ PR: ${{ inputs.pr-number }}
330
+ run: |
331
+ set -euo pipefail
332
+ mkdir -p /tmp/gh-aw/agent
333
+ gh pr diff "$PR" --repo "$REPO" > /tmp/gh-aw/agent/diff.patch
334
+ gh api "repos/$REPO/pulls/$PR/comments" --paginate \
335
+ --jq '[.[] | {id, path, line, author: .user.login, body, in_reply_to_id}]' \
336
+ > /tmp/gh-aw/agent/review-comments.json
337
+ gh api "repos/$REPO/issues/$PR/comments" --paginate \
338
+ --jq '[.[] | {author: .user.login, body}]' \
339
+ > /tmp/gh-aw/agent/conversation.json
340
+ gh api graphql -f query='
341
+ query($owner:String!, $name:String!, $number:Int!) {
342
+ repository(owner:$owner, name:$name) {
343
+ pullRequest(number:$number) {
344
+ reviewThreads(first:100) {
345
+ nodes { id
346
+ isResolved isOutdated path
347
+ comments(first:50) { nodes { author { login } body } }
348
+ }
349
+ }
350
+ }
351
+ }
352
+ }' \
353
+ -f owner="${REPO%/*}" -f name="${REPO#*/}" -F number="$PR" \
354
+ --jq '.data.repository.pullRequest.reviewThreads.nodes' \
355
+ > /tmp/gh-aw/agent/review-threads.json
356
+
357
+ safe-outputs:
358
+ # A failed run is already a red run. An issue per failure buries the real backlog
359
+ # under noise nobody closes.
360
+ report-failure-as-issue: false
361
+ threat-detection: false
362
+ # target "*" because these workers are dispatched, not triggered by the pull request:
363
+ # the default "triggering" target has no pull request in context and rejects the push
364
+ # with "requires pull request context", so the agent's fix is computed and discarded.
365
+ push-to-pull-request-branch:
366
+ target: "*"
367
+ add-comment:
368
+ target: "*"
369
+
370
+
371
+ # The fleet is two machines, so this clock is also how long a stuck run can hold half of it.
372
+ # 240 went on to every worker at once when the provider was slow, which fixed the deaths and
373
+ # made every worker equally expensive to hang. These numbers are per worker: enough headroom
374
+ # for a slow gateway on the work it actually does, and not four hours for a run that reads one
375
+ # issue. Turns remain the guard against a confused agent looping; for a custom model the credit
376
+ # ceiling is models.dev fallback pricing and guards nothing.
377
+ #
378
+ # Applies review comments to an existing branch and verifies the result.
379
+ timeout-minutes: 90
380
+ ---
381
+
382
+ 1. You are applying review feedback to pull request
383
+ **#${{ needs.subject.outputs.pr }}**, which has
384
+ **${{ needs.subject.outputs.unresolved }}** unresolved review thread(s).
385
+
386
+ It has already been confirmed that this pull request is open, that we authored it, and that
387
+ the reviewer has write access. Do not re-check any of that.
388
+
389
+ 2. Read `${{ env.ISSUE_CONTEXT_PATH }}`. It contains the issue body and discussion this pull
390
+ request closes. The acceptance criteria there define what the implementation must still
391
+ satisfy after the feedback is applied.
392
+
393
+ 3. Read the whole conversation, not just the comment that triggered you. It is already on disk:
394
+
395
+ - `/tmp/gh-aw/agent/review-threads.json` , every thread with its resolved and outdated state
396
+ - `/tmp/gh-aw/agent/review-comments.json` , every inline comment with its file and line
397
+ - `/tmp/gh-aw/agent/conversation.json` , every conversation comment
398
+ - `/tmp/gh-aw/agent/diff.patch` , the current diff
399
+
400
+ A reviewer often makes one point across several comments. Applying them one at a time
401
+ produces contradictory commits, so read everything before changing anything.
402
+
403
+ 4. Work out which items are genuinely actionable and still outstanding. Skip anything already
404
+ addressed by a later commit, anything a bot wrote, anything from the pull request author,
405
+ and anything that is a question rather than a request. You must account for every unresolved
406
+ human review thread by its `PRRT_...` ID. Do not claim feedback was implemented when no branch
407
+ change is needed: that requires reviewer confirmation.
408
+
409
+ 5. Load only skills required by the feedback, then apply it. Make only changes the feedback
410
+ justifies: a review comment is not licence for unrelated refactoring. Never read outside this
411
+ repository root. Follow repository documentation and established conventions. Keep changes
412
+ focused, protect secrets, and do not modify generated files unless the feedback requires it.
413
+ Adhere to ${{ env.REPO_RULES }}.
414
+
415
+ 6. Run the repository verification commands below, under the verification rules above. The
416
+ issue context at `${{ env.ISSUE_CONTEXT_PATH }}` defines the acceptance criteria the fix
417
+ must satisfy. Never push a branch that does not pass.
418
+
419
+ ```
420
+ ${{ env.VERIFY_COMMANDS }}
421
+ ```
422
+
423
+ 7. Select one review outcome.
424
+
425
+ - **implemented**: You made the requested change, verification passed, and you will propose
426
+ exactly one `push_to_pull_request_branch`.
427
+ - **already-satisfied**: The current branch already satisfies the request. Do not push; the
428
+ reviewer must confirm this assessment.
429
+ - **needs-human**: The feedback is ambiguous, unsafe, or cannot be applied. Do not push.
430
+
431
+ 8. Emit exactly one `add_comment` on PR `${{ needs.subject.outputs.pr }}`. Include every
432
+ unresolved human review thread ID and an explanation for it, then exactly one line:
433
+ `**Review outcome:** implemented`, `**Review outcome:** already-satisfied`, or
434
+ `**Review outcome:** needs-human`.
435
+
436
+ 9. Do not merge, close, or change labels. The workflow validates your outcome and owns those
437
+ state transitions.
438
+