@plainconceptsplatform/workflows 0.6.1 → 0.16.0

package/loops/actions/report-workflow-errors/action.yml

@@ -0,0 +1,385 @@
+# Managed by @plainconceptsplatform/workflows. Source: loops/actions/report-workflow-errors/action.yml. Update with workflows update --force; consumer edits may be overwritten.
+name: Report workflow errors upstream
+description: >-
+  Summarise the last day of failures in the workflows this package ships and file the summary
+  upstream so the package can be improved. Deterministic: no model runs, and nothing that could
+  identify this repository or its contents leaves it.
+
+inputs:
+  token:
+    description: Token for THIS repository. Read-only; used to list runs and jobs.
+    required: true
+  upstream-token:
+    description: >-
+      Token that can open an issue in the upstream repository. Empty means compute the report,
+      attach it to the run, and file nothing.
+    required: false
+    default: ''
+  upstream-repo:
+    description: The repository the report is filed in, as owner/name.
+    required: false
+    default: PlainConceptsPlatform/Agentic-Workflows
+  lookback-hours:
+    description: How far back to look for failures.
+    required: false
+    default: '24'
+  dry-run:
+    description: Compute and print the report, file nothing.
+    required: false
+    default: 'false'
+
+outputs:
+  filed:
+    description: The upstream issue number, or empty if nothing was filed.
+    value: ${{ steps.report.outputs.filed }}
+
+runs:
+  using: composite
+  steps:
+    - name: Collect and file
+      id: report
+      uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
+      env:
+        UPSTREAM_TOKEN: ${{ inputs.upstream-token }}
+        UPSTREAM_REPO: ${{ inputs.upstream-repo }}
+        LOOKBACK_HOURS: ${{ inputs.lookback-hours }}
+        DRY_RUN: ${{ inputs.dry-run }}
+      with:
+        github-token: ${{ inputs.token }}
+        script: |
+          // Every consumer of this package is a private repository, and this is the one job that
+          // sends anything out of one. The rule it is built around: no free text ever leaves
+          // here. Not a log line, not a branch name, not an issue title, not a file path. What
+          // leaves is a fixed set of enumerable facts about workflows this package itself
+          // ships -- their names, their job and step names, conclusions, timings and counts --
+          // plus the NAME of a matched error pattern from the catalogue below. The final body
+          // is checked against a leak scanner and the job fails rather than files if the
+          // scanner trips.
+
+          const dryRun = process.env.DRY_RUN === 'true';
+          const upstreamToken = process.env.UPSTREAM_TOKEN;
+          const [upstreamOwner, upstreamName] = process.env.UPSTREAM_REPO.split('/');
+          const since = new Date(Date.now() - Number(process.env.LOOKBACK_HOURS) * 3600 * 1000);
+
+          // Only workflows this package ships. A consumer's own workflow name is theirs and can
+          // describe a product, a customer or an environment ("Deploy: <customer> staging"), so
+          // an allowlist by filename is the boundary. Anything not matching is counted and
+          // otherwise ignored.
+          const OWNED = /^(work-router|agent-(refine|implement|triage|apply-review|merge-gate|audit|release)|authorize-bot-work|agentics-(checks|maintenance))\.(yml|lock\.yml)$/;
+          const ownedName = (path) => (path ?? '').split('/').pop() ?? '';
+
+          // The catalogue. Each entry is a failure shape worth fixing in the package. Only the
+          // `id` is ever reported -- never the text that matched it, because the surrounding log
+          // line carries repository paths, branch names and issue titles.
+          const CATALOGUE = [
+            { id: 'runner-never-assigned', test: /waiting for a runner|no runner matching|requested labels/i, note: 'A job waited for a self-hosted runner that never arrived.' },
+            { id: 'runner-lost-mid-job', test: /lost communication with the server|runner has received a shutdown signal|The self-hosted runner:.*lost/i, note: 'The runner disappeared while a job was running.' },
+            { id: 'job-cancelled-by-timeout', test: /The job running on runner .* has exceeded the maximum execution time|timeout-minutes/i, note: 'A job hit its timeout instead of finishing.' },
+            { id: 'out-of-disk', test: /no space left on device|You are running out of disk space/i, note: 'The runner ran out of disk.' },
+            { id: 'out-of-memory', test: /JavaScript heap out of memory|Killed\s+process|OOMKilled/i, note: 'A step was killed for memory.' },
+            { id: 'jq-error', test: /^jq: error|jq: error \(at/im, note: 'A jq filter in the router or an action died on its input.' },
+            { id: 'gh-api-403', test: /HTTP 403|Resource not accessible by integration/i, note: 'A step called an endpoint its token has no scope for.' },
+            { id: 'gh-api-404', test: /HTTP 404/i, note: 'A step called an endpoint or resource that does not exist.' },
+            { id: 'gh-api-rate-limit', test: /API rate limit exceeded|secondary rate limit/i, note: 'A step was rate limited.' },
+            { id: 'gh-api-409-conflict', test: /HTTP 409|Update is not a fast forward/i, note: 'A push or merge raced another writer.' },
+            { id: 'model-quota', test: /quota|insufficient_quota|429 Too Many Requests/i, note: 'The model gateway refused the request for quota reasons.' },
+            { id: 'model-gateway-unreachable', test: /ECONNREFUSED|ETIMEDOUT|getaddrinfo|502 Bad Gateway|503 Service Unavailable/i, note: 'The model gateway or another network dependency was unreachable.' },
+            { id: 'agent-produced-no-output', test: /no agent output|output file (is )?(missing|empty)|safe.outputs.*empty/i, note: 'The agent finished without emitting any safe output.' },
+            { id: 'lock-out-of-date', test: /lock file is out of date|recompile|\.lock\.yml.*differs/i, note: 'A compiled lock file did not match its source.' },
+            { id: 'action-not-found', test: /Can't find '.*' in|Unable to resolve action/i, note: 'A workflow referenced an action or path that is not present.' },
+            { id: 'yaml-or-expression-invalid', test: /Invalid workflow file|Unrecognized named-value|Unexpected symbol/i, note: 'A workflow failed to parse or an expression did not evaluate.' },
+          ];
+
+          // The leak scanner. Runs on the finished body, and its failure is fatal: a report that
+          // might carry private information is not filed at all. Deliberately paranoid, because
+          // the cost of a false positive is one missing daily report and the cost of a false
+          // negative is a private repository described in a public-facing issue.
+          const owner = context.repo.owner;
+          const repo = context.repo.repo;
+          const leakChecks = [
+            { what: 'the repository name', test: new RegExp(`\\b${repo.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}\\b`, 'i') },
+            { what: 'the owner name', test: new RegExp(`\\b${owner.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}\\b`, 'i') },
+            { what: 'a github.com URL', test: /https?:\/\/[^\s)]*github\.com\/[A-Za-z0-9._-]+\/[A-Za-z0-9._-]+/ },
+            { what: 'an email address', test: /[A-Za-z0-9._%+-]+@[A-Za-z0-9.-]+\.[A-Za-z]{2,}/ },
+            { what: 'an absolute path', test: /(?:^|\s)(?:\/(?:home|Users|github|runner|mnt)\/|[A-Za-z]:\\)/m },
+            { what: 'a long hex or base64 blob that could be a token or a commit', test: /\b(?:gh[pousr]_[A-Za-z0-9]{16,}|[A-Za-z0-9+/]{40,}={0,2}|[0-9a-f]{32,})\b/ },
+            { what: 'an issue or pull request reference', test: /(?:^|[^A-Za-z0-9_/])#\d+/ },
+            { what: 'a branch or ref path', test: /\brefs\/heads\/|\b(?:feature|fix|chore|bot)\/[A-Za-z0-9._-]+/ },
+          ];
+
+          // Which version of the package is reporting. Without this a bug fixed weeks ago keeps
+          // arriving upstream with no way to tell it is stale: the first report filed by this
+          // job was 19 occurrences of a jq bug that a release had already fixed, and nothing in
+          // it said so. The version is the package's own name for itself, read from the
+          // ownership header the installer stamps, so it carries nothing of the repository.
+          let packageVersion = 'unknown';
+          try {
+            const header = require('node:fs')
+              .readFileSync('.github/workflows/work-router.yml', 'utf8')
+              .split('\n')[0];
+            packageVersion = /@plainconceptsplatform\/workflows@([0-9][0-9A-Za-z.\-+]*)/.exec(header)?.[1] ?? 'unknown';
+          } catch {
+            core.info('could not read the installed package version from the router header');
+          }
+
+          const runs = await github.paginate(github.rest.actions.listWorkflowRunsForRepo, {
+            ...context.repo, created: `>=${since.toISOString()}`, per_page: 100,
+          });
+
+          // signature -> what we know about it. The signature is the dedup key both here and
+          // upstream, and every part of it is package-owned or an enumerated value.
+          //
+          // THE FINDING SHAPE IS THE PRIVACY BOUNDARY. bodyFor() renders a finding, so a field
+          // added here is a field sent to another repository. These eight are all
+          // package-owned names or enumerated values; nothing derived from a log, a branch, a
+          // path or an issue belongs on this object. The route matrix asserts this exact list,
+          // so adding a ninth field fails the build rather than leaking on the next cron.
+          const FINDING_FIELDS = ['workflow', 'job', 'step', 'conclusion', 'patternId', 'count', 'runnerLabels', 'attempts'];
+          const findings = new Map();
+          let ownedRuns = 0;
+          let ownedFailures = 0;
+          let skippedForeign = 0;
+          let queueWaitTotal = 0;
+          let queueWaitCount = 0;
+          let queueWaitWorst = 0;
+
+          // A run that never gets a runner never fails: it sits queued until GitHub expires it
+          // a day later. On a two-VM fleet that is the most common way work disappears, and it
+          // is invisible in every failure count, so it is detected by state and age instead.
+          const STUCK_AFTER_MS = 45 * 60 * 1000;
+          let stuckInQueue = 0;
+
+          for (const run of runs) {
+            const file = ownedName(run.path);
+            if (!OWNED.test(file)) { skippedForeign += 1; continue; }
+            ownedRuns += 1;
+
+            if (['queued', 'waiting', 'pending'].includes(run.status) &&
+                Date.now() - new Date(run.created_at).getTime() > STUCK_AFTER_MS) {
+              stuckInQueue += 1;
+              const signature = `${file} · (whole run) · (never started) · queued · runner-never-assigned`;
+              const seen = findings.get(signature) ?? {
+                workflow: file, job: '(whole run)', step: '(never started)',
+                conclusion: 'queued', patternId: 'runner-never-assigned', count: 0,
+                runnerLabels: new Set(), attempts: new Set(),
+              };
+              seen.count += 1;
+              seen.attempts.add(run.run_attempt ?? 1);
+              findings.set(signature, seen);
+              continue;
+            }
+
+            if (!['failure', 'cancelled', 'timed_out', 'startup_failure'].includes(run.conclusion)) continue;
+            ownedFailures += 1;
+
+            let jobs = [];
+            try {
+              jobs = await github.paginate(github.rest.actions.listJobsForWorkflowRunAttempt, {
+                ...context.repo, run_id: run.id, attempt_number: run.run_attempt ?? 1, per_page: 100,
+              });
+            } catch { continue; }
+
+            for (const job of jobs) {
+              if (job.started_at && job.created_at) {
+                const wait = (new Date(job.started_at) - new Date(job.created_at)) / 1000;
+                if (wait >= 0) {
+                  queueWaitTotal += wait; queueWaitCount += 1;
+                  queueWaitWorst = Math.max(queueWaitWorst, Math.round(wait));
+                }
+              }
+              if (!['failure', 'cancelled', 'timed_out'].includes(job.conclusion)) continue;
+
+              const step = (job.steps ?? []).find((s) => ['failure', 'timed_out'].includes(s.conclusion));
+              // Job and step names come from files this package ships, so they are the
+              // package's own words. A `run-name` is not: it interpolates issue titles.
+              const stepName = step?.name ?? '(no failing step recorded)';
+
+              let patternId = 'unrecognised';
+              try {
+                const { data: log } = await github.rest.actions.downloadJobLogsForWorkflowRun({
+                  ...context.repo, job_id: job.id,
+                });
+                const text = typeof log === 'string' ? log : Buffer.from(log).toString('utf8');
+                // The tail is where the failure is, and reading less of the log is less to get
+                // wrong. Only the matched entry's id crosses into the report.
+                const tail = text.slice(-20000);
+                patternId = CATALOGUE.find((entry) => entry.test.test(tail))?.id ?? 'unrecognised';
+              } catch {
+                patternId = 'log-unavailable';
+              }
+
+              const signature = `${file} · ${job.name} · ${stepName} · ${job.conclusion} · ${patternId}`;
+              const seen = findings.get(signature) ?? {
+                workflow: file, job: job.name, step: stepName,
+                conclusion: job.conclusion, patternId, count: 0,
+                runnerLabels: new Set(), attempts: new Set(),
+              };
+              seen.count += 1;
+              seen.attempts.add(run.run_attempt ?? 1);
+              for (const label of job.labels ?? []) seen.runnerLabels.add(label);
+              findings.set(signature, seen);
+            }
+          }
+
+          const catalogueNote = (id) => CATALOGUE.find((entry) => entry.id === id)?.note
+            ?? (id === 'log-unavailable' ? 'The job log could not be read, so the failure could not be classified.'
+              : 'The log matched no known failure shape. Worth adding one to the catalogue.');
+
+          const ranked = [...findings.values()].sort((a, b) => b.count - a.count);
+          const hours = process.env.LOOKBACK_HOURS;
+
+          // Enforce the boundary at run time as well as in the build. A field that reached a
+          // finding by some path the static check did not see stops the job here rather than
+          // being rendered into an issue in another repository.
+          for (const finding of ranked) {
+            const unexpected = Object.keys(finding).filter((key) => !FINDING_FIELDS.includes(key));
+            if (unexpected.length > 0) {
+              core.setFailed(`a finding carries ${unexpected.join(', ')}, which is not in the reportable field list. Nothing was filed.`);
+              return;
+            }
+          }
+
+          const bodyFor = (finding) => [
+            `<!-- pcp-error-report: ${finding.workflow}|${finding.job}|${finding.step}|${finding.patternId} -->`,
+            '',
+            'Filed automatically by the `report-workflow-errors` job in a repository that installs',
+            'this package. It carries no information about that repository: only the names this',
+            'package gives its own workflows, jobs and steps, and a classification of the failure.',
+            '',
+            '| | |',
+            '|---|---|',
+            `| Workflow | \`${finding.workflow}\` |`,
+            `| Job | \`${finding.job}\` |`,
+            `| Failing step | \`${finding.step}\` |`,
+            `| Conclusion | \`${finding.conclusion}\` |`,
+            `| Classification | \`${finding.patternId}\` |`,
+            `| Runner labels | ${[...finding.runnerLabels].map((l) => `\`${l}\``).join(', ') || 'not reported'} |`,
+            `| Occurrences in the last ${hours}h | ${finding.count} |`,
+            `| Re-run attempts involved | ${[...finding.attempts].sort().join(', ')} |`,
+            `| Package version reporting | \`${packageVersion}\` |`,
+            '',
+            `**What this classification means.** ${catalogueNote(finding.patternId)}`,
+            '',
+            '### Occurrences',
+            '',
+            `- ${new Date().toISOString().slice(0, 10)}: ${finding.count} in ${hours}h, on \`${packageVersion}\``,
+          ].join('\n');
+
+          const titleFor = (finding) =>
+            `${finding.workflow}: ${finding.patternId} in "${finding.step}"`;
+
+          // The scanner. A body that trips it is never filed, and the job goes red so the
+          // pattern that produced it gets fixed rather than quietly dropped every night.
+          const scan = (text, label) => {
+            const tripped = leakChecks.filter((check) => check.test.test(text));
+            if (tripped.length === 0) return true;
+            core.error(`${label} was withheld: the leak scanner matched ${tripped.map((t) => t.what).join('; ')}`);
+            return false;
+          };
+
+          const summaryRows = ranked.map((f) => [
+            `\`${f.workflow}\``, `\`${f.job}\``, `\`${f.patternId}\``, String(f.count),
+          ]);
+          await core.summary
+            .addHeading('Workflow error report', 2)
+            .addList([
+              `Runs from workflows this package ships: ${ownedRuns}`,
+              `Of those, failed: ${ownedFailures}`,
+              `Runs from the repository's own workflows, not inspected: ${skippedForeign}`,
+              `Runs still queued after 45 minutes, so no runner ever took them: ${stuckInQueue}`,
+              `Distinct failure signatures: ${ranked.length}`,
+              queueWaitCount > 0
+                ? `Runner queue wait: ${Math.round(queueWaitTotal / queueWaitCount)}s mean, ${queueWaitWorst}s worst`
+                : 'Runner queue wait: no jobs started in the window',
+            ])
+            .addTable([
+              [{ data: 'Workflow', header: true }, { data: 'Job', header: true }, { data: 'Classification', header: true }, { data: 'Count', header: true }],
+              ...summaryRows,
+            ])
+            .write();
+
+          if (ranked.length === 0) {
+            core.info('No failures in the window for any workflow this package ships.');
+            core.setOutput('filed', '');
+            return;
+          }
+
+          // Build every report first and scan them all, so a leak is reported once with the
+          // full picture rather than one night at a time.
+          const reports = [];
+          let leaked = 0;
+          for (const finding of ranked) {
+            const title = titleFor(finding);
+            const body = bodyFor(finding);
+            if (!scan(`${title}\n${body}`, `The report for ${finding.patternId}`)) { leaked += 1; continue; }
+            reports.push({ finding, title, body });
+            core.info(`report ready: ${title} (${finding.count})`);
+          }
+
+          if (!upstreamToken) {
+            // Not silent and not red: the report exists in the job summary, and the run says
+            // plainly why it went no further.
+            core.warning(`${reports.length} report(s) computed but not filed: no upstream token is configured. The full report is in this job summary.`);
+            core.setOutput('filed', '');
+            if (leaked > 0) core.setFailed(`${leaked} report(s) were withheld by the leak scanner; fix the field that carried private text.`);
+            return;
+          }
+
+          const upstream = getOctokit(upstreamToken);
+          const filed = [];
+
+          for (const { finding, title, body } of reports) {
+            const marker = body.split('\n')[0];
+            // One issue per signature, updated rather than repeated. Searching by the marker
+            // keeps that true across every consumer: two repositories hitting the same package
+            // bug land on the same issue and its count is the number that matters.
+            let existing;
+            try {
+              const { data } = await upstream.rest.search.issuesAndPullRequests({
+                q: `repo:${upstreamOwner}/${upstreamName} is:issue is:open in:body "${marker}"`,
+                per_page: 5,
+              });
+              existing = data.items.find((item) => (item.body ?? '').includes(marker));
+            } catch (error) {
+              core.warning(`could not search upstream for an existing report: HTTP ${error.status ?? '?'}`);
+            }
+
+            if (dryRun) {
+              core.info(`[dry-run] would ${existing ? `append to #${existing.number}` : 'open an issue'}: ${title}`);
+              continue;
+            }
+
+            try {
+              if (existing) {
+                // Append one dated line rather than rewriting the body, so the history of how
+                // often this fires stays readable.
+                const line = `- ${new Date().toISOString().slice(0, 10)}: ${finding.count} in ${hours}h, on \`${packageVersion}\``;
+                const updated = (existing.body ?? '').includes(line)
+                  ? existing.body
+                  : `${existing.body}\n${line}`;
+                if (!scan(updated, `The appended report for ${finding.patternId}`)) { leaked += 1; continue; }
+                await upstream.rest.issues.update({
+                  owner: upstreamOwner, repo: upstreamName,
+                  issue_number: existing.number, body: updated,
+                });
+                filed.push(existing.number);
+                core.info(`appended to ${upstreamOwner}/${upstreamName}#${existing.number}`);
+              } else {
+                const { data: created } = await upstream.rest.issues.create({
+                  owner: upstreamOwner, repo: upstreamName, title, body,
+                  labels: ['fleet-error-report'],
+                });
+                filed.push(created.number);
+                core.info(`opened ${upstreamOwner}/${upstreamName}#${created.number}`);
+              }
+            } catch (error) {
+              // A missing label, a token without issues:write, a repository that moved. Say so;
+              // do not fail the whole report for one signature.
+              core.warning(`could not file the report for ${finding.patternId}: HTTP ${error.status ?? '?'} ${error.message ?? ''}`);
+            }
+          }
+
+          core.setOutput('filed', filed.join(','));
+          if (leaked > 0) {
+            core.setFailed(`${leaked} report(s) were withheld by the leak scanner. Nothing was filed for them; fix the field that carried private text.`);
+          }

package/loops/actions/validate-merge-gate-output/validate-merge-gate-output.sh

@@ -26,8 +26,20 @@ jq -r --arg issue "$issue_number" --arg conclusion "$ci_conclusion" '
       )
     | .[0] // "invalid") as $outcome
   | ([$items[] | select(.type == "push_to_pull_request_branch")] | length) as $pushes
+  # remediated used to require conclusion == "failure", which threw correct work away. The prompt
+  # tells the agent to merge main in, verify and push when CI is green but the pull request
+  # conflicts. That is a real and common state: a conflicting pull request has no merge ref, so
+  # GitHub can never run CI on that head, and the belt falls back to the last verdict on the
+  # branch, which is usually success. The agent did the job, the validator called it invalid,
+  # conclude was skipped, and because this worker stages its outputs the resolved merge commit
+  # was discarded. The belt then dispatched again on the same verdict, up to six times, each a
+  # full run on the single-slot merge belt. A push carrying a remediated verdict is remediation
+  # whatever CI last said; what still matters is that exactly one push comes with it.
+  #
+  # No apostrophes in here. This block sits inside the single-quoted jq program, and one
+  # apostrophe closes that string and breaks the script.
   | if $outcome == "merge" and $conclusion == "success" and $pushes == 0 then "merge"
-    elif $outcome == "remediated" and $conclusion == "failure" and $pushes == 1 then "remediated"
+    elif $outcome == "remediated" and $pushes == 1 then "remediated"
     elif $outcome == "review" and $pushes == 0 then "review"
     else "invalid"
     end

package/loops/actions/validate-triage-output/action.yml

@@ -13,7 +13,7 @@ outputs:
     description: Whether the output contains a usable triage comment with a verdict.
     value: ${{ steps.validate.outputs.valid }}
   outcome:
-    description: "Deterministic triage outcome: pass, needs-info, block, or invalid."
+    description: "Deterministic triage outcome: pass, needs-info, needs-maintainer, block, or invalid."
     value: ${{ steps.validate.outputs.outcome }}
 runs:
   using: composite

package/loops/actions/validate-triage-output/validate-triage-output.sh

@@ -1,6 +1,10 @@
 #!/usr/bin/env bash
 # Managed by @plainconceptsplatform/workflows. Source: loops/actions/validate-triage-output/validate-triage-output.sh. Update with `workflows update --force`; consumer edits may be overwritten.
-# Print the deterministic triage outcome: pass, needs-info, block, or invalid.
+# Print the deterministic triage outcome: pass, needs-info, needs-maintainer, block, or invalid.
+#
+# needs-maintainer and block are both refusals of product-owner intake, and they part company on what
+# happens next: needs-maintainer keeps the issue open with the review label so a maintainer can take it
+# on, block closes it. Neither value is a substring of another, so the alternation order below is free.
 
 set -euo pipefail
 
@@ -13,21 +17,21 @@ if [ ! -f "$output_file" ] || ! jq -e '.items | arrays' "$output_file" >/dev/nul
 fi
 
 # The agent emits exactly one add_comment on the source issue. The comment body
-# must contain a verdict line matching **Verdict:** pass|needs-info|block.
+# must contain a verdict line matching **Verdict:** pass|needs-info|needs-maintainer|block.
 # capture() returns an object — use a named group (?<v>...) to extract the value.
 # test() before capture() avoids jq errors on non-matching bodies.
 jq -r --arg issue "$issue_number" '
   def extract_verdict:
     [.items[] | select(.type == "add_comment" and (.item_number | tostring) == $issue and (.body | type == "string"))]
     | map(.body |
-      if test("\\*\\*Verdict:\\*\\*\\s*(pass|needs-info|block)"; "i") then
-        capture("\\*\\*Verdict:\\*\\*\\s*(?<v>pass|needs-info|block)"; "i").v | ascii_downcase
+      if test("\\*\\*Verdict:\\*\\*\\s*(pass|needs-info|needs-maintainer|block)"; "i") then
+        capture("\\*\\*Verdict:\\*\\*\\s*(?<v>pass|needs-info|needs-maintainer|block)"; "i").v | ascii_downcase
       else empty end
     )
     | .[0] // "none";
 
   extract_verdict as $verdict |
-  if $verdict == "pass" or $verdict == "needs-info" or $verdict == "block" then
+  if $verdict == "pass" or $verdict == "needs-info" or $verdict == "needs-maintainer" or $verdict == "block" then
     $verdict
   else
     "invalid"

package/loops/actions/verify-composite-actions/verify-composite-actions.sh

@@ -38,6 +38,59 @@ while IFS= read -r manifest; do
     continue
   fi
 
+  # `actions/github-script` steps carry real JavaScript inside a YAML string, and nothing on
+  # the way to production parses it: not the YAML check above, not actionlint, not gh aw
+  # compile. A typo there is a green push and a red run at whatever hour the schedule fires.
+  # The same shape of bug shipped in a jq filter in the router and broke an hourly job in a
+  # consumer for a day, so every inline script gets syntax-checked here.
+  #
+  # `${{ }}` is substituted before checking: it is a runner expression, not JavaScript, and
+  # standing in a string literal keeps the surrounding syntax intact.
+  scripts="$(python3 - "$manifest" <<'PY' 2>/dev/null || true
+import re, sys, yaml, pathlib, tempfile, os
+
+manifest = pathlib.Path(sys.argv[1])
+doc = yaml.safe_load(manifest.read_text(encoding='utf-8')) or {}
+out = []
+for index, step in enumerate(((doc.get('runs') or {}).get('steps') or [])):
+    if not isinstance(step, dict):
+        continue
+    if 'github-script' not in str(step.get('uses', '')):
+        continue
+    body = ((step.get('with') or {}).get('script'))
+    if not isinstance(body, str):
+        continue
+    body = re.sub(r'\$\{\{[^}]*\}\}', '"__expr__"', body)
+    # github-script runs the body as the content of an async function, so a top-level `return`
+    # and a top-level `await` are both legal there. Wrap it the same way or every early return
+    # reads as a syntax error.
+    handle, path = tempfile.mkstemp(suffix='.mjs')
+    with os.fdopen(handle, 'w', encoding='utf-8') as sink:
+        sink.write('async function __ghScript(github, context, core, exec, io, glob, require, getOctokit) {\n')
+        sink.write(body)
+        sink.write('\n}\n')
+    out.append('%s\t%s' % (step.get('name', 'step %d' % index), path))
+print('\n'.join(out))
+PY
+)"
+
+  script_ok=1
+  while IFS=$'\t' read -r step_name script_file; do
+    [ -n "${script_file:-}" ] || continue
+    if ! node --check "$script_file" 2>/tmp/node-check.err; then
+      script_ok=0
+      echo "FAIL: ${rel} step '${step_name}' has a JavaScript syntax error:" >&2
+      sed -n '1,6p' /tmp/node-check.err >&2
+    fi
+    rm -f "$script_file"
+  done <<<"$scripts"
+  rm -f /tmp/node-check.err
+
+  if [ "$script_ok" -eq 0 ]; then
+    FAIL=$((FAIL + 1))
+    continue
+  fi
+
   PASS=$((PASS + 1))
 done < <(find "$ACTIONS_DIR" -name 'action.yml' | sort)