@plainconceptsplatform/workflows 0.5.1 → 0.16.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (60) hide show
  1. package/README.md +105 -88
  2. package/dist/catalog-installation.d.ts +67 -0
  3. package/dist/catalog-installation.js +485 -0
  4. package/dist/catalog-listing.d.ts +13 -0
  5. package/dist/catalog-listing.js +70 -0
  6. package/dist/index.d.ts +2 -0
  7. package/dist/index.js +273 -0
  8. package/dist/package-baseline.d.ts +25 -0
  9. package/dist/package-baseline.js +138 -0
  10. package/dist/repository-inspection.d.ts +23 -0
  11. package/dist/repository-inspection.js +113 -0
  12. package/dist/route-processing.d.ts +4 -0
  13. package/dist/route-processing.js +80 -0
  14. package/dist/stack-defaults.d.ts +11 -0
  15. package/dist/stack-defaults.js +110 -0
  16. package/dist/tui.d.ts +25 -0
  17. package/dist/tui.js +271 -0
  18. package/dist/worker-env.d.ts +46 -0
  19. package/dist/worker-env.js +179 -0
  20. package/dist/workflow-catalog.d.ts +27 -0
  21. package/dist/workflow-catalog.js +57 -0
  22. package/loops/actions/add-issue-labels/action.yml +22 -2
  23. package/loops/actions/apply-agent-bundle/apply-bundle.sh +14 -1
  24. package/loops/actions/audit-close/action.yml +180 -128
  25. package/loops/actions/classify-route/action.yml +7 -0
  26. package/loops/actions/classify-route/classify-route.sh +28 -7
  27. package/loops/actions/cleanup-artifacts/action.yml +38 -12
  28. package/loops/actions/housekeeping/action.yml +251 -0
  29. package/loops/actions/identify-gate-subject/action.yml +3 -1
  30. package/loops/actions/merge-agent-pr/action.yml +13 -0
  31. package/loops/actions/remove-issue-labels/action.yml +4 -2
  32. package/loops/actions/report-workflow-errors/action.yml +385 -0
  33. package/loops/actions/validate-merge-gate-output/validate-merge-gate-output.sh +13 -1
  34. package/loops/actions/validate-refine-output/validate-refine-output.sh +18 -2
  35. package/loops/actions/validate-triage-output/action.yml +1 -1
  36. package/loops/actions/validate-triage-output/validate-triage-output.sh +9 -5
  37. package/loops/actions/verify-composite-actions/verify-composite-actions.sh +53 -0
  38. package/loops/actions/verify-refine-output/verify-refine-output.sh +20 -0
  39. package/loops/actions/verify-route-matrix/verify-route-matrix.sh +1017 -56
  40. package/loops/scripts/compile-agent-workflows.mjs +96 -1
  41. package/loops/scripts/merge-changelog.mjs +76 -0
  42. package/loops/templates/agentics/actionlint.yaml +13 -0
  43. package/loops/templates/agentics/agentics-checks.yml +203 -86
  44. package/loops/templates/agentics/agentics-error-report.yml +97 -0
  45. package/loops/templates/ci/app-ci-dotnet-next.yml +64 -2
  46. package/loops/templates/ci/app-ci-node-monorepo.yml +52 -0
  47. package/loops/templates/opencode/opencode.ci.json +3 -3
  48. package/loops/templates/opencode/opencode.ci.json.md +4 -1
  49. package/loops/workflows/agent-apply-review.md +452 -465
  50. package/loops/workflows/agent-audit.md +201 -213
  51. package/loops/workflows/agent-implement.md +616 -538
  52. package/loops/workflows/agent-merge-gate.md +830 -730
  53. package/loops/workflows/agent-refine.md +599 -609
  54. package/loops/workflows/agent-release.md +244 -258
  55. package/loops/workflows/agent-triage.md +476 -447
  56. package/loops/workflows/authorize-bot-work.yml +26 -6
  57. package/loops/workflows/work-router.yml +1185 -862
  58. package/package.json +9 -8
  59. package/loops/actions/stale-recovery/action.yml +0 -288
  60. package/loops/actions/update-changelog/action.yml +0 -113
@@ -1,465 +1,452 @@
1
- ---
2
- # Managed by @plainconceptsplatform/workflows. Source: loops/workflows/agent-apply-review.md. Update with `workflows update --force`; consumer edits may be overwritten.
3
- env:
4
- REPO_RULES: "Apply only actionable outstanding reviewer feedback to the selected bot pull request. Make minimal changes that address each comment. Preserve architecture and do not weaken tests. Run full verification after changes."
5
- WORKING_LABEL: bot-working
6
- REVIEW_LABEL: review
7
- PR_PENDING_LABEL: pr-pending
8
- REVIEW_MARKER: "<!-- agent-apply-review -->"
9
- INCOMPLETE_COMMENT: "Automated review feedback ended without an outcome. The issue remains for a retry."
10
- ISSUE_CONTEXT_PATH: /tmp/gh-aw/agent/issue-context.json
11
- GH_AW_ALLOWED_BOTS: "platform-devbox[bot],github-actions[bot]"
12
- GIT_AUTHOR_NAME: "github-actions[bot]"
13
- GIT_AUTHOR_EMAIL: "github-actions[bot]@users.noreply.github.com"
14
- GIT_COMMITTER_NAME: "github-actions[bot]"
15
- GIT_COMMITTER_EMAIL: "github-actions[bot]@users.noreply.github.com"
16
- description: |
17
- Applies reviewer feedback to an open pull request the bot authored, then pushes the fixes to
18
- the same branch. Called by the Work Router; does not trigger on public events.
19
-
20
- `target: triggering` is enough for the push here, so unlike the merge gate this needs no
21
- wildcard fetch: the event is the pull request and gh-aw has already checked out its head.
22
-
23
- name: "Agent: Apply Review"
24
-
25
- # Router-only worker. The Work Router owns triggers, classification, and rung 1-2 checks.
26
- # This workflow receives the classified inputs and runs rung 3+.
27
- imports:
28
- - github/gh-aw/.github/workflows/shared/opencode.md@v0.87.5
29
- - shared/platform-defaults.md
30
- - shared/opencode-ci.md
31
-
32
- on:
33
- workflow_call:
34
- inputs:
35
- pr-number:
36
- description: Pull request number to apply review feedback on.
37
- required: true
38
- type: string
39
- linked-issue:
40
- description: Issue number the pull request closes. May be empty.
41
- required: false
42
- type: string
43
-
44
- # Rung 4. Router has classified the event; this job validates PR ownership and checks for
45
- # substantive feedback. A custom job, not `on.steps`, because the prompt needs these values.
46
- jobs:
47
- subject:
48
- runs-on: agents-arc
49
- permissions:
50
- contents: read
51
- issues: read
52
- pull-requests: read
53
- outputs:
54
- found: ${{ steps.subject.outputs.found }}
55
- pr: ${{ steps.subject.outputs.pr }}
56
- issue: ${{ steps.subject.outputs.issue }}
57
- unresolved: ${{ steps.subject.outputs.unresolved }}
58
- steps:
59
- - name: Confirm this is our pull request and the feedback is substantive
60
- id: subject
61
- env:
62
- GH_TOKEN: ${{ github.token }}
63
- REPO: ${{ github.repository }}
64
- PR: ${{ inputs.pr-number }}
65
- LINKED_ISSUE: ${{ inputs.linked-issue }}
66
- run: |
67
- set -euo pipefail
68
-
69
- none() {
70
- echo "found=false" >> "$GITHUB_OUTPUT"
71
- echo "$1"
72
- exit 0
73
- }
74
-
75
- pr=$(gh pr view "$PR" --repo "$REPO" --json number,state,author,title,body)
76
- [ "$(printf '%s' "$pr" | jq -r '.state')" = "OPEN" ] || none "PR #$PR is not open"
77
-
78
- # Use GitHub's bot flag because App login formats differ across APIs.
79
- author=$(printf '%s' "$pr" | jq -r '.author.login')
80
- is_bot=$(printf '%s' "$pr" | jq -r '.author.is_bot')
81
- [ "$is_bot" = "true" ] || \
82
- none "PR #$PR was authored by $author, a human. Never push to a human's branch."
83
-
84
- # The issue this pull request closes, preferring the router-provided linked issue.
85
- if [ -n "$LINKED_ISSUE" ]; then
86
- issue="$LINKED_ISSUE"
87
- else
88
- issue=$(printf '%s' "$pr" | jq -r '.body // ""' \
89
- | grep -oiE '(close[sd]?|fixe?[sd]?|resolve[sd]?) +#[0-9]+' \
90
- | grep -oE '[0-9]+' | head -n 1 || true)
91
- fi
92
-
93
- # Unresolved review threads, from the API rather than from the model's reading of it.
94
- unresolved=$(gh api graphql -f query='
95
- query($owner:String!, $name:String!, $number:Int!) {
96
- repository(owner:$owner, name:$name) {
97
- pullRequest(number:$number) {
98
- reviewThreads(first:100) { nodes { isResolved isOutdated } }
99
- }
100
- }
101
- }' \
102
- -f owner="${REPO%/*}" -f name="${REPO#*/}" -F number="$PR" \
103
- --jq '[.data.repository.pullRequest.reviewThreads.nodes[]
104
- | select(.isResolved == false and .isOutdated == false)] | length')
105
-
106
- {
107
- echo "found=true"
108
- echo "pr=$PR"
109
- echo "issue=${issue:-}"
110
- echo "unresolved=$unresolved"
111
- } >> "$GITHUB_OUTPUT"
112
- echo "PR #$PR has $unresolved unresolved thread(s)"
113
-
114
- reserve:
115
- needs: subject
116
- if: needs.subject.outputs.found == 'true' && needs.subject.outputs.issue != ''
117
- runs-on: agents-arc
118
- permissions:
119
- contents: read
120
- issues: write
121
- steps:
122
- - name: Checkout workflow actions
123
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
124
- with:
125
- persist-credentials: false
126
- - name: Create bot token
127
- id: app-token
128
- uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
129
- with:
130
- client-id: ${{ secrets.BOT_APP_ID }}
131
- private-key: ${{ secrets.BOT_PRIVATE_KEY }}
132
- - name: Mark the linked issue as in progress
133
- uses: ./.github/actions/add-issue-labels
134
- with:
135
- token: ${{ steps.app-token.outputs.token }}
136
- issue-number: ${{ needs.subject.outputs.issue }}
137
- labels: ${{ env.WORKING_LABEL }}
138
- - name: Clear the human-needed flag
139
- uses: ./.github/actions/remove-issue-labels
140
- with:
141
- token: ${{ steps.app-token.outputs.token }}
142
- issue-number: ${{ needs.subject.outputs.issue }}
143
- labels: ${{ env.REVIEW_LABEL }}
144
- validate_output:
145
- needs: [activation, subject, agent, safe_outputs]
146
- if: always() && needs.agent.result == 'success' && needs.safe_outputs.result == 'success'
147
- runs-on: agents-arc
148
- permissions:
149
- contents: read
150
- pull-requests: read
151
- outputs:
152
- valid: ${{ steps.validate.outputs.valid }}
153
- outcome: ${{ steps.validate.outputs.outcome }}
154
- steps:
155
- - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
156
- with:
157
- persist-credentials: false
158
- - id: output
159
- uses: ./.github/actions/download-agent-output
160
- with:
161
- artifact-name: ${{ needs.activation.outputs.artifact_prefix }}agent
162
- - name: Load unresolved review threads
163
- env:
164
- GH_TOKEN: ${{ github.token }}
165
- REPO: ${{ github.repository }}
166
- PR: ${{ needs.subject.outputs.pr }}
167
- run: |
168
- set -euo pipefail
169
- gh api graphql -f query='
170
- query($owner:String!, $name:String!, $number:Int!) {
171
- repository(owner:$owner, name:$name) {
172
- pullRequest(number:$number) {
173
- reviewThreads(first:100) { nodes { id isResolved isOutdated } }
174
- }
175
- }
176
- }' -f owner="${REPO%/*}" -f name="${REPO#*/}" -F number="$PR" \
177
- --jq '.data.repository.pullRequest.reviewThreads.nodes' > /tmp/review-threads.json
178
- - id: validate
179
- uses: ./.github/actions/validate-review-output
180
- with:
181
- output-file: ${{ steps.output.outputs.output-file }}
182
- pr-number: ${{ needs.subject.outputs.pr }}
183
- review-threads-file: /tmp/review-threads.json
184
- conclude:
185
- needs: [activation, subject, agent, safe_outputs, validate_output]
186
- if: >
187
- needs.agent.result == 'success' &&
188
- needs.safe_outputs.result == 'success' &&
189
- needs.validate_output.outputs.valid == 'true'
190
- runs-on: agents-arc
191
- permissions:
192
- contents: write
193
- issues: write
194
- pull-requests: write
195
- steps:
196
- - name: Create bot token
197
- id: app-token
198
- uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
199
- with:
200
- client-id: ${{ secrets.BOT_APP_ID }}
201
- private-key: ${{ secrets.BOT_PRIVATE_KEY }}
202
- - name: Checkout repository
203
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
204
- with:
205
- token: ${{ steps.app-token.outputs.token }}
206
- fetch-depth: 0
207
- - name: Apply agent output
208
- uses: ./.github/actions/apply-agent-output
209
- with:
210
- artifact-name: ${{ needs.activation.outputs.artifact_prefix }}agent
211
- token: ${{ steps.app-token.outputs.token }}
212
- push-to-branch: 'true'
213
- apply-labels: 'false'
214
- - name: Release implemented review
215
- if: needs.validate_output.outputs.outcome == 'implemented'
216
- uses: ./.github/actions/remove-issue-labels
217
- with:
218
- token: ${{ steps.app-token.outputs.token }}
219
- issue-number: ${{ needs.subject.outputs.issue }}
220
- labels: ${{ env.WORKING_LABEL }}
221
- - name: Flag review outcome
222
- if: needs.validate_output.outputs.outcome != 'implemented'
223
- uses: ./.github/actions/add-issue-labels
224
- with:
225
- token: ${{ steps.app-token.outputs.token }}
226
- issue-number: ${{ needs.subject.outputs.issue }}
227
- labels: ${{ env.REVIEW_LABEL }}
228
- - name: Release review outcome
229
- if: needs.validate_output.outputs.outcome != 'implemented'
230
- uses: ./.github/actions/remove-issue-labels
231
- with:
232
- token: ${{ steps.app-token.outputs.token }}
233
- issue-number: ${{ needs.subject.outputs.issue }}
234
- labels: ${{ env.WORKING_LABEL }},${{ env.PR_PENDING_LABEL }}
235
- incomplete:
236
- needs: [subject, agent, safe_outputs, validate_output]
237
- if: >
238
- always() &&
239
- needs.subject.outputs.found == 'true' &&
240
- (needs.agent.result != 'success' || needs.safe_outputs.result != 'success' || needs.validate_output.outputs.valid != 'true')
241
- runs-on: agents-arc
242
- permissions:
243
- contents: read
244
- issues: write
245
- steps:
246
- - name: Checkout workflow actions
247
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
248
- with:
249
- persist-credentials: false
250
- - name: Create bot token
251
- id: app-token
252
- uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
253
- with:
254
- client-id: ${{ secrets.BOT_APP_ID }}
255
- private-key: ${{ secrets.BOT_PRIVATE_KEY }}
256
- - name: Release the issue
257
- uses: ./.github/actions/remove-issue-labels
258
- with:
259
- token: ${{ steps.app-token.outputs.token }}
260
- issue-number: ${{ needs.subject.outputs.issue }}
261
- labels: ${{ env.WORKING_LABEL }}
262
- - name: Flag for human review
263
- uses: ./.github/actions/add-issue-labels
264
- with:
265
- token: ${{ steps.app-token.outputs.token }}
266
- issue-number: ${{ needs.subject.outputs.issue }}
267
- labels: ${{ env.REVIEW_LABEL }}
268
- - name: Report missing review feedback outcome
269
- uses: ./.github/actions/create-issue-comment
270
- with:
271
- token: ${{ steps.app-token.outputs.token }}
272
- issue-number: ${{ needs.subject.outputs.issue }}
273
- body: |
274
- ${{ env.REVIEW_MARKER }}
275
- ${{ env.INCOMPLETE_COMMENT }}
276
- [View this workflow run](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})
277
-
278
- if: needs.subject.outputs.found == 'true'
279
-
280
- runs-on: agents-arc
281
- runs-on-slim: agents-arc
282
-
283
- secrets:
284
- OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
285
-
286
- engine:
287
- id: opencode
288
- version: "1.2.14"
289
- env:
290
- OPENAI_BASE_URL: https://forge.plainconcepts.com/v1
291
-
292
- model: openai/glm-5-3
293
-
294
- max-turns: 300
295
- max-turn-cache-misses: 3000
296
- max-ai-credits: 5000
297
-
298
-
299
- permissions: read-all
300
-
301
- # Rung 3. A reviewer often makes one point across several comments, so the agent needs the
302
- # whole conversation, not just the one that triggered it. Fetching all of it is deterministic.
303
- steps:
304
- - name: Load the issue context
305
- uses: ./.github/actions/load-issue-context
306
- with:
307
- token: ${{ github.token }}
308
- issue-number: ${{ needs.subject.outputs.issue }}
309
- output-path: ${{ env.ISSUE_CONTEXT_PATH }}
310
- - name: Fetch the whole review conversation and the diff
311
- env:
312
- GH_TOKEN: ${{ github.token }}
313
- REPO: ${{ github.repository }}
314
- PR: ${{ inputs.pr-number }}
315
- run: |
316
- set -euo pipefail
317
- mkdir -p /tmp/gh-aw/agent
318
- gh pr diff "$PR" --repo "$REPO" > /tmp/gh-aw/agent/diff.patch
319
- gh api "repos/$REPO/pulls/$PR/comments" --paginate \
320
- --jq '[.[] | {id, path, line, author: .user.login, body, in_reply_to_id}]' \
321
- > /tmp/gh-aw/agent/review-comments.json
322
- gh api "repos/$REPO/issues/$PR/comments" --paginate \
323
- --jq '[.[] | {author: .user.login, body}]' \
324
- > /tmp/gh-aw/agent/conversation.json
325
- gh api graphql -f query='
326
- query($owner:String!, $name:String!, $number:Int!) {
327
- repository(owner:$owner, name:$name) {
328
- pullRequest(number:$number) {
329
- reviewThreads(first:100) {
330
- nodes { id
331
- isResolved isOutdated path
332
- comments(first:50) { nodes { author { login } body } }
333
- }
334
- }
335
- }
336
- }
337
- }' \
338
- -f owner="${REPO%/*}" -f name="${REPO#*/}" -F number="$PR" \
339
- --jq '.data.repository.pullRequest.reviewThreads.nodes' \
340
- > /tmp/gh-aw/agent/review-threads.json
341
-
342
- safe-outputs:
343
- # A failed run is already a red run. An issue per failure buries the real backlog
344
- # under noise nobody closes.
345
- report-failure-as-issue: false
346
- threat-detection: false
347
- # target "*" because these workers are dispatched, not triggered by the pull request:
348
- # the default "triggering" target has no pull request in context and rejects the push
349
- # with "requires pull request context", so the agent's fix is computed and discarded.
350
- push-to-pull-request-branch:
351
- target: "*"
352
- add-comment:
353
- target: "*"
354
-
355
-
356
- timeout-minutes: 45
357
- ---
358
-
359
- 1. You are applying review feedback to pull request
360
- **#${{ needs.subject.outputs.pr }}**, which has
361
- **${{ needs.subject.outputs.unresolved }}** unresolved review thread(s).
362
-
363
- It has already been confirmed that this pull request is open, that we authored it, and that
364
- the reviewer has write access. Do not re-check any of that.
365
-
366
- 2. Read `${{ env.ISSUE_CONTEXT_PATH }}`. It contains the issue body and discussion this pull
367
- request closes. The acceptance criteria there define what the implementation must still
368
- satisfy after the feedback is applied.
369
-
370
- 3. Read the whole conversation, not just the comment that triggered you. It is already on disk:
371
-
372
- - `/tmp/gh-aw/agent/review-threads.json` , every thread with its resolved and outdated state
373
- - `/tmp/gh-aw/agent/review-comments.json` , every inline comment with its file and line
374
- - `/tmp/gh-aw/agent/conversation.json` , every conversation comment
375
- - `/tmp/gh-aw/agent/diff.patch` , the current diff
376
-
377
- A reviewer often makes one point across several comments. Applying them one at a time
378
- produces contradictory commits, so read everything before changing anything.
379
-
380
- 4. Work out which items are genuinely actionable and still outstanding. Skip anything already
381
- addressed by a later commit, anything a bot wrote, anything from the pull request author,
382
- and anything that is a question rather than a request. You must account for every unresolved
383
- human review thread by its `PRRT_...` ID. Do not claim feedback was implemented when no branch
384
- change is needed: that requires reviewer confirmation.
385
-
386
- 5. Load only skills required by the feedback, then apply it. Make only changes the feedback
387
- justifies: a review comment is not licence for unrelated refactoring. Never read outside this
388
- repository root. Follow repository documentation and established conventions. Keep changes
389
- focused, protect secrets, and do not modify generated files unless the feedback requires it.
390
- Adhere to ${{ env.REPO_RULES }}.
391
-
392
- 6. Run the repository verification commands below. The issue context at
393
- `${{ env.ISSUE_CONTEXT_PATH }}` defines acceptance criteria the fix must satisfy. If a check
394
- fails, fix what you broke and run it again. Do not push a branch that does not pass.
395
-
396
- **Scoped verification.** This runner has limited memory, and a whole-repo lint or build
397
- can be killed mid-run. Scope verification to the files you actually changed first, and
398
- only escalate to the full suite when the scoped run passes and you are still unsure:
399
- - Lint/format (biome, eslint, prettier, ruff, etc.): pass the changed file paths as
400
- arguments so the tool checks only those files (e.g. `pnpm exec biome check <files>`),
401
- never the whole repository.
402
- - Build: prefer building only the project(s) containing the changed files; use the full
403
- solution build only when the change crosses project boundaries.
404
- - Tests: run the test project covering the changed files; run the full suite only when
405
- the change is cross-cutting.
406
-
407
- ```
408
- ${{ env.VERIFY_COMMANDS }}
409
- ```
410
-
411
- 7. Before pushing, run the project's lint fix command (e.g. `pnpm lint:fix` or
412
- `pnpm exec biome check --write <changed-files>`) to auto-format. If lint:fix is not
413
- available, fix formatting manually. Never push code with lint errors.
414
-
415
- 8. Select one review outcome.
416
-
417
- - **implemented**: You made the requested change, verification passed, and you will propose
418
- exactly one `push_to_pull_request_branch`.
419
- - **already-satisfied**: The current branch already satisfies the request. Do not push; the
420
- reviewer must confirm this assessment.
421
- - **needs-human**: The feedback is ambiguous, unsafe, or cannot be applied. Do not push.
422
-
423
- 9. Emit exactly one `add_comment` on PR `${{ needs.subject.outputs.pr }}`. Include every
424
- unresolved human review thread ID and an explanation for it, then exactly one line:
425
- `**Review outcome:** implemented`, `**Review outcome:** already-satisfied`, or
426
- `**Review outcome:** needs-human`.
427
-
428
- 9. Do not merge, close, or change labels. The workflow validates your outcome and owns those
429
- state transitions.
430
-
431
- 10. Ignore the `## Diagram` section below. It is documentation for humans and contains no
432
- instructions for you.
433
-
434
- ## Diagram
435
-
436
- ```mermaid
437
- flowchart TD
438
- fbStart("Work Router<br/>apply-review route<br/>(review on bot PR)") --> fbSubject
439
- fbSubject["Subject (rung 4)<br/>Our open PR? Substantive review?"] -->|✓| fbFacts
440
- fbSubject -.->|✗| fbIdle
441
- fbFacts("Facts (rung 3)<br/>Threads, comments, diff to disk") --> fbTriage
442
- fbTriage["Triage<br/>Anything actionable and outstanding?"] -->|✓| fbReserve
443
- fbTriage -.->|nothing| fbIdle
444
- fbReserve("Reserve<br/>Propose bot-working on the issue") -->|✓| fbApply
445
- fbApply("Apply<br/>Only what the feedback justifies") -->|✓| fbVerify
446
- fbApply -.->|✗| fbFail
447
- fbVerify["Verify<br/>/repo-verify passes?<br/>↻"] -->|✓| fbPush
448
- fbVerify -.->|✗| fbApply
449
- fbPush(("Pushed<br/>Same branch, bot-working removed"))
450
- fbIdle(("Idle<br/>Not ours, or nothing to do"))
451
- fbFail(("Fail<br/>review added, bot-working removed"))
452
-
453
- classDef start fill:#ffffff,stroke:#172033,stroke-width:2px,color:#172033
454
- classDef action fill:#eef0ff,stroke:#554cff,stroke-width:2px,color:#172033
455
- classDef decision fill:#fff8e8,stroke:#c75b00,stroke-width:2px,color:#172033
456
- classDef idle fill:#202c40,stroke:#738198,stroke-width:2px,color:#ffffff
457
- classDef failure fill:#fff0f0,stroke:#ef2929,stroke-width:2px,color:#8b1a1a
458
- classDef success fill:#e8f8ec,stroke:#18883c,stroke-width:2px,color:#145a32
459
- class fbStart start
460
- class fbFacts,fbReserve,fbApply action
461
- class fbSubject,fbTriage,fbVerify decision
462
- class fbIdle idle
463
- class fbFail failure
464
- class fbPush success
465
- ```
1
+ ---
2
+ # Managed by @plainconceptsplatform/workflows. Source: loops/workflows/agent-apply-review.md. Update with `workflows update --force`; consumer edits may be overwritten.
3
+ env:
4
+ # Printed by the prompt as the verification block. Consumers set their own commands.
5
+ VERIFY_COMMANDS: ""
6
+ REPO_RULES: "Apply only actionable outstanding reviewer feedback to the selected bot pull request. Make minimal changes that address each comment. Preserve architecture and do not weaken tests. Run full verification after changes."
7
+ WORKING_LABEL: bot-working
8
+ REVIEW_LABEL: review
9
+ # Marks a park the machine caused — a crash, a timeout, an empty output — as opposed to one it
10
+ # decided on. The janitor retries these after a while and never touches a decision park, because
11
+ # re-running a decision produces the same decision. Created idempotently where it is applied.
12
+ STALLED_LABEL: stalled
13
+ PR_PENDING_LABEL: pr-pending
14
+ REVIEW_MARKER: "<!-- agent-apply-review -->"
15
+ INCOMPLETE_COMMENT: "Applying the review feedback ended without an outcome. This worker has no retry of its own: it runs again when somebody reviews or comments on the pull request, and the issue is flagged so it is not lost until then."
16
+ ISSUE_CONTEXT_PATH: /tmp/gh-aw/agent/issue-context.json
17
+ GH_AW_ALLOWED_BOTS: "platform-devbox[bot],github-actions[bot]"
18
+ GIT_AUTHOR_NAME: "github-actions[bot]"
19
+ GIT_AUTHOR_EMAIL: "github-actions[bot]@users.noreply.github.com"
20
+ GIT_COMMITTER_NAME: "github-actions[bot]"
21
+ GIT_COMMITTER_EMAIL: "github-actions[bot]@users.noreply.github.com"
22
+ description: |
23
+ Applies reviewer feedback to an open pull request the bot authored, then pushes the fixes to
24
+ the same branch. Called by the Work Router; does not trigger on public events.
25
+
26
+ `target: triggering` is enough for the push here, so unlike the merge gate this needs no
27
+ wildcard fetch: the event is the pull request and gh-aw has already checked out its head.
28
+
29
+ name: "Agent: Apply Review"
30
+
31
+ # Router-only worker. The Work Router owns triggers, classification, and rung 1-2 checks.
32
+ # This workflow receives the classified inputs and runs rung 3+.
33
+ imports:
34
+ - github/gh-aw/.github/workflows/shared/opencode.md@v0.87.5
35
+ - shared/platform-defaults.md
36
+ - shared/opencode-ci.md
37
+
38
+ on:
39
+ workflow_call:
40
+ inputs:
41
+ pr-number:
42
+ description: Pull request number to apply review feedback on.
43
+ required: true
44
+ type: string
45
+ linked-issue:
46
+ description: Issue number the pull request closes. May be empty.
47
+ required: false
48
+ type: string
49
+
50
+ # Rung 4. Router has classified the event; this job validates PR ownership and checks for
51
+ # substantive feedback. A custom job, not `on.steps`, because the prompt needs these values.
52
+ jobs:
53
+ subject:
54
+ runs-on: agents-arc
55
+ permissions:
56
+ contents: read
57
+ issues: read
58
+ pull-requests: read
59
+ outputs:
60
+ found: ${{ steps.subject.outputs.found }}
61
+ pr: ${{ steps.subject.outputs.pr }}
62
+ issue: ${{ steps.subject.outputs.issue }}
63
+ unresolved: ${{ steps.subject.outputs.unresolved }}
64
+ steps:
65
+ - name: Confirm this is our pull request and the feedback is substantive
66
+ id: subject
67
+ env:
68
+ GH_TOKEN: ${{ github.token }}
69
+ REPO: ${{ github.repository }}
70
+ PR: ${{ inputs.pr-number }}
71
+ LINKED_ISSUE: ${{ inputs.linked-issue }}
72
+ run: |
73
+ set -euo pipefail
74
+
75
+ none() {
76
+ echo "found=false" >> "$GITHUB_OUTPUT"
77
+ echo "$1"
78
+ exit 0
79
+ }
80
+
81
+ pr=$(gh pr view "$PR" --repo "$REPO" --json number,state,author,title,body)
82
+ [ "$(printf '%s' "$pr" | jq -r '.state')" = "OPEN" ] || none "PR #$PR is not open"
83
+
84
+ # Use GitHub's bot flag because App login formats differ across APIs.
85
+ author=$(printf '%s' "$pr" | jq -r '.author.login')
86
+ is_bot=$(printf '%s' "$pr" | jq -r '.author.is_bot')
87
+ [ "$is_bot" = "true" ] || \
88
+ none "PR #$PR was authored by $author, a human. Never push to a human's branch."
89
+
90
+ # The issue this pull request closes, preferring the router-provided linked issue.
91
+ if [ -n "$LINKED_ISSUE" ]; then
92
+ issue="$LINKED_ISSUE"
93
+ else
94
+ issue=$(printf '%s' "$pr" | jq -r '.body // ""' \
95
+ | grep -oiE '(close[sd]?|fixe?[sd]?|resolve[sd]?) +#[0-9]+' \
96
+ | grep -oE '[0-9]+' | head -n 1 || true)
97
+ fi
98
+
99
+ # Unresolved review threads, from the API rather than from the model's reading of it.
100
+ unresolved=$(gh api graphql -f query='
101
+ query($owner:String!, $name:String!, $number:Int!) {
102
+ repository(owner:$owner, name:$name) {
103
+ pullRequest(number:$number) {
104
+ reviewThreads(first:100) { nodes { isResolved isOutdated } }
105
+ }
106
+ }
107
+ }' \
108
+ -f owner="${REPO%/*}" -f name="${REPO#*/}" -F number="$PR" \
109
+ --jq '[.data.repository.pullRequest.reviewThreads.nodes[]
110
+ | select(.isResolved == false and .isOutdated == false)] | length')
111
+
112
+ {
113
+ echo "found=true"
114
+ echo "pr=$PR"
115
+ echo "issue=${issue:-}"
116
+ echo "unresolved=$unresolved"
117
+ } >> "$GITHUB_OUTPUT"
118
+ echo "PR #$PR has $unresolved unresolved thread(s)"
119
+
120
+ reserve:
121
+ needs: subject
122
+ if: needs.subject.outputs.found == 'true' && needs.subject.outputs.issue != ''
123
+ runs-on: agents-arc
124
+ permissions:
125
+ contents: read
126
+ issues: write
127
+ steps:
128
+ - name: Checkout workflow actions
129
+ uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
130
+ with:
131
+ persist-credentials: false
132
+ - name: Create bot token
133
+ id: app-token
134
+ uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
135
+ with:
136
+ client-id: ${{ secrets.BOT_APP_ID }}
137
+ private-key: ${{ secrets.BOT_PRIVATE_KEY }}
138
+ - name: Mark the linked issue as in progress
139
+ uses: ./.github/actions/add-issue-labels
140
+ with:
141
+ token: ${{ steps.app-token.outputs.token }}
142
+ issue-number: ${{ needs.subject.outputs.issue }}
143
+ labels: ${{ env.WORKING_LABEL }}
144
+ - name: Clear the human-needed flag
145
+ uses: ./.github/actions/remove-issue-labels
146
+ with:
147
+ token: ${{ steps.app-token.outputs.token }}
148
+ issue-number: ${{ needs.subject.outputs.issue }}
149
+ labels: |-
150
+ ${{ env.REVIEW_LABEL }}
151
+ ${{ env.STALLED_LABEL }}
152
+ validate_output:
153
+ needs: [activation, subject, agent, safe_outputs]
154
+ if: always() && needs.agent.result == 'success' && needs.safe_outputs.result == 'success'
155
+ runs-on: agents-arc
156
+ permissions:
157
+ contents: read
158
+ pull-requests: read
159
+ outputs:
160
+ valid: ${{ steps.validate.outputs.valid }}
161
+ outcome: ${{ steps.validate.outputs.outcome }}
162
+ steps:
163
+ - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
164
+ with:
165
+ persist-credentials: false
166
+ - id: output
167
+ uses: ./.github/actions/download-agent-output
168
+ with:
169
+ artifact-name: ${{ needs.activation.outputs.artifact_prefix }}agent
170
+ - name: Load unresolved review threads
171
+ env:
172
+ GH_TOKEN: ${{ github.token }}
173
+ REPO: ${{ github.repository }}
174
+ PR: ${{ needs.subject.outputs.pr }}
175
+ run: |
176
+ set -euo pipefail
177
+ gh api graphql -f query='
178
+ query($owner:String!, $name:String!, $number:Int!) {
179
+ repository(owner:$owner, name:$name) {
180
+ pullRequest(number:$number) {
181
+ reviewThreads(first:100) { nodes { id isResolved isOutdated } }
182
+ }
183
+ }
184
+ }' -f owner="${REPO%/*}" -f name="${REPO#*/}" -F number="$PR" \
185
+ --jq '.data.repository.pullRequest.reviewThreads.nodes' > /tmp/review-threads.json
186
+ - id: validate
187
+ uses: ./.github/actions/validate-review-output
188
+ with:
189
+ output-file: ${{ steps.output.outputs.output-file }}
190
+ pr-number: ${{ needs.subject.outputs.pr }}
191
+ review-threads-file: /tmp/review-threads.json
192
+ conclude:
193
+ needs: [activation, subject, agent, safe_outputs, validate_output]
194
+ if: >
195
+ needs.agent.result == 'success' &&
196
+ needs.safe_outputs.result == 'success' &&
197
+ needs.validate_output.outputs.valid == 'true'
198
+ runs-on: agents-arc
199
+ permissions:
200
+ contents: write
201
+ issues: write
202
+ pull-requests: write
203
+ steps:
204
+ - name: Create bot token
205
+ id: app-token
206
+ uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
207
+ with:
208
+ client-id: ${{ secrets.BOT_APP_ID }}
209
+ private-key: ${{ secrets.BOT_PRIVATE_KEY }}
210
+ - name: Checkout repository
211
+ uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
212
+ with:
213
+ token: ${{ steps.app-token.outputs.token }}
214
+ fetch-depth: 0
215
+ - name: Apply agent output
216
+ uses: ./.github/actions/apply-agent-output
217
+ with:
218
+ artifact-name: ${{ needs.activation.outputs.artifact_prefix }}agent
219
+ token: ${{ steps.app-token.outputs.token }}
220
+ push-to-branch: 'true'
221
+ apply-labels: 'false'
222
+ - name: Release implemented review
223
+ if: needs.validate_output.outputs.outcome == 'implemented'
224
+ uses: ./.github/actions/remove-issue-labels
225
+ with:
226
+ token: ${{ steps.app-token.outputs.token }}
227
+ issue-number: ${{ needs.subject.outputs.issue }}
228
+ labels: ${{ env.WORKING_LABEL }}
229
+ - name: Flag review outcome
230
+ if: needs.validate_output.outputs.outcome != 'implemented'
231
+ uses: ./.github/actions/add-issue-labels
232
+ with:
233
+ token: ${{ steps.app-token.outputs.token }}
234
+ issue-number: ${{ needs.subject.outputs.issue }}
235
+ labels: ${{ env.REVIEW_LABEL }}
236
+ # Only the reservation comes off. pr-pending says a pull request for this issue is open and
237
+ # waiting, which is still true on both outcomes that reach here: already-satisfied and
238
+ # needs-human both leave the pull request open. Stripping it made the board show issues
239
+ # with open pull requests as having none — the exact bug the merge gate's own comment warns
240
+ # about, in the one file the route matrix was not checking.
241
+ - name: Release review outcome
242
+ if: needs.validate_output.outputs.outcome != 'implemented'
243
+ uses: ./.github/actions/remove-issue-labels
244
+ with:
245
+ token: ${{ steps.app-token.outputs.token }}
246
+ issue-number: ${{ needs.subject.outputs.issue }}
247
+ labels: ${{ env.WORKING_LABEL }}
248
+ incomplete:
249
+ needs: [subject, agent, safe_outputs, validate_output]
250
+ if: >
251
+ always() &&
252
+ needs.subject.outputs.found == 'true' &&
253
+ (needs.agent.result != 'success' || needs.safe_outputs.result != 'success' || needs.validate_output.outputs.valid != 'true')
254
+ runs-on: agents-arc
255
+ permissions:
256
+ contents: read
257
+ issues: write
258
+ steps:
259
+ - name: Checkout workflow actions
260
+ uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
261
+ with:
262
+ persist-credentials: false
263
+ - name: Create bot token
264
+ id: app-token
265
+ uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
266
+ with:
267
+ client-id: ${{ secrets.BOT_APP_ID }}
268
+ private-key: ${{ secrets.BOT_PRIVATE_KEY }}
269
+ - name: Release the issue
270
+ uses: ./.github/actions/remove-issue-labels
271
+ with:
272
+ token: ${{ steps.app-token.outputs.token }}
273
+ issue-number: ${{ needs.subject.outputs.issue }}
274
+ labels: ${{ env.WORKING_LABEL }}
275
+ - name: Flag for human review
276
+ uses: ./.github/actions/add-issue-labels
277
+ with:
278
+ token: ${{ steps.app-token.outputs.token }}
279
+ issue-number: ${{ needs.subject.outputs.issue }}
280
+ labels: |-
281
+ ${{ env.REVIEW_LABEL }}
282
+ ${{ env.STALLED_LABEL }}
283
+ - name: Report missing review feedback outcome
284
+ uses: ./.github/actions/create-issue-comment
285
+ with:
286
+ token: ${{ steps.app-token.outputs.token }}
287
+ issue-number: ${{ needs.subject.outputs.issue }}
288
+ body: |
289
+ ${{ env.REVIEW_MARKER }}
290
+ ${{ env.INCOMPLETE_COMMENT }}
291
+ [View this workflow run](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})
292
+
293
+ if: needs.subject.outputs.found == 'true'
294
+
295
+ runs-on: agents-arc
296
+ runs-on-slim: agents-arc
297
+
298
+ secrets:
299
+ OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
300
+
301
+ engine:
302
+ id: opencode
303
+ version: "1.2.14"
304
+ env:
305
+ OPENAI_BASE_URL: https://forge.plainconcepts.com/v1
306
+
307
+ model: openai/glm-5-3
308
+
309
+ max-turns: 300
310
+ max-turn-cache-misses: 3000
311
+ max-ai-credits: 5000
312
+
313
+
314
+ permissions: read-all
315
+
316
+ # Rung 3. A reviewer often makes one point across several comments, so the agent needs the
317
+ # whole conversation, not just the one that triggered it. Fetching all of it is deterministic.
318
+ steps:
319
+ - name: Load the issue context
320
+ uses: ./.github/actions/load-issue-context
321
+ with:
322
+ token: ${{ github.token }}
323
+ issue-number: ${{ needs.subject.outputs.issue }}
324
+ output-path: ${{ env.ISSUE_CONTEXT_PATH }}
325
+ - name: Fetch the whole review conversation and the diff
326
+ env:
327
+ GH_TOKEN: ${{ github.token }}
328
+ REPO: ${{ github.repository }}
329
+ PR: ${{ inputs.pr-number }}
330
+ run: |
331
+ set -euo pipefail
332
+ mkdir -p /tmp/gh-aw/agent
333
+ gh pr diff "$PR" --repo "$REPO" > /tmp/gh-aw/agent/diff.patch
334
+ gh api "repos/$REPO/pulls/$PR/comments" --paginate \
335
+ --jq '[.[] | {id, path, line, author: .user.login, body, in_reply_to_id}]' \
336
+ > /tmp/gh-aw/agent/review-comments.json
337
+ gh api "repos/$REPO/issues/$PR/comments" --paginate \
338
+ --jq '[.[] | {author: .user.login, body}]' \
339
+ > /tmp/gh-aw/agent/conversation.json
340
+ gh api graphql -f query='
341
+ query($owner:String!, $name:String!, $number:Int!) {
342
+ repository(owner:$owner, name:$name) {
343
+ pullRequest(number:$number) {
344
+ reviewThreads(first:100) {
345
+ nodes { id
346
+ isResolved isOutdated path
347
+ comments(first:50) { nodes { author { login } body } }
348
+ }
349
+ }
350
+ }
351
+ }
352
+ }' \
353
+ -f owner="${REPO%/*}" -f name="${REPO#*/}" -F number="$PR" \
354
+ --jq '.data.repository.pullRequest.reviewThreads.nodes' \
355
+ > /tmp/gh-aw/agent/review-threads.json
356
+
357
+ safe-outputs:
358
+ # A failed run is already a red run. An issue per failure buries the real backlog
359
+ # under noise nobody closes.
360
+ report-failure-as-issue: false
361
+ threat-detection: false
362
+ # target "*" because these workers are dispatched, not triggered by the pull request:
363
+ # the default "triggering" target has no pull request in context and rejects the push
364
+ # with "requires pull request context", so the agent's fix is computed and discarded.
365
+ push-to-pull-request-branch:
366
+ target: "*"
367
+ add-comment:
368
+ target: "*"
369
+
370
+
371
+ # The fleet is two machines, so this clock is also how long a stuck run can hold half of it.
372
+ # 240 went on to every worker at once when the provider was slow, which fixed the deaths and
373
+ # made every worker equally expensive to hang. These numbers are per worker: enough headroom
374
+ # for a slow gateway on the work it actually does, and not four hours for a run that reads one
375
+ # issue. Turns remain the guard against a confused agent looping; for a custom model the credit
376
+ # ceiling is models.dev fallback pricing and guards nothing.
377
+ #
378
+ # Applies review comments to an existing branch and verifies the result.
379
+ timeout-minutes: 90
380
+ ---
381
+
382
+ 1. You are applying review feedback to pull request
383
+ **#${{ needs.subject.outputs.pr }}**, which has
384
+ **${{ needs.subject.outputs.unresolved }}** unresolved review thread(s).
385
+
386
+ It has already been confirmed that this pull request is open, that we authored it, and that
387
+ the reviewer has write access. Do not re-check any of that.
388
+
389
+ 2. Read `${{ env.ISSUE_CONTEXT_PATH }}`. It contains the issue body and discussion this pull
390
+ request closes. The acceptance criteria there define what the implementation must still
391
+ satisfy after the feedback is applied.
392
+
393
+ 3. Read the whole conversation, not just the comment that triggered you. It is already on disk:
394
+
395
+ - `/tmp/gh-aw/agent/review-threads.json` , every thread with its resolved and outdated state
396
+ - `/tmp/gh-aw/agent/review-comments.json` , every inline comment with its file and line
397
+ - `/tmp/gh-aw/agent/conversation.json` , every conversation comment
398
+ - `/tmp/gh-aw/agent/diff.patch` , the current diff
399
+
400
+ A reviewer often makes one point across several comments. Applying them one at a time
401
+ produces contradictory commits, so read everything before changing anything.
402
+
403
+ 4. Work out which items are genuinely actionable and still outstanding. Skip anything already
404
+ addressed by a later commit, anything a bot wrote, anything from the pull request author,
405
+ and anything that is a question rather than a request. You must account for every unresolved
406
+ human review thread by its `PRRT_...` ID. Do not claim feedback was implemented when no branch
407
+ change is needed: that requires reviewer confirmation.
408
+
409
+ 5. Load only skills required by the feedback, then apply it. Make only changes the feedback
410
+ justifies: a review comment is not licence for unrelated refactoring. Never read outside this
411
+ repository root. Follow repository documentation and established conventions. Keep changes
412
+ focused, protect secrets, and do not modify generated files unless the feedback requires it.
413
+ Adhere to ${{ env.REPO_RULES }}.
414
+
415
+ 6. Run the repository verification commands below. The issue context at
416
+ `${{ env.ISSUE_CONTEXT_PATH }}` defines acceptance criteria the fix must satisfy. If a check
417
+ fails, fix what you broke and run it again. Do not push a branch that does not pass.
418
+
419
+ **Scope every command to the files you changed.** This is a constraint, not a preference:
420
+ the runner has limited memory and a whole-repository lint, build or test run gets killed
421
+ mid-run, which fails the job with no useful output. Escalate to the full suite only when
422
+ the scoped run has passed and the change crosses project boundaries.
423
+ - Lint/format (biome, eslint, prettier, ruff, etc.): pass the changed file paths as
424
+ arguments so the tool checks only those files (e.g. `pnpm exec biome check <files>`),
425
+ never the whole repository.
426
+ - Build: build only the project(s) containing the changed files.
427
+ - Tests: run the test project covering the changed files.
428
+
429
+ ```
430
+ ${{ env.VERIFY_COMMANDS }}
431
+ ```
432
+
433
+ 7. Before pushing, run the project's lint fix command (e.g. `pnpm lint:fix` or
434
+ `pnpm exec biome check --write <changed-files>`) to auto-format. If lint:fix is not
435
+ available, fix formatting manually. Never push code with lint errors.
436
+
437
+ 8. Select one review outcome.
438
+
439
+ - **implemented**: You made the requested change, verification passed, and you will propose
440
+ exactly one `push_to_pull_request_branch`.
441
+ - **already-satisfied**: The current branch already satisfies the request. Do not push; the
442
+ reviewer must confirm this assessment.
443
+ - **needs-human**: The feedback is ambiguous, unsafe, or cannot be applied. Do not push.
444
+
445
+ 9. Emit exactly one `add_comment` on PR `${{ needs.subject.outputs.pr }}`. Include every
446
+ unresolved human review thread ID and an explanation for it, then exactly one line:
447
+ `**Review outcome:** implemented`, `**Review outcome:** already-satisfied`, or
448
+ `**Review outcome:** needs-human`.
449
+
450
+ 10. Do not merge, close, or change labels. The workflow validates your outcome and owns those
451
+ state transitions.
452
+