@plainconceptsplatform/workflows 0.4.34 → 0.5.1

package/loops/actions/validate-refine-output/validate-refine-output.sh

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 # Managed by @plainconceptsplatform/workflows. Source: loops/actions/validate-refine-output/validate-refine-output.sh. Update with `workflows update --force`; consumer edits may be overwritten.
-# Print the deterministic Refine outcome: complete, questions, or invalid.
+# Print the deterministic Refine outcome: complete, split, questions, or invalid.
 
 set -euo pipefail
 
@@ -23,6 +23,13 @@ jq -r --arg marker "$marker" --arg prefix "$comment_prefix" --arg issue "$issue_
   def has_update:
     any(.items[]; .type == "update_issue");
 
+  # A split writes children, which are the only items allowed to target something other than
+  # the source issue: they do not exist yet, so they carry no number at all.
+  def child_count:
+    [.items[] | select(.type == "create_issue" and
+      (.body | type == "string") and (.body | test("[^[:space:]]")) and
+      (.title | type == "string") and (.title | test("[^[:space:]]")))] | length;
+
   def has_only_source_items:
     all(.items[];
       (
@@ -32,7 +39,8 @@ jq -r --arg marker "$marker" --arg prefix "$comment_prefix" --arg issue "$issue_
       (
         .type == "add_comment" and
         (.item_number | tostring) == $issue
-      ));
+      ) or
+      .type == "create_issue");
 
   def has_clarification:
     any(.items[]; .type == "add_comment" and (.item_number | tostring) == $issue and
@@ -40,7 +48,12 @@ jq -r --arg marker "$marker" --arg prefix "$comment_prefix" --arg issue "$issue_
       (.body | split($marker) | join("") | split($prefix) | join("") |
         gsub("<[^>]*>"; "") | test("[[:alnum:]]")));
 
-  if has_replacement_body and has_only_source_items then "complete"
+  # Order matters: a run that wrote children is a split even though it also replaced the
+  # parent body, and a lone child with no parent update is an incomplete split, not a
+  # complete refinement.
+  if child_count >= 2 and has_replacement_body and has_only_source_items then "split"
+  elif child_count > 0 then "invalid"
+  elif has_replacement_body and has_only_source_items then "complete"
   elif has_clarification and (has_update | not) and has_only_source_items then "questions"
   else "invalid"
   end

package/loops/actions/validate-review-output/action.yml

@@ -1,35 +1,35 @@
-# Managed by @plainconceptsplatform/workflows. Source: loops/actions/validate-review-output/action.yml. Update with workflows update --force; consumer edits may be overwritten.
-name: Validate review output
-description: Verify an apply-review outcome accounts for every unresolved review thread.
-inputs:
-  output-file:
-    description: Path to agent_output.json.
-    required: true
-  pr-number:
-    description: Pull request receiving the review feedback.
-    required: true
-  review-threads-file:
-    description: JSON file containing unresolved review threads.
-    required: true
-outputs:
-  valid:
-    description: Whether the agent output is a valid review outcome.
-    value: ${{ steps.validate.outputs.valid }}
-  outcome:
-    description: "Deterministic review outcome: implemented, already-satisfied, needs-human, or invalid."
-    value: ${{ steps.validate.outputs.outcome }}
-runs:
-  using: composite
-  steps:
-    - name: Validate review outcome
-      id: validate
-      shell: bash
-      env:
-        OUTPUT_FILE: ${{ inputs.output-file }}
-        PR_NUMBER: ${{ inputs.pr-number }}
-        REVIEW_THREADS_FILE: ${{ inputs.review-threads-file }}
-      run: |
-        set -euo pipefail
-        outcome="$(bash "${{ github.action_path }}/validate-review-output.sh" "$OUTPUT_FILE" "$PR_NUMBER" "$REVIEW_THREADS_FILE")"
-        echo "outcome=$outcome" >> "$GITHUB_OUTPUT"
-        echo "valid=$([ "$outcome" != 'invalid' ] && echo true || echo false)" >> "$GITHUB_OUTPUT"
+# Managed by @plainconceptsplatform/workflows. Source: loops/actions/validate-review-output/action.yml. Update with workflows update --force; consumer edits may be overwritten.
+name: Validate review output
+description: Verify an apply-review outcome accounts for every unresolved review thread.
+inputs:
+  output-file:
+    description: Path to agent_output.json.
+    required: true
+  pr-number:
+    description: Pull request receiving the review feedback.
+    required: true
+  review-threads-file:
+    description: JSON file containing unresolved review threads.
+    required: true
+outputs:
+  valid:
+    description: Whether the agent output is a valid review outcome.
+    value: ${{ steps.validate.outputs.valid }}
+  outcome:
+    description: "Deterministic review outcome: implemented, already-satisfied, needs-human, or invalid."
+    value: ${{ steps.validate.outputs.outcome }}
+runs:
+  using: composite
+  steps:
+    - name: Validate review outcome
+      id: validate
+      shell: bash
+      env:
+        OUTPUT_FILE: ${{ inputs.output-file }}
+        PR_NUMBER: ${{ inputs.pr-number }}
+        REVIEW_THREADS_FILE: ${{ inputs.review-threads-file }}
+      run: |
+        set -euo pipefail
+        outcome="$(bash "${{ github.action_path }}/validate-review-output.sh" "$OUTPUT_FILE" "$PR_NUMBER" "$REVIEW_THREADS_FILE")"
+        echo "outcome=$outcome" >> "$GITHUB_OUTPUT"
+        echo "valid=$([ "$outcome" != 'invalid' ] && echo true || echo false)" >> "$GITHUB_OUTPUT"

package/loops/actions/validate-triage-output/action.yml

@@ -1,36 +1,36 @@
-# Managed by @plainconceptsplatform/workflows. Source: loops/actions/validate-triage-output/action.yml. Update with workflows update --force; consumer edits may be overwritten.
-name: Validate triage output
-description: Verify agent_output.json contains a usable triage verdict before any GitHub writes.
-inputs:
-  output-file:
-    description: Path to agent_output.json.
-    required: true
-  issue-number:
-    description: Issue number that every triage outcome must target.
-    required: true
-outputs:
-  valid:
-    description: Whether the output contains a usable triage comment with a verdict.
-    value: ${{ steps.validate.outputs.valid }}
-  outcome:
-    description: "Deterministic triage outcome: pass, needs-info, block, or invalid."
-    value: ${{ steps.validate.outputs.outcome }}
-runs:
-  using: composite
-  steps:
-    - name: Validate triage outcome
-      id: validate
-      shell: bash
-      env:
-        ISSUE_NUMBER: ${{ inputs.issue-number }}
-        OUTPUT_FILE: ${{ inputs.output-file }}
-      run: |
-        set -euo pipefail
-
-        outcome="$(bash "${{ github.action_path }}/validate-triage-output.sh" "$OUTPUT_FILE" "$ISSUE_NUMBER")"
-        echo "outcome=$outcome" >> "$GITHUB_OUTPUT"
-        echo "valid=$([ "$outcome" != 'invalid' ] && echo true || echo false)" >> "$GITHUB_OUTPUT"
-
-        if [ "$outcome" = 'invalid' ]; then
-          echo "::warning::Agent output has no usable triage outcome. It will not be applied."
-        fi
+# Managed by @plainconceptsplatform/workflows. Source: loops/actions/validate-triage-output/action.yml. Update with workflows update --force; consumer edits may be overwritten.
+name: Validate triage output
+description: Verify agent_output.json contains a usable triage verdict before any GitHub writes.
+inputs:
+  output-file:
+    description: Path to agent_output.json.
+    required: true
+  issue-number:
+    description: Issue number that every triage outcome must target.
+    required: true
+outputs:
+  valid:
+    description: Whether the output contains a usable triage comment with a verdict.
+    value: ${{ steps.validate.outputs.valid }}
+  outcome:
+    description: "Deterministic triage outcome: pass, needs-info, block, or invalid."
+    value: ${{ steps.validate.outputs.outcome }}
+runs:
+  using: composite
+  steps:
+    - name: Validate triage outcome
+      id: validate
+      shell: bash
+      env:
+        ISSUE_NUMBER: ${{ inputs.issue-number }}
+        OUTPUT_FILE: ${{ inputs.output-file }}
+      run: |
+        set -euo pipefail
+
+        outcome="$(bash "${{ github.action_path }}/validate-triage-output.sh" "$OUTPUT_FILE" "$ISSUE_NUMBER")"
+        echo "outcome=$outcome" >> "$GITHUB_OUTPUT"
+        echo "valid=$([ "$outcome" != 'invalid' ] && echo true || echo false)" >> "$GITHUB_OUTPUT"
+
+        if [ "$outcome" = 'invalid' ]; then
+          echo "::warning::Agent output has no usable triage outcome. It will not be applied."
+        fi

package/loops/actions/verify-route-matrix/verify-route-matrix.sh

@@ -7,6 +7,7 @@ set -euo pipefail
 
 HERE="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 ROUTER_YML="${HERE}/../../workflows/work-router.yml"
+AUTHORIZE_YML="${HERE}/../../workflows/authorize-bot-work.yml"
 IMPLEMENT_WORKER_MD="${HERE}/../../workflows/agent-implement.md"
 MERGE_GATE_WORKER_MD="${HERE}/../../workflows/agent-merge-gate.md"
 
@@ -59,24 +60,32 @@ assert_route() {
 }
 
 echo "── Label events ──────────────────────────────────────────────────────────"
-assert_route "refine label routes to refine" refine \
-  EVENT=issues ACTION=labeled LABEL=refine EVENT_ISSUE_NUMBER=42
-assert_route "implement label routes to implement" implement \
-  EVENT=issues ACTION=labeled LABEL=implement EVENT_ISSUE_NUMBER=42
+assert_route "human refine label waits for authorization" none \
+  EVENT=issues ACTION=labeled LABEL=refine ACTOR=maintainer EVENT_ISSUE_NUMBER=42
+assert_route "bot refine label routes to refine" refine \
+  EVENT=issues ACTION=labeled LABEL=refine ACTOR=platform-devbox[bot] EVENT_ISSUE_NUMBER=42
+assert_route "human implement label waits for authorization" none \
+  EVENT=issues ACTION=labeled LABEL=implement ACTOR=maintainer EVENT_ISSUE_NUMBER=42
+assert_route "bot implement label routes to implement" implement \
+  EVENT=issues ACTION=labeled LABEL=implement ACTOR=platform-devbox[bot] EVENT_ISSUE_NUMBER=42
+assert_route "human feature label waits for authorization" none \
+  EVENT=issues ACTION=labeled LABEL=feature ACTOR=maintainer EVENT_ISSUE_NUMBER=350
 assert_route "unrelated label routes nowhere" none \
   EVENT=issues ACTION=labeled LABEL=documentation EVENT_ISSUE_NUMBER=42
-assert_route "a non-label issue action routes to triage" triage \
+assert_route "issue opened without labels routes to triage" triage \
   EVENT=issues ACTION=opened EVENT_ISSUE_NUMBER=42
+assert_route "issue opened with refine label skips triage" none \
+  EVENT=issues ACTION=opened 'ISSUE_LABELS=["refine"]' EVENT_ISSUE_NUMBER=42
+assert_route "issue opened with implement label skips triage" none \
+  EVENT=issues ACTION=opened 'ISSUE_LABELS=["implement"]' EVENT_ISSUE_NUMBER=42
 assert_route "a human triage label routes to triage" triage \
   EVENT=issues ACTION=labeled LABEL=triage ACTOR=maintainer EVENT_ISSUE_NUMBER=42
 assert_route "a bot triage label routes nowhere" none \
   EVENT=issues ACTION=labeled LABEL=triage ACTOR=platform-devbox[bot] EVENT_ISSUE_NUMBER=42
+assert_route "implement + bot-working without feature routes to implement" implement \
+  EVENT=issues ACTION=labeled LABEL=bot-working 'ISSUE_LABELS=["implement","bot-working"]' EVENT_ISSUE_NUMBER=300
 assert "refine label starts a first pass" first \
-  "$(route_field refine-mode EVENT=issues ACTION=labeled LABEL=refine EVENT_ISSUE_NUMBER=42)"
-assert_route "direct label routes to direct" direct \
-  EVENT=issues ACTION=labeled LABEL=direct EVENT_ISSUE_NUMBER=42
-assert "direct label starts a first pass" first \
-  "$(route_field direct-mode EVENT=issues ACTION=labeled LABEL=direct EVENT_ISSUE_NUMBER=42)"
+  "$(route_field refine-mode EVENT=issues ACTION=labeled LABEL=refine ACTOR=platform-devbox[bot] EVENT_ISSUE_NUMBER=42)"
 
 echo "── Comment events ────────────────────────────────────────────────────────"
 assert_route "a comment on a pull request routes to apply-review" apply-review \
@@ -93,12 +102,6 @@ assert_route "the bot's own comment never re-enters refine" none \
 assert_route "a comment on an issue without refine routes nowhere" none \
   EVENT=issue_comment COMMENT_ON_PR=false COMMENT_SENDER_TYPE=User \
   'ISSUE_LABELS=["bug"]' EVENT_ISSUE_NUMBER=42
-assert_route "an author reply on a direct issue continues" direct \
-  EVENT=issue_comment COMMENT_ON_PR=false COMMENT_SENDER_TYPE=User \
-  'ISSUE_LABELS=["direct"]' EVENT_ISSUE_NUMBER=42
-assert "a direct reply is a continue pass" continue \
-  "$(route_field direct-mode EVENT=issue_comment COMMENT_ON_PR=false \
-    COMMENT_SENDER_TYPE=User 'ISSUE_LABELS=["direct"]' EVENT_ISSUE_NUMBER=42)"
 assert_route "the bot's own comment never re-enters direct" none \
   EVENT=issue_comment COMMENT_ON_PR=false COMMENT_SENDER_TYPE=Bot \
   'ISSUE_LABELS=["direct"]' EVENT_ISSUE_NUMBER=42
@@ -112,6 +115,14 @@ assert_route "the bot's own comment never re-enters triage" none \
   EVENT=issue_comment COMMENT_ON_PR=false COMMENT_SENDER_TYPE=Bot \
   'ISSUE_LABELS=["triage"]' EVENT_ISSUE_NUMBER=42
 
+echo "── Closed issues ─────────────────────────────────────────────────────────"
+assert_route "a closing comment on a refine issue does not re-refine" none   EVENT=issue_comment COMMENT_ON_PR=false COMMENT_SENDER_TYPE=User   ISSUE_STATE=closed 'ISSUE_LABELS=["refine"]' EVENT_ISSUE_NUMBER=42
+assert_route "a comment on a closed issue never re-triages" none   EVENT=issue_comment COMMENT_ON_PR=false COMMENT_SENDER_TYPE=User   ISSUE_STATE=closed 'ISSUE_LABELS=["triage"]' EVENT_ISSUE_NUMBER=42
+assert_route "a work label added to a closed issue routes nowhere" none   EVENT=issues ACTION=labeled LABEL=bot-working ISSUE_STATE=closed   'ISSUE_LABELS=["implement"]' EVENT_ISSUE_NUMBER=42
+assert_route "a closed issue reopened as opened still routes nowhere while closed" none   EVENT=issues ACTION=opened ISSUE_STATE=closed 'ISSUE_LABELS=[]' EVENT_ISSUE_NUMBER=42
+assert_route "a comment on a closed pull request still routes to apply-review" apply-review   EVENT=issue_comment COMMENT_ON_PR=true ISSUE_STATE=closed EVENT_ISSUE_NUMBER=7
+assert_route "an open refine issue is unaffected by the closed guard" refine   EVENT=issue_comment COMMENT_ON_PR=false COMMENT_SENDER_TYPE=User   ISSUE_STATE=open 'ISSUE_LABELS=["refine"]' EVENT_ISSUE_NUMBER=42
+
 echo "── Review events ─────────────────────────────────────────────────────────"
 assert_route "a review comment routes to apply-review" apply-review \
   EVENT=pull_request_review_comment EVENT_PR_NUMBER=7
@@ -121,13 +132,20 @@ assert_route "a pull_request_target routes to bot-approve" bot-approve \
   EVENT=pull_request_target ACTION=opened
 
 echo "── CI completion ─────────────────────────────────────────────────────────"
-assert_route "App CI completion routes to merge-gate" merge-gate \
-  EVENT=workflow_run RUN_PR_NUMBER=7 RUN_CONCLUSION=success RUN_ID=99
-assert "merge-gate carries the CI conclusion" failure \
+assert_route "a failed App CI run on a pull request routes to merge-gate" merge-gate \
+  EVENT=workflow_run RUN_PR_NUMBER=7 RUN_CONCLUSION=failure RUN_ID=99
+assert "merge-gate carries the failing CI conclusion" failure \
   "$(route_field ci-conclusion EVENT=workflow_run RUN_PR_NUMBER=7 \
     RUN_CONCLUSION=failure RUN_ID=99)"
-assert_route "a CI run with no pull request routes nowhere" none \
-  EVENT=workflow_run RUN_PR_NUMBER= RUN_CONCLUSION=success RUN_ID=99
+assert "merge-gate carries the failing CI run id" 99 \
+  "$(route_field ci-run-id EVENT=workflow_run RUN_PR_NUMBER=7 \
+    RUN_CONCLUSION=failure RUN_ID=99)"
+assert_route "a green App CI run does not auto-trigger the gate" none \
+  EVENT=workflow_run RUN_PR_NUMBER=7 RUN_CONCLUSION=success RUN_ID=99
+assert_route "a cancelled App CI run does not auto-trigger the gate" none \
+  EVENT=workflow_run RUN_PR_NUMBER=7 RUN_CONCLUSION=cancelled RUN_ID=99
+assert_route "a failed CI run with no pull request routes nowhere" none \
+  EVENT=workflow_run RUN_PR_NUMBER= RUN_CONCLUSION=failure RUN_ID=99
 
 echo "── Schedules ─────────────────────────────────────────────────────────────"
 while read -r cron; do
@@ -151,8 +169,6 @@ assert_route "refine dispatch rejects a non-numeric issue" none \
   EVENT=workflow_dispatch OPERATION=refine INPUT_ISSUE_NUMBER=abc
 assert_route "refine dispatch accepts a positive issue" refine \
   EVENT=workflow_dispatch OPERATION=refine INPUT_ISSUE_NUMBER=42
-assert_route "direct dispatch accepts a positive issue" direct \
-  EVENT=workflow_dispatch OPERATION=direct INPUT_ISSUE_NUMBER=42
 assert_route "direct dispatch needs an issue number" none \
   EVENT=workflow_dispatch OPERATION=direct INPUT_ISSUE_NUMBER=
 assert_route "triage dispatch accepts a positive issue" triage \
@@ -161,41 +177,80 @@ assert_route "triage dispatch needs an issue number" none \
   EVENT=workflow_dispatch OPERATION=triage INPUT_ISSUE_NUMBER=
 assert "triage dispatch defaults to first pass" first \
   "$(route_field triage-mode EVENT=workflow_dispatch OPERATION=triage INPUT_ISSUE_NUMBER=42)"
+assert_route "batch dispatch needs an issue number" none \
+  EVENT=workflow_dispatch OPERATION=batch INPUT_ISSUE_NUMBER=
 assert_route "merge-gate dispatch needs a pull request number" none \
   EVENT=workflow_dispatch OPERATION=merge-gate INPUT_PR_NUMBER=0
 assert_route "merge-gate dispatch accepts a positive pull request" merge-gate \
   EVENT=workflow_dispatch OPERATION=merge-gate INPUT_PR_NUMBER=7
-assert_route "stale-recovery dispatch needs no numbers" stale-recovery \
-  EVENT=workflow_dispatch OPERATION=stale-recovery
 assert_route "reconcile-bot-pr-runs dispatch needs no numbers" reconcile-bot-pr-runs \
   EVENT=workflow_dispatch OPERATION=reconcile-bot-pr-runs
 assert_route "an unknown operation routes nowhere" none \
   EVENT=workflow_dispatch OPERATION=deploy-everything
 assert "a scheduled audit reports its trigger kind" scheduled \
   "$(route_field trigger-kind EVENT=schedule "SCHEDULE=17 1 * * 1")"
+
 assert "a dispatched audit reports its trigger kind" manual \
   "$(route_field trigger-kind EVENT=workflow_dispatch OPERATION=audit INPUT_TRIGGER_KIND=manual)"
-assert_route "propose dispatch needs no numbers" propose \
-  EVENT=workflow_dispatch OPERATION=propose
-assert "a scheduled propose reports its trigger kind" scheduled \
-  "$(route_field trigger-kind EVENT=schedule "SCHEDULE=29 7 * * *")"
-assert "a dispatched propose reports its trigger kind" manual \
-  "$(route_field trigger-kind EVENT=workflow_dispatch OPERATION=propose INPUT_TRIGGER_KIND=manual)"
 
 echo "── Router wiring ─────────────────────────────────────────────────────────"
+
+# GitHub evaluates every Actions expression in a workflow file, including ones written inside
+# shell comments. An empty pair is not a valid expression and fails the whole file to parse,
+# with an error that points at a line number rather than saying what is wrong. Prose about
+# expressions must not contain one.
+empty_expr=$(grep -rl -e '${{[[:space:]]*}}' "${HERE}/../../workflows"/*.yml "${HERE}/../../workflows"/*.md 2>/dev/null || true)
+if [ -z "$empty_expr" ]; then
+  PASS=$((PASS + 1))
+else
+  FAIL=$((FAIL + 1))
+  echo "FAIL: workflow files contain an empty Actions expression:" >&2
+  printf '  %s
+' $empty_expr >&2
+fi
+
+
+# A hyphen inside a ${{ }} property path is parsed as subtraction, so the reference silently
+# resolves to nothing and the rendered prompt keeps the raw expression. Underscores only.
+if ! grep -qE 'needs\.[a-z_]+\.outputs\.[a-zA-Z0-9_]*-' "$IMPLEMENT_WORKER_MD"; then
+  PASS=$((PASS + 1))
+else
+  FAIL=$((FAIL + 1))
+  echo "FAIL: implement worker reads a hyphenated job output inside an expression" >&2
+  grep -nE 'needs\.[a-z_]+\.outputs\.[a-zA-Z0-9_]*-' "$IMPLEMENT_WORKER_MD" >&2
+fi
+
+# A worker that prints a ${VERIFY_COMMANDS_*} block without setting it renders an empty command
+# block, and the model invents its own build line. That is how a child shipped `dotnet build
+# --no-restore` against an unrestored workspace. The commands are split per area so a change
+# that only touches apps/web does not pay for a cold Release build of the API.
+VERIFY_OK=1
+for VAR in VERIFY_COMMANDS_API VERIFY_COMMANDS_WEB; do
+  if grep -q "env\.$VAR" "$IMPLEMENT_WORKER_MD" && ! grep -q "^  $VAR:" "$IMPLEMENT_WORKER_MD"; then
+    VERIFY_OK=0
+    echo "FAIL: implement worker prints $VAR without defining it" >&2
+  fi
+done
+if grep -qE 'env\.VERIFY_COMMANDS[^_]' "$IMPLEMENT_WORKER_MD"; then
+  VERIFY_OK=0
+  echo "FAIL: implement worker still references the unscoped VERIFY_COMMANDS" >&2
+fi
+if [ "$VERIFY_OK" -eq 1 ]; then PASS=$((PASS + 1)); else FAIL=$((FAIL + 1)); fi
+
 if grep -Fq 'protected-files: allowed' "$IMPLEMENT_WORKER_MD" &&
-  grep -Fq 'protected_changes:' "$MERGE_GATE_WORKER_MD"; then
+  grep -Fq 'protected-files: allowed' "$MERGE_GATE_WORKER_MD" &&
+  grep -Fq "needs.protected_changes.outputs.requires_review != 'true' || needs.subject.outputs.conclusion == 'failure'" "$MERGE_GATE_WORKER_MD"; then
   PASS=$((PASS + 1))
 else
   FAIL=$((FAIL + 1))
-  echo "FAIL: protected changes are not held for Merge Gate review" >&2
+  echo "FAIL: protected changes must allow failed-CI repair while remaining held from merge" >&2
 fi
 
 # This repository is public. Every route a human can start from a comment, a review or a
 # label must pass the authorize gate, or anyone able to comment can start a model run that
 # writes code. Asserted here because removing the gate would otherwise be a silent, one-line
 # change that nothing fails on.
-for route in refine implement direct apply-review; do
+for route in refine implement apply-review; do
   if grep -qE "route == '${route}'.*needs\.authorize\.outputs\.trusted == 'true'" "$ROUTER_YML"; then
     PASS=$((PASS + 1))
   else
@@ -215,8 +270,8 @@ else
   echo "FAIL: route 'triage' does not dispatch outside collaborators and require a trusted worker actor" >&2
 fi
 
-for route in refine implement direct triage apply-review merge-gate audit propose bot-approve \
-  audit-close cleanup-artifacts reconcile-bot-pr-runs stale-recovery validate; do
+for route in refine implement triage apply-review merge-gate audit bot-approve \
+  audit-close cleanup-artifacts reconcile-bot-pr-runs validate release; do
   if grep -q "route == '${route}'" "$ROUTER_YML"; then
     PASS=$((PASS + 1))
   else

package/loops/scripts/compile-agent-workflows.mjs

@@ -1,4 +1,6 @@
 // Managed by @plainconceptsplatform/workflows. Source: loops/scripts/compile-agent-workflows.mjs. Update with `workflows update --force`; consumer edits may be overwritten.
+
+const OPENCODE_VERSION = '1.18.23'
 import { spawnSync } from "node:child_process";
 import { existsSync, readdirSync, readFileSync, writeFileSync } from "node:fs";
 import { join } from "node:path";
@@ -35,13 +37,200 @@ for (const file of readdirSync(workflowDirectory)) {
   const path = join(workflowDirectory, file);
   const content = readFileSync(path, "utf8");
   const patched = content
-    .replaceAll("opencode run --print-logs --log-level DEBUG", "opencode run --port 4096 --log-level ERROR")
-    .replaceAll("opencode run --print-logs --log-level ERROR", "opencode run --port 4096 --log-level ERROR")
-    .replaceAll("opencode run --log-level ERROR", "opencode run --port 4096 --log-level ERROR")
+    .replaceAll("opencode run --print-logs --log-level DEBUG", "opencode run --log-level ERROR")
+    .replaceAll("opencode run --print-logs --log-level ERROR", "opencode run --log-level ERROR")
+    .replaceAll("opencode run --log-level ERROR", "opencode run --log-level ERROR")
     .replaceAll("--log-level DEBUG", "--log-level ERROR")
     .replace(/GH_AW_INFO_MODEL: "[^"]*"/g, 'GH_AW_INFO_MODEL: "per-agent"')
     .replace(/OPENCODE_MODEL: [^\n]+/g, "OPENCODE_MODEL: ''")
-    .replace(/GH_AW_INFO_MODEL_COSTS: '[^']*'/g, 'GH_AW_INFO_MODEL_COSTS: \'{"providers":{}}\'');
+    .replace(/GH_AW_INFO_MODEL_COSTS: '[^']*'/g, 'GH_AW_INFO_MODEL_COSTS: \'{"providers":{}}\'')
+    // The MCP gateway is the only thing the agent publishes on the host loopback, so it is the
+    // one thing two runners on the same machine cannot share. Honour an inherited port so each
+    // runner service can pick its own; everything else is namespaced by its Docker daemon.
+    // awf names its containers awf-agent, awf-squid and awf-api-proxy with no way to change
+    // them, so two agent jobs on one host recreate each other's containers and the first dies
+    // with exit 137. Giving each runner its own user and daemon isolated the containers but
+    // broke everything the runners share through the filesystem: awf and gh-aw both write
+    // fixed-name files into /tmp, and a file one user creates cannot be overwritten by the
+    // next. Six separate failures came from that. One host lock is the smaller trade: agent
+    // jobs run one at a time, every other job still uses all the runners, and every user is
+    // the same again. The chain is serial anyway, so in practice this only queues one consumer behind
+    // the other. Held for the whole agent run, which is deliberate. The lock lives outside the
+    // /tmp/gh-aw namespace on purpose: the keying rewrite below would otherwise make the lock
+    // file per job, which is silently no lock at all.
+    // Agent jobs run in parallel again. Each runner has its own Docker-in-Docker daemon, so
+    // awf's fixed container names (awf-agent, awf-squid, awf-api-proxy, awmg-mcpg) live in
+    // separate namespaces and cannot recreate each other. gh-aw detects the tcp DOCKER_HOST
+    // and switches to its ARC/DinD path by itself, so no flag is needed here. The host-wide
+    // flock this replaces made every agent job wait for the previous one.
+    // Three host-global resources were left, and concurrent agent jobs fought over all of them.
+    // The global npm install rewrote the opencode binary another job was executing and killed it
+    // with SIGKILL mid-run; the warm server and its data directory were shared by every runner.
+    //
+    // All of these sites are step-level run: or env:, where the runner context is available. It
+    // is not available at workflow level, which is what broke the staging path earlier.
+    //
+    // Install only when the pinned version is missing, and take a lock so two jobs starting at
+    // once cannot both write the global prefix.
+    // gh-aw pins opencode-ai 1.2.14 at every release checked, up to v0.87.5. That version is
+    // from 2026-02-25. The harness expects 1.18.9 and this is the current release, so a gh-aw
+    // upgrade does not move it and the pin is ours to choose.
+    // gh-aw defaults NPM_CONFIG_MIN_RELEASE_AGE to 3 days, which blocks any package
+    // published in the last three days with ETARGET "No matching version found ... with a
+    // date before". Lowered to 1 so a fix released yesterday is usable. This is a
+    // supply-chain cooldown: shortening it accepts a newer package sooner.
+    .replace(/NPM_CONFIG_MIN_RELEASE_AGE: ['\"]?3['\"]?/g, "NPM_CONFIG_MIN_RELEASE_AGE: '1'")
+    // The MCP gateway runs inside a per-runner Docker-in-Docker daemon. gh-aw publishes it on
+    // 127.0.0.1, which is the DinD container's own loopback, while the outer publish forwards to
+    // that container's eth0, so the two never meet and gh-aw's health check fails 120 times with
+    // ECONNREFUSED. Binding 0.0.0.0 inside the daemon connects them. The host still exposes the
+    // port on loopback only, because the DinD container is published as 127.0.0.1:<port>.
+    .replaceAll("-p 127.0.0.1:'\"${MCP_GATEWAY_PORT}\"':", "-p '\"${MCP_GATEWAY_PORT}\"':")
+    // Each runner needs its own gateway port: four DinD daemons publish through to one host
+    // loopback, so two jobs on 8080 would collide. The runner sets it in .env.
+    // awf chroots into the Docker daemon's filesystem and requires it to be the runner's own
+    // glibc host. A Docker-in-Docker daemon fails with "Detected Alpine/musl host filesystem
+    // under /host", and no dind image fixes it: the agent needs the runner's toolchain and
+    // workspace, which a separate daemon container never has. So every agent job shares one
+    // daemon, awf's container names are fixed, and the jobs must be serialised.
+    .replaceAll('          awf --config', '          flock /tmp/agentic-awf.lock awf --config')
+    .replaceAll('export MCP_GATEWAY_PORT="8080"', 'export MCP_GATEWAY_PORT="${MCP_GATEWAY_PORT:-8080}"')
+    // The agent's safe outputs land in safeoutputs.jsonl, but the collector reads
+    // agent_output.json, and nothing in the generated workflow converts one to the other.
+    // With the OpenCode engine the tool calls go through the MCP server rather than stdout,
+    // so the log parser never produces agent_output.json and the placeholder step writes
+    // {"items":[]} over a run that did real work: the job goes green and the pull request
+    // is silently dropped. Build the collector's input from what the agent actually emitted.
+    .replaceAll("echo '{\"items\":[]}' > /tmp/gh-aw-${{ github.run_id }}/agent_output.json", "if [ -s /tmp/gh-aw-${{ github.run_id }}/safeoutputs.jsonl ]; then jq -s '{items: .}' /tmp/gh-aw-${{ github.run_id }}/safeoutputs.jsonl > /tmp/gh-aw-${{ github.run_id }}/agent_output.json; else echo '{\"items\":[]}' > /tmp/gh-aw-${{ github.run_id }}/agent_output.json; fi")
+    // The "Copy Safe Outputs" step runs on the host after the awf container exits. At that
+    // point /tmp/gh-aw/ IS the host's /tmp/gh-aw/, where the safeoutputs MCP container wrote
+    // patch and bundle files (via the MCP gateway's -v /tmp:/tmp:rw mount). Extend the step
+    // to also copy those files to RUNNER_TEMP/gh-aw/ so the upload step can include them.
+    // Without this, the upload step's glob /tmp/gh-aw/aw-*.patch runs inside the awf chroot
+    // (where /tmp/gh-aw is a different path) and finds nothing. The safe_outputs and conclude
+    // jobs then receive no patches in the artifact and silently skip the push.
+    .replace(
+      '          cp "$GH_AW_SAFE_OUTPUTS" /tmp/gh-aw/safeoutputs.jsonl 2>/dev/null || true\n',
+      '          cp "$GH_AW_SAFE_OUTPUTS" /tmp/gh-aw/safeoutputs.jsonl 2>/dev/null || true\n' +
+      '          # Copy patch/bundle files generated by the safeoutputs MCP container to\n' +
+      '          # RUNNER_TEMP/gh-aw/ so the upload step includes them in the artifact.\n' +
+      '          mkdir -p "${RUNNER_TEMP}/gh-aw"\n' +
+      '          ls -la /tmp/gh-aw/ 2>/dev/null || true\n' +
+      '          cp /tmp/gh-aw/aw-*.patch "${RUNNER_TEMP}/gh-aw/" 2>/dev/null || true\n' +
+      '          cp /tmp/gh-aw/aw-*.bundle "${RUNNER_TEMP}/gh-aw/" 2>/dev/null || true\n' +
+      '          ls -la "${RUNNER_TEMP}/gh-aw/"aw-* 2>/dev/null || true\n')
+    // Add patch/bundle paths to the upload glob so the agent artifact carries what
+    // push-agent-branch needs. The anchor is the two adjacent path lines of the
+    // "...agent" upload step; the "...agent-output-fallback" upload lists them in the
+    // opposite order, so it cannot match. Anchoring matters: the first bare
+    // '/tmp/gh-aw/agent_output.json\n' in the file is the placeholder step's echo line,
+    // and replacing there corrupted the placeholder into executing the globs as
+    // commands while the upload list stayed without bundles. The artifact then carried
+    // no bundle, push-agent-branch silently skipped the push, and the gate reported
+    // "remediated" on a pull request that was never touched.
+    // Only the /tmp/gh-aw globs may be added: a ${{ runner.temp }} path as well would
+    // move the upload's least-common-ancestor from /tmp/gh-aw to /, and every file in
+    // the artifact (agent_output.json included) would gain a prefix that
+    // download-agent-output does not look for.
+    .replace(
+      '            /tmp/gh-aw/safeoutputs.jsonl\n            /tmp/gh-aw/agent_output.json\n',
+      '            /tmp/gh-aw/safeoutputs.jsonl\n' +
+      '            /tmp/gh-aw/aw-*.patch\n' +
+      '            /tmp/gh-aw/aw-*.bundle\n' +
+      '            /tmp/gh-aw/agent_output.json\n')
+
+    // v0.87.5's arc-dind mode stages the engine CLI to a daemon-visible path but assumes the
+    // Copilot engine: command -v copilot is empty under engine: opencode and cp "" fails the
+    // job before the agent starts. OpenCode needs no staging, because npm -g installs it under
+    // the tool-cache prefix inside _work, which the dind daemon shares.
+    // Centralised AgentMemory: an always-on App Service; the shim proxies to it when the
+    // URL is set and authenticates with the HMAC secret. Local development leaves both
+    // unset and keeps the local per-run store.
+    .replace(/^env:\n/m, 'env:\n  AGENTMEMORY_URL: https://agentmemory-pro-01.azurewebsites.net\n')
+    // the secret is scoped to the one step that runs the agent (semgrep: a secret in
+    // workflow-level env is visible to every job and step)
+    .replaceAll('          OPENAI_BASE_URL: https://forge.plainconcepts.com/v1',
+      '          OPENAI_BASE_URL: https://forge.plainconcepts.com/v1' + '\n' +
+      '          AGENTMEMORY_SECRET: ${{ secrets.AGENTMEMORY_SECRET }}')
+    // the router passes secrets explicitly (semgrep flags secrets: inherit as over-broad),
+    // so the callee must declare everything it accepts
+    .replace(/^      COPILOT_GITHUB_TOKEN:/m,
+      '      AGENTMEMORY_SECRET:' + '\n' + '        required: false' + '\n' + '      COPILOT_GITHUB_TOKEN:')
+    .replaceAll('          COPILOT_SRC="$(command -v copilot)"',
+      '          command -v copilot >/dev/null 2>&1 || { echo "no copilot binary (engine is opencode); skipping"; exit 0; }' + '\n' +
+      '          COPILOT_SRC="$(command -v copilot)"')
+    // "A failed run is already a red run": report-failure-as-issue: false silences one
+    // reporter, but gh-aw hardcodes a second one (report_failed_jobs) that files an
+    // "[aw] Failed jobs" issue per red run. Same philosophy, same off switch.
+    .replaceAll('GH_AW_REPORT_FAILED_JOBS: "true"', 'GH_AW_REPORT_FAILED_JOBS: "false"')
+    // gh-aw sees a custom step calling dotnet and injects its own setup-dotnet, which carries
+    // no DOTNET_INSTALL_DIR and so tries to write /usr/share/dotnet. The runner user has no
+    // sudo, so the job dies with "Permission denied" before the agent starts. The shared
+    // baseline step already redirects to the tool cache; this gives every other one the same
+    // env, including ones a future gh-aw release injects.
+    .replace(
+      /^( +)- name: Setup \.NET\n\1  uses: actions\/setup-dotnet@[^\n]*\n\1  with:\n((?:\1    [^\n]*\n)+)(?!\1  env:)/gm,
+      (_m, indent, withBody) =>
+        indent + '- name: Setup .NET\n' + indent + '  uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6.0.0\n' +
+        indent + '  with:\n' + withBody +
+        indent + '  env:\n' + indent + '    DOTNET_INSTALL_DIR: ${{ runner.tool_cache }}/dotnet\n')
+    .replace(/opencode-ai@[0-9][0-9.]*/g, 'opencode-ai@' + OPENCODE_VERSION)
+    // gh-aw installs with --ignore-scripts, which blocks opencode's own postinstall. That
+    // script downloads the platform binary, so 1.18 fails at first use with "opencode-ai's
+    // postinstall script was not run". 1.2.14 did not need it. Run only opencode's postinstall
+    // explicitly, so every other package's scripts stay blocked.
+    .replace(
+      /npm install --ignore-scripts -g opencode-ai@([0-9][0-9.]*)/g,
+      (_m, v) =>
+        "opencode --version 2>/dev/null | grep -qF '" + v + "' || " +
+        "flock /tmp/opencode-install.lock sh -c 'npm install --ignore-scripts -g opencode-ai@" + v +
+        " && cd \"$(npm root -g)/opencode-ai\" && node postinstall.mjs' # opencode-ai@" + v)
+    // One warm server per runner, on its own port, with its own data directory. Keyed on the
+    // runner rather than the run so a runner keeps its server warm between its own jobs.
+    // No double quotes here: the enclosing run: is a double-quoted YAML scalar, so a quote
+    // would have to be escaped. The default has no spaces, so bare is safe shell.
+    .replace(/\/tmp\/opencode-data(?!-\$\{\{)/g, () => '/tmp/opencode-data-${{ runner.name }}');
+
+  let rewritten = patched;
+  // A queued implement executes hours after its run was created, but actions/checkout
+  // without a ref checks out github.sha, which GitHub pins at run creation. Five children
+  // queued together at 02:01 all carried the 02:01 base; once the first sibling merged,
+  // every later push became a rebase onto a moved parent, which gh-aw's signed-commit
+  // push cannot do (it dies with "cannot rebase: You have unstaged changes" and files the
+  // pull request as an issue instead of a pull request). Checking out the branch tip at
+  // execution time makes the commit parent current main; the implement-global queue
+  // already keeps sibling merges out of the window while the agent runs.
+  if (file === "agent-implement.lock.yml") {
+    const start = rewritten.indexOf("\n  agent:\n");
+    const rest = start === -1 ? "" : rewritten.slice(start + 1);
+    const next = rest.search(/\n  [a-z_][a-zA-Z_-]*:\n/);
+    if (start !== -1 && next !== -1) {
+      const end = start + 1 + next;
+      const span = rewritten.slice(start, end).replace(
+        /(uses: actions\/checkout@[^\n]*\n(\s+)with:\n(?:\2  [^\n]+\n)*)/,
+        (whole, _block, indent) =>
+          whole.includes("ref:") ? whole : whole + indent + "  ref: ${{ github.event.repository.default_branch }}\n",
+      );
+      rewritten = rewritten.slice(0, start) + span + rewritten.slice(end);
+    }
+  }
+
+  // Guard the two rewrites the compiled agent jobs cannot work without. The anchors are
+  // upstream template text: when a gh-aw upgrade reshapes either step, the silent
+  // failure mode returns (an artifact with no bundle, a skipped push, a green gate on
+  // an untouched pull request). Failing the compile is the only loud signal there is.
+  for (const check of [
+    { name: "bundle upload glob", ok: /\n( +)- name: Upload agent artifacts\n\1  if: always\(\)\n\1  continue-on-error: true\n\1  uses: actions\/upload-artifact@[^\n]*\n\1  with:\n\1    name: \$\{\{ needs\.activation\.outputs\.artifact_prefix \}\}agent\n\1    path: \|\n(?:\1      [^\n]*\n)*\1      \/tmp\/gh-aw\/aw-\*\.bundle\n/ },
+    { name: "placeholder step intact", ok: /\n( +)- name: Write agent output placeholder if missing\n\1  if: always\(\)\n\1  run: \|\n\1    if \[ ! -f \/tmp\/gh-aw\/agent_output\.json \]; then\n\1      echo '\{"items":\[\]\}' > \/tmp\/gh-aw\/agent_output\.json\n\1    fi\n/ },
+  ]) {
+    if (!check.ok.test(rewritten)) {
+      process.stderr.write(
+        `compile patch "${check.name}" no longer matches in ${file}: the gh-aw template changed. ` +
+        `Re-anchor the rewrite in loops/scripts/compile-agent-workflows.mjs, or agent pushes are silently dropped.\n`,
+      );
+      process.exitCode = 1;
+    }
+  }
 
-  if (patched !== content) writeFileSync(path, patched);
-}
+  if (rewritten !== content) writeFileSync(path, rewritten);
+}