@plainconceptsplatform/workflows 0.28.19 → 0.28.20
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
|
@@ -181,7 +181,7 @@ jobs:
|
|
|
181
181
|
shell: bash
|
|
182
182
|
run: |
|
|
183
183
|
set -euo pipefail
|
|
184
|
-
mapfile -t authored < <(git ls-files '.github/workflows/*.yml' '.github/actions/**' 2>/dev/null || true)
|
|
184
|
+
mapfile -t authored < <(git ls-files '.github/workflows/*.yml' '.github/actions/**' 2>/dev/null | grep -vE '\.lock\.yml$' || true)
|
|
185
185
|
[ "${#authored[@]}" -gt 0 ] || exit 0
|
|
186
186
|
# Two passes, because "is this a literal" is the hard half. The first finds every
|
|
187
187
|
# assignment to a password-ish name whose value is quoted; the second keeps only
|
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
# Managed by @plainconceptsplatform/workflows. Source: loops/workflows/agent-refine.md. Update with `workflows update --force`; consumer edits may be overwritten.
|
|
3
3
|
env:
|
|
4
|
-
REPO_RULES: "Refine only the selected issue into a grounded, implementation-ready user story. Read repository documentation for domain context. Write acceptance criteria that match existing patterns. Do not implement code."
|
|
4
|
+
REPO_RULES: "Refine only the selected issue into a grounded, implementation-ready user story. Read repository documentation for domain context. Write acceptance criteria that match existing patterns. Where a story or its open questions decide how business data (named people, roles, addresses) is stored, resolve it toward the repository's convention for that data -- a database entity or a settings entry -- and record that choice in the acceptance criteria; do not carry a person's name or email address into the story as something the code reads from a constant. Do not implement code."
|
|
5
5
|
# The estimate decides whether a story gets split, and the prompt tells the agent these bands
|
|
6
6
|
# come from this repository's own merged pull requests. They have to actually come from it, or
|
|
7
7
|
# the claim is false and every repository sizes work on another one's diffs.
|
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
# Managed by @plainconceptsplatform/workflows. Source: loops/workflows/agent-triage.md. Update with `workflows update --force`; consumer edits may be overwritten.
|
|
3
3
|
env:
|
|
4
|
-
REPO_RULES: "Triage issues opened by outside collaborators. Assess template completeness, security risk, change size, danger level, duplicates, clarity, reproducibility, acceptance criteria, and cross-cutting impact. Do not implement code. Do not modify the issue body."
|
|
4
|
+
REPO_RULES: "Triage issues opened by outside collaborators. Assess template completeness, security risk, change size, danger level, duplicates, clarity, reproducibility, acceptance criteria, and cross-cutting impact. When the request names specific people, email addresses, or business entities as the thing the code acts on, judge where that data is meant to live: business data that belongs in the database or a settings page is a design decision, not a wording detail, and it must not be left for the implementer to decide by hardcoding it. Do not implement code. Do not modify the issue body."
|
|
5
5
|
# What a product owner may ask for, and what has to become a maintainer-owned technical
|
|
6
6
|
# proposal instead. This is business policy, so it belongs to the repository rather than to
|
|
7
7
|
# the package: it is also the check that closes somebody's issue, which is the last place a
|
|
@@ -493,9 +493,13 @@ timeout-minutes: 45
|
|
|
493
493
|
multiple components, modules, or services? Flag if it is too large for single-issue
|
|
494
494
|
implementation.
|
|
495
495
|
|
|
496
|
-
|
|
497
|
-
|
|
498
|
-
|
|
496
|
+
**Check 4 Danger level.** Does the request touch authentication, authorization, IAM,
|
|
497
|
+
infrastructure, migrations, data model changes, or other high-risk areas? These need
|
|
498
|
+
maintainer eyes before the pipeline starts. Also flag the data-placement case: the
|
|
499
|
+
request hardcodes business data in code (a named reviewer's email, a person the code
|
|
500
|
+
acts on, a fixed address) that belongs in the database or a settings page. That is the
|
|
501
|
+
difference between modelling a role and hardcoding a person, and it is a design decision
|
|
502
|
+
the implementer must not be left to make.
|
|
499
503
|
|
|
500
504
|
**Check 5 Duplicate detection.** Compare the issue title and body against the open
|
|
501
505
|
issues in `${{ env.OPEN_ISSUES_PATH }}`. Flag any that are semantically similar same
|
|
@@ -529,7 +533,13 @@ timeout-minutes: 45
|
|
|
529
533
|
|
|
530
534
|
**pass.** All checks pass, including Product-owner eligibility. The issue is a clear,
|
|
531
535
|
appropriately scoped product request and ready for refinement. The refine label will
|
|
532
|
-
be added by the workflow to enter the normal pipeline.
|
|
536
|
+
be added by the workflow to enter the normal pipeline. A `pass` must not silently
|
|
537
|
+
resolve an open question whose answer decides where business data lives (named
|
|
538
|
+
individual vs managed role, address in code vs in the database or settings). When such
|
|
539
|
+
a question is a pure design call, state in the assessment which way it must go --
|
|
540
|
+
model the data in the database or a settings page rather than in code -- as an
|
|
541
|
+
explicit requirement the refine stage must satisfy in the story and its acceptance
|
|
542
|
+
criteria.
|
|
533
543
|
|
|
534
544
|
**needs-info.** One or more checks need clarification from the author. State exactly
|
|
535
545
|
what information is missing and what the author should provide. The review label will be
|