@plainconceptsplatform/agent-harness 3.0.1 → 3.0.3

package/cli/commands/join.js

@@ -50,11 +50,27 @@ export async function runJoin() {
   header('Step 2, Installing OpenCode plugins')
   const pkgPath = path.join(opencodeDir, 'package.json')
   if (await fse.pathExists(pkgPath)) {
+    // `reject: false` made the catch below unreachable: a failed install exited
+    // non-zero without throwing, so this reported success while the plugin's
+    // dependency was missing and every plugin silently refused to load. Let the
+    // call reject, and confirm the dependency is actually on disk before saying so.
+    const declared = Object.keys(
+      parseJsonc(await fse.readFile(pkgPath, 'utf8'))?.dependencies ?? {},
+    )
     try {
-      await execa('npm', ['install'], { cwd: opencodeDir, reject: false, stdio: 'pipe' })
-      success('OpenCode plugins installed')
-    } catch {
+      await execa('npm', ['install'], { cwd: opencodeDir, stdio: 'pipe' })
+    } catch (err) {
       warn('npm install failed in .opencode/: plugins may not load correctly')
+      if (err?.stderr) info(String(err.stderr).trim().split('\n').slice(-3).join('\n'))
+    }
+    const missing = declared.filter(
+      name => !fse.pathExistsSync(path.join(opencodeDir, 'node_modules', ...name.split('/'))),
+    )
+    if (missing.length === 0) {
+      success('OpenCode plugins installed')
+    } else {
+      warn(`These dependencies are still missing from .opencode/node_modules: ${missing.join(', ')}`)
+      warn('Plugins that import them will not load. Re-run `npm install` there once the registry is reachable.')
     }
   } else {
     warn('No .opencode/package.json found: skipping plugin install')

package/harness/.opencode/plugins/pc-subagent-tiers.js

@@ -19,7 +19,7 @@
 // generation is the mechanism: writing the files in setup, before agents resolve,
 // is what makes them visible.
 
-import { Plugin } from "@opencode/plugin"
+import { Plugin, Model } from "@opencode/plugin"
 import fs from "node:fs/promises"
 import path from "node:path"
 
@@ -143,10 +143,16 @@ function stripLegacyFields(frontmatter) {
 
 function setScalar(frontmatter, key, value) {
   const line = `${key}: ${value}`
-  if (new RegExp(`^${key}:`, "m").test(frontmatter)) {
-    return frontmatter.replace(new RegExp(`^${key}:.*$`, "m"), () => line)
+  // String operations rather than a built RegExp: `key` is one of this module's
+  // own constants, so the pattern would be safe, but a dynamic regexp here is a
+  // ReDoS-shaped pattern that static analysis rightly refuses to clear.
+  const lines = frontmatter.split(/\r?\n/)
+  const index = lines.findIndex(current => current.startsWith(`${key}:`))
+  if (index === -1) {
+    return frontmatter ? `${line}\n${frontmatter}` : line
   }
-  return frontmatter ? `${line}\n${frontmatter}` : line
+  lines[index] = line
+  return lines.join("\n")
 }
 
 function permissionsYaml(permissions) {
@@ -189,6 +195,9 @@ function buildVariant(templateContent, model) {
   let fm = stripLegacyFields(frontmatter ?? "")
   fm = setScalar(fm, "mode", "subagent")
   fm = setScalar(fm, "model", model)
+  // Hidden by default: a tier is chosen by whoever writes the task, not picked
+  // from the @ menu. Without this the menu lists every specialist once per tier.
+  fm = setScalar(fm, "hidden", "true")
   if (!/^color:/m.test(fm)) {
     const name = ""
     fm = setScalar(fm, "color", name ? yamlColor(agentColor(name)) : yamlColor(agentColor("engineer")))
@@ -324,7 +333,13 @@ export default Plugin.define({
             const existing = editor.get(id)
             if (!existing) continue
             const model = models[spec.tier]
-            if (model) existing.model = model
+            if (model) {
+              try {
+                existing.model = Model.Ref.parse(model)
+              } catch {
+                // invalid model ref; leave undefined so session model applies
+              }
+            }
             existing.mode = "primary"
             existing.description = spec.description
             if (spec.permissions) existing.permissions = spec.permissions

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@plainconceptsplatform/agent-harness",
-  "version": "3.0.1",
+  "version": "3.0.3",
   "description": "Installs the Plain Concepts Platform Harness into any codebase, and keeps it up to date. Wires OpenCode, OpenSpec, codegraph, and agentmemory into a multi-agent workflow that runs on native parallel subagents.",
   "keywords": [
     "opencode",

package/skills/pc-plan-goal/branching.md

@@ -1,30 +1,39 @@
-# Branching procedure
-
-Resolve and record the branch names:
-
-```bash
-START_BRANCH="$(git branch --show-current)"
-DEFAULT_BRANCH="$(git symbolic-ref --short refs/remotes/origin/HEAD 2>/dev/null | sed 's|^origin/||')"
-[ -z "$DEFAULT_BRANCH" ] && DEFAULT_BRANCH="main"
-```
-
-Stash uncommitted work when needed and record that the goal stash exists:
-
-```bash
-git stash push -u -m "goal-wip"
-```
-
-Create the feature branch from the synchronized default branch:
-
-```bash
-git switch "$DEFAULT_BRANCH"
-
-if git remote get-url origin >/dev/null 2>&1; then
-  git pull origin "$DEFAULT_BRANCH"
-fi
-
-git switch -c "feature/{slug}"
-BRANCH="$(git branch --show-current)"
-```
-
-Everything through archive happens on `$BRANCH`.
+# Branching procedure
+
+Resolve and record the branch names. If the invoking workflow already placed you on a feature branch (`feature/*`, `fix/*`, etc.), it owns the branch: do not stash, switch, pull, or rename. The sandbox hosting the workflow has no git credentials, so those commands would either corrupt the tree or hang, and the workflow has already cut the branch from the default branch. Treat its result as given.
+
+```bash
+BRANCH="$(git branch --show-current)"
+case "$BRANCH" in
+  feature/*|fix/*|chore/*|docs/*|refactor/*)
+    START_BRANCH="$BRANCH"
+    DEFAULT_BRANCH="$BRANCH"
+    GOAL_STASH="none"
+    ;;
+  *)
+    START_BRANCH="$BRANCH"
+    DEFAULT_BRANCH="$(git symbolic-ref --short refs/remotes/origin/HEAD 2>/dev/null | sed 's|^origin/||')"
+    [ -z "$DEFAULT_BRANCH" ] && DEFAULT_BRANCH="main"
+
+    # Stash uncommitted work when needed and record that the goal stash exists.
+    git stash push -u -m "goal-wip"
+    GOAL_STASH="goal-wip"
+
+    # Create the feature branch from the synchronized default branch.
+    git switch "$DEFAULT_BRANCH"
+
+    if git remote get-url origin >/dev/null 2>&1; then
+      git pull origin "$DEFAULT_BRANCH"
+    fi
+
+    git switch -c "feature/{slug}"
+    BRANCH="$(git branch --show-current)"
+    ;;
+esac
+```
+
+Record the branch name and that `feature/{slug}` was applied unconditionally, so downstream phases can restore if they move off it.
+
+Everything through archive happens on `$BRANCH`.
+
+When a later phase renames `$BRANCH` to match the canonical change slug (Phase 3 of `pc-plan-goal`), skip the rename if the workflow already fixed the name. Renaming would call `git branch -m`, which a credentialless sandbox refuses, and the workflow's `create_pull_request` is told to use the branch as named. Detect this by checking that `$BRANCH` already starts with `feature/`; if it does, keep it.