@pkmn/sim 0.9.26 → 0.9.28

package/build/esm/data/abilities.mjs

@@ -89,15 +89,12 @@ export const Abilities = {
     },
     airlock: {
         onSwitchIn(pokemon) {
-            this.effectState.switchingIn = true;
+            // Air Lock does not activate when Skill Swapped or when Neutralizing Gas leaves the field
+            this.add('-ability', pokemon, 'Air Lock');
+            this.effect.onStart.call(this, pokemon);
         },
         onStart(pokemon) {
-            // Air Lock does not activate when Skill Swapped or when Neutralizing Gas leaves the field
             pokemon.abilityState.ending = false; // Clear the ending flag
-            if (this.effectState.switchingIn) {
-                this.add('-ability', pokemon, 'Air Lock');
-                this.effectState.switchingIn = false;
-            }
             this.eachEvent('WeatherChange', this.effect);
         },
         onEnd(pokemon) {
@@ -259,11 +256,7 @@ export const Abilities = {
         num: 165,
     },
     asoneglastrier: {
-        onPreStart(pokemon) {
-            this.add('-ability', pokemon, 'As One');
-            this.add('-ability', pokemon, 'Unnerve');
-            this.effectState.unnerved = true;
-        },
+        onSwitchInPriority: 1,
         onStart(pokemon) {
             if (this.effectState.unnerved)
                 return;
@@ -288,11 +281,7 @@ export const Abilities = {
         num: 266,
     },
     asonespectrier: {
-        onPreStart(pokemon) {
-            this.add('-ability', pokemon, 'As One');
-            this.add('-ability', pokemon, 'Unnerve');
-            this.effectState.unnerved = true;
-        },
+        onSwitchInPriority: 1,
         onStart(pokemon) {
             if (this.effectState.unnerved)
                 return;
@@ -565,15 +554,12 @@ export const Abilities = {
     },
     cloudnine: {
         onSwitchIn(pokemon) {
-            this.effectState.switchingIn = true;
+            // Cloud Nine does not activate when Skill Swapped or when Neutralizing Gas leaves the field
+            this.add('-ability', pokemon, 'Cloud Nine');
+            this.effect.onStart.call(this, pokemon);
         },
         onStart(pokemon) {
-            // Cloud Nine does not activate when Skill Swapped or when Neutralizing Gas leaves the field
             pokemon.abilityState.ending = false; // Clear the ending flag
-            if (this.effectState.switchingIn) {
-                this.add('-ability', pokemon, 'Cloud Nine');
-                this.effectState.switchingIn = false;
-            }
             this.eachEvent('WeatherChange', this.effect);
         },
         onEnd(pokemon) {
@@ -627,10 +613,22 @@ export const Abilities = {
         num: 213,
     },
     commander: {
+        onAnySwitchInPriority: -2,
+        onAnySwitchIn() {
+            this.effect.onUpdate.call(this, this.effectState.target);
+        },
+        onStart(pokemon) {
+            this.effect.onUpdate.call(this, pokemon);
+        },
         onUpdate(pokemon) {
             if (this.gameType !== 'doubles')
                 return;
+            // don't run between when a Pokemon switches in and the resulting onSwitchIn event
+            if (this.queue.peek()?.choice === 'runSwitch')
+                return;
             const ally = pokemon.allies()[0];
+            if (pokemon.switchFlag || ally?.switchFlag)
+                return;
             if (!ally || pokemon.baseSpecies.baseSpecies !== 'Tatsugiri' || ally.baseSpecies.baseSpecies !== 'Dondozo') {
                 // Handle any edge cases
                 if (pokemon.getVolatile('commanding'))
@@ -716,6 +714,7 @@ export const Abilities = {
         num: 212,
     },
     costar: {
+        onSwitchInPriority: -2,
         onStart(pokemon) {
             const ally = pokemon.allies()[0];
             if (!ally)
@@ -1098,12 +1097,8 @@ export const Abilities = {
     },
     drizzle: {
         onStart(source) {
-            for (const action of this.queue) {
-                if (action.choice === 'runPrimal' && action.pokemon === source && source.species.id === 'kyogre')
-                    return;
-                if (action.choice !== 'runSwitch' && action.choice !== 'runPrimal')
-                    break;
-            }
+            if (source.species.id === 'kyogre' && source.item === 'blueorb')
+                return;
             this.field.setWeather('raindance');
         },
         flags: {},
@@ -1113,12 +1108,8 @@ export const Abilities = {
     },
     drought: {
         onStart(source) {
-            for (const action of this.queue) {
-                if (action.choice === 'runPrimal' && action.pokemon === source && source.species.id === 'groudon')
-                    return;
-                if (action.choice !== 'runSwitch' && action.choice !== 'runPrimal')
-                    break;
-            }
+            if (source.species.id === 'groudon' && source.item === 'redorb')
+                return;
             this.field.setWeather('sunnyday');
         },
         flags: {},
@@ -1218,14 +1209,12 @@ export const Abilities = {
     },
     embodyaspectcornerstone: {
         onStart(pokemon) {
-            if (pokemon.baseSpecies.name === 'Ogerpon-Cornerstone-Tera' && !this.effectState.embodied) {
-                this.effectState.embodied = true;
+            if (pokemon.baseSpecies.name === 'Ogerpon-Cornerstone-Tera' &&
+                this.effectState.embodied !== pokemon.previouslySwitchedIn) {
+                this.effectState.embodied = pokemon.previouslySwitchedIn;
                 this.boost({ def: 1 }, pokemon);
             }
         },
-        onSwitchIn() {
-            delete this.effectState.embodied;
-        },
         flags: { failroleplay: 1, noreceiver: 1, noentrain: 1, notrace: 1, failskillswap: 1, notransform: 1 },
         name: "Embody Aspect (Cornerstone)",
         rating: 3.5,
@@ -1233,14 +1222,12 @@ export const Abilities = {
     },
     embodyaspecthearthflame: {
         onStart(pokemon) {
-            if (pokemon.baseSpecies.name === 'Ogerpon-Hearthflame-Tera' && !this.effectState.embodied) {
-                this.effectState.embodied = true;
+            if (pokemon.baseSpecies.name === 'Ogerpon-Hearthflame-Tera' &&
+                this.effectState.embodied !== pokemon.previouslySwitchedIn) {
+                this.effectState.embodied = pokemon.previouslySwitchedIn;
                 this.boost({ atk: 1 }, pokemon);
             }
         },
-        onSwitchIn() {
-            delete this.effectState.embodied;
-        },
         flags: { failroleplay: 1, noreceiver: 1, noentrain: 1, notrace: 1, failskillswap: 1, notransform: 1 },
         name: "Embody Aspect (Hearthflame)",
         rating: 3.5,
@@ -1248,14 +1235,12 @@ export const Abilities = {
     },
     embodyaspectteal: {
         onStart(pokemon) {
-            if (pokemon.baseSpecies.name === 'Ogerpon-Teal-Tera' && !this.effectState.embodied) {
-                this.effectState.embodied = true;
+            if (pokemon.baseSpecies.name === 'Ogerpon-Teal-Tera' &&
+                this.effectState.embodied !== pokemon.previouslySwitchedIn) {
+                this.effectState.embodied = pokemon.previouslySwitchedIn;
                 this.boost({ spe: 1 }, pokemon);
             }
         },
-        onSwitchIn() {
-            delete this.effectState.embodied;
-        },
         flags: { failroleplay: 1, noreceiver: 1, noentrain: 1, notrace: 1, failskillswap: 1, notransform: 1 },
         name: "Embody Aspect (Teal)",
         rating: 3.5,
@@ -1263,14 +1248,12 @@ export const Abilities = {
     },
     embodyaspectwellspring: {
         onStart(pokemon) {
-            if (pokemon.baseSpecies.name === 'Ogerpon-Wellspring-Tera' && !this.effectState.embodied) {
-                this.effectState.embodied = true;
+            if (pokemon.baseSpecies.name === 'Ogerpon-Wellspring-Tera' &&
+                this.effectState.embodied !== pokemon.previouslySwitchedIn) {
+                this.effectState.embodied = pokemon.previouslySwitchedIn;
                 this.boost({ spd: 1 }, pokemon);
             }
         },
-        onSwitchIn() {
-            delete this.effectState.embodied;
-        },
         flags: { failroleplay: 1, noreceiver: 1, noentrain: 1, notrace: 1, failskillswap: 1, notransform: 1 },
         name: "Embody Aspect (Wellspring)",
         rating: 3.5,
@@ -1393,6 +1376,7 @@ export const Abilities = {
         num: 18,
     },
     flowergift: {
+        onSwitchInPriority: -2,
         onStart(pokemon) {
             this.singleEvent('WeatherChange', this.effect, this.effectState, pokemon);
         },
@@ -1488,6 +1472,7 @@ export const Abilities = {
         num: 218,
     },
     forecast: {
+        onSwitchInPriority: -2,
         onStart(pokemon) {
             this.singleEvent('WeatherChange', this.effect, this.effectState, pokemon);
         },
@@ -1913,6 +1898,7 @@ export const Abilities = {
         num: 118,
     },
     hospitality: {
+        onSwitchInPriority: -2,
         onStart(pokemon) {
             for (const ally of pokemon.adjacentAllies()) {
                 this.heal(ally.baseMaxhp / 4, ally, pokemon);
@@ -2010,6 +1996,7 @@ export const Abilities = {
         num: 115,
     },
     iceface: {
+        onSwitchInPriority: -2,
         onStart(pokemon) {
             if (this.field.isWeather(['hail', 'snow']) && pokemon.species.id === 'eiscuenoice') {
                 this.add('-activate', pokemon, 'ability: Ice Face');
@@ -2128,8 +2115,7 @@ export const Abilities = {
             if (pokemon.illusion) {
                 this.debug('illusion cleared');
                 pokemon.illusion = null;
-                const details = pokemon.species.name + (pokemon.level === 100 ? '' : ', L' + pokemon.level) +
-                    (pokemon.gender === '' ? '' : ', ' + pokemon.gender) + (pokemon.set.shiny ? ', shiny' : '');
+                const details = pokemon.getUpdatedDetails();
                 this.add('replace', pokemon, details);
                 this.add('-end', pokemon, 'Illusion');
                 if (this.ruleTable.has('illusionlevelmod')) {
@@ -2167,20 +2153,14 @@ export const Abilities = {
     },
     imposter: {
         onSwitchIn(pokemon) {
-            this.effectState.switchingIn = true;
-        },
-        onStart(pokemon) {
             // Imposter does not activate when Skill Swapped or when Neutralizing Gas leaves the field
-            if (!this.effectState.switchingIn)
-                return;
-            // copies across in doubles/triples
+            // Imposter copies across in doubles/triples
             // (also copies across in multibattle and diagonally in free-for-all,
             // but side.foe already takes care of those)
             const target = pokemon.side.foe.active[pokemon.side.foe.active.length - 1 - pokemon.position];
             if (target) {
                 pokemon.transformInto(target, this.dex.abilities.get('imposter'));
             }
-            this.effectState.switchingIn = false;
         },
         flags: { failroleplay: 1, noreceiver: 1, noentrain: 1, notrace: 1 },
         name: "Imposter",
@@ -2339,6 +2319,9 @@ export const Abilities = {
         num: 51,
     },
     klutz: {
+        // Klutz isn't technically active immediately in-game, but it activates early enough to beat all items
+        // we should keep an eye out in future gens for items that activate on switch-in before Unnerve
+        onSwitchInPriority: 1,
         // Item suppression implemented in Pokemon.ignoringItem() within sim/pokemon.js
         onStart(pokemon) {
             this.singleEvent('End', pokemon.getItem(), pokemon.itemState, pokemon);
@@ -2377,7 +2360,7 @@ export const Abilities = {
     },
     libero: {
         onPrepareHit(source, target, move) {
-            if (this.effectState.libero)
+            if (this.effectState.libero === source.previouslySwitchedIn)
                 return;
             if (move.hasBounced || move.flags['futuremove'] || move.sourceEffect === 'snatch' || move.callsMove)
                 return;
@@ -2385,13 +2368,10 @@ export const Abilities = {
             if (type && type !== '???' && source.getTypes().join() !== type) {
                 if (!source.setType(type))
                     return;
-                this.effectState.libero = true;
+                this.effectState.libero = source.previouslySwitchedIn;
                 this.add('-start', source, 'typechange', type, '[from] ability: Libero');
             }
         },
-        onSwitchIn() {
-            delete this.effectState.libero;
-        },
         flags: {},
         name: "Libero",
         rating: 4,
@@ -2642,6 +2622,7 @@ export const Abilities = {
         num: 196,
     },
     mimicry: {
+        onSwitchInPriority: -1,
         onStart(pokemon) {
             this.singleEvent('TerrainChange', this.effect, this.effectState, pokemon);
         },
@@ -2978,7 +2959,8 @@ export const Abilities = {
     },
     neutralizinggas: {
         // Ability suppression implemented in sim/pokemon.ts:Pokemon#ignoringAbility
-        onPreStart(pokemon) {
+        onSwitchInPriority: 2,
+        onSwitchIn(pokemon) {
             this.add('-ability', pokemon, 'Neutralizing Gas');
             pokemon.abilityState.ending = false;
             const strongWeathers = ['desolateland', 'primordialsea', 'deltastream'];
@@ -3119,17 +3101,38 @@ export const Abilities = {
         onFoeAfterBoost(boost, target, source, effect) {
             if (effect?.name === 'Opportunist' || effect?.name === 'Mirror Herb')
                 return;
-            const pokemon = this.effectState.target;
-            const positiveBoosts = {};
+            if (!this.effectState.boosts)
+                this.effectState.boosts = {};
+            const boostPlus = this.effectState.boosts;
             let i;
             for (i in boost) {
                 if (boost[i] > 0) {
-                    positiveBoosts[i] = boost[i];
+                    boostPlus[i] = (boostPlus[i] || 0) + boost[i];
                 }
             }
-            if (Object.keys(positiveBoosts).length < 1)
+        },
+        onAnySwitchInPriority: -3,
+        onAnySwitchIn() {
+            if (!this.effectState.boosts)
                 return;
-            this.boost(positiveBoosts, pokemon);
+            this.boost(this.effectState.boosts, this.effectState.target);
+            delete this.effectState.boosts;
+        },
+        onAnyAfterMove() {
+            if (!this.effectState.boosts)
+                return;
+            this.boost(this.effectState.boosts, this.effectState.target);
+            delete this.effectState.boosts;
+        },
+        onResidualOrder: 29,
+        onResidual(pokemon) {
+            if (!this.effectState.boosts)
+                return;
+            this.boost(this.effectState.boosts, this.effectState.target);
+            delete this.effectState.boosts;
+        },
+        onEnd() {
+            delete this.effectState.boosts;
         },
         flags: {},
         name: "Opportunist",
@@ -3256,11 +3259,8 @@ export const Abilities = {
                 pokemon.cureStatus();
             }
         },
-        onAllySwitchIn(pokemon) {
-            if (['psn', 'tox'].includes(pokemon.status)) {
-                this.add('-activate', this.effectState.target, 'ability: Pastel Veil');
-                pokemon.cureStatus();
-            }
+        onAnySwitchIn() {
+            this.effect.onStart.call(this, this.effectState.target);
         },
         onSetStatus(status, target, source, effect) {
             if (!['psn', 'tox'].includes(status.id))
@@ -3567,7 +3567,7 @@ export const Abilities = {
     },
     protean: {
         onPrepareHit(source, target, move) {
-            if (this.effectState.protean)
+            if (this.effectState.protean === source.previouslySwitchedIn)
                 return;
             if (move.hasBounced || move.flags['futuremove'] || move.sourceEffect === 'snatch' || move.callsMove)
                 return;
@@ -3575,19 +3575,17 @@ export const Abilities = {
             if (type && type !== '???' && source.getTypes().join() !== type) {
                 if (!source.setType(type))
                     return;
-                this.effectState.protean = true;
+                this.effectState.protean = source.previouslySwitchedIn;
                 this.add('-start', source, 'typechange', type, '[from] ability: Protean');
             }
         },
-        onSwitchIn(pokemon) {
-            delete this.effectState.protean;
-        },
         flags: {},
         name: "Protean",
         rating: 4,
         num: 168,
     },
     protosynthesis: {
+        onSwitchInPriority: -2,
         onStart(pokemon) {
             this.singleEvent('WeatherChange', this.effect, this.effectState, pokemon);
         },
@@ -3596,8 +3594,7 @@ export const Abilities = {
             if (this.field.isWeather('sunnyday')) {
                 pokemon.addVolatile('protosynthesis');
             }
-            else if (!pokemon.volatiles['protosynthesis']?.fromBooster && this.field.weather !== 'sunnyday') {
-                // Protosynthesis will not deactivite if Sun is suppressed, hence the direct ID check (isWeather respects supression)
+            else if (!pokemon.volatiles['protosynthesis']?.fromBooster && !this.field.isWeather('sunnyday')) {
                 pokemon.removeVolatile('protosynthesis');
             }
         },
@@ -3732,6 +3729,7 @@ export const Abilities = {
         num: 272,
     },
     quarkdrive: {
+        onSwitchInPriority: -2,
         onStart(pokemon) {
             this.singleEvent('TerrainChange', this.effect, this.effectState, pokemon);
         },
@@ -4147,6 +4145,7 @@ export const Abilities = {
         num: 157,
     },
     schooling: {
+        onSwitchInPriority: -1,
         onStart(pokemon) {
             if (pokemon.baseSpecies.baseSpecies !== 'Wishiwashi' || pokemon.level < 20 || pokemon.transformed)
                 return;
@@ -4350,6 +4349,7 @@ export const Abilities = {
         num: 19,
     },
     shieldsdown: {
+        onSwitchInPriority: -1,
         onStart(pokemon) {
             if (pokemon.baseSpecies.baseSpecies !== 'Minior' || pokemon.transformed)
                 return;
@@ -5092,21 +5092,7 @@ export const Abilities = {
         num: 309,
     },
     terashell: {
-        onEffectiveness(typeMod, target, type, move) {
-            if (!target || target.species.name !== 'Terapagos-Terastal')
-                return;
-            if (this.effectState.resisted)
-                return -1; // all hits of multi-hit move should be not very effective
-            if (move.category === 'Status' || move.id === 'struggle')
-                return;
-            if (!target.runImmunity(move.type))
-                return; // immunity has priority
-            if (target.hp < target.maxhp)
-                return;
-            this.add('-activate', target, 'ability: Tera Shell');
-            this.effectState.resisted = true;
-            return -1;
-        },
+        // effectiveness implemented in sim/pokemon.ts:Pokemon#runEffectiveness
         onAnyAfterMove() {
             this.effectState.resisted = false;
         },
@@ -5116,12 +5102,14 @@ export const Abilities = {
         num: 308,
     },
     terashift: {
-        onPreStart(pokemon) {
+        onSwitchInPriority: 2,
+        onSwitchIn(pokemon) {
             if (pokemon.baseSpecies.baseSpecies !== 'Terapagos')
                 return;
             if (pokemon.species.forme !== 'Terastal') {
                 this.add('-activate', pokemon, 'ability: Tera Shift');
                 pokemon.formeChange('Terapagos-Terastal', this.effect, true);
+                pokemon.regressionForme = false;
                 pokemon.baseMaxhp = Math.floor(Math.floor(2 * pokemon.species.baseStats['hp'] + pokemon.set.ivs['hp'] + Math.floor(pokemon.set.evs['hp'] / 4) + 100) * pokemon.level / 100 + 10);
                 const newMaxHP = pokemon.baseMaxhp;
                 pokemon.hp = newMaxHP - (pokemon.maxhp - pokemon.hp);
@@ -5277,19 +5265,23 @@ export const Abilities = {
     },
     trace: {
         onStart(pokemon) {
+            this.effectState.seek = true;
             // n.b. only affects Hackmons
             // interaction with No Ability is complicated: https://www.smogon.com/forums/threads/pokemon-sun-moon-battle-mechanics-research.3586701/page-76#post-7790209
             if (pokemon.adjacentFoes().some(foeActive => foeActive.ability === 'noability')) {
-                this.effectState.gaveUp = true;
+                this.effectState.seek = false;
             }
             // interaction with Ability Shield is similar to No Ability
             if (pokemon.hasItem('Ability Shield')) {
                 this.add('-block', pokemon, 'item: Ability Shield');
-                this.effectState.gaveUp = true;
+                this.effectState.seek = false;
+            }
+            if (this.effectState.seek) {
+                this.singleEvent('Update', this.effect, this.effectState, pokemon);
             }
         },
         onUpdate(pokemon) {
-            if (!pokemon.isStarted || this.effectState.gaveUp)
+            if (!this.effectState.seek)
                 return;
             const possibleTargets = pokemon.adjacentFoes().filter(target => !target.getAbility().flags['notrace'] && target.ability !== 'noability');
             if (!possibleTargets.length)
@@ -5415,10 +5407,7 @@ export const Abilities = {
         num: 84,
     },
     unnerve: {
-        onPreStart(pokemon) {
-            this.add('-ability', pokemon, 'Unnerve');
-            this.effectState.unnerved = true;
-        },
+        onSwitchInPriority: 1,
         onStart(pokemon) {
             if (this.effectState.unnerved)
                 return;
@@ -5825,15 +5814,10 @@ export const Abilities = {
                 return;
             if (pokemon.species.forme !== 'Hero') {
                 pokemon.formeChange('Palafin-Hero', this.effect, true);
+                pokemon.regressionForme = false;
             }
         },
-        onSwitchIn() {
-            this.effectState.switchingIn = true;
-        },
-        onStart(pokemon) {
-            if (!this.effectState.switchingIn)
-                return;
-            this.effectState.switchingIn = false;
+        onSwitchIn(pokemon) {
             if (pokemon.baseSpecies.baseSpecies !== 'Palafin')
                 return;
             if (!this.effectState.heroMessageDisplayed && pokemon.species.forme === 'Hero') {