@pkmn/engine 0.1.0-dev.b01cb48c → 0.1.0-dev.b3197aa3

package/src/lib/gen1/mechanics.zig

@@ -1,39 +1,29 @@
-const std = @import("std");
-
-const pkmn = @import("../pkmn.zig");
+const DEBUG = @import("../common/debug.zig").print;
 
+const builtin = @import("builtin");
+const chance = @import("chance.zig");
 const common = @import("../common/data.zig");
-const DEBUG = @import("../common/debug.zig").print;
-const optional = @import("../common/optional.zig");
+const data = @import("data.zig");
+const pkmn = @import("../pkmn.zig");
 const protocol = @import("../common/protocol.zig");
 const rng = @import("../common/rng.zig");
-
-const data = @import("data.zig");
-const chance = @import("chance.zig");
+const std = @import("std");
 
 const assert = std.debug.assert;
-
-const expectEqual = std.testing.expectEqual;
-
-const showdown = pkmn.options.showdown;
-
-const Choice = common.Choice;
-const ID = common.ID;
-const Player = common.Player;
-const Result = common.Result;
-
 const Boost = protocol.Boost;
+const Choice = common.Choice;
 const Damage = protocol.Damage;
+const Effectiveness = data.Effectiveness;
+const expectEqual = std.testing.expectEqual;
 const Fail = protocol.Fail;
-const Heal = protocol.Heal;
-
 const Gen12 = rng.Gen12;
-
-const ActivePokemon = data.ActivePokemon;
-const Effectiveness = data.Effectiveness;
+const Heal = protocol.Heal;
+const ID = common.ID;
 const Move = data.Move;
 const MoveSlot = data.MoveSlot;
-const Pokemon = data.Pokemon;
+const Player = common.Player;
+const Result = common.Result;
+const showdown = pkmn.options.showdown;
 const Side = data.Side;
 const Species = data.Species;
 const Stats = data.Stats;
@@ -176,7 +166,10 @@ fn selectMove(
             if (foe_choice.type == .Switch) {
                 const last = side.active.move(battle.lastMove(player).index);
                 if (last.id == .Metronome) side.last_selected_move = last.id;
-                if (last.id == .MirrorMove) return Result.Error;
+                if (last.id == .MirrorMove) {
+                    if (!pkmn.options.mod) return Result.Error;
+                    side.last_selected_move = last.id;
+                }
             }
         }
         return null;
@@ -255,6 +248,7 @@ fn switchIn(battle: anytype, player: Player, slot: u8, initial: bool, options: a
     active.moves = incoming.moves;
 
     statusModify(incoming.status, &active.stats);
+    options.chance.switched(player, slot);
 
     foe.active.volatiles.Binding = false;
 
@@ -354,7 +348,7 @@ fn doTurn(
         if (try checkFaint(battle, player, false, options)) |r| return r;
     } else if (foe_choice.type == .Pass) return null;
 
-    options.chance.clearPending();
+    if (!showdown) options.chance.clearPending();
 
     residual = true;
     replace = battle.side(foe_player).stored().hp == 0;
@@ -426,7 +420,7 @@ fn executeMove(
         mslot = @intCast(battle.lastMove(player).index);
         const stored = side.stored();
         // GLITCH: Struggle bypass PP underflow via Hyper Beam / Trapping-switch auto selection
-        auto = isForced(&side.active) or
+        auto = pkmn.options.mod or isForced(&side.active) or
             side.active.volatiles.Binding or side.active.volatiles.Bide or
             side.last_selected_move == .HyperBeam or
             Status.is(stored.status, .FRZ) or Status.is(stored.status, .SLP);
@@ -459,6 +453,25 @@ fn executeMove(
         .err => return @as(?Result, Result.Error),
     }
 
+    // Pokémon Showdown incorrectly implements PP deduction when handling the Hyper Beam automatic
+    // selection glitch - if the move was proced due to Metronome / Mirror Move it either subtracts
+    // from the Hyper Beam slot if present or skips PP deduction entirely...
+    if (showdown and !skip_pp and side.last_selected_move == .HyperBeam and
+        side.last_selected_move != side.active.move(mslot).id)
+    {
+        assert(mslot == 1);
+        const has_beam = has_beam: {
+            for (side.active.moves, 0..) |m, i| {
+                if (m.id == .HyperBeam) {
+                    mslot = @intCast(i + 1);
+                    break :has_beam true;
+                }
+            }
+            break :has_beam false;
+        };
+        if (!has_beam) skip_pp = true;
+    }
+
     const can = skip_can or
         try canMove(battle, player, mslot, auto, skip_pp, .None, residual, options);
     if (!can) return null;
@@ -485,6 +498,7 @@ fn beforeMove(
 
     if (Status.is(stored.status, .SLP)) {
         const before = stored.status;
+        const slf = Status.is(stored.status, .EXT);
         // Even if the EXT bit is set this will still correctly modify the sleep duration
         if (options.calc.overridden(player, .sleep)) |obs| switch (obs) {
             .started, .ended => stored.status = 0,
@@ -497,7 +511,9 @@ fn beforeMove(
         }
 
         const duration = Status.duration(stored.status);
-        options.chance.observe(.sleep, player, observation(duration));
+        try options.chance.sleep(player, if (slf)
+            .None
+        else if (duration == 0) .ended else .continuing);
 
         if (duration == 0) {
             try log.curestatus(.{ ident, before, .Message });
@@ -537,7 +553,10 @@ fn beforeMove(
     if (volatiles.disable_duration > 0) {
         volatiles.disable_duration =
             decrement(.disable, player, options, volatiles.disable_duration);
-        options.chance.observe(.disable, player, observation(volatiles.disable_duration));
+        try options.chance.disable(
+            player,
+            if (volatiles.disable_duration == 0) .ended else .continuing,
+        );
 
         if (volatiles.disable_duration == 0) {
             volatiles.disable_move = 0;
@@ -550,25 +569,24 @@ fn beforeMove(
     // This can only happen if a Pokémon started the battle frozen/sleeping and was thawed/woken
     // before the side had a selected a move - we simply need to assume this leads to a desync
     if (side.last_selected_move == .None) {
-        assert(!showdown);
+        assert(!pkmn.options.mod);
         return .err;
     }
 
     if (volatiles.Confusion) {
         assert(volatiles.confusion > 0);
         if (options.calc.overridden(player, .confusion)) |obs| switch (obs) {
-            .started => volatiles.confusion -= 1,
+            .started, .ended => volatiles.confusion = 0,
             .continuing => if (volatiles.confusion > 1) {
                 volatiles.confusion -= 1;
             },
-            .ended => volatiles.confusion = 0,
             .overwritten => {},
             else => unreachable,
         } else {
             volatiles.confusion -= 1;
         }
 
-        options.chance.observe(.confusion, player, observation(volatiles.confusion));
+        try options.chance.confusion(player, if (volatiles.confusion == 0) .ended else .continuing);
 
         if (volatiles.confusion == 0) {
             volatiles.Confusion = false;
@@ -587,8 +605,7 @@ fn beforeMove(
                 volatiles.Binding = false;
                 volatiles.Invulnerable = false;
 
-                options.chance.observe(.bide, player, .None);
-                options.chance.observe(.thrashing, player, .None);
+                options.chance.observe(.attacking, player, .None);
                 options.chance.observe(.binding, player, .None);
                 {
                     // This feels (and is) disgusting but the cartridge literally just overwrites
@@ -597,19 +614,14 @@ fn beforeMove(
                     const def = foe.active.stats.def;
                     foe.active.stats.def = active.stats.def;
                     defer foe.active.stats.def = def;
-                    if (!calcDamage(battle, player, player.foe(), null, false)) return .err;
+                    if (!calcDamage(battle, player, player.foe(), null, false, options)) {
+                        return .err;
+                    }
                 }
-                // Pokémon Showdown incorrectly changes the "target" of the confusion self-hit based
-                // on the targeting behavior of the confused Pokémon's selected move which results
-                // in the wrong behavior with respect to the Substitute + Confusion glitch
-                const target = if (showdown and Move.get(side.last_selected_move).target == .Self)
-                    player
-                else
-                    player.foe();
 
                 const uncapped = battle.last_damage;
                 // Skipping adjustDamage / randomizeDamage / checkHit
-                _ = try applyDamage(battle, player, target, .Confusion, options);
+                _ = try applyDamage(battle, player, player.foe(), .Confusion, options);
                 // Pokémon Showdown thinks that confusion damage is uncapped ¯\_(ツ)_/¯
                 if (showdown) battle.last_damage = uncapped;
 
@@ -627,8 +639,7 @@ fn beforeMove(
         volatiles.Charging = false;
         volatiles.Binding = false;
 
-        options.chance.observe(.bide, player, .None);
-        options.chance.observe(.thrashing, player, .None);
+        options.chance.observe(.attacking, player, .None);
         options.chance.observe(.binding, player, .None);
 
         // GLITCH: Invulnerable is not cleared, resulting in permanent Fly/Dig invulnerability
@@ -648,8 +659,8 @@ fn beforeMove(
             volatiles.state +%= battle.last_damage;
         }
 
-        volatiles.attacks = decrement(.bide, player, options, volatiles.attacks);
-        options.chance.observe(.bide, player, observation(volatiles.attacks));
+        volatiles.attacks = decrement(.attacking, player, options, volatiles.attacks);
+        try options.chance.attacking(player, if (volatiles.attacks == 0) .ended else .continuing);
 
         if (volatiles.attacks != 0) {
             try log.activate(.{ ident, .Bide });
@@ -685,8 +696,8 @@ fn beforeMove(
     if (volatiles.Thrashing) {
         try log.move(.{ ident, side.last_selected_move, battle.active(player.foe()) });
 
-        volatiles.attacks = decrement(.thrashing, player, options, volatiles.attacks);
-        options.chance.observe(.thrashing, player, observation(volatiles.attacks));
+        volatiles.attacks = decrement(.attacking, player, options, volatiles.attacks);
+        try options.chance.attacking(player, if (volatiles.attacks == 0) .ended else .continuing);
 
         if (volatiles.attacks == 0) {
             const overwritten = volatiles.Confusion;
@@ -700,11 +711,11 @@ fn beforeMove(
             // can be expected to recognize this pattern and pass the information only to the
             // correct player)
             try log.start(.{ battle.active(player), .ConfusionSilent });
-            options.chance.observe(
-                .confusion,
-                player,
-                if (overwritten) .overwritten else .started,
-            );
+            options.chance.observe(.confusion, player, if (overwritten)
+                if (pkmn.options.overwrite) .overwritten else .continuing
+            else
+                .started);
+            if (!overwritten) options.calc.confusion(player);
         }
 
         // This shouldn't actually set last_used_move, but Pokémon Showdown sets last
@@ -716,7 +727,7 @@ fn beforeMove(
 
     if (volatiles.Binding) {
         volatiles.attacks = decrement(.binding, player, options, volatiles.attacks);
-        options.chance.observe(.binding, player, observation(volatiles.attacks));
+        try options.chance.binding(player, if (volatiles.attacks == 0) .ended else .continuing);
 
         try log.move(.{ ident, side.last_selected_move, battle.active(player.foe()) });
         if (showdown or battle.last_damage != 0) {
@@ -770,9 +781,14 @@ fn canMove(
 
     if (move.effect == .Thrashing) {
         Effects.thrashing(battle, player, options);
-    } else if (!showdown and move.effect == .Binding) {
-        // Pokémon Showdown handles this after hit/miss checks and damage calculation
-        try Effects.binding(battle, player, false, options);
+    } else if (move.effect == .Binding) {
+        // Pokémon Showdown handles this after hit/miss checks and damage calculation, though clears
+        // Recharging in onTryMove (required for the Hyper Beam automatic selection glitch)
+        if (showdown) {
+            battle.foe(player).active.volatiles.Recharging = false;
+        } else {
+            try Effects.binding(battle, player, false, options);
+        }
     }
 
     return true;
@@ -809,7 +825,7 @@ fn decrementPP(side: *Side, mslot: u4, auto: bool) void {
     assert(active.move(mslot).pp == side.stored().move(mslot).pp);
 }
 
-fn incrementPP(side: *Side, mslot: u4) void {
+fn incrementPP(side: *Side, player: Player, mslot: u4, options: anytype) void {
     var active = &side.active;
     const volatiles = &active.volatiles;
 
@@ -817,8 +833,11 @@ fn incrementPP(side: *Side, mslot: u4) void {
     // GLITCH: No check for Transform means an empty/incorrect stored slot can get incremented
     if (showdown and volatiles.Transform) return;
 
+    const n = options.calc.overridden(player, .pp) orelse 1;
+    if (volatiles.Transform and !options.chance.pp(player, n)) return;
+
     assert(mslot > 0 and mslot <= 4);
-    side.stored().moves[mslot - 1].pp = @as(u6, @intCast(side.stored().moves[mslot - 1].pp)) +% 1;
+    side.stored().moves[mslot - 1].pp = @as(u6, @intCast(side.stored().moves[mslot - 1].pp)) +% n;
 }
 
 // Pokémon Showdown does hit/multi/crit/damage instead of crit/damage/hit/multi
@@ -872,7 +891,7 @@ fn doMove(
 
     var late = showdown and move.effect != .Explode;
     const skip = status or immune;
-    if ((!showdown or (!skip or counter)) and !miss) blk: {
+    if ((!showdown or (!skip or counter)) and !miss) damage: {
         if (showdown and move.effect.isMulti()) {
             try Effects.multiHit(battle, player, move, options);
             hits = side.active.volatiles.attacks;
@@ -894,8 +913,9 @@ fn doMove(
                 ohko = if (!showdown) side.active.stats.spe >= foe.active.stats.spe else true;
                 // This can overflow after adjustDamage, but will still be sufficient to OHKO
                 battle.last_damage = if (ohko) 65535 else 0;
-                if (showdown) break :blk; // skip adjustDamage / randomizeDamage
-            } else if (!calcDamage(battle, player, player.foe(), move, crit)) {
+                if (showdown) break :damage; // skip adjustDamage / randomizeDamage
+            } else if (!calcDamage(battle, player, player.foe(), move, crit, options)) {
+                if (!showdown) try options.chance.commit(player, .err);
                 return @as(?Result, Result.Error);
             }
             if (battle.last_damage == 0) {
@@ -909,11 +929,12 @@ fn doMove(
         }
     }
 
+    var missed: bool = undefined;
     const zero = battle.last_damage == 0;
-    miss = if (showdown or skip)
-        miss
-    else
-        (!try moveHit(battle, player, move, &immune, &mist, options) or zero);
+    if (!showdown and !skip) {
+        missed = !try moveHit(battle, player, move, &immune, &mist, options);
+        miss = missed or zero;
+    }
 
     assert(showdown or miss or battle.last_damage > 0 or skip);
     assert((!showdown and miss) or !(ohko and immune));
@@ -940,24 +961,32 @@ fn doMove(
             try log.immune(.{ foe_ident, .OHKO });
         } else if (immune and !invulnerable and (!showdown or move.effect != .Binding)) {
             try log.immune(.{ foe_ident, .None });
-            if (!showdown and move.effect == .Binding) {
-                // Rather obnoxiously, the cartridge sets the Binding volatile in canMove and then
-                // simply clears it later on if the move happens to miss in moveHit. However,
-                // moveHit can return true and we'll still end up in the outer miss handling block
-                // because attacking into an immune Pokemon does zero damage (considered missing)
-                assert(zero);
-                // Thus we still need to actually save the hit result (but not the crit roll). Using
-                // .miss for this commit would accomplish what we want, but is somewhat misleading
-                // as its entirely possible the move actually did hit (and the target is now
-                // trapped) so we use the .binding value instead which is effectively identical,
-                // just doesn't claim to know about the actual results of the hit roll)
-                try options.chance.commit(player, .binding);
+            if (!showdown) {
+                if (move.effect == .Binding) {
+                    // Rather obnoxiously, the cartridge sets the Binding volatile in canMove and
+                    // then simply clears it later on if the move happens to miss in moveHit.
+                    // However, moveHit can return true and we'll still end up in the outer miss
+                    // handling block because attacking into an immune Pokemon does zero damage
+                    // (considered missing)
+                    assert(zero);
+                    // Thus we still need to actually save the hit result (but not the crit roll).
+                    // Using .miss for this commit would accomplish what we want, but is somewhat
+                    // misleading as its entirely possible the move actually did hit (and the target
+                    // is now trapped) so we use the .binding value instead which is effectively
+                    // identical, just doesn't claim to know about the actual results of the hit
+                    // roll)
+                    try options.chance.commit(player, .binding);
+                } else {
+                    // The .glitch option allows for conditionally committing if we are in a
+                    // division-by-zero freeze alternative timeline scenario
+                    try options.chance.commit(player, .glitch);
+                }
             }
         } else if (mist) {
             if (!foe.active.volatiles.Substitute) try log.activate(.{ foe_ident, .Mist });
             try log.fail(.{ foe_ident, .None });
         } else {
-            if (!showdown and !zero) try options.chance.commit(player, .miss);
+            if (!showdown) try options.chance.commit(player, if (zero and !missed) .hit else .miss);
             try log.lastmiss(.{});
             try log.miss(.{battle.active(player)});
         }
@@ -1019,22 +1048,20 @@ fn doMove(
             try Effects.poison(battle, player, Move.get(.PoisonSting), options);
         }
         try log.hitcount(.{ battle.active(player.foe()), hit });
-    } else if (showdown) {
+    } else if (showdown and move.effect == .Binding) {
         // This should be handled much earlier but Pokémon Showdown does it here... ¯\_(ツ)_/¯
-        if (move.effect == .Binding) {
-            try Effects.binding(battle, player, rewrap, options);
-            if (immune) {
-                battle.last_damage = 0;
-                assert(foe.stored().hp > 0);
-                // Pokémon Showdown logs |-damage| here instead of |-immune| because logic...
-                if (sub) {
-                    try log.activate(.{ battle.active(player.foe()), .Substitute });
-                } else {
-                    try log.damage(.{ battle.active(player.foe()), foe.stored(), .None });
-                    try buildRage(battle, player.foe(), options);
-                }
-                return null;
+        try Effects.binding(battle, player, rewrap, options);
+        if (immune) {
+            battle.last_damage = 0;
+            assert(foe.stored().hp > 0);
+            // Pokémon Showdown logs |-damage| here instead of |-immune| because logic...
+            if (sub) {
+                try log.activate(.{ battle.active(player.foe()), .Substitute });
+            } else {
+                try log.damage(.{ battle.active(player.foe()), foe.stored(), .None });
+                try buildRage(battle, player.foe(), options);
             }
+            return null;
         }
     }
 
@@ -1094,6 +1121,7 @@ fn calcDamage(
     target_player: Player,
     m: ?Move.Data,
     crit: bool,
+    options: anytype,
 ) bool {
     // Confusion (indicated when m == null) just needs a 40 BP physical move
     const cfz = m == null;
@@ -1105,28 +1133,8 @@ fn calcDamage(
 
     const special = move.type.special();
 
-    // zig fmt: off
-    var atk: u32 =
-        if (crit)
-            if (special) side.stored().stats.spc
-            else side.stored().stats.atk
-        else
-            if (special) side.active.stats.spc
-            else side.active.stats.atk;
-    var def: u32 =
-        if (crit)
-            if (special) target.stored().stats.spc
-            else target.stored().stats.def
-        else
-            // GLITCH: not capped to MAX_STAT_VALUE, can be 999 * 2 = 1998
-            if (special)
-                target.active.stats.spc *
-                    @as(u2, if (target.active.volatiles.LightScreen) 2 else 1)
-            // Pokémon Showdown doesn't apply the opponent's Reflect to confusion's self-hit
-            else
-                target.active.stats.def *
-                    @as(u2, if ((!showdown or !cfz) and target.active.volatiles.Reflect) 2 else 1);
-    // zig fmt: on
+    var atk = attack(side, crit, special);
+    var def = defense(target, crit, special, cfz);
 
     // Pokémon Showdown erroneously skips this for confusion's self-hit damage, but thankfully we
     // will not overflow because the hit is only 40 BP and unboosted (the highest legal unboosted
@@ -1134,7 +1142,7 @@ fn calcDamage(
     if ((!showdown or !cfz) and (atk > 255 or def > 255)) {
         atk = @max((atk / 4) & 255, 1);
         // GLITCH: not adjusted to be a min of 1 on cartridge (can lead to division-by-zero freeze)
-        def = @max((def / 4) & 255, if (showdown) 1 else 0);
+        def = @max((def / 4) & 255, if (pkmn.options.mod) 1 else 0);
     }
 
     const lvl: u32 = side.stored().level * @as(u2, if (crit) 2 else 1);
@@ -1151,11 +1159,41 @@ fn calcDamage(
     d = @min(997, d);
     d += 2;
 
+    // Whether or not a critical hit occurred can change whether a division-by-zero freeze is
+    // encountered so we need to make sure that in the event of a miss we commit the status of the
+    // crit roll. The alternative to doing this extra work is to *always* commit the crit roll but
+    // that results in counter intuitive probabilities in the common case
+    if (pkmn.options.chance and !pkmn.options.mod and move.effect != .Explode) {
+        atk = attack(side, !crit, special);
+        def = defense(target, !crit, special, false);
+        if ((atk > 255 or def > 255) and (def / 4) & 255 == 0) options.chance.glitch();
+    }
+
     battle.last_damage = @intCast(d);
 
     return true;
 }
 
+fn attack(side: *Side, crit: bool, special: bool) u32 {
+    return if (crit)
+        if (special) side.stored().stats.spc else side.stored().stats.atk
+    else if (special) side.active.stats.spc else side.active.stats.atk;
+}
+
+fn defense(target: *Side, crit: bool, special: bool, cfz: bool) u32 {
+    return if (crit)
+        if (special) target.stored().stats.spc else target.stored().stats.def
+    else
+    // GLITCH: not capped to MAX_STAT_VALUE, can be 999 * 2 = 1998
+    if (special)
+        target.active.stats.spc *
+            @as(u2, if (target.active.volatiles.LightScreen) 2 else 1)
+    else
+        // Pokémon Showdown doesn't apply the opponent's Reflect to confusion's self-hit
+        target.active.stats.def *
+            @as(u2, if ((!showdown or !cfz) and target.active.volatiles.Reflect) 2 else 1);
+}
+
 fn adjustDamage(battle: anytype, player: Player) u16 {
     const side = battle.side(player);
     const foe = battle.foe(player);
@@ -1210,13 +1248,13 @@ fn specialDamage(battle: anytype, player: Player, move: Move.Data, options: anyt
         .Psywave => power: {
             const max: u8 = @intCast(@as(u16, side.stored().level) * 3 / 2);
             // GLITCH: Psywave infinite glitch loop
-            if (!showdown and max <= 1) return Result.Error;
+            if (!pkmn.options.mod and max <= 1) return Result.Error;
             break :power try Rolls.psywave(battle, player, max, options);
         },
         else => unreachable,
     };
 
-    if (battle.last_damage == 0) return if (showdown) null else Result.Error;
+    if (battle.last_damage == 0) return if (pkmn.options.mod) null else Result.Error;
 
     const sub = showdown and foe.active.volatiles.Substitute;
     _ = try applyDamage(battle, player.foe(), player.foe(), .None, options);
@@ -1253,12 +1291,16 @@ fn counterDamage(battle: anytype, player: Player, move: Move.Data, options: anyt
 
     if (!used or !selected) {
         // GLITCH: Counter desync (covered by Desync Clause Mod on Pokémon Showdown)
-        if (!showdown) return Result.Error;
+        if (!pkmn.options.mod) return Result.Error;
         try options.log.fail(.{ battle.active(player), .None });
         return null;
     }
 
-    battle.last_damage *|= 2;
+    // NOTE: llvm/llvm-project#58557
+    battle.last_damage = if (comptime builtin.target.cpu.arch.isWasm())
+        @max(battle.last_damage *% 2, std.math.maxInt(u16))
+    else
+        battle.last_damage *| 2;
 
     // Pokémon Showdown calls moveHit before Counter
     if (!showdown and !try checkHit(battle, player, move, options)) return null;
@@ -1290,7 +1332,7 @@ fn applyDamage(
             subbed.active.volatiles.Substitute = false;
             // battle.last_damage is not updated with the amount of HP the Substitute had
             try options.log.end(.{ battle.active(sub_player), .Substitute });
-            options.calc.capped(sub_player);
+            if (reason != .Confusion) options.calc.capped(sub_player);
             return true;
         } else {
             // Safe to truncate since less than subbed.volatiles.substitute which is a u8
@@ -1324,7 +1366,7 @@ fn mirrorMove(
         try options.log.fail(.{ battle.active(player), .None });
         return null;
     } else if (!showdown or foe.last_used_move != .Struggle) {
-        incrementPP(side, mslot);
+        incrementPP(side, player, mslot, options);
     }
 
     if (!try canMove(battle, player, mslot, auto, false, .MirrorMove, residual, options)) {
@@ -1345,7 +1387,7 @@ fn metronome(
     var side = battle.side(player);
 
     side.last_selected_move = try Rolls.metronome(battle, player, options);
-    incrementPP(side, mslot);
+    incrementPP(side, player, mslot, options);
 
     if (!try canMove(battle, player, mslot, auto, false, .Metronome, residual, options)) {
         return null;
@@ -1404,7 +1446,16 @@ fn moveHit(
             break :miss true;
         }
         if (!showdown) {
-            if (move.effect == .Swift) return true;
+            if (move.effect == .Swift) {
+                // If Swift could cause a division-by-zero freeze (which doesn't exist on Pokémon
+                // Showdown, hence why the block above doesn't include this code), we need the
+                // damage roll to be committed. However, the commit code will not save this roll if
+                // the glitch occurs and the move was not marked as having hit. To work around this
+                // we flag that the move hit (as Swift trivially does), but pass the probability of
+                // the hit as zero to ensure it doesn't actually get saved.
+                try options.chance.hit(player, true, 0);
+                return true;
+            }
             if (foe.active.volatiles.Invulnerable) break :miss true;
         }
 
@@ -1446,7 +1497,10 @@ fn moveHit(
 
     if (!miss) return true;
     if (!showdown or !foe.active.volatiles.Invulnerable) battle.last_damage = 0;
+
     side.active.volatiles.Binding = false;
+    options.chance.observe(.binding, player, .None);
+
     return false;
 }
 
@@ -1497,7 +1551,7 @@ fn faint(battle: anytype, player: Player, done: bool, cap: bool, options: anytyp
     assert(!foe_volatiles.MultiHit);
     if (foe_volatiles.Bide) {
         assert(!foe_volatiles.Thrashing and !foe_volatiles.Rage);
-        foe_volatiles.state = if (showdown) 0 else foe_volatiles.state & 255;
+        foe_volatiles.state = if (pkmn.options.mod) 0 else foe_volatiles.state & 255;
         if (foe_volatiles.state != 0) return Result.Error;
     }
 
@@ -1588,12 +1642,12 @@ fn endTurn(battle: anytype, options: anytype) @TypeOf(options.log).Error!Result
 
     battle.turn += 1;
 
-    if (showdown and pkmn.options.ebc and checkEBC(battle)) {
+    if (pkmn.options.mod and pkmn.options.ebc and checkEBC(battle)) {
         try options.log.tie(.{});
         return Result.Tie;
     }
 
-    if (showdown and battle.turn >= 1000) {
+    if (pkmn.options.mod and battle.turn >= 1000) {
         try options.log.tie(.{});
         return Result.Tie;
     } else if (battle.turn >= 65535) {
@@ -1773,7 +1827,7 @@ pub const Effects = struct {
 
         side.active.volatiles.state = 0;
         side.active.volatiles.attacks = Rolls.attackingDuration(battle, player, options);
-        options.chance.observe(.bide, player, .started);
+        options.chance.observe(.attacking, player, .started);
 
         try options.log.start(.{ battle.active(player), .Bide });
     }
@@ -1842,6 +1896,7 @@ pub const Effects = struct {
 
         foe.active.volatiles.confusion = Rolls.confusionDuration(battle, player, options);
         options.chance.observe(.confusion, player.foe(), .started);
+        options.calc.confusion(player.foe());
 
         try options.log.start(.{ battle.active(player.foe()), .Confusion });
     }
@@ -1887,12 +1942,11 @@ pub const Effects = struct {
 
         // Technically this is still considered simply a "miss" on the cartridge,
         // but diverging from Pokémon Showdown here would mostly just be pedantic
-        if (n == 0) {
+        if (n == 0 or (pkmn.options.mod and err)) {
             try options.log.fail(.{ foe_ident, .None });
             return null;
         } else if (err) {
             // GLITCH: Transform + Mirror Move / Metronome PP softlock
-            assert(!showdown);
             return Result.Error;
         }
 
@@ -1970,7 +2024,7 @@ pub const Effects = struct {
         if (foe.active.types.includes(move.type)) return;
         if (!try Rolls.secondaryChance(battle, player, true, options)) return;
         // Freeze Clause Mod
-        if (showdown) for (foe.pokemon) |p| if (Status.is(p.status, .FRZ)) return;
+        if (pkmn.options.mod) for (foe.pokemon) |p| if (Status.is(p.status, .FRZ)) return;
 
         foe_stored.status = Status.init(.FRZ);
         // GLITCH: Hyper Beam recharging status is not cleared
@@ -2311,7 +2365,7 @@ pub const Effects = struct {
         }
 
         // Sleep Clause Mod
-        if (showdown) {
+        if (pkmn.options.mod) {
             for (foe.pokemon) |p| {
                 if (Status.is(p.status, .SLP) and !Status.is(p.status, .EXT)) return;
             }
@@ -2378,7 +2432,7 @@ pub const Effects = struct {
         volatiles.Thrashing = true;
         volatiles.attacks = Rolls.attackingDuration(battle, player, options);
 
-        options.chance.observe(.thrashing, player, .started);
+        options.chance.observe(.attacking, player, .started);
     }
 
     fn transform(battle: anytype, player: Player, options: anytype) !void {
@@ -2417,7 +2471,7 @@ pub const Effects = struct {
         if (side.active.volatiles.Binding) return;
         side.active.volatiles.Binding = true;
         // GLITCH: Hyper Beam automatic selection glitch if Recharging gets cleared on miss
-        // (Pokémon Showdown unitentionally patches this glitch, preventing automatic selection)
+        // (Pokémon Showdown clears Recharging in onTryMove instead)
         if (!showdown) {
             foe.active.volatiles.Recharging = false;
         } else if (foe.stored().hp == 0) return if (!rewrap) battle.rng.advance(1);
@@ -2717,10 +2771,6 @@ fn decrement(
     } else n - 1;
 }
 
-fn observation(n: anytype) optional.Optional(chance.Confusion) {
-    return if (n == 0) .ended else .continuing;
-}
-
 pub const Rolls = struct {
     fn speedTie(battle: anytype, options: anytype) !bool {
         const p1 = if (options.calc.overridden(.P1, .speed_tie)) |player|
@@ -2918,9 +2968,10 @@ pub const Rolls = struct {
     }
 
     fn sleepDuration(battle: anytype, player: Player, options: anytype) u3 {
-        const duration: u3 = if (options.calc.overridden(player, .duration)) |val|
-            @intCast(val)
-        else if (@hasDecl(@TypeOf(battle.rng), "sleepDuration"))
+        const duration: u3 = (if (options.calc.overridden(player, .duration)) |val|
+            if (val >= 1 and val <= 7) @as(u3, @intCast(val)) else null
+        else
+            null) orelse if (@hasDecl(@TypeOf(battle.rng), "sleepDuration"))
             battle.rng.sleepDuration(player)
         else if (showdown)
             battle.rng.range(u3, 1, 8)
@@ -2937,9 +2988,10 @@ pub const Rolls = struct {
     }
 
     fn disableDuration(battle: anytype, player: Player, options: anytype) u4 {
-        const duration: u4 = if (options.calc.overridden(player, .duration)) |val|
-            val
-        else if (@hasDecl(@TypeOf(battle.rng), "disableDuration"))
+        const duration: u4 = (if (options.calc.overridden(player, .duration)) |val|
+            if (val >= 1 and val <= 8) val else null
+        else
+            null) orelse if (@hasDecl(@TypeOf(battle.rng), "disableDuration"))
             battle.rng.disableDuration(player)
         else if (showdown)
             battle.rng.range(u4, 1, 9)
@@ -2952,9 +3004,10 @@ pub const Rolls = struct {
     }
 
     fn confusionDuration(battle: anytype, player: Player, options: anytype) u3 {
-        const duration: u3 = if (options.calc.overridden(player, .duration)) |val|
-            @intCast(val)
-        else if (@hasDecl(@TypeOf(battle.rng), "confusionDuration"))
+        const duration: u3 = (if (options.calc.overridden(player, .duration)) |val|
+            if (val >= 2 and val <= 5) @as(u3, @intCast(val)) else null
+        else
+            null) orelse if (@hasDecl(@TypeOf(battle.rng), "confusionDuration"))
             battle.rng.confusionDuration(player)
         else if (showdown)
             battle.rng.range(u3, 2, 6)
@@ -2967,9 +3020,10 @@ pub const Rolls = struct {
     }
 
     fn attackingDuration(battle: anytype, player: Player, options: anytype) u3 {
-        const duration: u3 = if (options.calc.overridden(player, .duration)) |val|
-            @intCast(val)
-        else if (@hasDecl(@TypeOf(battle.rng), "attackingDuration"))
+        const duration: u3 = (if (options.calc.overridden(player, .duration)) |val|
+            if (val >= 2 and val <= 3) @as(u3, @intCast(val)) else null
+        else
+            null) orelse if (@hasDecl(@TypeOf(battle.rng), "attackingDuration"))
             battle.rng.attackingDuration(player)
         else if (showdown)
             battle.rng.range(u3, 2, 4)
@@ -2990,9 +3044,10 @@ pub const Rolls = struct {
         options: anytype,
     ) !u3 {
         const roll = if (effect == .Binding) .duration else .multi_hit;
-        const n: u3 = if (options.calc.overridden(player, roll)) |val|
-            @intCast(val)
-        else if (@hasDecl(@TypeOf(battle.rng), "distribution"))
+        const n: u3 = (if (options.calc.overridden(player, roll)) |val|
+            if (val >= 2 and val <= 5) @as(u3, @intCast(val)) else null
+        else
+            null) orelse if (@hasDecl(@TypeOf(battle.rng), "distribution"))
             battle.rng.distribution(player)
         else if (showdown)
             DISTRIBUTION[battle.rng.range(u3, 0, DISTRIBUTION.len)]
@@ -3018,15 +3073,13 @@ pub const Rolls = struct {
         options: anytype,
     ) !u4 {
         // TODO: consider throwing error instead of rerolling?
-        const overridden = if (options.calc.overridden(player, .move_slot)) |val|
+        const slot: u4 = (if (options.calc.overridden(player, .move_slot)) |val|
             if (moves[val - 1].id != .None and (check_pp == 0 or moves[val - 1].pp > 0))
                 val
             else
                 null
         else
-            null;
-
-        const slot: u4 = overridden orelse if (@hasDecl(@TypeOf(battle.rng), "moveSlot"))
+            null) orelse if (@hasDecl(@TypeOf(battle.rng), "moveSlot"))
             battle.rng.moveSlot(player, moves, check_pp)
         else slot: {
             if (showdown) {
@@ -3184,7 +3237,7 @@ pub fn choices(battle: anytype, player: Player, request: Choice.Type, out: []Cho
             // Struggle (Pokémon Showdown would use 'move 1' here)
             if (n == before) {
                 // GLITCH: Transform + Mirror Move / Metronome PP softlock
-                if (!showdown) {
+                if (!pkmn.options.mod) {
                     while (slot <= 4) : (slot += 1) {
                         if (active.moves[slot - 1].pp != 0) return n;
                     }