@pkmn/engine 0.1.0-dev.a93847b2 → 0.1.0-dev.ac652f4e

package/src/lib/gen2/mechanics.zig

@@ -1,55 +1,44 @@
-const std = @import("std");
-
-const pkmn = @import("../pkmn.zig");
-
-const common = @import("../common/data.zig");
 const DEBUG = @import("../common/debug.zig").print;
-const protocol = @import("../common/protocol.zig");
-const rng = @import("../common/rng.zig");
-const util = @import("../common/util.zig");
 
+const builtin = @import("builtin");
+const common = @import("../common/data.zig");
 const data = @import("data.zig");
 const generated = @import("generated.zig");
-
-const assert = std.debug.assert;
-
-const expectEqual = std.testing.expectEqual;
-const expectEqualSlices = std.testing.expectEqualSlices;
-const expectEqualStrings = std.testing.expectEqualStrings;
-
-const showdown = pkmn.options.showdown;
-
-const Choice = common.Choice;
-const ID = common.ID;
-const Player = common.Player;
-const Result = common.Result;
+const pkmn = @import("../pkmn.zig");
+const protocol = @import("../common/protocol.zig");
+const rng = @import("../common/rng.zig");
+const std = @import("std");
 
 const Activate = protocol.Activate;
+const ActivePokemon = data.ActivePokemon;
+const assert = std.debug.assert;
 const Boost = protocol.Boost;
-const Cant = protocol.Cant;
+const Boosts = data.Boosts;
+const Choice = common.Choice;
 const Damage = protocol.Damage;
+const Effectiveness = data.Effectiveness;
 const End = protocol.End;
-const Heal = protocol.Heal;
-const Start = protocol.Start;
-
+const expectEqual = std.testing.expectEqual;
+const expectEqualSlices = std.testing.expectEqualSlices;
+const expectEqualStrings = std.testing.expectEqualStrings;
+const Fail = protocol.Fail;
 const Gen12 = rng.Gen12;
-
-const PointerType = util.PointerType;
-
-const ActivePokemon = data.ActivePokemon;
-const Effectiveness = data.Effectiveness;
+const Heal = protocol.Heal;
+const ID = common.ID;
 const Item = data.Item;
 const Move = data.Move;
-const MoveSlot = data.MoveSlot;
-const Pokemon = data.Pokemon;
+const Player = common.Player;
+const Result = common.Result;
+const showdown = pkmn.options.showdown;
 const Side = data.Side;
-const Species = data.Species;
+const Start = protocol.Start;
 const Stats = data.Stats;
 const Status = data.Status;
 const TriAttack = data.TriAttack;
 const Type = data.Type;
 const Types = data.Types;
 const Volatiles = data.Volatiles;
+const Weather = data.Weather;
 
 // zig fmt: off
 const STAT_BOOSTS = &[_][2]u8{
@@ -95,12 +84,16 @@ const CRITICAL_HITS = &[_]u8{
 
 const MAX_STAT_VALUE = 999;
 
+const STATS = [_][]const u8{ "atk", "def", "spe", "spa", "spd" };
+
 pub const State = struct {
     damage: u16 = 0, // wCurDamage
     effectiveness: u16 = Effectiveness.neutral, // wTypeModifier
     bp: u8, // wPlayerMoveStructPower
+    type: Type, // BATTLE_VARS_MOVE_TYPE
     accuracy: u8, // wEnemyMoveStruct + MOVE_ACC
     move: Move, // wCurPlayerMove
+    hit: u3 = 0,
     from: Move = .None,
     mslot: u4, // wCurMoveNum
     first: bool, // wEnemyGoesFirst
@@ -110,10 +103,10 @@ pub const State = struct {
     proc: bool = true, // wEffectFailed
 
     comptime {
-        assert(@sizeOf(State) == 14);
+        assert(@sizeOf(State) == 16);
     }
 
-    pub inline fn immune(self: *State) bool {
+    pub fn immune(self: *State) bool {
         return self.effectiveness == 0;
     }
 };
@@ -135,11 +128,11 @@ fn start(battle: anytype, options: anytype) !Result {
     const p1 = battle.side(.P1);
     const p2 = battle.side(.P2);
 
-    var p1_slot = findFirstAlive(p1);
+    const p1_slot = findFirstAlive(p1);
     assert(!showdown or p1_slot == 1);
     if (p1_slot == 0) return if (findFirstAlive(p2) == 0) Result.Tie else Result.Lose;
 
-    var p2_slot = findFirstAlive(p2);
+    const p2_slot = findFirstAlive(p2);
     assert(!showdown or p2_slot == 1);
     if (p2_slot == 0) return Result.Win;
 
@@ -247,15 +240,14 @@ fn switchIn(battle: anytype, player: Player, slot: u8, kind: SwitchIn, options:
     statusModify(incoming.status, &active.stats);
 
     if (kind == .Drag) {
-        try options.log.drag(battle.active(player), incoming);
+        try options.log.drag(.{ battle.active(player), incoming });
     } else {
-        try options.log.switched(battle.active(player), incoming);
+        try options.log.switched(.{ battle.active(player), incoming });
     }
-    options.chance.switched(player, side.pokemon[0].position, out);
 
     if (side.conditions.Spikes and !active.types.includes(.Flying)) {
         incoming.hp -|= @max(incoming.stats.hp / 8, 1);
-        try options.log.damage(battle.active(player), incoming, .Spikes);
+        try options.log.damage(.{ battle.active(player), incoming, .Spikes });
     }
 }
 
@@ -269,7 +261,13 @@ fn turnOrder(battle: anytype, c1: Choice, c2: Choice, options: anytype) !Player
     // TODO: add to pending and only commit roll on Pokémon Showdown if roll is used
     const qkc = showdown and try Rolls.quickClaw(battle, .P1, options);
 
-    if ((c1.type == .Switch) != (c2.type == .Switch)) return if (c1.type == .Switch) .P1 else .P2;
+    if ((c1.type == .Switch) != (c2.type == .Switch)) {
+        const m1 = .Pound; // TODO battle.side(.P1).last_selected_move;
+        const m2 = .Pound; // TODO battle.side(.P2).last_selected_move;
+        return if (c1.type == .Switch)
+            if (m1 == .Pursuit) .P2 else .P1
+        else if (m2 == .Pursuit) .P1 else .P2;
+    }
 
     // https://www.smogon.com/forums/threads/adv-switch-priority.3622189/
     // > In Gen 1 it's irrelevant [which player switches first] because switches happen instantly on
@@ -392,14 +390,22 @@ fn executeMove(
 
     assert(choice.type == .Move);
     var mslot: u4 = @intCast(choice.data);
+    _ = &mslot;
     var move = Move.Pound; // TODO
+    _ = &move;
 
     if (!try beforeMove(battle, player, move, options)) return null;
 
     // FIXME: need damage from doTurn
     const m = Move.get(move);
-    var state: State =
-        .{ .move = move, .mslot = mslot, .first = first, .accuracy = m.accuracy, .bp = m.bp };
+    var state: State = .{
+        .move = move,
+        .mslot = mslot,
+        .first = first,
+        .accuracy = m.accuracy,
+        .bp = m.bp,
+        .type = m.type,
+    };
     try generated.runMove(battle, player, &state, options);
     return null;
 }
@@ -416,31 +422,22 @@ fn beforeMove(battle: anytype, player: Player, move: Move, options: anytype) !bo
     if (volatiles.Recharging) {
         volatiles.Recharging = false;
         resetCant(volatiles);
-        try log.cant(ident, .Recharge);
+        try log.cant(.{ ident, .Recharge });
         return false;
     }
 
     if (Status.is(stored.status, .SLP)) slp: {
         const before = stored.status;
         // Even if the EXT bit is set this will still correctly modify the sleep duration
-        // if (options.calc.modify(player, .sleep)) |extend| {
-        //     if (!extend) stored.status = 0;
-        // } else {
         stored.status -= 1;
-        // }
 
-        const duration = Status.duration(stored.status);
-        if (!Status.is(stored.status, .EXT)) {
-            try options.chance.sleep(player, duration);
-        }
-
-        if (duration == 0) {
-            try log.curestatus(ident, before, .Message);
+        if (Status.duration(stored.status) == 0) {
+            try log.curestatus(.{ ident, before, .Message });
             stored.status = 0; // clears EXT if present
             resetCant(volatiles);
             volatiles.Nightmare = false;
         } else {
-            try log.cant(ident, .Sleep);
+            try log.cant(.{ ident, .Sleep });
             if (move == .Snore or move == .SleepTalk) break :slp;
             resetCant(volatiles);
             return false;
@@ -449,7 +446,7 @@ fn beforeMove(battle: anytype, player: Player, move: Move, options: anytype) !bo
 
     if (Status.is(stored.status, .FRZ) and !(move == .FlameWheel or move == .SacredFire)) {
         resetCant(volatiles);
-        try log.cant(ident, .Freeze);
+        try log.cant(.{ ident, .Freeze });
         return false;
     }
 
@@ -459,39 +456,28 @@ fn beforeMove(battle: anytype, player: Player, move: Move, options: anytype) !bo
         // if (!showdown) volatiles.Flinch = false;
         volatiles.Flinch = false;
         resetCant(volatiles);
-        try log.cant(ident, .Flinch);
+        try log.cant(.{ ident, .Flinch });
         return false;
     }
 
     if (volatiles.disable.duration > 0) {
-        // if (options.calc.modify(player, .disable)) |extend| {
-        //     if (!extend) volatiles.disable.duration = 0;
-        // } else {
         volatiles.disable.duration -= 1;
-        // }
-        try options.chance.disable(player, volatiles.disable.duration);
 
         if (volatiles.disable.duration == 0) {
             volatiles.disable.move = 0;
-            try log.end(ident, .Disable);
+            try log.end(.{ ident, .Disable });
         }
     }
 
     if (volatiles.Confusion) {
         assert(volatiles.confusion > 0);
-
-        // if (options.calc.modify(player, .confusion)) |extend| {
-        //     if (!extend) volatiles.confusion = 0;
-        // } else {
         volatiles.confusion -= 1;
-        // }
-        try options.chance.confusion(player, volatiles.confusion);
 
         if (volatiles.confusion == 0) {
             volatiles.Confusion = false;
-            try log.end(ident, .Confusion);
+            try log.end(.{ ident, .Confusion });
         } else {
-            try log.activate(ident, .Confusion);
+            try log.activate(.{ ident, .Confusion });
 
             if (try Rolls.confused(battle, player, options)) {
                 volatiles.BeatUp = false;
@@ -506,11 +492,11 @@ fn beforeMove(battle: anytype, player: Player, move: Move, options: anytype) !bo
     }
 
     if (volatiles.Attract) {
-        try log.activate(ident, .Attract);
+        try log.activate(.{ ident, .Attract });
 
         if (try Rolls.attract(battle, player, options)) {
             resetCant(volatiles);
-            try log.cant(ident, .Attract);
+            try log.cant(.{ ident, .Attract });
             return false;
         }
     }
@@ -521,14 +507,14 @@ fn beforeMove(battle: anytype, player: Player, move: Move, options: anytype) !bo
         if (m != .None and m == move) {
             side.active.volatiles.Charging = false;
             resetCant(volatiles);
-            try options.log.disabled(ident, move);
+            try options.log.cant(.{ ident, .Disable, move });
             return false;
         }
     }
 
     if (Status.is(stored.status, .PAR) and try Rolls.paralyzed(battle, player, options)) {
         resetCant(volatiles);
-        try log.cant(ident, .Paralysis);
+        try log.cant(.{ ident, .Paralysis });
         return false;
     }
 
@@ -548,11 +534,11 @@ fn resetCant(volatiles: *align(8) Volatiles) void {
 
 pub fn canMove(battle: anytype, player: Player, state: *State, options: anytype) !bool {
     var side = battle.side(player);
-    var volatiles = &side.active.volatiles;
+    const volatiles = &side.active.volatiles;
 
     // FIXME: pass in target to avoid lookup?
     const target = if (Move.get(state.move).target == .Self) player else player.foe();
-    try options.log.moveFrom(battle.active(player), state.move, battle.active(target), state.from);
+    try options.log.move(.{ battle.active(player), state.move, battle.active(target), state.from });
 
     const charging = false; // TODO charging uses doUse
     const skip_pp = charging or state.move == .Struggle or
@@ -631,7 +617,7 @@ pub fn afterMove(
 
 pub fn checkCriticalHit(battle: anytype, player: Player, state: *State, options: anytype) !void {
     const move = Move.get(state.move);
-    if (move.bp == 0) return;
+    if (state.bp == 0) return;
 
     const side = battle.side(player);
     const pokemon = side.stored();
@@ -646,7 +632,7 @@ pub fn checkCriticalHit(battle: anytype, player: Player, state: *State, options:
     }
     assert(stage <= 4);
 
-    state.crit = try Rolls.criticalHit(battle, player, CRITICAL_HITS[stage], options);
+    state.crit = try Rolls.criticalHit(battle, player, state.hit, CRITICAL_HITS[stage], options);
 }
 
 pub fn calcDamage(
@@ -669,31 +655,30 @@ pub fn adjustDamage(battle: anytype, player: Player, state: *State, _: anytype)
     const side = battle.side(player);
     const foe = battle.foe(player);
     const types = foe.active.types;
-    const move = Move.get(state.move);
 
     var d = state.damage;
-    if ((move.type == .Water and battle.field.weather == .Rain) or
-        (move.type == .Fire and battle.field.weather == .Sun))
+    if ((state.type == .Water and battle.field.weather == .Rain) or
+        (state.type == .Fire and battle.field.weather == .Sun))
     {
         d = d *% @intFromEnum(Effectiveness.Super) / 10;
-    } else if ((move.type == .Water and battle.field.weather == .Sun) or
-        ((move.type == .Fire or state.move == .SolarBeam) and battle.field.weather == .Rain))
+    } else if ((state.type == .Water and battle.field.weather == .Sun) or
+        ((state.type == .Fire or state.move == .SolarBeam) and battle.field.weather == .Rain))
     {
         d = d *% @intFromEnum(Effectiveness.Resisted) / 10;
     }
 
-    if (side.active.types.includes(move.type)) d +%= d / 2;
+    if (side.active.types.includes(state.type)) d +%= d / 2;
 
     const neutral = @intFromEnum(Effectiveness.Neutral);
-    const foresight = foe.active.volatiles.Foresight and FORESIGHT.includes(move.type);
+    const foresight = foe.active.volatiles.Foresight and FORESIGHT.includes(state.type);
     const eff1: u16 = if (foresight and types.type1 == .Ghost)
         neutral
     else
-        @intFromEnum(move.type.effectiveness(types.type1));
+        @intFromEnum(state.type.effectiveness(types.type1));
     const eff2: u16 = if (foresight and types.type2 == .Ghost)
         neutral
     else
-        @intFromEnum(move.type.effectiveness(types.type2));
+        @intFromEnum(state.type.effectiveness(types.type2));
 
     // Type effectiveness matchup precedence only matters with (NVE, SE)
     if (!showdown and (eff1 + eff2) == Effectiveness.mismatch and
@@ -715,7 +700,7 @@ pub fn adjustDamage(battle: anytype, player: Player, state: *State, _: anytype)
 
 pub fn randomizeDamage(battle: anytype, player: Player, state: *State, options: anytype) !void {
     if (state.damage <= 1) return;
-    const random = try Rolls.damage(battle, player, options);
+    const random = try Rolls.damage(battle, player, state.hit, options);
     options.calc.base(player.foe(), state.damage);
     state.damage = @intCast(@as(u32, state.damage) *% random / 255);
     options.calc.final(player.foe(), state.damage);
@@ -775,9 +760,15 @@ pub fn checkHit(
             return;
         }
     }
-    if (move.effect == .Thunder and battle.field.weather == .Rain) {
-        state.miss = false;
-        return;
+    if (move.effect == .Thunder) {
+        if (battle.field.weather == .Rain) {
+            state.miss = false;
+            return;
+        } else if (battle.field.weather == .Sun) {
+            // This latter part gets applied in a separate Thunder accuracy handler
+            // on the cartridge but it makes more sense to just do it here
+            state.accuracy = Gen12.percent(50) + 1;
+        }
     }
     if (move.effect == .AlwaysHit) {
         state.miss = false;
@@ -827,13 +818,13 @@ fn checkFaint(
     if (foe_fainted) try faint(battle, player.foe(), !more, options);
 
     if (player_out and foe_out) {
-        try options.log.tie();
+        try options.log.tie(.{});
         return Result.Tie;
     } else if (player_out) {
-        try options.log.win(player.foe());
+        try options.log.win(.{player.foe()});
         return if (player == .P1) Result.Lose else Result.Win;
     } else if (foe_out) {
-        try options.log.win(player);
+        try options.log.win(.{player});
         return if (player == .P1) Result.Win else Result.Lose;
     }
 
@@ -863,19 +854,19 @@ fn faint(battle: anytype, player: Player, done: bool, options: anytype) !void {
             side.stored().stats.spe;
     }
 
-    try options.log.faint(battle.active(player), done);
+    try options.log.faint(.{ battle.active(player), done });
     options.calc.capped(player);
 }
 
 // TODO: see if we can move *before* applyDamage and include failuretext logic
 pub fn reportOutcome(battle: anytype, player: Player, state: *State, options: anytype) !void {
     const foe_ident = battle.active(player.foe());
-    if (state.crit) try options.log.crit(foe_ident);
+    if (state.crit) try options.log.crit(.{foe_ident});
     if (!state.immune()) {
         if (state.effectiveness > Effectiveness.neutral) {
-            try options.log.supereffective(foe_ident);
+            try options.log.supereffective(.{foe_ident});
         } else if (state.effectiveness < Effectiveness.neutral) {
-            try options.log.resisted(foe_ident);
+            try options.log.resisted(.{foe_ident});
         }
     }
 }
@@ -908,8 +899,8 @@ fn handleResidual(battle: anytype, player: Player, options: anytype) !bool {
         }
 
         stored.hp -|= damage;
-        // Pokémon Showdown uses damageOf here but its not relevant in Generation II
-        try options.log.damage(ident, stored, if (brn) Damage.Burn else Damage.Poison);
+        // Pokémon Showdown uses damage [of] here but its not relevant in Generation II
+        try options.log.damage(.{ ident, stored, if (brn) Damage.Burn else Damage.Poison });
         if (stored.hp == 0) return true;
     }
 
@@ -925,27 +916,27 @@ fn handleResidual(battle: anytype, player: Player, options: anytype) !bool {
 
         const damage = @max(stored.stats.hp / 8, 1);
         stored.hp -|= damage;
-        // As above, Pokémon Showdown uses damageOf but its not relevant
-        try options.log.damage(ident, stored, .LeechSeed);
+        // As above, Pokémon Showdown uses damage [of] but its not relevant
+        try options.log.damage(.{ ident, stored, .LeechSeed });
 
         const before = foe_stored.hp;
         foe_stored.hp = @min(foe_stored.hp + damage, foe_stored.stats.hp);
         // Pokémon Showdown uses the less specific heal here instead of drain... because reasons?
-        if (foe_stored.hp > before) try options.log.heal(foe_ident, foe_stored, .Silent);
+        if (foe_stored.hp > before) try options.log.heal(.{ foe_ident, foe_stored, .Silent });
         if (stored.hp == 0) return true;
     }
 
     if (volatiles.Nightmare) {
         stored.hp -= @max(stored.stats.hp / 4, 1);
         // ibid
-        try options.log.damage(ident, stored, .Nightmare);
+        try options.log.damage(.{ ident, stored, .Nightmare });
         if (stored.hp == 0) return true;
     }
 
     if (volatiles.Curse) {
         stored.hp -= @max(stored.stats.hp / 4, 1);
         // ibid
-        try options.log.damage(ident, stored, .Curse);
+        try options.log.damage(.{ ident, stored, .Curse });
         if (stored.hp == 0) return true;
     }
 
@@ -966,7 +957,7 @@ fn betweenTurns(battle: anytype, mslot: u4, options: anytype) !?Result {
             future_sight.count -= 1;
             assert(future_sight.count != 0);
             if (future_sight.count == 1) {
-                try options.log.end(battle.active(player), .FutureSight);
+                try options.log.end(.{ battle.active(player), .FutureSight });
                 // TODO doMove
             }
         }
@@ -975,21 +966,24 @@ fn betweenTurns(battle: anytype, mslot: u4, options: anytype) !?Result {
 
     // Weather
     if (battle.field.weather != .None) {
-        assert(battle.field.weather_duration > 0);
         battle.field.weather_duration -= 1;
 
         if (battle.field.weather_duration == 0) {
             battle.field.weather = .None;
-            try options.log.weather(battle.field.weather, .None);
+            try options.log.weather(.{ battle.field.weather, protocol.Weather.None });
         } else {
-            try options.log.weather(battle.field.weather, .Upkeep);
+            try options.log.weather(.{ battle.field.weather, protocol.Weather.Upkeep });
             if (battle.field.weather == .Sandstorm) {
                 inline for (players) |player| {
                     var side = battle.side(player);
                     const active = side.active;
                     if (!(active.volatiles.Underground or active.types.sandstormImmune())) {
                         side.stored().hp -|= @max(side.stored().stats.hp / 8, 1);
-                        try options.log.damage(battle.active(player), side.stored(), .Sandstorm);
+                        try options.log.damage(.{
+                            battle.active(player),
+                            side.stored(),
+                            .Sandstorm,
+                        });
                     }
                 }
                 if (try checkFaint(battle, .P1, options)) |r| return r;
@@ -1001,19 +995,24 @@ fn betweenTurns(battle: anytype, mslot: u4, options: anytype) !?Result {
     inline for (players) |player| {
         var side = battle.side(player);
         var volatiles = &side.active.volatiles;
+        const ident = battle.active(player);
 
         if (volatiles.bind.duration > 0 and !volatiles.Substitute) {
             volatiles.bind.duration -= 1;
             if (volatiles.bind.duration == 0) {
                 const reason = @intFromEnum(End.Bind) + volatiles.bind.reason - 1;
-                try options.log.end(battle.active(player), @enumFromInt(reason));
+                try options.log.end(.{ ident, @as(End, @enumFromInt(reason)) });
             } else {
                 var reason = @intFromEnum(Activate.Bind) + volatiles.bind.reason - 1;
-                try options.log.activate(battle.active(player), @enumFromInt(reason));
+                try options.log.activate(.{ ident, @as(Activate, @enumFromInt(reason)) });
 
                 reason = @intFromEnum(Damage.Bind) + volatiles.bind.reason - 1;
                 side.stored().hp -|= @max(side.stored().stats.hp / 16, 1);
-                try options.log.damage(battle.active(player), side.stored(), @enumFromInt(reason));
+                try options.log.damage(.{
+                    ident,
+                    side.stored(),
+                    @as(Damage, @enumFromInt(reason)),
+                });
             }
         }
     }
@@ -1025,12 +1024,11 @@ fn betweenTurns(battle: anytype, mslot: u4, options: anytype) !?Result {
         var volatiles = &side.active.volatiles;
 
         if (volatiles.PerishSong) {
-            assert(volatiles.perish_song > 0);
             volatiles.perish_song -= 1;
 
             assert(volatiles.perish_song < 3);
             const reason = @intFromEnum(Start.PerishSong0) + volatiles.perish_song;
-            try options.log.start(battle.active(player), @enumFromInt(reason));
+            try options.log.start(.{ battle.active(player), @as(Start, @enumFromInt(reason)) });
 
             if (volatiles.perish_song == 0) {
                 volatiles.PerishSong = false;
@@ -1047,13 +1045,15 @@ fn betweenTurns(battle: anytype, mslot: u4, options: anytype) !?Result {
         if (stored.item == .Leftovers) {
             const before = stored.hp;
             stored.hp = @min(stored.hp + @max(stored.stats.hp / 16, 1), stored.stats.hp);
-            if (stored.hp > before) try options.log.heal(battle.active(player), stored, .Leftovers);
+            if (stored.hp > before) {
+                try options.log.heal(.{ battle.active(player), stored, .Leftovers });
+            }
         }
     }
 
     // Mystery Berry
     inline for (players) |player| {
-        var stored = battle.side(player).stored();
+        const stored = battle.side(player).stored();
 
         if (stored.item == .MysteryBerry) {
             // TODO stored and active moves, transform, etc
@@ -1068,7 +1068,7 @@ fn betweenTurns(battle: anytype, mslot: u4, options: anytype) !?Result {
             !side.active.volatiles.frozen and
             try Rolls.defrost(battle, player, options))
         {
-            try options.log.curestatus(battle.active(player), side.stored().status, .Message);
+            try options.log.curestatus(.{ battle.active(player), side.stored().status, .Message });
             side.stored().status = 0;
         }
     }
@@ -1109,14 +1109,14 @@ fn betweenTurns(battle: anytype, mslot: u4, options: anytype) !?Result {
                     stored.hp < stored.stats.hp;
                 if (proc) {
                     assert(stored.hp != 0);
-                    try options.log.enditem(ident, stored.item, .Eat);
+                    try options.log.enditem(.{ ident, stored.item, .Eat });
                     stored.item = .None;
 
                     const offset = num - @intFromEnum(Item.Berry);
                     assert(offset < 3);
                     stored.hp = @min(stored.hp + ((offset + 1) * 10), stored.stats.hp);
                     const reason: Heal = @enumFromInt(@intFromEnum(Heal.Berry) + offset);
-                    try options.log.heal(ident, stored, reason);
+                    try options.log.heal(.{ ident, stored, reason });
                 }
             } else if (num < @intFromEnum(Item.BitterBerry)) {
                 const proc = if (stored.item == .MiracleBerry)
@@ -1126,29 +1126,29 @@ fn betweenTurns(battle: anytype, mslot: u4, options: anytype) !?Result {
 
                 if (proc) {
                     assert(Status.any(stored.status));
-                    try options.log.enditem(ident, stored.item, .Eat);
+                    try options.log.enditem(.{ ident, stored.item, .Eat });
                     stored.item = .None;
 
                     // FIXME wtf?
                     // side.active.volatiles.Toxic = false;
-                    // side.active.volatiles.NightMare = false;
+                    // side.active.volatiles.Nightmare = false;
                     if (stored.item == .MiracleBerry) {
                         side.active.volatiles.Confusion = false;
-                        try options.log.end(ident, .Confusion);
+                        try options.log.end(.{ ident, .Confusion });
                     }
                     stored.status = 0;
 
                     // FIXME recalc stats
 
-                    try options.log.curestatus(ident, stored.status, .Message);
+                    try options.log.curestatus(.{ ident, stored.status, .Message });
                 }
             } else if (num == @intFromEnum(Item.BitterBerry)) {
                 if (side.active.volatiles.Confusion) {
-                    try options.log.enditem(ident, stored.item, .Eat);
+                    try options.log.enditem(.{ ident, stored.item, .Eat });
                     stored.item = .None;
 
                     side.active.volatiles.Confusion = false;
-                    try options.log.end(ident, .Confusion);
+                    try options.log.end(.{ ident, .Confusion });
                 }
             }
         }
@@ -1160,12 +1160,11 @@ fn betweenTurns(battle: anytype, mslot: u4, options: anytype) !?Result {
         var volatiles = &side.active.volatiles;
 
         if (volatiles.Encore) {
-            assert(volatiles.encore > 0);
             volatiles.encore -= 1;
 
             if (volatiles.encore == 0 or side.active.move(mslot).pp == 0) {
                 volatiles.Encore = false;
-                try options.log.end(battle.active(player), .Encore);
+                try options.log.end(.{ battle.active(player), .Encore });
             }
         }
     }
@@ -1173,7 +1172,7 @@ fn betweenTurns(battle: anytype, mslot: u4, options: anytype) !?Result {
     return null;
 }
 
-inline fn updateSideCondition(
+fn updateSideCondition(
     battle: anytype,
     player: Player,
     comptime key: []const u8,
@@ -1182,12 +1181,11 @@ inline fn updateSideCondition(
 ) !void {
     var side = battle.side(player);
     if (@field(side.conditions, key)) {
-        assert(@field(side.conditions, value) > 0);
         @field(side.conditions, value) -= 1;
 
         if (@field(side.conditions, value) == 0) {
             @field(side.conditions, key) = false;
-            try options.log.sideend(player, @field(protocol.Side, key));
+            try options.log.sideend(.{ player, @field(protocol.Side, key) });
         }
     }
 }
@@ -1195,14 +1193,14 @@ inline fn updateSideCondition(
 fn endTurn(battle: anytype, options: anytype) @TypeOf(options.log).Error!Result {
     battle.turn += 1;
 
-    if (showdown and battle.turn >= 1000) {
-        try options.log.tie();
+    if (pkmn.options.mod and battle.turn >= 1000) {
+        try options.log.tie(.{});
         return Result.Tie;
     } else if (battle.turn >= 65535) {
         return Result.Error;
     }
 
-    try options.log.turn(battle.turn);
+    try options.log.turn(.{battle.turn});
 
     return Result.Default;
 }
@@ -1218,7 +1216,7 @@ pub fn buildRage(battle: anytype, player: Player, state: *State, options: anytyp
             }
         } else {
             foe.active.volatiles.rage +|= 1;
-            try options.log.activate(battle.active(player), .Rage);
+            try options.log.activate(.{ battle.active(player), .Rage });
         }
     }
 }
@@ -1241,16 +1239,12 @@ pub fn destinyBond(battle: anytype, player: Player, _: *State, options: anytype)
 
     if (foe.active.volatiles.DestinyBond) {
         battle.side(player).stored().hp = 0;
-        try options.log.activate(battle.active(player.foe()), .DestinyBond);
+        try options.log.activate(.{ battle.active(player.foe()), .DestinyBond });
     }
     return true;
 }
 
 pub const Effects = struct {
-    pub fn alwaysHit(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
-
     pub fn attract(battle: anytype, player: Player, _: *State, options: anytype) !void {
         const side = battle.side(player);
         var foe = battle.foe(player);
@@ -1258,16 +1252,14 @@ pub const Effects = struct {
         const gender: u8 = @intFromEnum(side.stored().dvs.gender);
         const foe_gender: u8 = @intFromEnum(foe.stored().dvs.gender);
         if (gender + foe_gender != 1) {
-            try options.log.immune(battle.active(player.foe()), .None);
-            return;
+            return options.log.immune(.{ battle.active(player.foe()), .None });
         } else if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
-            try options.log.lastmiss();
-            try options.log.miss(battle.active(player));
-            return;
+            try options.log.lastmiss(.{});
+            return options.log.miss(.{battle.active(player)});
         }
 
         foe.active.volatiles.Attract = true;
-        try options.log.start(battle.active(player.foe()), .Attract);
+        try options.log.start(.{ battle.active(player.foe()), .Attract });
     }
 
     pub fn batonPass(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -1279,15 +1271,71 @@ pub const Effects = struct {
     }
 
     pub fn bellyDrum(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
+        assert(!state.miss);
+        var side = battle.side(player);
 
-    pub fn bide(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        const ident = battle.active(player);
+
+        assert(side.active.boosts.atk >= -6 and side.active.boosts.atk <= 6);
+        if (side.active.boosts.atk == 6 or side.active.boosts.atk == MAX_STAT_VALUE) {
+            return options.log.fail(.{ ident, .None });
+        }
+
+        const hp = @max(side.stored().stats.hp / 2, 1);
+        if (side.stored().hp <= hp) {
+            try boostStat(battle, side, &side.active.stats, &side.active.boosts, "atk", 2);
+            try options.log.boost(.{ ident, .Attack, @as(i8, 2), .Silent });
+            return options.log.fail(.{ ident, .None });
+        } else {
+            side.stored().hp -= hp;
+            try options.log.damage(.{ ident, side.stored(), .None });
+
+            const before = side.active.boosts.atk;
+            var i: usize = 0;
+            while (i < 6 and side.active.stats.atk < MAX_STAT_VALUE) : (i += 1) {
+                try boostStat(battle, side, &side.active.stats, &side.active.boosts, "atk", 2);
+            }
+            try options.log.boost(.{ ident, .Attack, @as(i8, side.active.boosts.atk - before) });
+        }
     }
 
+    pub const bide = struct {
+        pub fn store(battle: anytype, player: Player, state: *State, options: anytype) !void {
+            var side = battle.side(player);
+            var volatiles = &side.active.volatiles;
+
+            const ident = battle.active(player);
+
+            if (!volatiles.Bide) return;
+
+            volatiles.attacks -= 1;
+            if (volatiles.attacks != 0) return options.log.activate(.{ ident, .Bide });
+
+            volatiles.Bide = false;
+            try options.log.end(.{ ident, .Bide });
+
+            state.damage = volatiles.bide *% 2;
+            volatiles.bide = 0;
+
+            if (state.damage == 0) state.miss = true;
+        }
+
+        pub fn unleash(battle: anytype, player: Player, state: *State, options: anytype) !void {
+            _ = .{ battle, player, state, options }; // TODO
+        }
+    };
+
     pub fn binding(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        var foe = battle.foe(player);
+
+        if (state.miss) return;
+        if (foe.active.volatiles.bind.duration > 0) return;
+        if (foe.active.volatiles.Substitute) return;
+
+        foe.active.volatiles.bind = .{
+            .duration = Rolls.bindingDuration(battle, player, options),
+            .reason = Move.get(state.move).extra.protocol,
+        };
     }
 
     pub fn burnChance(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -1297,12 +1345,12 @@ pub const Effects = struct {
         if (foe.active.volatiles.Substitute) return;
         if (Status.any(foe_stored.status)) {
             if (Status.is(foe_stored.status, .FRZ)) {
-                assert(Move.get(state.move).type == .Fire);
-                try options.log.curestatus(
+                assert(Move.get(state.move).type == .Fire or state.move == .TriAttack);
+                try options.log.curestatus(.{
                     battle.active(player.foe()),
                     foe_stored.status,
                     .Message,
-                );
+                });
                 foe_stored.status = 0;
             }
             return;
@@ -1311,11 +1359,14 @@ pub const Effects = struct {
         if (foe.conditions.Safeguard) return;
         // Nothing is immune to Fire-type, but Ghosts are immune to burnChance called by Tri Attack
         if (state.immune()) return;
-        if (foe.active.types.includes(Move.get(state.move).type)) return;
+        if (foe.active.types.includes(Move.get(state.move).type) and state.move != .TriAttack) {
+            return;
+        }
 
         foe_stored.status = Status.init(.BRN);
         foe.active.stats.atk = @max(foe.active.stats.atk / 2, 1);
-        try options.log.status(battle.active(player.foe()), foe_stored.status, .None);
+
+        try options.log.status(.{ battle.active(player.foe()), foe_stored.status, .None });
 
         // TODO: check for status berry
     }
@@ -1335,10 +1386,7 @@ pub const Effects = struct {
         for (side.active.moves) |m| {
             if (convertible(side.active, m.id)) n += 1;
         }
-        if (n == 0) {
-            try options.log.fail(battle.active(player), .None);
-            return;
-        }
+        if (n == 0) return options.log.fail(.{ battle.active(player), .None });
 
         side.active.types.type1 = try Rolls.conversion(battle, player, n, options);
         side.active.types.type2 = side.active.types.type1;
@@ -1348,26 +1396,88 @@ pub const Effects = struct {
         var side = battle.side(player);
 
         const last = battle.foe(player).lastMove(false);
-        if (last == .None) {
-            try options.log.fail(battle.active(player), .None);
-            return;
-        }
+        if (last == .None) return options.log.fail(.{ battle.active(player), .None });
         const move = Move.get(last);
-        if (move.type == .@"???") {
-            try options.log.fail(battle.active(player), .None);
-            return;
-        }
+        if (move.type == .@"???") return options.log.fail(.{ battle.active(player), .None });
 
         side.active.types.type1 = try Rolls.conversion2(battle, player, move.type, options);
         side.active.types.type2 = side.active.types.type1;
     }
 
-    pub fn counter(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn counter(battle: anytype, player: Player, state: *State, _: anytype) !void {
+        assert(state.move == .Counter or state.move == .MirrorCoat);
+
+        const foe = battle.foe(player);
+
+        state.miss = true;
+        const last = foe.lastMove(false);
+
+        if (last == .None) return;
+        if (last == state.move) return;
+
+        const immune = state.immune();
+        state.effectiveness = Effectiveness.neutral;
+        if (immune) {
+            state.damage = 0;
+            return;
+        }
+
+        const move = Move.get(last);
+        if (state.bp == 0) return;
+        if (move.type.special() != (last == .MirrorCoat)) return;
+        if (state.damage == 0) return;
+
+        // NOTE: llvm/llvm-project#58557
+        state.damage = smul(state.damage, 2);
+        state.miss = false;
     }
 
     pub fn curse(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        var side = battle.side(player);
+        var foe = battle.foe(player);
+
+        const ident = battle.active(player);
+        const foe_ident = battle.active(player.foe());
+
+        if (side.active.types.includes(.Ghost)) {
+            if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
+                try options.log.lastmiss(.{});
+                return options.log.miss(.{battle.active(player)});
+            } else if (foe.active.volatiles.Substitute) {
+                return options.log.activate(.{ foe_ident, .SubstituteBlock, state.move });
+            } else if (foe.active.volatiles.Curse) {
+                return options.log.fail(.{ foe_ident, .None });
+            }
+
+            foe.active.volatiles.Curse = true;
+            try options.log.start(.{ foe_ident, .Curse });
+
+            side.stored().hp -= @max(side.stored().stats.hp / 2, 1);
+            try options.log.damage(.{ ident, side.stored(), .Curse });
+        } else {
+            const stats = &side.active.stats;
+            const boosts = &side.active.boosts;
+
+            const max_atk = boosts.atk == 6 or stats.atk == MAX_STAT_VALUE;
+            const max_def = boosts.def == 6 or stats.def == MAX_STAT_VALUE;
+            if (max_atk and max_def) return options.log.fail(.{ ident, .None });
+
+            if (!(boosts.spe == -6 or stats.spe == 1)) {
+                assert(boosts.spe >= -6 and boosts.spe <= 6);
+                try unboostStat(battle, side, stats, boosts, "spe", 1);
+                try options.log.boost(.{ ident, .Speed, @as(i8, -1) });
+            }
+            if (!max_atk) {
+                assert(boosts.atk >= -6 and boosts.atk <= 6);
+                try boostStat(battle, side, stats, boosts, "atk", 1);
+                try options.log.boost(.{ ident, .Attack, @as(i8, 1) });
+            }
+            if (!max_def) {
+                assert(boosts.def >= -6 and boosts.def <= 6);
+                try boostStat(battle, side, stats, boosts, "def", 1);
+                try options.log.boost(.{ ident, .Defense, @as(i8, 1) });
+            }
+        }
     }
 
     pub fn defenseCurl(battle: anytype, player: Player, _: *State, _: anytype) !void {
@@ -1377,14 +1487,13 @@ pub const Effects = struct {
     pub fn defrost(battle: anytype, player: Player, _: *State, options: anytype) !void {
         var side = battle.side(player);
         assert(Status.is(side.stored().status, .FRZ));
-
-        try options.log.curestatus(battle.active(player), side.stored().status, .Message);
+        try options.log.curestatus(.{ battle.active(player), side.stored().status, .Message });
         side.stored().status = 0;
     }
 
     pub fn destinyBond(battle: anytype, player: Player, _: *State, options: anytype) !void {
         battle.side(player).active.volatiles.DestinyBond = true;
-        try options.log.singlemove(battle.active(player), Move.DestinyBond);
+        try options.log.singlemove(.{ battle.active(player), Move.DestinyBond });
     }
 
     pub fn disable(battle: anytype, player: Player, _: *State, options: anytype) !void {
@@ -1392,16 +1501,10 @@ pub const Effects = struct {
         var volatiles = &foe.active.volatiles;
         const foe_ident = battle.active(player.foe());
 
-        if (volatiles.disable.move != 0) {
-            try options.log.fail(foe_ident, .None);
-            return;
-        }
+        if (volatiles.disable.move != 0) return options.log.fail(.{ foe_ident, .None });
 
         const last = battle.foe(player).lastMove(false);
-        if (last == .None or last == .Struggle) {
-            try options.log.fail(foe_ident, .None);
-            return;
-        }
+        if (last == .None or last == .Struggle) return options.log.fail(.{ foe_ident, .None });
 
         var slot: u3 = 0;
         for (foe.active.moves) |m| {
@@ -1410,30 +1513,41 @@ pub const Effects = struct {
             if (m.id == last) break;
         }
         const move = foe.active.move(slot);
-        if (move.pp == 0) {
-            try options.log.fail(foe_ident, .None);
-            return;
-        }
+        if (move.pp == 0) return options.log.fail(.{ foe_ident, .None });
 
         volatiles.disable.move = slot;
         volatiles.disable.duration = Rolls.disableDuration(battle, player, options);
 
-        try options.log.startEffect(foe_ident, .Disable, move.id);
+        try options.log.start(.{ foe_ident, .Disable, move.id });
     }
 
-    pub fn doubleHit(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
+    pub const double = struct {
+        pub fn flying(battle: anytype, player: Player, state: *State, _: anytype) !void {
+            if (!battle.foe(player).active.volatiles.Flying) return;
+            state.damage = smul(state.damage, 2);
+        }
+
+        pub fn underground(battle: anytype, player: Player, state: *State, _: anytype) !void {
+            if (!battle.foe(player).active.volatiles.Underground) return;
+            state.damage = smul(state.damage, 2);
+        }
+
+        pub fn minimize(battle: anytype, player: Player, state: *State, _: anytype) !void {
+            if (!battle.foe(player).active.volatiles.minimized) return;
+            state.damage = smul(state.damage, 2);
+        }
+    };
 
     pub fn drainHP(battle: anytype, player: Player, state: *State, options: anytype) !void {
         var stored = battle.side(player).stored();
+        const ident = battle.active(player);
 
         assert(state.damage != 0);
 
         if (stored.hp == stored.stats.hp) return;
         stored.hp = @min(stored.stats.hp, stored.hp + @max(state.damage / 2, 1));
 
-        try options.log.drain(battle.active(player), stored, battle.active(player.foe()));
+        try options.log.heal(.{ ident, stored, .Drain, battle.active(player.foe()) });
     }
 
     pub fn encore(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -1445,10 +1559,7 @@ pub const Effects = struct {
         const failed = volatiles.Encore or
             (last == .None or last == .Struggle or
             last == .Encore or .last == .MirrorMove);
-        if (failed) {
-            try options.log.fail(foe_ident, .None);
-            return;
-        }
+        if (failed) return options.log.fail(.{ foe_ident, .None });
 
         var slot: u3 = 0;
         for (foe.active.moves) |m| {
@@ -1457,10 +1568,7 @@ pub const Effects = struct {
             if (m.id == last) break;
         }
         const move = foe.active.move(slot);
-        if (move.pp == 0) {
-            try options.log.fail(foe_ident, .None);
-            return;
-        }
+        if (move.pp == 0) return options.log.fail(.{ foe_ident, .None });
 
         volatiles.Encore = true;
         volatiles.encore = Rolls.encoreDuration(battle, player, options);
@@ -1468,11 +1576,19 @@ pub const Effects = struct {
         // TODO ???
         _ = state;
 
-        try options.log.startEffect(foe_ident, .Encore, move.id);
+        try options.log.start(.{ foe_ident, .Encore, move.id });
     }
 
-    pub fn explode(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn explode(battle: anytype, player: Player, _: *State, _: anytype) !void {
+        var side = battle.side(player);
+        var stored = side.stored();
+
+        stored.hp = 0;
+        // Pokémon Showdown sets the status to 0 on faint(), and we need to do the same to be able
+        // to correctly implement Pokémon Showdown's dumb speed-based switch mechanics
+        if (!showdown) stored.status = 0;
+        side.active.volatiles.LeechSeed = false;
+        side.active.volatiles.DestinyBond = false;
     }
 
     pub fn falseSwipe(battle: anytype, player: Player, state: *State, _: anytype) !void {
@@ -1500,10 +1616,6 @@ pub const Effects = struct {
         };
     }
 
-    pub fn flameWheel(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
-
     pub fn flinchChance(battle: anytype, player: Player, state: *State, _: anytype) !void {
         const foe = battle.foe(player);
         const status = foe.stored().status;
@@ -1526,12 +1638,11 @@ pub const Effects = struct {
         var side = battle.side(player);
 
         if (side.active.volatiles.FocusEnergy) {
-            if (!showdown) try options.log.fail(battle.active(player), .None);
-            return;
+            return if (!showdown) try options.log.fail(.{ battle.active(player), .None });
         }
 
         side.active.volatiles.FocusEnergy = true;
-        try options.log.start(battle.active(player), .FocusEnergy);
+        try options.log.start(.{ battle.active(player), .FocusEnergy });
     }
 
     var SLOTS: [5]u4 = .{ 0, 0, 0, 0, 0 };
@@ -1541,7 +1652,7 @@ pub const Effects = struct {
 
         const foe = battle.foe(player);
 
-        if (state.first) return try options.log.fail(battle.active(player), .None);
+        if (state.first) return options.log.fail(.{ battle.active(player), .None });
 
         var n: u4 = 0;
         var i: u4 = 0;
@@ -1555,10 +1666,7 @@ pub const Effects = struct {
             }
         }
 
-        if (n == 0) {
-            try options.log.fail(battle.active(player), .None);
-            return;
-        }
+        if (n == 0) return options.log.fail(.{ battle.active(player), .None });
 
         const slot = try Rolls.forceSwitch(battle, player, SLOTS[0..i], n, options);
         try switchIn(battle, player.foe(), slot, .Drag, options);
@@ -1568,16 +1676,14 @@ pub const Effects = struct {
         var foe = battle.foe(player);
 
         if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
-            try options.log.lastmiss();
-            try options.log.miss(battle.active(player));
-            return;
+            try options.log.lastmiss(.{});
+            return options.log.miss(.{battle.active(player)});
         } else if (foe.active.volatiles.Foresight) {
-            try options.log.fail(battle.active(player), .None);
-            return;
+            return options.log.fail(.{ battle.active(player), .None });
         }
 
         foe.active.volatiles.Foresight = true;
-        try options.log.start(battle.active(player.foe()), .FocusEnergy);
+        try options.log.start(.{ battle.active(player.foe()), .FocusEnergy });
     }
 
     pub fn freezeChance(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -1589,15 +1695,18 @@ pub const Effects = struct {
         if (Status.any(foe_stored.status)) return;
 
         // Nothing is immune to Ice-type, but Ghosts are immune to freezeChance called by Tri Attack
+        if (state.immune()) return;
         if (battle.field.weather == .Sun) return;
-        if (foe.active.types.includes(Move.get(state.move).type)) return;
+        if (foe.active.types.includes(Move.get(state.move).type) and state.move != .TriAttack) {
+            return;
+        }
         if (!state.proc) return;
         if (foe.conditions.Safeguard) return;
         // Freeze Clause Mod
-        if (showdown) for (foe.pokemon) |p| if (Status.is(p.status, .FRZ)) return;
+        if (pkmn.options.mod) for (foe.pokemon) |p| if (Status.is(p.status, .FRZ)) return;
 
         foe_stored.status = Status.init(.FRZ);
-        try options.log.status(foe_ident, foe_stored.status, .None);
+        try options.log.status(.{ foe_ident, foe_stored.status, .None });
 
         // TODO: check for status berry
 
@@ -1605,8 +1714,26 @@ pub const Effects = struct {
         foe.active.volatiles.frozen = true;
     }
 
-    pub fn furyCutter(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    // TODO FIXME showdown calls this before calcDamage (after checkHit) and modifies state.bp!
+    pub fn furyCutter(battle: anytype, player: Player, state: *State, _: anytype) !void {
+        var side = battle.side(player);
+        var volatiles = &side.active.volatiles;
+
+        if (state.miss) {
+            volatiles.fury_cutter = 0;
+            return;
+        }
+
+        assert(volatiles.fury_cutter >= 0 and volatiles.fury_cutter <= 5);
+        if (volatiles.fury_cutter == 5) return;
+        volatiles.fury_cutter += 1;
+
+        if (showdown) {
+            state.bp *= 2;
+            assert(state.bp <= 160);
+        } else {
+            state.damage = smul(state.damage, 2);
+        }
     }
 
     pub fn futureSight(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -1619,73 +1746,222 @@ pub const Effects = struct {
         state.bp = ((if (frustration) 255 - val else val) * 10) / 25;
     }
 
-    pub fn haze(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn haze(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+        var stats = unmodifiedStats(battle, side);
+        side.active.boosts = .{};
+        inline for (STATS) |s| @field(side.active.stats, s) = @field(stats, s);
+        statusModify(side.stored().status, &side.active.stats);
+
+        var foe = battle.foe(player);
+        stats = unmodifiedStats(battle, foe);
+        foe.active.boosts = .{};
+        inline for (STATS) |s| @field(foe.active.stats, s) = @field(stats, s);
+        statusModify(foe.stored().status, &foe.active.stats);
+
+        try options.log.clearallboost(.{});
     }
 
     pub fn heal(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
+        var side = battle.side(player);
+        var stored = side.stored();
+        const ident = battle.active(player);
 
-    pub fn healBell(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        if (stored.stats.hp == stored.hp) return options.log.fail(.{ ident, .None });
+
+        const rest = state.move == .Rest;
+        if (rest) {
+            // Adding the sleep status runs the sleep condition handler to roll duration
+            if (showdown) battle.rng.advance(1);
+            side.active.volatiles.Toxic = false;
+            stored.status = Status.slf(2);
+            recomputeStats(battle, side);
+            try options.log.status(.{ ident, stored.status, .From, Move.Rest });
+            stored.hp = stored.stats.hp;
+        } else {
+            stored.hp = @min(stored.stats.hp, stored.hp + (stored.stats.hp / 2));
+        }
+        try options.log.heal(.{ ident, stored, if (rest) Heal.Silent else Heal.None });
     }
 
-    pub fn hiddenPower(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn healBell(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+        side.active.volatiles.Nightmare = false;
+
+        try options.log.cureteam(.{battle.active(player)});
+        for (&side.pokemon) |*p| p.status = 0;
+
+        // We technically only need to recompute stats if the active Pokémon was burned/paralyzed,
+        // but adding a branch to check for that is probably more expensive than just recomputing
+        recomputeStats(battle, side);
     }
 
-    pub fn hyperBeam(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn hiddenPower(battle: anytype, player: Player, state: *State, _: anytype) !void {
+        const side = battle.side(player);
+        state.bp = side.stored().dvs.power();
+        state.type = side.stored().dvs.type;
     }
 
-    pub fn jumpKick(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn hyperBeam(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        battle.side(player).active.volatiles.Recharging = true;
+        try options.log.mustrecharge(.{battle.active(player)});
     }
 
     pub fn leechSeed(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        var foe = battle.foe(player);
+
+        if (showdown) {
+            // Invulnerability trumps type immunity on Pokémon Showdown
+            const invulnerable = foe.active.volatiles.Underground or foe.active.volatiles.Flying;
+            if (!invulnerable and foe.active.types.includes(.Grass)) {
+                return options.log.immune(.{ battle.active(player.foe()), .None });
+            }
+            try checkHit(battle, player, state, options);
+            if (state.miss) {
+                try options.log.lastmiss(.{});
+                return options.log.miss(.{battle.active(player)});
+            }
+            if (foe.active.volatiles.LeechSeed) return;
+        } else {
+            try checkHit(battle, player, state, options);
+            const miss =
+                state.miss or foe.active.types.includes(.Grass) or foe.active.volatiles.LeechSeed;
+            if (miss) {
+                try options.log.lastmiss(.{});
+                return options.log.miss(.{battle.active(player)});
+            }
+        }
+
+        foe.active.volatiles.LeechSeed = true;
+
+        try options.log.start(.{ battle.active(player.foe()), .LeechSeed });
     }
 
     pub fn lockOn(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        var foe = battle.foe(player);
+        const foe_ident = battle.active(player.foe());
+
+        if (foe.active.volatiles.Substitute) {
+            return options.log.activate(.{ foe_ident, .SubstituteBlock, state.move });
+        } else if (state.miss) {
+            return options.log.fail(.{ foe_ident, .None });
+        }
+
+        foe.active.volatiles.LockOn = true;
+        try options.log.activate(.{ battle.active(player), .LockOn });
     }
 
     const MAGNITUDE_POWER = [_]u8{ 10, 30, 50, 70, 90, 110, 150 };
 
     pub fn magnitude(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        const num = try Rolls.magnitude(battle, player, options);
+        try options.log.activate(.{ battle.active(player), .Magnitude, num });
+        state.bp = MAGNITUDE_POWER[num - 4];
     }
 
-    pub fn meanLook(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn meanLook(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var foe = battle.foe(player);
+
+        if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
+            if (!showdown) return options.log.fail(.{ battle.active(player.foe()), .None });
+            try options.log.lastmiss(.{});
+            return options.log.miss(.{battle.active(player)});
+        } else if (foe.active.volatiles.Trapped) {
+            return options.log.fail(.{ battle.active(player.foe()), .None });
+        }
+
+        foe.active.volatiles.Trapped = true;
     }
 
-    pub fn metronome(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn metronome(
+        battle: anytype,
+        player: Player,
+        state: *State,
+        options: anytype,
+    ) anyerror!void {
+        var side = battle.side(player);
+
+        side.last_used_move = .None;
+        side.active.volatiles.dirty = false;
+
+        // if (wPlayerCharging) ???
+        // wPlayerCharging = 1
+
+        // FIXME
+        state.move = try Rolls.metronome(battle, player, options);
+        state.from = .Metronome;
+        return generated.runMove(battle, player, state, options);
     }
 
     pub fn mimic(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
+        var side = battle.side(player);
 
-    pub fn mirrorCoat(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        if (state.miss) {
+            if (!showdown) return options.log.fail(.{ battle.active(player.foe()), .None });
+            try options.log.lastmiss(.{});
+            return options.log.miss(.{battle.active(player)});
+        }
+
+        const move = battle.foe(player).lastMove(false);
+        if (move == .None or move == .Struggle) {
+            return options.log.fail(.{ battle.active(player.foe()), .None });
+        }
+
+        var slot: u4 = 0;
+        for (side.active.moves, 0..) |m, i| {
+            if (m.id == move) return options.log.fail(.{ battle.active(player.foe()), .None });
+            if (m.id == .Mimic) slot = @intCast(i + 1);
+        }
+        assert(slot != 0 and slot == state.mslot);
+
+        side.active.move(slot).id = move;
+        side.active.move(slot).pp = 5;
+        try options.log.start(.{ battle.active(player), .Mimic, move });
     }
 
-    pub fn mirrorMove(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn mirrorMove(
+        battle: anytype,
+        player: Player,
+        state: *State,
+        options: anytype,
+    ) anyerror!void {
+        var side = battle.side(player);
+        const foe = battle.foe(player);
+
+        side.last_used_move = .None;
+        side.active.volatiles.dirty = false;
+
+        const last = foe.lastMove(false);
+
+        if (last == .None) return options.log.fail(.{ battle.active(player), .None });
+        const knows = knows: for (side.active.moves) |m| {
+            if (last == m.id) break :knows true;
+        } else false;
+        if (knows) return options.log.fail(.{ battle.active(player), .None });
+
+        // if (wPlayerCharging) ???
+        // wPlayerCharging = 1
+
+        // FIXME
+        state.move = last;
+        state.from = .MirrorMove;
+        return generated.runMove(battle, player, state, options);
     }
 
-    pub fn mist(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn mist(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+
+        if (side.active.volatiles.Mist) return options.log.fail(.{ battle.active(player), .None });
+        side.active.volatiles.Mist = true;
+
+        try options.log.start(.{ battle.active(player), .Mist });
     }
 
     pub fn weatherHeal(battle: anytype, player: Player, _: *State, options: anytype) !void {
         var stored = battle.side(player).stored();
         const ident = battle.active(player);
 
-        if (stored.hp == stored.stats.hp) return try options.log.fail(ident, .None);
+        if (stored.hp == stored.stats.hp) return options.log.fail(.{ ident, .None });
 
         stored.hp = switch (battle.field.weather) {
             .Sun => stored.stats.hp,
@@ -1693,7 +1969,7 @@ pub const Effects = struct {
             else => @min(stored.stats.hp, stored.hp + (stored.stats.hp / 4)),
         };
 
-        try options.log.heal(ident, stored, Heal.None);
+        try options.log.heal(.{ ident, stored, .None });
     }
 
     pub fn multiHit(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -1701,32 +1977,96 @@ pub const Effects = struct {
     }
 
     pub fn nightmare(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        var foe = battle.foe(player);
+        var foe_volatiles = &foe.active.volatiles;
+        const foe_ident = battle.active(player.foe());
+
+        if (foe_volatiles.Flying or foe_volatiles.Underground) {
+            if (!showdown) return options.log.fail(.{ battle.active(player.foe()), .None });
+            try options.log.lastmiss(.{});
+            return options.log.miss(.{battle.active(player)});
+        } else if (foe_volatiles.Substitute) {
+            return options.log.activate(.{ foe_ident, .SubstituteBlock, state.move });
+        } else if (!Status.is(foe.stored().status, .SLP) or foe_volatiles.Nightmare) {
+            return options.log.fail(.{ foe_ident, .None });
+        }
+
+        foe_volatiles.Nightmare = true;
+        try options.log.start(.{ battle.active(player.foe()), .Nightmare });
     }
 
-    pub fn ohko(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        const side = battle.side(player);
-        const foe = battle.foe(player);
+    pub const ohko = struct {
+        // OHKO calls adjustDamage but only actually cares about immunity
+        pub fn immune(battle: anytype, player: Player, state: *State, _: anytype) !void {
+            const move = Move.get(state.move);
 
-        const foe_ident = battle.active(player.foe());
+            assert(move.type == .Normal or move.type == .Ground);
+            const foe = battle.foe(player);
+            const zero = if (move.type == .Normal)
+                foe.active.types.includes(.Ghost) and !foe.active.volatiles.Foresight
+            else
+                foe.active.types.includes(.Flying);
+            state.effectiveness = if (zero) 0 else Effectiveness.neutral;
+        }
 
-        state.damage = 0;
-        if (state.immune()) return try options.log.immune(foe_ident, .None);
-        const delta = side.stored().level -| foe.stored().level;
-        if (delta == 0) return try options.log.immune(foe_ident, .OHKO);
+        pub fn damage(battle: anytype, player: Player, state: *State, options: anytype) !void {
+            const side = battle.side(player);
+            const foe = battle.foe(player);
 
-        state.accuracy = 2 * delta +| Gen12.percent(30);
-        try checkHit(battle, player, state, options);
-        if (!state.miss) state.damage = 65535;
-        state.ohko = true;
-    }
+            const foe_ident = battle.active(player.foe());
+
+            state.damage = 0;
+            if (state.immune()) return options.log.immune(.{ foe_ident, .None });
+            const delta = side.stored().level -| foe.stored().level;
+            if (delta == 0) return options.log.immune(.{ foe_ident, .OHKO });
+
+            state.accuracy = 2 * delta +| Gen12.percent(30);
+            try checkHit(battle, player, state, options);
+            if (!state.miss) state.damage = 65535;
+            state.ohko = true;
+        }
+    };
 
     pub fn painSplit(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        var side = battle.side(player);
+        var foe = battle.foe(player);
+
+        const ident = battle.active(player);
+        const foe_ident = battle.active(player.foe());
+
+        if (state.miss) return options.log.fail(.{ foe_ident, .None });
+        if (foe.active.volatiles.Substitute) {
+            return options.log.activate(.{ foe_ident, .SubstituteBlock, state.move });
+        }
+
+        const avg = @max((foe.stored().hp + side.stored().hp) / 2, 1);
+        foe.stored().hp -= avg;
+        side.stored().hp = avg;
+
+        try options.log.sethp(.{ foe_ident, foe.stored(), .Silent });
+        try options.log.sethp(.{ ident, side.stored(), .None });
     }
 
     pub fn paralyze(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        var foe = battle.foe(player);
+        const foe_ident = battle.active(player.foe());
+
+        if (Status.is(foe.stored().status, .PAR)) {
+            return options.log.fail(.{ foe_ident, .Paralysis });
+        }
+        if (state.immune()) return options.log.immune(.{ foe_ident, .None });
+        if (Status.any(foe.stored().status)) return options.log.fail(.{ foe_ident, .None });
+        if (state.miss) {
+            try options.log.lastmiss(.{});
+            return options.log.miss(.{battle.active(player)});
+        } else if (foe.active.volatiles.Substitute) {
+            return options.log.activate(.{ foe_ident, .SubstituteBlock, state.move });
+        }
+
+        foe.stored().status = Status.init(.PAR);
+        foe.active.stats.spe = @max(foe.active.stats.spe / 4, 1);
+
+        try options.log.status(.{ foe_ident, foe.stored().status, .None });
     }
 
     pub fn paralyzeChance(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -1741,17 +2081,34 @@ pub const Effects = struct {
 
         foe_stored.status = Status.init(.PAR);
         foe.active.stats.spe = @max(foe.active.stats.spe / 4, 1);
-        try options.log.status(battle.active(player.foe()), foe_stored.status, .None);
+
+        try options.log.status(.{ battle.active(player.foe()), foe_stored.status, .None });
 
         // TODO: check for status berry
     }
 
-    pub fn payDay(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn payDay(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        if (!showdown or !battle.foe(player).active.volatiles.Substitute) {
+            try options.log.fieldactivate(.{}); // FIXME .PayDay
+        }
     }
 
-    pub fn perishSong(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn perishSong(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+        var foe = battle.foe(player);
+
+        if (foe.active.volatiles.PerishSong) {
+            return options.log.fail(.{ battle.active(player.foe()), .None });
+        } else if (!side.active.volatiles.PerishSong) {
+            side.active.volatiles.PerishSong = true;
+            side.active.volatiles.perish_song = 4;
+            try options.log.start(.{ battle.active(player), .PerishSong3Silent });
+        }
+        foe.active.volatiles.PerishSong = true;
+        foe.active.volatiles.perish_song = 4;
+        try options.log.start(.{ battle.active(player.foe()), .PerishSong3Silent });
+
+        try options.log.fieldactivate(.{}); // FIXME .PerishSong
     }
 
     pub fn poison(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -1761,24 +2118,24 @@ pub const Effects = struct {
 
         const toxic = state.move == .Toxic;
         if (state.immune() or foe.active.types.includes(.Poison)) {
-            return options.log.immune(foe_ident, .None);
+            return options.log.immune(.{ foe_ident, .None });
         } else if (Status.any(foe_stored.status)) {
             // Pokémon Showdown considers Toxic to be a status even in Generation II and so
             // will not include a fail reason for Toxic vs. Poison or vice-versa...
-            return options.log.fail(foe_ident, if (Status.is(foe_stored.status, .PSN))
+            return options.log.fail(.{ foe_ident, if (Status.is(foe_stored.status, .PSN))
                 if (!showdown)
-                    .Poison
+                    Fail.Poison
                 else if (toxic == (foe_stored.status == Status.TOX))
-                    if (toxic) .Toxic else .Poison
+                    if (toxic) Fail.Toxic else Fail.Poison
                 else
-                    .None
+                    Fail.None
             else
-                .None);
+                Fail.None });
         } else if (foe.active.volatiles.Substitute) {
-            return options.log.activateMove(foe_ident, .SubstituteBlock, state.move);
+            return options.log.activate(.{ foe_ident, .SubstituteBlock, state.move });
         } else if (state.miss) {
-            try options.log.lastmiss();
-            try options.log.miss(battle.active(player));
+            try options.log.lastmiss(.{});
+            return options.log.miss(.{battle.active(player)});
         }
 
         foe_stored.status = Status.init(.PSN);
@@ -1788,7 +2145,7 @@ pub const Effects = struct {
             foe.active.volatiles.toxic = 0;
         }
 
-        try options.log.status(foe_ident, foe_stored.status, .None);
+        try options.log.status(.{ foe_ident, foe_stored.status, .None });
 
         // TODO: check for status berry
     }
@@ -1804,7 +2161,8 @@ pub const Effects = struct {
         if (foe.conditions.Safeguard) return;
 
         foe_stored.status = Status.init(.PSN);
-        try options.log.status(battle.active(player.foe()), foe_stored.status, .None);
+
+        try options.log.status(.{ battle.active(player.foe()), foe_stored.status, .None });
 
         // TODO: check for status berry
     }
@@ -1819,10 +2177,7 @@ pub const Effects = struct {
 
         const failed = !state.first or volatiles.Substitute or
             !try Rolls.protect(battle, player, volatiles.protect, options);
-        if (failed) {
-            try options.log.fail(battle.active(player), .None);
-            return;
-        }
+        if (failed) return options.log.fail(.{ battle.active(player), .None });
 
         volatiles.protect = @max(8, volatiles.protect + 1);
         if (state.move == .Endure) {
@@ -1830,36 +2185,76 @@ pub const Effects = struct {
         } else {
             volatiles.Protect = true;
         }
-        try options.log.singleturn(battle.active(player), state.move);
+        try options.log.singleturn(.{ battle.active(player), state.move });
     }
 
-    pub fn psychUp(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
+    pub fn psychUp(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+        const foe = battle.foe(player);
 
-    pub fn pursuit(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
+        // Pokémon Showdown should fail when the enemy has no boosts/unboosts but doesn't
+        if (!showdown and @as(u32, @bitCast(foe.active.boosts)) == 0) {
+            return options.log.fail(.{ battle.active(player), .None });
+        }
 
-    pub fn rage(battle: anytype, player: Player, _: *State, options: anytype) !void {
-        battle.side(player).active.volatiles.Rage = true;
-        try options.log.singlemove(battle.active(player), Move.Rage);
+        side.active.boosts = foe.active.boosts;
+        try options.log.copyboost(.{ battle.active(player), battle.active(player.foe()) });
     }
 
-    pub fn rainDance(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn pursuit(battle: anytype, player: Player, state: *State, _: anytype) !void {
+        // TODO: remove switching variable and just look at Choice saved in Battle struct?
+        if (battle.foe(player).active.volatiles.switching) state.damage = smul(state.damage, 2);
     }
 
-    pub fn rapidSpin(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub const rage = struct {
+        pub fn start(battle: anytype, player: Player, _: *State, options: anytype) !void {
+            battle.side(player).active.volatiles.Rage = true;
+            try options.log.singlemove(.{ battle.active(player), Move.Rage });
+        }
+
+        pub fn damage(battle: anytype, player: Player, state: *State, _: anytype) !void {
+            const side = battle.side(player);
+
+            assert(side.active.volatiles.Rage);
+            state.damage = smul(state.damage, (side.active.volatiles.rage +| 1)); // TODO: |+
+        }
+    };
+
+    pub fn rainDance(battle: anytype, _: Player, _: *State, options: anytype) !void {
+        return weather(battle, .Rain, options);
     }
 
-    pub fn razorWind(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn rapidSpin(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+
+        if (side.active.volatiles.LeechSeed) {
+            try options.log.end(.{ battle.active(player), .LeechSeedFrom });
+            side.active.volatiles.LeechSeed = false;
+        }
+
+        if (side.conditions.Spikes) {
+            try options.log.sideend(.{ player, protocol.Side.Spikes, battle.active(player) });
+            side.conditions.Spikes = false;
+        }
+
+        if (side.active.volatiles.bind.duration > 0) {
+            const reason = @intFromEnum(End.Bind) + side.active.volatiles.bind.reason - 1;
+            try options.log.end(.{ battle.active(player), @as(End, @enumFromInt(reason)) });
+            side.active.volatiles.bind = .{};
+        }
     }
 
     pub fn recoil(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        var side = battle.side(player);
+        var stored = side.stored();
+        const ident = battle.active(player);
+
+        assert(state.damage > 0);
+
+        const damage: i16 = @intCast(@max(state.damage / 4, 1));
+        stored.hp = @intCast(@max(@as(i16, @intCast(stored.hp)) - damage, 0));
+
+        try options.log.damage(.{ ident, stored, .RecoilOf, battle.active(player.foe()) });
     }
 
     pub fn reversal(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -1887,36 +2282,86 @@ pub const Effects = struct {
         try calcDamage(battle, player, state, options);
     }
 
-    pub fn rollout(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
+    pub const rollout = struct {
+        pub fn check(battle: anytype, player: Player, _: *State, _: anytype) !void {
+            var side = battle.side(player);
 
-    pub fn sacredFire(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
+            if (!side.active.volatiles.Rollout) {
+                side.active.volatiles.attacks = 0;
+            } else {
+                // TODO SkipToBattleCommand(doturn_command)
+            }
+        }
 
-    pub fn safeguard(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        pub fn power(battle: anytype, player: Player, state: *State, _: anytype) !void {
+            var side = battle.side(player);
+
+            if (Status.is(side.stored().status, .SLP)) return;
+
+            if (side.active.volatiles.attacks > 0) {
+                // TODO set wSomeoneIsRampaging
+            }
+
+            if (state.miss) {
+                side.active.volatiles.Rollout = false;
+                return;
+            }
+
+            assert(side.active.volatiles.attacks < 5);
+            side.active.volatiles.attacks += 1;
+            side.active.volatiles.Rollout = side.active.volatiles.attacks != 5;
+
+            if (side.active.volatiles.DefenseCurl) state.damage = smul(state.damage, 2);
+        }
+    };
+
+    pub fn sandstorm(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        if (battle.field.weather != .Sandstorm) return weather(battle, .Sandstorm, options);
+        return options.log.fail(.{ battle.active(player), .None });
     }
 
-    pub fn sandstorm(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn safeguard(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        return screens(battle, player, "Safeguard", "safeguard", options);
     }
 
-    pub fn screens(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn reflect(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        return screens(battle, player, "Reflect", "reflect", options);
     }
 
-    pub fn sketch(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn lightScreen(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        return screens(battle, player, "LightScreen", "light_screen", options);
     }
 
-    pub fn skullBash(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    fn screens(
+        battle: anytype,
+        player: Player,
+        comptime key: []const u8,
+        comptime value: []const u8,
+        options: anytype,
+    ) !void {
+        var side = battle.side(player);
+
+        if (@field(side.conditions, key)) {
+            return options.log.fail(.{ battle.active(player), .None });
+        }
+
+        @field(side.conditions, key) = true;
+        @field(side.conditions, value) = 5;
+        try options.log.sidestart(.{ player, @field(protocol.Side, key) });
     }
 
-    pub fn skyAttack(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn sketch(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+
+        side.last_used_move = .None;
+        side.active.volatiles.dirty = false;
+
+        if (showdown) {
+            // yes, actually "Splash". '|nothing' gets blindly mapped to  '|-activate||move:Splash'
+            try options.log.activate(.{ battle.active(player), .Splash });
+        } else {
+            try options.log.fail(.{ battle.active(player), .None });
+        }
     }
 
     pub fn sleep(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -1925,97 +2370,200 @@ pub const Effects = struct {
         const foe_ident = battle.active(player.foe());
 
         if (Status.any(foe_stored.status)) {
-            return options.log.fail(
+            return options.log.fail(.{
                 foe_ident,
-                if (Status.is(foe_stored.status, .SLP)) .Sleep else .None,
-            );
+                if (Status.is(foe_stored.status, .SLP)) Fail.Sleep else Fail.None,
+            });
         }
 
         if (foe.active.volatiles.Substitute) {
-            return options.log.activateMove(foe_ident, .SubstituteBlock, state.move);
+            return options.log.activate(.{ foe_ident, .SubstituteBlock, state.move });
         }
 
         // Sleep Clause Mod
-        if (showdown) {
+        if (pkmn.options.mod) {
             for (foe.pokemon) |p| {
                 if (Status.is(p.status, .SLP) and !Status.is(p.status, .EXT)) return;
             }
         }
 
         foe_stored.status = Status.slp(Rolls.sleepDuration(battle, player, options));
-        try options.log.statusFrom(foe_ident, foe_stored.status, state.move);
+        try options.log.status(.{ foe_ident, foe_stored.status, .From, state.move });
     }
 
     pub fn sleepTalk(battle: anytype, player: Player, state: *State, options: anytype) !void {
         const side = battle.side(player);
 
         if (!Status.is(side.stored().status, .SLP)) {
-            if (!showdown) try options.log.fail(battle.active(player), .None);
-            return;
+            return if (!showdown) try options.log.fail(.{ battle.active(player), .None });
         }
 
         var n: u3 = 0;
         for (side.active.moves, 0..) |m, i| {
             if (state.mslot - 1 != i and Move.get(m.id).extra.sleep_talk) n += 1;
         }
-        if (n == 0) {
-            try options.log.fail(battle.active(player), .None);
-            return;
-        }
+        if (n == 0) return options.log.fail(.{ battle.active(player), .None });
 
         _ = try Rolls.sleepTalk(battle, player, n, state.mslot, options); // TODO
     }
 
-    pub fn snore(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn snore(battle: anytype, player: Player, state: *State, options: anytype) !bool {
+        if (Status.is(battle.side(player).stored().status, .SLP)) return true;
+        state.damage = 0;
+        state.miss = true; // TODO is this necessary?
+        if (!showdown) try options.log.fail(.{ battle.active(player), .None });
+        return false;
     }
 
-    pub fn spikes(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn spikes(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var foe = battle.foe(player);
+        if (foe.conditions.Spikes) return options.log.fail(.{ battle.active(player), .None });
+
+        foe.conditions.Spikes = true;
+        try options.log.sidestart(.{ player.foe(), protocol.Side.Spikes });
     }
 
     pub fn spite(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
+        var foe = battle.foe(player);
 
-    pub fn splash(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
+        const last = foe.lastMove(false);
+        if (state.miss or last == .None or last == .Struggle) {
+            return options.log.fail(.{ battle.active(player.foe()), .None });
+        }
 
-    pub fn stomp(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        var slot: u4 = 0;
+        for (foe.active.moves, 0..) |m, i| {
+            if (m.id == last) slot = @intCast(i + 1);
+        }
+        // If the move was called via Metronome it might not exist
+        if (slot == 0 or foe.active.move(slot).pp == 0) {
+            return options.log.fail(.{ battle.active(player.foe()), .None });
+        }
+
+        // Pokémon Showdown always deducts 4 instead of randomizing
+        const pp = @min(
+            foe.active.move(slot).pp,
+            if (showdown) 4 else try Rolls.spite(battle, player, options),
+        );
+        foe.active.move(slot).pp -= pp;
+        if (!foe.active.volatiles.Transform) {
+            var move_slot = foe.stored().move(slot);
+            assert(move_slot.pp > 0);
+
+            move_slot.pp = @as(u6, @intCast(move_slot.pp)) -% 1;
+            assert(foe.active.move(slot).pp == foe.stored().move(slot).pp);
+        }
+
+        try options.log.activate(.{ battle.active(player.foe()), .Spite, last, pp });
     }
 
-    pub fn substitute(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn splash(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        try options.log.activate(.{ battle.active(player), .Splash });
     }
 
-    pub fn sunnyDay(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn substitute(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+        if (side.active.volatiles.Substitute) {
+            return options.log.fail(.{ battle.active(player), .Substitute });
+        }
+
+        assert(side.stored().stats.hp <= 1023);
+        const hp: u8 = @intCast(side.stored().stats.hp / 4);
+
+        if (hp == 0 or side.stored().hp <= hp) {
+            return options.log.fail(.{ battle.active(player), .Weak });
+        }
+
+        side.stored().hp -= hp;
+        side.active.volatiles.substitute = hp;
+        side.active.volatiles.Substitute = true;
+        side.active.volatiles.bind = .{};
+        try options.log.start(.{ battle.active(player), .Substitute });
+        try options.log.damage(.{ battle.active(player), side.stored(), .None });
     }
 
-    pub fn swagger(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn sunnyDay(battle: anytype, _: Player, _: *State, options: anytype) !void {
+        return weather(battle, .Sun, options);
     }
 
-    pub fn synthesis(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    fn weather(battle: anytype, w: Weather, options: anytype) !void {
+        battle.field.weather = w;
+        battle.field.weather_duration = 5;
+        try options.log.weather(.{ w, protocol.Weather.None });
     }
 
-    pub fn teleport(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn teleport(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        if (showdown) return;
+
+        try options.log.fail(.{ battle.active(player), .None });
+        try options.log.laststill(.{});
     }
 
     pub fn thief(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        const side = battle.side(player);
+        const foe = battle.foe(player);
+
+        if (side.stored().item != .None or foe.stored().item == .None) return;
+        // Pokémon Showdown incorrectly allows you steal Mail
+        if (!showdown and foe.stored().item.isMail()) return;
+        if (!state.proc) return;
+
+        side.stored().item = foe.stored().item;
+        foe.stored().item = .None;
+
+        try options.log.item(.{
+            battle.active(player),
+            side.stored().item,
+            battle.active(player.foe()),
+        });
     }
 
-    pub fn thrashing(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn thrashing(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+        if (Status.is(side.stored().status, .SLP)) return;
+
+        assert(!side.active.volatiles.Thrashing);
+        side.active.volatiles.Thrashing = true;
+        side.active.volatiles.attacks = Rolls.attackingDuration(battle, player, options);
+        // TODO wSomeoneIsRampaging = true;
     }
 
-    pub fn transform(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn transform(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+        const foe = battle.foe(player);
+        const foe_ident = battle.active(player.foe());
+
+        side.last_used_move = .None;
+        side.active.volatiles.dirty = false;
+
+        if (foe.active.volatiles.Transform) {
+            return options.log.fail(.{ battle.active(player), .None });
+        } else if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
+            if (!showdown) return options.log.fail(.{ battle.active(player), .None });
+            try options.log.lastmiss(.{});
+            return options.log.miss(.{battle.active(player)});
+        }
+
+        side.active.volatiles.Transform = true;
+        side.active.volatiles.transform = foe_ident.int();
+        side.active.volatiles.disable = .{};
+
+        // HP is not copied by Transform
+        side.active.stats.atk = foe.active.stats.atk;
+        side.active.stats.def = foe.active.stats.def;
+        side.active.stats.spe = foe.active.stats.spe;
+        side.active.stats.spa = foe.active.stats.spa;
+        side.active.stats.spd = foe.active.stats.spd;
+
+        side.active.species = foe.active.species;
+        side.active.types = foe.active.types;
+        side.active.boosts = foe.active.boosts;
+        for (foe.active.moves, 0..) |m, i| {
+            side.active.moves[i].id = m.id;
+            side.active.moves[i].pp = if (m.id != .None) if (m.id == .Sketch) 1 else 5 else 0;
+        }
+
+        try options.log.transform(.{ battle.active(player), foe_ident });
     }
 
     pub fn triAttack(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -2027,42 +2575,32 @@ pub const Effects = struct {
                 .FRZ => freezeChance(battle, player, state, options),
                 .BRN => burnChance(battle, player, state, options),
             };
-        } else if (!showdown and pkmn.options.advance) _ = battle.rng.next();
+        } else if (!showdown) battle.rng.advance(1);
     }
 
     pub fn tripleKick(battle: anytype, player: Player, state: *State, options: anytype) !void {
         _ = .{ battle, player, state, options }; // TODO
     }
 
-    pub fn twister(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
-
-    const ALL_STAT_UP_STATS = [_][]const u8{ "atk", "def", "spe", "spa", "spd" };
-    const ALL_STAT_UP_REASONS =
+    const STAT_UP_REASONS =
         [_]Boost{ .Attack, .Defense, .Speed, .SpecialAttack, .SpecialDefense };
 
     pub fn allStatUpChance(battle: anytype, player: Player, state: *State, options: anytype) !void {
         var side = battle.side(player);
 
-        var stats = &side.active.stats;
-        var boosts = &side.active.boosts;
+        const stats = &side.active.stats;
+        const boosts = &side.active.boosts;
 
         if (!state.proc) return;
-        inline for (ALL_STAT_UP_STATS, ALL_STAT_UP_REASONS) |s, r| {
+        inline for (STATS, STAT_UP_REASONS) |s, r| {
             assert(@field(boosts, s) >= -6 and @field(boosts, s) <= 6);
             if (@field(boosts, s) == 6 or @field(stats, s) == MAX_STAT_VALUE) {
-                try options.log.boost(battle.active(player), r, 0);
+                try options.log.boost(.{ battle.active(player), r, 0 });
             } else {
-                @field(boosts, s) = @intCast(@min(6, @as(i8, @field(boosts, s)) + 1));
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, @field(boosts, s)) + 6))];
-                const stat = @field(unmodifiedStats(battle, side), s);
-                @field(stats, s) = @min(MAX_STAT_VALUE, stat * mod[0] / mod[1]);
-                try options.log.boost(battle.active(player), r, 1);
+                try boostStat(battle, side, stats, boosts, s, 1);
+                try options.log.boost(.{ battle.active(player), r, 1 });
             }
         }
-
-        statusModify(side.stored().status, stats);
     }
 
     pub fn boost(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -2070,84 +2608,65 @@ pub const Effects = struct {
         var side = battle.side(player);
         const ident = battle.active(player);
 
-        if (state.miss) return try log.fail(ident, .None);
+        if (state.miss) return log.fail(.{ ident, .None });
 
-        var stats = &side.active.stats;
+        const stats = &side.active.stats;
         var boosts = &side.active.boosts;
 
         const move = Move.get(state.move);
         switch (move.effect) {
-            .AttackUp1, .AttackUp2, .Rage => {
+            .AttackUp1, .AttackUp2, .Rage, .Swagger => {
                 assert(boosts.atk >= -6 and boosts.atk <= 6);
                 if (boosts.atk == 6 or stats.atk == MAX_STAT_VALUE) {
-                    return try log.fail(ident, .None);
+                    return log.fail(.{ ident, .None });
                 }
-                const n: u2 = if (move.effect == .AttackUp2) 2 else 1;
-                boosts.atk = @as(i4, @intCast(@min(6, @as(i8, boosts.atk) + n)));
+                const n: u2 = if (move.effect == .AttackUp2 or move.effect == .Swagger) 2 else 1;
+                try boostStat(battle, side, stats, boosts, "atk", n);
                 const reason = if (showdown and move.effect == .Rage) Boost.Rage else Boost.Attack;
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, boosts.atk) + 6))];
-                const stat = unmodifiedStats(battle, side).atk;
-                stats.atk = @min(MAX_STAT_VALUE, stat * mod[0] / mod[1]);
-                try log.boost(ident, reason, n);
+                try log.boost(.{ ident, reason, n });
             },
-            .DefenseUp1, .DefenseUp2 => {
+            .DefenseUp1, .DefenseUp2, .SkullBash => {
                 assert(boosts.def >= -6 and boosts.def <= 6);
                 if (boosts.def == 6 or stats.def == MAX_STAT_VALUE) {
-                    return try log.fail(ident, .None);
+                    return log.fail(.{ ident, .None });
                 }
                 const n: u2 = if (move.effect == .DefenseUp2) 2 else 1;
-                boosts.def = @intCast(@min(6, @as(i8, boosts.def) + n));
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, boosts.def) + 6))];
-                const stat = unmodifiedStats(battle, side).def;
-                stats.def = @min(MAX_STAT_VALUE, stat * mod[0] / mod[1]);
-                try log.boost(ident, .Defense, n);
+                try boostStat(battle, side, stats, boosts, "def", n);
+                try log.boost(.{ ident, .Defense, n });
             },
             .SpeedUp2 => {
                 assert(boosts.spe >= -6 and boosts.spe <= 6);
                 if (boosts.spe == 6 or stats.spe == MAX_STAT_VALUE) {
-                    return try log.fail(ident, .None);
+                    return log.fail(.{ ident, .None });
                 }
-                boosts.spe = @intCast(@min(6, @as(i8, boosts.spe) + 2));
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, boosts.spe) + 6))];
-                const stat = unmodifiedStats(battle, side).spe;
-                stats.spe = @min(MAX_STAT_VALUE, stat * mod[0] / mod[1]);
-                try log.boost(ident, .Speed, 2);
+                try boostStat(battle, side, stats, boosts, "spe", 2);
+                try log.boost(.{ ident, .Speed, 2 });
             },
             .SpAtkUp1 => {
                 assert(boosts.spa >= -6 and boosts.spa <= 6);
                 if (boosts.spa == 6 or stats.spa == MAX_STAT_VALUE) {
-                    return try log.fail(ident, .None);
+                    return log.fail(.{ ident, .None });
                 }
-                boosts.spa = @intCast(@min(6, @as(i8, boosts.spa) + 1));
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, boosts.spa) + 6))];
-                const stat = unmodifiedStats(battle, side).spa;
-                stats.spa = @min(MAX_STAT_VALUE, stat * mod[0] / mod[1]);
-                try log.boost(ident, .SpecialAttack, 1);
+                try boostStat(battle, side, stats, boosts, "spa", 1);
+                try log.boost(.{ ident, .SpecialAttack, 1 });
             },
             .SpDefUp2 => {
                 assert(boosts.spd >= -6 and boosts.spd <= 6);
                 if (boosts.spd == 6 or stats.spd == MAX_STAT_VALUE) {
-                    return try log.fail(ident, .None);
+                    return log.fail(.{ ident, .None });
                 }
-                boosts.spd = @intCast(@min(6, @as(i8, boosts.spd) + 2));
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, boosts.spd) + 6))];
-                const stat = unmodifiedStats(battle, side).spd;
-                stats.spd = @min(MAX_STAT_VALUE, stat * mod[0] / mod[1]);
-                try log.boost(ident, .SpecialDefense, 2);
+                try boostStat(battle, side, stats, boosts, "spd", 2);
+                try log.boost(.{ ident, .SpecialDefense, 2 });
             },
             .EvasionUp1 => {
                 assert(boosts.evasion >= -6 and boosts.evasion <= 6);
-                if (boosts.evasion == 6) {
-                    return try log.fail(ident, .None);
-                }
+                if (boosts.evasion == 6) return log.fail(.{ ident, .None });
                 boosts.evasion = @intCast(@min(6, @as(i8, boosts.evasion) + 1));
-                try log.boost(ident, .Evasion, 1);
+                try log.boost(.{ ident, .Evasion, 1 });
                 if (state.move == .Minimize) side.active.volatiles.minimized = true;
             },
             else => unreachable,
         }
-
-        statusModify(side.stored().status, stats);
     }
 
     pub fn unboost(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -2156,102 +2675,86 @@ pub const Effects = struct {
         const foe_ident = battle.active(player.foe());
 
         if (foe.active.volatiles.Mist) {
-            try log.activate(foe_ident, .Mist);
-            return try log.fail(foe_ident, .None);
+            try log.activate(.{ foe_ident, .Mist });
+            return log.fail(.{ foe_ident, .None });
         }
 
         const fail = foe.active.volatiles.Substitute or state.miss or !state.proc;
 
-        var stats = &foe.active.stats;
+        const stats = &foe.active.stats;
         var boosts = &foe.active.boosts;
 
         const move = Move.get(state.move);
+        const none: Fail = .None;
         switch (move.effect) {
             .AttackDown1, .AttackDown2, .AttackDownChance => {
                 assert(boosts.atk >= -6 and boosts.atk <= 6);
                 if (fail or boosts.atk == -6) {
-                    return if (move.effect != .AttackDownChance) try log.fail(foe_ident, .None);
+                    return if (move.effect != .AttackDownChance) try log.fail(.{ foe_ident, none });
                 } else if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
-                    try options.log.lastmiss();
-                    try options.log.miss(battle.active(player));
-                    return;
+                    try options.log.lastmiss(.{});
+                    return options.log.miss(.{battle.active(player)});
                 } else if (stats.atk == 1) {
-                    return if (move.effect != .AttackDownChance) try log.fail(foe_ident, .None);
+                    return if (move.effect != .AttackDownChance) try log.fail(.{ foe_ident, none });
                 }
                 const n: u2 = if (move.effect == .AttackDown2) 2 else 1;
-                boosts.atk = @intCast(@max(-6, @as(i8, boosts.atk) - n));
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, boosts.atk) + 6))];
-                const stat = unmodifiedStats(battle, foe).atk;
-                stats.atk = @max(1, stat * mod[0] / mod[1]);
-                try log.boost(foe_ident, .Attack, -@as(i8, n));
+                try unboostStat(battle, foe, stats, boosts, "atk", n);
+                try log.boost(.{ foe_ident, .Attack, -@as(i8, n) });
             },
             .DefenseDown1, .DefenseDown2, .DefenseDownChance => {
                 assert(boosts.def >= -6 and boosts.def <= 6);
                 if (fail or boosts.def == -6) {
-                    return if (move.effect != .DefenseDownChance) try log.fail(foe_ident, .None);
-                } else if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
-                    try options.log.lastmiss();
-                    try options.log.miss(battle.active(player));
+                    if (move.effect != .DefenseDownChance) try log.fail(.{ foe_ident, none });
                     return;
+                } else if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
+                    try options.log.lastmiss(.{});
+                    return options.log.miss(.{battle.active(player)});
                 } else if (stats.def == 1) {
-                    return if (move.effect != .DefenseDownChance) try log.fail(foe_ident, .None);
+                    if (move.effect != .DefenseDownChance) try log.fail(.{ foe_ident, none });
+                    return;
                 }
                 const n: u2 = if (move.effect == .DefenseDown2) 2 else 1;
-                boosts.def = @intCast(@max(-6, @as(i8, boosts.def) - n));
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, boosts.def) + 6))];
-                const stat = unmodifiedStats(battle, foe).def;
-                stats.def = @max(1, stat * mod[0] / mod[1]);
-                try log.boost(foe_ident, .Defense, -@as(i8, n));
+                try unboostStat(battle, foe, stats, boosts, "def", n);
+                try log.boost(.{ foe_ident, .Defense, -@as(i8, n) });
             },
             .SpeedDown1, .SpeedDown2, .SpeedDownChance => {
                 assert(boosts.spe >= -6 and boosts.spe <= 6);
                 if (fail or boosts.spe == -6) {
-                    return if (move.effect != .SpeedDownChance) try log.fail(foe_ident, .None);
+                    return if (move.effect != .SpeedDownChance) try log.fail(.{ foe_ident, none });
                 } else if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
-                    try options.log.lastmiss();
-                    try options.log.miss(battle.active(player));
-                    return;
+                    try options.log.lastmiss(.{});
+                    return options.log.miss(.{battle.active(player)});
                 } else if (stats.spe == 1) {
-                    return if (move.effect != .SpeedDownChance) try log.fail(foe_ident, .None);
+                    return if (move.effect != .SpeedDownChance) try log.fail(.{ foe_ident, none });
                 }
                 const n: u2 = if (move.effect == .SpeedDown2) 2 else 1;
-                boosts.spe = @intCast(@max(-6, @as(i8, boosts.spe) - 1));
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, boosts.spe) + 6))];
-                const stat = unmodifiedStats(battle, foe).spe;
-                stats.spe = @max(1, stat * mod[0] / mod[1]);
-                try log.boost(foe_ident, .Speed, -@as(i8, n));
-                assert(boosts.spe >= -6);
+                try unboostStat(battle, foe, stats, boosts, "spe", n);
+                try log.boost(.{ foe_ident, .Speed, -@as(i8, n) });
             },
             .SpDefDownChance => {
                 assert(boosts.spd >= -6 and boosts.spd <= 6);
                 if (fail or boosts.spd == -6) return;
                 if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
-                    try options.log.lastmiss();
-                    try options.log.miss(battle.active(player));
-                    return;
+                    try options.log.lastmiss(.{});
+                    return options.log.miss(.{battle.active(player)});
                 } else if (stats.spd == 1) return;
-                boosts.spd = @intCast(@max(-6, @as(i8, boosts.spd) - 1));
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, boosts.spd) + 6))];
-                const stat = unmodifiedStats(battle, foe).spd;
-                stats.spd = @max(1, stat * mod[0] / mod[1]);
-                try log.boost(foe_ident, .SpecialDefense, -1);
+                try unboostStat(battle, foe, stats, boosts, "spd", 1);
+                try log.boost(.{ foe_ident, .SpecialDefense, -1 });
             },
             .AccuracyDown1, .AccuracyDownChance => {
                 assert(boosts.accuracy >= -6 and boosts.accuracy <= 6);
                 if (fail or boosts.accuracy == -6) {
-                    return if (move.effect != .AccuracyDownChance) try log.fail(foe_ident, .None);
-                } else if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
-                    try options.log.lastmiss();
-                    try options.log.miss(battle.active(player));
+                    if (move.effect != .AccuracyDownChance) try log.fail(.{ foe_ident, none });
                     return;
+                } else if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
+                    try options.log.lastmiss(.{});
+                    return options.log.miss(.{battle.active(player)});
                 }
                 boosts.accuracy = @intCast(@max(-6, @as(i8, boosts.accuracy) - 1));
-                try log.boost(foe_ident, .Accuracy, -1);
+                try log.boost(.{ foe_ident, .Accuracy, -1 });
             },
             else => unreachable,
         }
-
-        statusModify(foe.stored().status, stats);
     }
 };
 
@@ -2261,6 +2764,15 @@ fn unmodifiedStats(battle: anytype, side: *Side) *Stats(u16) {
     return &battle.side(id.player).pokemon[id.id - 1].stats;
 }
 
+fn recomputeStats(battle: anytype, side: *Side) void {
+    const stats = unmodifiedStats(battle, side);
+    inline for (STATS) |s| {
+        const mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, @field(side.active.boosts, s)) + 6))];
+        const val = @field(stats, s) * mod[0] / mod[1];
+        @field(side.active.stats, s) = @max(1, @min(MAX_STAT_VALUE, val));
+    }
+}
+
 fn statusModify(status: u8, stats: *Stats(u16)) void {
     if (Status.is(status, .PAR)) {
         stats.spe = @max(stats.spe / 4, 1);
@@ -2269,21 +2781,73 @@ fn statusModify(status: u8, stats: *Stats(u16)) void {
     }
 }
 
-inline fn isForced(active: anytype) bool {
+fn boostStat(
+    battle: anytype,
+    side: *Side,
+    stats: *Stats(u16),
+    boosts: *Boosts,
+    comptime s: []const u8,
+    n: u2,
+) !void {
+    @field(boosts, s) = @intCast(@min(6, @as(i8, @field(boosts, s)) + n));
+    const mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, @field(boosts, s)) + 6))];
+    const stat = @field(unmodifiedStats(battle, side), s);
+    @field(stats, s) = @min(MAX_STAT_VALUE, stat * mod[0] / mod[1]);
+    if (comptime std.mem.eql(u8, s, "atk")) {
+        if (Status.is(side.stored().status, .BRN)) {
+            @field(stats, s) = @max(@field(stats, s) / 2, 1);
+        }
+    } else if (comptime std.mem.eql(u8, s, "spe")) {
+        if (Status.is(side.stored().status, .PAR)) {
+            @field(stats, s) = @max(@field(stats, s) / 4, 1);
+        }
+    }
+}
+
+fn unboostStat(
+    battle: anytype,
+    side: *Side,
+    stats: *Stats(u16),
+    boosts: *Boosts,
+    comptime s: []const u8,
+    n: u2,
+) !void {
+    @field(boosts, s) = @intCast(@max(-6, @as(i8, @field(boosts, s)) - n));
+    const mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, @field(boosts, s)) + 6))];
+    const stat = @field(unmodifiedStats(battle, side), s);
+    @field(stats, s) = @max(1, stat * mod[0] / mod[1]);
+    if (comptime std.mem.eql(u8, s, "atk")) {
+        if (Status.is(side.stored().status, .BRN)) {
+            @field(stats, s) = @max(@field(stats, s) / 2, 1);
+        }
+    } else if (comptime std.mem.eql(u8, s, "spe")) {
+        if (Status.is(side.stored().status, .PAR)) {
+            @field(stats, s) = @max(@field(stats, s) / 4, 1);
+        }
+    }
+}
+
+fn isForced(active: anytype) bool {
     return active.volatiles.Recharging or active.volatiles.Rage or
         active.volatiles.Thrashing or active.volatiles.Charging or
         active.volatiles.Rollout;
 }
 
-inline fn convertible(active: ActivePokemon, m: Move) bool {
+fn convertible(active: ActivePokemon, m: Move) bool {
     if (m == .None) return false;
     const t = Move.get(m).type;
     return t != .@"???" and !active.types.includes(t);
 }
 
+// NOTE: llvm/llvm-project#58557
+fn smul(a: anytype, b: @TypeOf(a)) @TypeOf(a) {
+    if (!comptime builtin.target.cpu.arch.isWasm()) return a *| b;
+    return @max(a *% b, std.math.maxInt(@TypeOf(a)));
+}
+
 pub const Rolls = struct {
-    inline fn speedTie(battle: anytype, options: anytype) !bool {
-        const p1 = if (options.calc.overridden(.P1, .speed_tie)) |player|
+    fn speedTie(battle: anytype, options: anytype) !bool {
+        const p1 = if (options.calc.overridden(.P1, 0, .speed_tie)) |player|
             player == .P1
         else if (showdown)
             battle.rng.range(u8, 0, 2) == 0
@@ -2294,8 +2858,8 @@ pub const Rolls = struct {
         return p1;
     }
 
-    inline fn quickClaw(battle: anytype, player: Player, options: anytype) !bool {
-        const qkc = if (options.calc.overridden(player, .quick_claw)) |val|
+    fn quickClaw(battle: anytype, player: Player, options: anytype) !bool {
+        const qkc = if (options.calc.overridden(player, 0, .quick_claw)) |val|
             val == .true
         else if (showdown)
             battle.rng.chance(u8, 60, 256)
@@ -2306,8 +2870,8 @@ pub const Rolls = struct {
         return qkc;
     }
 
-    inline fn hit(battle: anytype, player: Player, accuracy: u8, options: anytype) !bool {
-        const ok = if (options.calc.overridden(player, .hit)) |val|
+    fn hit(battle: anytype, player: Player, accuracy: u8, options: anytype) !bool {
+        const ok = if (options.calc.overridden(player, 0, .hit)) |val|
             val == .true
         else if (showdown)
             battle.rng.chance(u8, accuracy, 256)
@@ -2318,20 +2882,22 @@ pub const Rolls = struct {
         return ok;
     }
 
-    inline fn criticalHit(battle: anytype, player: Player, rate: u8, options: anytype) !bool {
-        const crit = if (options.calc.overridden(player, .critical_hit)) |val|
+    fn criticalHit(battle: anytype, player: Player, i: u3, rate: u8, options: anytype) !bool {
+        _ = .{ player, options };
+        const crit = if (options.calc.overridden(player, i, .critical_hits)) |val|
             val == .true
         else if (showdown)
             battle.rng.chance(u8, rate, 256)
         else
             battle.rng.next() < rate;
 
-        try options.chance.criticalHit(player, crit, rate);
+        try options.chance.criticalHit(player, i, crit, rate);
         return crit;
     }
 
-    inline fn damage(battle: anytype, player: Player, options: anytype) !u8 {
-        const roll = if (options.calc.overridden(player, .damage)) |val|
+    fn damage(battle: anytype, player: Player, i: u3, options: anytype) !u8 {
+        _ = .{ player, options };
+        const roll = if (options.calc.overridden(player, i, .damages)) |val|
             val
         else roll: {
             if (showdown) break :roll battle.rng.range(u8, 217, 256);
@@ -2342,12 +2908,12 @@ pub const Rolls = struct {
         };
 
         assert(roll >= 217 and roll <= 255);
-        try options.chance.damage(player, roll);
+        try options.chance.damage(player, i, roll);
         return roll;
     }
 
-    inline fn confused(battle: anytype, player: Player, options: anytype) !bool {
-        const cfz = if (options.calc.overridden(player, .confused)) |val|
+    fn confused(battle: anytype, player: Player, options: anytype) !bool {
+        const cfz = if (options.calc.overridden(player, 0, .confused)) |val|
             val == .true
         else if (showdown)
             !battle.rng.chance(u8, 128, 256)
@@ -2358,8 +2924,8 @@ pub const Rolls = struct {
         return cfz;
     }
 
-    inline fn attract(battle: anytype, player: Player, options: anytype) !bool {
-        const cant = if (options.calc.overridden(player, .attract)) |val|
+    fn attract(battle: anytype, player: Player, options: anytype) !bool {
+        const cant = if (options.calc.overridden(player, 0, .attract)) |val|
             val == .true
         else if (showdown)
             battle.rng.chance(u8, 1, 2)
@@ -2370,8 +2936,8 @@ pub const Rolls = struct {
         return cant;
     }
 
-    inline fn paralyzed(battle: anytype, player: Player, options: anytype) !bool {
-        const par = if (options.calc.overridden(player, .paralyzed)) |val|
+    fn paralyzed(battle: anytype, player: Player, options: anytype) !bool {
+        const par = if (options.calc.overridden(player, 0, .paralyzed)) |val|
             val == .true
         else if (showdown)
             battle.rng.chance(u8, 63, 256)
@@ -2382,8 +2948,8 @@ pub const Rolls = struct {
         return par;
     }
 
-    inline fn defrost(battle: anytype, player: Player, options: anytype) !bool {
-        const thaw = if (options.calc.overridden(player, .defrost)) |val|
+    fn defrost(battle: anytype, player: Player, options: anytype) !bool {
+        const thaw = if (options.calc.overridden(player, 0, .defrost)) |val|
             val == .true
         else if (showdown)
             battle.rng.chance(u8, 25, 256)
@@ -2394,9 +2960,9 @@ pub const Rolls = struct {
         return thaw;
     }
 
-    inline fn secondaryChance(battle: anytype, player: Player, rate: u8, options: anytype) !bool {
+    fn secondaryChance(battle: anytype, player: Player, rate: u8, options: anytype) !bool {
         // GLITCH: 100% secondary chance will still fail 1/256 of the time
-        const proc = if (options.calc.overridden(player, .secondary_chance)) |val|
+        const proc = if (options.calc.overridden(player, 0, .secondary_chance)) |val|
             val == .true
         else if (showdown)
             battle.rng.chance(u8, rate, 256)
@@ -2407,8 +2973,8 @@ pub const Rolls = struct {
         return proc;
     }
 
-    inline fn item(battle: anytype, player: Player, options: anytype) !bool {
-        const proc = if (options.calc.overridden(player, .item)) |val|
+    fn item(battle: anytype, player: Player, options: anytype) !bool {
+        const proc = if (options.calc.overridden(player, 0, .item)) |val|
             val == .true
         else if (showdown)
             battle.rng.chance(u8, 30, 256)
@@ -2419,8 +2985,8 @@ pub const Rolls = struct {
         return proc;
     }
 
-    inline fn triAttack(battle: anytype, player: Player, options: anytype) !TriAttack {
-        const status: TriAttack = if (options.calc.overridden(player, .tri_attack)) |val|
+    fn triAttack(battle: anytype, player: Player, options: anytype) !TriAttack {
+        const status: TriAttack = if (options.calc.overridden(player, 0, .tri_attack)) |val|
             @enumFromInt(@intFromEnum(val) - 1)
         else if (showdown)
             @enumFromInt(battle.rng.range(u2, 0, 2))
@@ -2435,8 +3001,8 @@ pub const Rolls = struct {
         return status;
     }
 
-    inline fn present(battle: anytype, player: Player, options: anytype) !u8 {
-        const power = if (options.calc.overridden(player, .present)) |val|
+    fn present(battle: anytype, player: Player, options: anytype) !u8 {
+        const power = if (options.calc.overridden(player, 0, .present)) |val|
             (val - 1) * 40
         else if (showdown) power: {
             const r = battle.rng.range(u8, 0, 10);
@@ -2457,8 +3023,8 @@ pub const Rolls = struct {
         return power;
     }
 
-    inline fn magnitude(battle: anytype, player: Player, options: anytype) !u8 {
-        const num = if (options.calc.overridden(player, .magnitude)) |val|
+    fn magnitude(battle: anytype, player: Player, options: anytype) !u8 {
+        const num: u8 = if (options.calc.overridden(player, 0, .magnitude)) |val|
             val + 3
         else if (showdown) num: {
             const r = battle.rng.range(u8, 0, 100);
@@ -2485,8 +3051,8 @@ pub const Rolls = struct {
         return num;
     }
 
-    inline fn tripleKick(battle: anytype, player: Player, options: anytype) !u2 {
-        const hits = if (options.calc.overridden(player, .triple_kick)) |val|
+    fn tripleKick(battle: anytype, player: Player, options: anytype) !u2 {
+        const hits = if (options.calc.overridden(player, 0, .triple_kick)) |val|
             val
         else if (showdown)
             battle.rng.range(u2, 1, 4)
@@ -2502,13 +3068,12 @@ pub const Rolls = struct {
         return hits;
     }
 
-    inline fn spite(battle: anytype, player: Player, options: anytype) !u8 {
-        const pp = if (options.calc.overridden(player, .spite)) |val|
+    fn spite(battle: anytype, player: Player, options: anytype) !u3 {
+        assert(!showdown);
+        const pp: u3 = if (options.calc.overridden(player, 0, .spite)) |val|
             val + 1
-        else if (showdown)
-            battle.rng.range(u8, 2, 6)
         else
-            (battle.rng.next() & 3) + 2;
+            @intCast((battle.rng.next() & 3) + 2);
 
         assert(pp >= 2 and pp <= 5);
         try options.chance.spite(player, pp);
@@ -2518,11 +3083,11 @@ pub const Rolls = struct {
     // Conversion 2 can at most choose between 7 types (vs. a Grass-type attack)
     var CONVERSION_2: [7]Type = [_]Type{.@"???"} ** 7;
 
-    inline fn conversion2(battle: anytype, player: Player, mtype: Type, options: anytype) !Type {
+    fn conversion2(battle: anytype, player: Player, mtype: Type, options: anytype) !Type {
         var i: u8 = 0;
         const neutral = @intFromEnum(Effectiveness.Neutral);
         assert(mtype != .@"???");
-        const ty: Type = if (options.calc.overridden(player, .conversion_2)) |val|
+        const ty: Type = if (options.calc.overridden(player, 0, .conversion_2)) |val|
             @enumFromInt(@intFromEnum(val) - 1)
         else if (showdown) ty: {
             for (Type.SHOWDOWN) |t| {
@@ -2552,11 +3117,11 @@ pub const Rolls = struct {
         return ty;
     }
 
-    inline fn protect(battle: anytype, player: Player, count: u8, options: anytype) !bool {
+    fn protect(battle: anytype, player: Player, count: u8, options: anytype) !bool {
         assert(count <= 8);
         const num = if (count == 8) 0 else @as(u8, 255) >> @intCast(count);
 
-        const ok = if (options.calc.overridden(player, .protect)) |val|
+        const ok = if (options.calc.overridden(player, 0, .protect)) |val|
             val == .true
         else if (showdown)
             battle.rng.chance(u8, num, 255)
@@ -2578,7 +3143,7 @@ pub const Rolls = struct {
         const moves = active.moves;
 
         // TODO: consider throwing error instead of rerolling?
-        const overridden = if (options.calc.overridden(player, .move_slot)) |val|
+        const overridden = if (options.calc.overridden(player, 0, .move_slot)) |val|
             if (convertible(active, moves[val - 1].id)) val else null
         else
             null;
@@ -2615,7 +3180,7 @@ pub const Rolls = struct {
         const moves = active.moves;
 
         // TODO: consider throwing error instead of rerolling?
-        const overridden = if (options.calc.overridden(player, .move_slot)) |val|
+        const overridden = if (options.calc.overridden(player, 0, .move_slot)) |val|
             if (val != mslot and Move.get(moves[val - 1].id).extra.sleep_talk) val else null
         else
             null;
@@ -2646,7 +3211,7 @@ pub const Rolls = struct {
         return slot;
     }
 
-    inline fn forceSwitch(
+    fn forceSwitch(
         battle: anytype,
         player: Player,
         slots: []u4,
@@ -2659,7 +3224,7 @@ pub const Rolls = struct {
         assert(n > 0 and n <= 6);
 
         // TODO: consider throwing error instead of rerolling?
-        const overridden = if (options.calc.overridden(player, .force_switch)) |val| val: {
+        const overridden = if (options.calc.overridden(player, 0, .force_switch)) |val| val: {
             for (slots) |slot| if (slot == val) break :val if (foe.get(slot).hp > 0) val else null;
             break :val null;
         } else null;
@@ -2684,8 +3249,8 @@ pub const Rolls = struct {
 
     const DISTRIBUTION = [_]u3{ 2, 2, 2, 3, 3, 3, 4, 5 };
 
-    inline fn multiHit(battle: anytype, player: Player, options: anytype) !u3 {
-        const n: u3 = if (options.calc.overridden(player, .multi_hit)) |val|
+    fn multiHit(battle: anytype, player: Player, options: anytype) !u3 {
+        const n: u3 = if (options.calc.overridden(player, 0, .multi_hit)) |val|
             @intCast(val)
         else if (showdown)
             DISTRIBUTION[battle.rng.range(u3, 0, DISTRIBUTION.len)]
@@ -2699,8 +3264,8 @@ pub const Rolls = struct {
         return n;
     }
 
-    inline fn psywave(battle: anytype, player: Player, max: u8, options: anytype) !u8 {
-        const power = if (options.calc.overridden(player, .psywave)) |val|
+    fn psywave(battle: anytype, player: Player, max: u8, options: anytype) !u8 {
+        const power = if (options.calc.overridden(player, 0, .psywave)) |val|
             val
         else if (showdown)
             battle.rng.range(u8, 1, max)
@@ -2716,27 +3281,28 @@ pub const Rolls = struct {
         return power;
     }
 
-    inline fn metronome(battle: anytype, player: Player, options: anytype) !Move {
-        const moves = battle.get(player).active.moves;
+    fn metronome(battle: anytype, player: Player, options: anytype) !Move {
+        const moves = battle.side(player).active.moves;
 
         var n: u2 = 0;
         for (moves) |m| {
-            if (m == .None) break;
-            if (Move.get(m).metronome) n += 1;
+            if (m.id == .None) break;
+            if (Move.get(m.id).extra.metronome) n += 1;
         }
 
         // TODO: consider throwing error instead of rerolling?
-        const overridden = if (options.calc.overridden(player, .metronome)) |val| val: {
+        const overridden = if (options.calc.overridden(player, 0, .metronome)) |val| val: {
             for (moves) |m| if (m.id == val) break :val null;
             break :val val;
         } else null;
 
         const move: Move = overridden orelse move: {
             if (showdown) {
-                var r = battle.rng.range(u8, 0, Move.METRONOME.len - n);
+                var r = battle.rng.range(u8, 0, @as(u8, @intCast(Move.METRONOME.len - n)));
                 for (moves) |m| {
-                    if (m == .None or @intFromEnum(m) > @intFromEnum(Move.METRONOME[r])) break;
-                    if (Move.get(m).metronome) r -= 1;
+                    if (m.id == .None) break;
+                    if (@intFromEnum(m.id) > @intFromEnum(Move.METRONOME[r])) break;
+                    if (Move.get(m.id).extra.metronome) r -= 1;
                 }
                 break :move Move.METRONOME[r];
             } else {
@@ -2751,13 +3317,13 @@ pub const Rolls = struct {
             }
         };
 
-        assert(Move.get(move).metronome);
+        assert(Move.get(move).extra.metronome);
         try options.chance.metronome(player, move, n);
         return move;
     }
 
-    inline fn sleepDuration(battle: anytype, player: Player, options: anytype) u3 {
-        const duration: u3 = if (options.calc.overridden(player, .duration)) |val|
+    fn sleepDuration(battle: anytype, player: Player, options: anytype) u3 {
+        const duration: u3 = if (options.calc.overridden(player, 0, .duration)) |val|
             @intCast(val)
         else if (showdown)
             battle.rng.range(u3, 1, 7)
@@ -2769,12 +3335,12 @@ pub const Rolls = struct {
         };
 
         assert(duration >= 1 and duration <= 6);
-        options.chance.duration(.sleep, player, player.foe(), duration);
+        options.chance.duration(player, duration);
         return duration + 1;
     }
 
-    inline fn confusionDuration(battle: anytype, player: Player, self: bool, options: anytype) u3 {
-        const duration: u3 = if (options.calc.overridden(player, .duration)) |val|
+    fn confusionDuration(battle: anytype, player: Player, self: bool, options: anytype) u3 {
+        const duration: u3 = if (options.calc.overridden(player, 0, .duration)) |val|
             @intCast(val)
         else if (showdown)
             // Pokémon Showdown incorrectly uses the same duration for self-confusion
@@ -2783,16 +3349,16 @@ pub const Rolls = struct {
             @intCast((battle.rng.next() & if (self) 1 else 3) + 2);
 
         assert(duration >= 2 and duration <= if (!showdown and self) 3 else 5);
-        options.chance.duration(.confusion, player, if (self) player else player.foe(), duration);
+        options.chance.duration(player, duration);
         return duration;
     }
 
-    inline fn disableDuration(battle: anytype, player: Player, options: anytype) u4 {
-        const duration: u4 = if (options.calc.overridden(player, .duration)) |val|
+    fn disableDuration(battle: anytype, player: Player, options: anytype) u4 {
+        const duration: u3 = if (options.calc.overridden(player, 0, .duration)) |val|
             @intCast(val)
         else if (showdown)
             // Pokémon Showdown incorrectly inherits Generation III's Disable duration
-            battle.rng.range(u4, 2, 6)
+            battle.rng.range(u3, 2, 6)
         else duration: {
             while (true) {
                 const r = battle.rng.next() & 7;
@@ -2801,12 +3367,12 @@ pub const Rolls = struct {
         };
 
         assert(duration >= 2 and duration <= (if (showdown) 5 else 7));
-        options.chance.duration(.disable, player, player.foe(), duration);
+        options.chance.duration(player, duration);
         return duration;
     }
 
-    inline fn attackingDuration(battle: anytype, player: Player, options: anytype) u3 {
-        const duration: u3 = if (options.calc.overridden(player, .duration)) |val|
+    fn attackingDuration(battle: anytype, player: Player, options: anytype) u3 {
+        const duration: u3 = if (options.calc.overridden(player, 0, .duration)) |val|
             @intCast(val)
         else if (showdown)
             battle.rng.range(u3, 2, 4)
@@ -2814,12 +3380,12 @@ pub const Rolls = struct {
             @intCast((battle.rng.next() & 1) + 2); // BUG: thrash is + 1 not +2
 
         assert(duration >= 2 and duration <= 3);
-        options.chance.duration(.attacking, player, player, duration);
+        options.chance.duration(player, duration);
         return duration;
     }
 
-    inline fn bindingDuration(battle: anytype, player: Player, options: anytype) u3 {
-        const duration: u3 = (if (options.calc.overridden(player, .duration)) |val|
+    fn bindingDuration(battle: anytype, player: Player, options: anytype) u3 {
+        const duration: u3 = (if (options.calc.overridden(player, 0, .duration)) |val|
             @intCast(val)
         else if (showdown)
             // TODO: PS does range(3, 6) here which after subtracting 1 is actually 2-4 not 2-5!
@@ -2828,13 +3394,13 @@ pub const Rolls = struct {
             @intCast(battle.rng.next() & 3 + 2));
 
         assert(duration >= 2 and duration <= 5);
-        options.chance.duration(.binding, player, player.foe(), duration);
+        options.chance.duration(player, duration);
         return duration + 1;
     }
 
     // TODO: consider sharing implementation with bindingDuration
-    inline fn encoreDuration(battle: anytype, player: Player, options: anytype) u3 {
-        const duration: u3 = (if (options.calc.overridden(player, .duration)) |val|
+    fn encoreDuration(battle: anytype, player: Player, options: anytype) u3 {
+        const duration: u3 = (if (options.calc.overridden(player, 0, .duration)) |val|
             @intCast(val)
         else if (showdown)
             battle.rng.range(u3, 2, 6)
@@ -2842,7 +3408,7 @@ pub const Rolls = struct {
             @intCast(battle.rng.next() & 3 + 2));
 
         assert(duration >= 2 and duration <= 5);
-        options.chance.duration(.encore, player, player.foe(), duration);
+        options.chance.duration(player, duration);
         return duration + 1;
     }
 };
@@ -2955,7 +3521,7 @@ pub fn choices(battle: anytype, player: Player, request: Choice.Type, out: []Cho
         .Move => {
             const side = battle.side(player);
 
-            var active = &side.active;
+            const active = &side.active;
             const stored = side.stored();
 
             // While players are not given any input options on the cartridge in these cases,
@@ -2975,7 +3541,7 @@ pub fn choices(battle: anytype, player: Player, request: Choice.Type, out: []Cho
             }
 
             var slot: u4 = 2;
-            while (!active.volatiles.trapped and slot <= 6) : (slot += 1) {
+            while (!active.volatiles.Trapped and slot <= 6) : (slot += 1) {
                 const id = side.order[slot - 1];
                 if (id == 0 or side.pokemon[id - 1].hp == 0) continue;
                 out[n] = .{ .type = .Switch, .data = slot };