@pkmn/engine 0.1.0-dev.a02611a4 → 0.1.0-dev.a15b6c17

package/src/lib/gen1/chance.zig

@@ -1,23 +1,26 @@
-const std = @import("std");
-
-const assert = std.debug.assert;
-const print = std.debug.print;
-
-const expect = std.testing.expect;
-const expectEqual = std.testing.expectEqual;
-
 const DEBUG = @import("../common/debug.zig").print;
+
+const array = @import("../common/array.zig");
+const common = @import("../common/data.zig");
+const data = @import("data.zig");
+const optional = @import("../common/optional.zig");
 const options = @import("../common/options.zig");
 const rational = @import("../common/rational.zig");
+const std = @import("std");
 const util = @import("../common/util.zig");
 
-const Player = @import("../common/data.zig").Player;
-const Optional = @import("../common/optional.zig").Optional;
-
-const Move = @import("data.zig").Move;
-const MoveSlot = @import("data.zig").MoveSlot;
-
+const Array = array.Array;
+const assert = std.debug.assert;
 const enabled = options.chance;
+const expect = std.testing.expect;
+const expectEqual = std.testing.expectEqual;
+const isPointerTo = util.isPointerTo;
+const Move = data.Move;
+const MoveSlot = data.MoveSlot;
+const Optional = optional.Optional;
+const Player = common.Player;
+const PointerType = util.PointerType;
+const print = std.debug.print;
 const showdown = options.showdown;
 
 /// Actions taken by a hypothetical "chance player" that convey information about which RNG events
@@ -35,19 +38,13 @@ pub const Actions = extern struct {
     }
 
     /// Returns the `Action` for the given `player`.
-    pub inline fn get(self: anytype, player: Player) util.PointerType(@TypeOf(self), Action) {
-        assert(@typeInfo(@TypeOf(self)).Pointer.child == Actions);
+    pub fn get(self: anytype, player: Player) PointerType(@TypeOf(self), Action) {
+        assert(isPointerTo(self, Actions));
         return if (player == .P1) &self.p1 else &self.p2;
     }
 
-    /// Perform a reset by clearing fields which should not persist across updates.
-    pub inline fn reset(self: *Actions) void {
-        self.p1.reset();
-        self.p2.reset();
-    }
-
     /// Returns true if `a` is equal to `b`.
-    pub inline fn eql(a: Actions, b: Actions) bool {
+    pub fn eql(a: Actions, b: Actions) bool {
         return @as(u128, @bitCast(a)) == @as(u128, @bitCast(b));
     }
 
@@ -55,20 +52,15 @@ pub const Actions = extern struct {
     /// same shape if they have the same fields set (though those fields need not necessarily be
     /// set to the same value).
     pub fn matches(a: Actions, b: Actions) bool {
-        inline for (@typeInfo(Actions).Struct.fields) |player| {
-            inline for (@typeInfo(Action).Struct.fields) |field| {
+        inline for (@typeInfo(Actions).@"struct".fields) |player| {
+            inline for (@typeInfo(Action).@"struct".fields) |field| {
                 const a_val = @field(@field(a, player.name), field.name);
                 const b_val = @field(@field(b, player.name), field.name);
 
                 switch (@typeInfo(@TypeOf(a_val))) {
-                    .Struct => inline for (@typeInfo(@TypeOf(a_val)).Struct.fields) |f| {
-                        if ((@field(a_val, f.name) > 0) != (@field(b_val, f.name) > 0)) {
-                            return false;
-                        }
-                    },
-                    .Enum => if ((@intFromEnum(a_val) > 0) != (@intFromEnum(b_val) > 0))
+                    .@"enum" => if ((@intFromEnum(a_val) > 0) != (@intFromEnum(b_val) > 0))
                         return false,
-                    .Int => if ((a_val > 0) != (b_val > 0)) return false,
+                    .int => if ((a_val > 0) != (b_val > 0)) return false,
                     else => unreachable,
                 }
             }
@@ -76,7 +68,26 @@ pub const Actions = extern struct {
         return true;
     }
 
-    pub fn fmt(self: Actions, writer: anytype, shape: bool) !void {
+    /// TODO
+    pub fn matchesAny(a: Actions, bs: []Actions, i: usize) bool {
+        for (bs, 0..) |b, j| {
+            // TODO: is skipping this redundant check worth it?
+            if (i == j) continue;
+            if (b.matches(a)) return true;
+        }
+        return false;
+    }
+
+    /// TODO
+    pub fn relax(actions: Actions) Actions {
+        if (!options.overwrite) return actions;
+        var a = actions;
+        if (a.p1.confusion == .overwritten) a.p1.confusion = .continuing;
+        if (a.p2.confusion == .overwritten) a.p2.confusion = .continuing;
+        return a;
+    }
+
+    pub fn fmt(self: Actions, writer: *std.Io.Writer, shape: bool) !void {
         try writer.writeAll("<P1 = ");
         try self.p1.fmt(writer, shape);
         try writer.writeAll(", P2 = ");
@@ -84,8 +95,7 @@ pub const Actions = extern struct {
         try writer.writeAll(">");
     }
 
-    pub fn format(a: Actions, comptime f: []const u8, o: std.fmt.FormatOptions, w: anytype) !void {
-        _ = .{ f, o };
+    pub fn format(a: Actions, w: *std.Io.Writer) !void {
         try fmt(a, w, false);
     }
 };
@@ -94,9 +104,6 @@ test Actions {
     const a: Actions = .{ .p1 = .{ .hit = .true, .critical_hit = .false, .damage = 245 } };
     const b: Actions = .{ .p1 = .{ .hit = .false, .critical_hit = .true, .damage = 246 } };
     const c: Actions = .{ .p1 = .{ .hit = .true } };
-    const d: Actions = .{ .p2 = .{ .hit = .true, .durations = .{ .sleep = 2 } } };
-    const e: Actions = .{ .p2 = .{ .hit = .false, .durations = .{ .sleep = 4 } } };
-    const f: Actions = .{ .p1 = .{ .hit = .false, .durations = .{ .sleep = 4 } } };
 
     try expect(a.eql(a));
     try expect(!a.eql(b));
@@ -109,13 +116,48 @@ test Actions {
     try expect(b.matches(a));
     try expect(!a.matches(c));
     try expect(!c.matches(a));
-    try expect(d.matches(e));
-    try expect(!d.matches(f));
+}
+
+/// Observation made about a duration - whether the duration has started, been continued, or ended.
+pub fn Observation(comptime field: Duration.Field) type {
+    return switch (field) {
+        .attacking, .binding => enum(u2) {
+            started,
+            continuing,
+            ended,
+        },
+        .sleep, .disable => enum(u3) {
+            started,
+            continuing,
+            ended,
+            // TODO haze support
+            unused1,
+            unused2,
+            unused3,
+            unused4,
+        },
+        .confusion => enum(u4) {
+            started,
+            continuing,
+            ended,
+            /// An indicator that an existing confusion duration has been overwritten by a new
+            /// confusion duration due to a Thrashing move ending ("hidden" confusion). This is not
+            /// immediately observable to an opponent, to compute probabilities from an opponent's
+            /// point of view based solely on public information extra work must be done to correct
+            /// for the information leak
+            overwritten,
+            // TODO haze support
+            unused1,
+            unused2,
+            unused3,
+            unused4,
+        },
+    };
 }
 
 /// Information about the RNG that was observed during a Generation I battle `update` for a
 /// single player.
-pub const Action = packed struct {
+pub const Action = packed struct(u64) {
     /// If not 0, the roll to be returned Rolls.damage.
     damage: u8 = 0,
 
@@ -137,14 +179,25 @@ pub const Action = packed struct {
     /// or Rolls.{sleepDuration,disableDuration,confusionDuration,attackingDuration} otherwise.
     duration: u4 = 0,
 
-    /// Observed values of various durations. Does not influence future RNG calls. TODO
-    durations: Duration = .{},
+    /// TODO
+    sleep: Optional(Observation(.sleep)) = .None,
+    /// TODO
+    confusion: Optional(Observation(.confusion)) = .None,
+    /// TODO
+    disable: Optional(Observation(.disable)) = .None,
+    /// TODO
+    attacking: Optional(Observation(.attacking)) = .None,
+    /// TODO
+    binding: Optional(Observation(.binding)) = .None,
 
     /// If not 0, the move slot (1-4) to return in Rolls.moveSlot. If present as an override,
     /// invalid values (eg. due to empty move slots or 0 PP) will be ignored.
-    move_slot: u4 = 0,
+    move_slot: u3 = 0,
     /// If not 0, the value (2-5) to return for Rolls.distribution for multi hit.
-    multi_hit: u4 = 0,
+    multi_hit: u3 = 0,
+
+    /// TODO
+    pp: u4 = 0,
 
     /// If not 0, psywave - 1 should be returned as the damage roll for Rolls.psywave.
     psywave: u8 = 0,
@@ -152,43 +205,21 @@ pub const Action = packed struct {
     /// If not None, the Move to return for Rolls.metronome.
     metronome: Move = .None,
 
-    pub const DURATIONS: u64 = 0x000000FFFF000000;
-
     pub const Field = std.meta.FieldEnum(Action);
 
-    comptime {
-        assert(@sizeOf(Action) == 8);
-    }
-
-    /// Perform a reset by clearing fields which should not persist across updates.
-    pub inline fn reset(self: *Action) void {
-        self.* = @bitCast(@as(u64, @bitCast(self.*)) & DURATIONS);
-    }
-
-    pub fn format(a: Action, comptime f: []const u8, o: std.fmt.FormatOptions, w: anytype) !void {
-        _ = .{ f, o };
+    pub fn format(a: Action, w: *std.Io.Writer) !void {
         try fmt(a, w, false);
     }
 
-    pub fn fmt(self: Action, writer: anytype, shape: bool) !void {
+    const SYMBOLS = [_][]const u8{ "+", "", "-", "#" };
+
+    pub fn fmt(self: Action, writer: *std.Io.Writer, shape: bool) !void {
         try writer.writeByte('(');
         var printed = false;
-        inline for (@typeInfo(Action).Struct.fields) |field| {
+        inline for (@typeInfo(Action).@"struct".fields) |field| {
             const val = @field(self, field.name);
             switch (@typeInfo(@TypeOf(val))) {
-                .Struct => inline for (@typeInfo(@TypeOf(val)).Struct.fields) |f| {
-                    const v = @field(val, f.name);
-                    if (v != 0) {
-                        if (printed) try writer.writeAll(", ");
-                        if (shape) {
-                            try writer.print("{s}:?", .{f.name});
-                        } else {
-                            try writer.print("{s}:{d}", .{ f.name, v });
-                        }
-                        printed = true;
-                    }
-                },
-                .Enum => if (val != .None) {
+                .@"enum" => if (val != .None) {
                     if (printed) try writer.writeAll(", ");
                     if (shape) {
                         try writer.print("{s}:?", .{field.name});
@@ -197,12 +228,14 @@ pub const Action = packed struct {
                             if (val == .false) "!" else "",
                             field.name,
                         });
+                    } else if (@TypeOf(val) != Move and @TypeOf(val) != Optional(Player)) {
+                        try writer.print("{s}{s}", .{ SYMBOLS[@intFromEnum(val) - 1], field.name });
                     } else {
                         try writer.print("{s}:{s}", .{ field.name, @tagName(val) });
                     }
                     printed = true;
                 },
-                .Int => if (val != 0) {
+                .int => if (val != 0) {
                     if (printed) try writer.writeAll(", ");
                     if (shape) {
                         try writer.print("{s}:?", .{field.name});
@@ -218,47 +251,75 @@ pub const Action = packed struct {
     }
 };
 
-test Action {
-    var a = Action{ .hit = .true, .durations = .{ .sleep = 3 }, .damage = 225 };
-    a.reset();
-
-    try expectEqual(Action{ .hit = .None, .durations = .{ .sleep = 3 }, .damage = 0 }, a);
-}
-
 /// TODO
 pub const Durations = extern struct {
-    /// Information about the durations for Player 1.
+    /// TODO
     p1: Duration = .{},
-    /// Information about the durations for Player 2.
+    /// TODO
     p2: Duration = .{},
 
     comptime {
-        assert(@sizeOf(Durations) == 4);
+        assert(@sizeOf(Durations) == 8);
+    }
+
+    /// TODO
+    pub fn get(self: anytype, player: Player) PointerType(@TypeOf(self), Duration) {
+        assert(isPointerTo(self, Durations));
+        return if (player == .P1) &self.p1 else &self.p2;
+    }
+
+    pub fn format(self: Durations, writer: *std.Io.Writer) !void {
+        try writer.print("[P1 = {f}, P2 = {f}]", .{ self.p1, self.p2 });
     }
 };
 
-/// Observed values for various durations that need to be tracked in order to properly
-/// deduplicate transitions with a primary key. TODO
-pub const Duration = packed struct {
-    /// The number of turns a Pokémon has been observed to be sleeping.
-    sleep: u3 = 0,
-    /// The number of turns a Pokémon has been observed to be confused.
+pub const Sleeps = Array(6, u3);
+
+/// TODO
+pub const Duration = packed struct(u32) {
+    sleeps: Sleeps.T = 0,
     confusion: u3 = 0,
-    /// The number of turns a Pokémon has been observed to be disabled.
     disable: u4 = 0,
-    /// The number of turns a Pokémon has been observed to be attacking.
     attacking: u3 = 0,
-    /// The number of turns a Pokémon has been observed to be binding their opponent.
     binding: u3 = 0,
 
-    pub const Field = std.meta.FieldEnum(Duration);
+    _: u1 = 0,
 
-    comptime {
-        assert(@sizeOf(Duration) == 2);
+    pub const Field = enum { attacking, binding, sleep, disable, confusion };
+
+    pub fn format(
+        self: Duration,
+        writer: *std.Io.Writer,
+    ) !void {
+        try writer.writeByte('(');
+        var printed = false;
+        inline for (@typeInfo(Duration).@"struct".fields) |field| {
+            const val = @field(self, field.name);
+            switch (@typeInfo(@TypeOf(val))) {
+                .int => if (val != 0) {
+                    if (printed) try writer.writeAll(", ");
+                    if (comptime std.mem.eql(u8, field.name, "sleeps")) {
+                        try writer.print("{s}:[", .{field.name});
+                        for (0..6) |i| {
+                            if (i != 0) try writer.writeByte(',');
+                            try writer.print("{d}", .{Sleeps.get(val, i)});
+                        }
+                        try writer.writeAll("]");
+                    } else {
+                        try writer.print("{s}:{d}", .{ field.name, val });
+                    }
+                    printed = true;
+                },
+                else => unreachable,
+            }
+        }
+        try writer.writeByte(')');
     }
 };
 
-pub const Commit = enum { hit, miss, binding };
+pub const Commit = enum { hit, miss, binding, err, glitch };
+
+const uN = if (options.miss) u8 else u9;
 
 /// Tracks chance actions and their associated probability during a Generation I battle update when
 /// `options.chance` is enabled.
@@ -271,14 +332,8 @@ pub fn Chance(comptime Rational: type) type {
         /// The actions taken by a hypothetical "chance player" that convey information about which
         /// RNG events were observed during a battle `update`.
         actions: Actions = .{},
-
-        // Tracks the observed sleep durations for the Pokémon in both player's parties. Unlike
-        // other durations which are all tied to volatiles, sleep's counter persists through
-        // switching and so we must store it here. The indices of these arrays correspond to the
-        // `order` field of a Side. This information could be stored in actions but size is a
-        // concern so this is tracked separately as actions only purports to track RNG events
-        // observed during a single `update` (not across updates).
-        sleeps: [2][6]u3 = .{ .{0} ** 6, .{0} ** 6 },
+        /// TODO
+        durations: Durations = .{},
 
         // In many cases on both the cartridge and on Pokémon Showdown rolls are made even though
         // later checks render their result irrelevant (missing when the target is actually immune,
@@ -296,16 +351,13 @@ pub fn Chance(comptime Rational: type) type {
         //
         // Finally, because each player's actions are processed sequentially we only need a single
         // shared structure to track this information (though it needs to be cleared appropriately)
-        pending: if (showdown) struct {
-            hit: bool = false,
-            hit_probablity: u8 = 0,
-        } else struct {
+        pending: if (showdown) struct {} else struct {
             crit: bool = false,
             crit_probablity: u8 = 0,
             damage_roll: u8 = 0,
             hit: bool = false,
-            hit_probablity: u8 = 0,
-            binding: u8 = 0,
+            hit_probablity: uN = 0,
+            glitch: bool = false,
         } = .{},
 
         /// Possible error returned by operations tracking chance probability.
@@ -313,86 +365,90 @@ pub fn Chance(comptime Rational: type) type {
 
         /// Convenience helper to clear fields which typically should be cleared between updates.
         pub fn reset(self: *Self) void {
+            if (!enabled) return;
+
             self.probability.reset();
-            self.actions.reset();
+            self.actions = .{};
             self.pending = .{};
         }
 
         pub fn commit(self: *Self, player: Player, kind: Commit) Error!void {
+            if (!enabled) return;
+
+            assert(!showdown);
+
+            if (kind == .glitch and !self.pending.glitch) return;
+
             var action = self.actions.get(player);
 
-            // We need to handle binding specially because we still need to commit it when attacking
-            // into a Pokémon that is immune
-            if (!showdown) {
-                if (kind != .miss and self.pending.binding != 0) {
-                    assert(action.duration == 0);
-                    action.duration = @intCast(self.pending.binding);
-                    assert(action.durations.binding == 0);
-                    action.durations.binding = 1;
-                }
-                if (kind == .binding) return;
-            } else assert(kind != .binding);
+            if (kind == .err and self.pending.crit_probablity != 0) {
+                try self.probability.update(self.pending.crit_probablity, 256);
+                action.critical_hit = if (self.pending.crit) .true else .false;
+                return;
+            }
 
             // Always commit the hit result if we make it here (commit won't be called at all if the
-            // target is immune/behind a sub/etc)
+            // target is immune*/behind a sub/etc)
             if (self.pending.hit_probablity != 0) {
                 try self.probability.update(self.pending.hit_probablity, 256);
                 action.hit = if (self.pending.hit) .true else .false;
             }
 
-            if (showdown) return;
-
-            // If the move actually lands we can commit any past critical hit / damage rolls. We
-            // avoid updating anything if there wasn't a damage roll as any "critical hit" not tied
-            // to a damage roll is actually a no-op
-            if (kind == .hit and self.pending.damage_roll > 0) {
-                assert(!self.pending.crit or self.pending.crit_probablity > 0);
+            // If the move actually lands we can commit any past critical hit / damage rolls. Note
+            // we can't rely on the presence or absence of a damage roll to determine whether a
+            // "critical hit" was spurious or not as moves that do 1 or less damage don't roll for
+            // damage but can still crit (instead, whether or not a roll is deemed to be a no-op is
+            // passed to the critical hit helper).
+            //
+            // There is a special edge case with the division-by-zero freeze where we need to commit
+            // the status of critical hit roll the occured before the move missed to avoid missing
+            // out on the possibility that the alternative branch encountered an error
+            if (kind != .hit and !self.pending.glitch) {
+                return assert(!self.pending.crit or self.pending.crit_probablity > 0);
+            }
 
-                if (self.pending.crit_probablity != 0) {
-                    try self.probability.update(self.pending.crit_probablity, 256);
-                    action.critical_hit = if (self.pending.crit) .true else .false;
-                }
+            if (self.pending.crit_probablity != 0) {
+                try self.probability.update(self.pending.crit_probablity, 256);
+                action.critical_hit = if (self.pending.crit) .true else .false;
+            } else assert(!self.pending.glitch);
 
+            if (self.pending.damage_roll > 0 and (!self.pending.glitch or self.pending.hit)) {
                 try self.probability.update(1, 39);
                 action.damage = self.pending.damage_roll;
             }
         }
 
-        pub fn clearPending(self: *Self) void {
+        pub fn glitch(self: *Self) void {
             if (!enabled) return;
 
-            self.pending = .{};
+            assert(!showdown);
+            self.pending.glitch = true;
         }
 
-        pub fn clearDurations(self: *Self, player: Player, haze: ?bool) void {
+        pub fn clearPending(self: *Self) void {
             if (!enabled) return;
 
-            var action = self.actions.get(player);
-            if (haze) |status| {
-                if (status) action.durations.sleep = 0;
-                action.durations.confusion = 0;
-                action.durations.disable = 0;
-            } else {
-                action.durations.attacking = 0;
-                action.durations.binding = 0;
-            }
+            assert(!showdown);
+            self.pending = .{};
         }
 
-        pub fn switched(self: *Self, player: Player, in: u8, out: u8) void {
+        pub fn switched(self: *Self, player: Player, slot: u8) void {
             if (!enabled) return;
 
-            assert(in >= 1 and in <= 6);
-            assert(out >= 1 and out <= 6);
+            assert(slot >= 1 and slot <= 6);
 
-            var action = self.actions.get(player);
+            var d = self.durations.get(player);
 
-            const slp = action.durations.sleep;
-            action.durations = .{};
+            const out = Sleeps.get(d.sleeps, 0);
+            d.sleeps = Sleeps.set(d.sleeps, 0, Sleeps.get(d.sleeps, slot - 1));
+            d.sleeps = Sleeps.set(d.sleeps, slot - 1, out);
 
-            self.sleeps[@intFromEnum(player)][out - 1] = slp;
-            action.durations.sleep = @intCast(self.sleeps[@intFromEnum(player)][in - 1]);
+            d.confusion = 0;
+            d.disable = 0;
+            d.attacking = 0;
+            d.binding = 0;
 
-            self.actions.get(player.foe()).durations.binding = 0;
+            self.durations.get(player.foe()).binding = 0;
         }
 
         pub fn speedTie(self: *Self, p1: bool) Error!void {
@@ -403,12 +459,17 @@ pub fn Chance(comptime Rational: type) type {
             self.actions.p2.speed_tie = self.actions.p1.speed_tie;
         }
 
-        pub fn hit(self: *Self, ok: bool, accuracy: u8) void {
+        pub fn hit(self: *Self, player: Player, ok: bool, accuracy: uN) Error!void {
             if (!enabled) return;
 
             const p = if (ok) accuracy else @as(u8, @intCast(256 - @as(u9, accuracy)));
-            self.pending.hit = ok;
-            self.pending.hit_probablity = p;
+            if (showdown) {
+                try self.probability.update(p, 256);
+                self.actions.get(player).hit = if (ok) .true else .false;
+            } else {
+                self.pending.hit = ok;
+                self.pending.hit_probablity = p;
+            }
         }
 
         pub fn criticalHit(self: *Self, player: Player, crit: bool, rate: u8) Error!void {
@@ -486,108 +547,188 @@ pub fn Chance(comptime Rational: type) type {
             self.actions.get(player).multi_hit = n;
         }
 
-        pub fn duration(
+        pub fn duration(self: *Self, player: Player, turns: u4) void {
+            if (!enabled) return;
+
+            self.actions.get(player).duration = if (options.key) 2 else turns;
+        }
+
+        pub fn observe(
             self: *Self,
-            comptime field: Duration.Field,
+            comptime field: Action.Field,
             player: Player,
-            target: Player,
-            turns: u4,
+            obs: Optional(Observation(.confusion)),
         ) void {
             if (!enabled) return;
 
-            if (!showdown and field == .binding) {
-                self.pending.binding = if (options.key) 1 else turns;
-            } else {
-                var durations = &self.actions.get(target).durations;
-                assert(@field(durations, @tagName(field)) == 0 or
-                    (field == .confusion and player == target));
-                @field(durations, @tagName(field)) = 1;
-                self.actions.get(player).duration = if (options.key) 1 else turns;
+            var a = self.actions.get(player);
+            const val = @field(a, @tagName(field));
+            switch (obs) {
+                .overwritten => {
+                    assert(field == .confusion);
+                    assert(val == .started or val == .continuing);
+                    assert(a.duration > 0);
+                    a.confusion = obs;
+                    self.durations.get(player).confusion = 1;
+                },
+                .None => {
+                    @field(a, @tagName(field)) = .None;
+                    if (field == .sleep) {
+                        var d = self.durations.get(player);
+                        d.sleeps = Sleeps.set(d.sleeps, 0, 0);
+                    } else {
+                        @field(self.durations.get(player), @tagName(field)) = 0;
+                    }
+                },
+                .started => {
+                    assert(val == .None or val == .ended);
+                    assert(switch (field) {
+                        .confusion => a.duration > 0 or self.actions.get(player.foe()).duration > 0,
+                        .sleep, .disable => self.actions.get(player.foe()).duration > 0,
+                        else => a.duration > 0,
+                    });
+                    @field(a, @tagName(field)) = .started;
+                    if (field == .sleep) {
+                        var d = self.durations.get(player);
+                        d.sleeps = Sleeps.set(d.sleeps, 0, 1);
+                    } else {
+                        @field(self.durations.get(player), @tagName(field)) = 1;
+                    }
+                },
+                else => unreachable,
             }
         }
 
-        pub fn sleep(self: *Self, player: Player, turns: u4) Error!void {
+        pub fn sleep(self: *Self, player: Player, obs: Optional(Observation(.sleep))) Error!void {
             if (!enabled) return;
 
-            var durations = &self.actions.get(player).durations;
-            const n = durations.sleep;
-            if (turns == 0) {
+            var a = self.actions.get(player);
+            assert(a.sleep == .None or a.sleep == .started);
+            a.sleep = obs;
+
+            var d = self.durations.get(player);
+            const n = Sleeps.get(d.sleeps, 0);
+
+            if (obs == .None) {
+                d.sleeps = Sleeps.set(d.sleeps, 0, 0);
+            } else if (obs == .ended) {
                 assert(n >= 1 and n <= 7);
                 if (n != 7) try self.probability.update(1, 8 - @as(u4, n));
-                durations.sleep = 0;
+                d.sleeps = Sleeps.set(d.sleeps, 0, 0);
             } else {
+                assert(obs == .continuing);
                 assert(n >= 1 and n < 7);
                 try self.probability.update(8 - @as(u4, n) - 1, 8 - @as(u4, n));
-                durations.sleep += 1;
+                d.sleeps = Sleeps.set(d.sleeps, 0, n + 1);
             }
         }
 
-        pub fn disable(self: *Self, player: Player, turns: u4) Error!void {
+        pub fn confusion(
+            self: *Self,
+            player: Player,
+            obs: Optional(Observation(.confusion)),
+        ) Error!void {
             if (!enabled) return;
 
-            var durations = &self.actions.get(player).durations;
-            const n = durations.disable;
-            if (turns == 0) {
-                assert(n >= 1 and n <= 8);
-                if (n != 8) try self.probability.update(1, 9 - @as(u4, n));
-                durations.disable = 0;
-            } else {
-                assert(n >= 1 and n < 8);
-                try self.probability.update(9 - @as(u4, n) - 1, 9 - @as(u4, n));
-                durations.disable += 1;
-            }
-        }
+            var a = self.actions.get(player);
+            assert(a.confusion == .None or a.confusion == .started);
+            a.confusion = obs;
 
-        pub fn confusion(self: *Self, player: Player, turns: u4) Error!void {
-            if (!enabled) return;
+            var d = self.durations.get(player);
+            const n = d.confusion;
 
-            var durations = &self.actions.get(player).durations;
-            const n = durations.confusion;
-            if (turns == 0) {
+            if (obs == .ended) {
                 assert(n >= 2 and n <= 5);
                 if (n != 5) try self.probability.update(1, 6 - @as(u4, n));
-                durations.confusion = 0;
+                d.confusion = 0;
             } else {
+                assert(obs == .continuing);
                 assert(n >= 1 and n < 5);
                 if (n > 1) try self.probability.update(6 - @as(u4, n) - 1, 6 - @as(u4, n));
-                durations.confusion += 1;
+                d.confusion += 1;
+            }
+        }
+
+        pub fn disable(
+            self: *Self,
+            player: Player,
+            obs: Optional(Observation(.disable)),
+        ) Error!void {
+            if (!enabled) return;
+
+            var a = self.actions.get(player);
+            assert(a.disable == .None or a.disable == .started);
+            a.disable = obs;
+
+            var d = self.durations.get(player);
+            const n = d.disable;
+
+            if (obs == .ended) {
+                assert(n >= 1 and n <= 8);
+                if (n != 8) try self.probability.update(1, 9 - @as(u4, n));
+                d.disable = 0;
+            } else {
+                assert(obs == .continuing);
+                assert(n >= 1 and n < 8);
+                try self.probability.update(9 - @as(u4, n) - 1, 9 - @as(u4, n));
+                d.disable += 1;
             }
         }
 
-        pub fn attacking(self: *Self, player: Player, turns: u4) Error!void {
+        pub fn attacking(
+            self: *Self,
+            player: Player,
+            obs: Optional(Observation(.attacking)),
+        ) Error!void {
             if (!enabled) return;
 
-            var durations = &self.actions.get(player).durations;
-            const n = durations.attacking;
-            if (turns == 0) {
+            var a = self.actions.get(player);
+            assert(a.attacking == .None or a.attacking == .started);
+            a.attacking = obs;
+
+            var d = self.durations.get(player);
+            const n = d.attacking;
+            if (obs == .ended) {
+                // "3-4 turns" includes the turn for the initial attack *plus* the forced attacks
                 assert(n >= 2 and n <= 3);
                 if (n != 3) try self.probability.update(1, 4 - @as(u4, n));
-                durations.attacking = 0;
+                d.attacking = 0;
             } else {
+                assert(obs == .continuing);
                 assert(n >= 1 and n < 3);
                 if (n > 1) try self.probability.update(4 - @as(u4, n) - 1, 4 - @as(u4, n));
-                durations.attacking += 1;
+                d.attacking += 1;
             }
         }
 
-        pub fn binding(self: *Self, player: Player, turns: u4) Error!void {
+        pub fn binding(
+            self: *Self,
+            player: Player,
+            obs: Optional(Observation(.binding)),
+        ) Error!void {
             if (!enabled) return;
 
-            var durations = &self.actions.get(player).durations;
-            const n = durations.binding;
+            var a = self.actions.get(player);
+            assert(a.binding == .None or a.binding == .started);
+            a.binding = obs;
+
+            var d = self.durations.get(player);
+            const n = d.binding;
 
             assert(n > 0);
             const p: u4 = if (n < 3) 3 else 1;
             const q: u4 = if (n < 3) 8 - ((n - 1) * p) else 2;
 
-            if (turns == 0) {
+            if (obs == .ended) {
+                // "2-5 turns" includes the turn for the initial attack *plus* the forced attacks
                 assert(n >= 1 and n <= 4);
                 if (n != 4) try self.probability.update(p, q);
-                durations.binding = 0;
+                d.binding = 0;
             } else {
+                assert(obs == .continuing);
                 assert(n >= 1 and n < 4);
                 try self.probability.update(q - p, q);
-                durations.binding += 1;
+                d.binding += 1;
             }
         }
 
@@ -601,9 +742,18 @@ pub fn Chance(comptime Rational: type) type {
         pub fn metronome(self: *Self, player: Player, move: Move) Error!void {
             if (!enabled) return;
 
-            try self.probability.update(1, Move.size - 2);
+            try self.probability.update(1, Move.METRONOME.len);
             self.actions.get(player).metronome = move;
         }
+
+        pub fn pp(self: *Self, player: Player, n: u4) bool {
+            if (!enabled) return true;
+
+            var a = self.actions.get(player);
+            if (n > 1 and a.pp == n) return false;
+            if (a.metronome != .None) a.pp += n;
+            return true;
+        }
     };
 }
 
@@ -626,19 +776,25 @@ test "Chance.speedTie" {
 test "Chance.hit" {
     var chance: Chance(rational.Rational(u64)) = .{ .probability = .{} };
 
-    chance.hit(true, 229);
-    try expectProbability(&chance.probability, 1, 1);
-    try expectValue(Optional(bool).None, chance.actions.p1.hit);
-    try chance.commit(.P1, .hit);
+    try chance.hit(.P1, true, 229);
+    if (!showdown) {
+        try expectProbability(&chance.probability, 1, 1);
+        try expectValue(Optional(bool).None, chance.actions.p1.hit);
+
+        try chance.commit(.P1, .hit);
+    }
     try expectValue(Optional(bool).true, chance.actions.p1.hit);
     try expectProbability(&chance.probability, 229, 256);
 
     chance.reset();
 
-    chance.hit(false, 255);
-    try expectProbability(&chance.probability, 1, 1);
-    try expectValue(Optional(bool).None, chance.actions.p2.hit);
-    try chance.commit(.P2, .miss);
+    try chance.hit(.P2, false, 255);
+    if (!showdown) {
+        try expectProbability(&chance.probability, 1, 1);
+        try expectValue(Optional(bool).None, chance.actions.p2.hit);
+
+        try chance.commit(.P2, .miss);
+    }
     try expectValue(Optional(bool).false, chance.actions.p2.hit);
     try expectProbability(&chance.probability, 1, 256);
 }
@@ -654,26 +810,18 @@ test "Chance.criticalHit" {
         try expectProbability(&chance.probability, 1, 1);
         try expectValue(Optional(bool).None, chance.actions.p1.critical_hit);
 
-        try chance.commit(.P1, .hit);
-        try expectProbability(&chance.probability, 1, 1);
-        try expectValue(Optional(bool).None, chance.actions.p1.critical_hit);
-
-        chance.hit(true, 128);
+        try chance.hit(.P1, true, 128);
 
-        try chance.commit(.P1, .hit);
-        try expectProbability(&chance.probability, 1, 2);
+        try expectProbability(&chance.probability, 1, 1);
         try expectValue(Optional(bool).None, chance.actions.p1.critical_hit);
 
-        chance.probability.reset();
         try chance.damage(.P1, 217);
 
-        try chance.commit(.P1, .miss);
-        try expectProbability(&chance.probability, 1, 2);
+        try expectProbability(&chance.probability, 1, 1);
         try expectValue(Optional(bool).None, chance.actions.p1.critical_hit);
 
-        chance.probability.reset();
-
         try chance.commit(.P1, .hit);
+
         try expectProbability(&chance.probability, 17, 19968); // (1/2) * (17/256) * (1/39)
         try expectValue(Optional(bool).true, chance.actions.p1.critical_hit);
     }
@@ -688,20 +836,14 @@ test "Chance.criticalHit" {
         try expectProbability(&chance.probability, 1, 1);
         try expectValue(Optional(bool).None, chance.actions.p1.critical_hit);
 
-        try chance.commit(.P1, .hit);
-        try expectProbability(&chance.probability, 1, 1);
-        try expectValue(Optional(bool).None, chance.actions.p1.critical_hit);
-
-        chance.hit(true, 128);
+        try chance.hit(.P1, true, 128);
 
-        try chance.commit(.P1, .hit);
-        try expectProbability(&chance.probability, 1, 2);
+        try expectProbability(&chance.probability, 1, 1);
         try expectValue(Optional(bool).None, chance.actions.p1.critical_hit);
 
-        chance.probability.reset();
         try chance.damage(.P1, 217);
-
         try chance.commit(.P1, .hit);
+
         try expectProbability(&chance.probability, 251, 19968); // (1/2) * (251/256) * (1/39)
         try expectValue(Optional(bool).false, chance.actions.p1.critical_hit);
     }
@@ -718,11 +860,8 @@ test "Chance.damage" {
         try expectProbability(&chance.probability, 1, 1);
         try expectValue(@as(u8, 0), chance.actions.p1.damage);
 
-        try chance.commit(.P1, .miss);
-        try expectProbability(&chance.probability, 1, 1);
-        try expectValue(@as(u8, 0), chance.actions.p1.damage);
-
         try chance.commit(.P1, .hit);
+
         try expectProbability(&chance.probability, 1, 39);
         try expectValue(@as(u8, 217), chance.actions.p1.damage);
     }
@@ -776,13 +915,13 @@ test "Chance.moveSlot" {
 
     try chance.moveSlot(.P2, 2, &ms, 2);
     try expectProbability(&chance.probability, 1, 2);
-    try expectValue(@as(u4, 2), chance.actions.p2.move_slot);
+    try expectValue(@as(u3, 2), chance.actions.p2.move_slot);
 
     chance.reset();
 
     try chance.moveSlot(.P1, 1, &ms, 0);
     try expectProbability(&chance.probability, 1, 3);
-    try expectValue(@as(u4, 1), chance.actions.p1.move_slot);
+    try expectValue(@as(u3, 1), chance.actions.p1.move_slot);
 }
 
 test "Chance.multiHit" {
@@ -802,38 +941,31 @@ test "Chance.multiHit" {
 test "Chance.duration" {
     var chance: Chance(rational.Rational(u64)) = .{ .probability = .{} };
 
-    chance.duration(.sleep, .P1, .P2, 2);
+    chance.duration(.P1, 2);
     try expectValue(@as(u4, 2), chance.actions.p1.duration);
-    try expectValue(@as(u3, 1), chance.actions.p2.durations.sleep);
 
     chance.reset();
 
-    chance.duration(.binding, .P2, .P2, 4);
-    if (!showdown) {
-        try expectValue(@as(u4, 0), chance.actions.p2.duration);
-        try expectValue(@as(u3, 0), chance.actions.p2.durations.binding);
-        try chance.commit(.P2, .hit);
-    }
+    chance.duration(.P2, 4);
     try expectValue(@as(u4, 4), chance.actions.p2.duration);
-    try expectValue(@as(u3, 1), chance.actions.p2.durations.binding);
 }
 
 test "Chance.sleep" {
     var chance: Chance(rational.Rational(u64)) = .{ .probability = .{} };
 
     for ([_]u8{ 7, 6, 5, 4, 3, 2, 1 }, 1..8) |d, i| {
-        chance.actions.p1.durations.sleep = @intCast(i);
-        try chance.sleep(.P1, 0);
+        chance.durations.p1.sleeps = Sleeps.set(chance.durations.p1.sleeps, 0, @intCast(i));
+        try chance.sleep(.P1, .ended);
         try expectProbability(&chance.probability, 1, d);
-        try expectValue(@as(u3, 0), chance.actions.p1.durations.sleep);
+        try expectValue(@as(u3, 0), Sleeps.get(chance.durations.p1.sleeps, 0));
 
         chance.reset();
 
         if (i < 7) {
-            chance.actions.p1.durations.sleep = @intCast(i);
-            try chance.sleep(.P1, 1);
+            chance.durations.p1.sleeps = Sleeps.set(chance.durations.p1.sleeps, 0, @intCast(i));
+            try chance.sleep(.P1, .continuing);
             try expectProbability(&chance.probability, d - 1, d);
-            try expectValue(@as(u3, @intCast(i)) + 1, chance.actions.p1.durations.sleep);
+            try expectValue(@as(u3, @intCast(i)) + 1, Sleeps.get(chance.durations.p1.sleeps, 0));
 
             chance.reset();
         }
@@ -845,19 +977,41 @@ test "Chance.confusion" {
 
     for ([_]u8{ 1, 4, 3, 2, 1 }, 1..6) |d, i| {
         if (i > 1) {
-            chance.actions.p2.durations.confusion = @intCast(i);
-            try chance.confusion(.P2, 0);
+            chance.durations.p2.confusion = @intCast(i);
+            try chance.confusion(.P2, .ended);
             try expectProbability(&chance.probability, 1, d);
-            try expectValue(@as(u3, 0), chance.actions.p2.durations.confusion);
+            try expectValue(@as(u3, 0), chance.durations.p2.confusion);
 
             chance.reset();
         }
 
         if (i < 5) {
-            chance.actions.p2.durations.confusion = @intCast(i);
-            try chance.confusion(.P2, 1);
+            chance.durations.p2.confusion = @intCast(i);
+            try chance.confusion(.P2, .continuing);
             try expectProbability(&chance.probability, if (d > 1) d - 1 else d, d);
-            try expectValue(@as(u3, @intCast(i)) + 1, chance.actions.p2.durations.confusion);
+            try expectValue(@as(u3, @intCast(i)) + 1, chance.durations.p2.confusion);
+
+            chance.reset();
+        }
+    }
+}
+
+test "Chance.disable" {
+    var chance: Chance(rational.Rational(u64)) = .{ .probability = .{} };
+
+    for ([_]u8{ 8, 7, 6, 5, 4, 3, 2, 1 }, 1..9) |d, i| {
+        chance.durations.p1.disable = @intCast(i);
+        try chance.disable(.P1, .ended);
+        try expectProbability(&chance.probability, 1, d);
+        try expectValue(@as(u4, 0), chance.durations.p1.disable);
+
+        chance.reset();
+
+        if (i < 8) {
+            chance.durations.p1.disable = @intCast(i);
+            try chance.disable(.P1, .continuing);
+            try expectProbability(&chance.probability, d - 1, d);
+            try expectValue(@as(u4, @intCast(i)) + 1, chance.durations.p1.disable);
 
             chance.reset();
         }
@@ -869,19 +1023,19 @@ test "Chance.attacking" {
 
     for ([_]u8{ 1, 2, 1 }, 1..4) |d, i| {
         if (i > 1) {
-            chance.actions.p2.durations.attacking = @intCast(i);
-            try chance.attacking(.P2, 0);
+            chance.durations.p2.attacking = @intCast(i);
+            try chance.attacking(.P2, .ended);
             try expectProbability(&chance.probability, 1, d);
-            try expectValue(@as(u3, 0), chance.actions.p2.durations.attacking);
+            try expectValue(@as(u3, 0), chance.durations.p2.attacking);
 
             chance.reset();
         }
 
         if (i < 3) {
-            chance.actions.p2.durations.attacking = @intCast(i);
-            try chance.attacking(.P2, 1);
+            chance.durations.p2.attacking = @intCast(i);
+            try chance.attacking(.P2, .continuing);
             try expectProbability(&chance.probability, if (d > 1) d - 1 else d, d);
-            try expectValue(@as(u3, @intCast(i)) + 1, chance.actions.p2.durations.attacking);
+            try expectValue(@as(u3, @intCast(i)) + 1, chance.durations.p2.attacking);
 
             chance.reset();
         }
@@ -895,18 +1049,18 @@ test "Chance.binding" {
     const qs = [_]u8{ 8, 5, 2, 1 };
 
     for (ps, qs, 1..5) |p, q, i| {
-        chance.actions.p1.durations.binding = @intCast(i);
-        try chance.binding(.P1, 0);
+        chance.durations.p1.binding = @intCast(i);
+        try chance.binding(.P1, .ended);
         try expectProbability(&chance.probability, p, q);
-        try expectValue(@as(u3, 0), chance.actions.p1.durations.binding);
+        try expectValue(@as(u3, 0), chance.durations.p1.binding);
 
         chance.reset();
 
         if (i < 4) {
-            chance.actions.p1.durations.binding = @intCast(i);
-            try chance.binding(.P1, 1);
+            chance.durations.p1.binding = @intCast(i);
+            try chance.binding(.P1, .continuing);
             try expectProbability(&chance.probability, q - p, q);
-            try expectValue(@as(u3, @intCast(i)) + 1, chance.actions.p1.durations.binding);
+            try expectValue(@as(u3, @intCast(i)) + 1, chance.durations.p1.binding);
 
             chance.reset();
         }
@@ -934,7 +1088,7 @@ pub fn expectProbability(r: anytype, p: u64, q: u64) !void {
 
     r.reduce();
     if (r.p != p or r.q != q) {
-        print("expected {d}/{d}, found {}\n", .{ p, q, r });
+        print("expected {d}/{d}, found {f}\n", .{ p, q, r });
         return error.TestExpectedEqual;
     }
 }
@@ -947,7 +1101,7 @@ pub fn expectValue(a: anytype, b: anytype) !void {
 
 /// Null object pattern implementation of Generation I `Chance` which does nothing, though chance
 /// tracking should additionally be turned off entirely via `options.chance`.
-pub const NULL = Null{};
+pub const NULL: Null = .{};
 
 const Null = struct {
     pub const Error = error{};
@@ -956,24 +1110,24 @@ const Null = struct {
         _ = .{ self, player, kind };
     }
 
-    pub fn clearPending(self: Null) void {
+    pub fn glitch(self: Null) void {
         _ = .{self};
     }
 
-    pub fn clearDurations(self: Null, player: Player, haze: ?bool) void {
-        _ = .{ self, player, haze };
+    pub fn clearPending(self: Null) void {
+        _ = .{self};
     }
 
-    pub fn switched(self: Null, player: Player, in: u8, out: u8) void {
-        _ = .{ self, player, in, out };
+    pub fn switched(self: Null, player: Player, slot: u8) void {
+        _ = .{ self, player, slot };
     }
 
     pub fn speedTie(self: Null, p1: bool) Error!void {
         _ = .{ self, p1 };
     }
 
-    pub fn hit(self: Null, ok: bool, accuracy: u8) void {
-        _ = .{ self, ok, accuracy };
+    pub fn hit(self: Null, player: Player, ok: bool, accuracy: uN) Error!void {
+        _ = .{ self, player, ok, accuracy };
     }
 
     pub fn criticalHit(self: Null, player: Player, crit: bool, rate: u8) Error!void {
@@ -984,10 +1138,6 @@ const Null = struct {
         _ = .{ self, player, roll };
     }
 
-    pub fn secondaryChance(self: Null, player: Player, proc: bool, rate: u8) Error!void {
-        _ = .{ self, player, proc, rate };
-    }
-
     pub fn confused(self: Null, player: Player, ok: bool) Error!void {
         _ = .{ self, player, ok };
     }
@@ -996,6 +1146,10 @@ const Null = struct {
         _ = .{ self, player, ok };
     }
 
+    pub fn secondaryChance(self: Null, player: Player, proc: bool, rate: u8) Error!void {
+        _ = .{ self, player, proc, rate };
+    }
+
     pub fn moveSlot(self: Null, player: Player, slot: u4, ms: []const MoveSlot, n: u4) Error!void {
         _ = .{ self, player, slot, ms, n };
     }
@@ -1004,34 +1158,53 @@ const Null = struct {
         _ = .{ self, player, n };
     }
 
-    pub fn duration(
+    pub fn duration(self: Null, player: Player, turns: u4) void {
+        _ = .{ self, player, turns };
+    }
+
+    pub fn observe(
         self: Null,
-        comptime field: Duration.Field,
+        comptime field: Action.Field,
         player: Player,
-        target: Player,
-        turns: u4,
+        obs: Optional(Observation(.confusion)),
     ) void {
-        _ = .{ self, field, player, target, turns };
+        _ = .{ self, field, player, obs };
     }
 
-    pub fn sleep(self: Null, player: Player, turns: u4) Error!void {
-        _ = .{ self, player, turns };
+    pub fn sleep(self: Null, player: Player, obs: Optional(Observation(.sleep))) Error!void {
+        _ = .{ self, player, obs };
     }
 
-    pub fn disable(self: Null, player: Player, turns: u4) Error!void {
-        _ = .{ self, player, turns };
+    pub fn confusion(
+        self: Null,
+        player: Player,
+        obs: Optional(Observation(.confusion)),
+    ) Error!void {
+        _ = .{ self, player, obs };
     }
 
-    pub fn confusion(self: Null, player: Player, turns: u4) Error!void {
-        _ = .{ self, player, turns };
+    pub fn disable(
+        self: Null,
+        player: Player,
+        obs: Optional(Observation(.disable)),
+    ) Error!void {
+        _ = .{ self, player, obs };
     }
 
-    pub fn attacking(self: Null, player: Player, turns: u4) Error!void {
-        _ = .{ self, player, turns };
+    pub fn attacking(
+        self: Null,
+        player: Player,
+        obs: Optional(Observation(.attacking)),
+    ) Error!void {
+        _ = .{ self, player, obs };
     }
 
-    pub fn binding(self: Null, player: Player, turns: u4) Error!void {
-        _ = .{ self, player, turns };
+    pub fn binding(
+        self: Null,
+        player: Player,
+        obs: Optional(Observation(.binding)),
+    ) Error!void {
+        _ = .{ self, player, obs };
     }
 
     pub fn psywave(self: Null, player: Player, power: u8, max: u8) Error!void {
@@ -1041,4 +1214,9 @@ const Null = struct {
     pub fn metronome(self: Null, player: Player, move: Move) Error!void {
         _ = .{ self, player, move };
     }
+
+    pub fn pp(self: Null, player: Player, n: u4) bool {
+        _ = .{ self, player, n };
+        return true;
+    }
 };