@pkmn/engine 0.1.0-dev.89cc1c98 → 0.1.0-dev.900756a9

package/src/lib/gen2/mechanics.zig

@@ -37,6 +37,7 @@ const Gen12 = rng.Gen12;
 const PointerType = util.PointerType;
 
 const ActivePokemon = data.ActivePokemon;
+const Boosts = data.Boosts;
 const Effectiveness = data.Effectiveness;
 const Item = data.Item;
 const Move = data.Move;
@@ -50,6 +51,7 @@ const TriAttack = data.TriAttack;
 const Type = data.Type;
 const Types = data.Types;
 const Volatiles = data.Volatiles;
+const Weather = data.Weather;
 
 // zig fmt: off
 const STAT_BOOSTS = &[_][2]u8{
@@ -95,10 +97,13 @@ const CRITICAL_HITS = &[_]u8{
 
 const MAX_STAT_VALUE = 999;
 
+const STATS = [_][]const u8{ "atk", "def", "spe", "spa", "spd" };
+
 pub const State = struct {
     damage: u16 = 0, // wCurDamage
     effectiveness: u16 = Effectiveness.neutral, // wTypeModifier
     bp: u8, // wPlayerMoveStructPower
+    type: Type, // BATTLE_VARS_MOVE_TYPE
     accuracy: u8, // wEnemyMoveStruct + MOVE_ACC
     move: Move, // wCurPlayerMove
     from: Move = .None,
@@ -110,7 +115,7 @@ pub const State = struct {
     proc: bool = true, // wEffectFailed
 
     comptime {
-        assert(@sizeOf(State) == 14);
+        assert(@sizeOf(State) == 16);
     }
 
     pub fn immune(self: *State) bool {
@@ -269,7 +274,13 @@ fn turnOrder(battle: anytype, c1: Choice, c2: Choice, options: anytype) !Player
     // TODO: add to pending and only commit roll on Pokémon Showdown if roll is used
     const qkc = showdown and try Rolls.quickClaw(battle, .P1, options);
 
-    if ((c1.type == .Switch) != (c2.type == .Switch)) return if (c1.type == .Switch) .P1 else .P2;
+    if ((c1.type == .Switch) != (c2.type == .Switch)) {
+        const m1 = .Pound; // TODO battle.side(.P1).last_selected_move;
+        const m2 = .Pound; // TODO battle.side(.P2).last_selected_move;
+        return if (c1.type == .Switch)
+            if (m1 == .Pursuit) .P2 else .P1
+        else if (m2 == .Pursuit) .P1 else .P2;
+    }
 
     // https://www.smogon.com/forums/threads/adv-switch-priority.3622189/
     // > In Gen 1 it's irrelevant [which player switches first] because switches happen instantly on
@@ -398,8 +409,14 @@ fn executeMove(
 
     // FIXME: need damage from doTurn
     const m = Move.get(move);
-    var state: State =
-        .{ .move = move, .mslot = mslot, .first = first, .accuracy = m.accuracy, .bp = m.bp };
+    var state: State = .{
+        .move = move,
+        .mslot = mslot,
+        .first = first,
+        .accuracy = m.accuracy,
+        .bp = m.bp,
+        .type = m.type,
+    };
     try generated.runMove(battle, player, &state, options);
     return null;
 }
@@ -631,7 +648,7 @@ pub fn afterMove(
 
 pub fn checkCriticalHit(battle: anytype, player: Player, state: *State, options: anytype) !void {
     const move = Move.get(state.move);
-    if (move.bp == 0) return;
+    if (state.bp == 0) return;
 
     const side = battle.side(player);
     const pokemon = side.stored();
@@ -669,31 +686,30 @@ pub fn adjustDamage(battle: anytype, player: Player, state: *State, _: anytype)
     const side = battle.side(player);
     const foe = battle.foe(player);
     const types = foe.active.types;
-    const move = Move.get(state.move);
 
     var d = state.damage;
-    if ((move.type == .Water and battle.field.weather == .Rain) or
-        (move.type == .Fire and battle.field.weather == .Sun))
+    if ((state.type == .Water and battle.field.weather == .Rain) or
+        (state.type == .Fire and battle.field.weather == .Sun))
     {
         d = d *% @intFromEnum(Effectiveness.Super) / 10;
-    } else if ((move.type == .Water and battle.field.weather == .Sun) or
-        ((move.type == .Fire or state.move == .SolarBeam) and battle.field.weather == .Rain))
+    } else if ((state.type == .Water and battle.field.weather == .Sun) or
+        ((state.type == .Fire or state.move == .SolarBeam) and battle.field.weather == .Rain))
     {
         d = d *% @intFromEnum(Effectiveness.Resisted) / 10;
     }
 
-    if (side.active.types.includes(move.type)) d +%= d / 2;
+    if (side.active.types.includes(state.type)) d +%= d / 2;
 
     const neutral = @intFromEnum(Effectiveness.Neutral);
-    const foresight = foe.active.volatiles.Foresight and FORESIGHT.includes(move.type);
+    const foresight = foe.active.volatiles.Foresight and FORESIGHT.includes(state.type);
     const eff1: u16 = if (foresight and types.type1 == .Ghost)
         neutral
     else
-        @intFromEnum(move.type.effectiveness(types.type1));
+        @intFromEnum(state.type.effectiveness(types.type1));
     const eff2: u16 = if (foresight and types.type2 == .Ghost)
         neutral
     else
-        @intFromEnum(move.type.effectiveness(types.type2));
+        @intFromEnum(state.type.effectiveness(types.type2));
 
     // Type effectiveness matchup precedence only matters with (NVE, SE)
     if (!showdown and (eff1 + eff2) == Effectiveness.mismatch and
@@ -775,9 +791,15 @@ pub fn checkHit(
             return;
         }
     }
-    if (move.effect == .Thunder and battle.field.weather == .Rain) {
-        state.miss = false;
-        return;
+    if (move.effect == .Thunder) {
+        if (battle.field.weather == .Rain) {
+            state.miss = false;
+            return;
+        } else if (battle.field.weather == .Sun) {
+            // This latter part gets applied in a separate Thunder accuracy handler
+            // on the cartridge but it makes more sense to just do it here
+            state.accuracy = Gen12.percent(50) + 1;
+        }
     }
     if (move.effect == .AlwaysHit) {
         state.miss = false;
@@ -931,7 +953,7 @@ fn handleResidual(battle: anytype, player: Player, options: anytype) !bool {
         const before = foe_stored.hp;
         foe_stored.hp = @min(foe_stored.hp + damage, foe_stored.stats.hp);
         // Pokémon Showdown uses the less specific heal here instead of drain... because reasons?
-        if (foe_stored.hp > before) try options.log.heal(foe_ident, foe_stored, .Silent);
+        if (foe_stored.hp > before) try options.log.heal(.{ foe_ident, foe_stored, Heal.Silent });
         if (stored.hp == 0) return true;
     }
 
@@ -1047,7 +1069,9 @@ fn betweenTurns(battle: anytype, mslot: u4, options: anytype) !?Result {
         if (stored.item == .Leftovers) {
             const before = stored.hp;
             stored.hp = @min(stored.hp + @max(stored.stats.hp / 16, 1), stored.stats.hp);
-            if (stored.hp > before) try options.log.heal(battle.active(player), stored, .Leftovers);
+            if (stored.hp > before) {
+                try options.log.heal(.{ battle.active(player), stored, Heal.Leftovers });
+            }
         }
     }
 
@@ -1116,7 +1140,7 @@ fn betweenTurns(battle: anytype, mslot: u4, options: anytype) !?Result {
                     assert(offset < 3);
                     stored.hp = @min(stored.hp + ((offset + 1) * 10), stored.stats.hp);
                     const reason: Heal = @enumFromInt(@intFromEnum(Heal.Berry) + offset);
-                    try options.log.heal(ident, stored, reason);
+                    try options.log.heal(.{ ident, stored, reason });
                 }
             } else if (num < @intFromEnum(Item.BitterBerry)) {
                 const proc = if (stored.item == .MiracleBerry)
@@ -1131,7 +1155,7 @@ fn betweenTurns(battle: anytype, mslot: u4, options: anytype) !?Result {
 
                     // FIXME wtf?
                     // side.active.volatiles.Toxic = false;
-                    // side.active.volatiles.NightMare = false;
+                    // side.active.volatiles.Nightmare = false;
                     if (stored.item == .MiracleBerry) {
                         side.active.volatiles.Confusion = false;
                         try options.log.end(ident, .Confusion);
@@ -1247,10 +1271,6 @@ pub fn destinyBond(battle: anytype, player: Player, _: *State, options: anytype)
 }
 
 pub const Effects = struct {
-    pub fn alwaysHit(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
-
     pub fn attract(battle: anytype, player: Player, _: *State, options: anytype) !void {
         const side = battle.side(player);
         var foe = battle.foe(player);
@@ -1258,12 +1278,10 @@ pub const Effects = struct {
         const gender: u8 = @intFromEnum(side.stored().dvs.gender);
         const foe_gender: u8 = @intFromEnum(foe.stored().dvs.gender);
         if (gender + foe_gender != 1) {
-            try options.log.immune(battle.active(player.foe()), .None);
-            return;
+            return options.log.immune(battle.active(player.foe()), .None);
         } else if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
             try options.log.lastmiss();
-            try options.log.miss(battle.active(player));
-            return;
+            return options.log.miss(battle.active(player));
         }
 
         foe.active.volatiles.Attract = true;
@@ -1280,14 +1298,59 @@ pub const Effects = struct {
 
     pub fn bellyDrum(battle: anytype, player: Player, state: *State, options: anytype) !void {
         _ = .{ battle, player, state, options }; // TODO
+        // assert(!state.miss);
+        // var side = battle.side(player);
+        // try boostStat(battle, side, &side.active.stats, &side.active.boosts, "atk", 2);
+        // TODO
+        // |-boost|p1a: Poliwag|atk|2|[silent]
+        // |-fail|p1a: Poliwag
+        //
     }
 
-    pub fn bide(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
+    pub const bide = struct {
+        pub fn store(battle: anytype, player: Player, state: *State, options: anytype) !void {
+            var side = battle.side(player);
+            var volatiles = &side.active.volatiles;
+
+            const ident = battle.active(player);
+
+            if (!volatiles.Bide) return;
+
+            assert(volatiles.attacks > 0);
+            // if (options.calc.modify(player, .attacking)) |extend| {
+            //     if (!extend) volatiles.attacks = 0;
+            // } else {
+            volatiles.attacks -= 1;
+            // }
+            try options.chance.attacking(player, volatiles.attacks);
+
+            if (volatiles.attacks != 0) return options.log.activate(ident, .Bide);
+
+            volatiles.Bide = false;
+            try options.log.end(ident, .Bide);
+
+            state.damage = volatiles.bide *% 2;
+            volatiles.bide = 0;
+
+            if (state.damage == 0) state.miss = true;
+        }
+
+        pub fn unleash(battle: anytype, player: Player, state: *State, options: anytype) !void {
+            _ = .{ battle, player, state, options }; // TODO
+        }
+    };
 
     pub fn binding(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        var foe = battle.foe(player);
+
+        if (state.miss) return;
+        if (foe.active.volatiles.bind.duration > 0) return;
+        if (foe.active.volatiles.Substitute) return;
+
+        foe.active.volatiles.bind = .{
+            .duration = Rolls.bindingDuration(battle, player, options),
+            .reason = Move.get(state.move).extra.protocol,
+        };
     }
 
     pub fn burnChance(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -1297,7 +1360,7 @@ pub const Effects = struct {
         if (foe.active.volatiles.Substitute) return;
         if (Status.any(foe_stored.status)) {
             if (Status.is(foe_stored.status, .FRZ)) {
-                assert(Move.get(state.move).type == .Fire);
+                assert(Move.get(state.move).type == .Fire or state.move == .TriAttack);
                 try options.log.curestatus(
                     battle.active(player.foe()),
                     foe_stored.status,
@@ -1311,7 +1374,9 @@ pub const Effects = struct {
         if (foe.conditions.Safeguard) return;
         // Nothing is immune to Fire-type, but Ghosts are immune to burnChance called by Tri Attack
         if (state.immune()) return;
-        if (foe.active.types.includes(Move.get(state.move).type)) return;
+        if (foe.active.types.includes(Move.get(state.move).type) and state.move != .TriAttack) {
+            return;
+        }
 
         foe_stored.status = Status.init(.BRN);
         foe.active.stats.atk = @max(foe.active.stats.atk / 2, 1);
@@ -1335,10 +1400,7 @@ pub const Effects = struct {
         for (side.active.moves) |m| {
             if (convertible(side.active, m.id)) n += 1;
         }
-        if (n == 0) {
-            try options.log.fail(battle.active(player), .None);
-            return;
-        }
+        if (n == 0) return options.log.fail(battle.active(player), .None);
 
         side.active.types.type1 = try Rolls.conversion(battle, player, n, options);
         side.active.types.type2 = side.active.types.type1;
@@ -1348,26 +1410,87 @@ pub const Effects = struct {
         var side = battle.side(player);
 
         const last = battle.foe(player).lastMove(false);
-        if (last == .None) {
-            try options.log.fail(battle.active(player), .None);
-            return;
-        }
+        if (last == .None) return options.log.fail(battle.active(player), .None);
         const move = Move.get(last);
-        if (move.type == .@"???") {
-            try options.log.fail(battle.active(player), .None);
-            return;
-        }
+        if (move.type == .@"???") return options.log.fail(battle.active(player), .None);
 
         side.active.types.type1 = try Rolls.conversion2(battle, player, move.type, options);
         side.active.types.type2 = side.active.types.type1;
     }
 
-    pub fn counter(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn counter(battle: anytype, player: Player, state: *State, _: anytype) !void {
+        assert(state.move == .Counter or state.move == .MirrorCoat);
+
+        const foe = battle.foe(player);
+
+        state.miss = true;
+        const last = foe.lastMove(false);
+
+        if (last == .None) return;
+        if (last == state.move) return;
+
+        const immune = state.immune();
+        state.effectiveness = Effectiveness.neutral;
+        if (immune) {
+            state.damage = 0;
+            return;
+        }
+
+        const move = Move.get(last);
+        if (state.bp == 0) return;
+        if (move.type.special() != (last == .MirrorCoat)) return;
+        if (state.damage == 0) return;
+
+        state.damage *|= 2;
+        state.miss = false;
     }
 
     pub fn curse(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        var side = battle.side(player);
+        var foe = battle.foe(player);
+
+        const ident = battle.active(player);
+        const foe_ident = battle.active(player.foe());
+
+        if (side.active.types.includes(.Ghost)) {
+            if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
+                try options.log.lastmiss();
+                return options.log.miss(battle.active(player));
+            } else if (foe.active.volatiles.Substitute) {
+                return options.log.activateMove(foe_ident, .SubstituteBlock, state.move);
+            } else if (foe.active.volatiles.Curse) {
+                return options.log.fail(foe_ident, .None);
+            }
+
+            foe.active.volatiles.Curse = true;
+            try options.log.start(foe_ident, .Curse);
+
+            side.stored().hp -= @max(side.stored().stats.hp / 2, 1);
+            try options.log.damage(ident, side.stored(), .Curse);
+        } else {
+            var stats = &side.active.stats;
+            var boosts = &side.active.boosts;
+
+            const max_atk = boosts.atk == 6 or stats.atk == MAX_STAT_VALUE;
+            const max_def = boosts.def == 6 or stats.def == MAX_STAT_VALUE;
+            if (max_atk and max_def) return options.log.fail(ident, .None);
+
+            if (!(boosts.spe == -6 or stats.spe == 1)) {
+                assert(boosts.spe >= -6 and boosts.spe <= 6);
+                try unboostStat(battle, side, stats, boosts, "spe", 1);
+                try options.log.boost(ident, .Speed, @as(i8, -1));
+            }
+            if (!max_atk) {
+                assert(boosts.atk >= -6 and boosts.atk <= 6);
+                try boostStat(battle, side, stats, boosts, "atk", 1);
+                try options.log.boost(ident, .Attack, @as(i8, 1));
+            }
+            if (!max_def) {
+                assert(boosts.def >= -6 and boosts.def <= 6);
+                try boostStat(battle, side, stats, boosts, "def", 1);
+                try options.log.boost(ident, .Defense, @as(i8, 1));
+            }
+        }
     }
 
     pub fn defenseCurl(battle: anytype, player: Player, _: *State, _: anytype) !void {
@@ -1393,14 +1516,12 @@ pub const Effects = struct {
         const foe_ident = battle.active(player.foe());
 
         if (volatiles.disable.move != 0) {
-            try options.log.fail(foe_ident, .None);
-            return;
+            return options.log.fail(foe_ident, .None);
         }
 
         const last = battle.foe(player).lastMove(false);
         if (last == .None or last == .Struggle) {
-            try options.log.fail(foe_ident, .None);
-            return;
+            return options.log.fail(foe_ident, .None);
         }
 
         var slot: u3 = 0;
@@ -1410,10 +1531,7 @@ pub const Effects = struct {
             if (m.id == last) break;
         }
         const move = foe.active.move(slot);
-        if (move.pp == 0) {
-            try options.log.fail(foe_ident, .None);
-            return;
-        }
+        if (move.pp == 0) return options.log.fail(foe_ident, .None);
 
         volatiles.disable.move = slot;
         volatiles.disable.duration = Rolls.disableDuration(battle, player, options);
@@ -1421,9 +1539,19 @@ pub const Effects = struct {
         try options.log.startEffect(foe_ident, .Disable, move.id);
     }
 
-    pub fn doubleHit(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
+    pub const double = struct {
+        pub fn flying(battle: anytype, player: Player, state: *State, _: anytype) !void {
+            if (battle.foe(player).active.volatiles.Flying) state.damage *|= 2;
+        }
+
+        pub fn underground(battle: anytype, player: Player, state: *State, _: anytype) !void {
+            if (battle.foe(player).active.volatiles.Underground) state.damage *|= 2;
+        }
+
+        pub fn minimize(battle: anytype, player: Player, state: *State, _: anytype) !void {
+            if (battle.foe(player).active.volatiles.minimized) state.damage *|= 2;
+        }
+    };
 
     pub fn drainHP(battle: anytype, player: Player, state: *State, options: anytype) !void {
         var stored = battle.side(player).stored();
@@ -1445,10 +1573,7 @@ pub const Effects = struct {
         const failed = volatiles.Encore or
             (last == .None or last == .Struggle or
             last == .Encore or .last == .MirrorMove);
-        if (failed) {
-            try options.log.fail(foe_ident, .None);
-            return;
-        }
+        if (failed) return options.log.fail(foe_ident, .None);
 
         var slot: u3 = 0;
         for (foe.active.moves) |m| {
@@ -1457,10 +1582,7 @@ pub const Effects = struct {
             if (m.id == last) break;
         }
         const move = foe.active.move(slot);
-        if (move.pp == 0) {
-            try options.log.fail(foe_ident, .None);
-            return;
-        }
+        if (move.pp == 0) return options.log.fail(foe_ident, .None);
 
         volatiles.Encore = true;
         volatiles.encore = Rolls.encoreDuration(battle, player, options);
@@ -1500,10 +1622,6 @@ pub const Effects = struct {
         };
     }
 
-    pub fn flameWheel(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
-
     pub fn flinchChance(battle: anytype, player: Player, state: *State, _: anytype) !void {
         const foe = battle.foe(player);
         const status = foe.stored().status;
@@ -1541,7 +1659,7 @@ pub const Effects = struct {
 
         const foe = battle.foe(player);
 
-        if (state.first) return try options.log.fail(battle.active(player), .None);
+        if (state.first) return options.log.fail(battle.active(player), .None);
 
         var n: u4 = 0;
         var i: u4 = 0;
@@ -1555,10 +1673,7 @@ pub const Effects = struct {
             }
         }
 
-        if (n == 0) {
-            try options.log.fail(battle.active(player), .None);
-            return;
-        }
+        if (n == 0) return options.log.fail(battle.active(player), .None);
 
         const slot = try Rolls.forceSwitch(battle, player, SLOTS[0..i], n, options);
         try switchIn(battle, player.foe(), slot, .Drag, options);
@@ -1569,11 +1684,9 @@ pub const Effects = struct {
 
         if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
             try options.log.lastmiss();
-            try options.log.miss(battle.active(player));
-            return;
+            return options.log.miss(battle.active(player));
         } else if (foe.active.volatiles.Foresight) {
-            try options.log.fail(battle.active(player), .None);
-            return;
+            return options.log.fail(battle.active(player), .None);
         }
 
         foe.active.volatiles.Foresight = true;
@@ -1589,8 +1702,11 @@ pub const Effects = struct {
         if (Status.any(foe_stored.status)) return;
 
         // Nothing is immune to Ice-type, but Ghosts are immune to freezeChance called by Tri Attack
+        if (state.immune()) return;
         if (battle.field.weather == .Sun) return;
-        if (foe.active.types.includes(Move.get(state.move).type)) return;
+        if (foe.active.types.includes(Move.get(state.move).type) and state.move != .TriAttack) {
+            return;
+        }
         if (!state.proc) return;
         if (foe.conditions.Safeguard) return;
         // Freeze Clause Mod
@@ -1619,73 +1735,200 @@ pub const Effects = struct {
         state.bp = ((if (frustration) 255 - val else val) * 10) / 25;
     }
 
-    pub fn haze(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn haze(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+        var stats = unmodifiedStats(battle, side);
+        side.active.boosts = .{};
+        inline for (STATS) |s| @field(side.active.stats, s) = @field(stats, s);
+        statusModify(side.stored().status, &side.active.stats);
+
+        var foe = battle.foe(player);
+        stats = unmodifiedStats(battle, foe);
+        foe.active.boosts = .{};
+        inline for (STATS) |s| @field(foe.active.stats, s) = @field(stats, s);
+        statusModify(foe.stored().status, &foe.active.stats);
+
+        try options.log.clearallboost();
     }
 
     pub fn heal(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
+        var side = battle.side(player);
+        var stored = side.stored();
+        const ident = battle.active(player);
 
-    pub fn healBell(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        if (stored.stats.hp == stored.hp) return options.log.fail(ident, .None);
+
+        const rest = state.move == .Rest;
+        if (rest) {
+            // Adding the sleep status runs the sleep condition handler to roll duration
+            if (showdown) battle.rng.advance(1);
+            side.active.volatiles.Toxic = false;
+            stored.status = Status.slf(2);
+            recomputeStats(battle, side);
+            try options.log.statusFrom(ident, stored.status, Move.Rest);
+            stored.hp = stored.stats.hp;
+        } else {
+            stored.hp = @min(stored.stats.hp, stored.hp + (stored.stats.hp / 2));
+        }
+        try options.log.heal(.{ ident, stored, if (rest) Heal.Silent else Heal.None });
     }
 
-    pub fn hiddenPower(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn healBell(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+        side.active.volatiles.Nightmare = false;
+
+        try options.log.cureteam(battle.active(player));
+        for (&side.pokemon) |*p| p.status = 0;
+
+        // We technically only need to recompute stats if the active Pokémon was burned/paralyzed,
+        // but adding a branch to check for that is probably more expensive than just recomputing
+        recomputeStats(battle, side);
     }
 
-    pub fn hyperBeam(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn hiddenPower(battle: anytype, player: Player, state: *State, _: anytype) !void {
+        const side = battle.side(player);
+        state.bp = side.stored().dvs.power();
+        state.type = side.stored().dvs.type;
     }
 
-    pub fn jumpKick(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn hyperBeam(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        battle.side(player).active.volatiles.Recharging = true;
+        try options.log.mustrecharge(battle.active(player));
     }
 
     pub fn leechSeed(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        var foe = battle.foe(player);
+
+        if (showdown) {
+            // Invulnerability trumps type immunity on Pokémon Showdown
+            const invulnerable = foe.active.volatiles.Underground or foe.active.volatiles.Flying;
+            if (!invulnerable and foe.active.types.includes(.Grass)) {
+                return options.log.immune(battle.active(player.foe()), .None);
+            }
+            try checkHit(battle, player, state, options);
+            if (state.miss) {
+                try options.log.lastmiss();
+                return options.log.miss(battle.active(player));
+            }
+            if (foe.active.volatiles.LeechSeed) return;
+        } else {
+            try checkHit(battle, player, state, options);
+            const miss =
+                state.miss or foe.active.types.includes(.Grass) or foe.active.volatiles.LeechSeed;
+            if (miss) {
+                try options.log.lastmiss();
+                return options.log.miss(battle.active(player));
+            }
+        }
+
+        foe.active.volatiles.LeechSeed = true;
+
+        try options.log.start(battle.active(player.foe()), .LeechSeed);
     }
 
     pub fn lockOn(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        var foe = battle.foe(player);
+        const foe_ident = battle.active(player.foe());
+
+        if (foe.active.volatiles.Substitute) {
+            return options.log.activateMove(foe_ident, .SubstituteBlock, state.move);
+        } else if (state.miss) {
+            return options.log.fail(foe_ident, .None);
+        }
+
+        foe.active.volatiles.LockOn = true;
+        try options.log.activate(battle.active(player), .LockOn);
     }
 
     const MAGNITUDE_POWER = [_]u8{ 10, 30, 50, 70, 90, 110, 150 };
 
     pub fn magnitude(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        const num = try Rolls.magnitude(battle, player, options);
+        try options.log.magnitude(battle.active(player), num);
+        state.bp = MAGNITUDE_POWER[num - 4];
     }
 
-    pub fn meanLook(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn meanLook(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var foe = battle.foe(player);
+
+        if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
+            if (!showdown) return options.log.fail(battle.active(player.foe()), .None);
+            try options.log.lastmiss();
+            return options.log.miss(battle.active(player));
+        } else if (foe.active.volatiles.Trapped) {
+            return options.log.fail(battle.active(player.foe()), .None);
+        }
+
+        foe.active.volatiles.Trapped = true;
     }
 
-    pub fn metronome(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn metronome(
+        battle: anytype,
+        player: Player,
+        state: *State,
+        options: anytype,
+    ) anyerror!void {
+        var side = battle.side(player);
+
+        side.last_used_move = .None;
+        side.active.volatiles.dirty = false;
+
+        // if (wPlayerCharging) ???
+        // wPlayerCharging = 1
+
+        // FIXME
+        state.move = try Rolls.metronome(battle, player, options);
+        state.from = .Metronome;
+        return generated.runMove(battle, player, state, options);
     }
 
     pub fn mimic(battle: anytype, player: Player, state: *State, options: anytype) !void {
         _ = .{ battle, player, state, options }; // TODO
     }
 
-    pub fn mirrorCoat(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
+    pub fn mirrorMove(
+        battle: anytype,
+        player: Player,
+        state: *State,
+        options: anytype,
+    ) anyerror!void {
+        var side = battle.side(player);
+        const foe = battle.foe(player);
 
-    pub fn mirrorMove(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        side.last_used_move = .None;
+        side.active.volatiles.dirty = false;
+
+        const last = foe.lastMove(false);
+
+        if (last == .None) return options.log.fail(battle.active(player), .None);
+        const knows = knows: for (side.active.moves) |m| {
+            if (last == m.id) break :knows true;
+        } else false;
+        if (knows) return options.log.fail(battle.active(player), .None);
+
+        // if (wPlayerCharging) ???
+        // wPlayerCharging = 1
+
+        // FIXME
+        state.move = last;
+        state.from = .MirrorMove;
+        return generated.runMove(battle, player, state, options);
     }
 
-    pub fn mist(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn mist(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+
+        if (side.active.volatiles.Mist) return options.log.fail(battle.active(player), .None);
+        side.active.volatiles.Mist = true;
+
+        try options.log.start(battle.active(player), .Mist);
     }
 
     pub fn weatherHeal(battle: anytype, player: Player, _: *State, options: anytype) !void {
         var stored = battle.side(player).stored();
         const ident = battle.active(player);
 
-        if (stored.hp == stored.stats.hp) return try options.log.fail(ident, .None);
+        if (stored.hp == stored.stats.hp) return options.log.fail(ident, .None);
 
         stored.hp = switch (battle.field.weather) {
             .Sun => stored.stats.hp,
@@ -1693,7 +1936,7 @@ pub const Effects = struct {
             else => @min(stored.stats.hp, stored.hp + (stored.stats.hp / 4)),
         };
 
-        try options.log.heal(ident, stored, Heal.None);
+        try options.log.heal(.{ ident, stored, Heal.None });
     }
 
     pub fn multiHit(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -1701,32 +1944,94 @@ pub const Effects = struct {
     }
 
     pub fn nightmare(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        var foe = battle.foe(player);
+        var foe_volatiles = &foe.active.volatiles;
+        const foe_ident = battle.active(player.foe());
+
+        if (foe_volatiles.Flying or foe_volatiles.Underground) {
+            if (!showdown) return options.log.fail(battle.active(player.foe()), .None);
+            try options.log.lastmiss();
+            return options.log.miss(battle.active(player));
+        } else if (foe_volatiles.Substitute) {
+            return options.log.activateMove(foe_ident, .SubstituteBlock, state.move);
+        } else if (!Status.is(foe.stored().status, .SLP) or foe_volatiles.Nightmare) {
+            return options.log.fail(foe_ident, .None);
+        }
+
+        foe_volatiles.Nightmare = true;
+        try options.log.start(battle.active(player.foe()), .Nightmare);
     }
 
-    pub fn ohko(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        const side = battle.side(player);
-        const foe = battle.foe(player);
+    pub const ohko = struct {
+        // OHKO calls adjustDamage but only actually cares about immunity
+        pub fn immune(battle: anytype, player: Player, state: *State, _: anytype) !void {
+            const move = Move.get(state.move);
 
-        const foe_ident = battle.active(player.foe());
+            assert(move.type == .Normal or move.type == .Ground);
+            const foe = battle.foe(player);
+            const zero = if (move.type == .Normal)
+                foe.active.types.includes(.Ghost) and !foe.active.volatiles.Foresight
+            else
+                foe.active.types.includes(.Flying);
+            state.effectiveness = if (zero) 0 else Effectiveness.neutral;
+        }
 
-        state.damage = 0;
-        if (state.immune()) return try options.log.immune(foe_ident, .None);
-        const delta = side.stored().level -| foe.stored().level;
-        if (delta == 0) return try options.log.immune(foe_ident, .OHKO);
+        pub fn damage(battle: anytype, player: Player, state: *State, options: anytype) !void {
+            const side = battle.side(player);
+            const foe = battle.foe(player);
 
-        state.accuracy = 2 * delta +| Gen12.percent(30);
-        try checkHit(battle, player, state, options);
-        if (!state.miss) state.damage = 65535;
-        state.ohko = true;
-    }
+            const foe_ident = battle.active(player.foe());
+
+            state.damage = 0;
+            if (state.immune()) return options.log.immune(foe_ident, .None);
+            const delta = side.stored().level -| foe.stored().level;
+            if (delta == 0) return options.log.immune(foe_ident, .OHKO);
+
+            state.accuracy = 2 * delta +| Gen12.percent(30);
+            try checkHit(battle, player, state, options);
+            if (!state.miss) state.damage = 65535;
+            state.ohko = true;
+        }
+    };
 
     pub fn painSplit(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        var side = battle.side(player);
+        var foe = battle.foe(player);
+
+        const ident = battle.active(player);
+        const foe_ident = battle.active(player.foe());
+
+        if (state.miss) return options.log.fail(foe_ident, .None);
+        if (foe.active.volatiles.Substitute) {
+            return options.log.activateMove(foe_ident, .SubstituteBlock, state.move);
+        }
+
+        const avg = @max((foe.stored().hp + side.stored().hp) / 2, 1);
+        foe.stored().hp -= avg;
+        side.stored().hp = avg;
+
+        try options.log.sethp(foe_ident, foe.stored(), .Silent);
+        try options.log.sethp(ident, side.stored(), .None);
     }
 
     pub fn paralyze(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        var foe = battle.foe(player);
+        const foe_ident = battle.active(player.foe());
+
+        if (Status.is(foe.stored().status, .PAR)) return options.log.fail(foe_ident, .Paralysis);
+        if (state.immune()) return options.log.immune(foe_ident, .None);
+        if (Status.any(foe.stored().status)) return options.log.fail(foe_ident, .None);
+        if (state.miss) {
+            try options.log.lastmiss();
+            return options.log.miss(battle.active(player));
+        } else if (foe.active.volatiles.Substitute) {
+            return options.log.activateMove(foe_ident, .SubstituteBlock, state.move);
+        }
+
+        foe.stored().status = Status.init(.PAR);
+        foe.active.stats.spe = @max(foe.active.stats.spe / 4, 1);
+
+        try options.log.status(foe_ident, foe.stored().status, .None);
     }
 
     pub fn paralyzeChance(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -1746,12 +2051,28 @@ pub const Effects = struct {
         // TODO: check for status berry
     }
 
-    pub fn payDay(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn payDay(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        if (!showdown or !battle.foe(player).active.volatiles.Substitute) {
+            try options.log.fieldactivate(); // FIXME .PayDay
+        }
     }
 
-    pub fn perishSong(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn perishSong(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+        var foe = battle.foe(player);
+
+        if (foe.active.volatiles.PerishSong) {
+            return options.log.fail(battle.active(player.foe()), .None);
+        } else if (!side.active.volatiles.PerishSong) {
+            side.active.volatiles.PerishSong = true;
+            side.active.volatiles.perish_song = 4;
+            try options.log.start(battle.active(player), .PerishSong3Silent);
+        }
+        foe.active.volatiles.PerishSong = true;
+        foe.active.volatiles.perish_song = 4;
+        try options.log.start(battle.active(player.foe()), .PerishSong3Silent);
+
+        try options.log.fieldactivate(); // FIXME .PerishSong
     }
 
     pub fn poison(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -1778,7 +2099,7 @@ pub const Effects = struct {
             return options.log.activateMove(foe_ident, .SubstituteBlock, state.move);
         } else if (state.miss) {
             try options.log.lastmiss();
-            try options.log.miss(battle.active(player));
+            return options.log.miss(battle.active(player));
         }
 
         foe_stored.status = Status.init(.PSN);
@@ -1820,8 +2141,7 @@ pub const Effects = struct {
         const failed = !state.first or volatiles.Substitute or
             !try Rolls.protect(battle, player, volatiles.protect, options);
         if (failed) {
-            try options.log.fail(battle.active(player), .None);
-            return;
+            return options.log.fail(battle.active(player), .None);
         }
 
         volatiles.protect = @max(8, volatiles.protect + 1);
@@ -1833,33 +2153,78 @@ pub const Effects = struct {
         try options.log.singleturn(battle.active(player), state.move);
     }
 
-    pub fn psychUp(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
+    pub fn psychUp(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+        const foe = battle.foe(player);
 
-    pub fn pursuit(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
+        // Pokémon Showdown should fail when the enemy has no boosts/unboosts but doesn't
+        if (!showdown and @as(u32, @bitCast(foe.active.boosts)) == 0) {
+            return options.log.fail(battle.active(player), .None);
+        }
 
-    pub fn rage(battle: anytype, player: Player, _: *State, options: anytype) !void {
-        battle.side(player).active.volatiles.Rage = true;
-        try options.log.singlemove(battle.active(player), Move.Rage);
+        side.active.boosts = foe.active.boosts;
+        try options.log.copyboost(battle.active(player), battle.active(player.foe()));
     }
 
-    pub fn rainDance(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn pursuit(battle: anytype, player: Player, state: *State, _: anytype) !void {
+        // TODO: remove switching variable and just look at Choice saved in Battle struct?
+        if (battle.foe(player).active.volatiles.switching) state.damage *|= 2;
     }
 
-    pub fn rapidSpin(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub const rage = struct {
+        pub fn start(battle: anytype, player: Player, _: *State, options: anytype) !void {
+            battle.side(player).active.volatiles.Rage = true;
+            try options.log.singlemove(battle.active(player), Move.Rage);
+        }
+
+        pub fn damage(battle: anytype, player: Player, state: *State, _: anytype) !void {
+            var side = battle.side(player);
+            var volatiles = &side.active.volatiles;
+
+            assert(volatiles.Rage);
+            state.damage *|= (volatiles.rage +| 1);
+        }
+    };
+
+    pub fn rainDance(battle: anytype, _: Player, _: *State, options: anytype) !void {
+        return weather(battle, .Rain, options);
     }
 
-    pub fn razorWind(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn rapidSpin(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+
+        if (side.active.volatiles.LeechSeed) {
+            try options.log.end(battle.active(player), .LeechSeedFrom);
+            side.active.volatiles.LeechSeed = false;
+        }
+
+        if (side.conditions.Spikes) {
+            try options.log.spikesend(battle.active(player));
+            side.conditions.Spikes = false;
+        }
+
+        if (side.active.volatiles.bind.duration > 0) {
+            const reason = @intFromEnum(End.Bind) + side.active.volatiles.bind.reason - 1;
+            try options.log.end(battle.active(player), @enumFromInt(reason));
+            side.active.volatiles.bind = .{};
+        }
     }
 
     pub fn recoil(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        var side = battle.side(player);
+        var stored = side.stored();
+
+        assert(state.damage > 0);
+
+        const damage: i16 = @intCast(@max(state.damage / 4, 1));
+        stored.hp = @intCast(@max(@as(i16, @intCast(stored.hp)) - damage, 0));
+
+        try options.log.damageOf(
+            battle.active(player),
+            stored,
+            .RecoilOf,
+            battle.active(player.foe()),
+        );
     }
 
     pub fn reversal(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -1887,36 +2252,84 @@ pub const Effects = struct {
         try calcDamage(battle, player, state, options);
     }
 
-    pub fn rollout(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
+    pub const rollout = struct {
+        pub fn check(battle: anytype, player: Player, _: *State, _: anytype) !void {
+            var side = battle.side(player);
 
-    pub fn sacredFire(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
+            if (!side.active.volatiles.Rollout) {
+                side.active.volatiles.attacks = 0;
+            } else {
+                // TODO SkipToBattleCommand(doturn_command)
+            }
+        }
 
-    pub fn safeguard(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        pub fn power(battle: anytype, player: Player, state: *State, _: anytype) !void {
+            var side = battle.side(player);
+
+            if (Status.is(side.stored().status, .SLP)) return;
+
+            if (side.active.volatiles.attacks > 0) {
+                // TODO set wSomeoneIsRampaging
+            }
+
+            if (state.miss) {
+                side.active.volatiles.Rollout = false;
+                return;
+            }
+
+            assert(side.active.volatiles.attacks < 5);
+            side.active.volatiles.attacks += 1;
+            side.active.volatiles.Rollout = side.active.volatiles.attacks != 5;
+
+            if (side.active.volatiles.DefenseCurl) state.damage *|= 2;
+        }
+    };
+
+    pub fn sandstorm(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        if (battle.field.weather != .Sandstorm) return weather(battle, .Sandstorm, options);
+        return options.log.fail(battle.active(player), .None);
     }
 
-    pub fn sandstorm(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn safeguard(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        return screens(battle, player, "Safeguard", "safeguard", options);
     }
 
-    pub fn screens(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn reflect(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        return screens(battle, player, "Reflect", "reflect", options);
     }
 
-    pub fn sketch(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn lightScreen(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        return screens(battle, player, "LightScreen", "light_screen", options);
     }
 
-    pub fn skullBash(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    fn screens(
+        battle: anytype,
+        player: Player,
+        comptime key: []const u8,
+        comptime value: []const u8,
+        options: anytype,
+    ) !void {
+        var side = battle.side(player);
+
+        if (@field(side.conditions, key)) return options.log.fail(battle.active(player), .None);
+
+        @field(side.conditions, key) = true;
+        @field(side.conditions, value) = 5;
+        try options.log.sidestart(player, @field(protocol.Side, key));
     }
 
-    pub fn skyAttack(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn sketch(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+
+        side.last_used_move = .None;
+        side.active.volatiles.dirty = false;
+
+        if (showdown) {
+            // yes, actually "Splash". '|nothing' gets blindly mapped to  '|-activate||move:Splash'
+            try options.log.activate(battle.active(player), .Splash);
+        } else {
+            try options.log.fail(battle.active(player), .None);
+        }
     }
 
     pub fn sleep(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -1958,64 +2371,148 @@ pub const Effects = struct {
         for (side.active.moves, 0..) |m, i| {
             if (state.mslot - 1 != i and Move.get(m.id).extra.sleep_talk) n += 1;
         }
-        if (n == 0) {
-            try options.log.fail(battle.active(player), .None);
-            return;
-        }
+        if (n == 0) return options.log.fail(battle.active(player), .None);
 
         _ = try Rolls.sleepTalk(battle, player, n, state.mslot, options); // TODO
     }
 
-    pub fn snore(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn snore(battle: anytype, player: Player, state: *State, options: anytype) !bool {
+        if (Status.is(battle.side(player).stored().status, .SLP)) return true;
+        state.damage = 0;
+        state.miss = true; // TODO is this necessary?
+        if (!showdown) try options.log.fail(battle.active(player), .None);
+        return false;
     }
 
-    pub fn spikes(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn spikes(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var foe = battle.foe(player);
+        if (foe.conditions.Spikes) return options.log.fail(battle.active(player), .None);
+
+        foe.conditions.Spikes = true;
+        try options.log.sidestart(player.foe(), .Spikes);
     }
 
     pub fn spite(battle: anytype, player: Player, state: *State, options: anytype) !void {
         _ = .{ battle, player, state, options }; // TODO
-    }
+        // var foe = battle.foe(player);
 
-    pub fn splash(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
+        // if (state.miss) return options.log.fail(battle.active(player), .None);
 
-    pub fn stomp(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        // const last = foe.lastMove(false);
+        // if (showdown) {
+        //     const roll = try Rolls.spite(battle, player, options);
+        // } else {
+        //     if (last != .None) {}
+        // }
     }
 
-    pub fn substitute(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn splash(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        try options.log.activate(battle.active(player), .Splash);
     }
 
-    pub fn sunnyDay(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn substitute(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+        if (side.active.volatiles.Substitute) {
+            return options.log.fail(battle.active(player), .Substitute);
+        }
+
+        assert(side.stored().stats.hp <= 1023);
+        const hp: u8 = @intCast(side.stored().stats.hp / 4);
+
+        if (hp == 0 or side.stored().hp <= hp) {
+            return options.log.fail(battle.active(player), .Weak);
+        }
+
+        side.stored().hp -= hp;
+        side.active.volatiles.substitute = hp;
+        side.active.volatiles.Substitute = true;
+        side.active.volatiles.bind = .{};
+        try options.log.start(battle.active(player), .Substitute);
+        try options.log.damage(battle.active(player), side.stored(), .None);
     }
 
-    pub fn swagger(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn sunnyDay(battle: anytype, _: Player, _: *State, options: anytype) !void {
+        return weather(battle, .Sun, options);
     }
 
-    pub fn synthesis(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    fn weather(battle: anytype, w: Weather, options: anytype) !void {
+        battle.field.weather = w;
+        battle.field.weather_duration = 5;
+        try options.log.weather(w, .None);
     }
 
-    pub fn teleport(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn teleport(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        if (showdown) return;
+
+        try options.log.fail(battle.active(player), .None);
+        try options.log.laststill();
     }
 
     pub fn thief(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+        const side = battle.side(player);
+        const foe = battle.foe(player);
+
+        if (side.stored().item != .None or foe.stored().item == .None) return;
+        // Pokémon Showdown incorrectly allows you steal Mail
+        if (!showdown and foe.stored().item.isMail()) return;
+        if (!state.proc) return;
+
+        side.stored().item = foe.stored().item;
+        foe.stored().item = .None;
+
+        try options.log.item(
+            battle.active(player),
+            side.stored().item,
+            battle.active(player.foe()),
+        );
     }
 
-    pub fn thrashing(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn thrashing(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+        if (Status.is(side.stored().status, .SLP)) return;
+
+        assert(!side.active.volatiles.Thrashing);
+        side.active.volatiles.Thrashing = true;
+        side.active.volatiles.attacks = Rolls.attackingDuration(battle, player, options);
+        // TODO wSomeoneIsRampaging = true;
     }
 
-    pub fn transform(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
+    pub fn transform(battle: anytype, player: Player, _: *State, options: anytype) !void {
+        var side = battle.side(player);
+        const foe = battle.foe(player);
+        const foe_ident = battle.active(player.foe());
+
+        side.last_used_move = .None;
+        side.active.volatiles.dirty = false;
+
+        if (foe.active.volatiles.Transform) {
+            return options.log.fail(battle.active(player), .None);
+        } else if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
+            if (!showdown) return options.log.fail(battle.active(player), .None);
+            try options.log.lastmiss();
+            return options.log.miss(battle.active(player));
+        }
+
+        side.active.volatiles.Transform = true;
+        side.active.volatiles.transform = foe_ident.int();
+        side.active.volatiles.disable = .{};
+
+        // HP is not copied by Transform
+        side.active.stats.atk = foe.active.stats.atk;
+        side.active.stats.def = foe.active.stats.def;
+        side.active.stats.spe = foe.active.stats.spe;
+        side.active.stats.spa = foe.active.stats.spa;
+        side.active.stats.spd = foe.active.stats.spd;
+
+        side.active.species = foe.active.species;
+        side.active.types = foe.active.types;
+        side.active.boosts = foe.active.boosts;
+        for (foe.active.moves, 0..) |m, i| {
+            side.active.moves[i].id = m.id;
+            side.active.moves[i].pp = if (m.id != .None) if (m.id == .Sketch) 1 else 5 else 0;
+        }
+
+        try options.log.transform(battle.active(player), foe_ident);
     }
 
     pub fn triAttack(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -2027,19 +2524,14 @@ pub const Effects = struct {
                 .FRZ => freezeChance(battle, player, state, options),
                 .BRN => burnChance(battle, player, state, options),
             };
-        } else if (!showdown and pkmn.options.advance) _ = battle.rng.next();
+        } else if (!showdown) battle.rng.advance(1);
     }
 
     pub fn tripleKick(battle: anytype, player: Player, state: *State, options: anytype) !void {
         _ = .{ battle, player, state, options }; // TODO
     }
 
-    pub fn twister(battle: anytype, player: Player, state: *State, options: anytype) !void {
-        _ = .{ battle, player, state, options }; // TODO
-    }
-
-    const ALL_STAT_UP_STATS = [_][]const u8{ "atk", "def", "spe", "spa", "spd" };
-    const ALL_STAT_UP_REASONS =
+    const STAT_UP_REASONS =
         [_]Boost{ .Attack, .Defense, .Speed, .SpecialAttack, .SpecialDefense };
 
     pub fn allStatUpChance(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -2049,20 +2541,15 @@ pub const Effects = struct {
         var boosts = &side.active.boosts;
 
         if (!state.proc) return;
-        inline for (ALL_STAT_UP_STATS, ALL_STAT_UP_REASONS) |s, r| {
+        inline for (STATS, STAT_UP_REASONS) |s, r| {
             assert(@field(boosts, s) >= -6 and @field(boosts, s) <= 6);
             if (@field(boosts, s) == 6 or @field(stats, s) == MAX_STAT_VALUE) {
                 try options.log.boost(battle.active(player), r, 0);
             } else {
-                @field(boosts, s) = @intCast(@min(6, @as(i8, @field(boosts, s)) + 1));
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, @field(boosts, s)) + 6))];
-                const stat = @field(unmodifiedStats(battle, side), s);
-                @field(stats, s) = @min(MAX_STAT_VALUE, stat * mod[0] / mod[1]);
+                try boostStat(battle, side, stats, boosts, s, 1);
                 try options.log.boost(battle.active(player), r, 1);
             }
         }
-
-        statusModify(side.stored().status, stats);
     }
 
     pub fn boost(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -2070,84 +2557,55 @@ pub const Effects = struct {
         var side = battle.side(player);
         const ident = battle.active(player);
 
-        if (state.miss) return try log.fail(ident, .None);
+        if (state.miss) return log.fail(ident, .None);
 
         var stats = &side.active.stats;
         var boosts = &side.active.boosts;
 
         const move = Move.get(state.move);
         switch (move.effect) {
-            .AttackUp1, .AttackUp2, .Rage => {
+            .AttackUp1, .AttackUp2, .Rage, .Swagger => {
                 assert(boosts.atk >= -6 and boosts.atk <= 6);
-                if (boosts.atk == 6 or stats.atk == MAX_STAT_VALUE) {
-                    return try log.fail(ident, .None);
-                }
-                const n: u2 = if (move.effect == .AttackUp2) 2 else 1;
-                boosts.atk = @as(i4, @intCast(@min(6, @as(i8, boosts.atk) + n)));
+                if (boosts.atk == 6 or stats.atk == MAX_STAT_VALUE) return log.fail(ident, .None);
+                const n: u2 = if (move.effect == .AttackUp2 or move.effect == .Swagger) 2 else 1;
+                try boostStat(battle, side, stats, boosts, "atk", n);
                 const reason = if (showdown and move.effect == .Rage) Boost.Rage else Boost.Attack;
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, boosts.atk) + 6))];
-                const stat = unmodifiedStats(battle, side).atk;
-                stats.atk = @min(MAX_STAT_VALUE, stat * mod[0] / mod[1]);
                 try log.boost(ident, reason, n);
             },
-            .DefenseUp1, .DefenseUp2 => {
+            .DefenseUp1, .DefenseUp2, .SkullBash => {
                 assert(boosts.def >= -6 and boosts.def <= 6);
-                if (boosts.def == 6 or stats.def == MAX_STAT_VALUE) {
-                    return try log.fail(ident, .None);
-                }
+                if (boosts.def == 6 or stats.def == MAX_STAT_VALUE) return log.fail(ident, .None);
                 const n: u2 = if (move.effect == .DefenseUp2) 2 else 1;
-                boosts.def = @intCast(@min(6, @as(i8, boosts.def) + n));
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, boosts.def) + 6))];
-                const stat = unmodifiedStats(battle, side).def;
-                stats.def = @min(MAX_STAT_VALUE, stat * mod[0] / mod[1]);
+                try boostStat(battle, side, stats, boosts, "def", n);
                 try log.boost(ident, .Defense, n);
             },
             .SpeedUp2 => {
                 assert(boosts.spe >= -6 and boosts.spe <= 6);
-                if (boosts.spe == 6 or stats.spe == MAX_STAT_VALUE) {
-                    return try log.fail(ident, .None);
-                }
-                boosts.spe = @intCast(@min(6, @as(i8, boosts.spe) + 2));
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, boosts.spe) + 6))];
-                const stat = unmodifiedStats(battle, side).spe;
-                stats.spe = @min(MAX_STAT_VALUE, stat * mod[0] / mod[1]);
+                if (boosts.spe == 6 or stats.spe == MAX_STAT_VALUE) return log.fail(ident, .None);
+                try boostStat(battle, side, stats, boosts, "spe", 2);
                 try log.boost(ident, .Speed, 2);
             },
             .SpAtkUp1 => {
                 assert(boosts.spa >= -6 and boosts.spa <= 6);
-                if (boosts.spa == 6 or stats.spa == MAX_STAT_VALUE) {
-                    return try log.fail(ident, .None);
-                }
-                boosts.spa = @intCast(@min(6, @as(i8, boosts.spa) + 1));
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, boosts.spa) + 6))];
-                const stat = unmodifiedStats(battle, side).spa;
-                stats.spa = @min(MAX_STAT_VALUE, stat * mod[0] / mod[1]);
+                if (boosts.spa == 6 or stats.spa == MAX_STAT_VALUE) return log.fail(ident, .None);
+                try boostStat(battle, side, stats, boosts, "spa", 1);
                 try log.boost(ident, .SpecialAttack, 1);
             },
             .SpDefUp2 => {
                 assert(boosts.spd >= -6 and boosts.spd <= 6);
-                if (boosts.spd == 6 or stats.spd == MAX_STAT_VALUE) {
-                    return try log.fail(ident, .None);
-                }
-                boosts.spd = @intCast(@min(6, @as(i8, boosts.spd) + 2));
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, boosts.spd) + 6))];
-                const stat = unmodifiedStats(battle, side).spd;
-                stats.spd = @min(MAX_STAT_VALUE, stat * mod[0] / mod[1]);
+                if (boosts.spd == 6 or stats.spd == MAX_STAT_VALUE) return log.fail(ident, .None);
+                try boostStat(battle, side, stats, boosts, "spd", 2);
                 try log.boost(ident, .SpecialDefense, 2);
             },
             .EvasionUp1 => {
                 assert(boosts.evasion >= -6 and boosts.evasion <= 6);
-                if (boosts.evasion == 6) {
-                    return try log.fail(ident, .None);
-                }
+                if (boosts.evasion == 6) return log.fail(ident, .None);
                 boosts.evasion = @intCast(@min(6, @as(i8, boosts.evasion) + 1));
                 try log.boost(ident, .Evasion, 1);
                 if (state.move == .Minimize) side.active.volatiles.minimized = true;
             },
             else => unreachable,
         }
-
-        statusModify(side.stored().status, stats);
     }
 
     pub fn unboost(battle: anytype, player: Player, state: *State, options: anytype) !void {
@@ -2157,7 +2615,7 @@ pub const Effects = struct {
 
         if (foe.active.volatiles.Mist) {
             try log.activate(foe_ident, .Mist);
-            return try log.fail(foe_ident, .None);
+            return log.fail(foe_ident, .None);
         }
 
         const fail = foe.active.volatiles.Substitute or state.miss or !state.proc;
@@ -2173,16 +2631,12 @@ pub const Effects = struct {
                     return if (move.effect != .AttackDownChance) try log.fail(foe_ident, .None);
                 } else if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
                     try options.log.lastmiss();
-                    try options.log.miss(battle.active(player));
-                    return;
+                    return options.log.miss(battle.active(player));
                 } else if (stats.atk == 1) {
                     return if (move.effect != .AttackDownChance) try log.fail(foe_ident, .None);
                 }
                 const n: u2 = if (move.effect == .AttackDown2) 2 else 1;
-                boosts.atk = @intCast(@max(-6, @as(i8, boosts.atk) - n));
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, boosts.atk) + 6))];
-                const stat = unmodifiedStats(battle, foe).atk;
-                stats.atk = @max(1, stat * mod[0] / mod[1]);
+                try unboostStat(battle, foe, stats, boosts, "atk", n);
                 try log.boost(foe_ident, .Attack, -@as(i8, n));
             },
             .DefenseDown1, .DefenseDown2, .DefenseDownChance => {
@@ -2191,16 +2645,12 @@ pub const Effects = struct {
                     return if (move.effect != .DefenseDownChance) try log.fail(foe_ident, .None);
                 } else if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
                     try options.log.lastmiss();
-                    try options.log.miss(battle.active(player));
-                    return;
+                    return options.log.miss(battle.active(player));
                 } else if (stats.def == 1) {
                     return if (move.effect != .DefenseDownChance) try log.fail(foe_ident, .None);
                 }
                 const n: u2 = if (move.effect == .DefenseDown2) 2 else 1;
-                boosts.def = @intCast(@max(-6, @as(i8, boosts.def) - n));
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, boosts.def) + 6))];
-                const stat = unmodifiedStats(battle, foe).def;
-                stats.def = @max(1, stat * mod[0] / mod[1]);
+                try unboostStat(battle, foe, stats, boosts, "def", n);
                 try log.boost(foe_ident, .Defense, -@as(i8, n));
             },
             .SpeedDown1, .SpeedDown2, .SpeedDownChance => {
@@ -2209,31 +2659,22 @@ pub const Effects = struct {
                     return if (move.effect != .SpeedDownChance) try log.fail(foe_ident, .None);
                 } else if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
                     try options.log.lastmiss();
-                    try options.log.miss(battle.active(player));
-                    return;
+                    return options.log.miss(battle.active(player));
                 } else if (stats.spe == 1) {
                     return if (move.effect != .SpeedDownChance) try log.fail(foe_ident, .None);
                 }
                 const n: u2 = if (move.effect == .SpeedDown2) 2 else 1;
-                boosts.spe = @intCast(@max(-6, @as(i8, boosts.spe) - 1));
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, boosts.spe) + 6))];
-                const stat = unmodifiedStats(battle, foe).spe;
-                stats.spe = @max(1, stat * mod[0] / mod[1]);
+                try unboostStat(battle, foe, stats, boosts, "spe", n);
                 try log.boost(foe_ident, .Speed, -@as(i8, n));
-                assert(boosts.spe >= -6);
             },
             .SpDefDownChance => {
                 assert(boosts.spd >= -6 and boosts.spd <= 6);
                 if (fail or boosts.spd == -6) return;
                 if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
                     try options.log.lastmiss();
-                    try options.log.miss(battle.active(player));
-                    return;
+                    return options.log.miss(battle.active(player));
                 } else if (stats.spd == 1) return;
-                boosts.spd = @intCast(@max(-6, @as(i8, boosts.spd) - 1));
-                var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, boosts.spd) + 6))];
-                const stat = unmodifiedStats(battle, foe).spd;
-                stats.spd = @max(1, stat * mod[0] / mod[1]);
+                try unboostStat(battle, foe, stats, boosts, "spd", 1);
                 try log.boost(foe_ident, .SpecialDefense, -1);
             },
             .AccuracyDown1, .AccuracyDownChance => {
@@ -2242,16 +2683,13 @@ pub const Effects = struct {
                     return if (move.effect != .AccuracyDownChance) try log.fail(foe_ident, .None);
                 } else if (foe.active.volatiles.Flying or foe.active.volatiles.Underground) {
                     try options.log.lastmiss();
-                    try options.log.miss(battle.active(player));
-                    return;
+                    return options.log.miss(battle.active(player));
                 }
                 boosts.accuracy = @intCast(@max(-6, @as(i8, boosts.accuracy) - 1));
                 try log.boost(foe_ident, .Accuracy, -1);
             },
             else => unreachable,
         }
-
-        statusModify(foe.stored().status, stats);
     }
 };
 
@@ -2261,6 +2699,15 @@ fn unmodifiedStats(battle: anytype, side: *Side) *Stats(u16) {
     return &battle.side(id.player).pokemon[id.id - 1].stats;
 }
 
+fn recomputeStats(battle: anytype, side: *Side) void {
+    var stats = unmodifiedStats(battle, side);
+    inline for (STATS) |s| {
+        var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, @field(side.active.boosts, s)) + 6))];
+        const val = @field(stats, s) * mod[0] / mod[1];
+        @field(side.active.stats, s) = @max(1, @min(MAX_STAT_VALUE, val));
+    }
+}
+
 fn statusModify(status: u8, stats: *Stats(u16)) void {
     if (Status.is(status, .PAR)) {
         stats.spe = @max(stats.spe / 4, 1);
@@ -2269,6 +2716,52 @@ fn statusModify(status: u8, stats: *Stats(u16)) void {
     }
 }
 
+fn boostStat(
+    battle: anytype,
+    side: *Side,
+    stats: *Stats(u16),
+    boosts: *Boosts,
+    comptime s: []const u8,
+    n: u2,
+) !void {
+    @field(boosts, s) = @intCast(@min(6, @as(i8, @field(boosts, s)) + n));
+    var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, @field(boosts, s)) + 6))];
+    const stat = @field(unmodifiedStats(battle, side), s);
+    @field(stats, s) = @min(MAX_STAT_VALUE, stat * mod[0] / mod[1]);
+    if (comptime std.mem.eql(u8, s, "atk")) {
+        if (Status.is(side.stored().status, .BRN)) {
+            @field(stats, s) = @max(@field(stats, s) / 2, 1);
+        }
+    } else if (comptime std.mem.eql(u8, s, "spe")) {
+        if (Status.is(side.stored().status, .PAR)) {
+            @field(stats, s) = @max(@field(stats, s) / 4, 1);
+        }
+    }
+}
+
+fn unboostStat(
+    battle: anytype,
+    side: *Side,
+    stats: *Stats(u16),
+    boosts: *Boosts,
+    comptime s: []const u8,
+    n: u2,
+) !void {
+    @field(boosts, s) = @intCast(@max(-6, @as(i8, @field(boosts, s)) - n));
+    var mod = STAT_BOOSTS[@as(u4, @intCast(@as(i8, @field(boosts, s)) + 6))];
+    const stat = @field(unmodifiedStats(battle, side), s);
+    @field(stats, s) = @max(1, stat * mod[0] / mod[1]);
+    if (comptime std.mem.eql(u8, s, "atk")) {
+        if (Status.is(side.stored().status, .BRN)) {
+            @field(stats, s) = @max(@field(stats, s) / 2, 1);
+        }
+    } else if (comptime std.mem.eql(u8, s, "spe")) {
+        if (Status.is(side.stored().status, .PAR)) {
+            @field(stats, s) = @max(@field(stats, s) / 4, 1);
+        }
+    }
+}
+
 fn isForced(active: anytype) bool {
     return active.volatiles.Recharging or active.volatiles.Rage or
         active.volatiles.Thrashing or active.volatiles.Charging or
@@ -2458,7 +2951,7 @@ pub const Rolls = struct {
     }
 
     fn magnitude(battle: anytype, player: Player, options: anytype) !u8 {
-        const num = if (options.calc.overridden(player, .magnitude)) |val|
+        const num: u8 = if (options.calc.overridden(player, .magnitude)) |val|
             val + 3
         else if (showdown) num: {
             const r = battle.rng.range(u8, 0, 100);
@@ -2717,12 +3210,12 @@ pub const Rolls = struct {
     }
 
     fn metronome(battle: anytype, player: Player, options: anytype) !Move {
-        const moves = battle.get(player).active.moves;
+        const moves = battle.side(player).active.moves;
 
         var n: u2 = 0;
         for (moves) |m| {
-            if (m == .None) break;
-            if (Move.get(m).metronome) n += 1;
+            if (m.id == .None) break;
+            if (Move.get(m.id).extra.metronome) n += 1;
         }
 
         // TODO: consider throwing error instead of rerolling?
@@ -2733,10 +3226,11 @@ pub const Rolls = struct {
 
         const move: Move = overridden orelse move: {
             if (showdown) {
-                var r = battle.rng.range(u8, 0, Move.METRONOME.len - n);
+                var r = battle.rng.range(u8, 0, @intCast(Move.METRONOME.len - n));
                 for (moves) |m| {
-                    if (m == .None or @intFromEnum(m) > @intFromEnum(Move.METRONOME[r])) break;
-                    if (Move.get(m).metronome) r -= 1;
+                    if (m.id == .None) break;
+                    if (@intFromEnum(m.id) > @intFromEnum(Move.METRONOME[r])) break;
+                    if (Move.get(m.id).extra.metronome) r -= 1;
                 }
                 break :move Move.METRONOME[r];
             } else {
@@ -2751,7 +3245,7 @@ pub const Rolls = struct {
             }
         };
 
-        assert(Move.get(move).metronome);
+        assert(Move.get(move).extra.metronome);
         try options.chance.metronome(player, move, n);
         return move;
     }
@@ -2975,7 +3469,7 @@ pub fn choices(battle: anytype, player: Player, request: Choice.Type, out: []Cho
             }
 
             var slot: u4 = 2;
-            while (!active.volatiles.trapped and slot <= 6) : (slot += 1) {
+            while (!active.volatiles.Trapped and slot <= 6) : (slot += 1) {
                 const id = side.order[slot - 1];
                 if (id == 0 or side.pokemon[id - 1].hp == 0) continue;
                 out[n] = .{ .type = .Switch, .data = slot };