@pkmn/engine 0.1.0-dev.83de29ee → 0.1.0-dev.8b83af6b

package/src/lib/gen1/mechanics.zig

@@ -126,7 +126,7 @@ fn selectMove(
     const stored = side.stored();
 
     assert(!isForced(side.active) or
-        (choice.type == .Move and choice.data == @boolToInt(showdown)));
+        (choice.type == .Move and choice.data == @intFromBool(showdown)));
 
     // pre-battle menu
     if (volatiles.Recharging) {
@@ -183,7 +183,7 @@ fn selectMove(
                     battle.last_moves.p1_index
                 else
                     battle.last_moves.p2_index;
-                const last = side.active.move(@intCast(u4, slot));
+                const last = side.active.move(slot);
                 if (last.id == .Metronome) side.last_selected_move = last.id;
                 if (last.id == .MirrorMove) return Result.Error;
             }
@@ -237,9 +237,9 @@ fn saveMove(battle: anytype, player: Player, choice: ?Choice) void {
 
             side.last_selected_move = move.id;
             if (player == .P1) {
-                battle.last_moves.p1_index = @intCast(u3, c.data);
+                battle.last_moves.p1_index = @intCast(c.data);
             } else {
-                battle.last_moves.p2_index = @intCast(u3, c.data);
+                battle.last_moves.p2_index = @intCast(c.data);
             }
         }
     }
@@ -318,7 +318,9 @@ fn turnOrder(battle: anytype, c1: Choice, c2: Choice) Player {
     const spe2 = battle.side(.P2).active.stats.spe;
     if (spe1 == spe2) {
         // Pokémon Showdown's beforeTurnCallback shenanigans
-        if (showdown and m1 == .Counter and m2 == .Counter) battle.rng.advance(1);
+        if (showdown and !double_switch and m1 == .Counter and m2 == .Counter) {
+            battle.rng.advance(1);
+        }
 
         const p1 = Rolls.speedTie(battle);
         if (!showdown) return if (p1) .P1 else .P2;
@@ -418,7 +420,7 @@ fn executeMove(
     var side = battle.side(player);
 
     if (choice.type == .Switch) {
-        try switchIn(battle, player, @intCast(u4, choice.data), false, log);
+        try switchIn(battle, player, choice.data, false, log);
         return null;
     }
 
@@ -434,7 +436,7 @@ fn executeMove(
     }
 
     assert(choice.type == .Move);
-    var mslot = @intCast(u4, choice.data);
+    var mslot: u4 = @intCast(choice.data);
     // Sadly, we can't even check `Move.get(side.last_selected_move).effect == .Binding` here
     // because Pokémon Showdown's Mirror Move implementation clobbers side.last_selected_move
     var auto = showdown and side.last_selected_move != .None;
@@ -443,7 +445,7 @@ fn executeMove(
     if (mslot == 0 and side.last_selected_move != .None and side.last_selected_move != .Struggle) {
         // choice.data == 0 only happens with Struggle on Pokémon Showdown
         assert(!showdown);
-        mslot = @intCast(u4, if (player == .P1)
+        mslot = @intCast(if (player == .P1)
             battle.last_moves.p1_index
         else
             battle.last_moves.p2_index);
@@ -467,7 +469,7 @@ fn executeMove(
     } else if (showdown and side.active.volatiles.Charging) {
         // Incorrect mslot with Pokémon Showdown choice semantics so we need to recover from index
         assert(mslot == 1);
-        mslot = @intCast(u4, if (player == .P1)
+        mslot = @intCast(if (player == .P1)
             battle.last_moves.p1_index
         else
             battle.last_moves.p2_index);
@@ -627,7 +629,14 @@ fn beforeMove(
     if (volatiles.Bide) {
         assert(!volatiles.Thrashing and !volatiles.Rage);
 
-        volatiles.state +%= battle.last_damage;
+        if (showdown) {
+            // Pokémon Showdown doesn't implement Bide potentially overflowing in the event of
+            // OHKO-move damage, but we can fake this incorrect behavior by simply saturating the
+            // addition because 65535 is sufficient to faint any Pokémon anyway
+            volatiles.state +|= battle.last_damage;
+        } else {
+            volatiles.state +%= battle.last_damage;
+        }
 
         assert(volatiles.attacks > 0);
 
@@ -728,6 +737,7 @@ fn canMove(
         side.active.volatiles.Invulnerable = false;
     } else if (move.effect == .Charge) {
         try log.move(player_ident, side.last_selected_move, .{}, from);
+        setCounterable(battle, player, side, move);
         try Effects.charge(battle, player, log);
         return false;
     }
@@ -744,19 +754,7 @@ fn canMove(
     // regrettable, but this information is more "nice to have" than required
     const f = if (from != null and from.? == .None) null else from;
     try log.move(player_ident, side.last_selected_move, battle.active(target), f);
-
-    // The Counter desync is caused by the cartridge not calling GetCurrentMove until now, meaning
-    // in cases where an early return happens the data for a players last selected move does not get
-    // reloaded and HandleCounterMove actually bases its success/failure off of stale information.
-    // This boolean state we track here doesn't exist on the cartridge because it instead manifests
-    // as the desync results from actually having two separate battle states that subtly disagree.
-    const counterable = side.last_selected_move != .Counter and move.bp > 0 and
-        (move.type == .Normal or move.type == .Fighting);
-    if (player == .P1) {
-        battle.last_moves.p1_counterable = @boolToInt(counterable);
-    } else {
-        battle.last_moves.p2_counterable = @boolToInt(counterable);
-    }
+    setCounterable(battle, player, side, move);
 
     if (move.effect.onBegin()) {
         try onBegin(battle, player, move, mslot, residual, log);
@@ -773,6 +771,21 @@ fn canMove(
     return true;
 }
 
+fn setCounterable(battle: anytype, player: Player, side: *Side, move: Move.Data) void {
+    // The Counter desync is caused by the cartridge not calling GetCurrentMove until now, meaning
+    // in cases where an early return happens the data for a players last selected move does not get
+    // reloaded and HandleCounterMove actually bases its success/failure off of stale information.
+    // This boolean state we track here doesn't exist on the cartridge because it instead manifests
+    // as the desync results from actually having two separate battle states that subtly disagree
+    const counterable = side.last_selected_move != .Counter and move.bp > 0 and
+        (move.type == .Normal or move.type == .Fighting);
+    if (player == .P1) {
+        battle.last_moves.p1_counterable = @intFromBool(counterable);
+    } else {
+        battle.last_moves.p2_counterable = @intFromBool(counterable);
+    }
+}
+
 fn decrementPP(side: *Side, mslot: u4, auto: bool) void {
     if (side.last_selected_move == .Struggle) return;
 
@@ -783,11 +796,11 @@ fn decrementPP(side: *Side, mslot: u4, auto: bool) void {
     if (volatiles.Bide) return;
 
     assert(active.move(mslot).pp > 0 or auto);
-    active.move(mslot).pp = @intCast(u6, active.move(mslot).pp) -% 1;
+    active.move(mslot).pp = @as(u6, @intCast(active.move(mslot).pp)) -% 1;
     if (volatiles.Transform) return;
 
     assert(side.stored().move(mslot).pp > 0 or auto);
-    side.stored().move(mslot).pp = @intCast(u6, side.stored().move(mslot).pp) -% 1;
+    side.stored().move(mslot).pp = @as(u6, @intCast(side.stored().move(mslot).pp)) -% 1;
     assert(active.move(mslot).pp == side.stored().move(mslot).pp);
 }
 
@@ -795,12 +808,12 @@ fn incrementPP(side: *Side, mslot: u4) void {
     var active = &side.active;
     const volatiles = &active.volatiles;
 
-    active.move(mslot).pp = @intCast(u6, active.move(mslot).pp) +% 1;
+    active.move(mslot).pp = @as(u6, @intCast(active.move(mslot).pp)) +% 1;
     // GLITCH: No check for Transform means an empty/incorrect stored slot can get incremented
     if (showdown and volatiles.Transform) return;
 
     assert(mslot > 0 and mslot <= 4);
-    side.stored().moves[mslot - 1].pp = @intCast(u6, side.stored().moves[mslot - 1].pp) +% 1;
+    side.stored().moves[mslot - 1].pp = @as(u6, @intCast(side.stored().moves[mslot - 1].pp)) +% 1;
 }
 
 // Pokémon Showdown does hit/multi/crit/damage instead of crit/damage/hit/multi
@@ -836,8 +849,8 @@ fn doMove(
     // calling moveHit early covers most of that but we also need to check type immunity first
     var miss = showdown and miss: {
         immune = move.target != .Self and !status and !counter and
-            (@enumToInt(move.type.effectiveness(foe.active.types.type1)) == 0 or
-            @enumToInt(move.type.effectiveness(foe.active.types.type2)) == 0);
+            (@intFromEnum(move.type.effectiveness(foe.active.types.type1)) == 0 or
+            @intFromEnum(move.type.effectiveness(foe.active.types.type2)) == 0);
         if (immune and move.effect != .Binding) break :miss true;
         if (move.effect == .OHKO and side.active.stats.spe < foe.active.stats.spe) {
             battle.last_damage = 0;
@@ -928,7 +941,7 @@ fn doMove(
         }
         if (move.effect == .JumpKick) {
             // Recoil is supposed to be damage/8 but damage will always be 0 here
-            assert(battle.last_damage == 0);
+            assert(showdown or battle.last_damage == 0);
             battle.last_damage = 1;
             _ = try applyDamage(battle, player, player.foe(), .None, log);
             if (showdown and side.stored().hp == 0) residual.* = false;
@@ -1110,7 +1123,7 @@ fn calcDamage(
     d = @min(997, d);
     d += 2;
 
-    battle.last_damage = @intCast(u16, d);
+    battle.last_damage = @intCast(d);
 
     return true;
 }
@@ -1124,9 +1137,9 @@ fn adjustDamage(battle: anytype, player: Player) u16 {
     var d = battle.last_damage;
     if (side.active.types.includes(move.type)) d +%= d / 2;
 
-    const neutral = @enumToInt(Effectiveness.Neutral);
-    const eff1: u16 = @enumToInt(move.type.effectiveness(types.type1));
-    const eff2: u16 = @enumToInt(move.type.effectiveness(types.type2));
+    const neutral = @intFromEnum(Effectiveness.Neutral);
+    const eff1: u16 = @intFromEnum(move.type.effectiveness(types.type1));
+    const eff2: u16 = @intFromEnum(move.type.effectiveness(types.type2));
 
     // Type effectiveness matchup precedence only matters with (NVE, SE)
     if (!showdown and (eff1 + eff2) == Effectiveness.mismatch and
@@ -1149,7 +1162,7 @@ fn adjustDamage(battle: anytype, player: Player) u16 {
 fn randomizeDamage(battle: anytype) void {
     if (battle.last_damage <= 1) return;
     const random = Rolls.damage(battle);
-    battle.last_damage = @intCast(u16, @as(u32, battle.last_damage) *% random / 255);
+    battle.last_damage = @intCast(@as(u32, battle.last_damage) *% random / 255);
 }
 
 fn specialDamage(battle: anytype, player: Player, move: Move.Data, log: anytype) !?Result {
@@ -1165,7 +1178,7 @@ fn specialDamage(battle: anytype, player: Player, move: Move.Data, log: anytype)
         .DragonRage => 40,
         // GLITCH: if power = 0 then a desync occurs (or a miss on Pokémon Showdown)
         .Psywave => power: {
-            const max = @intCast(u8, @as(u16, side.stored().level) * 3 / 2);
+            const max: u8 = @intCast(@as(u16, side.stored().level) * 3 / 2);
             // GLITCH: Psywave infinite glitch loop
             if (!showdown and max <= 1) return Result.Error;
             break :power Rolls.psywave(battle, max);
@@ -1219,7 +1232,7 @@ fn counterDamage(battle: anytype, player: Player, move: Move.Data, log: anytype)
         return null;
     }
 
-    battle.last_damage = if (battle.last_damage > 0x7FFF) 0xFFFF else battle.last_damage * 2;
+    battle.last_damage *|= 2;
 
     // Pokémon Showdown calls checkHit before Counter
     if (!showdown and !try checkHit(battle, player, move, log)) return null;
@@ -1254,7 +1267,7 @@ fn applyDamage(
             return true;
         } else {
             // Safe to truncate since less than subbed.volatiles.substitute which is a u8
-            subbed.active.volatiles.substitute -= @intCast(u8, battle.last_damage);
+            subbed.active.volatiles.substitute -= @intCast(battle.last_damage);
             try log.activate(battle.active(sub_player), .Substitute);
             return false;
         }
@@ -1366,9 +1379,9 @@ fn moveHit(battle: anytype, player: Player, move: Move.Data, immune: *bool, mist
         assert(!overwritten or (0 < state and state <= 255 and !side.active.volatiles.Bide));
 
         var accuracy = if (overwritten) state else @as(u16, Gen12.percent(move.accuracy));
-        var boost = BOOSTS[@intCast(u4, @as(i8, side.active.boosts.accuracy) + 6)];
+        var boost = BOOSTS[@intCast(@as(i8, side.active.boosts.accuracy) + 6)];
         accuracy = accuracy * boost[0] / boost[1];
-        boost = BOOSTS[@intCast(u4, @as(i8, -foe.active.boosts.evasion) + 6)];
+        boost = BOOSTS[@intCast(@as(i8, -foe.active.boosts.evasion) + 6)];
         accuracy = accuracy * boost[0] / boost[1];
         accuracy = @min(255, @max(1, accuracy));
 
@@ -1387,7 +1400,7 @@ fn moveHit(battle: anytype, player: Player, move: Move.Data, immune: *bool, mist
     }
 
     if (!miss) return true;
-    battle.last_damage = 0;
+    if (!showdown or !foe.active.volatiles.Invulnerable) battle.last_damage = 0;
     side.active.volatiles.Binding = false;
     return false;
 }
@@ -1527,13 +1540,13 @@ fn endTurn(battle: anytype, log: anytype) @TypeOf(log).Error!Result {
     assert(!battle.side(.P1).active.volatiles.MultiHit);
     assert(!battle.side(.P2).active.volatiles.MultiHit);
 
+    battle.turn += 1;
+
     if (showdown and options.ebc and checkEBC(battle)) {
         try log.tie();
         return Result.Tie;
     }
 
-    battle.turn += 1;
-
     if (showdown and battle.turn >= 1000) {
         try log.tie();
         return Result.Tie;
@@ -1548,7 +1561,7 @@ fn endTurn(battle: anytype, log: anytype) @TypeOf(log).Error!Result {
 
 fn checkEBC(battle: anytype) bool {
     for (battle.sides, 0..) |side, i| {
-        const foe = battle.sides[~@intCast(u1, i)];
+        const foe = battle.sides[~@as(u1, @intCast(i))];
 
         var foe_all_ghosts = true;
         var foe_all_transform = true;
@@ -1842,7 +1855,7 @@ pub const Effects = struct {
             return Result.Error;
         }
 
-        volatiles.disabled_move = @intCast(u3, Rolls.moveSlot(battle, &foe.active.moves, n));
+        volatiles.disabled_move = @intCast(Rolls.moveSlot(battle, &foe.active.moves, n));
         volatiles.disabled_duration = Rolls.disableDuration(battle);
 
         try log.startEffect(foe_ident, .Disable, foe.active.move(volatiles.disabled_move).id);
@@ -1941,7 +1954,7 @@ pub const Effects = struct {
         // Pokémon Showdown clears P1 then P2 instead of status -> side -> foe
         if (showdown) {
             for (&battle.sides, 0..) |*s, i| {
-                const p = @intToEnum(Player, i);
+                const p: Player = @enumFromInt(i);
                 // Pokémon Showdown incorrectly does not prevent sleep/freeze from moving
                 if (p != player and Status.any(s.stored().status)) {
                     try log.curestatus(foe_ident, foe_stored.status, .Silent);
@@ -1972,7 +1985,9 @@ pub const Effects = struct {
 
         // GLITCH: HP recovery move failure glitches
         const delta = stored.stats.hp - stored.hp;
-        if (delta == 0 or delta & 255 == 255) return try log.fail(ident, .None);
+        if (delta == 0 or (delta & 255 == 255 and stored.hp % 256 != 0)) {
+            return try log.fail(ident, .None);
+        }
 
         const rest = side.last_selected_move == .Rest;
         if (rest) {
@@ -2040,7 +2055,7 @@ pub const Effects = struct {
             const has_mimic = has_mimic: {
                 for (side.active.moves, 0..) |m, i| {
                     if (m.id == .Mimic) {
-                        oslot = @intCast(u8, i + 1);
+                        oslot = @intCast(i + 1);
                         break :has_mimic true;
                     }
                 }
@@ -2186,9 +2201,12 @@ pub const Effects = struct {
         var side = battle.side(player);
         var stored = side.stored();
 
-        const damage = @intCast(i16, @max(battle.last_damage /
+        assert(showdown or battle.last_damage > 0);
+        if (showdown and battle.last_damage == 0) return;
+
+        const damage: i16 = @intCast(@max(battle.last_damage /
             @as(u8, if (side.last_selected_move == .Struggle) 2 else 4), 1));
-        stored.hp = @intCast(u16, @max(@intCast(i16, stored.hp) - damage, 0));
+        stored.hp = @intCast(@max(@as(i16, @intCast(stored.hp)) - damage, 0));
 
         try log.damageOf(battle.active(player), stored, .RecoilOf, battle.active(player.foe()));
         if (showdown and stored.hp == 0) residual.* = false;
@@ -2248,7 +2266,7 @@ pub const Effects = struct {
 
         assert(side.stored().stats.hp <= 1023);
         // Will be 0 if HP is <= 3 meaning that the user gets a 1 HP Substitute for "free"
-        const hp = @intCast(u8, side.stored().stats.hp / 4);
+        const hp: u8 = @intCast(side.stored().stats.hp / 4);
         // Pokénon Showdown incorrectly checks for 1/4 HP based on `target.maxhp / 4` which returns
         // a floating point value and thus only correctly implements the Substitute 1/4 glitch when
         // the target's HP is exactly divisible by 4 (here we're using an inlined divCeil routine to
@@ -2343,7 +2361,7 @@ pub const Effects = struct {
                 assert(boosts.atk >= -6 and boosts.atk <= 6);
                 if (boosts.atk == 6) return try log.fail(ident, .None);
                 const n: u2 = if (move.effect == .AttackUp2) 2 else 1;
-                boosts.atk = @intCast(i4, @min(6, @as(i8, boosts.atk) + n));
+                boosts.atk = @intCast(@min(6, @as(i8, boosts.atk) + n));
                 const reason = if (move.effect == .Rage) Boost.Rage else Boost.Attack;
                 if (stats.atk == MAX_STAT_VALUE) {
                     boosts.atk -= 1;
@@ -2354,7 +2372,7 @@ pub const Effects = struct {
                     }
                     return try log.fail(ident, .None);
                 }
-                var mod = BOOSTS[@intCast(u4, @as(i8, boosts.atk) + 6)];
+                var mod = BOOSTS[@intCast(@as(i8, boosts.atk) + 6)];
                 const stat = unmodifiedStats(battle, side).atk;
                 stats.atk = @min(MAX_STAT_VALUE, stat * mod[0] / mod[1]);
                 try log.boost(ident, reason, n);
@@ -2365,7 +2383,7 @@ pub const Effects = struct {
                 assert(boosts.def >= -6 and boosts.def <= 6);
                 if (boosts.def == 6) return try log.fail(ident, .None);
                 const n: u2 = if (move.effect == .DefenseUp2) 2 else 1;
-                boosts.def = @intCast(i4, @min(6, @as(i8, boosts.def) + n));
+                boosts.def = @intCast(@min(6, @as(i8, boosts.def) + n));
                 if (stats.def == MAX_STAT_VALUE) {
                     boosts.def -= 1;
                     if (showdown) {
@@ -2374,7 +2392,7 @@ pub const Effects = struct {
                     }
                     return try log.fail(ident, .None);
                 }
-                var mod = BOOSTS[@intCast(u4, @as(i8, boosts.def) + 6)];
+                var mod = BOOSTS[@intCast(@as(i8, boosts.def) + 6)];
                 const stat = unmodifiedStats(battle, side).def;
                 stats.def = @min(MAX_STAT_VALUE, stat * mod[0] / mod[1]);
                 try log.boost(ident, .Defense, n);
@@ -2382,7 +2400,7 @@ pub const Effects = struct {
             .SpeedUp2 => {
                 assert(boosts.spe >= -6 and boosts.spe <= 6);
                 if (boosts.spe == 6) return try log.fail(ident, .None);
-                boosts.spe = @intCast(i4, @min(6, @as(i8, boosts.spe) + 2));
+                boosts.spe = @intCast(@min(6, @as(i8, boosts.spe) + 2));
                 if (stats.spe == MAX_STAT_VALUE) {
                     boosts.spe -= 1;
                     if (showdown) {
@@ -2391,7 +2409,7 @@ pub const Effects = struct {
                     }
                     return try log.fail(ident, .None);
                 }
-                var mod = BOOSTS[@intCast(u4, @as(i8, boosts.spe) + 6)];
+                var mod = BOOSTS[@intCast(@as(i8, boosts.spe) + 6)];
                 const stat = unmodifiedStats(battle, side).spe;
                 stats.spe = @min(MAX_STAT_VALUE, stat * mod[0] / mod[1]);
                 try log.boost(ident, .Speed, 2);
@@ -2400,7 +2418,7 @@ pub const Effects = struct {
                 assert(boosts.spc >= -6 and boosts.spc <= 6);
                 if (boosts.spc == 6) return try log.fail(ident, .None);
                 const n: u2 = if (move.effect == .SpecialUp2) 2 else 1;
-                boosts.spc = @intCast(i4, @min(6, @as(i8, boosts.spc) + n));
+                boosts.spc = @intCast(@min(6, @as(i8, boosts.spc) + n));
                 if (stats.spc == MAX_STAT_VALUE) {
                     boosts.spc -= 1;
                     if (showdown) {
@@ -2411,7 +2429,7 @@ pub const Effects = struct {
                     }
                     return try log.fail(ident, .None);
                 }
-                var mod = BOOSTS[@intCast(u4, @as(i8, boosts.spc) + 6)];
+                var mod = BOOSTS[@intCast(@as(i8, boosts.spc) + 6)];
                 const stat = unmodifiedStats(battle, side).spc;
                 stats.spc = @min(MAX_STAT_VALUE, stat * mod[0] / mod[1]);
                 try log.boost(ident, .SpecialAttack, n);
@@ -2420,7 +2438,7 @@ pub const Effects = struct {
             .EvasionUp1 => {
                 assert(boosts.evasion >= -6 and boosts.evasion <= 6);
                 if (boosts.evasion == 6) return try log.fail(ident, .None);
-                boosts.evasion = @intCast(i4, @min(6, @as(i8, boosts.evasion) + 1));
+                boosts.evasion = @intCast(@min(6, @as(i8, boosts.evasion) + 1));
                 try log.boost(ident, .Evasion, 1);
             },
             else => unreachable,
@@ -2433,12 +2451,11 @@ pub const Effects = struct {
     fn unboost(battle: anytype, player: Player, move: Move.Data, log: anytype) !void {
         var foe = battle.foe(player);
         const foe_ident = battle.active(player.foe());
+        const secondary = move.effect.isStatDownChance();
 
-        if (foe.active.volatiles.Substitute) {
-            return if (!move.effect.isStatDownChance()) log.fail(foe_ident, .None);
-        }
+        if (foe.active.volatiles.Substitute) return if (!secondary) log.fail(foe_ident, .None);
 
-        if (move.effect.isStatDownChance()) {
+        if (secondary) {
             if (!Rolls.unboost(battle) or foe.active.volatiles.Invulnerable) return;
         } else if (!showdown and !try checkHit(battle, player, move, log)) {
             return; // checkHit already checks for Invulnerable
@@ -2446,12 +2463,13 @@ pub const Effects = struct {
 
         var stats = &foe.active.stats;
         var boosts = &foe.active.boosts;
+        const fail = showdown or !secondary;
 
         switch (move.effect) {
             .AttackDown1, .AttackDownChance => {
                 assert(boosts.atk >= -6 and boosts.atk <= 6);
-                if (boosts.atk == -6) return try log.fail(foe_ident, .None);
-                boosts.atk = @intCast(i4, @max(-6, @as(i8, boosts.atk) - 1));
+                if (boosts.atk == -6) return if (fail) try log.fail(foe_ident, .None);
+                boosts.atk = @intCast(@max(-6, @as(i8, boosts.atk) - 1));
                 if (stats.atk == 1) {
                     boosts.atk += 1;
                     if (showdown) {
@@ -2460,16 +2478,16 @@ pub const Effects = struct {
                     }
                     return try log.fail(foe_ident, .None);
                 }
-                var mod = BOOSTS[@intCast(u4, @as(i8, boosts.atk) + 6)];
+                var mod = BOOSTS[@intCast(@as(i8, boosts.atk) + 6)];
                 const stat = unmodifiedStats(battle, foe).atk;
                 stats.atk = @max(1, stat * mod[0] / mod[1]);
                 try log.boost(foe_ident, .Attack, -1);
             },
             .DefenseDown1, .DefenseDown2, .DefenseDownChance => {
                 assert(boosts.def >= -6 and boosts.def <= 6);
-                if (boosts.def == -6) return try log.fail(foe_ident, .None);
+                if (boosts.def == -6) return if (fail) try log.fail(foe_ident, .None);
                 const n: u2 = if (move.effect == .DefenseDown2) 2 else 1;
-                boosts.def = @intCast(i4, @max(-6, @as(i8, boosts.def) - n));
+                boosts.def = @intCast(@max(-6, @as(i8, boosts.def) - n));
                 if (stats.def == 1) {
                     boosts.def += 1;
                     if (showdown) {
@@ -2478,15 +2496,15 @@ pub const Effects = struct {
                     }
                     return try log.fail(foe_ident, .None);
                 }
-                var mod = BOOSTS[@intCast(u4, @as(i8, boosts.def) + 6)];
+                var mod = BOOSTS[@intCast(@as(i8, boosts.def) + 6)];
                 const stat = unmodifiedStats(battle, foe).def;
                 stats.def = @max(1, stat * mod[0] / mod[1]);
                 try log.boost(foe_ident, .Defense, -@as(i8, n));
             },
             .SpeedDown1, .SpeedDownChance => {
                 assert(boosts.spe >= -6 and boosts.spe <= 6);
-                if (boosts.spe == -6) return try log.fail(foe_ident, .None);
-                boosts.spe = @intCast(i4, @max(-6, @as(i8, boosts.spe) - 1));
+                if (boosts.spe == -6) return if (fail) try log.fail(foe_ident, .None);
+                boosts.spe = @intCast(@max(-6, @as(i8, boosts.spe) - 1));
                 if (stats.spe == 1) {
                     boosts.spe += 1;
                     if (showdown) {
@@ -2495,7 +2513,7 @@ pub const Effects = struct {
                     }
                     return try log.fail(foe_ident, .None);
                 }
-                var mod = BOOSTS[@intCast(u4, @as(i8, boosts.spe) + 6)];
+                var mod = BOOSTS[@intCast(@as(i8, boosts.spe) + 6)];
                 const stat = unmodifiedStats(battle, foe).spe;
                 stats.spe = @max(1, stat * mod[0] / mod[1]);
                 try log.boost(foe_ident, .Speed, -1);
@@ -2503,8 +2521,8 @@ pub const Effects = struct {
             },
             .SpecialDownChance => {
                 assert(boosts.spc >= -6 and boosts.spc <= 6);
-                if (boosts.spc == -6) return try log.fail(foe_ident, .None);
-                boosts.spc = @intCast(i4, @max(-6, @as(i8, boosts.spc) - 1));
+                if (boosts.spc == -6) return if (fail) try log.fail(foe_ident, .None);
+                boosts.spc = @intCast(@max(-6, @as(i8, boosts.spc) - 1));
                 if (stats.spc == 1) {
                     boosts.spc += 1;
                     if (showdown) {
@@ -2515,7 +2533,7 @@ pub const Effects = struct {
                     }
                     return try log.fail(foe_ident, .None);
                 }
-                var mod = BOOSTS[@intCast(u4, @as(i8, boosts.spc) + 6)];
+                var mod = BOOSTS[@intCast(@as(i8, boosts.spc) + 6)];
                 const stat = unmodifiedStats(battle, foe).spc;
                 stats.spc = @max(1, stat * mod[0] / mod[1]);
                 try log.boost(foe_ident, .SpecialAttack, -1);
@@ -2523,8 +2541,8 @@ pub const Effects = struct {
             },
             .AccuracyDown1 => {
                 assert(boosts.accuracy >= -6 and boosts.accuracy <= 6);
-                if (boosts.accuracy == -6) return try log.fail(foe_ident, .None);
-                boosts.accuracy = @intCast(i4, @max(-6, @as(i8, boosts.accuracy) - 1));
+                if (boosts.accuracy == -6) return if (fail) try log.fail(foe_ident, .None);
+                boosts.accuracy = @intCast(@max(-6, @as(i8, boosts.accuracy) - 1));
                 try log.boost(foe_ident, .Accuracy, -1);
             },
             else => unreachable,
@@ -2608,7 +2626,7 @@ pub const Rolls = struct {
     }
 
     inline fn criticalHit(battle: anytype, chance: u16) bool {
-        if (showdown) return battle.rng.chance(u8, @intCast(u8, chance), 256);
+        if (showdown) return battle.rng.chance(u8, @as(u8, @intCast(chance)), 256);
         return std.math.rotl(u8, battle.rng.next(), 3) < chance;
     }
 
@@ -2621,13 +2639,13 @@ pub const Rolls = struct {
     }
 
     inline fn hit(battle: anytype, accuracy: u16) bool {
-        if (showdown) return battle.rng.chance(u8, @intCast(u8, accuracy), 256);
+        if (showdown) return battle.rng.chance(u8, @as(u8, @intCast(accuracy)), 256);
         return battle.rng.next() < accuracy;
     }
 
     inline fn confusionDuration(battle: anytype) u3 {
-        if (showdown) return @intCast(u3, battle.rng.range(u8, 2, 6));
-        return @intCast(u3, (battle.rng.next() & 3) + 2);
+        if (showdown) return @intCast(battle.rng.range(u8, 2, 6));
+        return @intCast((battle.rng.next() & 3) + 2);
     }
 
     inline fn confused(battle: anytype) bool {
@@ -2656,16 +2674,16 @@ pub const Rolls = struct {
     }
 
     inline fn sleepDuration(battle: anytype) u3 {
-        if (showdown) return @intCast(u3, battle.rng.range(u8, 1, 8));
+        if (showdown) return @intCast(battle.rng.range(u8, 1, 8));
         while (true) {
             const r = battle.rng.next() & 7;
-            if (r != 0) return @intCast(u3, r);
+            if (r != 0) return @intCast(r);
         }
     }
 
     inline fn bideThrashDuration(battle: anytype) u3 {
-        if (showdown) return @intCast(u3, battle.rng.range(u4, 2, 4));
-        return @intCast(u3, (battle.rng.next() & 1) + 2);
+        if (showdown) return @intCast(battle.rng.range(u4, 2, 4));
+        return @intCast((battle.rng.next() & 1) + 2);
     }
 
     fn moveSlot(battle: anytype, moves: []MoveSlot, check_pp: u4) u4 {
@@ -2675,11 +2693,11 @@ pub const Rolls = struct {
                 while (i > 0) {
                     i -= 1;
                     if (moves[i].id != .None) {
-                        return battle.rng.range(u4, 0, @intCast(u4, i + 1)) + 1;
+                        return battle.rng.range(u4, 0, @as(u4, @intCast(i + 1))) + 1;
                     }
                 }
             } else {
-                var r = battle.rng.range(u4, 0, @intCast(u4, check_pp)) + 1;
+                var r = battle.rng.range(u4, 0, check_pp) + 1;
                 var i: usize = 0;
                 while (i < moves.len and r > 0) : (i += 1) {
                     if (moves[i].pp > 0) {
@@ -2687,32 +2705,32 @@ pub const Rolls = struct {
                         if (r == 0) break;
                     }
                 }
-                return @intCast(u4, i + 1);
+                return @intCast(i + 1);
             }
         }
 
         while (true) {
-            const r = @intCast(u4, battle.rng.next() & 3);
+            const r: u4 = @intCast(battle.rng.next() & 3);
             if (moves[r].id != .None and (check_pp == 0 or moves[r].pp > 0)) return r + 1;
         }
     }
 
     inline fn disableDuration(battle: anytype) u4 {
-        if (showdown) return @intCast(u4, battle.rng.range(u8, 1, 9));
-        return @intCast(u4, (battle.rng.next() & 7) + 1);
+        if (showdown) return @intCast(battle.rng.range(u8, 1, 9));
+        return @intCast((battle.rng.next() & 7) + 1);
     }
 
     inline fn metronome(battle: anytype) Move {
         if (showdown) {
-            const r = battle.rng.range(u8, 0, @enumToInt(Move.Struggle) - 2);
-            const mod = @as(u2, (if (r < @enumToInt(Move.Metronome) - 1) 1 else 2));
-            return @intToEnum(Move, r + mod);
+            const r = battle.rng.range(u8, 0, @intFromEnum(Move.Struggle) - 2);
+            const mod = @as(u2, (if (r < @intFromEnum(Move.Metronome) - 1) 1 else 2));
+            return @enumFromInt(r + mod);
         }
         while (true) {
             const r = battle.rng.next();
-            if (r == 0 or r == @enumToInt(Move.Metronome)) continue;
-            if (r >= @enumToInt(Move.Struggle)) continue;
-            return @intToEnum(Move, r);
+            if (r == 0 or r == @intFromEnum(Move.Metronome)) continue;
+            if (r >= @intFromEnum(Move.Struggle)) continue;
+            return @enumFromInt(r);
         }
     }
 
@@ -2727,7 +2745,7 @@ pub const Rolls = struct {
     inline fn distribution(battle: anytype) u3 {
         if (showdown) return DISTRIBUTION[battle.rng.range(u8, 0, DISTRIBUTION.len)];
         const r = (battle.rng.next() & 3);
-        return @intCast(u3, (if (r < 2) r else battle.rng.next() & 3) + 2);
+        return @intCast((if (r < 2) r else battle.rng.next() & 3) + 2);
     }
 
     inline fn unboost(battle: anytype) bool {
@@ -2740,7 +2758,7 @@ test "RNG agreement" {
     if (!showdown) return;
     var expected: [256]u32 = undefined;
     for (0..expected.len) |i| {
-        expected[i] = @intCast(u32, i * 0x1000000);
+        expected[i] = @intCast(i * 0x1000000);
     }
 
     var spe = rng.FixedRNG(1, expected.len){ .rolls = expected };
@@ -2797,7 +2815,7 @@ pub fn choices(battle: anytype, player: Player, request: Choice.Type, out: []Cho
             // strictly correct as the player would not have been presented the option to move or
             // switch at all.
             if (isForced(active)) {
-                out[n] = .{ .type = .Move, .data = @boolToInt(showdown) };
+                out[n] = .{ .type = .Move, .data = @intFromBool(showdown) };
                 n += 1;
                 return n;
             }