@pkmn/engine 0.1.0-dev.5ea92492 → 0.1.0-dev.5ec64ea5

package/build.zig

@@ -27,7 +27,6 @@ pub fn build(b: *std.Build) !void {
     const dynamic = b.option(bool, "dynamic", "Build a dynamic library") orelse false;
     const strip = b.option(bool, "strip", "Strip debugging symbols from binary") orelse false;
     const pic = b.option(bool, "pic", "Force position independent code") orelse false;
-    const emit_asm = b.option(bool, "emit-asm", "Output .s (assembly code)") orelse false;
 
     const cmd = b.findProgram(&.{"strip"}, &.{}) catch null;
 
@@ -135,7 +134,6 @@ pub fn build(b: *std.Build) !void {
         lib.bundle_compiler_rt = true;
         maybeStrip(b, lib, b.getInstallStep(), strip, cmd);
         if (pic) lib.force_pic = pic;
-        if (emit_asm) lib.emit_asm = .emit;
         lib.install();
         c = true;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pkmn/engine",
-  "version": "0.1.0-dev.5ea92492",
+  "version": "0.1.0-dev.5ec64ea5",
   "description": "A minimal, complete, Pokémon battle simulation engine optimized for performance",
   "repository": "github:pkmn/engine",
   "license": "MIT",

package/src/bin/pkmn-debug

@@ -7,9 +7,9 @@ try {
   if (err.code !== 'MODULE_NOT_FOUND') throw err;
 }
 
+const {join, resolve} = require('path');
 const {execFileSync} = require('child_process');
 const {readFileSync} = require('fs');
-const {join, resolve} = require('path');
 
 const ROOT = resolve(__dirname, '..', '..');
 const packageJSON = JSON.parse(readFileSync(join(ROOT, 'package.json'), 'utf8'));
@@ -46,7 +46,8 @@ if (missing.length) {
   execFileSync('npm', ['install', ...missing, '--global'], {encoding: 'utf8'});
 
   const node_modules = execFileSync('npm', ['root', '--global'], {encoding: 'utf8'}).trim();
-  if (!process.env.NODE_PATH || !process.env.NODE_PATH.includes(node_modules)) {
+  let NODE_PATH = process.env.NODE_PATH;
+  if (!NODE_PATH || !NODE_PATH.includes(node_modules)) {
     console.error(`NODE_PATH must include npm's global node_modules directory: '${node_modules}'`);
     process.exit(1);
   }

package/src/lib/gen1/README.md

@@ -478,8 +478,7 @@ Smogon](https://www.smogon.com/forums/posts/5933177/show):
 - Confusion self-hits use the wrong damage formula resulting in off-by-one errors (and also fail to
   account for an opponent's Reflect). Furthermore, the confusion self-hit damage will erroneously be
   inflicted to the confused user's substitute if the confused user had been attempting to use a
-  self-targeting move. Finally, Pokémon Showdown erroneously considers the *uncapped* self-hit
-  damage for the purposes of tracking the battle's last damage.
+  self-targeting move.
 
 Beyond the general bugs listed above, several move effects are implemented incorrectly by Pokémon
 Showdown. Some of these moves are [too fundamentally broken to be implemented](#unimplementable) by
@@ -489,8 +488,7 @@ the pkmn engine, but the following moves have their broken behavior preserved in
   incorrectly still gets applied to Bide's user.
 - **Leech Seed**: Leech Seed fails to heal its source side if a seeded target faints due to
   recoil/crash damage on Pokémon Showdown. Pokémon Showdown also updates the battle's last damage
-  field with the uncapped Leech Seed damage if the residual damage is applied which has consequences
-  for Bide and Counter.
+  field with the uncapped Leech Seed damage which has consequences for Bide and Counter.
 - **Pay Day**: Pay Day should still scatter coins if it hits (but doesn't break) and opponent's
   Substitute but doesn't on Pokémon Showdown.
 - **Flinch**: Flinching does not get cleared during move selection on Pokémon Showdown and is
@@ -500,14 +498,10 @@ the pkmn engine, but the following moves have their broken behavior preserved in
 - **Rage**: Rage boosts should still result in burn/paralysis [stat modification
   errors](https://pkmn.cc/bulba-glitch-1#Stat_modification_errors) but don't on Pokémon Showdown.
   Furthermore, Pokémon Showdown only builds Rage for Disable/Explosion (hit/miss) when attacking
-  into a Substitute instead of all moves. Pokémon Showdown also implements the [Rage and Thrash /
-  Petal Dance accuracy bug]( https://www.youtube.com/watch?v=NC5gbJeExbs) incorrectly, as the
-  accuracy only gets written when the volatile is present which can lead to incorrect accuracy
-  values on turns where Rage is used on the same turn as a move which modifies accuracy or evasion.
+  into a Substitute instead of all moves.
 - **Thrash** / **Petal Dance**: once a Pokémon is locked into a thrashing move they will lose all
   speed ties on Pokémon Showdown (due to the fact that if they win the speed tie their action will
-  then get "changed" and inserted back into the queue after their opponent's action). Pokémon
-  Showdown also implements accuracy incorrectly, as covered above.
+  then get "changed" and inserted back into the queue after their opponent's action).
 - **Freeze** / **Sleep**: Pokémon Showdown requires a move to be selected when a Pokémon is frozen
   or sleeping and uses that in the event that the status is removed while on the cartridge no
   selection is possible and no turn exists for the thawed/woken Pokémon to act except in the case of
@@ -532,8 +526,7 @@ the pkmn engine, but the following moves have their broken behavior preserved in
   Pokémon Showdown implementing the health check based on floating point division instead of integer
   divison like on the cartridge (meaning the Substitute 1/4 glitch will only occur if the Pokémon's
   maximum HP is evenly divisible by 4). Finally, Substitute also incorrectly blocks Dream Eater on
-  Pokémon Showdown and will incorrectly still heal 1 HP for any draining moves if the attack does 0
-  damage.
+  Pokémon Showdown.
 
 In addition to numerous cases where Pokémon Showdown uses the wrong type of message (e.g. `|-fail`
 vs. `|-miss|` vs. `|-immune|`, e.g. in the case of Leech Seed) which are not documented here, Pokémon

package/src/lib/gen1/data.zig

@@ -78,8 +78,7 @@ pub fn Battle(comptime RNG: anytype) type {
         /// Returns the result of applying Player 1's choice `c1` and Player 2's choice `c2` to the
         /// battle, optionally writing protocol logs to `log` if `options.trace` is enabled.
         pub fn update(self: *Self, c1: Choice, c2: Choice, log: anytype) !Result {
-            const m = mechanics.Mechanics(*Self, @TypeOf(log)){ .battle = self, .log = log };
-            return m.update(c1, c2);
+            return mechanics.update(self, c1, c2, log);
         }
 
         /// Fills in at most `out.len` possible choices for the `player` given the previous `result`