@pkmn/engine 0.1.0-dev.4f7cbb89 → 0.1.0-dev.51ebf68b

package/src/lib/common/protocol.zig

@@ -1,20 +1,17 @@
-const std = @import("std");
 const builtin = @import("builtin");
-
+const data = @import("data.zig");
+const options = @import("options.zig");
 const pkmn = @import("../pkmn.zig");
-
-const data = @import("./data.zig");
-const options = @import("./options.zig");
+const std = @import("std");
 
 const assert = std.debug.assert;
-const print = std.debug.print;
-
 const enabled = options.log;
-
-const Player = data.Player;
 const ID = data.ID;
+const Player = data.Player;
+const print = std.debug.print;
 
 const endian = builtin.cpu.arch.endian();
+const Endian = std.builtin.Endian;
 
 pub const ArgType = enum(u8) {
     None,
@@ -73,7 +70,7 @@ pub const ArgType = enum(u8) {
     EndAbility,
     ClearNegativeBoost,
     FormeChange,
-    NoTarget,
+    LastNoTarget, // FIXME
 
     // Gen 4
     SwapBoost,
@@ -220,6 +217,7 @@ pub const Activate = enum(u8) {
     BeatUp, // FIXME of
 
     Magnitude,
+    Spite,
 };
 
 pub const Start = enum(u8) {
@@ -311,19 +309,29 @@ pub const Weather = enum(u8) {
     Upkeep,
 };
 
-/// Null object pattern implementation of `Log` backed by a `std.io.null_writer`.
-/// Ignores anything sent to it, though protocol logging should additionally be turned off
-/// entirely with `options.log`.
-pub const NULL = Log(@TypeOf(std.io.null_writer)){ .writer = std.io.null_writer };
-
-/// Logs protocol information to its `Writer` during a battle update when `options.log` is enabled.
-pub fn Log(comptime Writer: type) type {
+/// Logs protocol information to its `WriterT` during a battle update when `options.log` is enabled.
+pub fn Log(comptime WriterT: type) type {
     return struct {
         const Self = @This();
 
-        writer: Writer,
+        writer: WriterT,
 
-        pub const Error = Writer.Error;
+        pub const Error = err(WriterT);
+
+        fn err(comptime T: type) type {
+            const msg = "Invalid Writer type " ++ @typeName(T) ++ "'";
+            return switch (@typeInfo(T)) {
+                .pointer => |ptr_info| switch (ptr_info.size) {
+                    .one => switch (@typeInfo(ptr_info.child)) {
+                        .@"struct" => err(ptr_info.child),
+                        else => @compileError(msg),
+                    },
+                    else => @compileError(msg),
+                },
+                .@"struct" => if (@hasDecl(T, "Error")) T.Error else @compileError(msg),
+                else => @compileError(msg),
+            };
+        }
 
         // source: ID, move: <Move>, target: ID, from?: <Move>
         pub fn move(self: Self, args: anytype) Error!void {
@@ -544,6 +552,7 @@ pub fn Log(comptime Writer: type) type {
         // ident: ID, reason: Activate
         // ident: ID, reason: .SubstituteBlock, m: <Move>
         // ident: ID, reason: .Magnitude, num: u8
+        // ident: ID, reason: .Spite, m: <Move>, num: u8
         pub fn activate(self: Self, args: anytype) Error!void {
             if (!enabled) return;
 
@@ -561,6 +570,9 @@ pub fn Log(comptime Writer: type) type {
                     assert(reason == .Magnitude);
                     try self.writer.writeByte(args[2]);
                 }
+            } else if (args.len == 4) {
+                assert(reason == .Spite);
+                try self.writer.writeAll(&.{ @intFromEnum(args[2]), args[3] });
             }
         }
 
@@ -810,56 +822,68 @@ pub fn Log(comptime Writer: type) type {
     };
 }
 
-/// `Log` type backed by the optimized `ByteStream.Writer`.
-pub const FixedLog = Log(ByteStream.Writer);
+/// `Log` type backed by the optimized `Writer`.
+pub const FixedLog = Log(*Writer);
 
-/// Stripped down version of `std.io.FixedBufferStream` optimized for efficiently writing the
-/// individual protocol bytes. Note that the `ByteStream.Writer` is **not** a `std.io.Writer` and
-/// should not be used for general purpose writing.
-pub const ByteStream = struct {
+/// Minimal logging helper optimized for efficiently writing the individual protocol bytes into a
+/// fixed buffer. Note that this is **not** a `std.Io.Writer` and should not be used for general
+/// purpose writing.
+pub const Writer = struct {
     buffer: []u8,
     pos: usize = 0,
 
-    pub const Writer = struct {
-        stream: *ByteStream,
+    pub const Error = error{NoSpaceLeft};
 
-        pub const Error = error{NoSpaceLeft};
+    pub fn writeByte(self: *Writer, byte: u8) Error!void {
+        if (self.pos >= self.buffer.len) return error.NoSpaceLeft;
+        self.buffer[self.pos] = byte;
+        self.pos += 1;
+    }
 
-        pub fn writeAll(self: Writer, bytes: []const u8) Error!void {
-            for (bytes) |b| try self.writeByte(b);
-        }
+    pub fn writeAll(self: *Writer, bytes: []const u8) Error!void {
+        const npos = self.pos + bytes.len;
+        if (npos > self.buffer.len) return error.NoSpaceLeft;
+        @memcpy(self.buffer[self.pos..npos], bytes);
+        self.pos = npos;
+    }
 
-        pub fn writeByte(self: Writer, byte: u8) Error!void {
-            try self.stream.writeByte(byte);
-        }
+    pub fn writeInt(self: *Writer, comptime T: type, v: T, end: std.builtin.Endian) Error!void {
+        const bytes = @divExact(@typeInfo(T).int.bits, 8);
+        const npos = self.pos + bytes;
+        if (npos > self.buffer.len) return error.NoSpaceLeft;
+        std.mem.writeInt(T, self.buffer[self.pos..][0..bytes], v, end);
+        self.pos = npos;
+    }
 
-        pub fn writeInt(self: Writer, comptime T: type, v: T, end: std.builtin.Endian) Error!void {
-            // TODO: rework this to write directly to the buffer?
-            var bytes: [@divExact(@typeInfo(T).Int.bits, 8)]u8 = undefined;
-            std.mem.writeInt(std.math.ByteAlignedInt(@TypeOf(v)), &bytes, v, end);
-            return self.writeAll(&bytes);
-        }
-    };
+    pub fn reset(self: *Writer) void {
+        self.pos = 0;
+    }
+};
 
-    pub fn writer(self: *ByteStream) Writer {
-        return .{ .stream = self };
+/// Null object pattern implementation of `Log` backed by a null writer. Ignores anything sent to
+/// it, though protocol logging should additionally be turned off entirely with `options.log`.
+pub const NULL = Log(NullWriter){ .writer = .{} };
+
+const NullWriter = struct {
+    pub const Error = error{};
+
+    pub fn writeByte(self: NullWriter, byte: u8) Error!void {
+        _ = .{ self, byte };
     }
 
-    pub fn writeByte(self: *ByteStream, byte: u8) Writer.Error!void {
-        if (self.pos >= self.buffer.len) return error.NoSpaceLeft;
-        self.buffer[self.pos] = byte;
-        self.pos += 1;
+    pub fn writeAll(self: NullWriter, bytes: []const u8) Error!void {
+        _ = .{ self, bytes };
     }
 
-    pub fn reset(self: *ByteStream) void {
-        self.pos = 0;
+    pub fn writeInt(self: NullWriter, comptime T: type, v: T, end: std.builtin.Endian) Error!void {
+        _ = .{ self, T, v, end };
     }
 };
 
 pub const Kind = enum { Move, Species, Type, Status, Item, Weather };
 
 pub fn format(
-    comptime gen: anytype,
+    gen: anytype,
     a: []const u8,
     b: ?[]const u8,
     color: bool,
@@ -945,7 +969,7 @@ pub fn format(
                     if (a[i] == N(gen.Gender.Unknown)) {
                         i += 1;
                     } else {
-                        var gender = if (a[i] == N(gen.Gender.Male)) "M" else "F";
+                        const gender = if (a[i] == N(gen.Gender.Male)) "M" else "F";
                         printc(", {s}", .{gender}, a, b, &i, 1, color);
                     }
                 }
@@ -1202,15 +1226,8 @@ pub fn expectLog(
 ) !void {
     if (!enabled) return;
 
-    const color = color: {
-        if (std.process.hasEnvVarConstant("ZIG_DEBUG_COLOR")) {
-            break :color true;
-        } else if (std.process.hasEnvVarConstant("NO_COLOR")) {
-            break :color false;
-        } else {
-            break :color std.io.getStdErr().supportsAnsiEscapeCodes();
-        }
-    };
+    // TODO: ziglang/zig#30833 - read from environment
+    const color = true;
 
     expectEqualBytes(expected, actual, offset) catch |err| switch (err) {
         error.TestExpectedEqual => {
@@ -1218,7 +1235,6 @@ pub fn expectLog(
             format(gen, actual, expected, color);
             return err;
         },
-        else => return err,
     };
 }
 
@@ -1226,7 +1242,7 @@ fn expectEqualBytes(expected: []const u8, actual: []const u8, offset: usize) !vo
     for (offset..@min(expected.len, actual.len)) |i| {
         if (expected[i] != actual[i]) {
             print(
-                "index {} incorrect. expected 0x{X:0>2}, found 0x{X:0>2}\n",
+                "index {d} incorrect. expected 0x{X:0>2}, found 0x{X:0>2}\n",
                 .{ i, expected[i], actual[i] },
             );
             return error.TestExpectedEqual;
@@ -1248,19 +1264,12 @@ fn N(e: anytype) u8 {
 const p1 = Player.P1;
 const p2 = Player.P2;
 
-const gen1 = struct {
-    pub usingnamespace @import("../gen1/data.zig");
-    pub const helpers = @import("../gen1/helpers.zig");
-};
-
-const gen2 = struct {
-    pub usingnamespace @import("../gen2/data.zig");
-    pub const helpers = @import("../gen2/helpers.zig");
-};
-
 var buf: [pkmn.LOGS_SIZE]u8 = undefined;
-var stream: ByteStream = .{ .buffer = &buf };
-var log: FixedLog = .{ .writer = stream.writer() };
+var writer: Writer = .{ .buffer = &buf };
+var log: FixedLog = .{ .writer = &writer };
+
+const gen1 = pkmn.gen1;
+const gen2 = pkmn.gen2;
 
 const M1 = gen1.Move;
 const S1 = gen1.Species;
@@ -1301,14 +1310,14 @@ test "|move|" {
         &.{ N(ArgType.Move), 0b1100, N(M1.Thunderbolt), 0b0101, N(Move.None) },
         buf[0..5],
     );
-    stream.reset();
+    writer.reset();
 
     try log.move(.{ p2.ident(4), M1.Pound, p1.ident(5), M1.Metronome });
     try expectLog1(
         &.{ N(ArgType.Move), 0b1100, N(M1.Pound), 0b0101, N(Move.From), N(M1.Metronome) },
         buf[0..6],
     );
-    stream.reset();
+    writer.reset();
 
     try log.move(.{ p2.ident(4), M1.SkullBash, ID{} });
     try log.laststill(.{});
@@ -1323,7 +1332,7 @@ test "|move|" {
         },
         buf[0..6],
     );
-    stream.reset();
+    writer.reset();
 
     try log.move(.{ p2.ident(4), M1.Tackle, p1.ident(5) });
     try log.lastmiss(.{});
@@ -1338,7 +1347,7 @@ test "|move|" {
         },
         buf[0..6],
     );
-    stream.reset();
+    writer.reset();
 }
 
 test "|switch|" {
@@ -1354,7 +1363,7 @@ test "|switch|" {
         .little => &.{ N(ArgType.Switch), 0b1011, N(S1.Snorlax), 91, 200, 0, 144, 1, par },
     };
     try expectLog1(expected, buf[0..9]);
-    stream.reset();
+    writer.reset();
 
     snorlax.level = 100;
     snorlax.hp = 0;
@@ -1365,7 +1374,7 @@ test "|switch|" {
         .little => &.{ N(ArgType.Switch), 0b1011, N(S1.Snorlax), 100, 0, 0, 144, 1, 0 },
     };
     try expectLog1(expected, buf[0..9]);
-    stream.reset();
+    writer.reset();
 
     snorlax.hp = 400;
     try log.switched(.{ p2.ident(3), &snorlax });
@@ -1374,7 +1383,7 @@ test "|switch|" {
         .little => &.{ N(ArgType.Switch), 0b1011, N(S1.Snorlax), 100, 144, 1, 144, 1, 0 },
     };
     try expectLog1(expected, buf[0..9]);
-    stream.reset();
+    writer.reset();
 
     var blissey = gen2.helpers.Pokemon.init(.{ .species = .Blissey, .moves = &.{.Splash} });
     blissey.level = 91;
@@ -1393,49 +1402,49 @@ test "|switch|" {
         .little => .{ 200, 0, 144, 1, par },
     });
     try expectLog2(expected, buf[0..10]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|cant|" {
     try log.cant(.{ p2.ident(6), .Bound });
     try expectLog1(&.{ N(ArgType.Cant), 0b1110, N(Cant.Bound) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 
     try log.cant(.{ p1.ident(2), .Disable, M1.Earthquake });
     try expectLog1(&.{ N(ArgType.Cant), 2, N(Cant.Disable), N(M1.Earthquake) }, buf[0..4]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|faint|" {
     try log.faint(.{ p2.ident(2), false });
     try expectLog1(&.{ N(ArgType.Faint), 0b1010 }, buf[0..2]);
-    stream.reset();
+    writer.reset();
 
     try log.faint(.{ p2.ident(2), true });
     try expectLog1(&.{ N(ArgType.Faint), 0b1010, N(ArgType.None) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|turn|" {
     try log.turn(.{42});
-    var expected = switch (endian) {
+    const expected = switch (endian) {
         .big => &.{ N(ArgType.Turn), 0, 42, N(ArgType.None) },
         .little => &.{ N(ArgType.Turn), 42, 0, N(ArgType.None) },
     };
     try expectLog1(expected, buf[0..4]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|win|" {
     try log.win(.{.P2});
     try expectLog1(&.{ N(ArgType.Win), 1, N(ArgType.None) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|tie|" {
     try log.tie(.{});
     try expectLog1(&.{ N(ArgType.Tie), N(ArgType.None) }, buf[0..2]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-damage|" {
@@ -1448,7 +1457,7 @@ test "|-damage|" {
         .little => &.{ N(ArgType.Damage), 0b1010, 100, 2, 191, 2, 1, N(Damage.None) },
     };
     try expectLog1(expected, buf[0..8]);
-    stream.reset();
+    writer.reset();
 
     chansey.hp = 100;
     chansey.stats.hp = 256;
@@ -1459,7 +1468,7 @@ test "|-damage|" {
         .little => &.{ N(ArgType.Damage), 0b1010, 100, 0, 0, 1, 0, N(Damage.Confusion) },
     };
     try expectLog1(expected, buf[0..8]);
-    stream.reset();
+    writer.reset();
 
     chansey.status = gen1.Status.init(.PSN);
     try log.damage(.{ p2.ident(2), &chansey, .RecoilOf, p1.ident(1) });
@@ -1468,7 +1477,7 @@ test "|-damage|" {
         .little => &.{ N(ArgType.Damage), 0b1010, 100, 0, 0, 1, 0b1000, N(Damage.RecoilOf), 1 },
     };
     try expectLog1(expected, buf[0..9]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-heal|" {
@@ -1481,7 +1490,7 @@ test "|-heal|" {
         .little => &.{ N(ArgType.Heal), 0b1010, 100, 2, 191, 2, 1, N(Heal.None) },
     };
     try expectLog1(expected, buf[0..8]);
-    stream.reset();
+    writer.reset();
 
     chansey.hp = 100;
     chansey.stats.hp = 256;
@@ -1492,7 +1501,7 @@ test "|-heal|" {
         .little => &.{ N(ArgType.Heal), 0b1010, 100, 0, 0, 1, 0, N(Heal.Silent) },
     };
     try expectLog1(expected, buf[0..8]);
-    stream.reset();
+    writer.reset();
 
     try log.heal(.{ p2.ident(2), &chansey, .Drain, p1.ident(1) });
     expected = switch (endian) {
@@ -1500,30 +1509,30 @@ test "|-heal|" {
         .little => &.{ N(ArgType.Heal), 0b1010, 100, 0, 0, 1, 0, N(Heal.Drain), 1 },
     };
     try expectLog1(expected, buf[0..9]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-status|" {
     try log.status(.{ p2.ident(6), gen1.Status.init(.BRN), .None });
     try expectLog1(&.{ N(ArgType.Status), 0b1110, 0b10000, N(Status.None) }, buf[0..4]);
-    stream.reset();
+    writer.reset();
 
     try log.status(.{ p2.ident(2), gen1.Status.init(.PSN), .Silent });
     try expectLog1(&.{ N(ArgType.Status), 0b1010, 0b1000, N(Status.Silent) }, buf[0..4]);
-    stream.reset();
+    writer.reset();
 
     try log.status(.{ p1.ident(1), gen1.Status.init(.PAR), .From, M1.BodySlam });
     try expectLog1(
         &.{ N(ArgType.Status), 0b0001, 0b1000000, N(Status.From), N(M1.BodySlam) },
         buf[0..5],
     );
-    stream.reset();
+    writer.reset();
 }
 
 test "|-curestatus|" {
     try log.curestatus(.{ p2.ident(6), gen1.Status.slp(7), .Message });
     try expectLog1(&.{ N(ArgType.CureStatus), 0b1110, 0b111, N(CureStatus.Message) }, buf[0..4]);
-    stream.reset();
+    writer.reset();
 
     try log.curestatus(.{ p1.ident(2), gen1.Status.TOX, .Silent });
     try expectLog1(&.{
@@ -1532,86 +1541,86 @@ test "|-curestatus|" {
         0b10001000,
         N(CureStatus.Silent),
     }, buf[0..4]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-boost|" {
     try log.boost(.{ p2.ident(6), .Speed, 2 });
     try expectLog1(&.{ N(ArgType.Boost), 0b1110, N(Boost.Speed), 8 }, buf[0..4]);
-    stream.reset();
+    writer.reset();
 
     try log.boost(.{ p1.ident(2), .Rage, 1 });
     try expectLog1(&.{ N(ArgType.Boost), 0b0010, N(Boost.Rage), 7 }, buf[0..4]);
-    stream.reset();
+    writer.reset();
 
     try log.boost(.{ p2.ident(3), .Defense, -2 });
     try expectLog1(&.{ N(ArgType.Boost), 0b1011, N(Boost.Defense), 4 }, buf[0..4]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-clearallboost|" {
     try log.clearallboost(.{});
     try expectLog1(&.{N(ArgType.ClearAllBoost)}, buf[0..1]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-fail|" {
     try log.fail(.{ p2.ident(6), .None });
     try expectLog1(&.{ N(ArgType.Fail), 0b1110, N(Fail.None) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 
     try log.fail(.{ p2.ident(6), .Sleep });
     try expectLog1(&.{ N(ArgType.Fail), 0b1110, N(Fail.Sleep) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 
     try log.fail(.{ p2.ident(6), .Substitute });
     try expectLog1(&.{ N(ArgType.Fail), 0b1110, N(Fail.Substitute) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 
     try log.fail(.{ p2.ident(6), .Weak });
     try expectLog1(&.{ N(ArgType.Fail), 0b1110, N(Fail.Weak) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-miss|" {
     try log.miss(.{p2.ident(4)});
     try expectLog1(&.{ N(ArgType.Miss), 0b1100 }, buf[0..2]);
-    stream.reset();
+    writer.reset();
 }
 test "|-hitcount|" {
     try log.hitcount(.{ p2.ident(1), 5 });
     try expectLog1(&.{ N(ArgType.HitCount), 0b1001, 5 }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-prepare|" {
     try log.prepare(.{ p2.ident(2), M1.Dig });
     try expectLog1(&.{ N(ArgType.Prepare), 0b1010, N(M1.Dig) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-mustrecharge|" {
     try log.mustrecharge(.{p1.ident(6)});
     try expectLog1(&.{ N(ArgType.MustRecharge), 0b0110 }, buf[0..2]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-activate|" {
     try log.activate(.{ p1.ident(2), .Struggle });
     try expectLog1(&.{ N(ArgType.Activate), 0b0010, N(Activate.Struggle) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 
     try log.activate(.{ p2.ident(4), .Mist });
     try expectLog1(&.{ N(ArgType.Activate), 0b1100, N(Activate.Mist) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 
     try log.activate(.{ p2.ident(6), .Substitute });
     try expectLog1(&.{ N(ArgType.Activate), 0b1110, N(Activate.Substitute) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 
     try log.activate(.{ p1.ident(2), .Splash });
     try expectLog1(&.{ N(ArgType.Activate), 0b0010, N(Activate.Splash) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 
     try log.activate(.{ p1.ident(4), .SubstituteBlock, M2.Spite });
     try expectLog1(&.{
@@ -1620,27 +1629,27 @@ test "|-activate|" {
         N(Activate.SubstituteBlock),
         N(M2.Spite),
     }, buf[0..4]);
-    stream.reset();
+    writer.reset();
 
     try log.activate(.{ p1.ident(3), .Magnitude, 5 });
     try expectLog1(&.{ N(ArgType.Activate), 0b0011, N(Activate.Magnitude), 5 }, buf[0..4]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-fieldactivate|" {
     try log.fieldactivate(.{});
     try expectLog1(&.{N(ArgType.FieldActivate)}, buf[0..1]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-start|" {
     try log.start(.{ p2.ident(6), .Bide });
     try expectLog1(&.{ N(ArgType.Start), 0b1110, N(Start.Bide) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 
     try log.start(.{ p1.ident(2), .ConfusionSilent });
     try expectLog1(&.{ N(ArgType.Start), 0b0010, N(Start.ConfusionSilent) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 
     try log.start(.{
         p2.ident(6),
@@ -1652,7 +1661,7 @@ test "|-start|" {
         &.{ N(ArgType.Start), 0b1110, N(Start.TypeChange), 0b1000_1000, 0b1101 },
         buf[0..5],
     );
-    stream.reset();
+    writer.reset();
 
     try log.start(.{
         p1.ident(2),
@@ -1664,65 +1673,65 @@ test "|-start|" {
         &.{ N(ArgType.Start), 0b0010, N(Start.TypeChange), 0b0011_0110, 0b1100 },
         buf[0..5],
     );
-    stream.reset();
+    writer.reset();
 
     try log.start(.{ p1.ident(2), .Disable, M1.Surf });
     try expectLog1(&.{ N(ArgType.Start), 0b0010, N(Start.Disable), N(M1.Surf) }, buf[0..4]);
-    stream.reset();
+    writer.reset();
 
     try log.start(.{ p1.ident(2), .Mimic, M1.Surf });
     try expectLog1(&.{ N(ArgType.Start), 0b0010, N(Start.Mimic), N(M1.Surf) }, buf[0..4]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-end|" {
     try log.end(.{ p2.ident(6), .Bide });
     try expectLog1(&.{ N(ArgType.End), 0b1110, N(End.Bide) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 
     try log.end(.{ p1.ident(2), .ConfusionSilent });
     try expectLog1(&.{ N(ArgType.End), 0b0010, N(End.ConfusionSilent) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-ohko|" {
     try log.ohko(.{});
     try expectLog1(&.{N(ArgType.OHKO)}, buf[0..1]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-crit|" {
     try log.crit(.{p2.ident(5)});
     try expectLog1(&.{ N(ArgType.Crit), 0b1101 }, buf[0..2]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-supereffective|" {
     try log.supereffective(.{p1.ident(1)});
     try expectLog1(&.{ N(ArgType.SuperEffective), 0b0001 }, buf[0..2]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-resisted|" {
     try log.resisted(.{p2.ident(2)});
     try expectLog1(&.{ N(ArgType.Resisted), 0b1010 }, buf[0..2]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-immune|" {
     try log.immune(.{ p1.ident(3), .None });
     try expectLog1(&.{ N(ArgType.Immune), 0b0011, N(Immune.None) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 
     try log.immune(.{ p2.ident(2), .OHKO });
     try expectLog1(&.{ N(ArgType.Immune), 0b1010, N(Immune.OHKO) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-transform|" {
     try log.transform(.{ p2.ident(4), p1.ident(5) });
     try expectLog1(&.{ N(ArgType.Transform), 0b1100, 0b0101 }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|drag|" {
@@ -1744,69 +1753,69 @@ test "|drag|" {
         .little => .{ 200, 0, 144, 1, par },
     });
     try expectLog2(expected, buf[0..10]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-item|" {
     try log.item(.{ p2.ident(2), I2.GoldBerry, p1.ident(4) });
     try expectLog2(&.{ N(ArgType.Item), 0b1010, N(I2.GoldBerry), 0b0100 }, buf[0..4]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-enditem|" {
     try log.enditem(.{ p1.ident(1), I2.BerserkGene, .None });
     try expectLog2(&.{ N(ArgType.EndItem), 0b0001, N(I2.BerserkGene), N(EndItem.None) }, buf[0..4]);
-    stream.reset();
+    writer.reset();
 
     try log.enditem(.{ p2.ident(4), I2.PRZCureBerry, .Eat });
     try expectLog2(&.{ N(ArgType.EndItem), 0b1100, N(I2.PRZCureBerry), N(EndItem.Eat) }, buf[0..4]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-cureteam|" {
     try log.cureteam(.{p2.ident(5)});
     try expectLog2(&.{ N(ArgType.CureTeam), 0b1101 }, buf[0..2]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-sethp|" {
     var blissey = gen2.helpers.Pokemon.init(.{ .species = .Blissey, .moves = &.{.PainSplit} });
     blissey.hp = 612;
     try log.sethp(.{ p2.ident(2), &blissey, .Silent });
-    var expected: []const u8 = switch (endian) {
+    const expected: []const u8 = switch (endian) {
         .big => &.{ N(ArgType.SetHP), 0b1010, 2, 100, 2, 201, 0, N(SetHP.Silent) },
         .little => &.{ N(ArgType.SetHP), 0b1010, 100, 2, 201, 2, 0, N(SetHP.Silent) },
     };
     try expectLog2(expected, buf[0..8]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-setboost|" {
     try log.setboost(.{ p2.ident(6), 6 });
     try expectLog2(&.{ N(ArgType.SetBoost), 0b1110, 12 }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 
     try log.setboost(.{ p2.ident(3), 2 });
     try expectLog2(&.{ N(ArgType.SetBoost), 0b1011, 8 }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-copyboost|" {
     try log.copyboost(.{ p2.ident(3), p1.ident(6) });
     try expectLog2(&.{ N(ArgType.CopyBoost), 0b1011, 0b0110 }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-sidestart|" {
     try log.sidestart(.{ .P2, .Reflect });
     try expectLog2(&.{ N(ArgType.SideStart), 1, N(Side.Reflect) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-sideend|" {
     try log.sideend(.{ .P2, .LightScreen });
     try expectLog2(&.{ N(ArgType.SideEnd), 1, N(Side.LightScreen) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 
     try log.sideend(.{ .P1, .Spikes, p1.ident(3) });
     try expectLog2(&.{
@@ -1815,27 +1824,27 @@ test "|-sideend|" {
         N(Side.Spikes),
         0b0011,
     }, buf[0..4]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-singlemove|" {
     try log.singlemove(.{ p2.ident(2), M2.DestinyBond });
     try expectLog2(&.{ N(ArgType.SingleMove), 0b1010, N(M2.DestinyBond) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-singleturn|" {
     try log.singleturn(.{ p1.ident(3), M2.Protect });
     try expectLog2(&.{ N(ArgType.SingleTurn), 0b0011, N(M2.Protect) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 }
 
 test "|-weather|" {
     try log.weather(.{ W2.Rain, .Upkeep });
     try expectLog2(&.{ N(ArgType.Weather), N(W2.Rain), N(Weather.Upkeep) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 
     try log.weather(.{ W2.None, .None });
     try expectLog2(&.{ N(ArgType.Weather), N(W2.None), N(Weather.None) }, buf[0..3]);
-    stream.reset();
+    writer.reset();
 }