@pixpilot/scaffoldfy-configs 0.48.2 → 0.48.4

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @pixpilot/scaffoldfy-configs
 
+## 0.48.4
+
+### Patch Changes
+
+- pass registry token to release installs
+- 3fc21c9: fix(pixpilot-changesets-release): pass secrets to the reusable CI workflow and the registry token to the GitHub Packages release install, so `@pixpilot-private` dependencies no longer fail with a 401
+
+## 0.48.3
+
+### Patch Changes
+
+- update package.json.hbs for dependency cataloging
+
 ## 0.48.2
 
 ### Patch Changes

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@pixpilot/scaffoldfy-configs",
   "type": "module",
-  "version": "0.48.2",
+  "version": "0.48.4",
   "author": "PixPilot <m.doaie@hotmail.com>",
   "license": "MIT",
   "repository": {
@@ -29,11 +29,11 @@
   "devDependencies": {
     "@types/node": "^22.18.11",
     "eslint": "^9.38.0",
-    "@internal/eslint-config": "0.3.0",
     "@internal/prettier-config": "0.0.1",
+    "@internal/tsdown-config": "0.1.0",
+    "@internal/eslint-config": "0.3.0",
     "@internal/vitest-config": "0.1.0",
-    "@pixpilot/scaffoldfy": "0.58.0",
-    "@internal/tsdown-config": "0.1.0"
+    "@pixpilot/scaffoldfy": "0.58.0"
   },
   "prettier": "@internal/prettier-config",
   "publishConfig": {

package/pixpilot-changesets-release/release-github-packages.yml

@@ -13,6 +13,9 @@ jobs:
   ci:
     name: Run CI Checks
     uses: ./.github/workflows/ci.yml
+    # Called workflows get no secrets unless passed; without this the CI
+    # install runs with an empty PIXPILOT_PRIVATE_REGISTRY_TOKEN and 401s.
+    secrets: inherit
 
   release:
     name: Create Release and Publish
@@ -49,6 +52,11 @@ jobs:
 
       - name: Setup project
         uses: pixpilot/github-actions/setup-pnpm-project@v1
+        env:
+          # setup-node's .npmrc reads ${NODE_AUTH_TOKEN}; it is needed to install
+          # @pixpilot-private dependencies. npm-auth-token would not work here:
+          # it writes ~/.npmrc, which setup-node's NPM_CONFIG_USERCONFIG shadows.
+          NODE_AUTH_TOKEN: ${{ secrets.PIXPILOT_PRIVATE_REGISTRY_TOKEN }}
         with:
           registry-url: 'https://npm.pkg.github.com'
           # setup-node defaults the scope to the repository owner. Left to that

package/pixpilot-changesets-release/release.yml

@@ -13,6 +13,9 @@ jobs:
   ci:
     name: Run CI Checks
     uses: ./.github/workflows/ci.yml
+    # Called workflows get no secrets unless passed; without this a CI that
+    # installs private packages runs with an empty registry token and 401s.
+    secrets: inherit
 
   release:
     name: Create Release and Publish

package/test/workspace-package-generator.test.ts

@@ -234,6 +234,7 @@ describe('workspace-package-generator – package.json.hbs rendering', () => {
 
     expect(pkg.name).toBe('@internal/my-package');
     expect(pkg.private).toBe(true);
+    expect(pkg.packageManager).toBe('pnpm@10.34.5');
     expect(pkg.sideEffects).toBeUndefined();
     expect(pkg.publishConfig).toBeUndefined();
     expect(pkg.files).toBeUndefined();
@@ -241,9 +242,26 @@ describe('workspace-package-generator – package.json.hbs rendering', () => {
     expect(pkg.scripts?.['test:ui:coverage']).toBe(
       'vitest --ui --coverage --watch --hookTimeout=30000 --coverage.thresholds.lines=0 --coverage.thresholds.functions=0 --coverage.thresholds.branches=0 --coverage.thresholds.statements=0',
     );
-    expect(pkg.devDependencies?.['@vitest/coverage-v8']).toBe('catalog:dev');
-    expect(pkg.devDependencies?.['@vitest/ui']).toBe('catalog:dev');
-    expect(pkg.devDependencies?.vitest).toBe('catalog:dev');
+    expect(pkg.devDependencies?.['@types/node']).toBe('catalog:tooling');
+    expect(pkg.devDependencies?.['@vitest/coverage-v8']).toBe('catalog:testing');
+    expect(pkg.devDependencies?.['@vitest/ui']).toBe('catalog:testing');
+    expect(pkg.devDependencies?.eslint).toBe('catalog:tooling');
+    expect(pkg.devDependencies?.typescript).toBe('catalog:tooling');
+    expect(pkg.devDependencies?.vitest).toBe('catalog:testing');
+  });
+
+  it('should use the React catalog for internal React packages', () => {
+    const rendered = renderHbs(tplPath, {
+      packageBaseName: 'ui',
+      isPublishablePackage: false,
+      isReactPackage: true,
+      relativeRootPath: '../../',
+    });
+    const pkg = JSON.parse(rendered);
+
+    for (const name of ['@types/react', '@types/react-dom', 'react', 'react-dom']) {
+      expect(pkg.devDependencies?.[name]).toBe('catalog:react');
+    }
   });
 
   /** Public npm package with tsdown bundler */
@@ -277,7 +295,7 @@ describe('workspace-package-generator – package.json.hbs rendering', () => {
     expect(pkg.files).toContain('dist');
     expect(pkg.scripts?.build).toBe('tsdown');
     expect(pkg.devDependencies?.['@pixpilot/tsdown-config']).toBeDefined();
-    expect(pkg.devDependencies?.tsdown).toBe('catalog:dev');
+    expect(pkg.devDependencies?.tsdown).toBe('catalog:tooling');
   });
 
   /** Private npm package with tsc bundler */

package/workspace-package-generator/templates/package.json.hbs

@@ -5,7 +5,7 @@
   {{#unless isPublishablePackage}}
   "private": true,
   {{/unless}}
-  "packageManager": "pnpm@10.17.0",
+  "packageManager": "pnpm@10.34.5",
   {{#if author}}
   "author": "{{author}} <{{authorEmail}}>",
   {{/if}}
@@ -93,39 +93,39 @@
     {{#if isPublishablePackage}}
     {{#if isBundlerTsdown}}
     {{#unless hasTsdownConfig}}
-    "{{tsdownConfigPackage}}": "^1.0.0",
+    "{{tsdownConfigPackage}}": "catalog:tooling",
     {{/unless}}
     {{/if}}
     {{/if}}
-    "@types/node": "catalog:dev",
+    "@types/node": "catalog:tooling",
     {{#if isReactPackage}}
     {{#if isPublishablePackage}}
-    "@types/react": "^19.0.0",
-    "@types/react-dom": "^19.0.0",
+    "@types/react": "catalog:react",
+    "@types/react-dom": "catalog:react",
     {{else}}
-    "@types/react": "catalog:",
-    "@types/react-dom": "catalog:",
+    "@types/react": "catalog:react",
+    "@types/react-dom": "catalog:react",
     {{/if}}
     {{/if}}
-    "@vitest/coverage-v8": "catalog:dev",
-    "@vitest/ui": "catalog:dev",
-    "eslint": "catalog:dev",
+    "@vitest/coverage-v8": "catalog:testing",
+    "@vitest/ui": "catalog:testing",
+    "eslint": "catalog:tooling",
     {{#if isReactPackage}}
     {{#if isPublishablePackage}}
-    "react": "^19.0.0",
-    "react-dom": "^19.0.0",
+    "react": "catalog:react",
+    "react-dom": "catalog:react",
     {{else}}
-    "react": "catalog:",
-    "react-dom": "catalog:",
+    "react": "catalog:react",
+    "react-dom": "catalog:react",
     {{/if}}
     {{/if}}
     {{#if isPublishablePackage}}
     {{#if isBundlerTsdown}}
-    "tsdown": "catalog:dev",
+    "tsdown": "catalog:tooling",
     {{/if}}
     {{/if}}
-    "typescript": "catalog:dev",
-    "vitest": "catalog:dev"
+    "typescript": "catalog:tooling",
+    "vitest": "catalog:testing"
   },
   "prettier": "@internal/prettier-config"
 }