@pixelbyte-software/pixcode 1.51.2 → 1.51.4

package/server/modules/orchestration/tasks/orchestration-task.types.ts

@@ -1,40 +1,40 @@
-export type OrchestrationTaskState = 'todo' | 'in_progress' | 'in_review' | 'done' | 'failed' | 'canceled';
-
-export interface OrchestrationTask {
-  id: string;
-  hermesTaskId?: string;
-  workflowRunIds?: string[];
-  projectId: string;
-  title: string;
-  description?: string;
-  state: OrchestrationTaskState;
-  acceptanceCriteria?: Array<{
-    id: string;
-    label: string;
-    status: 'pending' | 'passed' | 'failed';
-    source: 'workflow' | 'hermes';
-  }>;
-  changedFiles?: string[];
-  adapterId?: string;
-  adapterSelector?: string;
-  workspaceKind?: 'host' | 'worktree' | 'docker';
-  workspacePath?: string;
-  createdAt: number;
-  updatedAt: number;
-}
-
-export interface CreateOrchestrationTaskInput {
-  projectId: string;
-  title: string;
-  description?: string;
-  acceptanceCriteria?: OrchestrationTask['acceptanceCriteria'];
-  changedFiles?: string[];
-}
-
-export interface DispatchOrchestrationTaskInput {
-  adapterId: string;
-  isolation?: 'host' | 'worktree' | 'docker';
-  projectPath?: string;
-  model?: string;
-  permissionMode?: string;
-}
+export type OrchestrationTaskState = 'todo' | 'in_progress' | 'in_review' | 'done' | 'failed' | 'canceled';
+
+export interface OrchestrationTask {
+  id: string;
+  hermesTaskId?: string;
+  workflowRunIds?: string[];
+  projectId: string;
+  title: string;
+  description?: string;
+  state: OrchestrationTaskState;
+  acceptanceCriteria?: Array<{
+    id: string;
+    label: string;
+    status: 'pending' | 'passed' | 'failed';
+    source: 'workflow' | 'hermes';
+  }>;
+  changedFiles?: string[];
+  adapterId?: string;
+  adapterSelector?: string;
+  workspaceKind?: 'host' | 'worktree' | 'docker';
+  workspacePath?: string;
+  createdAt: number;
+  updatedAt: number;
+}
+
+export interface CreateOrchestrationTaskInput {
+  projectId: string;
+  title: string;
+  description?: string;
+  acceptanceCriteria?: OrchestrationTask['acceptanceCriteria'];
+  changedFiles?: string[];
+}
+
+export interface DispatchOrchestrationTaskInput {
+  adapterId: string;
+  isolation?: 'host' | 'worktree' | 'docker';
+  projectPath?: string;
+  model?: string;
+  permissionMode?: string;
+}

package/server/modules/orchestration/tasks/task-run-graph.ts

@@ -1,155 +1,155 @@
-import type { WorkflowNodeRun, WorkflowRun } from '@/modules/orchestration/workflows/workflow.types.js';
-import { workflowStore } from '@/modules/orchestration/workflows/workflow-store.js';
-import { orchestrationTaskService } from '@/modules/orchestration/tasks/orchestration-task.service.js';
-import type { OrchestrationTask } from '@/modules/orchestration/tasks/orchestration-task.types.js';
-
-export const PIXCODE_TASK_RUN_GRAPH_PROTOCOL = 'pixcode.task-run-graph.v1';
-
-export type TaskRunGraphCriterionStatus = 'pending' | 'passed' | 'failed';
-
-export interface TaskRunGraphCriterion {
-  id: string;
-  label: string;
-  status: TaskRunGraphCriterionStatus;
-  source: 'workflow' | 'hermes';
-}
-
-export interface TaskRunGraphRunSummary {
-  id: string;
-  workflowId: string;
-  status: WorkflowRun['status'];
-  startedAt: number;
-  finishedAt?: number;
-  orchestrationTaskId?: string;
-  changedFiles: string[];
-}
-
-export interface TaskRunGraph {
-  protocol: typeof PIXCODE_TASK_RUN_GRAPH_PROTOCOL;
-  projectId: string;
-  orchestrationTaskId?: string;
-  workflowRuns: TaskRunGraphRunSummary[];
-  changedFiles: string[];
-  acceptanceCriteria: TaskRunGraphCriterion[];
-  status: {
-    totalRuns: number;
-    completedRuns: number;
-    failedRuns: number;
-    passedCriteria: number;
-    failedCriteria: number;
-  };
-}
-
-function readString(value: unknown): string | undefined {
-  return typeof value === 'string' && value.trim() ? value.trim() : undefined;
-}
-
-function readRecord(value: unknown): Record<string, unknown> | undefined {
-  return value && typeof value === 'object' ? value as Record<string, unknown> : undefined;
-}
-
-function uniqueStrings(values: Array<string | undefined>): string[] {
-  return [...new Set(values.filter((value): value is string => Boolean(value?.trim())))]
-    .sort((a, b) => a.localeCompare(b));
-}
-
-function metadataOrchestrationTaskId(run: WorkflowRun): string | undefined {
-  return readString(run.metadata?.orchestrationTaskId)
-    ?? readString(readRecord(run.metadata?.taskGraph)?.orchestrationTaskId);
-}
-
-function artifactChangedFiles(node: WorkflowNodeRun): string[] {
-  const files: string[] = [];
-
-  if (node.handoffArtifact?.changedFiles) {
-    files.push(...node.handoffArtifact.changedFiles);
-  }
-
-  for (const artifact of node.artifacts ?? []) {
-    const data = readRecord(artifact.data);
-    const metadata = readRecord(artifact.metadata);
-    const candidates = [
-      readString(metadata?.path),
-      readString(metadata?.file),
-      readString(data?.path),
-      readString(data?.file),
-    ];
-    files.push(...candidates.filter((value): value is string => Boolean(value)));
-
-    for (const key of ['files', 'changedFiles']) {
-      const value = data?.[key] ?? metadata?.[key];
-      if (Array.isArray(value)) {
-        files.push(...value.map((entry) => readString(entry)).filter((entry): entry is string => Boolean(entry)));
-      }
-    }
-  }
-
-  return uniqueStrings(files);
-}
-
-export function changedFilesFromWorkflowRun(run: WorkflowRun): string[] {
-  return uniqueStrings(run.nodeRuns.flatMap((node) => artifactChangedFiles(node)));
-}
-
-function workflowRunMatchesTask(run: WorkflowRun, task: OrchestrationTask | undefined): boolean {
-  const runOrchestrationTaskId = metadataOrchestrationTaskId(run);
-  if (task?.id && runOrchestrationTaskId === task.id) return true;
-  if (task?.workflowRunIds?.includes(run.id)) return true;
-  return false;
-}
-
-function runSummary(run: WorkflowRun): TaskRunGraphRunSummary {
-  return {
-    id: run.id,
-    workflowId: run.workflowId,
-    status: run.status,
-    startedAt: run.startedAt,
-    finishedAt: run.finishedAt,
-    orchestrationTaskId: metadataOrchestrationTaskId(run),
-    changedFiles: changedFilesFromWorkflowRun(run),
-  };
-}
-
-export function buildTaskRunGraph({
-  projectId,
-  orchestrationTaskId,
-}: {
-  projectId: string;
-  orchestrationTaskId?: string;
-}): TaskRunGraph {
-  const orchestrationTask = orchestrationTaskId ? orchestrationTaskService.get(orchestrationTaskId) : undefined;
-  const workflowRuns = workflowStore
-    .listRuns()
-    .filter((run) => workflowRunMatchesTask(run, orchestrationTask))
-    .map(runSummary);
-  const workflowCriteria: TaskRunGraphCriterion[] = workflowRuns.map((run) => ({
-    id: `run-${run.id}`,
-    label: `Workflow ${run.workflowId} ${run.status}`,
-    status: run.status === 'completed' ? 'passed' : run.status === 'failed' || run.status === 'canceled' ? 'failed' : 'pending',
-    source: 'workflow',
-  }));
-  const acceptanceCriteria = [
-    ...(orchestrationTask?.acceptanceCriteria ?? []),
-    ...workflowCriteria,
-  ];
-  const changedFiles = uniqueStrings([
-    ...(orchestrationTask?.changedFiles ?? []),
-    ...workflowRuns.flatMap((run) => run.changedFiles),
-  ]);
-
-  return {
-    protocol: PIXCODE_TASK_RUN_GRAPH_PROTOCOL,
-    projectId,
-    orchestrationTaskId: orchestrationTask?.id,
-    workflowRuns,
-    changedFiles,
-    acceptanceCriteria,
-    status: {
-      totalRuns: workflowRuns.length,
-      completedRuns: workflowRuns.filter((run) => run.status === 'completed').length,
-      failedRuns: workflowRuns.filter((run) => run.status === 'failed' || run.status === 'canceled').length,
-      passedCriteria: acceptanceCriteria.filter((criterion) => criterion.status === 'passed').length,
-      failedCriteria: acceptanceCriteria.filter((criterion) => criterion.status === 'failed').length,
-    },
-  };
-}
+import type { WorkflowNodeRun, WorkflowRun } from '@/modules/orchestration/workflows/workflow.types.js';
+import { workflowStore } from '@/modules/orchestration/workflows/workflow-store.js';
+import { orchestrationTaskService } from '@/modules/orchestration/tasks/orchestration-task.service.js';
+import type { OrchestrationTask } from '@/modules/orchestration/tasks/orchestration-task.types.js';
+
+export const PIXCODE_TASK_RUN_GRAPH_PROTOCOL = 'pixcode.task-run-graph.v1';
+
+export type TaskRunGraphCriterionStatus = 'pending' | 'passed' | 'failed';
+
+export interface TaskRunGraphCriterion {
+  id: string;
+  label: string;
+  status: TaskRunGraphCriterionStatus;
+  source: 'workflow' | 'hermes';
+}
+
+export interface TaskRunGraphRunSummary {
+  id: string;
+  workflowId: string;
+  status: WorkflowRun['status'];
+  startedAt: number;
+  finishedAt?: number;
+  orchestrationTaskId?: string;
+  changedFiles: string[];
+}
+
+export interface TaskRunGraph {
+  protocol: typeof PIXCODE_TASK_RUN_GRAPH_PROTOCOL;
+  projectId: string;
+  orchestrationTaskId?: string;
+  workflowRuns: TaskRunGraphRunSummary[];
+  changedFiles: string[];
+  acceptanceCriteria: TaskRunGraphCriterion[];
+  status: {
+    totalRuns: number;
+    completedRuns: number;
+    failedRuns: number;
+    passedCriteria: number;
+    failedCriteria: number;
+  };
+}
+
+function readString(value: unknown): string | undefined {
+  return typeof value === 'string' && value.trim() ? value.trim() : undefined;
+}
+
+function readRecord(value: unknown): Record<string, unknown> | undefined {
+  return value && typeof value === 'object' ? value as Record<string, unknown> : undefined;
+}
+
+function uniqueStrings(values: Array<string | undefined>): string[] {
+  return [...new Set(values.filter((value): value is string => Boolean(value?.trim())))]
+    .sort((a, b) => a.localeCompare(b));
+}
+
+function metadataOrchestrationTaskId(run: WorkflowRun): string | undefined {
+  return readString(run.metadata?.orchestrationTaskId)
+    ?? readString(readRecord(run.metadata?.taskGraph)?.orchestrationTaskId);
+}
+
+function artifactChangedFiles(node: WorkflowNodeRun): string[] {
+  const files: string[] = [];
+
+  if (node.handoffArtifact?.changedFiles) {
+    files.push(...node.handoffArtifact.changedFiles);
+  }
+
+  for (const artifact of node.artifacts ?? []) {
+    const data = readRecord(artifact.data);
+    const metadata = readRecord(artifact.metadata);
+    const candidates = [
+      readString(metadata?.path),
+      readString(metadata?.file),
+      readString(data?.path),
+      readString(data?.file),
+    ];
+    files.push(...candidates.filter((value): value is string => Boolean(value)));
+
+    for (const key of ['files', 'changedFiles']) {
+      const value = data?.[key] ?? metadata?.[key];
+      if (Array.isArray(value)) {
+        files.push(...value.map((entry) => readString(entry)).filter((entry): entry is string => Boolean(entry)));
+      }
+    }
+  }
+
+  return uniqueStrings(files);
+}
+
+export function changedFilesFromWorkflowRun(run: WorkflowRun): string[] {
+  return uniqueStrings(run.nodeRuns.flatMap((node) => artifactChangedFiles(node)));
+}
+
+function workflowRunMatchesTask(run: WorkflowRun, task: OrchestrationTask | undefined): boolean {
+  const runOrchestrationTaskId = metadataOrchestrationTaskId(run);
+  if (task?.id && runOrchestrationTaskId === task.id) return true;
+  if (task?.workflowRunIds?.includes(run.id)) return true;
+  return false;
+}
+
+function runSummary(run: WorkflowRun): TaskRunGraphRunSummary {
+  return {
+    id: run.id,
+    workflowId: run.workflowId,
+    status: run.status,
+    startedAt: run.startedAt,
+    finishedAt: run.finishedAt,
+    orchestrationTaskId: metadataOrchestrationTaskId(run),
+    changedFiles: changedFilesFromWorkflowRun(run),
+  };
+}
+
+export function buildTaskRunGraph({
+  projectId,
+  orchestrationTaskId,
+}: {
+  projectId: string;
+  orchestrationTaskId?: string;
+}): TaskRunGraph {
+  const orchestrationTask = orchestrationTaskId ? orchestrationTaskService.get(orchestrationTaskId) : undefined;
+  const workflowRuns = workflowStore
+    .listRuns()
+    .filter((run) => workflowRunMatchesTask(run, orchestrationTask))
+    .map(runSummary);
+  const workflowCriteria: TaskRunGraphCriterion[] = workflowRuns.map((run) => ({
+    id: `run-${run.id}`,
+    label: `Workflow ${run.workflowId} ${run.status}`,
+    status: run.status === 'completed' ? 'passed' : run.status === 'failed' || run.status === 'canceled' ? 'failed' : 'pending',
+    source: 'workflow',
+  }));
+  const acceptanceCriteria = [
+    ...(orchestrationTask?.acceptanceCriteria ?? []),
+    ...workflowCriteria,
+  ];
+  const changedFiles = uniqueStrings([
+    ...(orchestrationTask?.changedFiles ?? []),
+    ...workflowRuns.flatMap((run) => run.changedFiles),
+  ]);
+
+  return {
+    protocol: PIXCODE_TASK_RUN_GRAPH_PROTOCOL,
+    projectId,
+    orchestrationTaskId: orchestrationTask?.id,
+    workflowRuns,
+    changedFiles,
+    acceptanceCriteria,
+    status: {
+      totalRuns: workflowRuns.length,
+      completedRuns: workflowRuns.filter((run) => run.status === 'completed').length,
+      failedRuns: workflowRuns.filter((run) => run.status === 'failed' || run.status === 'canceled').length,
+      passedCriteria: acceptanceCriteria.filter((criterion) => criterion.status === 'passed').length,
+      failedCriteria: acceptanceCriteria.filter((criterion) => criterion.status === 'failed').length,
+    },
+  };
+}

package/server/modules/orchestration/workflows/approval-queue.ts

@@ -1,106 +1,106 @@
-import type { WorkflowRun } from '@/modules/orchestration/workflows/workflow.types.js';
-import { workflowStore } from '@/modules/orchestration/workflows/workflow-store.js';
-
-export type ApprovalDecisionSource = 'ui' | 'telegram' | 'api';
-
-export type ApprovalQueueItem = Record<string, unknown> & {
-  id: string;
-  runId: string;
-  workflowId: string;
-  status: string;
-  requestedAt?: number;
-};
-
-function readRunApprovals(run: WorkflowRun): Array<Record<string, unknown>> {
-  const approvals = run.metadata?.pendingPermissionApprovals;
-  return Array.isArray(approvals)
-    ? approvals.filter((approval): approval is Record<string, unknown> => Boolean(approval && typeof approval === 'object'))
-    : [];
-}
-
-function normalizeApproval(run: WorkflowRun, approval: Record<string, unknown>): ApprovalQueueItem | null {
-  const id = typeof approval.id === 'string' && approval.id.trim() ? approval.id : null;
-  if (!id) return null;
-
-  return {
-    ...approval,
-    id,
-    runId: run.id,
-    workflowId: run.workflowId,
-    status: typeof approval.status === 'string' ? approval.status : 'pending',
-    requestedAt: typeof approval.requestedAt === 'number' ? approval.requestedAt : run.startedAt,
-  };
-}
-
-export function listPendingApprovals(options: {
-  projectId?: string;
-  includeResolved?: boolean;
-} = {}): ApprovalQueueItem[] {
-  const items: ApprovalQueueItem[] = [];
-  for (const run of workflowStore.listRuns()) {
-    if (options.projectId && run.metadata?.projectId !== options.projectId) continue;
-    for (const approval of readRunApprovals(run)) {
-      const item = normalizeApproval(run, approval);
-      if (!item) continue;
-      if (!options.includeResolved && item.status !== 'pending') continue;
-      items.push(item);
-    }
-  }
-
-  return items.sort((a, b) => Number(b.requestedAt ?? 0) - Number(a.requestedAt ?? 0));
-}
-
-export function resolvePermissionApproval({
-  approvalId,
-  allow,
-  source = 'api',
-  resolvedBy,
-  message,
-}: {
-  approvalId: string;
-  allow: boolean;
-  source?: ApprovalDecisionSource; // source: 'ui' | 'telegram' | 'api'
-  resolvedBy?: string | number | null;
-  message?: string;
-}): {
-  runId: string;
-  pendingApprovals: ApprovalQueueItem[];
-  approvalHistory: ApprovalQueueItem[];
-} | null {
-  for (const run of workflowStore.listRuns()) {
-    const approvals = readRunApprovals(run);
-    let changed = false;
-    const nextApprovals = approvals.map((approval) => {
-      if (approval.id !== approvalId) return approval;
-      changed = true;
-      return {
-        ...approval,
-        status: allow ? 'allowed' : 'denied',
-        resolvedAt: Date.now(),
-        resolvedBy: resolvedBy ?? null,
-        decisionSource: source,
-        resolutionMessage: typeof message === 'string' && message.trim() ? message.trim() : undefined,
-      };
-    });
-
-    if (!changed) continue;
-
-    run.metadata = {
-      ...run.metadata,
-      pendingPermissionApprovals: nextApprovals,
-    };
-    workflowStore.setRun(run);
-
-    const queueItems = nextApprovals
-      .map((approval) => normalizeApproval(run, approval))
-      .filter((approval): approval is ApprovalQueueItem => Boolean(approval));
-
-    return {
-      runId: run.id,
-      pendingApprovals: queueItems.filter((approval) => approval.status === 'pending'),
-      approvalHistory: queueItems.filter((approval) => approval.status !== 'pending'),
-    };
-  }
-
-  return null;
-}
+import type { WorkflowRun } from '@/modules/orchestration/workflows/workflow.types.js';
+import { workflowStore } from '@/modules/orchestration/workflows/workflow-store.js';
+
+export type ApprovalDecisionSource = 'ui' | 'telegram' | 'api';
+
+export type ApprovalQueueItem = Record<string, unknown> & {
+  id: string;
+  runId: string;
+  workflowId: string;
+  status: string;
+  requestedAt?: number;
+};
+
+function readRunApprovals(run: WorkflowRun): Array<Record<string, unknown>> {
+  const approvals = run.metadata?.pendingPermissionApprovals;
+  return Array.isArray(approvals)
+    ? approvals.filter((approval): approval is Record<string, unknown> => Boolean(approval && typeof approval === 'object'))
+    : [];
+}
+
+function normalizeApproval(run: WorkflowRun, approval: Record<string, unknown>): ApprovalQueueItem | null {
+  const id = typeof approval.id === 'string' && approval.id.trim() ? approval.id : null;
+  if (!id) return null;
+
+  return {
+    ...approval,
+    id,
+    runId: run.id,
+    workflowId: run.workflowId,
+    status: typeof approval.status === 'string' ? approval.status : 'pending',
+    requestedAt: typeof approval.requestedAt === 'number' ? approval.requestedAt : run.startedAt,
+  };
+}
+
+export function listPendingApprovals(options: {
+  projectId?: string;
+  includeResolved?: boolean;
+} = {}): ApprovalQueueItem[] {
+  const items: ApprovalQueueItem[] = [];
+  for (const run of workflowStore.listRuns()) {
+    if (options.projectId && run.metadata?.projectId !== options.projectId) continue;
+    for (const approval of readRunApprovals(run)) {
+      const item = normalizeApproval(run, approval);
+      if (!item) continue;
+      if (!options.includeResolved && item.status !== 'pending') continue;
+      items.push(item);
+    }
+  }
+
+  return items.sort((a, b) => Number(b.requestedAt ?? 0) - Number(a.requestedAt ?? 0));
+}
+
+export function resolvePermissionApproval({
+  approvalId,
+  allow,
+  source = 'api',
+  resolvedBy,
+  message,
+}: {
+  approvalId: string;
+  allow: boolean;
+  source?: ApprovalDecisionSource; // source: 'ui' | 'telegram' | 'api'
+  resolvedBy?: string | number | null;
+  message?: string;
+}): {
+  runId: string;
+  pendingApprovals: ApprovalQueueItem[];
+  approvalHistory: ApprovalQueueItem[];
+} | null {
+  for (const run of workflowStore.listRuns()) {
+    const approvals = readRunApprovals(run);
+    let changed = false;
+    const nextApprovals = approvals.map((approval) => {
+      if (approval.id !== approvalId) return approval;
+      changed = true;
+      return {
+        ...approval,
+        status: allow ? 'allowed' : 'denied',
+        resolvedAt: Date.now(),
+        resolvedBy: resolvedBy ?? null,
+        decisionSource: source,
+        resolutionMessage: typeof message === 'string' && message.trim() ? message.trim() : undefined,
+      };
+    });
+
+    if (!changed) continue;
+
+    run.metadata = {
+      ...run.metadata,
+      pendingPermissionApprovals: nextApprovals,
+    };
+    workflowStore.setRun(run);
+
+    const queueItems = nextApprovals
+      .map((approval) => normalizeApproval(run, approval))
+      .filter((approval): approval is ApprovalQueueItem => Boolean(approval));
+
+    return {
+      runId: run.id,
+      pendingApprovals: queueItems.filter((approval) => approval.status === 'pending'),
+      approvalHistory: queueItems.filter((approval) => approval.status !== 'pending'),
+    };
+  }
+
+  return null;
+}