@pixelbyte-software/pixcode 1.48.4 → 1.48.6

package/scripts/smoke/pixcode-workbench-1-48.mjs

@@ -14,7 +14,6 @@ const settingsMainTabs = read('src/components/settings/view/SettingsMainTabs.tsx
 const settingsTypes = read('src/components/settings/types/types.ts');
 const settingsController = read('src/components/settings/hooks/useSettingsController.ts');
 const app = read('src/App.tsx');
-const orchestration = read('src/components/orchestration/OrchestrationPage.tsx');
 const serverIndex = read('server/index.js');
 const hermesRoutes = read('server/modules/orchestration/hermes/hermes.routes.ts');
 const shellTerminal = read('src/components/shell/hooks/useShellTerminal.ts');
@@ -34,19 +33,32 @@ assert.doesNotMatch(appearanceTab, /workbenchLayout|WorkbenchLayoutPreference|on
 
 assert.match(workbench, /useState<ActivityPanel>\('projects'\)/, 'Workbench should open on the Projects panel.');
 assert.match(workbench, /WorkbenchWorkspaceTabs|WORKBENCH_WORKSPACE_TABS_STORAGE_KEY/, 'Workbench should expose persistent top workspace tabs.');
+assert.match(workbench, /workspaceTabStripRef/, 'Workbench workspace tabs should scroll instead of overflowing the viewport.');
+assert.match(workbench, /onToggleCliPanel/, 'Workbench workspace tab bar should expose a right CLI panel collapse toggle.');
 assert.match(workbench, /WorkspaceTabContextMenu/, 'Workbench workspace tabs should use right-click actions.');
 assert.doesNotMatch(workbench, /\.\.\.currentTabs\.filter\(\(tab\) => tab\.id !== tabId\)/, 'Workspace selection should not reorder tabs.');
 assert.match(workbench, /openEditorTabs|activeEditorPath/, 'Workbench editor should keep a Monaco-style tab set.');
+assert.match(workbench, /WORKBENCH_EDITOR_STATE_STORAGE_KEY/, 'Workbench editor should persist open tabs per workspace.');
+assert.match(workbench, /readWorkbenchEditorState/, 'Workbench editor should restore open tabs when switching back to a workspace.');
+assert.doesNotMatch(
+  workbench,
+  /useEffect\(\(\) => \{\s*setOpenEditorTabs\(\[\]\);\s*setActiveEditorPath\(null\);\s*setSplitEditorFile\(null\);[\s\S]*?\}, \[selectedProject\?\.name\]\);/,
+  'Workbench editor must not clear every open tab when the selected workspace changes.',
+);
 assert.doesNotMatch(workbench, /<ChatInterface/, 'Right workbench panel should not render the chat composer.');
 assert.match(workbench, /WorkbenchCliPanel/, 'Right workbench panel should render the CLI terminal panel.');
 assert.match(workbench, /setIsTerminalOpen\(true\)/, 'CLI picker should give way to a full-height terminal after the user starts a provider.');
 assert.match(workbench, /onClose=\{closeTerminal\}/, 'Closing the workbench terminal should return to the CLI picker.');
 assert.match(workbench, /WorkbenchCliPanelToolbar/, 'CLI terminal should keep history and new-session actions visible.');
 assert.match(workbench, /WORKBENCH_CLI_STATE_STORAGE_KEY/, 'CLI terminal should remember per-project open state across workspace switches.');
+assert.match(workbench, /function WorkbenchBottomTerminal/, 'Terminal activity should render as a bottom plain-shell panel.');
+assert.match(workbench, /isPlainShell/, 'Bottom terminal should open the selected project folder without starting the selected AI CLI.');
+assert.match(workbench, /startHermesAgent/, 'Right CLI panel should launch Hermes Agent in the active project.');
 assert.match(workbench, /openNewCliSessionPicker/, 'CLI terminal plus should return to provider selection before starting a fresh session.');
 assert.match(workbench, /terminateCurrentCliSession\(selectedProvider\)/, 'CLI terminal plus should terminate the existing provider PTY before showing selection.');
 assert.match(workbench, /forceNewSession=\{terminalLaunch\.forceNewSession\}/, 'Fresh CLI sessions should bypass the cached default PTY.');
 assert.match(serverIndex, /\/api\/shell\/sessions\/terminate/, 'Backend should expose an authenticated endpoint to terminate cached provider PTYs immediately.');
+assert.match(serverIndex, /isPlainShell && !initialCommand/, 'Backend should spawn an interactive plain shell when no terminal command is provided.');
 assert.doesNotMatch(shellTerminal, /new WebglAddon\(\)/, 'Workbench terminal should use the stable xterm renderer.');
 assert.match(workbench, /setActivityPanel\('explorer'\)/, 'Selecting a project should return the side panel to Explorer.');
 assert.match(gitPanelHeader, /compact/, 'Workbench Source Control should have compact icon-only controls.');
@@ -63,8 +75,8 @@ assert.doesNotMatch(settingsMainTabs, /id: 'tasks'/, 'Settings main tabs should
 assert.doesNotMatch(settingsTypes, /'tasks'/, 'Settings tab type should not include tasks.');
 assert.doesNotMatch(settingsController, /'tasks'/, 'Settings controller should not treat tasks as a known tab.');
 
-assert.match(orchestration, /Hermes/, 'Orchestration page should present Hermes as the control agent.');
-assert.doesNotMatch(orchestration, /A2A|a2a/, 'Orchestration page should not present A2A terminology.');
+assert.doesNotMatch(workbench, /<OrchestrationPage/, 'Workbench should not expose the old orchestration page.');
+assert.doesNotMatch(workbench, /tabs\.orchestration/, 'Workbench menus should not route users into orchestration.');
 assert.match(serverIndex, /app\.use\('\/hermes', createHermesTaskRouter\(\)\)/, 'Internal task router should be mounted behind Hermes.');
 assert.doesNotMatch(serverIndex, /app\.use\('\/a2a'/, 'Server should not expose the old A2A route.');
 assert.match(hermesRoutes, /createHermesRouter/, 'Hermes should have a dedicated orchestration API router.');

package/scripts/smoke/vscode-workbench-polish.mjs

@@ -102,12 +102,30 @@ assert.match(
   'Workspace add button should center its plus icon instead of rendering an off-center bare icon.',
 );
 
+assert.match(
+  workspaceTabsSource,
+  /workspaceTabStripRef/,
+  'Workspace tabs should use a scrollable strip like editor tabs.',
+);
+
+assert.match(
+  workspaceTabsSource,
+  /scrollWorkspaceTabs/,
+  'Workspace tabs should expose left/right scroll controls when the tab row overflows.',
+);
+
 assert.match(
   workspaceTabsSource,
   /border-r border-border/,
   'Workspace add button should read as part of the tab strip instead of a floating bare button.',
 );
 
+assert.match(
+  workspaceTabsSource,
+  /onToggleCliPanel/,
+  'Workspace tab bar should expose a right-panel toggle at the end of the strip.',
+);
+
 assert.match(
   workbench,
   /WORKBENCH_WORKSPACE_TABS_STORAGE_KEY/,
@@ -126,6 +144,18 @@ assert.match(
   'Editor tabs should have a scrollable strip instead of shrinking every tab.',
 );
 
+assert.match(
+  workbench,
+  /WORKBENCH_EDITOR_STATE_STORAGE_KEY/,
+  'Editor tabs should keep separate persisted state for each workspace.',
+);
+
+assert.doesNotMatch(
+  workbench,
+  /useEffect\(\(\) => \{\s*setOpenEditorTabs\(\[\]\);\s*setActiveEditorPath\(null\);\s*setSplitEditorFile\(null\);[\s\S]*?\}, \[selectedProject\?\.name\]\);/,
+  'Editor tabs should not be wiped by the selected-project change effect.',
+);
+
 assert.match(
   workbench,
   /handleEditorTabContextMenu/,
@@ -208,6 +238,24 @@ assert.match(
   'Right CLI terminal should keep compact History and New Session actions visible while the terminal is open.',
 );
 
+assert.match(
+  workbench,
+  /function WorkbenchBottomTerminal/,
+  'Terminal activity should open a VS Code-style bottom terminal instead of the provider CLI picker.',
+);
+
+assert.match(
+  workbench,
+  /isPlainShell/,
+  'Workbench bottom terminal should run a plain shell in the selected project directory.',
+);
+
+assert.match(
+  workbench,
+  /startHermesAgent/,
+  'Right CLI panel should offer Hermes Agent as a project-scoped control agent.',
+);
+
 assert.match(
   workbench,
   /onNewSession=\{openNewCliSessionPicker\}/,

package/server/index.js

@@ -2092,7 +2092,7 @@ function handleShellConnection(ws) {
                 const provider = data.provider || 'claude';
                 const initialCommand = data.initialCommand;
                 const isPlainShell = data.isPlainShell || (!!initialCommand && !hasSession) || provider === 'plain-shell';
-                const forceNewSession = Boolean(data.forceNewSession && !isPlainShell);
+                const forceNewSession = Boolean(data.forceNewSession);
                 urlDetectionBuffer = '';
                 announcedAuthUrls.clear();
 
@@ -2129,9 +2129,16 @@ function handleShellConnection(ws) {
                         terminatePtySession(ptySessionKey, oldSession, 'fresh login');
                     }
                 } else if (forceNewSession) {
-                    const killedSessions = killProviderPtySessions(projectPath, provider);
-                    if (killedSessions > 0) {
-                        console.log(`🧹 Fresh ${provider} session requested; terminated ${killedSessions} cached PTY session(s).`);
+                    if (isPlainShell) {
+                        const oldSession = ptySessionsMap.get(ptySessionKey);
+                        if (oldSession) {
+                            terminatePtySession(ptySessionKey, oldSession, 'fresh plain shell session');
+                        }
+                    } else {
+                        const killedSessions = killProviderPtySessions(projectPath, provider);
+                        if (killedSessions > 0) {
+                            console.log(`🧹 Fresh ${provider} session requested; terminated ${killedSessions} cached PTY session(s).`);
+                        }
                     }
                 }
 
@@ -2213,8 +2220,8 @@ function handleShellConnection(ws) {
                     // Build shell command — use cwd for project path (never interpolate into shell string)
                     let shellCommand;
                     if (isPlainShell) {
-                        // Plain shell mode - run the initial command in the project directory
-                        shellCommand = initialCommand;
+                        // Plain shell mode without an initial command must stay interactive.
+                        shellCommand = initialCommand || null;
                     } else if (provider === 'cursor') {
                         if (hasSession && sessionId) {
                             shellCommand = `cursor-agent --resume="${sessionId}"`;
@@ -2311,11 +2318,13 @@ function handleShellConnection(ws) {
                         }
                     }
 
-                    console.log('🔧 Executing shell command:', shellCommand);
+                    console.log('🔧 Executing shell command:', shellCommand || 'interactive shell');
 
                     // Use appropriate shell based on platform
                     const shell = os.platform() === 'win32' ? 'powershell.exe' : 'bash';
-                    const shellArgs = os.platform() === 'win32' ? ['-Command', shellCommand] : ['-c', shellCommand];
+                    const shellArgs = isPlainShell && !initialCommand
+                        ? (os.platform() === 'win32' ? ['-NoLogo'] : ['-l'])
+                        : (os.platform() === 'win32' ? ['-Command', shellCommand] : ['-c', shellCommand]);
 
                     // Use terminal dimensions from client if provided, otherwise use defaults
                     const termCols = data.cols || 80;