@pixelbyte-software/pixcode 1.33.9 → 1.33.10

package/server/modules/providers/shared/provider-configs.ts

@@ -1,142 +1,142 @@
-/**
- * Registry of user-editable config files per provider CLI.
- *
- * This is the single source of truth for the Settings → Agents →
- * Configuration tab. Adding a new provider? Append a row here and the
- * UI + API pick it up — no component changes required.
- *
- * Rules:
- *   - `relativePath` is relative to the user's home directory.
- *     We never accept absolute paths from the client; the server
- *     resolves these explicitly so path traversal is impossible.
- *   - `format` drives the CodeMirror language extension on the client.
- *   - `readonly: true` hides the Save button and the server rejects
- *     writes. Use it for files the CLI owns (e.g. OAuth tokens).
- *   - `description` is shown as a subtle caption under the editor.
- */
-
-export type ProviderConfigFormat = 'json' | 'toml' | 'env' | 'text';
-
-export type ProviderConfigFile = {
-  id: string;
-  label: string;
-  relativePath: string;
-  format: ProviderConfigFormat;
-  readonly?: boolean;
-  description?: string;
-};
-
-export const PROVIDER_CONFIG_FILES: Record<string, ProviderConfigFile[]> = {
-  claude: [
-    {
-      id: 'settings',
-      label: 'settings.json',
-      relativePath: '.claude/settings.json',
-      format: 'json',
-      description: 'Main Claude Code settings — default model, system prompt, tool policy.',
-    },
-    {
-      id: 'env',
-      label: '.env',
-      relativePath: '.claude/.env',
-      format: 'env',
-      description: 'Environment variables loaded when Claude runs (e.g. ANTHROPIC_API_KEY).',
-    },
-  ],
-  codex: [
-    {
-      id: 'config',
-      label: 'config.toml',
-      relativePath: '.codex/config.toml',
-      format: 'toml',
-      description: 'Main Codex CLI config — models, MCP servers, approval policy, sandbox mode.',
-    },
-    {
-      id: 'env',
-      label: '.env',
-      relativePath: '.codex/.env',
-      format: 'env',
-      description: 'Environment variables (OPENAI_API_KEY, OPENAI_BASE_URL, …).',
-    },
-    {
-      id: 'auth',
-      label: 'auth.json',
-      relativePath: '.codex/auth.json',
-      format: 'json',
-      readonly: true,
-      description: 'OAuth tokens managed by `codex login`. Read-only; editing here would corrupt the session.',
-    },
-  ],
-  cursor: [
-    {
-      id: 'env',
-      label: '.env',
-      relativePath: '.cursor/.env',
-      format: 'env',
-      description: 'Cursor CLI environment variables.',
-    },
-  ],
-  gemini: [
-    {
-      id: 'settings',
-      label: 'settings.json',
-      relativePath: '.gemini/settings.json',
-      format: 'json',
-      description: 'Main Gemini CLI settings — selected model, MCP servers, tool approval mode.',
-    },
-    {
-      id: 'env',
-      label: '.env',
-      relativePath: '.gemini/.env',
-      format: 'env',
-      description: 'Environment variables (GOOGLE_API_KEY, GEMINI_API_KEY, …).',
-    },
-  ],
-  qwen: [
-    {
-      id: 'settings',
-      label: 'settings.json',
-      relativePath: '.qwen/settings.json',
-      format: 'json',
-      description: 'Main Qwen Code settings — selected model, MCP servers, approval mode.',
-    },
-    {
-      id: 'env',
-      label: '.env',
-      relativePath: '.qwen/.env',
-      format: 'env',
-      description: 'Environment variables (DASHSCOPE_API_KEY, OPENAI_API_KEY for OpenAI-compatible routes, …).',
-    },
-  ],
-  opencode: [
-    {
-      id: 'config',
-      label: 'opencode.json',
-      relativePath: '.config/opencode/opencode.json',
-      format: 'json',
-      description: 'Main OpenCode config — provider, model, MCP servers, permission rules, agents.',
-    },
-    {
-      id: 'tui',
-      label: 'tui.json',
-      relativePath: '.config/opencode/tui.json',
-      format: 'json',
-      description: 'Terminal UI preferences (theme, keybinds). Separate from the main config since 2026-02.',
-    },
-    {
-      id: 'auth',
-      label: 'auth.json',
-      relativePath: '.local/share/opencode/auth.json',
-      format: 'json',
-      readonly: true,
-      description: 'Provider credentials managed by `opencode auth login`. Read-only here; editing would corrupt stored OAuth tokens.',
-    },
-  ],
-};
-
-export const SUPPORTED_CONFIG_PROVIDERS = Object.keys(PROVIDER_CONFIG_FILES);
-
-// Hard cap — no config file we care about is remotely this big, but we
-// want to refuse reads and writes that would swell memory. Editing a 1 MB
-// settings.json is already a smell.
-export const MAX_CONFIG_FILE_SIZE_BYTES = 1_048_576; // 1 MB
+/**
+ * Registry of user-editable config files per provider CLI.
+ *
+ * This is the single source of truth for the Settings → Agents →
+ * Configuration tab. Adding a new provider? Append a row here and the
+ * UI + API pick it up — no component changes required.
+ *
+ * Rules:
+ *   - `relativePath` is relative to the user's home directory.
+ *     We never accept absolute paths from the client; the server
+ *     resolves these explicitly so path traversal is impossible.
+ *   - `format` drives the CodeMirror language extension on the client.
+ *   - `readonly: true` hides the Save button and the server rejects
+ *     writes. Use it for files the CLI owns (e.g. OAuth tokens).
+ *   - `description` is shown as a subtle caption under the editor.
+ */
+
+export type ProviderConfigFormat = 'json' | 'toml' | 'env' | 'text';
+
+export type ProviderConfigFile = {
+  id: string;
+  label: string;
+  relativePath: string;
+  format: ProviderConfigFormat;
+  readonly?: boolean;
+  description?: string;
+};
+
+export const PROVIDER_CONFIG_FILES: Record<string, ProviderConfigFile[]> = {
+  claude: [
+    {
+      id: 'settings',
+      label: 'settings.json',
+      relativePath: '.claude/settings.json',
+      format: 'json',
+      description: 'Main Claude Code settings — default model, system prompt, tool policy.',
+    },
+    {
+      id: 'env',
+      label: '.env',
+      relativePath: '.claude/.env',
+      format: 'env',
+      description: 'Environment variables loaded when Claude runs (e.g. ANTHROPIC_API_KEY).',
+    },
+  ],
+  codex: [
+    {
+      id: 'config',
+      label: 'config.toml',
+      relativePath: '.codex/config.toml',
+      format: 'toml',
+      description: 'Main Codex CLI config — models, MCP servers, approval policy, sandbox mode.',
+    },
+    {
+      id: 'env',
+      label: '.env',
+      relativePath: '.codex/.env',
+      format: 'env',
+      description: 'Environment variables (OPENAI_API_KEY, OPENAI_BASE_URL, …).',
+    },
+    {
+      id: 'auth',
+      label: 'auth.json',
+      relativePath: '.codex/auth.json',
+      format: 'json',
+      readonly: true,
+      description: 'OAuth tokens managed by `codex login`. Read-only; editing here would corrupt the session.',
+    },
+  ],
+  cursor: [
+    {
+      id: 'env',
+      label: '.env',
+      relativePath: '.cursor/.env',
+      format: 'env',
+      description: 'Cursor CLI environment variables.',
+    },
+  ],
+  gemini: [
+    {
+      id: 'settings',
+      label: 'settings.json',
+      relativePath: '.gemini/settings.json',
+      format: 'json',
+      description: 'Main Gemini CLI settings — selected model, MCP servers, tool approval mode.',
+    },
+    {
+      id: 'env',
+      label: '.env',
+      relativePath: '.gemini/.env',
+      format: 'env',
+      description: 'Environment variables (GOOGLE_API_KEY, GEMINI_API_KEY, …).',
+    },
+  ],
+  qwen: [
+    {
+      id: 'settings',
+      label: 'settings.json',
+      relativePath: '.qwen/settings.json',
+      format: 'json',
+      description: 'Main Qwen Code settings — selected model, MCP servers, approval mode.',
+    },
+    {
+      id: 'env',
+      label: '.env',
+      relativePath: '.qwen/.env',
+      format: 'env',
+      description: 'Environment variables (DASHSCOPE_API_KEY, OPENAI_API_KEY for OpenAI-compatible routes, …).',
+    },
+  ],
+  opencode: [
+    {
+      id: 'config',
+      label: 'opencode.json',
+      relativePath: '.config/opencode/opencode.json',
+      format: 'json',
+      description: 'Main OpenCode config — provider, model, MCP servers, permission rules, agents.',
+    },
+    {
+      id: 'tui',
+      label: 'tui.json',
+      relativePath: '.config/opencode/tui.json',
+      format: 'json',
+      description: 'Terminal UI preferences (theme, keybinds). Separate from the main config since 2026-02.',
+    },
+    {
+      id: 'auth',
+      label: 'auth.json',
+      relativePath: '.local/share/opencode/auth.json',
+      format: 'json',
+      readonly: true,
+      description: 'Provider credentials managed by `opencode auth login`. Read-only here; editing would corrupt stored OAuth tokens.',
+    },
+  ],
+};
+
+export const SUPPORTED_CONFIG_PROVIDERS = Object.keys(PROVIDER_CONFIG_FILES);
+
+// Hard cap — no config file we care about is remotely this big, but we
+// want to refuse reads and writes that would swell memory. Editing a 1 MB
+// settings.json is already a smell.
+export const MAX_CONFIG_FILE_SIZE_BYTES = 1_048_576; // 1 MB

package/server/opencode-cli.js

@@ -50,13 +50,34 @@ function mapPermissionModeToArgs(permissionMode, skipPermissions) {
     return { agent: 'build', dangerously: false };
 }
 
+// Pixcode stores OpenCode permissions as two flat lists (`allowPatterns`,
+// `denyPatterns`) in `opencode-settings` localStorage; the backend collapses
+// them into the JSON shape OpenCode reads from `opencode.json`. We pass the
+// merged config inline via `OPENCODE_CONFIG_CONTENT` (a documented OpenCode
+// env var) instead of writing to disk — that way Pixcode's intent doesn't
+// pollute the user's project tree, and project-local opencode.json overrides
+// still take precedence per OpenCode's own precedence rules.
+function buildOpencodePermissionConfig(settings) {
+    const allow = Array.isArray(settings?.allowPatterns) ? settings.allowPatterns.filter(Boolean) : [];
+    const deny = Array.isArray(settings?.denyPatterns) ? settings.denyPatterns.filter(Boolean) : [];
+    if (!allow.length && !deny.length) return null;
+
+    const bash = {};
+    // Deny rules win when patterns collide — apply allow first so deny
+    // overwrites duplicates.
+    for (const pattern of allow) bash[pattern] = 'allow';
+    for (const pattern of deny) bash[pattern] = 'deny';
+
+    return { permission: { bash } };
+}
+
 async function spawnOpencode(command, options = {}, ws) {
     const { sessionId, projectPath, cwd, toolsSettings, permissionMode, images, sessionSummary, agent: agentOverride } = options;
     let capturedSessionId = sessionId;
     let sessionCreatedSent = false;
     let assistantBlocks = [];
 
-    const settings = toolsSettings || { allowedTools: [], disallowedTools: [], skipPermissions: false };
+    const settings = toolsSettings || { allowPatterns: [], denyPatterns: [], skipPermissions: false };
 
     const safeSessionIdPattern = /^[a-zA-Z0-9_.\-:]+$/;
     const args = ['run', '--format', 'json'];
@@ -135,6 +156,21 @@ async function spawnOpencode(command, options = {}, ws) {
 
     const spawnEnv = await buildSpawnEnv('opencode');
 
+    // Inject Pixcode's permission allow/deny patterns as inline OpenCode config.
+    // Skipped when `--dangerously-skip-permissions` is on (the flag overrides
+    // the config anyway) and when both lists are empty (avoid clobbering a
+    // project-local opencode.json the user has hand-tuned).
+    if (!dangerously) {
+        const permConfig = buildOpencodePermissionConfig(settings);
+        if (permConfig) {
+            try {
+                spawnEnv.OPENCODE_CONFIG_CONTENT = JSON.stringify(permConfig);
+            } catch (error) {
+                console.warn('[opencode] Failed to serialize permission config:', error?.message || error);
+            }
+        }
+    }
+
     return new Promise((resolve, reject) => {
         const opencodeProcess = spawnFunction(spawnCmd, spawnArgs, {
             cwd: workingDir,

package/server/opencode-response-handler.js

@@ -1,100 +1,107 @@
-// OpenCode Response Handler — `opencode run --format json` parser.
-//
-// The JSON format streams one event per line (NDJSON). Event shapes follow
-// the OpenAPI contract exposed by `opencode serve`. We treat the stream
-// permissively: lines that don't parse as JSON are passed through as plain
-// text deltas (covers OpenCode's pre-stream banner output and any debug
-// noise the CLI emits to stdout).
-import { sessionsService } from './modules/providers/services/sessions.service.js';
-
-class OpencodeResponseHandler {
-  constructor(ws, options = {}) {
-    this.ws = ws;
-    this.buffer = '';
-    this.onContentFragment = options.onContentFragment || null;
-    this.onInit = options.onInit || null;
-    this.onToolUse = options.onToolUse || null;
-    this.onToolResult = options.onToolResult || null;
-  }
-
-  processData(data) {
-    this.buffer += data;
-
-    const lines = this.buffer.split('\n');
-    this.buffer = lines.pop() || '';
-
-    for (const line of lines) {
-      const trimmed = line.trim();
-      if (!trimmed) continue;
-      try {
-        const event = JSON.parse(trimmed);
-        this.handleEvent(event);
-      } catch {
-        // Non-JSON line — surface as plain text delta so the user sees CLI
-        // banners / status messages instead of swallowing them silently.
-        if (this.onContentFragment) this.onContentFragment(trimmed + '\n');
-      }
-    }
-  }
-
-  handleEvent(event) {
-    const sid = typeof this.ws.getSessionId === 'function' ? this.ws.getSessionId() : null;
-
-    if (event.type === 'init' || event.type === 'session.start') {
-      if (this.onInit) this.onInit(event);
-      return;
-    }
-
-    // OpenCode emits assistant text as either a top-level `text` event
-    // (current `--format json` shape: `{ type: "text", part: { text } }`)
-    // or as `message`/`part` legacy shapes from earlier builds. Cover all
-    // three so we don't drop tokens on a CLI version we haven't matched.
-    if (event.type === 'text' && event.part && typeof event.part.text === 'string') {
-      if (this.onContentFragment && event.part.text) this.onContentFragment(event.part.text);
-    } else if (event.type === 'message' && event.role === 'assistant') {
-      const content = event.content || event.text || '';
-      if (this.onContentFragment && content) this.onContentFragment(content);
-    } else if (event.type === 'part' && event.part_type === 'text') {
-      const content = event.text || event.content || '';
-      if (this.onContentFragment && content) this.onContentFragment(content);
-    } else if (event.type === 'tool_use' || event.type === 'tool-use' || event.type === 'tool.start') {
-      // Tool-use shape on `--format json`: `{ type:"tool_use", part:{ callID, tool, state:{ input } } }`
-      const part = event.part || event;
-      if (this.onToolUse) this.onToolUse({
-        tool_id: part.callID || part.id || event.tool_id,
-        tool_name: part.tool || part.name || event.tool_name,
-        parameters: part.state?.input || part.input || event.parameters || {},
-      });
-    } else if (event.type === 'tool_result' || event.type === 'tool-result' || event.type === 'tool.end') {
-      const part = event.part || event;
-      const state = part.state || {};
-      if (this.onToolResult) this.onToolResult({
-        tool_id: part.callID || part.id || event.tool_id,
-        output: state.output ?? part.output ?? event.output ?? event.result ?? '',
-        status: state.status || event.status || (event.isError ? 'error' : 'ok'),
-      });
-    }
-
-    const normalized = sessionsService.normalizeMessage('opencode', event, sid);
-    for (const msg of normalized) {
-      this.ws.send(msg);
-    }
-  }
-
-  forceFlush() {
-    if (this.buffer.trim()) {
-      try {
-        const event = JSON.parse(this.buffer);
-        this.handleEvent(event);
-      } catch {
-        if (this.onContentFragment) this.onContentFragment(this.buffer);
-      }
-    }
-  }
-
-  destroy() {
-    this.buffer = '';
-  }
-}
-
-export default OpencodeResponseHandler;
+// OpenCode Response Handler — `opencode run --format json` parser.
+//
+// The JSON format streams one event per line (NDJSON). Verified shapes
+// (opencode-ai 0.x, see opencode.ai/docs/cli):
+//
+//   { type:"step_start",  timestamp, sessionID, part:{ type:"step-start",  id, messageID, sessionID } }
+//   { type:"text",        timestamp, sessionID, part:{ type:"text", id, messageID, sessionID, text:"…", time:{…}, metadata:{…} } }
+//   { type:"tool_use",    timestamp, sessionID, part:{ type:"tool-use",  callID, tool, state:{ input } } }
+//   { type:"tool_result", timestamp, sessionID, part:{ type:"tool-result", callID, state:{ output, status } } }
+//   { type:"step_finish", timestamp, sessionID, part:{ type:"step-finish", reason, tokens, cost } }
+//   { type:"error",       timestamp, sessionID, error:{ name, data:{ message, statusCode? } } }
+//
+// Important: field names are camelCase — `sessionID`, `callID`, `messageID`.
+// Earlier integration code assumed snake_case (`session_id`, `tool_id`) which
+// is wrong; nothing in `opencode run --format json` uses snake_case.
+//
+// Lines that don't parse as JSON are surfaced as plain text deltas (covers
+// the CLI's pre-stream banner output, "Shell cwd was reset to …" notices on
+// Windows, and any debug noise).
+import { sessionsService } from './modules/providers/services/sessions.service.js';
+
+class OpencodeResponseHandler {
+  constructor(ws, options = {}) {
+    this.ws = ws;
+    this.buffer = '';
+    this.onContentFragment = options.onContentFragment || null;
+    this.onInit = options.onInit || null;
+    this.onToolUse = options.onToolUse || null;
+    this.onToolResult = options.onToolResult || null;
+    this.capturedCliSessionId = null;
+  }
+
+  processData(data) {
+    this.buffer += data;
+
+    const lines = this.buffer.split('\n');
+    this.buffer = lines.pop() || '';
+
+    for (const line of lines) {
+      const trimmed = line.trim();
+      if (!trimmed) continue;
+      try {
+        const event = JSON.parse(trimmed);
+        this.handleEvent(event);
+      } catch {
+        // Non-JSON line — surface as plain text delta so the user sees CLI
+        // banners / status messages instead of swallowing them silently.
+        if (this.onContentFragment) this.onContentFragment(trimmed + '\n');
+      }
+    }
+  }
+
+  handleEvent(event) {
+    const sid = typeof this.ws.getSessionId === 'function' ? this.ws.getSessionId() : null;
+
+    // Capture OpenCode's real session ID (e.g. `ses_22d6…`) the first time we
+    // see one. Every event carries `sessionID` at the top level — we don't
+    // wait for an `init`/`session.start` event because OpenCode `run --format
+    // json` never emits those (the first event is always `step_start`).
+    if (!this.capturedCliSessionId && typeof event.sessionID === 'string' && event.sessionID) {
+      this.capturedCliSessionId = event.sessionID;
+      if (this.onInit) this.onInit({ session_id: event.sessionID, sessionID: event.sessionID });
+    }
+
+    const part = event.part && typeof event.part === 'object' ? event.part : null;
+
+    if (event.type === 'text' && part && typeof part.text === 'string') {
+      if (this.onContentFragment && part.text) this.onContentFragment(part.text);
+    } else if (event.type === 'tool_use' || event.type === 'tool-use' || event.type === 'tool.start') {
+      const state = part?.state && typeof part.state === 'object' ? part.state : {};
+      if (this.onToolUse) this.onToolUse({
+        tool_id: part?.callID || part?.id || event.tool_id || '',
+        tool_name: part?.tool || part?.name || event.tool_name || '',
+        parameters: state.input || part?.input || event.parameters || {},
+      });
+    } else if (event.type === 'tool_result' || event.type === 'tool-result' || event.type === 'tool.end') {
+      const state = part?.state && typeof part.state === 'object' ? part.state : {};
+      if (this.onToolResult) this.onToolResult({
+        tool_id: part?.callID || part?.id || event.tool_id || '',
+        output: state.output ?? part?.output ?? event.output ?? event.result ?? '',
+        status: state.status || event.status || (event.isError ? 'error' : 'ok'),
+      });
+    }
+
+    const normalized = sessionsService.normalizeMessage('opencode', event, sid);
+    for (const msg of normalized) {
+      this.ws.send(msg);
+    }
+  }
+
+  forceFlush() {
+    if (this.buffer.trim()) {
+      try {
+        const event = JSON.parse(this.buffer);
+        this.handleEvent(event);
+      } catch {
+        if (this.onContentFragment) this.onContentFragment(this.buffer);
+      }
+    }
+  }
+
+  destroy() {
+    this.buffer = '';
+  }
+}
+
+export default OpencodeResponseHandler;