@pixel-point/toolcraft 0.0.18 → 0.0.19

package/templates/starter/src/app/starter-acceptance.output-export-intent.test.ts

@@ -8,6 +8,7 @@ import { describe, expect, it } from "vitest";
 import {
   getToolcraftOutputExportErrors,
   schemaHasPngExportPanelAction,
+  schemaHasSvgExportPanelAction,
   schemaHasVideoExportPanelAction,
 } from "./acceptance/output-export";
 import { buildToolcraftOutputExportFacts } from "./acceptance/output-export-model";
@@ -46,9 +47,11 @@ function makeProductReadiness(
 
 function makeOutputActionsSection({
   image,
+  svg,
   video,
 }: {
   image: boolean;
+  svg: boolean;
   video: boolean;
 }): ToolcraftControlSectionSchema {
   const actions: ToolcraftActionSchema[] = [];
@@ -62,6 +65,15 @@ function makeOutputActionsSection({
     });
   }
 
+  if (svg) {
+    actions.push({
+      icon: "upload-simple",
+      label: "Export SVG",
+      role: "export-svg",
+      value: "export.svg",
+    });
+  }
+
   if (video) {
     actions.push({
       icon: "upload-simple",
@@ -87,19 +99,21 @@ function makeOutputActionsSection({
 function makeExportSchema({
   imageAction = false,
   imageSection = false,
+  svgAction = false,
   timeline = false,
   videoAction = false,
   videoSection = false,
 }: {
   imageAction?: boolean;
   imageSection?: boolean;
+  svgAction?: boolean;
   timeline?: boolean;
   videoAction?: boolean;
   videoSection?: boolean;
 } = {}) {
   const sections: ToolcraftControlSectionSchema[] = [];
 
-  if (imageAction || videoAction) {
+  if (imageAction || svgAction || videoAction) {
     sections.push(makeBackgroundSection());
   }
   if (imageSection) {
@@ -108,8 +122,14 @@ function makeExportSchema({
   if (videoSection) {
     sections.push(makeVideoExportSection());
   }
-  if (imageAction || videoAction) {
-    sections.push(makeOutputActionsSection({ image: imageAction, video: videoAction }));
+  if (imageAction || svgAction || videoAction) {
+    sections.push(
+      makeOutputActionsSection({
+        image: imageAction,
+        svg: svgAction,
+        video: videoAction,
+      }),
+    );
   }
 
   const panels: ToolcraftAppSchema["panels"] = {
@@ -133,12 +153,14 @@ function makeExportSchema({
 
 function makeArtifactCoverage({
   image,
+  svg,
   video,
 }: {
   image: boolean;
+  svg: boolean;
   video: boolean;
 }): readonly ToolcraftComponentAcceptance[] {
-  if (!image && !video) {
+  if (!image && !svg && !video) {
     return [];
   }
 
@@ -147,6 +169,9 @@ function makeArtifactCoverage({
   if (image) {
     exportArtifactCoverage.push("all-required-image-export-behavior");
   }
+  if (svg) {
+    exportArtifactCoverage.push("all-required-svg-export-behavior");
+  }
   if (video) {
     exportArtifactCoverage.push("all-required-video-export-behavior");
   }
@@ -155,6 +180,7 @@ function makeArtifactCoverage({
     {
       actionCoverage: [
         ...(image ? ["export.png"] : []),
+        ...(svg ? ["export.svg"] : []),
         ...(video ? ["export.video"] : []),
       ],
       automated: true,
@@ -184,6 +210,7 @@ function getExplicitExportErrors({
   return getToolcraftOutputExportErrors({
     acceptance: makeArtifactCoverage({
       image: schemaHasPngExportPanelAction(schema),
+      svg: schemaHasSvgExportPanelAction(schema),
       video: schemaHasVideoExportPanelAction(schema),
     }),
     controls: collectToolcraftVisibleAcceptanceControls(schema),
@@ -197,6 +224,7 @@ describe("Toolcraft explicit output export intent", () => {
     const errors = getExplicitExportErrors({
       intent: {
         image: { mode: "toolcraft-default" },
+        svg: { mode: "not-requested" },
         video: { mode: "not-requested" },
       },
       schema: makeExportSchema({
@@ -219,6 +247,7 @@ describe("Toolcraft explicit output export intent", () => {
     const errors = getExplicitExportErrors({
       intent: {
         image: { mode: "toolcraft-default" },
+        svg: { mode: "not-requested" },
         video: {
           evidence: "The user explicitly requested MP4 delivery.",
           mode: "user-requested",
@@ -265,6 +294,7 @@ describe("Toolcraft explicit output export intent", () => {
             evidence: "The user explicitly requested no image artifact.",
             mode: "user-removed",
           },
+          svg: { mode: "not-requested" },
           video: { mode: "not-requested" },
         },
         schema: makeExportSchema({ imageAction, imageSection }),
@@ -277,6 +307,7 @@ describe("Toolcraft explicit output export intent", () => {
       getExplicitExportErrors({
         intent: {
           image: { mode: "toolcraft-default" },
+          svg: { mode: "not-requested" },
           video: { mode: "not-requested" },
         },
         schema: makeExportSchema(),
@@ -291,6 +322,7 @@ describe("Toolcraft explicit output export intent", () => {
       getExplicitExportErrors({
         intent: {
           image: { evidence: " \n\t", mode: "user-removed" },
+          svg: { mode: "not-requested" },
           video: { mode: "not-requested" },
         },
         schema: makeExportSchema(),
@@ -308,6 +340,7 @@ describe("Toolcraft explicit output export intent", () => {
             evidence: "The user explicitly requested no image artifact.",
             mode: "user-removed",
           },
+          svg: { mode: "not-requested" },
           video: {
             evidence: "The user explicitly requested MP4 delivery.",
             mode: "user-requested",
@@ -326,6 +359,7 @@ describe("Toolcraft explicit output export intent", () => {
             evidence: "The user explicitly requested no downloadable artifacts.",
             mode: "user-removed",
           },
+          svg: { mode: "not-requested" },
           video: { mode: "not-requested" },
         },
         schema: makeExportSchema(),
@@ -333,10 +367,48 @@ describe("Toolcraft explicit output export intent", () => {
     ).toEqual([]);
   });
 
+  it("accepts explicit editable SVG-only delivery without inventing a settings section", () => {
+    expect(
+      getExplicitExportErrors({
+        intent: {
+          image: {
+            evidence: "The user requested SVG instead of image export.",
+            mode: "user-removed",
+          },
+          svg: {
+            evidence: "The user explicitly requested editable SVG delivery.",
+            mode: "user-requested",
+          },
+          video: { mode: "not-requested" },
+        },
+        schema: makeExportSchema({ svgAction: true }),
+      }),
+    ).toEqual([]);
+  });
+
+  it("requires the typed SVG action when SVG delivery was requested", () => {
+    expect(
+      getExplicitExportErrors({
+        intent: {
+          image: { mode: "toolcraft-default" },
+          svg: {
+            evidence: "The user explicitly requested editable SVG delivery.",
+            mode: "user-requested",
+          },
+          video: { mode: "not-requested" },
+        },
+        schema: makeExportSchema({ imageAction: true, imageSection: true }),
+      }),
+    ).toContain(
+      'SVG export intent "user-requested" requires an export-svg panel action.',
+    );
+  });
+
   it("does not infer video delivery from an enabled playback timeline", () => {
     const errors = getExplicitExportErrors({
       intent: {
         image: { mode: "toolcraft-default" },
+        svg: { mode: "not-requested" },
         video: { mode: "not-requested" },
       },
       schema: makeExportSchema({
@@ -356,6 +428,7 @@ describe("Toolcraft explicit output export intent", () => {
       getExplicitExportErrors({
         intent: {
           image: { mode: "toolcraft-default" },
+          svg: { mode: "not-requested" },
           video: {
             evidence: "The user explicitly requested video delivery.",
             mode: "user-requested",
@@ -377,6 +450,7 @@ describe("Toolcraft explicit output export intent", () => {
     });
 
     expect(facts.hasImageExportAction).toBe(false);
+    expect(facts.hasSvgExportAction).toBe(false);
     expect(facts.hasVideoExportAction).toBe(false);
     expect(facts.imageExportSectionIndex).toBeGreaterThanOrEqual(0);
     expect(facts.finalExportSettingsIndex).toBe(-1);

package/templates/starter/src/app/starter-acceptance.product-output-export.test.ts

@@ -4,6 +4,7 @@ import { resolveToolcraftArtifactExportIntent } from "./acceptance/artifact-expo
 import { starterProductReadiness } from "./starter-acceptance";
 import {
   textLooksLikePngExport,
+  textLooksLikeSvgExport,
   textLooksLikeVideoExport,
 } from "./starter-acceptance.export-test-utils";
 import {
@@ -31,7 +32,7 @@ describe("Toolcraft output export acceptance contract", () => {
       new Set(["checkbox", "select", "segmented", "switch"]),
     );
 
-    if (delivery.imageEnabled || delivery.videoEnabled) {
+    if (delivery.imageEnabled || delivery.svgEnabled || delivery.videoEnabled) {
       expect(
         panelActionTexts.length,
         "Product apps with artifact delivery must define panelActions in the controls panel sticky footer.",
@@ -84,6 +85,10 @@ describe("Toolcraft output export acceptance contract", () => {
       imageExportSection !== undefined,
       '"Image Export" section presence must match resolved product export intent.',
     ).toBe(delivery.imageEnabled);
+    expect(
+      panelActionTexts.some(textLooksLikeSvgExport),
+      "SVG export action presence must match resolved product export intent.",
+    ).toBe(delivery.svgEnabled);
 
     if (delivery.imageEnabled) {
       expect(

package/templates/starter/src/app/starter-acceptance.product-readiness.test.ts

@@ -4,7 +4,10 @@ import {
   starterProductReadiness,
   starterTransferMode,
 } from "./starter-acceptance";
-import { schemaHasVideoExportPanelAction } from "./acceptance/output-export";
+import {
+  schemaHasSvgExportPanelAction,
+  schemaHasVideoExportPanelAction,
+} from "./acceptance/output-export";
 import { isNeutralTemplateProject } from "./starter-acceptance.product-readiness-test-utils";
 import { schemaHasProductSurface } from "./starter-acceptance.schema-test-utils";
 import { starterSchema } from "./starter-schema";
@@ -18,9 +21,18 @@ describe("Toolcraft product readiness", () => {
     expect(starterTransferMode).toEqual({
       animationIntent: { mode: "none" },
       mode: "new-toolcraft-app",
+      referenceInputs: [],
     });
   });
 
+  it("makes the no-reference decision explicit", () => {
+    if (starterProductReadiness.mode !== "starter") {
+      return;
+    }
+
+    expect(starterTransferMode.referenceInputs).toEqual([]);
+  });
+
   it("allows neutral readiness only for the source starter/template folder", () => {
     if (starterProductReadiness.mode === "product") {
       expect(starterProductReadiness.exportIntent).toBeDefined();
@@ -34,6 +46,11 @@ describe("Toolcraft product readiness", () => {
           ? "user-requested"
           : "not-requested",
       );
+      expect(starterProductReadiness.exportIntent.svg.mode).toBe(
+        schemaHasSvgExportPanelAction(starterSchema)
+          ? "user-requested"
+          : "not-requested",
+      );
       expect(starterProductReadiness.productName.trim()).not.toBe("");
       expect(starterProductReadiness.productSummary.trim()).not.toBe("");
       expect(starterProductReadiness.requestedBehavior.trim()).not.toBe("");

package/templates/starter/src/app/starter-acceptance.product-worklog.test.ts

@@ -2,20 +2,141 @@ import { existsSync, readFileSync } from "node:fs";
 
 import { describe, expect, it } from "vitest";
 
-import { starterProductReadiness } from "./starter-acceptance";
+import {
+  starterProductReadiness,
+  starterTransferMode,
+} from "./starter-acceptance";
+import type { ToolcraftTransferMode } from "./starter-acceptance";
+import {
+  createMotionReferenceBehavior,
+  createMotionReferenceInput,
+  createOrdinalMotionReferenceStudy,
+  createTimedMotionReferenceStudy,
+} from "./starter-acceptance.motion-reference-test-utils";
 import { schemaHasProductSurface } from "./starter-acceptance.schema-test-utils";
 import {
   agentWorklogPath,
   getAgentWorklogValidationErrors,
+  type WorklogMotionReference,
 } from "./starter-acceptance.worklog-test-utils";
 
+function getWorklogMotionReferences(
+  transferMode: ToolcraftTransferMode,
+): readonly WorklogMotionReference[] {
+  return transferMode.referenceInputs.flatMap((referenceInput) =>
+    referenceInput.studies.map((study) => {
+      const requiresRealTimeReview =
+        study.evidence.timingMode === "seconds";
+      const requiresSlowedReview =
+        requiresRealTimeReview &&
+        (study.events.some(
+          ({ classification }) => classification === "product-behavior",
+        ) ||
+          referenceInput.behaviors.some((behavior) =>
+            behavior.timingClaims.some(
+              (claim) => claim.studyId === study.studyId,
+            ),
+          ));
+
+      return {
+        contactSheetPath: study.evidence.contactSheet.path,
+        referenceId: referenceInput.referenceId,
+        requiresRealTimeReview,
+        requiresSlowedReview,
+        sourceSha256: study.evidence.sourceSha256,
+        studyId: study.studyId,
+        timingMode: study.evidence.timingMode,
+      } satisfies WorklogMotionReference;
+    }),
+  );
+}
+
+const worklogMotionReferences = getWorklogMotionReferences(starterTransferMode);
+
 describe("Toolcraft product worklog", () => {
+  it("derives real-time, slowed, and ordered-frame review requirements per nested study", () => {
+    const transferMode: ToolcraftTransferMode = {
+      animationIntent: { mode: "none" },
+      mode: "new-toolcraft-app",
+      referenceInputs: [
+        createMotionReferenceInput({
+          behaviors: [
+            createMotionReferenceBehavior({
+              timingClaims: [{ claim: "duration", studyId: "study-claim" }],
+            }),
+          ],
+          studies: [
+            createTimedMotionReferenceStudy({
+              pathId: "study-event",
+              studyId: "study-event",
+            }),
+            createTimedMotionReferenceStudy({
+              pathId: "study-claim",
+              studyId: "study-claim",
+              withEvent: false,
+            }),
+            createTimedMotionReferenceStudy({
+              pathId: "study-quiet",
+              studyId: "study-quiet",
+              withEvent: false,
+            }),
+            createOrdinalMotionReferenceStudy({
+              pathId: "study-ordinal",
+              studyId: "study-ordinal",
+            }),
+          ],
+        }),
+      ],
+    };
+
+    expect(
+      getWorklogMotionReferences(transferMode).map(
+        ({ requiresRealTimeReview, requiresSlowedReview, studyId, timingMode }) =>
+          ({
+            requiresRealTimeReview,
+            requiresSlowedReview,
+            studyId,
+            timingMode,
+          }),
+      ),
+    ).toEqual([
+      {
+        requiresRealTimeReview: true,
+        requiresSlowedReview: true,
+        studyId: "study-event",
+        timingMode: "seconds",
+      },
+      {
+        requiresRealTimeReview: true,
+        requiresSlowedReview: true,
+        studyId: "study-claim",
+        timingMode: "seconds",
+      },
+      {
+        requiresRealTimeReview: true,
+        requiresSlowedReview: false,
+        studyId: "study-quiet",
+        timingMode: "seconds",
+      },
+      {
+        requiresRealTimeReview: false,
+        requiresSlowedReview: false,
+        studyId: "study-ordinal",
+        timingMode: "ordinal",
+      },
+    ]);
+  });
+
   it("requires product apps to replace the starter worklog with decision evidence", () => {
     if (starterProductReadiness.mode !== "product" && !schemaHasProductSurface()) {
       return;
     }
 
     expect(existsSync(agentWorklogPath)).toBe(true);
-    expect(getAgentWorklogValidationErrors(readFileSync(agentWorklogPath, "utf8"))).toEqual([]);
+    expect(
+      getAgentWorklogValidationErrors(readFileSync(agentWorklogPath, "utf8"), {
+        motionReferences: worklogMotionReferences,
+      }),
+    ).toEqual([]);
   });
 });

package/templates/starter/src/app/starter-acceptance.reference-custom-timeline.test.ts

@@ -19,6 +19,7 @@ describe("starter acceptance custom reference timeline contract", () => {
         transferMode: {
           behaviorCoverage: ["canvas-sizing", "control-mapping", "renderer-state"],
           mode: "reference-runtime-clone",
+          referenceInputs: [],
           referenceName: "legacy state timeline",
           referenceTimeline: {
             behaviorCoverage: ["state-jump", "trim-range"],
@@ -117,6 +118,7 @@ describe("starter acceptance custom reference timeline contract", () => {
         transferMode: {
           behaviorCoverage: ["canvas-sizing", "control-mapping", "renderer-state"],
           mode: "reference-runtime-clone",
+          referenceInputs: [],
           referenceFeatureInventory: makeReferenceFeatureInventory([
             {
               acceptanceId: "reference.timeline.stateJump",

package/templates/starter/src/app/starter-acceptance.reference-foundation.test.ts

@@ -27,6 +27,7 @@ describe("starter acceptance reference-runtime foundation", () => {
             "renderer-loop",
           ],
           mode: "reference-runtime-clone",
+          referenceInputs: [],
           referenceName: "legacy badge wall",
           sourceOfTruth: "reference-runtime",
         } as never,
@@ -57,6 +58,7 @@ describe("starter acceptance reference-runtime foundation", () => {
         transferMode: {
           behaviorCoverage: ["canvas-sizing", "control-mapping", "renderer-state"],
           mode: "reference-runtime-clone",
+          referenceInputs: [],
           referenceName: "legacy badge wall",
           referenceTimeline: { behaviorCoverage: [], mode: "none" },
           sourceOfTruth: "reference-runtime",
@@ -86,6 +88,7 @@ describe("starter acceptance reference-runtime foundation", () => {
         transferMode: {
           behaviorCoverage: ["canvas-sizing", "control-mapping", "renderer-state"],
           mode: "reference-runtime-clone",
+          referenceInputs: [],
           referenceFeatureInventory: makeReferenceFeatureInventory(),
           referenceName: "legacy badge wall",
           referenceTimeline: { behaviorCoverage: [], mode: "none" },
@@ -110,6 +113,7 @@ describe("starter acceptance reference-runtime foundation", () => {
         transferMode: {
           behaviorCoverage: ["canvas-sizing", "control-mapping", "renderer-state"],
           mode: "reference-runtime-clone",
+          referenceInputs: [],
           referenceFeatureInventory: makeReferenceFeatureInventory(),
           referenceName: "legacy badge wall",
           referenceStudy: {
@@ -141,6 +145,7 @@ describe("starter acceptance reference-runtime foundation", () => {
         transferMode: {
           behaviorCoverage: ["canvas-sizing", "control-mapping", "renderer-state"],
           mode: "reference-runtime-clone",
+          referenceInputs: [],
           referenceFeatureInventory: [
             {
               acceptanceId: "appearance.opacity",
@@ -180,6 +185,7 @@ describe("starter acceptance reference-runtime foundation", () => {
         transferMode: {
           behaviorCoverage: ["canvas-sizing", "control-mapping", "renderer-state"],
           mode: "reference-runtime-clone",
+          referenceInputs: [],
           referenceFeatureInventory: [
             { ...makeReferenceFeatureInventory()[0], behaviorEvidence: "" },
             ...makeReferenceFeatureInventory().slice(1),
@@ -208,6 +214,7 @@ describe("starter acceptance reference-runtime foundation", () => {
         transferMode: {
           behaviorCoverage: ["canvas-sizing", "control-mapping", "renderer-state"],
           mode: "reference-runtime-clone",
+          referenceInputs: [],
           referenceFeatureInventory: [
             {
               ...makeReferenceFeatureInventory()[0],
@@ -292,6 +299,7 @@ describe("starter acceptance reference-runtime foundation", () => {
         transferMode: {
           behaviorCoverage: ["canvas-sizing", "control-mapping", "renderer-state"],
           mode: "reference-runtime-clone",
+          referenceInputs: [],
           referenceName: "legacy iframe shell",
           referenceTimeline: { behaviorCoverage: [], mode: "none" },
           sourceOfTruth: "reference-runtime",

package/templates/starter/src/app/starter-acceptance.reference-timeline.test.ts

@@ -67,6 +67,7 @@ describe("starter acceptance reference timeline contract", () => {
         transferMode: {
           behaviorCoverage: ["canvas-sizing", "control-mapping", "renderer-state"],
           mode: "reference-runtime-clone",
+          referenceInputs: [],
           referenceFeatureInventory: makeReferenceFeatureInventory(),
           referenceName: "legacy badge wall",
           referenceStudy: referenceStudyEvidence,
@@ -90,6 +91,7 @@ describe("starter acceptance reference timeline contract", () => {
             "pause-resume",
           ],
           mode: "reference-runtime-clone",
+          referenceInputs: [],
           referenceName: "legacy pause animation",
           referenceTimeline: { behaviorCoverage: [], mode: "none" },
           sourceOfTruth: "reference-runtime",
@@ -114,6 +116,7 @@ describe("starter acceptance reference timeline contract", () => {
             "time-progress",
           ],
           mode: "reference-runtime-clone",
+          referenceInputs: [],
           referenceName: "legacy restart animation",
           referenceTimeline: { behaviorCoverage: [], mode: "none" },
           sourceOfTruth: "reference-runtime",
@@ -132,6 +135,7 @@ describe("starter acceptance reference timeline contract", () => {
         transferMode: {
           behaviorCoverage: ["canvas-sizing", "control-mapping", "renderer-state"],
           mode: "reference-runtime-clone",
+          referenceInputs: [],
           referenceName: "legacy playback animation",
           referenceTimeline: { behaviorCoverage: [], mode: "toolcraft-playback" },
           sourceOfTruth: "reference-runtime",
@@ -170,6 +174,7 @@ describe("starter acceptance reference timeline contract", () => {
             "pause-resume",
           ],
           mode: "reference-runtime-clone",
+          referenceInputs: [],
           referenceName: "legacy playback animation",
           referenceTimeline: { behaviorCoverage: ["playback"], mode: "toolcraft-playback" },
           sourceOfTruth: "reference-runtime",
@@ -208,6 +213,7 @@ describe("starter acceptance reference timeline contract", () => {
             "pause-resume",
           ],
           mode: "reference-runtime-clone",
+          referenceInputs: [],
           referenceName: "legacy playback animation",
           referenceTimeline: {
             behaviorCoverage: ["playback"],
@@ -255,6 +261,7 @@ describe("starter acceptance reference timeline contract", () => {
             "time-progress",
           ],
           mode: "reference-runtime-clone",
+          referenceInputs: [],
           referenceName: "legacy keyframe animation",
           referenceTimeline: { behaviorCoverage: ["keyframes"], mode: "toolcraft-keyframes" },
           sourceOfTruth: "reference-runtime",

package/templates/starter/src/app/starter-acceptance.section-cohesion.test.ts

@@ -162,6 +162,7 @@ describe("starter acceptance section cohesion contract", () => {
           reason: "The flow speed is a decorative self-running effect and does not expose product time transport.",
         },
         mode: "new-toolcraft-app",
+        referenceInputs: [],
       },
     });
 
@@ -247,6 +248,7 @@ describe("starter acceptance section cohesion contract", () => {
             reason: "The flow speed is a decorative self-running effect and does not expose product time transport.",
           },
           mode: "new-toolcraft-app",
+          referenceInputs: [],
         },
       }),
     ).toEqual([]);

package/templates/starter/src/app/starter-acceptance.timeline-playback.test.ts

@@ -67,6 +67,7 @@ describe("starter acceptance timeline playback contract", () => {
         transferMode: {
           animationIntent: { mode: "timeline-playback" },
           mode: "new-toolcraft-app",
+          referenceInputs: [],
         } as unknown as ToolcraftTransferMode,
       }),
     ).toContain(
@@ -82,6 +83,7 @@ describe("starter acceptance timeline playback contract", () => {
         transferMode: {
           animationIntent: { mode: "none" },
           mode: "new-toolcraft-app",
+          referenceInputs: [],
         },
       }),
     ).toContain(
@@ -97,6 +99,7 @@ describe("starter acceptance timeline playback contract", () => {
         transferMode: {
           animationIntent: { mode: "none" },
           mode: "new-toolcraft-app",
+          referenceInputs: [],
         },
       }),
     ).toContain(
@@ -119,6 +122,7 @@ describe("starter acceptance timeline playback contract", () => {
             mode: "timeline-playback",
           },
           mode: "new-toolcraft-app",
+          referenceInputs: [],
         },
       }),
     ).toContain(
@@ -141,6 +145,7 @@ describe("starter acceptance timeline playback contract", () => {
             mode: "timeline-playback",
           },
           mode: "new-toolcraft-app",
+          referenceInputs: [],
         },
       }),
     ).toContain(