@pixel-point/toolcraft 0.0.17 → 0.0.19

package/templates/starter/src/app/starter-acceptance.section-dependencies.test.ts

@@ -58,6 +58,7 @@ describe("starter acceptance section dependency contract", () => {
         sectionInventory: [
           {
             entity: "Shape",
+            entityId: "shape",
             groupingReason: "Shape setup",
             id: "shape",
             targets: ["shape.kind"],
@@ -73,7 +74,7 @@ describe("starter acceptance section dependency contract", () => {
     );
   });
 
-  it("allows explicit workflow split evidence for one target entity", () => {
+  it("rejects workflow splitting when one entity fits in one section", () => {
     const schemaWithWorkflowSplit = defineContractSchemaFixture({
       canvas: { enabled: true },
       panels: {
@@ -118,6 +119,33 @@ describe("starter acceptance section dependency contract", () => {
       },
     });
 
+    const workflowSplitInventory = [
+      {
+        entity: "Object shape",
+        entityId: "object-shape",
+        groupingReason:
+          "Structure controls tune the physical footprint of the object.",
+        id: "shape-structure",
+        splitReason:
+          "Structure and density are separate workflow stages in this editor.",
+        targets: ["object.shape.size"],
+        title: "Shape Structure",
+        workflowStage: "structure",
+      },
+      {
+        entity: "Object shape",
+        entityId: "object-shape",
+        groupingReason:
+          "Density controls tune how many objects appear after structure is set.",
+        id: "shape-density",
+        splitReason:
+          "Density is separated from structure because users set count after the shape footprint.",
+        targets: ["object.shape.count"],
+        title: "Shape Density",
+        workflowStage: "density",
+      },
+    ] as const;
+
     expect(
       validateContractAcceptance({
         schema: schemaWithWorkflowSplit,
@@ -126,28 +154,11 @@ describe("starter acceptance section dependency contract", () => {
           makeControlAcceptance("object.shape.count", "slider"),
         ],
         transferMode: contractTransferModeFixture,
-        sectionInventory: [
-          {
-            entity: "Object shape",
-            groupingReason: "Structure controls tune the physical footprint of the object.",
-            id: "shape-structure",
-            splitReason: "Structure and density are separate workflow stages in this editor.",
-            targets: ["object.shape.size"],
-            title: "Shape Structure",
-            workflowStage: "structure",
-          },
-          {
-            entity: "Object shape",
-            groupingReason: "Density controls tune how many objects appear after structure is set.",
-            id: "shape-density",
-            splitReason: "Density is separated from structure because users set count after the shape footprint.",
-            targets: ["object.shape.count"],
-            title: "Shape Density",
-            workflowStage: "density",
-          },
-        ],
+        sectionInventory: workflowSplitInventory,
       }),
-    ).toEqual([]);
+    ).toContain(
+      'Control Section Inventory entity "object-shape" owns 2 controls across 2 sections (Shape Structure, Shape Density). Entities with 10 or fewer controls must stay in one section.',
+    );
   });
 
   it("rejects mode-gated controls split away from their selector section", () => {
@@ -203,7 +214,7 @@ describe("starter acceptance section dependency contract", () => {
       }),
     ).toEqual(
       expect.arrayContaining([
-        'Image / sourceUpload is gated by visibleWhen target "source.mode" in Source, but it belongs to the same dependency group. Keep selectors and their dependent controls in one semantic section when they describe one product entity or branch; use visibleWhen for branch-specific controls inside that section instead of splitting branch controls into their own section. Do not use disabledWhen for product controls.',
+        'Image / sourceUpload is gated by applicability target "source.mode" in Source, but it belongs to the same dependency group. Keep selectors and their dependent controls in one semantic section when they describe one product entity or branch; use conditional applicability for branch-specific controls inside that section instead of splitting branch controls into their own section. Do not use disabledWhen for product controls.',
       ]),
     );
   });
@@ -259,7 +270,7 @@ describe("starter acceptance section dependency contract", () => {
       }),
     ).toEqual(
       expect.arrayContaining([
-        'Library / libraryAsset is gated by visibleWhen target "shape.kind" in Shape, but it belongs to the same dependency group. Keep selectors and their dependent controls in one semantic section when they describe one product entity or branch; use visibleWhen for branch-specific controls inside that section instead of splitting branch controls into their own section. Do not use disabledWhen for product controls.',
+        'Library / libraryAsset is gated by applicability target "shape.kind" in Shape, but it belongs to the same dependency group. Keep selectors and their dependent controls in one semantic section when they describe one product entity or branch; use conditional applicability for branch-specific controls inside that section instead of splitting branch controls into their own section. Do not use disabledWhen for product controls.',
       ]),
     );
   });

package/templates/starter/src/app/starter-acceptance.section-size.test.ts

@@ -0,0 +1,72 @@
+import { defineToolcraft } from "@repo/toolcraft-runtime";
+import { describe, expect, it } from "vitest";
+
+import { getToolcraftControlSectionInvariantErrors } from "./acceptance/control-layout";
+
+function makeSliderControls(count: number, includeSemanticGroup: boolean) {
+  return Object.fromEntries(
+    Array.from({ length: count }, (_, index) => {
+      const control = {
+        defaultValue: 0,
+        label: `Value ${index + 1}`,
+        max: 1,
+        min: 0,
+        orderRole: "detail" as const,
+        target: `dense.value${index + 1}`,
+        type: "slider" as const,
+        variant: "continuous" as const,
+      };
+
+      return [
+        `value${index + 1}`,
+        includeSemanticGroup
+          ? { ...control, semanticGroup: "dense-entity" }
+          : control,
+      ];
+    }),
+  );
+}
+
+function makeDenseSchema(count: number, includeSemanticGroup = true) {
+  return defineToolcraft({
+    canvas: { enabled: true },
+    panels: {
+      controls: {
+        sections: [
+          {
+            controls: makeSliderControls(count, includeSemanticGroup),
+            id: "dense-entity",
+            title: "Dense Entity",
+          },
+        ],
+        title: "Controls",
+      },
+    },
+  });
+}
+
+describe("starter acceptance section size boundaries", () => {
+  it("does not require semanticGroup at seven controls", () => {
+    expect(
+      getToolcraftControlSectionInvariantErrors(makeDenseSchema(7, false)),
+    ).toEqual([]);
+  });
+
+  it("accepts ten grouped controls in one section", () => {
+    expect(
+      getToolcraftControlSectionInvariantErrors(makeDenseSchema(10)),
+    ).toEqual([]);
+  });
+
+  it("requires semanticGroup beginning at eight controls", () => {
+    expect(
+      getToolcraftControlSectionInvariantErrors(makeDenseSchema(8, false)),
+    ).toEqual(
+      expect.arrayContaining([
+        expect.stringContaining(
+          "has 8 controls and must declare semanticGroup for every control",
+        ),
+      ]),
+    );
+  });
+});

package/templates/starter/src/app/starter-acceptance.timeline-playback.test.ts

@@ -67,6 +67,7 @@ describe("starter acceptance timeline playback contract", () => {
         transferMode: {
           animationIntent: { mode: "timeline-playback" },
           mode: "new-toolcraft-app",
+          referenceInputs: [],
         } as unknown as ToolcraftTransferMode,
       }),
     ).toContain(
@@ -82,6 +83,7 @@ describe("starter acceptance timeline playback contract", () => {
         transferMode: {
           animationIntent: { mode: "none" },
           mode: "new-toolcraft-app",
+          referenceInputs: [],
         },
       }),
     ).toContain(
@@ -97,6 +99,7 @@ describe("starter acceptance timeline playback contract", () => {
         transferMode: {
           animationIntent: { mode: "none" },
           mode: "new-toolcraft-app",
+          referenceInputs: [],
         },
       }),
     ).toContain(
@@ -119,6 +122,7 @@ describe("starter acceptance timeline playback contract", () => {
             mode: "timeline-playback",
           },
           mode: "new-toolcraft-app",
+          referenceInputs: [],
         },
       }),
     ).toContain(
@@ -141,6 +145,7 @@ describe("starter acceptance timeline playback contract", () => {
             mode: "timeline-playback",
           },
           mode: "new-toolcraft-app",
+          referenceInputs: [],
         },
       }),
     ).toContain(

package/templates/starter/src/app/starter-acceptance.ts

@@ -4,6 +4,21 @@ import {
 } from "@repo/toolcraft-runtime";
 
 import { getRequiredToolcraftControlPartCoverage } from "./acceptance/control-parts";
+export {
+  getToolcraftApplicabilitySelectorDomain,
+  getToolcraftControlApplicabilityErrors,
+  type ToolcraftApplicabilitySelectorDomain,
+  type ToolcraftApplicabilitySelectorValue,
+} from "./acceptance/control-applicability";
+export {
+  getToolcraftApplicabilityRequirementId,
+  getToolcraftControlApplicabilityCases,
+  type ToolcraftControlApplicabilityCase,
+} from "./acceptance/control-applicability-cases";
+export {
+  createToolcraftFeatureVerificationSelection,
+  type ToolcraftFeatureVerificationSelection,
+} from "./acceptance/feature-verification-selection";
 import {
   getToolcraftControlOrder as getToolcraftControlOrderForSchema,
   getToolcraftControlOrderTargets as getToolcraftControlOrderTargetsForSchema,
@@ -17,7 +32,6 @@ import type {
   ToolcraftBuiltInFitCheck,
   ToolcraftBackgroundOutputCoverage,
   ToolcraftCanvasSizingCoverage,
-  ToolcraftConditionalVisibilityCoverage,
   ToolcraftComponentAcceptance,
   ToolcraftControlOrderItem,
   ToolcraftControlPartCoverage,
@@ -32,11 +46,25 @@ import type {
   ToolcraftInfinityCanvasCoverage,
   ToolcraftMediaLifecycleCoverage,
   ToolcraftModelImportCoverage,
+  ToolcraftMotionReferenceBehavior,
+  ToolcraftMotionReferenceCoverage,
+  ToolcraftMotionReferenceEvent,
+  ToolcraftMotionReferenceEvidence,
+  ToolcraftMotionReferenceEvidenceEvent,
+  ToolcraftMotionReferenceInput,
+  ToolcraftMotionReferenceOrdinalFrame,
+  ToolcraftMotionReferencePhase,
+  ToolcraftMotionReferenceSourceKind,
+  ToolcraftMotionReferenceStudy,
+  ToolcraftMotionReferenceTimedFrame,
+  ToolcraftMotionReferenceTimingClaim,
+  ToolcraftMotionReferenceTimingMode,
   ToolcraftPersistenceCoverage,
   ToolcraftProductReadiness,
   ToolcraftReferenceCoverage,
   ToolcraftReferenceFeatureInventoryItem,
   ToolcraftReferenceFeatureStatus,
+  ToolcraftReferenceInput,
   ToolcraftReferenceStudyEvidence,
   ToolcraftReferenceStudyStatus,
   ToolcraftReferenceTimelineContract,
@@ -45,16 +73,13 @@ import type {
   ToolcraftRenderScaleCoverage,
   ToolcraftRenderScaleState,
   ToolcraftSettingsTransferCoverage,
+  ToolcraftSelectionScopeCoverage,
   ToolcraftTimelineLoopDurationIntent,
   ToolcraftTimelineLoopDurationSource,
   ToolcraftTimelinePlaybackCoverage,
   ToolcraftTransferMode,
   ToolcraftViewInteractionEvidenceSource,
   ToolcraftViewInteractionIntent,
-  ToolcraftVideoReferenceAcceptanceMapping,
-  ToolcraftVideoReferenceStoryboardFrame,
-  ToolcraftVideoReferenceStudyEvidence,
-  ToolcraftVideoReferenceTransition,
   ToolcraftVisibleControl,
 } from "./acceptance/types";
 import { TOOLCRAFT_REQUIRED_MODEL_IMPORT_COVERAGE } from "./acceptance/types";
@@ -91,7 +116,6 @@ export type {
   ToolcraftBuiltInFitCheck,
   ToolcraftBackgroundOutputCoverage,
   ToolcraftCanvasSizingCoverage,
-  ToolcraftConditionalVisibilityCoverage,
   ToolcraftComponentAcceptance,
   ToolcraftControlOrderItem,
   ToolcraftControlPartCoverage,
@@ -106,11 +130,25 @@ export type {
   ToolcraftInfinityCanvasCoverage,
   ToolcraftMediaLifecycleCoverage,
   ToolcraftModelImportCoverage,
+  ToolcraftMotionReferenceBehavior,
+  ToolcraftMotionReferenceCoverage,
+  ToolcraftMotionReferenceEvent,
+  ToolcraftMotionReferenceEvidence,
+  ToolcraftMotionReferenceEvidenceEvent,
+  ToolcraftMotionReferenceInput,
+  ToolcraftMotionReferenceOrdinalFrame,
+  ToolcraftMotionReferencePhase,
+  ToolcraftMotionReferenceSourceKind,
+  ToolcraftMotionReferenceStudy,
+  ToolcraftMotionReferenceTimedFrame,
+  ToolcraftMotionReferenceTimingClaim,
+  ToolcraftMotionReferenceTimingMode,
   ToolcraftPersistenceCoverage,
   ToolcraftProductReadiness,
   ToolcraftReferenceCoverage,
   ToolcraftReferenceFeatureInventoryItem,
   ToolcraftReferenceFeatureStatus,
+  ToolcraftReferenceInput,
   ToolcraftReferenceStudyEvidence,
   ToolcraftReferenceStudyStatus,
   ToolcraftReferenceTimelineContract,
@@ -119,16 +157,13 @@ export type {
   ToolcraftRenderScaleCoverage,
   ToolcraftRenderScaleState,
   ToolcraftSettingsTransferCoverage,
+  ToolcraftSelectionScopeCoverage,
   ToolcraftTimelineLoopDurationIntent,
   ToolcraftTimelineLoopDurationSource,
   ToolcraftTimelinePlaybackCoverage,
   ToolcraftTransferMode,
   ToolcraftViewInteractionEvidenceSource,
   ToolcraftViewInteractionIntent,
-  ToolcraftVideoReferenceAcceptanceMapping,
-  ToolcraftVideoReferenceStoryboardFrame,
-  ToolcraftVideoReferenceStudyEvidence,
-  ToolcraftVideoReferenceTransition,
   ToolcraftVisibleControl,
 };
 

package/templates/starter/src/app/starter-acceptance.video-export-settings.test.ts

@@ -0,0 +1,338 @@
+import { describe, expect, it } from "vitest";
+
+import type { ToolcraftComponentAcceptance } from "./acceptance/types";
+import { getToolcraftOutputExportErrors } from "./acceptance/output-export";
+import { buildToolcraftOutputExportFacts } from "./acceptance/output-export-model";
+import { getToolcraftVideoExportErrors } from "./acceptance/output-video-export-rules";
+import { collectToolcraftVisibleAcceptanceControls } from "./acceptance/validate-coverage";
+import { defineContractSchemaFixture, validateContractAcceptance } from "./starter-acceptance.contract-fixtures";
+import {
+  makeBackgroundSection,
+  makeExportSettingsProductReadiness,
+} from "./starter-acceptance.export-test-utils";
+import { makeControlAcceptance } from "./starter-acceptance.test-utils";
+
+describe("Toolcraft video export settings acceptance contract", () => {
+  it("accepts a Segmented video format paired with a Select resolution", () => {
+    const schemaWithSegmentedVideoFormat = defineContractSchemaFixture({
+      canvas: {
+        enabled: true,
+        sizing: { mode: "editable-output" },
+      },
+      panels: {
+        controls: {
+          sections: [
+            makeBackgroundSection(),
+            {
+              controls: {
+                videoFormat: {
+                  defaultValue: "mp4",
+                  label: "Format",
+                  options: [
+                    { label: "MP4", value: "mp4" },
+                    { label: "WebM", value: "webm" },
+                  ],
+                  target: "export.video.format",
+                  type: "segmented",
+                },
+                videoResolution: {
+                  defaultValue: "current",
+                  label: "Resolution",
+                  options: [
+                    { label: "Current", value: "current" },
+                    { label: "4K", value: "4k" },
+                  ],
+                  target: "export.video.resolution",
+                  type: "select",
+                },
+              },
+              layoutGroups: [
+                {
+                  columns: 2,
+                  controls: ["videoFormat", "videoResolution"],
+                  layout: "inline",
+                },
+              ],
+              title: "Video Export",
+            },
+            {
+              actionGroup: "secondary",
+              controls: {
+                outputActions: {
+                  actions: [
+                    {
+                      icon: "upload-simple",
+                      label: "Export Video",
+                      role: "export-video",
+                      value: "export.video",
+                    },
+                  ],
+                  target: "actions.output",
+                  type: "panelActions",
+                },
+              },
+              title: "Export",
+            },
+          ],
+          title: "Controls",
+        },
+      },
+    });
+    const segmentedProductReadiness = makeExportSettingsProductReadiness({
+      image: {
+        evidence: "The user explicitly removed image delivery.",
+        mode: "user-removed",
+      },
+      svg: { mode: "not-requested" },
+      video: {
+        evidence: "The user explicitly requested video delivery.",
+        mode: "user-requested",
+      },
+    });
+    const videoFormatAcceptance = makeControlAcceptance(
+      "export.video.format",
+      "segmented",
+    );
+    videoFormatAcceptance.optionCoverage = ["mp4", "webm"];
+    const videoResolutionAcceptance = makeControlAcceptance(
+      "export.video.resolution",
+      "select",
+    );
+    videoResolutionAcceptance.optionCoverage = ["current", "4k"];
+    const acceptance: readonly ToolcraftComponentAcceptance[] = [
+      makeControlAcceptance("appearance.background", "color"),
+      makeControlAcceptance("export.includeBackground", "switch"),
+      videoFormatAcceptance,
+      videoResolutionAcceptance,
+      {
+        actionCoverage: ["export.video"],
+        automated: true,
+        automatedTestName: "exports segmented-format video output",
+        browser: true,
+        browserTestName: "browser: exports segmented-format video output",
+        componentType: "panelActions",
+        evidence: "exported-bytes",
+        expectedObservable: "Export Video creates validated video bytes.",
+        exportArtifactCoverage: "all-required-video-export-behavior",
+        fixture: "segmented video export fixture",
+        id: "actions.output",
+        kind: "control",
+        target: "actions.output",
+        userAction: "Choose MP4 or WebM, then export and inspect the video artifact.",
+      },
+    ];
+
+    expect(
+      getToolcraftOutputExportErrors({
+        acceptance,
+        controls: collectToolcraftVisibleAcceptanceControls(
+          schemaWithSegmentedVideoFormat,
+        ),
+        productReadiness: segmentedProductReadiness,
+        schema: schemaWithSegmentedVideoFormat,
+      }),
+    ).toEqual([]);
+
+    expect(
+      validateContractAcceptance({
+        acceptance,
+        productReadiness: segmentedProductReadiness,
+        schema: schemaWithSegmentedVideoFormat,
+      }),
+    ).not.toEqual(
+      expect.arrayContaining([
+        expect.stringContaining("includes segmented control videoFormat"),
+      ]),
+    );
+  });
+
+  it.each([
+    {
+      expected:
+        'Video Export format options must be exactly "mp4" and "webm".',
+      formatOptions: ["mp4", "webm", "mov"],
+      name: "extra video format",
+      resolutionOptions: ["current", "4k"],
+    },
+    {
+      expected:
+        'Video Export format options must be exactly "mp4" and "webm".',
+      formatOptions: ["mp4", "webm", "webm"],
+      name: "duplicate video format",
+      resolutionOptions: ["current", "4k"],
+    },
+    {
+      expected:
+        'Video Export resolution options must be exactly "current" and "4k".',
+      formatOptions: ["mp4", "webm"],
+      name: "extra video resolution",
+      resolutionOptions: ["current", "4k", "8k"],
+    },
+    {
+      expected:
+        'Video Export resolution options must be exactly "current" and "4k".',
+      formatOptions: ["mp4", "webm"],
+      name: "duplicate video resolution",
+      resolutionOptions: ["current", "4k", "4k"],
+    },
+  ])("rejects an $name option", ({
+    expected,
+    formatOptions,
+    resolutionOptions,
+  }) => {
+    const schema = defineContractSchemaFixture({
+      canvas: { enabled: true },
+      panels: {
+        controls: {
+          sections: [
+            {
+              controls: {
+                videoFormat: {
+                  defaultValue: "mp4",
+                  label: "Format",
+                  options: formatOptions.map((value) => ({
+                    label: value.toUpperCase(),
+                    value,
+                  })),
+                  target: "export.video.format",
+                  type: "select",
+                },
+                videoResolution: {
+                  defaultValue: "current",
+                  label: "Resolution",
+                  options: resolutionOptions.map((value) => ({
+                    label: value.toUpperCase(),
+                    value,
+                  })),
+                  target: "export.video.resolution",
+                  type: "select",
+                },
+              },
+              layoutGroups: [
+                {
+                  columns: 2,
+                  controls: ["videoFormat", "videoResolution"],
+                  layout: "inline",
+                },
+              ],
+              title: "Video Export",
+            },
+          ],
+          title: "Controls",
+        },
+      },
+    });
+
+    expect(
+      getToolcraftVideoExportErrors(
+        buildToolcraftOutputExportFacts({ schema }),
+      ),
+    ).toContain(expected);
+  });
+
+  it("validates the complete video format, resolution, defaults, and layout contract", () => {
+    const malformedVideoSchema = defineContractSchemaFixture({
+      canvas: {
+        enabled: true,
+        sizing: { mode: "editable-output" },
+      },
+      panels: {
+        controls: {
+          sections: [
+            makeBackgroundSection(),
+            {
+              controls: {
+                videoFormat: {
+                  defaultValue: "mov",
+                  label: "Format",
+                  target: "export.video.format",
+                  textValueKind: "single-line",
+                  type: "text",
+                },
+                videoResolution: {
+                  defaultValue: "8k",
+                  label: "Resolution",
+                  options: [
+                    { label: "Current", value: "current" },
+                    { label: "8K", value: "8k" },
+                  ],
+                  target: "export.video.resolution",
+                  type: "segmented",
+                },
+              },
+              title: "Video Export",
+            },
+            {
+              actionGroup: "secondary",
+              controls: {
+                outputActions: {
+                  actions: [
+                    {
+                      icon: "upload-simple",
+                      label: "Export Video",
+                      role: "export-video",
+                      value: "export.video",
+                    },
+                  ],
+                  target: "actions.output",
+                  type: "panelActions",
+                },
+              },
+              title: "Export",
+            },
+          ],
+          title: "Controls",
+        },
+      },
+    });
+
+    expect(
+      validateContractAcceptance({
+        acceptance: [
+          makeControlAcceptance("appearance.background", "color"),
+          makeControlAcceptance("export.includeBackground", "switch"),
+          makeControlAcceptance("export.video.format", "text"),
+          makeControlAcceptance("export.video.resolution", "segmented"),
+          {
+            actionCoverage: ["export.video"],
+            automated: true,
+            automatedTestName: "exports video output",
+            browser: true,
+            browserTestName: "browser: exports video output",
+            componentType: "panelActions",
+            evidence: "exported-bytes",
+            expectedObservable: "Export Video creates validated video bytes.",
+            exportArtifactCoverage: "all-required-video-export-behavior",
+            fixture: "video-only export fixture",
+            id: "actions.output",
+            kind: "control",
+            target: "actions.output",
+            userAction: "Export and inspect the video artifact.",
+          },
+        ],
+        productReadiness: makeExportSettingsProductReadiness({
+          image: {
+            evidence: "The user explicitly removed image delivery.",
+            mode: "user-removed",
+          },
+          svg: { mode: "not-requested" },
+          video: {
+            evidence: "The user explicitly requested video delivery.",
+            mode: "user-requested",
+          },
+        }),
+        schema: malformedVideoSchema,
+      }),
+    ).toEqual(
+      expect.arrayContaining([
+        "Video Export format must be a Select or Segmented control.",
+        'Video Export format options must be exactly "mp4" and "webm".',
+        'Video Export format must default to "mp4".',
+        "Video Export resolution must be a Select control.",
+        'Video Export resolution options must be exactly "current" and "4k".',
+        'Video Export resolution must default to "current".',
+        "Video Export format and resolution must render as one exact two-column inline row.",
+      ]),
+    );
+  });
+});