@pirireis/webglobeplugins 0.8.19 → 0.8.20

package/Math/arc.ts

@@ -79,8 +79,6 @@ export class Arc {
 
 
 
-
-    // TODO: EDGE CASE: the points are on same location 
     intersectionMedium(medium: Plane, target: Arc | null = null): Arc | null {
         // Orianted in right hand rule
         if (this.pointA.equals(this.pointB)) return null; // arc is too short
@@ -97,6 +95,10 @@ export class Arc {
             return null; // no intersection
         }
 
+        // think as this.pointA is on y=1 on a x-y space. this.pointB is on the x>0 part of the space.
+        // any point on x<0 is outside. Any point y<this._dot is outside.
+
+        // A is before B with right hand rule
         const [A, B] = (() => {
             Vector3D.crossVectors(...intersectionPoints, _AxB);
             if (_AxB.dot(this._AxB) >= 0) {
@@ -109,8 +111,7 @@ export class Arc {
 
         Vector3D.crossVectors(this.pointA, A, _A_x_otherA);
         Vector3D.crossVectors(this.pointA, B, _A_x_otherB);
-        // think as this.pointA is on y=1 on a x-y space. this.pointB is on the x>0 part of the space. 
-        // any point on x<0 is outside. Any point y<this._dot is outside.
+
         const _yA = this.pointA.dot(A);
         const _yB = this.pointA.dot(B);
 
@@ -119,6 +120,9 @@ export class Arc {
 
 
         if (_xA < 0 && _xB < 0) {
+            if (_yA > _yB) {
+                throw new Error("A is before B with right hand rule but A is on the left side of the arc. This should not happen.");
+            }
             return null; // no intersection
         }
         if (_yA < this._dot && _yB < this._dot) {
@@ -131,8 +135,10 @@ export class Arc {
         ];
         if (target === null) {
             target = new Arc(...resultPoints);
-        } else {
+        } else if (target instanceof Arc) {
             target.setFromUnitVectors(...resultPoints);
+        } else {
+            throw new Error("target is not null or an Arc instance");
         }
 
         return target;

package/Math/vector3d.ts

@@ -224,7 +224,9 @@ export class Vector3D implements IVector3D {
     }
 
 
+
     static fromLonLatRadians(lon: Radians, lat: Radians): Vector3D {
         return new Vector3D().setFromLonLat(lon, lat);
     }
+
 }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@pirireis/webglobeplugins",
-    "version": "0.8.19",
+    "version": "0.8.20",
     "main": "index.js",
     "author": "Toprak Nihat Deniz Ozturk",
     "license": "MIT"

package/tests/Math/arc.test.ts

@@ -47,6 +47,28 @@ test("intersectionMedium 2 - single point arc", () => {
 });
 
 
+describe(`intersectionMedium 3 - return full arc`, () => {
+
+    for (let i = 0; i < 100; i++) {
+        test(`intersectionMedium 3 - return full arc  ${i} `, () => {
+            _medium.set(new Vector3D(0, 0, 1), 0.001);
+            _0vector.randomUnit();
+            _0vector.z = Math.abs(_0vector.z);
+            _1vector.randomUnit();
+            _1vector.z = Math.abs(_1vector.z);
+            _0arc.setFromUnitVectors(_0vector, _1vector);
+
+            const _1arc = _0arc.intersectionMedium(_medium)!;
+            if (_1arc === null) {
+                console.log(_0arc, _medium);
+            }
+            expect(_1arc !== null).toBeTruthy();
+            expect(_0arc.equals(_1arc)).toBeTruthy();
+        });
+    }
+});
+
+
 test(" populatePoints3D", () => {
 
 });