@pirireis/webglobeplugins 0.8.17 → 0.8.19

package/Math/arc.ts

@@ -97,7 +97,6 @@ export class Arc {
             return null; // no intersection
         }
 
-
         const [A, B] = (() => {
             Vector3D.crossVectors(...intersectionPoints, _AxB);
             if (_AxB.dot(this._AxB) >= 0) {
@@ -110,8 +109,8 @@ export class Arc {
 
         Vector3D.crossVectors(this.pointA, A, _A_x_otherA);
         Vector3D.crossVectors(this.pointA, B, _A_x_otherB);
-
-        // think as this.pointA is on Vector3D(0, 0, 1) on some space
+        // think as this.pointA is on y=1 on a x-y space. this.pointB is on the x>0 part of the space. 
+        // any point on x<0 is outside. Any point y<this._dot is outside.
         const _yA = this.pointA.dot(A);
         const _yB = this.pointA.dot(B);
 
@@ -126,13 +125,14 @@ export class Arc {
             return null; // no intersection
         }
 
-
-        const results: [Vector3D, Vector3D] = [_xA < 0 ? this.pointA.clone() : A, _yB <= this._dot ? this.pointB.clone() : B];
-
+        const resultPoints: [Vector3D, Vector3D] = [
+            _xA < 0 ? this.pointA.clone() : A,
+            _yB <= this._dot ? this.pointB.clone() : B
+        ];
         if (target === null) {
-            target = new Arc(...results);
+            target = new Arc(...resultPoints);
         } else {
-            target.setFromUnitVectors(...results);
+            target.setFromUnitVectors(...resultPoints);
         }
 
         return target;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@pirireis/webglobeplugins",
-    "version": "0.8.17",
+    "version": "0.8.19",
     "main": "index.js",
     "author": "Toprak Nihat Deniz Ozturk",
     "license": "MIT"

package/rangerings/rangeringangletext.js

@@ -48,6 +48,7 @@ export default class RangeRingAngleText {
         label.vAlignment = 2;
         label.hAlignment = 2;
         label.size = 17;
+        // eslint-disable-next-line
         label.text = "`${aci}`"
 
         return style;
@@ -163,7 +164,7 @@ export default class RangeRingAngleText {
 
     /**
      * 
-     * @param {Array<{centerID:string, hide: bool}} centerHides 
+     * @param {Array<{centerID:string, hide: bool}>} centerHides 
      */
     updateCentersHide(centerHides) {
         if (this._hideAll) {

package/waveparticles/plugin.js

@@ -20,7 +20,7 @@ const MAX_PIXELS_ON_DIMENSION = 2200;
 
 
 export default class Plugin {
-    constructor(id, { fadeOpacity = 0.83, opacity = 0.75, minLon = -180, minLat = -90, maxLon = 180, maxLat = 90, patricleCount = 8000, dataWidth, dataHeight, drawTextureMaxPixelOnDimension = MAX_PIXELS_ON_DIMENSION } = {}) {
+    constructor(id, { dataWidth, dataHeight, fadeOpacity = 0.83, opacity = 0.75, minLon = -180, minLat = -90, maxLon = 180, maxLat = 90, patricleCount = 8000, flipY = true, drawTextureMaxPixelOnDimension = MAX_PIXELS_ON_DIMENSION } = {}) {
 
         this.id = id;
         this.globe = null;
@@ -31,6 +31,7 @@ export default class Plugin {
         this._rgVectorFieldTexture = null;
         this.globeShellWiggle = null;
         this.waveUbo = null;
+        this._flipY = flipY;
         this._drawTextureResolution = {};
         this._frameBuffer = null;
         this._fadeOpacity = fadeOpacity;
@@ -84,6 +85,7 @@ export default class Plugin {
         gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MAG_FILTER, gl.LINEAR);
         gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_WRAP_S, gl.CLAMP_TO_EDGE);
         gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_WRAP_T, gl.CLAMP_TO_EDGE);
+
         gl.bindTexture(gl.TEXTURE_2D, null);
         return texture;
     }
@@ -145,7 +147,7 @@ export default class Plugin {
     }
 
     _createRGTexture() {
-        const { gl, _dataWidth, _dataHeight } = this;
+        const { gl, _dataWidth, _dataHeight, } = this;
         const texture = gl.createTexture();
         // R32F
         gl.bindTexture(gl.TEXTURE_2D, texture);
@@ -154,8 +156,8 @@ export default class Plugin {
         gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MAG_FILTER, gl.NEAREST);
         gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_WRAP_S, gl.CLAMP_TO_EDGE);
         gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_WRAP_T, gl.CLAMP_TO_EDGE);
-        gl.pixelStorei(gl.UNPACK_FLIP_Y_WEBGL, false);
-
+        // gl.pixelStorei(gl.UNPACK_FLIP_X_WEBGL, this._flipX);
+        gl.pixelStorei(gl.UNPACK_FLIP_Y_WEBGL, this._flipY);
         gl.bindTexture(gl.TEXTURE_2D, null);
         return texture;
     }
@@ -186,11 +188,12 @@ export default class Plugin {
     }
 
 
-    setVectorFieldData(data, dataWidth = null, dataHeight = null) {
+    setVectorFieldData(data, { dataWidth = null, dataHeight = null } = {}) {
         if (dataWidth !== null && dataHeight !== null) {
             this._dataWidth = dataWidth;
             this._dataHeight = dataHeight;
         }
+
         const { gl, _dataWidth, _dataHeight } = this;
         gl.bindTexture(gl.TEXTURE_2D, this._rgVectorFieldTexture);
         gl.texImage2D(gl.TEXTURE_2D, 0, gl.RG32F, _dataWidth, _dataHeight, 0, gl.RG, gl.FLOAT, data);