@pippit-dev/cli 1.0.21 → 1.0.23

package/cmd/upload_file_test.go

@@ -0,0 +1,155 @@
+package cmd
+
+import (
+	"bytes"
+	"io"
+	"net/http"
+	"net/http/httptest"
+	"os"
+	"path/filepath"
+	"strings"
+	"testing"
+
+	"github.com/Pippit-dev/pippit-cli/internal/config"
+)
+
+func TestUploadFileMediaContract(t *testing.T) {
+	for _, name := range []string{"image.png", "image.WEBP", "video.mp4", "audio.mp3", "audio.WAV"} {
+		t.Run(name, func(t *testing.T) {
+			path := filepath.Join(t.TempDir(), name)
+			if err := os.WriteFile(path, []byte("media-content"), 0o600); err != nil {
+				t.Fatal(err)
+			}
+			calls := 0
+			server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+				calls++
+				if r.Method != http.MethodPost || r.URL.Path != config.UploadFilePath {
+					t.Errorf("unexpected request: %s %s", r.Method, r.URL.Path)
+				}
+				if r.Header.Get("Authorization") != "Bearer test-token" {
+					t.Error("missing bearer authorization")
+				}
+				body, err := io.ReadAll(r.Body)
+				if err != nil {
+					t.Error(err)
+					return
+				}
+				if bytes.Contains(body, []byte("test-token")) || bytes.Contains(body, []byte(`name="accessKey"`)) {
+					t.Error("credentials must not appear in multipart body")
+				}
+				r.Body = io.NopCloser(bytes.NewReader(body))
+				if err := r.ParseMultipartForm(1 << 20); err != nil {
+					t.Error(err)
+					return
+				}
+				defer r.MultipartForm.RemoveAll()
+				files := r.MultipartForm.File["file"]
+				if len(files) != 1 || files[0].Filename != name {
+					t.Errorf("unexpected file parts: %#v", files)
+					return
+				}
+				contentType := files[0].Header.Get("Content-Type")
+				prefix := "audio/"
+				if strings.HasPrefix(name, "image") {
+					prefix = "image/"
+				} else if strings.HasPrefix(name, "video") {
+					prefix = "video/"
+				}
+				if !strings.HasPrefix(contentType, prefix) {
+					t.Errorf("content type = %s, want %s", contentType, prefix)
+				}
+				file, err := files[0].Open()
+				if err != nil {
+					t.Error(err)
+					return
+				}
+				defer file.Close()
+				data, err := io.ReadAll(file)
+				if err != nil || string(data) != "media-content" {
+					t.Errorf("uploaded content = %q, err = %v", data, err)
+				}
+				_, _ = w.Write([]byte(`{"ret":"0","data":{"pippit_asset_id":"asset_original"}}`))
+			}))
+			defer server.Close()
+			var stdout, stderr bytes.Buffer
+			root := newTestRootCommand(t, &stdout, &stderr, server.URL)
+			root.SetArgs([]string{"upload-file", "--path", path})
+			if err := root.Execute(); err != nil {
+				t.Fatal(err)
+			}
+			if stdout.String() != "{\"asset_id\":\"asset_original\"}\n" || calls != 1 {
+				t.Fatalf("stdout = %q, requests = %d", stdout.String(), calls)
+			}
+		})
+	}
+}
+
+func TestValidateMediaUpload(t *testing.T) {
+	dir := t.TempDir()
+	for _, tc := range []struct {
+		name string
+		size int64
+		ok   bool
+	}{
+		{"below-limit.png", maxMediaUploadBytes - 1, true},
+		{"at-limit.png", maxMediaUploadBytes, false},
+		{"over-limit.png", maxMediaUploadBytes + 1, false},
+		{"script.docx", 1, false},
+		{"audio.flac", 1, false},
+		{"file.unknown", 1, false},
+	} {
+		path := filepath.Join(dir, tc.name)
+		if err := os.WriteFile(path, nil, 0o600); err != nil {
+			t.Fatal(err)
+		}
+		// Sparse files exercise the exact size boundary without large allocations.
+		if err := os.Truncate(path, tc.size); err != nil {
+			t.Fatal(err)
+		}
+		if err := validateMediaUpload(path); (err == nil) != tc.ok {
+			t.Errorf("validateMediaUpload(%s) = %v, want accepted=%t", tc.name, err, tc.ok)
+		}
+	}
+	for _, path := range []string{"", dir, filepath.Join(dir, "missing.png")} {
+		if err := validateMediaUpload(path); err == nil {
+			t.Errorf("validateMediaUpload(%q) should fail", path)
+		}
+	}
+}
+
+func TestUploadFileCommandHelpAndArguments(t *testing.T) {
+	var stdout, stderr bytes.Buffer
+	root := newRootCommand(&stdout, &stderr, nil)
+	root.SetArgs([]string{"upload-file", "--help"})
+	if err := root.Execute(); err != nil || !strings.Contains(stdout.String(), "--path") {
+		t.Fatalf("help must work without credentials: %v, %s", err, stdout.String())
+	}
+	for _, args := range [][]string{{"upload-file"}, {"upload-file", "--path", " "}, {"upload-file", "unexpected"}} {
+		root := newRootCommand(&stdout, &stderr, nil)
+		root.SetArgs(args)
+		if err := root.Execute(); err == nil {
+			t.Errorf("Execute(%v) should fail", args)
+		}
+	}
+}
+
+func TestUploadFileRejectsInvalidResponse(t *testing.T) {
+	path := filepath.Join(t.TempDir(), "image.png")
+	if err := os.WriteFile(path, []byte("media"), 0o600); err != nil {
+		t.Fatal(err)
+	}
+	for _, response := range []string{`{"ret":"1","errmsg":"rejected"}`, `{"ret":"0","data":{"asset_id":"wrong_field"}}`} {
+		server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+			_, _ = io.Copy(io.Discard, r.Body)
+			_, _ = w.Write([]byte(response))
+		}))
+		var stdout, stderr bytes.Buffer
+		root := newTestRootCommand(t, &stdout, &stderr, server.URL)
+		root.SetArgs([]string{"upload-file", "--path", path})
+		err := root.Execute()
+		server.Close()
+		if err == nil || stdout.Len() != 0 {
+			t.Errorf("response %s: error = %v, stdout = %s", response, err, stdout.String())
+		}
+	}
+}

package/dist/checksums.txt

@@ -1,6 +1,6 @@
-c1657ee91f7f964dd936ecd723ff4985c12be4585f7f64dff96adba0277ec669  pippit-tool-cli-1.0.21-darwin-amd64.tar.gz
-ebfe75d1a8fbd6e76125b49917e97a3a81db6c4bae35ab5a1cb9625c618ea490  pippit-tool-cli-1.0.21-darwin-arm64.tar.gz
-3d828780c00f985378df61072d633e84dd2bcba3b8f7b7e6619fbd9ee34bf2a2  pippit-tool-cli-1.0.21-linux-amd64.tar.gz
-14dfb1412da253c62a4a52c27a40ce09c3af8480be9c4a94565952e7eed9afff  pippit-tool-cli-1.0.21-linux-arm64.tar.gz
-0d7b8bc575efb3928f8881cb2ba76f2583c2d4ed3f53c7ab3c98f53cf278d0c3  pippit-tool-cli-1.0.21-windows-amd64.zip
-3145e59e584bfd618b06d8a4e1586d242ff8c568f7221737f2f06d8f111a2cd7  pippit-tool-cli-1.0.21-windows-arm64.zip
+259ad5fb69598b646e035e5dd70fd6c905a25128b1b9c8e9689c58e09ec0a3d9  pippit-tool-cli-1.0.23-darwin-amd64.tar.gz
+610ec13e42a53a472759daf322701e178b062ff2ca2e854382cf5a8b6b894953  pippit-tool-cli-1.0.23-darwin-arm64.tar.gz
+3d371bb915e4b6adaf29cd3b1b06a9ee6a40896f962051ce97adeb1937a1b4a1  pippit-tool-cli-1.0.23-linux-amd64.tar.gz
+541f8a8e1913a591ad98ed3835525eba8459fd12ec289f9b206f9588812311c8  pippit-tool-cli-1.0.23-linux-arm64.tar.gz
+0ded272a827aa39427c53135465c99e6e1f94c81ef1f5e0982c6726d385e03bf  pippit-tool-cli-1.0.23-windows-amd64.zip
+ab6fd1baeac84e4e3cdde2392462534bd2a6279ee1cab0395437f1a03b5ace55  pippit-tool-cli-1.0.23-windows-arm64.zip