@pipelab/core-node 1.0.0-beta.17 → 1.0.0-beta.18

package/src/plugins-registry.ts

@@ -299,24 +299,22 @@ export const builtInPlugins = async (options: { context: PipelabContext }): Prom
     console.log(`[Plugins] Total plugins to load on startup:`, Array.from(pluginsToLoad.entries()));
 
     // Now load all collected plugins in parallel
-    const loadPromises = Array.from(pluginsToLoad.entries()).map(
-      async ([packageName, version]) => {
-        sendStartupProgress(`Loading plugin: ${packageName}`);
-        const pluginStart = Date.now();
-        try {
-          const plugin = await loadCustomPlugin(packageName, version, options);
-          if (plugin) {
-            registerPlugins([plugin]);
-            webSocketServer.broadcast("plugin:loaded", { plugin });
-            console.log(
-              `[Plugins] Loaded ${packageName}@${version} in ${Date.now() - pluginStart}ms`,
-            );
-          }
-        } catch (err) {
-          console.error(`[Plugins] Failed to load plugin ${packageName} at startup:`, err);
+    const loadPromises = Array.from(pluginsToLoad.entries()).map(async ([packageName, version]) => {
+      sendStartupProgress(`Loading plugin: ${packageName}`);
+      const pluginStart = Date.now();
+      try {
+        const plugin = await loadCustomPlugin(packageName, version, options);
+        if (plugin) {
+          registerPlugins([plugin]);
+          webSocketServer.broadcast("plugin:loaded", { plugin });
+          console.log(
+            `[Plugins] Loaded ${packageName}@${version} in ${Date.now() - pluginStart}ms`,
+          );
         }
-      },
-    );
+      } catch (err) {
+        console.error(`[Plugins] Failed to load plugin ${packageName} at startup:`, err);
+      }
+    });
     await Promise.all(loadPromises);
 
     console.log(`[Plugins] All startup plugins loaded in ${Date.now() - totalStart}ms.`);

package/src/runner.ts

@@ -1,6 +1,6 @@
 import { executeGraphWithHistory } from "./utils";
 import { setupConfigFile } from "./config";
-import { isDev, PipelabContext } from "./context";
+import { isDev, PipelabContext, CacheFolder } from "./context";
 import { readFile, access, writeFile, mkdir } from "node:fs/promises";
 import { resolve, isAbsolute, join, dirname } from "node:path";
 import { savedFileMigrator } from "@pipelab/shared";
@@ -67,9 +67,7 @@ export async function runPipelineCommand(file: string, options: RunOptions, vers
   await registerAllHandlers({ version, context });
   registerMigrationHandlers(context);
 
-  const settings = await setupConfigFile<AppConfig>("settings", { context });
-  const config = await settings.getConfig();
-  const cachePath = join(context.userDataPath, "cache");
+  const cachePath = context.getCachePath(CacheFolder.Pipelines, effectivePipelineId);
   await mkdir(cachePath, { recursive: true });
 
   const abortController = new AbortController();

package/src/server.ts

@@ -116,6 +116,7 @@ export async function serveCommand(options: ServeOptions, version: string, _dirn
 
     return handler(request, response, {
       public: rawAssetFolder,
+      rewrites: [{ source: "/**", destination: "/index.html" }],
     });
   });
 

package/src/utils/github.test.ts

@@ -29,7 +29,7 @@ describe("GitHub Release Updates API", () => {
     expect(releases).toEqual([]);
     expect(fetchSpy).toHaveBeenCalledWith(
       expect.stringContaining("matching-refs/tags/%40pipelab%2Fapp"),
-      expect.any(Object)
+      expect.any(Object),
     );
   });
 
@@ -153,7 +153,7 @@ describe("GitHub Release Updates API", () => {
     expect(releases[0].tag_name).toBe("@pipelab/app@1.2.3");
     expect(fetchSpy).toHaveBeenCalledWith(
       expect.stringContaining("releases/tags/%40pipelab%2Fapp%401.2.3"),
-      expect.any(Object)
+      expect.any(Object),
     );
   });
 
@@ -189,9 +189,7 @@ describe("GitHub Release Updates API", () => {
     // Mock matching refs
     fetchSpy.mockResolvedValueOnce({
       ok: true,
-      json: async () => [
-        { ref: "refs/tags/@pipelab/app@3.0.0" },
-      ],
+      json: async () => [{ ref: "refs/tags/@pipelab/app@3.0.0" }],
     } as any);
 
     // Mock release lookup

package/src/utils/remote.test.ts

@@ -93,13 +93,16 @@ describe("remote utilities & offline mode", () => {
 
   test("fetchPipelabPlugin maps latest to releaseTag for official plugins", async () => {
     vi.advanceTimersByTime(30000); // Bypass 10s caching
-    const context = new PipelabContext({ userDataPath: "/tmp/pipelab-test-remote", releaseTag: "beta" });
+    const context = new PipelabContext({
+      userDataPath: "/tmp/pipelab-test-remote",
+      releaseTag: "beta",
+    });
     const pluginName = "@pipelab/plugin-poki";
     const packageBaseDir = context.getPackagesPath(pluginName);
     const cachedVersionDir = path.join(packageBaseDir, "1.0.0-beta.15");
 
     vi.spyOn(dns, "lookup").mockResolvedValue({ address: "1.2.3.4", family: 4 } as any);
-    
+
     vi.mocked(pacote.packument).mockResolvedValue({
       name: pluginName,
       versions: {
@@ -128,13 +131,16 @@ describe("remote utilities & offline mode", () => {
 
   test("fetchPipelabPlugin maps latest to releaseTag for custom plugins and falls back to latest if tag is missing", async () => {
     vi.advanceTimersByTime(40000); // Bypass 10s caching
-    const context = new PipelabContext({ userDataPath: "/tmp/pipelab-test-remote-custom", releaseTag: "beta" });
+    const context = new PipelabContext({
+      userDataPath: "/tmp/pipelab-test-remote-custom",
+      releaseTag: "beta",
+    });
     const pluginName = "custom-cool-plugin";
     const packageBaseDir = context.getPackagesPath(pluginName);
     const cachedVersionDir = path.join(packageBaseDir, "2.0.0");
 
     vi.spyOn(dns, "lookup").mockResolvedValue({ address: "1.2.3.4", family: 4 } as any);
-    
+
     vi.mocked(pacote.packument).mockResolvedValue({
       name: pluginName,
       versions: {
@@ -163,13 +169,16 @@ describe("remote utilities & offline mode", () => {
 
   test("fetchPipelabPlugin maps latest to releaseTag for custom plugins and falls back to latest if beta is stale", async () => {
     vi.advanceTimersByTime(50000); // Bypass 10s caching
-    const context = new PipelabContext({ userDataPath: "/tmp/pipelab-test-remote-stale", releaseTag: "beta" });
+    const context = new PipelabContext({
+      userDataPath: "/tmp/pipelab-test-remote-stale",
+      releaseTag: "beta",
+    });
     const pluginName = "stale-beta-plugin";
     const packageBaseDir = context.getPackagesPath(pluginName);
     const cachedVersionDir = path.join(packageBaseDir, "2.0.0");
 
     vi.spyOn(dns, "lookup").mockResolvedValue({ address: "1.2.3.4", family: 4 } as any);
-    
+
     vi.mocked(pacote.packument).mockResolvedValue({
       name: pluginName,
       versions: {

package/src/utils/remote.ts

@@ -14,7 +14,7 @@ import { existsSync, constants, statSync, readdirSync } from "node:fs";
 import dns from "node:dns/promises";
 import pacote from "pacote";
 import semver from "semver";
-import { isDev, projectRoot, PipelabContext } from "../context";
+import { isDev, projectRoot, PipelabContext, CacheFolder } from "../context";
 import { execa } from "execa";
 import { sendStartupProgress } from "../server";
 import { downloadFile, extractZip, extractTarGz } from "./fs-extras";
@@ -163,7 +163,7 @@ export async function fetchPackage(
   } else {
     try {
       // 1. Resolve version/range using npm with session-wide memoization and disk cache
-      const cachePath = join(ctx.userDataPath, "cache", "pacote");
+      const cachePath = ctx.getCachePath(CacheFolder.Pacote);
       let packumentPromise = packumentRequests.get(packageName);
       if (!packumentPromise) {
         packumentPromise = pacote.packument(packageName, { cache: cachePath });
@@ -183,7 +183,10 @@ export async function fetchPackage(
       if (range === "latest" && ctx.releaseTag && ctx.releaseTag !== "latest") {
         const releaseTagVersion = packument["dist-tags"]?.[ctx.releaseTag];
         if (releaseTagVersion && semver.valid(releaseTagVersion)) {
-          if (!foundVersion || (semver.valid(foundVersion) && semver.gte(releaseTagVersion, foundVersion))) {
+          if (
+            !foundVersion ||
+            (semver.valid(foundVersion) && semver.gte(releaseTagVersion, foundVersion))
+          ) {
             console.log(
               `[Fetcher] Using release tag "${ctx.releaseTag}" (${releaseTagVersion}) instead of "latest" (${foundVersion || "none"}) for ${packageName}`,
             );
@@ -227,7 +230,7 @@ export async function fetchPackage(
     }
   }
 
-  const cachePath = join(ctx.userDataPath, "cache", "pacote");
+  const cachePath = ctx.getCachePath(CacheFolder.Pacote);
   const packageDir = join(baseDir, resolvedVersion);
 
   const checkStart = Date.now();
@@ -351,7 +354,7 @@ export async function runPnpm(
       ...process.env,
       NODE_ENV: "production",
       PATH: nodePath ? `${dirname(nodePath)}${delimiter}${process.env.PATH}` : process.env.PATH,
-      PNPM_HOME: join(ctx.userDataPath, "pnpm"),
+      PNPM_HOME: ctx.getPnpmPath(),
       PNPM_ONLY_ALLOW_TRUSTED_DEPENDENCIES: "false",
       ...extraEnv,
     },

package/src/utils/storage.ts

@@ -12,7 +12,8 @@ export class JsonFileStorage {
   private logger = useLogger().logger;
 
   constructor(fileName: string, context: PipelabContext) {
-    this.filePath = path.join(context.userDataPath, fileName);
+    this.filePath = context.getConfigPath(fileName);
+
     const dir = path.dirname(this.filePath);
     if (!fs.existsSync(dir)) {
       try {

package/src/utils.ts

@@ -102,6 +102,7 @@ export const executeGraphWithHistory = async ({
     projectName,
     projectPath,
     pipelineId,
+    cachePath,
     startTime,
     status: "running",
     logs: [],
@@ -247,18 +248,17 @@ export const executeGraphWithHistory = async ({
 
     throw error;
   } finally {
-    // Apply retention policy regardless of outcome
-    if (!shouldDisableHistory) {
-      // Don't await, let it run in the background
-      buildHistoryStorage.applyRetentionPolicy();
-    }
-
     if (shouldCleanup) {
       try {
         await rm(sandboxPath, { recursive: true, force: true });
       } catch (e) {
         console.warn(`Failed to cleanup sandbox at ${sandboxPath}:`, e);
       }
+      try {
+        await rm(cachePath, { recursive: true, force: true });
+      } catch (e) {
+        console.warn(`Failed to cleanup cache at ${cachePath}:`, e);
+      }
     }
   }
 };