@pipedream/trello 0.4.0 → 0.4.1

package/sources/card-updates/test-event.mjs

@@ -0,0 +1,86 @@
+export default {
+  "id": "620eb14ebda9570d72fddead",
+  "badges": {
+    "attachmentsByType": {
+      "trello": {
+        "board": 0,
+        "card": 0
+      }
+    },
+    "externalSource": null,
+    "location": false,
+    "votes": 0,
+    "viewingMemberVoted": false,
+    "subscribed": false,
+    "fogbugz": "",
+    "checkItems": 1,
+    "checkItemsChecked": 1,
+    "checkItemsEarliestDue": null,
+    "comments": 3,
+    "attachments": 1,
+    "description": false,
+    "due": "2021-05-10T21:50:00.000Z",
+    "dueComplete": false,
+    "start": null,
+    "lastUpdatedByAi": false
+  },
+  "checkItemStates": [
+    {
+      "idCheckItem": "620eb14fbda9570d72fde031",
+      "state": "complete"
+    }
+  ],
+  "closed": false,
+  "dueComplete": false,
+  "dateLastActivity": "2024-09-30T16:31:35.215Z",
+  "desc": "",
+  "descData": {
+    "emoji": {}
+  },
+  "due": "2021-05-10T21:50:00.000Z",
+  "dueReminder": null,
+  "email": null,
+  "idBoard": "5f4d7be6c45c22583f75fa02",
+  "idChecklists": [
+    "620eb14fbda9570d72fde030"
+  ],
+  "idList": "5f4d7f78bdd7ce4d2d25fdda",
+  "idMembers": [],
+  "idMembersVoted": [],
+  "idShort": 85,
+  "idAttachmentCover": "620eb14ebda9570d72fdded7",
+  "labels": [
+    {
+      "id": "5f4d7be6cdabcf46c027c792",
+      "idBoard": "5f4d7be6c45c22583f75fa02",
+      "idOrganization": "6047c17c2f558003144e04d7",
+      "name": "green label",
+      "nodeId": "ari:cloud:trello::label/workspace/6047c17c2f558003144e04d7/5f4d7be6cdabcf46c027c792",
+      "color": "green",
+      "uses": 9
+    },
+  ],
+  "idLabels": [
+    "5f4d7be6cdabcf46c027c792",
+  ],
+  "manualCoverAttachment": false,
+  "name": "new card",
+  "pinned": false,
+  "pos": 360447,
+  "shortLink": "dho6bOdR",
+  "shortUrl": "https://trello.com/c/dho6bOdR",
+  "start": null,
+  "subscribed": false,
+  "url": "https://trello.com/c/dho6bOdR/85-new-card",
+  "cover": {
+    "idAttachment": "620eb14ebda9570d72fdded7",
+    "color": null,
+    "idUploadedBackground": null,
+    "size": "normal",
+    "brightness": "dark",
+    "idPlugin": null
+  },
+  "isTemplate": false,
+  "cardRole": null,
+  "customFieldItems": []
+}

package/sources/common/actions.mjs

@@ -0,0 +1,206 @@
+export default [
+  {
+    label: "Accept Enterprise Join Request",
+    value: "acceptEnterpriseJoinRequest",
+  },
+  {
+    label: "Add Attachment To Card",
+    value: "addAttachmentToCard",
+  },
+  {
+    label: "Add Checklist To Card",
+    value: "addChecklistToCard",
+  },
+  {
+    label: "Add Member To Board",
+    value: "addMemberToBoard",
+  },
+  {
+    label: "Add Member To Card",
+    value: "addMemberToCard",
+  },
+  {
+    label: "Add Member To Organization",
+    value: "addMemberToOrganization",
+  },
+  {
+    label: "Add Organization To Enterprise",
+    value: "addOrganizationToEnterprise",
+  },
+  {
+    label: "Add To Enterprise Plugin Whitelist",
+    value: "addToEnterprisePluginWhitelist",
+  },
+  {
+    label: "Add To Organization Board",
+    value: "addToOrganizationBoard",
+  },
+  {
+    label: "Comment Card",
+    value: "commentCard",
+  },
+  {
+    label: "Convert To Card From Check Item",
+    value: "convertToCardFromCheckItem",
+  },
+  {
+    label: "Copy Board",
+    value: "copyBoard",
+  },
+  {
+    label: "Copy Card",
+    value: "copyCard",
+  },
+  {
+    label: "Copy Comment Card",
+    value: "copyCommentCard",
+  },
+  {
+    label: "Create Board",
+    value: "createBoard",
+  },
+  {
+    label: "Create Card",
+    value: "createCard",
+  },
+  {
+    label: "Create List",
+    value: "createList",
+  },
+  {
+    label: "Create Organization",
+    value: "createOrganization",
+  },
+  {
+    label: "Delete Board Invitation",
+    value: "deleteBoardInvitation",
+  },
+  {
+    label: "Delete Card",
+    value: "deleteCard",
+  },
+  {
+    label: "Delete Organization Invitation",
+    value: "deleteOrganizationInvitation",
+  },
+  {
+    label: "Disable Enterprise Plugin Whitelist",
+    value: "disableEnterprisePluginWhitelist",
+  },
+  {
+    label: "Disable Plugin",
+    value: "disablePlugin",
+  },
+  {
+    label: "Disable Power Up",
+    value: "disablePowerUp",
+  },
+  {
+    label: "Email Card",
+    value: "emailCard",
+  },
+  {
+    label: "Enable Enterprise Plugin Whitelist",
+    value: "enableEnterprisePluginWhitelist",
+  },
+  {
+    label: "Enable Plugin",
+    value: "enablePlugin",
+  },
+  {
+    label: "Enable Power Up",
+    value: "enablePowerUp",
+  },
+  {
+    label: "Make Admin Of Board",
+    value: "makeAdminOfBoard",
+  },
+  {
+    label: "Make Normal Member Of Board",
+    value: "makeNormalMemberOfBoard",
+  },
+  {
+    label: "Make Normal Member Of Organization",
+    value: "makeNormalMemberOfOrganization",
+  },
+  {
+    label: "Make Observer Of Board",
+    value: "makeObserverOfBoard",
+  },
+  {
+    label: "Member Joined Trello",
+    value: "memberJoinedTrello",
+  },
+  {
+    label: "Move Card From Board",
+    value: "moveCardFromBoard",
+  },
+  {
+    label: "Move Card To Board",
+    value: "moveCardToBoard",
+  },
+  {
+    label: "Move List From Board",
+    value: "moveListFromBoard",
+  },
+  {
+    label: "Move List To Board",
+    value: "moveListToBoard",
+  },
+  {
+    label: "Remove Checklist From Card",
+    value: "removeChecklistFromCard",
+  },
+  {
+    label: "Remove From Enterprise Plugin Whitelist",
+    value: "removeFromEnterprisePluginWhitelist",
+  },
+  {
+    label: "Remove From Organization Board",
+    value: "removeFromOrganizationBoard",
+  },
+  {
+    label: "Remove Member From Card",
+    value: "removeMemberFromCard",
+  },
+  {
+    label: "Remove Organization From Enterprise",
+    value: "removeOrganizationFromEnterprise",
+  },
+  {
+    label: "Unconfirmed Board Invitation",
+    value: "unconfirmedBoardInvitation",
+  },
+  {
+    label: "Unconfirmed Organization Invitation",
+    value: "unconfirmedOrganizationInvitation",
+  },
+  {
+    label: "Update Board",
+    value: "updateBoard",
+  },
+  {
+    label: "Update Card",
+    value: "updateCard",
+  },
+  {
+    label: "Update Check Item State On Card",
+    value: "updateCheckItemStateOnCard",
+  },
+  {
+    label: "Update Checklist",
+    value: "updateChecklist",
+  },
+  {
+    label: "Update List",
+    value: "updateList",
+  },
+  {
+    label: "Update Member",
+    value: "updateMember",
+  },
+  {
+    label: "Update Organization",
+    value: "updateOrganization",
+  },
+];

package/sources/common/common-board-based.mjs

@@ -14,7 +14,7 @@ export default {
       ],
     },
     onlyEventsRelatedWithAuthenticatedUser: {
-      label: "Only Events Related With Me",
+      label: "Only Events Related To Me",
       description: "Only will emit events from the cards related with the authenticated user",
       type: "boolean",
       default: false,
@@ -32,19 +32,24 @@ export default {
         return false;
       }
 
+      if (this.lists?.length) {
+        const list = await this.app.getCardList({
+          cardId: result.idCard,
+        });
+        if (!this.lists.includes(list.id)) {
+          return false;
+        }
+      }
+
       const member = await this.app.getMember({
         memberId: "me",
       });
 
-      if (
+      return !(
         this.onlyEventsRelatedWithAuthenticatedUser &&
         result?.idMembers?.length &&
         !result.idMembers.includes(member.id)
-      ) {
-        return false;
-      }
-
-      return true;
+      );
     },
   },
 };

package/sources/common/common-webhook.mjs

@@ -9,12 +9,9 @@ export default {
   },
   hooks: {
     async deploy() {
-      const {
-        sampleEvents, sortField,
-      } = await this.getSampleEvents();
-      sampleEvents.sort((a, b) => (Date.parse(a[sortField]) > Date.parse(b[sortField]))
-        ? 1
-        : -1);
+      let sampleEvents = await this.getSampleEvents();
+      const sortField = this.getSortField();
+      sampleEvents = this.sortItemsByDate(sampleEvents, sortField);
       for (const event of sampleEvents.slice(-25)) {
         this.emitEvent(event);
       }
@@ -28,17 +25,25 @@ export default {
           callbackURL: this.http.endpoint,
         },
       });
-      this.db.set("hookId", id);
+      this._setHookId(id);
     },
     async deactivate() {
-      const hookId = this.db.get("hookId");
-      await this.deleteHook({
-        hookId,
-      });
+      const hookId = this._getHookId();
+      if (hookId) {
+        await this.deleteHook({
+          hookId,
+        });
+      }
     },
   },
   methods: {
     ...common.methods,
+    _getHookId() {
+      return this.db.get("hookId");
+    },
+    _setHookId(hookId) {
+      this.db.set("hookId", hookId);
+    },
     getBase64Digest(data) {
       const { secret } = this.app.getToken();
       return createHmac("sha1", secret)
@@ -57,7 +62,6 @@ export default {
     createHook(args = {}) {
       return this.app.post({
         ...args,
-        debug: true,
         path: "/webhooks/",
       });
     },
@@ -66,7 +70,6 @@ export default {
     } = {}) {
       return this.app.delete({
         ...args,
-        debug: true,
         path: `/webhooks/${hookId}`,
       });
     },
@@ -97,9 +100,15 @@ export default {
     isRelevant() {
       return true;
     },
+    getResult(action) {
+      return action;
+    },
     getSampleEvents() {
       throw new Error("getSampleEvents not implemented");
     },
+    getSortField() {
+      throw new Error("getSortField is not implemented");
+    },
   },
   async run(event) {
     if (event.body === undefined) {
@@ -112,15 +121,17 @@ export default {
       return;
     }
 
-    if (!this.isCorrectEventType(event)) {
+    const { action } = event.body;
+
+    if (!this.isCorrectEventType(action)) {
       console.log("The event is not of the correct type. Skipping...");
       return;
     }
 
-    const result = await this.getResult(event);
+    const result = await this.getResult(action);
     const isRelevant = await this.isRelevant({
       result,
-      event,
+      action,
     });
 
     if (!isRelevant) {

package/sources/common/common.mjs

@@ -13,11 +13,11 @@ export default {
      * @param {string} name - The name of the item of the book.
      */
     generateMeta({
-      id, name: summary,
+      id, name,
     }) {
       return {
         id,
-        summary,
+        summary: name || `${id}`,
         ts: Date.now(),
       };
     },
@@ -30,5 +30,8 @@ export default {
       const meta = this.generateMeta(result);
       this.$emit(result, meta);
     },
+    sortItemsByDate(items, sortField) {
+      return items.sort((a, b) => (Date.parse(a[sortField]) > Date.parse(b[sortField])));
+    },
   },
 };

package/sources/custom-webhook-events/custom-webhook-events.mjs

@@ -4,9 +4,9 @@ import events from "../common/events.mjs";
 export default {
   ...common,
   key: "trello-custom-webhook-events",
-  name: "Custom Webhook Events (Instant)",
+  name: "Custom Webhook Events (Instant)", /* eslint-disable-line pipedream/source-name */
   description: "Emit new events for activity matching a board, event types, lists and/or cards.",
-  version: "0.1.0",
+  version: "0.1.1",
   type: "source",
   props: {
     ...common.props,
@@ -42,59 +42,29 @@ export default {
       ],
     },
   },
-  hooks: {
-    ...common.hooks,
-    async deploy() {
-      const {
-        sampleEvents, sortField,
-      } = await this.getSampleEvents();
-      sampleEvents.sort((a, b) => (Date.parse(a[sortField]) > Date.parse(b[sortField]))
-        ? 1
-        : -1);
-      for (const action of sampleEvents.slice(-25)) {
-        this.emitEvent({
-          action,
-        });
-      }
-    },
-  },
   methods: {
     ...common.methods,
-    getCardList({
-      cardId, ...args
-    } = {}) {
-      return this.app._makeRequest({
-        path: `/cards/${cardId}/list`,
-        ...args,
-      });
-    },
-    async getSampleEvents() {
-      const eventTypes = this.eventTypes && this.eventTypes.length > 0
+    getSampleEvents() {
+      const eventTypes = this.eventTypes?.length
         ? this.eventTypes.join(",")
         : null;
-      const actions = await this.app.getBoardActivity({
+      return this.app.getBoardActivity({
         boardId: this.board,
         params: {
           filter: eventTypes,
         },
       });
-      return {
-        sampleEvents: actions,
-        sortField: "date",
-      };
     },
-    isCorrectEventType(event) {
-      const eventType = event.body?.action?.type;
+    getSortField() {
+      return "date";
+    },
+    isCorrectEventType({ type }) {
       return (
-        (eventType) &&
-        (!this.eventTypes ||
-        this.eventTypes.length === 0 ||
-        this.eventTypes.includes(eventType))
+        (type) &&
+        (!this.eventTypes?.length ||
+        this.eventTypes.includes(type))
       );
     },
-    async getResult(event) {
-      return event.body;
-    },
     async isRelevant({ result: body }) {
       let listId = body.action?.data?.list?.id;
       const cardId = body.action?.data?.card?.id;
@@ -106,22 +76,21 @@ export default {
         listId = res.id;
       }
       return (
-        (!this.lists ||
-          this.lists.length === 0 ||
+        (!this.lists?.length ||
           !listId ||
           this.lists.includes(listId)) &&
-        (!this.cards || this.cards.length === 0 || !cardId || this.cards.includes(cardId))
+        (!this.cards?.length || !cardId || this.cards.includes(cardId))
       );
     },
-    generateMeta({ action }) {
+    generateMeta(action) {
       const {
         id,
-        type: summary,
+        type,
         date,
       } = action;
       return {
         id,
-        summary,
+        summary: `New ${type} event`,
         ts: Date.parse(date),
       };
     },

package/sources/new-activity/new-activity.mjs

@@ -1,11 +1,12 @@
 import common from "../common/common-webhook.mjs";
+import actions from "../common/actions.mjs";
 
 export default {
   ...common,
   key: "trello-new-activity",
-  name: "New Activity (Instant)",
+  name: "New Board Activity (Instant)",
   description: "Emit new event for new activity on a board.",
-  version: "0.1.0",
+  version: "0.1.1",
   type: "source",
   props: {
     ...common.props,
@@ -15,50 +16,40 @@ export default {
         "board",
       ],
     },
-  },
-  hooks: {
-    ...common.hooks,
-    async deploy() {
-      const {
-        sampleEvents, sortField,
-      } = await this.getSampleEvents();
-      sampleEvents.sort((a, b) => (Date.parse(a[sortField]) > Date.parse(b[sortField]))
-        ? 1
-        : -1);
-      for (const action of sampleEvents.slice(-25)) {
-        this.emitEvent({
-          action,
-        });
-      }
+    activityTypes: {
+      type: "string[]",
+      label: "Activity Types",
+      description: "Filter incoming events by the activity type",
+      options: actions,
+      optional: true,
     },
   },
   methods: {
     ...common.methods,
-    async getSampleEvents() {
-      const actions = await this.app.getBoardActivity({
+    getSampleEvents() {
+      return this.app.getBoardActivity({
         boardId: this.board,
       });
-      return {
-        sampleEvents: actions,
-        sortField: "date",
-      };
     },
-    async getResult(event) {
-      return event.body;
+    getSortField() {
+      return "date";
     },
-    isRelevant({ event }) {
-      const boardId = event.body?.action?.data?.board?.id;
-      return !this.board || this.board === boardId;
+    isRelevant({ action }) {
+      const {
+        data, type,
+      } = action;
+      return ((!this.board || this.board === data?.board?.id)
+        && (!this.activityTypes?.length || this.activityTypes.includes(type)));
     },
-    generateMeta({ action }) {
+    generateMeta(action) {
       const {
         id,
-        type: summary,
+        type,
         date,
       } = action;
       return {
         id,
-        summary,
+        summary: `New ${type} activity`,
         ts: Date.parse(date),
       };
     },