@pioneer-platform/pioneer-sdk 8.15.2 → 8.15.3

package/dist/index.cjs

@@ -1982,9 +1982,16 @@ async function createUnsignedRippleTx(caip, to, amount, memo, pubkeys, pioneer,
     accountInfo = accountInfo.data;
     const sequence = accountInfo.Sequence.toString();
     const ledgerIndexCurrent = parseInt(accountInfo.ledger_index_current);
-    let desttag = memo;
-    if (!desttag || /^\s*$/.test(desttag) || isNaN(desttag)) {
-      desttag = "0";
+    let desttag = undefined;
+    if (memo && memo.trim() !== "") {
+      if (!/^\d+$/.test(memo.trim())) {
+        throw new Error(`XRP destination tag must be numeric. Got: "${memo}"`);
+      }
+      const tagNum = parseInt(memo.trim(), 10);
+      if (isNaN(tagNum) || tagNum < 0 || tagNum > 4294967295) {
+        throw new Error(`XRP destination tag must be 0-4294967295. Got: ${memo}`);
+      }
+      desttag = tagNum.toString();
     }
     if (isMax) {
       amount = Number(accountInfo.Balance) - 1e6 - 1;
@@ -1993,6 +2000,22 @@ async function createUnsignedRippleTx(caip, to, amount, memo, pubkeys, pioneer,
       amount = amount * 1e6;
       amount = amount.toString();
     }
+    const msg = {
+      type: "ripple-sdk/MsgSend",
+      value: {
+        amount: [
+          {
+            amount,
+            denom: "drop"
+          }
+        ],
+        from_address: fromAddress,
+        to_address: to
+      }
+    };
+    if (desttag !== undefined) {
+      msg.DestinationTag = desttag;
+    }
     let tx = {
       type: "auth/StdTx",
       value: {
@@ -2006,36 +2029,24 @@ async function createUnsignedRippleTx(caip, to, amount, memo, pubkeys, pioneer,
           gas: "28000"
         },
         memo: memo || "",
-        msg: [
-          {
-            type: "ripple-sdk/MsgSend",
-            DestinationTag: desttag,
-            value: {
-              amount: [
-                {
-                  amount,
-                  denom: "drop"
-                }
-              ],
-              from_address: fromAddress,
-              to_address: to
-            }
-          }
-        ],
+        msg: [msg],
         signatures: null
       }
     };
+    const payment = {
+      amount,
+      destination: to
+    };
+    if (desttag !== undefined) {
+      payment.destinationTag = desttag;
+    }
     let unsignedTx = {
       addressNList: [2147483692, 2147483792, 2147483648, 0, 0],
       tx,
       flags: undefined,
       lastLedgerSequence: (ledgerIndexCurrent + 1000).toString(),
       sequence: sequence || "0",
-      payment: {
-        amount,
-        destination: to,
-        destinationTag: desttag
-      }
+      payment
     };
     return unsignedTx;
   } catch (error) {

package/dist/index.es.js

@@ -2166,9 +2166,16 @@ async function createUnsignedRippleTx(caip, to, amount, memo, pubkeys, pioneer,
     accountInfo = accountInfo.data;
     const sequence = accountInfo.Sequence.toString();
     const ledgerIndexCurrent = parseInt(accountInfo.ledger_index_current);
-    let desttag = memo;
-    if (!desttag || /^\s*$/.test(desttag) || isNaN(desttag)) {
-      desttag = "0";
+    let desttag = undefined;
+    if (memo && memo.trim() !== "") {
+      if (!/^\d+$/.test(memo.trim())) {
+        throw new Error(`XRP destination tag must be numeric. Got: "${memo}"`);
+      }
+      const tagNum = parseInt(memo.trim(), 10);
+      if (isNaN(tagNum) || tagNum < 0 || tagNum > 4294967295) {
+        throw new Error(`XRP destination tag must be 0-4294967295. Got: ${memo}`);
+      }
+      desttag = tagNum.toString();
     }
     if (isMax) {
       amount = Number(accountInfo.Balance) - 1e6 - 1;
@@ -2177,6 +2184,22 @@ async function createUnsignedRippleTx(caip, to, amount, memo, pubkeys, pioneer,
       amount = amount * 1e6;
       amount = amount.toString();
     }
+    const msg = {
+      type: "ripple-sdk/MsgSend",
+      value: {
+        amount: [
+          {
+            amount,
+            denom: "drop"
+          }
+        ],
+        from_address: fromAddress,
+        to_address: to
+      }
+    };
+    if (desttag !== undefined) {
+      msg.DestinationTag = desttag;
+    }
     let tx = {
       type: "auth/StdTx",
       value: {
@@ -2190,36 +2213,24 @@ async function createUnsignedRippleTx(caip, to, amount, memo, pubkeys, pioneer,
           gas: "28000"
         },
         memo: memo || "",
-        msg: [
-          {
-            type: "ripple-sdk/MsgSend",
-            DestinationTag: desttag,
-            value: {
-              amount: [
-                {
-                  amount,
-                  denom: "drop"
-                }
-              ],
-              from_address: fromAddress,
-              to_address: to
-            }
-          }
-        ],
+        msg: [msg],
         signatures: null
       }
     };
+    const payment = {
+      amount,
+      destination: to
+    };
+    if (desttag !== undefined) {
+      payment.destinationTag = desttag;
+    }
     let unsignedTx = {
       addressNList: [2147483692, 2147483792, 2147483648, 0, 0],
       tx,
       flags: undefined,
       lastLedgerSequence: (ledgerIndexCurrent + 1000).toString(),
       sequence: sequence || "0",
-      payment: {
-        amount,
-        destination: to,
-        destinationTag: desttag
-      }
+      payment
     };
     return unsignedTx;
   } catch (error) {

package/dist/index.js

@@ -2166,9 +2166,16 @@ async function createUnsignedRippleTx(caip, to, amount, memo, pubkeys, pioneer,
     accountInfo = accountInfo.data;
     const sequence = accountInfo.Sequence.toString();
     const ledgerIndexCurrent = parseInt(accountInfo.ledger_index_current);
-    let desttag = memo;
-    if (!desttag || /^\s*$/.test(desttag) || isNaN(desttag)) {
-      desttag = "0";
+    let desttag = undefined;
+    if (memo && memo.trim() !== "") {
+      if (!/^\d+$/.test(memo.trim())) {
+        throw new Error(`XRP destination tag must be numeric. Got: "${memo}"`);
+      }
+      const tagNum = parseInt(memo.trim(), 10);
+      if (isNaN(tagNum) || tagNum < 0 || tagNum > 4294967295) {
+        throw new Error(`XRP destination tag must be 0-4294967295. Got: ${memo}`);
+      }
+      desttag = tagNum.toString();
     }
     if (isMax) {
       amount = Number(accountInfo.Balance) - 1e6 - 1;
@@ -2177,6 +2184,22 @@ async function createUnsignedRippleTx(caip, to, amount, memo, pubkeys, pioneer,
       amount = amount * 1e6;
       amount = amount.toString();
     }
+    const msg = {
+      type: "ripple-sdk/MsgSend",
+      value: {
+        amount: [
+          {
+            amount,
+            denom: "drop"
+          }
+        ],
+        from_address: fromAddress,
+        to_address: to
+      }
+    };
+    if (desttag !== undefined) {
+      msg.DestinationTag = desttag;
+    }
     let tx = {
       type: "auth/StdTx",
       value: {
@@ -2190,36 +2213,24 @@ async function createUnsignedRippleTx(caip, to, amount, memo, pubkeys, pioneer,
           gas: "28000"
         },
         memo: memo || "",
-        msg: [
-          {
-            type: "ripple-sdk/MsgSend",
-            DestinationTag: desttag,
-            value: {
-              amount: [
-                {
-                  amount,
-                  denom: "drop"
-                }
-              ],
-              from_address: fromAddress,
-              to_address: to
-            }
-          }
-        ],
+        msg: [msg],
         signatures: null
       }
     };
+    const payment = {
+      amount,
+      destination: to
+    };
+    if (desttag !== undefined) {
+      payment.destinationTag = desttag;
+    }
     let unsignedTx = {
       addressNList: [2147483692, 2147483792, 2147483648, 0, 0],
       tx,
       flags: undefined,
       lastLedgerSequence: (ledgerIndexCurrent + 1000).toString(),
       sequence: sequence || "0",
-      payment: {
-        amount,
-        destination: to,
-        destinationTag: desttag
-      }
+      payment
     };
     return unsignedTx;
   } catch (error) {

package/package.json

@@ -1,7 +1,7 @@
 {
   "author": "highlander",
   "name": "@pioneer-platform/pioneer-sdk",
-  "version": "8.15.2",
+  "version": "8.15.3",
   "dependencies": {
     "@keepkey/keepkey-sdk": "^0.2.62",
     "@pioneer-platform/loggerdog": "^8.11.0",
@@ -49,8 +49,6 @@
   },
   "react-native": "./src/index.ts",
   "repository": "https://github.com/thorswap/SwapKit.git",
-  "type": "module",
-  "types": "./dist/index.d.ts",
   "scripts": {
     "build": "bash scripts/build.sh",
     "build:watch": "nodemon --watch src --exec 'bun run build'",
@@ -58,5 +56,7 @@
     "lint": "eslint ./ --ext .ts,.tsx --fix; tsc --noEmit",
     "test": "echo 'vitest --run'",
     "test:coverage": "echo 'vitest run --coverage'"
-  }
-}
+  },
+  "type": "module",
+  "types": "./dist/index.d.ts"
+}

package/src/txbuilder/createUnsignedRippleTx.ts

@@ -50,11 +50,22 @@ export async function createUnsignedRippleTx(
 
     const sequence = accountInfo.Sequence.toString();
     const ledgerIndexCurrent = parseInt(accountInfo.ledger_index_current);
-    let desttag = memo;
-    // Check if desttag is null, undefined, a space, or any non-numeric value
-    //@ts-ignore
-    if (!desttag || /^\s*$/.test(desttag) || isNaN(desttag)) {
-      desttag = '0';
+    
+    // XRP Destination Tag Validation (CRITICAL: uint32 range 0-4294967295)
+    let desttag: string | undefined = undefined;
+    if (memo && memo.trim() !== '') {
+      // Must be numeric
+      if (!/^\d+$/.test(memo.trim())) {
+        throw new Error(`XRP destination tag must be numeric. Got: "${memo}"`);
+      }
+      
+      // Must be in valid range (uint32)
+      const tagNum = parseInt(memo.trim(), 10);
+      if (isNaN(tagNum) || tagNum < 0 || tagNum > 4294967295) {
+        throw new Error(`XRP destination tag must be 0-4294967295. Got: ${memo}`);
+      }
+      
+      desttag = tagNum.toString();
     }
 
     //console.log(tag, 'amount:', amount);
@@ -68,6 +79,24 @@ export async function createUnsignedRippleTx(
       amount = amount.toString();
     }
 
+    // Build message - only include DestinationTag if provided
+    const msg: any = {
+      type: 'ripple-sdk/MsgSend',
+      value: {
+        amount: [
+          {
+            amount: amount,
+            denom: 'drop',
+          },
+        ],
+        from_address: fromAddress,
+        to_address: to,
+      },
+    };
+    if (desttag !== undefined) {
+      msg.DestinationTag = desttag;
+    }
+
     let tx = {
       type: 'auth/StdTx',
       value: {
@@ -81,26 +110,20 @@ export async function createUnsignedRippleTx(
           gas: '28000',
         },
         memo: memo || '',
-        msg: [
-          {
-            type: 'ripple-sdk/MsgSend',
-            DestinationTag: desttag,
-            value: {
-              amount: [
-                {
-                  amount: amount,
-                  denom: 'drop',
-                },
-              ],
-              from_address: fromAddress,
-              to_address: to,
-            },
-          },
-        ],
+        msg: [msg],
         signatures: null,
       },
     };
 
+    // Build payment object - only include destinationTag if provided
+    const payment: any = {
+      amount,
+      destination: to,
+    };
+    if (desttag !== undefined) {
+      payment.destinationTag = desttag;
+    }
+
     //Unsigned TX
     let unsignedTx = {
       addressNList: [2147483692, 2147483792, 2147483648, 0, 0],
@@ -108,11 +131,7 @@ export async function createUnsignedRippleTx(
       flags: undefined,
       lastLedgerSequence: (ledgerIndexCurrent + 1000).toString(), // Add 1000 ledgers (~16 minutes) for transaction validity
       sequence: sequence || '0',
-      payment: {
-        amount,
-        destination: to,
-        destinationTag: desttag,
-      },
+      payment,
     };
 
     return unsignedTx;