@pioneer-platform/eth-network 8.14.2 → 8.14.4

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @pioneer-platform/eth-network
 
+## 8.14.4
+
+### Patch Changes
+
+- chore: 🔒 CRITICAL FIX: XRP destination tag validation
+- Updated dependencies
+  - @pioneer-platform/blockbook@8.12.2
+
+## 8.14.3
+
+### Patch Changes
+
+- fix: Add node racing to all eth-network \*ByNetwork functions
+
 ## 8.14.2
 
 ### Patch Changes

package/lib/index.d.ts

@@ -57,8 +57,14 @@ export declare const getBalances: (addresses: string[]) => Promise<string[]>;
 export declare const getBalanceToken: (address: string, tokenAddress: string) => Promise<string>;
 /**
  * Get ERC20 allowance
+ * @deprecated Use getAllowanceByNetwork instead
  */
 export declare const getAllowance: (tokenAddress: string, spender: string, sender: string) => Promise<any>;
+/**
+ * Get ERC20 allowance by network with node racing
+ * Uses the node racing system for reliability and performance
+ */
+export declare const getAllowanceByNetwork: (networkId: string, tokenAddress: string, ownerAddress: string, spenderAddress: string) => Promise<string>;
 /**
  * Get symbol from contract address
  */
@@ -117,8 +123,20 @@ export declare const estimateGasByNetwork: (networkId: string, transaction: any)
  */
 export declare const broadcastByNetwork: (networkId: string, signedTx: string) => Promise<{
     success: boolean;
-    txid: string;
-    transactionHash: string;
+    error: string;
+    txid?: undefined;
+    transactionHash?: undefined;
+    from?: undefined;
+    to?: undefined;
+    nonce?: undefined;
+    gasLimit?: undefined;
+    gasPrice?: undefined;
+    chainId?: undefined;
+    details?: undefined;
+} | {
+    success: boolean;
+    txid: any;
+    transactionHash: any;
     from: string;
     to: string;
     nonce: number;
@@ -126,9 +144,11 @@ export declare const broadcastByNetwork: (networkId: string, signedTx: string) =
     gasPrice: string;
     chainId: number;
     error?: undefined;
+    details?: undefined;
 } | {
     success: boolean;
     error: any;
+    details: string;
     txid?: undefined;
     transactionHash?: undefined;
     from?: undefined;

package/lib/index.js

@@ -43,7 +43,7 @@ var __importStar = (this && this.__importStar) || (function () {
     };
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getFees = exports.getBalanceAddress = exports.getTransactionsByNetwork = exports.getTransactionByNetwork = exports.broadcastByNetwork = exports.estimateGasByNetwork = exports.getTokenMetadataByNetwork = exports.getTokenMetadata = exports.getTokenDecimalsByNetwork = exports.getBalanceTokensByNetwork = exports.getBalanceTokenByNetwork = exports.getBalanceAddressByNetwork = exports.getMemoEncoded = exports.getTransferData = exports.broadcast = exports.getTransaction = exports.getSymbolFromContract = exports.getAllowance = exports.getBalanceToken = exports.getBalances = exports.getBalance = exports.estimateFee = exports.getGasPriceByNetwork = exports.getGasPrice = exports.getNonceByNetwork = exports.getNonce = exports.addNodes = exports.addNode = exports.getNodes = exports.init = void 0;
+exports.getFees = exports.getBalanceAddress = exports.getTransactionsByNetwork = exports.getTransactionByNetwork = exports.broadcastByNetwork = exports.estimateGasByNetwork = exports.getTokenMetadataByNetwork = exports.getTokenMetadata = exports.getTokenDecimalsByNetwork = exports.getBalanceTokensByNetwork = exports.getBalanceTokenByNetwork = exports.getBalanceAddressByNetwork = exports.getMemoEncoded = exports.getTransferData = exports.broadcast = exports.getTransaction = exports.getSymbolFromContract = exports.getAllowanceByNetwork = exports.getAllowance = exports.getBalanceToken = exports.getBalances = exports.getBalance = exports.estimateFee = exports.getGasPriceByNetwork = exports.getGasPrice = exports.getNonceByNetwork = exports.getNonce = exports.addNodes = exports.addNode = exports.getNodes = exports.init = void 0;
 const TAG = " | eth-network | ";
 const ethers = __importStar(require("ethers"));
 const BigNumber = require('bignumber.js');
@@ -553,6 +553,7 @@ const getBalanceToken = async function (address, tokenAddress) {
 exports.getBalanceToken = getBalanceToken;
 /**
  * Get ERC20 allowance
+ * @deprecated Use getAllowanceByNetwork instead
  */
 const getAllowance = async function (tokenAddress, spender, sender) {
     let tag = TAG + ' | getAllowance | ';
@@ -567,6 +568,70 @@ const getAllowance = async function (tokenAddress, spender, sender) {
     }
 };
 exports.getAllowance = getAllowance;
+/**
+ * Get ERC20 allowance by network with node racing
+ * Uses the node racing system for reliability and performance
+ */
+const getAllowanceByNetwork = async function (networkId, tokenAddress, ownerAddress, spenderAddress) {
+    let tag = TAG + ' | getAllowanceByNetwork | ';
+    // Get ALL nodes for this network, excluding dead ones
+    let allNodes = NODES.filter((n) => n.networkId === networkId);
+    if (!allNodes || allNodes.length === 0) {
+        throw Error(`No nodes found for networkId: ${networkId}`);
+    }
+    // Filter out dead nodes and sort by tier priority
+    let nodes = allNodes
+        .filter((n) => !isNodeDead(n.service))
+        .sort((a, b) => {
+        const tierA = a.tier || 'public';
+        const tierB = b.tier || 'public';
+        return TIER_PRIORITY[tierA] - TIER_PRIORITY[tierB];
+    });
+    if (nodes.length === 0) {
+        log.error(tag, `All ${allNodes.length} nodes are marked dead for ${networkId} token ${tokenAddress} - failing fast`);
+        throw Error(`No healthy nodes available for ${networkId} token ${tokenAddress} (all ${allNodes.length} nodes are dead)`);
+    }
+    const topTier = nodes[0].tier || 'public';
+    log.info(tag, `Racing top ${Math.min(RACE_BATCH_SIZE, nodes.length)} nodes (${nodes.length} alive of ${allNodes.length} total, starting with ${topTier})`);
+    // Extract chain ID from networkId (e.g., "eip155:1" -> 1)
+    let chainId;
+    if (networkId.includes(':')) {
+        chainId = parseInt(networkId.split(':')[1]);
+    }
+    // Race nodes in batches
+    let batchStartIndex = 0;
+    while (batchStartIndex < nodes.length) {
+        const batch = nodes.slice(batchStartIndex, batchStartIndex + RACE_BATCH_SIZE);
+        // Create racing promises for this batch
+        const racePromises = batch.map(async (node, index) => {
+            try {
+                const provider = new ethers.providers.StaticJsonRpcProvider(node.service, chainId ? { chainId, name: node.networkId } : undefined);
+                const contract = new ethers.Contract(tokenAddress, ERC20ABI, provider);
+                // Wrap contract call with timeout
+                const allowance = await withTimeout(contract.allowance(ownerAddress, spenderAddress), RPC_TIMEOUT_MS, `Node ${node.service} allowance timeout`);
+                log.info(tag, `Node ${node.service} (tier: ${node.tier || 'public'}) returned allowance: ${allowance.toString()}`);
+                return allowance.toString();
+            }
+            catch (error) {
+                log.error(tag, `Node ${node.service} failed:`, error.message);
+                throw error;
+            }
+        });
+        try {
+            // Race this batch of nodes
+            const result = await Promise.race(racePromises);
+            log.info(tag, `Successfully got allowance from racing batch starting at index ${batchStartIndex}`);
+            return result;
+        }
+        catch (error) {
+            log.warn(tag, `Batch starting at ${batchStartIndex} failed, trying next batch if available`);
+        }
+        batchStartIndex += RACE_BATCH_SIZE;
+    }
+    // If we get here, all batches failed
+    throw Error(`All ${nodes.length} healthy nodes failed for ${networkId} token ${tokenAddress} allowance check`);
+};
+exports.getAllowanceByNetwork = getAllowanceByNetwork;
 /**
  * Get symbol from contract address
  */
@@ -1081,41 +1146,133 @@ const broadcastByNetwork = async function (networkId, signedTx) {
     if (networkId.includes(':')) {
         chainId = parseInt(networkId.split(':')[1]);
     }
+    // VALIDATE TRANSACTION BEFORE BROADCASTING
+    // This catches issues early before attempting RPC calls
+    try {
+        log.info(tag, 'Validating signed transaction before broadcast...');
+        const parsedTx = ethers.utils.parseTransaction(signedTx);
+        log.info(tag, 'Parsed transaction fields:', {
+            to: parsedTx.to,
+            from: parsedTx.from,
+            nonce: parsedTx.nonce,
+            gasLimit: parsedTx.gasLimit?.toString(),
+            gasPrice: parsedTx.gasPrice?.toString(),
+            chainId: parsedTx.chainId,
+            value: parsedTx.value?.toString(),
+            data: parsedTx.data?.substring(0, 20) + '...'
+        });
+        // CRITICAL VALIDATION: Check for gasLimit = 0
+        if (!parsedTx.gasLimit || parsedTx.gasLimit.isZero()) {
+            const errorMsg = `Transaction validation failed: gasLimit is 0 or missing. This transaction will be rejected by the network. gasLimit=${parsedTx.gasLimit?.toString()}`;
+            log.error(tag, errorMsg);
+            return {
+                success: false,
+                error: errorMsg
+            };
+        }
+        // CRITICAL VALIDATION: Check for gasPrice = 0 (for non-EIP1559 txs)
+        if (!parsedTx.gasPrice || parsedTx.gasPrice.isZero()) {
+            const errorMsg = `Transaction validation failed: gasPrice is 0 or missing. This transaction will be rejected by the network. gasPrice=${parsedTx.gasPrice?.toString()}`;
+            log.error(tag, errorMsg);
+            return {
+                success: false,
+                error: errorMsg
+            };
+        }
+        // Validate chainId matches network
+        if (chainId && parsedTx.chainId !== chainId) {
+            const errorMsg = `Transaction validation failed: chainId mismatch. Expected ${chainId}, got ${parsedTx.chainId}`;
+            log.error(tag, errorMsg);
+            return {
+                success: false,
+                error: errorMsg
+            };
+        }
+        log.info(tag, '✅ Transaction validation passed - proceeding with broadcast');
+    }
+    catch (validationError) {
+        log.error(tag, 'Transaction parsing/validation failed:', validationError);
+        return {
+            success: false,
+            error: `Invalid transaction format: ${validationError.message}`
+        };
+    }
     // Try each node until one succeeds
     let lastError = null;
+    let allErrors = [];
     for (let i = 0; i < nodes.length; i++) {
         const node = nodes[i];
         try {
             const provider = new ethers.providers.StaticJsonRpcProvider(node.service, chainId ? { chainId, name: node.networkId } : undefined);
-            const result = await withTimeout(provider.sendTransaction(signedTx), RPC_TIMEOUT_MS, `Broadcast timeout after ${RPC_TIMEOUT_MS}ms for ${node.service.substring(0, 50)}`);
+            // Use raw JSON-RPC call for immediate validation errors
+            // eth_sendRawTransaction will validate the tx BEFORE returning
+            log.info(tag, `Broadcasting via eth_sendRawTransaction to ${node.service.substring(0, 50)}...`);
+            const txHash = await withTimeout(provider.send('eth_sendRawTransaction', [signedTx]), RPC_TIMEOUT_MS, `Broadcast timeout after ${RPC_TIMEOUT_MS}ms for ${node.service.substring(0, 50)}`);
+            // If we got here, the transaction was accepted by the network
+            log.info(tag, `✅ Transaction accepted by network: ${txHash}`);
             // Success! Log which node worked (only if not the first one)
             if (i > 0) {
                 log.info(tag, `Successfully broadcasted from node ${i + 1}/${nodes.length}: ${node.service.substring(0, 50)}`);
             }
+            // Parse the original transaction to get details for response
+            const parsedTx = ethers.utils.parseTransaction(signedTx);
             // Return in expected format for pioneer-server
             return {
                 success: true,
-                txid: result.hash,
-                transactionHash: result.hash,
-                from: result.from,
-                to: result.to,
-                nonce: result.nonce,
-                gasLimit: result.gasLimit?.toString(),
-                gasPrice: result.gasPrice?.toString(),
-                chainId: result.chainId
+                txid: txHash,
+                transactionHash: txHash,
+                from: parsedTx.from,
+                to: parsedTx.to,
+                nonce: parsedTx.nonce,
+                gasLimit: parsedTx.gasLimit?.toString(),
+                gasPrice: parsedTx.gasPrice?.toString(),
+                chainId: parsedTx.chainId
             };
         }
         catch (e) {
             lastError = e;
-            log.warn(tag, `Node ${i + 1}/${nodes.length} failed (${node.service.substring(0, 50)}): ${e.message}`);
+            // Extract detailed error message from RPC response
+            let errorMessage = e.message || 'Unknown error';
+            // Check for JSON-RPC error format
+            if (e.error) {
+                if (typeof e.error === 'string') {
+                    errorMessage = e.error;
+                }
+                else if (e.error.message) {
+                    errorMessage = e.error.message;
+                }
+            }
+            else if (e.body) {
+                try {
+                    const body = JSON.parse(e.body);
+                    if (body.error) {
+                        if (typeof body.error === 'string') {
+                            errorMessage = body.error;
+                        }
+                        else if (body.error.message) {
+                            errorMessage = body.error.message;
+                        }
+                    }
+                }
+                catch (parseErr) {
+                    // Ignore parsing errors
+                }
+            }
+            // Log the detailed error
+            log.error(tag, `❌ Broadcast rejected by node ${i + 1}: ${errorMessage}`);
+            allErrors.push(`Node ${i + 1}: ${errorMessage}`);
+            log.warn(tag, `Node ${i + 1}/${nodes.length} failed (${node.service.substring(0, 50)}): ${errorMessage}`);
             // Continue to next node
         }
     }
-    // All nodes failed
+    // All nodes failed - provide comprehensive error details
+    const detailedError = allErrors.join(' | ');
     log.error(tag, `All ${nodes.length} nodes failed for ${networkId}`);
+    log.error(tag, 'Detailed errors:', detailedError);
     return {
         success: false,
-        error: lastError?.message || `Failed to broadcast from any node for ${networkId}`
+        error: lastError?.message || `Failed to broadcast from any node for ${networkId}`,
+        details: detailedError
     };
 };
 exports.broadcastByNetwork = broadcastByNetwork;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pioneer-platform/eth-network",
-  "version": "8.14.2",
+  "version": "8.14.4",
   "main": "./lib/index.js",
   "types": "./lib/index.d.ts",
   "scripts": {
@@ -18,7 +18,7 @@
     "@ethersproject/abstract-provider": "^5.8.0",
     "@ethersproject/bignumber": "^5.8.0",
     "@ethersproject/providers": "^5.8.0",
-    "@pioneer-platform/blockbook": "^8.12.0",
+    "@pioneer-platform/blockbook": "^8.12.2",
     "@pioneer-platform/loggerdog": "^8.11.0",
     "@pioneer-platform/nodes": "^8.11.10",
     "@pioneer-platform/pioneer-caip": "^9.10.0",