@pingux/astro 2.184.0-alpha.0 → 2.185.0-alpha.0

package/lib/cjs/components/Avatar/Avatar.js

@@ -44,7 +44,7 @@ var Avatar = /*#__PURE__*/(0, _react.forwardRef)(function (props, ref) {
     isSquare = props.isSquare,
     isLogo = props.isLogo,
     others = (0, _objectWithoutProperties2["default"])(props, _excluded);
-  var safeColorId = colorId || '_INTERNAL_DEFAULT_ID_';
+  var safeColorId = colorId || (defaultText && defaultText !== 'AA' ? defaultText : '_INTERNAL_DEFAULT_ID_');
   if (process.env.NODE_ENV !== 'production') {
     if (!src && !color && !colorId) {
       console.warn("[Astro] Avatar: No 'src', 'color', or 'colorId' provided. " + 'The component is falling back to a default generated color.');

package/lib/cjs/components/Avatar/Avatar.test.js

@@ -25,7 +25,6 @@ var getComponent = function getComponent() {
   var props = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};
   return (0, _testWrapper.render)((0, _react2.jsx)(_["default"], (0, _extends2["default"])({}, defaultProps, props)));
 };
-// Needs to be added to each components test file
 (0, _universalComponentTest.universalComponentTests)({
   renderComponent: function renderComponent(props) {
     return (0, _react2.jsx)(_["default"], (0, _extends2["default"])({}, defaultProps, props));
@@ -45,7 +44,7 @@ test('an avatar is rendered with custom alt', function () {
   var img = _testWrapper.screen.getByRole('img');
   expect(img).toHaveAttribute('alt', 'Custom Alt');
 });
-test('an avatar is rendered with custom alt', function () {
+test('an avatar is rendered with initials', function () {
   var warnSpy = jest.spyOn(console, 'warn').mockImplementation();
   getComponent({
     src: undefined,
@@ -70,9 +69,6 @@ describe('getColorFromUUID', function () {
   test('distributes colors differently for different UUIDs', function () {
     var colorA = (0, _getColorFromUuid["default"])('id-1', _constants.avatarColors);
     var colorB = (0, _getColorFromUuid["default"])('id-2', _constants.avatarColors);
-
-    // While collisions are mathematically possible, for 2 items in a 10-item list,
-    // these specific IDs yield different results in FNV-1a.
     expect(colorA).not.toBe(colorB);
   });
   test('throws error if color array is empty', function () {
@@ -86,8 +82,6 @@ describe('getColorFromUUID', function () {
       colorId: 'some-id'
     });
     var avatar = _testWrapper.screen.getByTestId(datatestId);
-
-    // Checking for 'is-blue'
     expect(avatar).toHaveClass('is-blue');
   });
   test('applies a hashed color class from colorId', function () {
@@ -96,9 +90,6 @@ describe('getColorFromUUID', function () {
       colorId: uuid
     });
     var avatar = _testWrapper.screen.getByTestId(datatestId);
-
-    // We check that it has *a* class starting with 'is-'
-    // and specifically isn't the default 'is-green'
     var classList = (0, _from["default"])(avatar.classList);
     var colorClass = (0, _find["default"])(classList).call(classList, function (cls) {
       return (0, _startsWith["default"])(cls).call(cls, 'is-');
@@ -171,27 +162,40 @@ describe('getColorFromUUID Distribution', function () {
   test('distributes 10,000 UUIDs evenly across 10 colors', function () {
     var iterations = 10000;
     var distribution = {};
-
-    // Initialize counts
     (0, _forEach["default"])(_constants.avatarColors).call(_constants.avatarColors, function (c) {
       distribution[c] = 0;
     });
-
-    // Generate and hash
     for (var i = 0; i < iterations; i += 1) {
-      // Use the imported randomUUID function directly
       var uuid = (0, _nodeCrypto.randomUUID)();
       var selectedColor = (0, _getColorFromUuid["default"])(uuid, _constants.avatarColors);
       distribution[selectedColor] += 1;
     }
     var expectedMean = iterations / _constants.avatarColors.length;
-    // 15% variance is a safe threshold for 10k iterations
     var allowedVariance = 0.15;
     (0, _forEach["default"])(_constants.avatarColors).call(_constants.avatarColors, function (color) {
       var count = distribution[color];
-      // Assert that each color is roughly 10% of the total
       expect(count).toBeGreaterThan(expectedMean * (1 - allowedVariance));
       expect(count).toBeLessThan(expectedMean * (1 + allowedVariance));
     });
   });
+});
+describe('Color Selection Logic', function () {
+  var getResolvedId = function getResolvedId(colorId, defaultText) {
+    return colorId || (defaultText && defaultText !== 'AA' ? defaultText : '_INTERNAL_DEFAULT_ID_');
+  };
+  test('should use colorId if it is provided', function () {
+    expect(getResolvedId('custom-id', 'BB')).toBe('custom-id');
+  });
+  test('should use defaultText if colorId is missing and text is not "AA"', function () {
+    expect(getResolvedId(null, 'BB')).toBe('BB');
+  });
+  test('should use hardcoded string if colorId is missing and text is "AA"', function () {
+    expect(getResolvedId(undefined, 'AA')).toBe('_INTERNAL_DEFAULT_ID_');
+  });
+  test('should use hardcoded string if both colorId and defaultText are null', function () {
+    expect(getResolvedId(null, null)).toBe('_INTERNAL_DEFAULT_ID_');
+  });
+  test('should use hardcoded string if colorId is missing and defaultText is empty string', function () {
+    expect(getResolvedId(null, '')).toBe('_INTERNAL_DEFAULT_ID_');
+  });
 });

package/lib/cjs/components/PanelHeader/PanelHeader.js

@@ -61,7 +61,6 @@ var PanelHeader = /*#__PURE__*/(0, _react.forwardRef)(function (_ref, ref) {
     }
   }));
   var renderAvatar = (0, _react2.jsx)(_index.Avatar, (0, _extends2["default"])({
-    color: image !== null && image !== void 0 && image.src ? false : 'green',
     src: image === null || image === void 0 ? void 0 : image.src,
     isSquare: !!(image !== null && image !== void 0 && image.src),
     size: "avatar.lg",

package/lib/components/Avatar/Avatar.js

@@ -34,7 +34,7 @@ var Avatar = /*#__PURE__*/forwardRef(function (props, ref) {
     isSquare = props.isSquare,
     isLogo = props.isLogo,
     others = _objectWithoutProperties(props, _excluded);
-  var safeColorId = colorId || '_INTERNAL_DEFAULT_ID_';
+  var safeColorId = colorId || (defaultText && defaultText !== 'AA' ? defaultText : '_INTERNAL_DEFAULT_ID_');
   if (process.env.NODE_ENV !== 'production') {
     if (!src && !color && !colorId) {
       console.warn("[Astro] Avatar: No 'src', 'color', or 'colorId' provided. " + 'The component is falling back to a default generated color.');

package/lib/components/Avatar/Avatar.test.js

@@ -22,7 +22,6 @@ var getComponent = function getComponent() {
   var props = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};
   return render(___EmotionJSX(Avatar, _extends({}, defaultProps, props)));
 };
-// Needs to be added to each components test file
 universalComponentTests({
   renderComponent: function renderComponent(props) {
     return ___EmotionJSX(Avatar, _extends({}, defaultProps, props));
@@ -42,7 +41,7 @@ test('an avatar is rendered with custom alt', function () {
   var img = screen.getByRole('img');
   expect(img).toHaveAttribute('alt', 'Custom Alt');
 });
-test('an avatar is rendered with custom alt', function () {
+test('an avatar is rendered with initials', function () {
   var warnSpy = jest.spyOn(console, 'warn').mockImplementation();
   getComponent({
     src: undefined,
@@ -67,9 +66,6 @@ describe('getColorFromUUID', function () {
   test('distributes colors differently for different UUIDs', function () {
     var colorA = getColorFromUUID('id-1', colors);
     var colorB = getColorFromUUID('id-2', colors);
-
-    // While collisions are mathematically possible, for 2 items in a 10-item list,
-    // these specific IDs yield different results in FNV-1a.
     expect(colorA).not.toBe(colorB);
   });
   test('throws error if color array is empty', function () {
@@ -83,8 +79,6 @@ describe('getColorFromUUID', function () {
       colorId: 'some-id'
     });
     var avatar = screen.getByTestId(datatestId);
-
-    // Checking for 'is-blue'
     expect(avatar).toHaveClass('is-blue');
   });
   test('applies a hashed color class from colorId', function () {
@@ -93,9 +87,6 @@ describe('getColorFromUUID', function () {
       colorId: uuid
     });
     var avatar = screen.getByTestId(datatestId);
-
-    // We check that it has *a* class starting with 'is-'
-    // and specifically isn't the default 'is-green'
     var classList = _Array$from(avatar.classList);
     var colorClass = _findInstanceProperty(classList).call(classList, function (cls) {
       return _startsWithInstanceProperty(cls).call(cls, 'is-');
@@ -168,27 +159,40 @@ describe('getColorFromUUID Distribution', function () {
   test('distributes 10,000 UUIDs evenly across 10 colors', function () {
     var iterations = 10000;
     var distribution = {};
-
-    // Initialize counts
     _forEachInstanceProperty(colors).call(colors, function (c) {
       distribution[c] = 0;
     });
-
-    // Generate and hash
     for (var i = 0; i < iterations; i += 1) {
-      // Use the imported randomUUID function directly
       var uuid = randomUUID();
       var selectedColor = getColorFromUUID(uuid, colors);
       distribution[selectedColor] += 1;
     }
     var expectedMean = iterations / colors.length;
-    // 15% variance is a safe threshold for 10k iterations
     var allowedVariance = 0.15;
     _forEachInstanceProperty(colors).call(colors, function (color) {
       var count = distribution[color];
-      // Assert that each color is roughly 10% of the total
       expect(count).toBeGreaterThan(expectedMean * (1 - allowedVariance));
       expect(count).toBeLessThan(expectedMean * (1 + allowedVariance));
     });
   });
+});
+describe('Color Selection Logic', function () {
+  var getResolvedId = function getResolvedId(colorId, defaultText) {
+    return colorId || (defaultText && defaultText !== 'AA' ? defaultText : '_INTERNAL_DEFAULT_ID_');
+  };
+  test('should use colorId if it is provided', function () {
+    expect(getResolvedId('custom-id', 'BB')).toBe('custom-id');
+  });
+  test('should use defaultText if colorId is missing and text is not "AA"', function () {
+    expect(getResolvedId(null, 'BB')).toBe('BB');
+  });
+  test('should use hardcoded string if colorId is missing and text is "AA"', function () {
+    expect(getResolvedId(undefined, 'AA')).toBe('_INTERNAL_DEFAULT_ID_');
+  });
+  test('should use hardcoded string if both colorId and defaultText are null', function () {
+    expect(getResolvedId(null, null)).toBe('_INTERNAL_DEFAULT_ID_');
+  });
+  test('should use hardcoded string if colorId is missing and defaultText is empty string', function () {
+    expect(getResolvedId(null, '')).toBe('_INTERNAL_DEFAULT_ID_');
+  });
 });

package/lib/components/PanelHeader/PanelHeader.js

@@ -51,7 +51,6 @@ var PanelHeader = /*#__PURE__*/forwardRef(function (_ref, ref) {
     }
   }));
   var renderAvatar = ___EmotionJSX(Avatar, _extends({
-    color: image !== null && image !== void 0 && image.src ? false : 'green',
     src: image === null || image === void 0 ? void 0 : image.src,
     isSquare: !!(image !== null && image !== void 0 && image.src),
     size: "avatar.lg",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pingux/astro",
-  "version": "2.184.0-alpha.0",
+  "version": "2.185.0-alpha.0",
   "description": "React component library for Ping Identity's design system",
   "repository": {
     "type": "git",