@pingux/astro 1.34.0-alpha.0 → 1.34.0-alpha.2

package/CHANGELOG.md

@@ -3,6 +3,19 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [1.33.1](https://gitlab.corp.pingidentity.com/ux/pingux/compare/@pingux/astro@1.33.0...@pingux/astro@1.33.1) (2022-11-01)
+
+
+### Bug Fixes
+
+* [UIP-5638] LinkedListView - fix label font size ([aa9dfbe](https://gitlab.corp.pingidentity.com/ux/pingux/commit/aa9dfbed209fa782f66bd01396b396003a4db030))
+* [UIP-5796] Fix checkbox getting focus indicator on click within a modal ([2fcc515](https://gitlab.corp.pingidentity.com/ux/pingux/commit/2fcc5154bb6eef4cb1191ad5a4c6830cf7b7b3e1))
+* [UIP-5839] Fix support for checkbox indeterminism ([eef26e6](https://gitlab.corp.pingidentity.com/ux/pingux/commit/eef26e653948d0059e07475cb9056fd606955068))
+
+
+
+
+
 # [1.33.0](https://gitlab.corp.pingidentity.com/ux/pingux/compare/@pingux/astro@1.32.1...@pingux/astro@1.33.0) (2022-10-27)
 
 

package/lib/cjs/components/MultivaluesField/MultivaluesField.js

@@ -272,6 +272,8 @@ var MultivaluesField = /*#__PURE__*/(0, _react.forwardRef)(function (props, ref)
     switch (e.key) {
       case 'Enter':
         {
+          e.preventDefault();
+
           if (selectionManager.focusedKey) {
             var key = selectionManager.focusedKey;
 

package/lib/cjs/components/MultivaluesField/MultivaluesField.test.js

@@ -55,6 +55,24 @@ var getComponent = function getComponent() {
   })));
 };
 
+var getComponentInForm = function getComponentInForm() {
+  var props = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};
+  var onFormSubmit = arguments.length > 1 ? arguments[1] : undefined;
+
+  var _ref2 = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : {},
+      _ref2$renderFn = _ref2.renderFn,
+      renderFn = _ref2$renderFn === void 0 ? _testWrapper.render : _ref2$renderFn;
+
+  return renderFn((0, _react2.jsx)(_index.OverlayProvider, null, (0, _react2.jsx)("form", {
+    onSubmit: onFormSubmit
+  }, (0, _react2.jsx)(_index.MultivaluesField, (0, _extends2["default"])({}, defaultProps, props), function (item) {
+    return (0, _react2.jsx)(_index.Item, {
+      key: item.key,
+      "data-id": item.name
+    }, item.name);
+  }))));
+};
+
 beforeAll(function () {
   jest.spyOn(window.HTMLElement.prototype, 'clientWidth', 'get').mockImplementation(function () {
     return 1000;
@@ -570,4 +588,21 @@ test('popover closes on input blur', function () {
 
   expect(_testWrapper.screen.queryByRole('listbox')).not.toBeInTheDocument();
   expect(_testWrapper.screen.queryByRole('option')).not.toBeInTheDocument();
+});
+test('form does not submit when adding custom value', function () {
+  var onFormSubmit = jest.fn();
+  getComponentInForm({}, onFormSubmit);
+
+  var input = _testWrapper.screen.getByRole('combobox');
+
+  expect(input).toHaveValue('');
+  var value = 'custom';
+
+  _userEvent["default"].type(input, value);
+
+  expect(input).toHaveValue(value);
+
+  _userEvent["default"].type(input, '{enter}');
+
+  expect(onFormSubmit).not.toHaveBeenCalled();
 });

package/lib/components/MultivaluesField/MultivaluesField.js

@@ -220,6 +220,8 @@ var MultivaluesField = /*#__PURE__*/forwardRef(function (props, ref) {
     switch (e.key) {
       case 'Enter':
         {
+          e.preventDefault();
+
           if (selectionManager.focusedKey) {
             var key = selectionManager.focusedKey;
 

package/lib/components/MultivaluesField/MultivaluesField.test.js

@@ -41,6 +41,24 @@ var getComponent = function getComponent() {
   })));
 };
 
+var getComponentInForm = function getComponentInForm() {
+  var props = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};
+  var onFormSubmit = arguments.length > 1 ? arguments[1] : undefined;
+
+  var _ref2 = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : {},
+      _ref2$renderFn = _ref2.renderFn,
+      renderFn = _ref2$renderFn === void 0 ? render : _ref2$renderFn;
+
+  return renderFn(___EmotionJSX(OverlayProvider, null, ___EmotionJSX("form", {
+    onSubmit: onFormSubmit
+  }, ___EmotionJSX(MultivaluesField, _extends({}, defaultProps, props), function (item) {
+    return ___EmotionJSX(Item, {
+      key: item.key,
+      "data-id": item.name
+    }, item.name);
+  }))));
+};
+
 beforeAll(function () {
   jest.spyOn(window.HTMLElement.prototype, 'clientWidth', 'get').mockImplementation(function () {
     return 1000;
@@ -420,4 +438,15 @@ test('popover closes on input blur', function () {
   userEvent.click(document.body);
   expect(screen.queryByRole('listbox')).not.toBeInTheDocument();
   expect(screen.queryByRole('option')).not.toBeInTheDocument();
+});
+test('form does not submit when adding custom value', function () {
+  var onFormSubmit = jest.fn();
+  getComponentInForm({}, onFormSubmit);
+  var input = screen.getByRole('combobox');
+  expect(input).toHaveValue('');
+  var value = 'custom';
+  userEvent.type(input, value);
+  expect(input).toHaveValue(value);
+  userEvent.type(input, '{enter}');
+  expect(onFormSubmit).not.toHaveBeenCalled();
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pingux/astro",
-  "version": "1.34.0-alpha.0",
+  "version": "1.34.0-alpha.2",
   "description": "PingUX themeable React component library",
   "repository": {
     "type": "git",