@pinelab/vendure-plugin-qls-fulfillment 2.0.1 → 2.0.2

package/CHANGELOG.md

@@ -1,3 +1,8 @@
+# 2.0.2 (2026-07-01)
+
+- Verify barcode deletion in QLS by fetching remaining barcodes after removal attempt
+- Emit `QlsVariantSyncFailedEvent` and log an error when barcodes fail to be removed from QLS
+
 # 2.0.1 (2026-06-15)
 
 - Fixed fulfillment product detail type

package/dist/lib/qls-client.d.ts

@@ -25,6 +25,10 @@ export declare class QlsClient {
     updateFulfillmentProduct(fulfillmentProductId: string, data: FulfillmentProductInput): Promise<void>;
     deleteFulfillmentProduct(fulfillmentProductId: string): Promise<void>;
     createFulfillmentOrder(data: Omit<FulfillmentOrderInput, 'brand_id'>): Promise<FulfillmentOrder>;
+    /**
+     * Get all barcodes for a fulfillment product in QLS
+     */
+    getBarcodes(productId: string): Promise<FulfillmentProduct['barcodes']>;
     /**
      * Add an extra barcode to a fulfillment product in QLS
      */

package/dist/lib/qls-client.js

@@ -85,6 +85,13 @@ class QlsClient {
         }
         return response.data;
     }
+    /**
+     * Get all barcodes for a fulfillment product in QLS
+     */
+    async getBarcodes(productId) {
+        const result = await this.rawRequest('GET', `fulfillment/products/${productId}/barcodes`);
+        return result.data ?? [];
+    }
     /**
      * Add an extra barcode to a fulfillment product in QLS
      */

package/dist/services/qls-product.service.js

@@ -335,7 +335,7 @@ let QlsProductService = class QlsProductService {
             core_1.Logger.info(`Set QLS product ID for variant '${variant.sku}' to ${qlsProduct.id}`, constants_1.loggerCtx);
         }
         if (qlsProduct) {
-            const updatedEANs = await this.updateAdditionalEANs(ctx, client, qlsProduct, additionalEANs);
+            const updatedEANs = await this.updateAdditionalEANs(ctx, client, qlsProduct, additionalEANs, variant);
             if (createdOrUpdated === 'not-changed' && updatedEANs) {
                 // If nothing changed so far, but EANs changed, then we did update the product in QLS
                 createdOrUpdated = 'updated';
@@ -349,7 +349,7 @@ let QlsProductService = class QlsProductService {
     /**
      * Update the additional EANs/barcodes for a product in QLS if needed
      */
-    async updateAdditionalEANs(ctx, client, qlsProduct, additionalEANs) {
+    async updateAdditionalEANs(ctx, client, qlsProduct, additionalEANs, variant) {
         const existingAdditionalEANs = qlsProduct?.barcodes_and_ean.filter((ean) => ean !== qlsProduct.ean); // Remove the main EAN
         const eansToUpdate = (0, util_2.getEansToUpdate)({
             existingEans: existingAdditionalEANs,
@@ -374,8 +374,16 @@ let QlsProductService = class QlsProductService {
             .filter((barcode) => eansToUpdate.eansToRemove.includes(barcode.barcode))
             .map((barcode) => barcode.id);
         await Promise.all(barcodeIdsToRemove.map((barcodeId) => client.removeBarcode(qlsProduct.id, barcodeId)));
-        if (eansToUpdate.eansToRemove.length > 0) {
-            core_1.Logger.info(`Removed EANs '${eansToUpdate.eansToRemove.join(',')} from product '${qlsProduct.sku}' in QLS`, constants_1.loggerCtx);
+        // Fetch remaining barcodes from QLS to verify deletion worked
+        const remainingBarcodes = await client.getBarcodes(qlsProduct.id);
+        const remainingEansToRemove = eansToUpdate.eansToRemove.filter((ean) => remainingBarcodes.some((barcode) => barcode.barcode === ean));
+        if (remainingEansToRemove.length > 0) {
+            const errorMessage = `Failed to remove EANs '${remainingEansToRemove.join(',')}' from product '${qlsProduct.sku}' in QLS. Barcodes still present after deletion attempt.`;
+            core_1.Logger.error(errorMessage, constants_1.loggerCtx);
+            await this.eventBus.publish(new qls_variant_sync_failed_event_1.QlsVariantSyncFailedEvent(ctx, variant, new Date(), errorMessage));
+        }
+        else if (eansToUpdate.eansToRemove.length > 0) {
+            core_1.Logger.info(`Removed EANs '${eansToUpdate.eansToRemove.join(',')}' from product '${qlsProduct.sku}' in QLS`, constants_1.loggerCtx);
         }
         return true;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pinelab/vendure-plugin-qls-fulfillment",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "description": "Vendure plugin to fulfill orders via QLS.",
   "keywords": [
     "fulfillment",