@pinelab/vendure-plugin-qls-fulfillment 1.0.0-beta.7 → 1.0.0-beta.9

package/dist/services/qls-product.service.js

@@ -132,6 +132,7 @@ let QlsProductService = class QlsProductService {
             }
             core_1.Logger.info(`Created ${createdQlsProductsCount} products in QLS`, constants_1.loggerCtx);
             core_1.Logger.info(`Updated ${updatedQlsProductsCount} products in QLS`, constants_1.loggerCtx);
+            core_1.Logger.info(`Finished full sync with ${failedCount} failures`, constants_1.loggerCtx);
             return {
                 updatedInQls: updatedQlsProductsCount,
                 createdInQls: createdQlsProductsCount,
@@ -277,6 +278,9 @@ let QlsProductService = class QlsProductService {
                 createdOrUpdated = 'updated';
             }
         }
+        if (createdOrUpdated === 'not-changed') {
+            core_1.Logger.info(`Variant '${variant.sku}' not updated in QLS, because no changes were found.`, constants_1.loggerCtx);
+        }
         return createdOrUpdated;
     }
     /**
@@ -288,17 +292,26 @@ let QlsProductService = class QlsProductService {
             existingEans: existingAdditionalEANs,
             desiredEans: additionalEANs,
         });
-        if (!eansToUpdate) {
+        if (!eansToUpdate || eansToUpdate.eansToAdd.length === 0 && eansToUpdate.eansToRemove.length === 0) {
             // No updates needed
             return false;
         }
+        // Add additional EANs
+        eansToUpdate.eansToAdd = (0, util_2.normalizeEans)(eansToUpdate.eansToAdd);
         await Promise.all(eansToUpdate.eansToAdd.map((ean) => client.addBarcode(qlsProduct.id, ean)));
+        if (eansToUpdate.eansToAdd.length > 0) {
+            core_1.Logger.info(`Added additional EANs: ${eansToUpdate.eansToAdd.join(',')} to product '${qlsProduct.sku}' in QLS`, constants_1.loggerCtx);
+        }
+        // Remove EANs, normalize first
+        eansToUpdate.eansToRemove = (0, util_2.normalizeEans)(eansToUpdate.eansToRemove);
         // get barcode ID's to remove, because deletion goes via barcode ID, not barcode value
         const barcodeIdsToRemove = qlsProduct.barcodes
             .filter((barcode) => eansToUpdate.eansToRemove.includes(barcode.barcode))
             .map((barcode) => barcode.id);
         await Promise.all(barcodeIdsToRemove.map((barcodeId) => client.removeBarcode(qlsProduct.id, barcodeId)));
-        core_1.Logger.info(`Added additional EANs '${eansToUpdate.eansToAdd.join(',')}', and removed EANs '${eansToUpdate.eansToRemove.join(',')}' for product '${qlsProduct.sku}' in QLS`, constants_1.loggerCtx);
+        if (eansToUpdate.eansToRemove.length > 0) {
+            core_1.Logger.info(`Removed EANs '${eansToUpdate.eansToRemove.join(',')} from product '${qlsProduct.sku}' in QLS`, constants_1.loggerCtx);
+        }
         return true;
     }
     /**

package/dist/services/util.spec.js

@@ -9,9 +9,9 @@ const util_1 = require("./util");
             desiredEans: ['456', '123'],
         })).toBe(false);
     });
-    (0, vitest_1.it)('ignores ordering, whitespace and null/undefined when determining additions', () => {
+    (0, vitest_1.it)('ignores ordering, whitespace, null/undefined and empty stringswhen determining additions', () => {
         (0, vitest_1.expect)((0, util_1.getEansToUpdate)({
-            existingEans: [null, '123'],
+            existingEans: [null, '123', ''],
             desiredEans: [' 123', '456 ', undefined, null],
         })).toEqual({
             eansToAdd: ['456'],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pinelab/vendure-plugin-qls-fulfillment",
-  "version": "1.0.0-beta.7",
+  "version": "1.0.0-beta.9",
   "description": "Vendure plugin to fulfill orders via QLS.",
   "keywords": [
     "fulfillment",