@pineforge/codegen-pyodide 0.9.0 → 0.10.1

package/pineforge_codegen/codegen/visit_stmt.py

@@ -37,8 +37,6 @@ Mixin contract — host class must provide the following attributes
   ``_visit_var_decl`` populates it from inferred specs.
 - ``self._active_var_remap`` (``dict[str, str]``): per-call-site
   rename map for cloned function-local var/series names.
-- ``self._in_ta_func_variant`` (``bool``): set during per-call-site
-  function emission; gates the TA-hoist branch in ``_visit_if``.
 - ``self._current_loop_vars`` (``set[str]``): for-in iterator names;
   saved/restored around ``_visit_for_in`` bodies so member-access
   resolution can distinguish iterators from enum constants.
@@ -58,7 +56,7 @@ Sibling-mixin methods consumed via ``self``:
   ``_map_spec_for_name``.
 - ``TaSiteHelper`` (``codegen/ta.py``): ``_get_ta_site``,
   ``_ta_member_name``, ``_ta_compute_args_for_site``,
-  ``_ta_name_from_site``, ``_if_body_has_ta``, ``_hoist_if_body``.
+  ``_ta_name_from_site``.
 - ``InputHelper`` (``codegen/input.py``): ``_is_input_call``,
   ``_get_input_default``, ``_get_input_title``,
   ``_input_type_to_getter``,
@@ -93,21 +91,24 @@ from ..ast_nodes import (
     MethodDef,
     StrategyDecl,
     SwitchStmt,
+    Ternary,
     TupleAssign,
+    TupleLiteral,
     TypeDecl,
     VarDecl,
     WhileStmt,
 )
-from ..symbols import TypeSpec
+from ..symbols import PineType, TypeSpec, method_receiver_type_name
 from .tables import (
     ARRAY_NEW_CTORS,
+    DRAWING_TYPE_TO_CPP,
     TA_RETURNS_BOOL,
     TA_TUPLE_FIELDS,
     MATRIX_RETURNING_METHODS,
 )
 
-# Sentinel for "no block-scoped var remap was activated" so an empty dict
-# saved-remap is still distinguishable from the no-op case.
+# Sentinel for "no block-scoped overlay was activated" so an empty saved map
+# is still distinguishable from the no-op case.
 _NO_BLOCK_REMAP = object()
 
 
@@ -137,11 +138,191 @@ class StmtVisitor:
         if isinstance(node, MethodDef):
             return  # handled as class method via FuncInfo
         if isinstance(node, VarDecl):
-            self._visit_var_decl(node, lines, pad)
+            is_callable_binding = (
+                getattr(self, "_active_func_name", None) is not None
+                and id(node) in self._callable_collection_bindings
+            )
+            activation_spec = (
+                self._callable_collection_bindings.get(id(node))
+                if is_callable_binding
+                else None
+            )
+            if is_callable_binding and activation_spec is None:
+                inferred_spec = self._type_spec_from_expr(node.value)
+                if (inferred_spec is not None
+                        and inferred_spec.kind in {"array", "map", "matrix"}):
+                    activation_spec = inferred_spec
+            previous_pending_alias = self._pending_decl_outer_alias
+            if (is_callable_binding
+                    and not node.is_var
+                    and not node.is_varip
+                    and self._collection_spec_for_name(node.name) is not None
+                    and any(
+                        isinstance(part, Identifier) and part.name == node.name
+                        for part in self._walk_ast(node.value)
+                    )):
+                safe_name = self._safe_name(node.name)
+                if (node.name in self._global_collection_types
+                        and node.name not in self._current_func_param_specs
+                        and node.name not in self._current_func_collection_specs
+                        and node.name not in self._current_loop_var_specs):
+                    outer_expr = f"this->{safe_name}"
+                else:
+                    outer_expr = self._active_var_remap.get(safe_name, safe_name)
+                occupied_alias_names = (
+                    set(self._all_bound_names)
+                    | set(self._collection_shadow_tmp_names)
+                    | set(self._current_func_param_types)
+                    | {
+                        self._safe_name(param)
+                        for param in self._current_func_param_types
+                    }
+                )
+                while True:
+                    alias = (
+                        f"_pf_outer_{safe_name}_"
+                        f"{self._collection_shadow_tmp_counter}"
+                    )
+                    self._collection_shadow_tmp_counter += 1
+                    if alias not in occupied_alias_names:
+                        break
+                self._collection_shadow_tmp_names.add(alias)
+                lines.append(f"{pad}auto& {alias} = {outer_expr};")
+                self._pending_decl_outer_alias = {
+                    **previous_pending_alias,
+                    node.name: alias,
+                }
+            try:
+                self._visit_var_decl(node, lines, pad)
+            finally:
+                self._pending_decl_outer_alias = previous_pending_alias
+            if is_callable_binding:
+                self._activate_callable_collection_binding(
+                    node.name,
+                    activation_spec,
+                )
+            metadata = getattr(
+                self.ctx, "var_member_metadata_by_node", {}
+            ).get(id(node))
+            if metadata is not None:
+                member_name = metadata[1]
+                if member_name != node.name:
+                    # The declaration RHS was emitted against the inherited
+                    # binding.  Only now activate the collision-safe member for
+                    # later statements in this exact lexical block.
+                    exact_storage = self._safe_name(member_name)
+                    # A callable variant may already map the exact member to a
+                    # per-call-site clone (``x__blk1`` -> ``x__blk1_cs1``).
+                    # Preserve that outer clone mapping when exposing the raw
+                    # lexical spelling after the declaration.
+                    exact_storage = self._active_var_remap.get(
+                        exact_storage, exact_storage
+                    )
+                    self._active_var_remap = dict(self._active_var_remap)
+                    self._active_var_remap[self._safe_name(node.name)] = (
+                        exact_storage
+                    )
+                drawing_info = self._drawing_var_decl_info_by_node.get(id(node))
+                if (drawing_info is not None
+                        and drawing_info.get("is_callable_scoped")):
+                    raw_safe = self._safe_name(node.name)
+                    storage = self._active_var_remap.get(
+                        raw_safe, self._safe_name(member_name)
+                    )
+                    if storage.startswith("this->"):
+                        storage = storage[len("this->"):]
+                    self._active_var_remap = dict(self._active_var_remap)
+                    self._active_var_remap[raw_safe] = f"this->{storage}"
+                self._lexical_series_bindings[node.name] = (
+                    self._safe_name(member_name)
+                    in self._series_var_member_names
+                )
+            else:
+                self._lexical_series_bindings[node.name] = (
+                    self._decl_binding_is_series(id(node), node.name)
+                )
+            if id(node) not in self._direct_program_var_decl_nodes:
+                self._lexical_known_var_tombstones.add(node.name)
+            decl_spec = getattr(
+                self.ctx, "var_member_type_specs_by_node", {}
+            ).get(id(node))
+            if decl_spec is None:
+                decl_spec = (
+                    self._type_spec_from_hint_name(node.type_hint)
+                    if node.type_hint
+                    else self._type_spec_from_expr(node.value)
+                )
+            self._lexical_drawing_types[node.name] = (
+                DRAWING_TYPE_TO_CPP.get(decl_spec.name)
+                if decl_spec is not None and decl_spec.kind == "udt"
+                else None
+            )
+            self._lexical_udt_types[node.name] = (
+                decl_spec.name
+                if (decl_spec is not None
+                    and decl_spec.kind == "udt"
+                    and decl_spec.name in self._udt_defs)
+                else None
+            )
+            if (
+                node.name == "map"
+                and getattr(self, "_block_map_visibility_depth", 0) > 0
+            ):
+                # The declaration RHS was emitted against the outer lexical
+                # state. Only subsequent statements in this exact block see
+                # the new ``map`` value; block pop restores sibling/outside
+                # visibility.
+                self._block_map_binding_visible = True
         elif isinstance(node, Assignment):
             self._visit_assignment(node, lines, pad)
         elif isinstance(node, TupleAssign):
             self._visit_tuple_assign(node, lines, pad)
+            tuple_cpp_types = self._tuple_binding_cpp_types(node)
+            if getattr(self, "_active_func_name", None) is not None:
+                for name in node.names:
+                    if name and name != "_":
+                        self._activate_callable_collection_binding(name, None)
+            scalar_names = [
+                name
+                for name in node.names
+                if name
+                and name != "_"
+                and not self._decl_binding_is_series(id(node), name)
+            ]
+            if any(
+                self._safe_name(name) in self._active_var_remap
+                for name in scalar_names
+            ):
+                # Tuple declarations are lexical bindings.  A scalar element
+                # must shadow any same-spelled Series storage inherited from a
+                # broad callable call-site remap; otherwise a later read can
+                # silently resolve to an unrelated ``x_csN`` member even
+                # though the structured binding declared a local ``x``.
+                self._active_var_remap = dict(self._active_var_remap)
+                for name in scalar_names:
+                    self._active_var_remap.pop(self._safe_name(name), None)
+            for index, name in enumerate(node.names):
+                if name and name != "_":
+                    # A supported tuple destructure creates fresh lexical
+                    # bindings.  Tuple elements are primitive on the current
+                    # supported surface, so install an explicit tombstone: an
+                    # unrelated same-named global/callable UDT must not target-
+                    # type a later ``name := na`` as ``State{}``.
+                    self._lexical_udt_types[name] = None
+                    if (getattr(self, "_active_func_name", None) is not None
+                            and not self._decl_binding_is_series(
+                                id(node), name
+                            )):
+                        self._current_func_local_types[name] = (
+                            tuple_cpp_types[index]
+                            if index < len(tuple_cpp_types)
+                            else "double"
+                        )
+                    self._lexical_series_bindings[name] = (
+                        self._decl_binding_is_series(id(node), name)
+                    )
+                    if id(node) not in self._direct_program_tuple_decl_nodes:
+                        self._lexical_known_var_tombstones.add(name)
         elif isinstance(node, IfStmt):
             self._visit_if(node, lines, indent)
         elif isinstance(node, ForStmt):
@@ -234,7 +415,8 @@ class StmtVisitor:
         # m.concat(other, ...) — receiver is callee.object
         if isinstance(callee.object, Identifier):
             recv = callee.object.name
-            if recv in getattr(self, "_matrix_specs", {}):
+            recv_spec = self._collection_spec_for_name(recv)
+            if recv_spec is not None and recv_spec.kind == "matrix":
                 return recv
         # matrix.concat(m, other, ...) — receiver is first arg
         if (isinstance(callee.object, Identifier)
@@ -242,21 +424,155 @@ class StmtVisitor:
                 and expr.args
                 and isinstance(expr.args[0], Identifier)):
             recv = expr.args[0].name
-            if recv in getattr(self, "_matrix_specs", {}):
+            recv_spec = self._collection_spec_for_name(recv)
+            if recv_spec is not None and recv_spec.kind == "matrix":
                 return recv
         return None
 
+    def _nullable_collection_target_cpp_type(
+        self,
+        *,
+        name: str | None = None,
+        target_node=None,
+        type_hint: str | None = None,
+    ) -> str | None:
+        """Return the exact nullable collection type for an RHS target.
+
+        Declarations need the explicit hint before their lexical collection
+        binding is activated; reassignments can use the active name registry,
+        while UDT fields are resolved from the target expression itself.
+        Arrays are deliberately excluded until their runtime representation
+        can distinguish ``na`` from a valid empty ID.
+        """
+        spec = self._type_spec_from_hint_name(type_hint) if type_hint else None
+        if spec is None and target_node is not None:
+            spec = self._type_spec_from_expr(target_node)
+        if spec is None and name is not None:
+            spec = self._collection_spec_for_name(name)
+        if spec is None or spec.kind not in {"map", "matrix"}:
+            return None
+        return self._type_spec_to_cpp(spec)
+
     def _visit_var_decl(self, node: VarDecl, lines: list[str], pad: str) -> None:
-        # var/varip — handled as members in on_bar preamble
+        member_meta = getattr(
+            self.ctx, "var_member_metadata_by_node", {}
+        ).get(id(node))
+        if member_meta is not None:
+            declaration_is_series = (
+                self._safe_name(member_meta[1])
+                in self._series_var_member_names
+            )
+        else:
+            declaration_is_series = (
+                self._decl_binding_is_series(id(node), node.name)
+            )
+        # Primitive runtime var/varip initializers execute at the declaration
+        # site under a dedicated once flag. This preserves source order (a
+        # preceding input/plain/TA declaration is already available) and Pine's
+        # first-entry semantics for declarations nested in conditional blocks.
+        # Series, aggregates, constructor constants, and function-local vars
+        # retain their specialized initialization paths.
         if node.is_var or node.is_varip:
+            info = self._runtime_scalar_var_init_by_node.get(id(node))
+            if info is not None:
+                member_name = info["member_name"]
+                target = self._safe_name(member_name)
+                if self._active_var_remap and target in self._active_var_remap:
+                    target = self._active_var_remap[target]
+                flag = self._runtime_var_init_flags.get(
+                    (info["node_id"], target),
+                    info["flag"],
+                )
+                target_expr = (
+                    f"this->{target}"
+                    if info.get("is_callable_scoped")
+                    else target
+                )
+                flag_expr = (
+                    f"this->{flag}"
+                    if info.get("is_callable_scoped")
+                    else flag
+                )
+                previous_input_name = self._current_input_var_name
+                self._current_input_var_name = node.name
+                try:
+                    type_spec = info.get("type_spec")
+                    target_cpp_type = info.get("drawing_cpp")
+                    if (
+                        target_cpp_type is None
+                        and type_spec is not None
+                        and type_spec.kind in {"map", "matrix"}
+                    ):
+                        target_cpp_type = self._type_spec_to_cpp(type_spec)
+                    if (
+                        target_cpp_type is not None
+                        and type_spec is not None
+                        and type_spec.kind in {"map", "matrix"}
+                        and isinstance(node.value, (IfStmt, SwitchStmt))
+                    ):
+                        lines.append(f"{pad}if (!{flag_expr}) {{")
+                        self._visit_if_switch_expr(
+                            node.value,
+                            target_expr,
+                            lines,
+                            len(pad) // 4 + 1,
+                            target_cpp_type=target_cpp_type,
+                        )
+                        # The flag belongs after the complete selection.  If it
+                        # were emitted in an individual branch, unmatched paths
+                        # or later arms could retry a Pine ``var`` initializer,
+                        # violating first-reach / one-time semantics.
+                        lines.append(f"{pad}    {flag_expr} = true;")
+                        lines.append(f"{pad}}}")
+                        return
+                    if target_cpp_type is not None:
+                        init_cpp = self._visit_rhs_value(
+                            node.value,
+                            member_name,
+                            target_cpp_type=target_cpp_type,
+                        )
+                    else:
+                        init_cpp = self._visit_expr(node.value)
+                finally:
+                    self._current_input_var_name = previous_input_name
+                if info.get("drawing_cpp") is None:
+                    init_cpp = self._typed_na_init(
+                        init_cpp, member_name, info["ptype"]
+                    )
+                lines.append(f"{pad}if (!{flag_expr}) {{")
+                # A history-referenced persistent primitive is a Series<T> too,
+                # not just a drawing handle.  The per-bar carry has already
+                # advanced it before this declaration-site one-shot runs, so
+                # replace the current slot rather than assigning a scalar to
+                # the Series object (or pushing a duplicate bar).
+                if info.get("is_series"):
+                    lines.append(f"{pad}    {target_expr}.update({init_cpp});")
+                else:
+                    lines.append(f"{pad}    {target_expr} = {init_cpp};")
+                lines.append(f"{pad}    {flag_expr} = true;")
+                lines.append(f"{pad}}}")
             return
 
         safe = self._safe_name(node.name)
         # Apply per-call-site var remap (for function-local vars)
         if self._active_var_remap and safe in self._active_var_remap:
             safe = self._active_var_remap[safe]
-        # Global-scope non-var vars are class members — emit assignment, not declaration
-        is_global_member = node.name in self._global_member_vars
+        # Only a declaration in the script body can bind a hoisted global
+        # member.  A callable-local declaration may legally shadow that global
+        # with the same raw name; treating it as the member emits an assignment
+        # into unrelated storage (and can assign a scalar into Series<T> when
+        # the global was promoted for an indirect history call).
+        is_global_member = (
+            getattr(self, "_active_func_name", None) is None
+            and node.name in self._global_member_vars
+            and (
+                id(node) in self._ordinary_global_var_decl_nodes
+                or (
+                    node.name not in self._direct_program_binding_names
+                    and node.name not in self._callable_state_raw_names
+                )
+            )
+        )
 
         def remember_local_type(cpp_type: str | None) -> None:
             if cpp_type and not is_global_member:
@@ -287,7 +603,7 @@ class StmtVisitor:
                 self._enforce_enum_declared_before_input_enum(node.value)
             title = self._get_input_title(node.value, var_name=node.name)
             cpp_val = self._render_input_value(node.value, func_name_i, namespace_i, title)
-            if node.name in self.ctx.series_vars:
+            if declaration_is_series:
                 self._emit_history_series_write(lines, pad, safe, cpp_val)
             elif is_global_member:
                 lines.append(f"{pad}{safe} = {cpp_val};")
@@ -301,10 +617,16 @@ class StmtVisitor:
         if isinstance(node.value, FuncCall):
             func_name, namespace = self._resolve_callee(node.value.callee)
             if namespace == "array" and func_name in ARRAY_NEW_CTORS | {"new", "from", "copy", "slice"}:
+                captured = self._callable_collection_bindings.get(id(node))
+                spec = (
+                    captured
+                    if captured is not None and captured.kind == "array"
+                    else self._type_spec_from_expr(node.value)
+                        or self._array_spec_for_name(node.name)
+                )
+                init = self._visit_expr(node.value)
                 self._array_vars.add(node.name)
-                spec = self._type_spec_from_expr(node.value) or self._array_spec_for_name(node.name)
                 self._collection_types.setdefault(node.name, spec)
-                init = self._visit_expr(node.value)
                 cpp_type = self._type_spec_to_cpp(spec)
                 if is_global_member:
                     lines.append(f"{pad}{safe} = {init};")
@@ -318,9 +640,13 @@ class StmtVisitor:
             if namespace == "matrix" and func_name == "new":
                 targs = self._template_args_from_call(node.value) if hasattr(node.value, "annotations") else []
                 elem_spec = self._type_spec_from_hint_name(targs[0]) if targs else TypeSpec.primitive("float")
-                spec = TypeSpec.matrix(elem_spec)
-                self._matrix_specs[node.name] = spec
-                self._collection_types[node.name] = spec
+                captured = self._callable_collection_bindings.get(id(node))
+                spec = (
+                    captured
+                    if captured is not None and captured.kind == "matrix"
+                    else TypeSpec.matrix(elem_spec)
+                )
+                elem_spec = spec.element or elem_spec
                 cpp_type = self._type_spec_to_cpp(spec)
                 if len(node.value.args) >= 2:
                     r = self._visit_expr(node.value.args[0])
@@ -329,6 +655,8 @@ class StmtVisitor:
                     init = f"{cpp_type}::new_({r}, {c}, {v})"
                 else:
                     init = f"{cpp_type}::new_(0, 0, {self._default_for_spec(elem_spec)})"
+                self._matrix_specs[node.name] = spec
+                self._collection_types[node.name] = spec
                 if is_global_member:
                     lines.append(f"{pad}{safe} = {init};")
                 else:
@@ -341,12 +669,20 @@ class StmtVisitor:
             # rejects ``double = PineMatrix``. The RHS expression itself is
             # already lowered to the right ``m.inv()`` form by visit_call.
             if namespace == "matrix" and func_name in MATRIX_RETURNING_METHODS:
-                recv_spec = self._matrix_specs.get(self._extract_receiver_name(node.value))
-                if recv_spec is None:
+                recv_name = self._extract_receiver_name(node.value)
+                recv_spec = (
+                    self._collection_spec_for_name(recv_name)
+                    if recv_name is not None
+                    else None
+                )
+                if recv_spec is None or recv_spec.kind != "matrix":
                     recv_spec = TypeSpec.matrix(TypeSpec.primitive("float"))
+                captured = self._callable_collection_bindings.get(id(node))
+                if captured is not None and captured.kind == "matrix":
+                    recv_spec = captured
+                init = self._visit_expr(node.value)
                 self._matrix_specs[node.name] = recv_spec
                 self._collection_types[node.name] = recv_spec
-                init = self._visit_expr(node.value)
                 cpp_type = self._type_spec_to_cpp(recv_spec)
                 if is_global_member:
                     lines.append(f"{pad}{safe} = {init};")
@@ -354,14 +690,21 @@ class StmtVisitor:
                     lines.append(f"{pad}{cpp_type} {safe} = {init};")
                 return
             if namespace == "map" and func_name == "new":
+                captured = self._callable_collection_bindings.get(id(node))
+                spec = (
+                    captured
+                    if captured is not None and captured.kind == "map"
+                    else self._type_spec_from_expr(node.value)
+                        or self._map_spec_for_name(node.name)
+                )
                 self._map_vars.add(node.name)
-                spec = self._type_spec_from_expr(node.value) or self._map_spec_for_name(node.name)
                 self._collection_types.setdefault(node.name, spec)
                 cpp_type = self._type_spec_to_cpp(spec)
+                init = f"{cpp_type}::new_()"
                 if is_global_member:
-                    lines.append(f"{pad}{safe} = {cpp_type}();")
+                    lines.append(f"{pad}{safe} = {init};")
                 else:
-                    lines.append(f"{pad}{cpp_type} {safe};")
+                    lines.append(f"{pad}{cpp_type} {safe} = {init};")
                 return
 
         # Visual/drawing function assignments (line.new, label.new, box.new,
@@ -389,7 +732,7 @@ class StmtVisitor:
                 f"(history_advances_new_bar() ? {ta_name}.compute({compute_args}) "
                 f": {ta_name}.recompute({compute_args}))"
             )
-            if node.name in self.ctx.series_vars:
+            if declaration_is_series:
                 self._emit_history_series_write(lines, pad, safe, ta_expr)
             elif is_global_member:
                 lines.append(f"{pad}{safe} = {ta_expr};")
@@ -398,41 +741,58 @@ class StmtVisitor:
             return
 
         # Non-var series variable — push instead of declare
-        if node.name in self.ctx.series_vars:
-            cpp_val = self._visit_expr(node.value)
+        if declaration_is_series:
+            target_cpp_type = self._type_for_decl(node)
+            cpp_val = self._visit_rhs_value(
+                node.value,
+                node.name,
+                target_cpp_type=(
+                    target_cpp_type
+                    if target_cpp_type in DRAWING_TYPE_TO_CPP.values()
+                    else None
+                ),
+            )
             self._emit_history_series_write(lines, pad, safe, cpp_val)
             return
 
         # If/switch expression: x = if cond ... else ...
         if isinstance(node.value, (IfStmt, SwitchStmt)):
+            cpp_type = self._type_for_decl(node) if not is_global_member else None
+            selection_cpp_type = (
+                cpp_type
+                if (cpp_type is not None
+                    and (self._is_nullable_collection_cpp_type(cpp_type)
+                         or cpp_type in DRAWING_TYPE_TO_CPP.values()
+                         or cpp_type in self._udt_defs))
+                else self._nullable_collection_target_cpp_type(
+                    name=node.name,
+                    type_hint=node.type_hint,
+                )
+            )
+            if selection_cpp_type is None:
+                selection_cpp_type = self._udt_target_cpp_type(
+                    target_name=node.name,
+                    type_hint=node.type_hint,
+                )
+            if selection_cpp_type is None:
+                selection_cpp_type = self._drawing_target_cpp_type(
+                    node.name,
+                    cpp_type,
+                )
             if not is_global_member:
-                cpp_type = self._type_for_decl(node)
                 default = self._default_for_type(cpp_type)
                 lines.append(f"{pad}{cpp_type} {safe} = {default};")
+                remember_local_type(cpp_type)
             indent = len(pad) // 4
-            self._visit_if_switch_expr(node.value, safe, lines, indent)
+            self._visit_if_switch_expr(
+                node.value,
+                safe,
+                lines,
+                indent,
+                target_cpp_type=selection_cpp_type,
+            )
             return
 
-        # UDT lvalue alias (BUG C): a local initialised from a user-defined-UDT
-        # var/global lvalue (or a ternary/switch of such lvalues) and then
-        # mutated through must ALIAS the global, not value-copy — Pine UDTs are
-        # reference types. Emit a C++ reference (non-rebinding) or pointer
-        # (rebinding) alias instead of the default copy.
-        if not is_global_member:
-            alias = self._udt_local_alias_kind(node)
-            if alias is not None:
-                kind, udt_t = alias
-                if kind == "ref":
-                    cpp_val = self._visit_rhs_value(node.value, node.name, target_cpp_type=udt_t)
-                    lines.append(f"{pad}{udt_t}& {safe} = {cpp_val};")
-                    return
-                # Pointer alias: take address of each selected lvalue; subsequent
-                # field access lowers to ``->`` and rebinds to ``&(other)``.
-                self._udt_ptr_alias_locals.add(node.name)
-                cpp_val = self._addr_of_udt_selection(node.value, node.name)
-                lines.append(f"{pad}{udt_t}* {safe} = {cpp_val};")
-                return
-
         # Collection lvalue alias (BUG 2): a local bound to an existing array /
         # map / matrix lvalue (or a ternary/switch selecting same-typed ones)
         # and later MUTATED through must ALIAS the member, not value-copy — Pine
@@ -444,6 +804,8 @@ class StmtVisitor:
         if not is_global_member:
             coll_spec = self._collection_lvalue_selection_spec(node.value)
             if coll_spec is not None and self._collection_local_must_alias(node):
+                cpp_type = self._type_spec_to_cpp(coll_spec)
+                cpp_val = self._visit_rhs_value(node.value, node.name, target_cpp_type=cpp_type)
                 # Register the local's collection kind so subsequent
                 # ``.size()/.get()/.unshift()`` dispatch resolves correctly.
                 self._collection_types[node.name] = coll_spec
@@ -453,30 +815,30 @@ class StmtVisitor:
                     self._map_vars.add(node.name)
                 elif coll_spec.kind == "matrix":
                     self._matrix_specs[node.name] = coll_spec
-                cpp_type = self._type_spec_to_cpp(coll_spec)
-                cpp_val = self._visit_rhs_value(node.value, node.name, target_cpp_type=cpp_type)
-                lines.append(f"{pad}{cpp_type}& {safe} = {cpp_val};")
+                # PineMap is itself a shared-ID handle. Copying it by value is
+                # the correct alias operation and, unlike a C++ reference,
+                # keeps a later local rebind local. Arrays/matrices still need
+                # their established reference alias route.
+                ref = "" if coll_spec.kind == "map" else "&"
+                lines.append(f"{pad}{cpp_type}{ref} {safe} = {cpp_val};")
                 return
 
-        # Global-scope UDT array-element alias (BUG: Pine array elements of a
-        # user-defined type are references). A global loop-local bound from
-        # ``arr.get(i)`` and later field-mutated must ALIAS the element so the
-        # mutation writes back into the array. Emit a fresh per-iteration
-        # ``UDT& z = arr[i];`` reference (any hoisted class member was
-        # suppressed) — identical to the non-hoisted function-local alias path.
-        # Gated by _register_udt_array_get_ref_locals (which only records global-
-        # scope names); the ``_current_func_body is None`` guard confines this to
-        # global scope, so a function-local sharing the name keeps its own path.
-        if (node.name in self._udt_array_get_ref_locals
-                and getattr(self, "_current_func_body", None) is None):
-            udt_t = self._udt_var_types.get(node.name)
-            cpp_val = self._visit_rhs_value(node.value, node.name, target_cpp_type=udt_t)
-            lines.append(f"{pad}{udt_t}& {safe} = {cpp_val};")
-            return
-
         # General declaration
         cpp_type = self._type_for_decl(node) if not is_global_member else None
-        cpp_val = self._visit_rhs_value(node.value, node.name, target_cpp_type=cpp_type)
+        target_cpp_type = cpp_type or self._nullable_collection_target_cpp_type(
+            name=node.name,
+            type_hint=node.type_hint,
+        )
+        if target_cpp_type is None:
+            target_cpp_type = self._udt_target_cpp_type(
+                target_name=node.name,
+                type_hint=node.type_hint,
+            )
+        cpp_val = self._visit_rhs_value(
+            node.value,
+            node.name,
+            target_cpp_type=target_cpp_type,
+        )
         if is_global_member:
             lines.append(f"{pad}{safe} = {cpp_val};")
         else:
@@ -502,20 +864,124 @@ class StmtVisitor:
             return f"std::fmod((double)({target_read}), (double)({val_cpp}))"
         return None
 
+    def _matrix_rhs_specs(self, value: ASTNode | None) -> list[TypeSpec]:
+        """Return every known concrete matrix type in an RHS selection.
+
+        ``_type_spec_from_expr`` intentionally returns ``None`` for a
+        selection whose concrete arms disagree.  Reassignment validation must
+        still inspect those arms individually: otherwise
+        ``matrix<int> := cond ? matrix<int> : matrix<float>`` evades the type
+        check precisely because the complete selection has no unified type.
+        Explicit and implicit ``na`` arms contribute no concrete type.
+        """
+        if self._selection_node_is_na(value):
+            return []
+        if isinstance(value, Ternary):
+            return (
+                self._matrix_rhs_specs(value.true_val)
+                + self._matrix_rhs_specs(value.false_val)
+            )
+        if isinstance(value, IfStmt):
+            return (
+                self._matrix_rhs_specs(
+                    self._selection_terminal_expr(value.body)
+                )
+                + self._matrix_rhs_specs(
+                    self._selection_terminal_expr(value.else_body)
+                )
+            )
+        if isinstance(value, SwitchStmt):
+            specs: list[TypeSpec] = []
+            for _case_expr, case_body in value.cases:
+                specs.extend(
+                    self._matrix_rhs_specs(
+                        self._selection_terminal_expr(case_body)
+                    )
+                )
+            specs.extend(
+                self._matrix_rhs_specs(
+                    self._selection_terminal_expr(value.default_body)
+                )
+            )
+            return specs
+        spec = self._type_spec_from_expr(value)
+        return [spec] if spec is not None and spec.kind == "matrix" else []
+
+    def _validate_matrix_reassignment(
+        self,
+        node: Assignment,
+        target_name: str | None,
+    ) -> None:
+        """Reject any known matrix RHS whose element type changes the LHS.
+
+        This check belongs to the lexical target rather than any particular
+        storage representation. A matrix may be a persistent ``var``, a plain
+        global member, a callable local, or a UDT field, but Pine forbids
+        changing its declared element type in every case.
+        """
+        if node.op != ":=":
+            return
+        target_spec = self._type_spec_from_expr(node.target)
+        if target_spec is None and target_name is not None:
+            target_spec = self._collection_spec_for_name(target_name)
+        if target_spec is None or target_spec.kind != "matrix":
+            return
+        target_label = target_name
+        if target_label is None and isinstance(node.target, MemberAccess):
+            target_label = node.target.member
+        target_label = target_label or "<expression>"
+        for rhs_spec in self._matrix_rhs_specs(node.value):
+            if rhs_spec.element == target_spec.element:
+                continue
+            self._codegen_error(
+                node,
+                f"matrix '{target_label}' element type mismatch on reassignment: "
+                f"expected {self._type_spec_to_cpp(target_spec)}, "
+                f"got {self._type_spec_to_cpp(rhs_spec)}",
+            )
+
     def _visit_assignment(self, node: Assignment, lines: list[str], pad: str) -> None:
         if isinstance(node.value, FuncCall) and self._is_skip_expr(node.value):
             return
 
+        # Validate against the active lexical target before any syntax-specific
+        # early return. In particular, if/switch expressions and UDT-field
+        # targets otherwise bypass the ordinary identifier assignment path.
+        target_name = self._get_target_name(node.target)
+        self._validate_matrix_reassignment(node, target_name)
+
         # If/switch expression in assignment: x := if cond ...
         if isinstance(node.value, (IfStmt, SwitchStmt)):
-            target_name = self._get_target_name(node.target)
-            safe = self._safe_name(target_name) if target_name else self._visit_expr(node.target)
+            safe = (
+                self._safe_name(target_name)
+                if target_name
+                else self._visit_mutable_expr(node.target)
+            )
+            selection_cpp_type = self._nullable_collection_target_cpp_type(
+                name=target_name,
+                target_node=node.target if target_name is None else None,
+            )
+            if selection_cpp_type is None:
+                selection_cpp_type = self._udt_target_cpp_type(
+                    target_name=target_name,
+                    target_node=node.target if target_name is None else None,
+                )
+            if selection_cpp_type is None:
+                selection_cpp_type = self._drawing_target_cpp_type(
+                    target_name,
+                    None,
+                )
             indent = len(pad) // 4
-            self._visit_if_switch_expr(node.value, safe, lines, indent)
+            self._visit_if_switch_expr(
+                node.value,
+                safe,
+                lines,
+                indent,
+                target_cpp_type=selection_cpp_type,
+            )
             return
 
         # Get target name
-        target_name = self._get_target_name(node.target)
         if target_name is None:
             # Assignment to a UDT field that was dropped from the emitted
             # struct because it had a drawing-only type (label/line/box/
@@ -533,8 +999,17 @@ class StmtVisitor:
                 )
                 return
             # General expression target (e.g., member access)
-            target_cpp = self._visit_expr(node.target)
-            val_cpp = self._visit_expr(node.value)
+            target_cpp = self._visit_mutable_expr(node.target)
+            target_cpp_type = self._nullable_collection_target_cpp_type(
+                target_node=node.target,
+            )
+            if target_cpp_type is None:
+                target_cpp_type = self._udt_target_cpp_type(
+                    target_node=node.target,
+                )
+            val_cpp = self._visit_rhs_value(
+                node.value, target_cpp_type=target_cpp_type
+            )
             if node.op == ":=":
                 lines.append(f"{pad}{target_cpp} = {val_cpp};")
             else:
@@ -550,14 +1025,15 @@ class StmtVisitor:
         if self._active_var_remap and safe in self._active_var_remap:
             safe = self._active_var_remap[safe]
 
-        # Pointer-aliased UDT local (BUG C, rebinding case): ``p := other``
-        # rebinds the pointer to the address of the newly selected UDT lvalue.
-        if target_name in self._udt_ptr_alias_locals and node.op == ":=":
-            lines.append(f"{pad}{safe} = {self._addr_of_udt_selection(node.value, target_name)};")
-            return
-
-        if target_name in self.ctx.series_vars:
-            val_cpp = self._visit_expr(node.value)
+        if self._binding_is_series(target_name, safe):
+            val_cpp = self._visit_rhs_value(
+                node.value,
+                target_name,
+                target_cpp_type=self._drawing_target_cpp_type(
+                    target_name,
+                    None,
+                ),
+            )
             if node.op == ":=":
                 lines.append(f"{pad}{safe}.update({val_cpp});")
             else:
@@ -570,26 +1046,17 @@ class StmtVisitor:
                     op_char = node.op[0]  # e.g., "+" from "+="
                     lines.append(f"{pad}{safe}.update({safe}[0] {op_char} {val_cpp});")
         elif target_name in self._var_names:
-            if node.op == ":=" and target_name in self._matrix_specs and isinstance(node.value, FuncCall):
-                rhs_fn, rhs_ns = self._resolve_callee(node.value.callee)
-                rhs_spec = None
-                if rhs_ns == "matrix" and rhs_fn == "new":
-                    targs = self._template_args_from_call(node.value) if hasattr(node.value, "annotations") else []
-                    elem = self._type_spec_from_hint_name(targs[0]) if targs else TypeSpec.primitive("float")
-                    rhs_spec = TypeSpec.matrix(elem)
-                elif rhs_ns == "matrix" and rhs_fn in MATRIX_RETURNING_METHODS:
-                    rcv = self._extract_receiver_name(node.value)
-                    rhs_spec = self._matrix_specs.get(rcv)
-                if rhs_spec is not None:
-                    lhs_spec = self._matrix_specs[target_name]
-                    if rhs_spec.element != lhs_spec.element:
-                        self._codegen_error(
-                            node,
-                            f"matrix '{target_name}' element type mismatch on reassignment: "
-                            f"expected {self._type_spec_to_cpp(lhs_spec)}, "
-                            f"got {self._type_spec_to_cpp(rhs_spec)}",
-                        )
-            val_cpp = self._visit_rhs_value(node.value, target_name)
+            # A bare-``na`` reassignment must adopt the target's declared scalar
+            # type (``x := na`` -> ``na<int>()`` not ``na<double>()``); otherwise
+            # a double NaN is stored into an int/int64_t/bool member (UB, defeats
+            # is_na<T>()). Only computed for bare na — every other RHS is
+            # unaffected.
+            tct = self._nullable_collection_target_cpp_type(name=target_name)
+            if tct is None:
+                tct = self._udt_target_cpp_type(target_name=target_name)
+            if tct is None and self._is_na_expr(node.value):
+                tct = self._na_reassign_cpp_type(target_name)
+            val_cpp = self._visit_rhs_value(node.value, target_name, target_cpp_type=tct)
             if node.op == ":=":
                 lines.append(f"{pad}{safe} = {val_cpp};")
             else:
@@ -599,7 +1066,12 @@ class StmtVisitor:
                 else:
                     lines.append(f"{pad}{safe} {node.op} {val_cpp};")
         else:
-            val_cpp = self._visit_rhs_value(node.value, target_name)
+            tct = self._nullable_collection_target_cpp_type(name=target_name)
+            if tct is None:
+                tct = self._udt_target_cpp_type(target_name=target_name)
+            if tct is None and self._is_na_expr(node.value):
+                tct = self._na_reassign_cpp_type(target_name)
+            val_cpp = self._visit_rhs_value(node.value, target_name, target_cpp_type=tct)
             if node.op == ":=":
                 lines.append(f"{pad}{safe} = {val_cpp};")
             else:
@@ -610,6 +1082,143 @@ class StmtVisitor:
                     lines.append(f"{pad}{safe} {node.op} {val_cpp};")
 
     def _visit_tuple_assign(self, node: TupleAssign, lines: list[str], pad: str) -> None:
+        is_top_level = any(id(node) == id(stmt) for stmt in self.ctx.ast.body)
+        global_targets = (
+            set(getattr(self.ctx, "ordinary_global_binding_names", set()))
+            & self._qualified_func_var_raw_names
+            if is_top_level
+            else set()
+        )
+        security_result_fields: list[str] | None = None
+
+        # Exact supported request.security tuples are authoritative Program
+        # globals: a later UDF reads their class-member storage, so a local
+        # structured binding would shadow the members with fresh values while
+        # leaving the UDF-visible state stale. Keep this narrow to security
+        # tuples whose analyzer metadata proves a supported helper family, an
+        # exact direct literal, or a known TA tuple result. Ordinary
+        # non-security heterogeneous tuples retain their established local
+        # destructuring behavior.
+        if is_top_level and isinstance(node.value, FuncCall):
+            func_name, namespace = self._resolve_callee(node.value.callee)
+            if namespace == "request" and func_name == "security":
+                param_names = [
+                    "symbol", "timeframe", "expression", "gaps",
+                    "lookahead", "ignore_invalid_symbol", "currency",
+                ]
+                all_args = list(node.value.args)
+                for idx, param_name in enumerate(param_names):
+                    if param_name in node.value.kwargs:
+                        while len(all_args) <= idx:
+                            all_args.append(None)
+                        all_args[idx] = node.value.kwargs[param_name]
+                expr_node = all_args[2] if len(all_args) > 2 else None
+                info = next(
+                    (
+                        item
+                        for item in self._security_calls
+                        if not item.get("is_lower_tf_array")
+                        and item.get("expr_node") is expr_node
+                    ),
+                    None,
+                )
+                if info is not None:
+                    tuple_size = info.get("tuple_size", 0)
+                    tuple_types = tuple(
+                        info.get("tuple_element_types", ()) or ()
+                    )
+                    numeric_tuple = (
+                        tuple_size >= 2
+                        and len(tuple_types) == tuple_size
+                        and all(
+                            item in (PineType.INT, PineType.FLOAT)
+                            for item in tuple_types
+                        )
+                    )
+                    bool_tuple = (
+                        tuple_size >= 2
+                        and len(tuple_types) == tuple_size
+                        and all(item == PineType.BOOL for item in tuple_types)
+                    )
+                    exact_direct_tuple = (
+                        isinstance(expr_node, TupleLiteral)
+                        and tuple_size >= 2
+                        and len(tuple_types) == tuple_size
+                        and all(
+                            item in (
+                                PineType.INT,
+                                PineType.FLOAT,
+                                PineType.BOOL,
+                            )
+                            for item in tuple_types
+                        )
+                    )
+                    ta_site = self._get_ta_site(expr_node)
+                    known_ta_tuple = (
+                        ta_site is not None
+                        and self._ta_name_from_site(ta_site) in TA_TUPLE_FIELDS
+                    )
+                    if known_ta_tuple:
+                        security_result_fields = TA_TUPLE_FIELDS[
+                            self._ta_name_from_site(ta_site)
+                        ]
+                    if (
+                        numeric_tuple
+                        or bool_tuple
+                        or exact_direct_tuple
+                        or known_ta_tuple
+                    ):
+                        global_targets.update(
+                            name for name in node.names if name != "_"
+                        )
+
+        def emit_call_tuple(call_expr: str) -> None:
+            """Destructure once, routing exact history elements to Series.
+
+            A structured binding always creates scalar C++ locals, which would
+            shadow the class Series storage required by a later ``x[n]`` read.
+            It also cannot assign an existing top-level class member. Materialize
+            the tuple once whenever either case applies; ordinary lexical scalar
+            elements remain locals, Series elements advance their remapped
+            members, and top-level scalars assign their class storage.
+            """
+            series_names = {
+                name
+                for name in node.names
+                if name != "_"
+                and self._decl_binding_is_series(id(node), name)
+            }
+            if not series_names and not global_targets.intersection(node.names):
+                binding_names = ", ".join(node.names)
+                lines.append(f"{pad}auto [{binding_names}] = {call_expr};")
+                return
+
+            temp = f"_tuple_result_{self._tuple_assign_counter}"
+            self._tuple_assign_counter += 1
+            lines.append(f"{pad}auto {temp} = {call_expr};")
+            for idx, name in enumerate(node.names):
+                if name == "_":
+                    continue
+                value = (
+                    f"{temp}.{security_result_fields[idx]}"
+                    if (
+                        security_result_fields is not None
+                        and idx < len(security_result_fields)
+                    )
+                    else f"std::get<{idx}>({temp})"
+                )
+                safe = self._safe_name(name)
+                if name in series_names:
+                    if safe in self._active_var_remap:
+                        safe = self._active_var_remap[safe]
+                    self._emit_history_series_write(
+                        lines, pad, safe, value
+                    )
+                elif name in global_targets:
+                    lines.append(f"{pad}{safe} = {value};")
+                else:
+                    lines.append(f"{pad}auto {safe} = {value};")
+
         site = self._get_ta_site(node.value)
         if site is not None:
             compute_args = self._ta_compute_args_for_site(site)
@@ -637,11 +1246,17 @@ class StmtVisitor:
                     # fresh ``double`` local would shadow the member and make
                     # ``dir[n]`` a scalar subscript (clang error). Non-series
                     # destructured names keep the plain scalar declaration.
-                    if name in self.ctx.series_vars:
+                    if self._decl_binding_is_series(id(node), name):
                         safe = self._safe_name(name)
+                        if safe in self._active_var_remap:
+                            safe = self._active_var_remap[safe]
                         self._emit_history_series_write(
                             lines, pad, safe, field_expr
                         )
+                    elif name in global_targets:
+                        lines.append(
+                            f"{pad}{self._safe_name(name)} = {field_expr};"
+                        )
                     else:
                         lines.append(f"{pad}double {name} = {field_expr};")
             return
@@ -650,14 +1265,12 @@ class StmtVisitor:
         if isinstance(node.value, FuncCall):
             func_name, namespace = self._resolve_callee(node.value.callee)
             if namespace == "request" and func_name == "security":
-                binding_names = ", ".join(n for n in node.names if n != "_")
                 call_expr = self._visit_func_call(node.value)
-                lines.append(f"{pad}auto [{binding_names}] = {call_expr};")
+                emit_call_tuple(call_expr)
                 return
             if func_name and namespace is None and func_name in self._func_names:
-                binding_names = ", ".join(node.names)
                 call_expr = self._visit_func_call(node.value)
-                lines.append(f"{pad}auto [{binding_names}] = {call_expr};")
+                emit_call_tuple(call_expr)
                 return
 
             # UDT instance method returning a tuple: ``[a, b, c] = receiver.method(...)``.
@@ -673,64 +1286,188 @@ class StmtVisitor:
             callee = node.value.callee
             if isinstance(callee, MemberAccess):
                 recv_spec = self._type_spec_from_expr(callee.object)
-                if recv_spec is not None and recv_spec.kind == "udt" and recv_spec.name:
-                    method_key = f"{recv_spec.name}.{callee.member}"
+                receiver_name = method_receiver_type_name(recv_spec)
+                if receiver_name is not None:
+                    method_key = f"{receiver_name}.{callee.member}"
                     fi_u = self._func_info_map.get(method_key)
                     if (fi_u is not None
                             and getattr(fi_u, "is_udt_method", False)
                             and getattr(fi_u, "returns_tuple", False)):
-                        binding_names = ", ".join(node.names)
                         call_expr = self._visit_func_call(node.value)
-                        lines.append(f"{pad}auto [{binding_names}] = {call_expr};")
+                        emit_call_tuple(call_expr)
                         return
 
         lines.append(f"{pad}/* unsupported tuple assignment */")
 
-    def _push_block_var_remap(self, node):
-        """Activate block-scoped var renames for ``node`` (BUG 1). Returns the
-        previous ``_active_var_remap`` to restore (or ``_NO_BLOCK_REMAP`` if this
-        block owns no renames). Renames are MERGED over the inherited remap so
-        nested blocks keep any enclosing func-clone / outer-block mapping."""
-        renames = self._block_var_renames.get(id(node))
-        if not renames:
-            return _NO_BLOCK_REMAP
-        saved = self._active_var_remap
-        self._active_var_remap = {**saved, **renames}
-        return saved
+    def _tuple_binding_cpp_types(self, node: TupleAssign) -> list[str]:
+        """Exact supported tuple element types for later lexical operations."""
+        count = len(node.names)
+        if not isinstance(node.value, FuncCall):
+            return ["double"] * count
+        func_name, namespace = self._resolve_callee(node.value.callee)
+        fi = None
+        if namespace is None:
+            fi = self._func_info_map.get(func_name)
+        elif isinstance(node.value.callee, MemberAccess):
+            recv_spec = self._type_spec_from_expr(node.value.callee.object)
+            receiver_name = method_receiver_type_name(recv_spec)
+            if receiver_name is not None:
+                fi = self._func_info_map.get(
+                    f"{receiver_name}.{node.value.callee.member}"
+                )
+        if (fi is not None
+                and fi.node is not None
+                and getattr(fi, "returns_tuple", False)):
+            return self._infer_tuple_types(fi.node, count)
+        return ["double"] * count
+
+    def _push_block_var_remap(self, owner):
+        """Activate exact lexical metadata for one branch/loop body.
+
+        Persistent-var renames use copy-on-write and activate only after their
+        declarations. Collection registries likewise use copy-on-write and
+        declarations activate their bindings in
+        source order, and block exit restores the outer state. Thus a sibling
+        block can reuse the same raw name without either pre-shadowing earlier
+        statements or controlling dispatch in the other branch.
+        """
+        previous_map_visible = getattr(
+            self, "_block_map_binding_visible", False
+        )
+        previous_map_depth = getattr(self, "_block_map_visibility_depth", 0)
+        self._block_map_visibility_depth = previous_map_depth + 1
+        saved_drawing_types = self._lexical_drawing_types
+        self._lexical_drawing_types = dict(saved_drawing_types)
+        saved_udt_types = self._lexical_udt_types
+        self._lexical_udt_types = dict(saved_udt_types)
+        saved_series_bindings = self._lexical_series_bindings
+        self._lexical_series_bindings = dict(saved_series_bindings)
+        saved_known_tombstones = self._lexical_known_var_tombstones
+        self._lexical_known_var_tombstones = set(
+            saved_known_tombstones
+        )
 
-    def _pop_block_var_remap(self, saved) -> None:
-        if saved is not _NO_BLOCK_REMAP:
-            self._active_var_remap = saved
+        renames = self._block_var_renames.get(id(owner))
+        collection_specs = self._block_collection_types.get(id(owner))
+        if not renames and collection_specs is None:
+            return (
+                _NO_BLOCK_REMAP,
+                None,
+                previous_map_visible,
+                previous_map_depth,
+                saved_drawing_types,
+                saved_udt_types,
+                saved_series_bindings,
+                saved_known_tombstones,
+            )
+        saved_remap = self._active_var_remap
+        if renames:
+            # Do not pre-shadow an outer binding at block entry.  _visit_stmt
+            # installs each exact rename immediately after that VarDecl's RHS.
+            self._active_var_remap = dict(saved_remap)
+
+        saved_collections = None
+        if collection_specs is not None:
+            saved_collections = (
+                self._current_func_collection_specs,
+                self._current_func_collection_shadows,
+                self._collection_types,
+                self._array_vars,
+                self._map_vars,
+                self._matrix_specs,
+            )
+            self._current_func_collection_specs = dict(
+                self._current_func_collection_specs
+            )
+            self._current_func_collection_shadows = set(
+                self._current_func_collection_shadows
+            )
+            self._collection_types = dict(self._collection_types)
+            self._array_vars = set(self._array_vars)
+            self._map_vars = set(self._map_vars)
+            self._matrix_specs = dict(self._matrix_specs)
+        return (
+            saved_remap,
+            saved_collections,
+            previous_map_visible,
+            previous_map_depth,
+            saved_drawing_types,
+            saved_udt_types,
+            saved_series_bindings,
+            saved_known_tombstones,
+        )
 
-    def _visit_if(self, node: IfStmt, lines: list[str], indent: int) -> None:
-        _blk_saved = self._push_block_var_remap(node)
+    def _pop_block_var_remap(self, saved) -> None:
+        (
+            saved_remap,
+            saved_collections,
+            previous_map_visible,
+            previous_map_depth,
+            saved_drawing_types,
+            saved_udt_types,
+            saved_series_bindings,
+            saved_known_tombstones,
+        ) = saved
         try:
-            self._visit_if_body(node, lines, indent)
+            if saved_remap is not _NO_BLOCK_REMAP:
+                self._active_var_remap = saved_remap
+                if saved_collections is not None:
+                    (
+                        self._current_func_collection_specs,
+                        self._current_func_collection_shadows,
+                        self._collection_types,
+                        self._array_vars,
+                        self._map_vars,
+                        self._matrix_specs,
+                    ) = saved_collections
         finally:
-            self._pop_block_var_remap(_blk_saved)
+            self._lexical_drawing_types = saved_drawing_types
+            self._lexical_udt_types = saved_udt_types
+            self._lexical_series_bindings = saved_series_bindings
+            self._lexical_known_var_tombstones = saved_known_tombstones
+            self._block_map_binding_visible = previous_map_visible
+            self._block_map_visibility_depth = previous_map_depth
+
+    def _visit_block_statements(self, body: list, lines: list[str],
+                                indent: int) -> None:
+        """Emit one lexical branch/loop body with its exact var remap."""
+        saved = self._push_block_var_remap(body)
+        try:
+            for stmt in body:
+                self._visit_stmt(stmt, lines, indent)
+        finally:
+            self._pop_block_var_remap(saved)
+
+    def _emit_block_with_assign(
+        self,
+        body: list,
+        target: str,
+        lines: list[str],
+        indent: int,
+        target_cpp_type: str | None = None,
+    ) -> None:
+        """Expression-body counterpart of :meth:`_visit_block_statements`."""
+        saved = self._push_block_var_remap(body)
+        try:
+            self._emit_body_with_assign(
+                body,
+                target,
+                lines,
+                indent,
+                target_cpp_type=target_cpp_type,
+            )
+        finally:
+            self._pop_block_var_remap(saved)
+
+    def _visit_if(self, node: IfStmt, lines: list[str], indent: int) -> None:
+        self._visit_if_body(node, lines, indent)
 
     def _visit_if_body(self, node: IfStmt, lines: list[str], indent: int) -> None:
         pad = "    " * indent
 
-        # TA hoisting: inside per-call-site function variants, execute ALL
-        # statements unconditionally (PineScript execution model) but wrap
-        # the result assignment in the condition.
-        if self._in_ta_func_variant and self._if_body_has_ta(node.body):
-            cond = self._visit_expr(node.condition)
-            self._hoist_if_body(node.body, cond, lines, pad, indent)
-            # Handle else_body similarly
-            if node.else_body:
-                if len(node.else_body) == 1 and isinstance(node.else_body[0], IfStmt):
-                    self._visit_if(node.else_body[0], lines, indent)
-                else:
-                    neg_cond = f"!({cond})"
-                    self._hoist_if_body(node.else_body, neg_cond, lines, pad, indent)
-            return
-
         cond = self._visit_expr(node.condition)
         lines.append(f"{pad}if ({cond}) {{")
-        for s in node.body:
-            self._visit_stmt(s, lines, indent + 1)
+        self._visit_block_statements(node.body, lines, indent + 1)
         lines.append(f"{pad}}}")
         if node.else_body:
             if len(node.else_body) == 1 and isinstance(node.else_body[0], IfStmt):
@@ -738,8 +1475,9 @@ class StmtVisitor:
                 self._visit_if(node.else_body[0], lines, indent)
             else:
                 lines[-1] = f"{pad}}} else {{"
-                for s in node.else_body:
-                    self._visit_stmt(s, lines, indent + 1)
+                self._visit_block_statements(
+                    node.else_body, lines, indent + 1
+                )
                 lines.append(f"{pad}}}")
 
     def _visit_for(self, node: ForStmt, lines: list[str], indent: int) -> None:
@@ -760,8 +1498,24 @@ class StmtVisitor:
         e_var = f"_for_end_{fid}"
         step_var = f"_for_step_{fid}"
         down_var = f"_for_down_{fid}"
+        end_mentions_binder = bool(
+            node.var
+            and any(
+                isinstance(part, Identifier) and part.name == node.var
+                for part in self._walk_ast(node.end)
+            )
+        )
+        end_eval = f"_for_end_eval_{fid}" if end_mentions_binder else None
+        if end_eval is not None:
+            # The ``to`` expression is authored outside the loop-binder scope,
+            # but its refresh executes inside the generated C++ ``for`` where
+            # the binder would shadow a same-named outer member/parameter. A
+            # pre-binder lambda preserves the authored lexical binding while
+            # still reevaluating the expression after every iteration.
+            lines.append(f"{pad}auto {end_eval} = [&]() {{ return ({end}); }};")
         lines.append(f"{pad}int {s_var} = ({start});")
-        lines.append(f"{pad}int {e_var} = ({end});")
+        end_expr = f"{end_eval}()" if end_eval is not None else f"({end})"
+        lines.append(f"{pad}int {e_var} = {end_expr};")
         lines.append(f"{pad}int {step_var} = ({step});")
         lines.append(f"{pad}if ({step_var} < 0) {step_var} = -{step_var};")
         lines.append(f"{pad}if ({step_var} == 0) {step_var} = 1;")
@@ -769,47 +1523,35 @@ class StmtVisitor:
         lines.append(
             f"{pad}for (int {var} = {s_var}; "
             f"({down_var} ? ({var} >= {e_var}) : ({var} <= {e_var})); "
-            f"{var} += ({down_var} ? -{step_var} : {step_var}), {e_var} = ({end})) {{"
+            f"{var} += ({down_var} ? -{step_var} : {step_var}), "
+            f"{e_var} = {end_expr}) {{"
         )
         # Register the loop counter so reads of it inside the body resolve (the
         # unknown-identifier guard in _visit_ident would otherwise flag it).
         saved_loop = self._current_loop_vars
+        saved_loop_specs = self._current_loop_var_specs
         self._current_loop_vars = set(self._current_loop_vars)
+        self._current_loop_var_specs = dict(self._current_loop_var_specs)
         if node.var:
             self._current_loop_vars.add(node.var)
+            self._current_loop_var_specs[node.var] = TypeSpec.primitive("int")
         _blk_saved = self._push_block_var_remap(node)
+        if node.var:
+            # The loop counter is a fresh primitive lexical binding.  Keep it
+            # from inheriting a same-spelled outer/raw UDT or drawing type.
+            self._lexical_drawing_types[node.var] = None
+            self._lexical_udt_types[node.var] = None
+            self._lexical_series_bindings[node.var] = False
+            self._lexical_known_var_tombstones.add(node.var)
         try:
             for s in node.body:
                 self._visit_stmt(s, lines, indent + 1)
         finally:
             self._pop_block_var_remap(_blk_saved)
         self._current_loop_vars = saved_loop
+        self._current_loop_var_specs = saved_loop_specs
         lines.append(f"{pad}}}")
 
-    def _loop_elem_is_writeback_udt(self, iterable) -> bool:
-        """Whether a ``for x in coll`` loop variable must bind by reference.
-
-        In Pine a ``for x in arr`` loop variable over an array of *user-defined
-        objects* is a reference to the element — field writes (``x.f := v``)
-        mutate the array in place — whereas over a primitive array it is a
-        copy. So emit C++ ``auto&`` only for arrays whose element is a
-        user-defined UDT struct. Primitive elements keep ``auto`` (Pine copy
-        semantics: writing the loop var must NOT write back). Drawing handles
-        (line/box/label/linefill/...) also keep ``auto``: their element type
-        name is a builtin, not in ``_udt_defs``, and a handle copy already
-        mutates the shared engine object. (Reassigning the loop var itself —
-        ``x := ...`` — is not modelled by either form, but Pine forbids it for
-        objects in practice and it does not occur in the corpus.)
-        """
-        spec = self._type_spec_from_expr(iterable)
-        return (
-            spec is not None
-            and spec.kind == "array"
-            and spec.element is not None
-            and spec.element.kind == "udt"
-            and spec.element.name in self._udt_defs
-        )
-
     def _visit_for_in(self, node, lines: list[str], indent: int) -> None:
         pad = "    " * indent
         iterable = self._visit_expr(node.iterable)
@@ -828,17 +1570,123 @@ class StmtVisitor:
             if elem_spec is not None:
                 self._current_loop_var_specs[node.var] = elem_spec
         if node.vars:
-            for v in node.vars:
+            tuple_specs: list[TypeSpec | None] = []
+            if iterable_spec is not None and iterable_spec.kind == "map":
+                tuple_specs = [iterable_spec.key, iterable_spec.value]
+            for idx, v in enumerate(node.vars):
                 if v != "_":
                     self._current_loop_vars.add(v)
+                    if (idx < len(tuple_specs)
+                            and tuple_specs[idx] is not None):
+                        self._current_loop_var_specs[v] = tuple_specs[idx]
+        map_pair_loop = (
+            iterable_spec is not None
+            and iterable_spec.kind == "map"
+            and node.vars is not None
+            and len(node.vars) == 2
+        )
         if node.var:
             v_cpp = self._safe_name(node.var)
-            ref = "&" if self._loop_elem_is_writeback_udt(node.iterable) else ""
-            lines.append(f"{pad}for (auto{ref} {v_cpp} : {iterable}) {{")
+            # User UDT elements are numeric object-ID handles.  Copying the
+            # loop binding preserves Pine semantics: field writes still reach
+            # the shared arena record, while rebinding the loop variable does
+            # not overwrite the array slot.  Primitive elements use the same
+            # value-binding rule.
+            lines.append(f"{pad}for (auto {v_cpp} : {iterable}) {{")
+        elif map_pair_loop:
+            # Pine map iteration exposes insertion-ordered ``[key, value]``
+            # pairs. PineMap intentionally keeps its storage private, so take
+            # one handle copy (which aliases the same map ID), iterate keys(),
+            # and obtain each value through the public API. Binding the
+            # iterable once also preserves single-evaluation semantics for an
+            # arbitrary map-producing expression.
+            key_name, value_name = node.vars
+            authored_names = (
+                set(self._all_bound_names)
+                | set(self._func_names)
+                | set(self._udt_defs)
+            )
+            occupied_names = authored_names | {
+                self._safe_name(name) for name in authored_names
+            } | {
+                self._func_safe_name(name) for name in self._func_names
+            }
+            # Parameters are not statement bindings, so they are absent from
+            # ``_all_bound_names``.  Include both their authored and C++-safe
+            # spellings before minting loop temporaries; otherwise a legal UDF
+            # or method parameter named ``__pf_map_iter_0`` (or, for ``_`` key
+            # loops, ``__pf_map_key_0``) is redeclared and then shadowed by the
+            # generated loop machinery.
+            active_params = set(self._current_func_param_types)
+            occupied_names.update(active_params)
+            occupied_names.update(
+                self._safe_name(name) for name in active_params
+            )
+            while True:
+                fid = self._for_counter
+                self._for_counter += 1
+                map_token = f"__pf_map_iter_{fid}"
+                internal_key = f"__pf_map_key_{fid}"
+                generated_names = {map_token}
+                if key_name == "_":
+                    generated_names.add(internal_key)
+                if not (generated_names & occupied_names):
+                    break
+            key_cpp = (
+                self._safe_name(key_name)
+                if key_name != "_"
+                else internal_key
+            )
+            lines.append(f"{pad}auto {map_token} = {iterable};")
+            lines.append(f"{pad}for (auto {key_cpp} : {map_token}.keys()) {{")
+            if value_name != "_":
+                value_cpp = self._safe_name(value_name)
+                lines.append(
+                    f"{pad}    auto {value_cpp} = {map_token}.get({key_cpp});"
+                )
         elif node.vars:
             bindings = ", ".join(node.vars)
             lines.append(f"{pad}for (auto [{bindings}] : {iterable}) {{")
         _blk_saved = self._push_block_var_remap(node)
+        loop_binding_names = (
+            [node.var] if node.var else list(node.vars or [])
+        )
+        loop_binding_specs = (
+            [elem_spec]
+            if node.var
+            else [
+                tuple_specs[index] if index < len(tuple_specs) else None
+                for index in range(len(loop_binding_names))
+            ]
+        )
+        for index, name in enumerate(loop_binding_names):
+            if name and name != "_":
+                spec = (
+                    loop_binding_specs[index]
+                    if index < len(loop_binding_specs)
+                    else None
+                )
+                drawing_name = (
+                    spec.name
+                    if (spec is not None
+                        and spec.kind == "udt"
+                        and spec.name in DRAWING_TYPE_TO_CPP)
+                    else None
+                )
+                self._lexical_drawing_types[name] = (
+                    DRAWING_TYPE_TO_CPP[drawing_name]
+                    if drawing_name is not None
+                    else None
+                )
+                self._lexical_udt_types[name] = (
+                    spec.name
+                    if (spec is not None
+                        and spec.kind == "udt"
+                        and spec.name in self._udt_defs)
+                    else None
+                )
+                self._lexical_series_bindings[name] = False
+                self._lexical_known_var_tombstones.add(name)
         try:
             for s in node.body:
                 self._visit_stmt(s, lines, indent + 1)
@@ -870,22 +1718,21 @@ class StmtVisitor:
                 prefix = "if" if i == 0 else "else if"
                 case_val = self._visit_expr(case_expr)
                 lines.append(f"{pad}{prefix} ({expr_var} == {case_val}) {{")
-                for s in case_body:
-                    self._visit_stmt(s, lines, indent + 1)
+                self._visit_block_statements(case_body, lines, indent + 1)
                 lines.append(f"{pad}}}")
         else:
             for i, (case_expr, case_body) in enumerate(node.cases):
                 prefix = "if" if i == 0 else "else if"
                 cond = self._visit_expr(case_expr)
                 lines.append(f"{pad}{prefix} ({cond}) {{")
-                for s in case_body:
-                    self._visit_stmt(s, lines, indent + 1)
+                self._visit_block_statements(case_body, lines, indent + 1)
                 lines.append(f"{pad}}}")
 
         if node.default_body:
             lines.append(f"{pad}else {{")
-            for s in node.default_body:
-                self._visit_stmt(s, lines, indent + 1)
+            self._visit_block_statements(
+                node.default_body, lines, indent + 1
+            )
             lines.append(f"{pad}}}")
 
     # ------------------------------------------------------------------
@@ -894,8 +1741,14 @@ class StmtVisitor:
 
     # _default_for_type lives on TypeInferer — see codegen/types.py.
 
-    def _emit_body_with_assign(self, body: list, target: str,
-                               lines: list[str], indent: int) -> None:
+    def _emit_body_with_assign(
+        self,
+        body: list,
+        target: str,
+        lines: list[str],
+        indent: int,
+        target_cpp_type: str | None = None,
+    ) -> None:
         """Emit a body block where the last expression becomes an assignment."""
         if not body:
             return
@@ -912,36 +1765,93 @@ class StmtVisitor:
                     if self._call_is_void(stmt.expr):
                         self._visit_stmt(stmt, lines, indent)
                         return
-                    cpp = self._visit_expr(stmt.expr)
+                    cpp = self._visit_rhs_value(
+                        stmt.expr,
+                        target_cpp_type=target_cpp_type,
+                    )
                     pad = "    " * indent
                     lines.append(f"{pad}{target} = {cpp};")
                 elif isinstance(stmt, IfStmt):
                     # Nested if expression
-                    self._visit_if_switch_expr(stmt, target, lines, indent)
+                    self._visit_if_switch_expr(
+                        stmt,
+                        target,
+                        lines,
+                        indent,
+                        target_cpp_type=target_cpp_type,
+                    )
                 elif isinstance(stmt, SwitchStmt):
-                    self._visit_if_switch_expr(stmt, target, lines, indent)
+                    self._visit_if_switch_expr(
+                        stmt,
+                        target,
+                        lines,
+                        indent,
+                        target_cpp_type=target_cpp_type,
+                    )
                 else:
                     self._visit_stmt(stmt, lines, indent)
             else:
                 self._visit_stmt(stmt, lines, indent)
 
-    def _visit_if_switch_expr(self, node, target: str,
-                              lines: list[str], indent: int) -> None:
+    def _visit_if_switch_expr(
+        self,
+        node,
+        target: str,
+        lines: list[str],
+        indent: int,
+        target_cpp_type: str | None = None,
+    ) -> None:
         """Emit an if/switch used as an expression, assigning to target."""
         pad = "    " * indent
+        nullable_collection_target = self._is_nullable_collection_cpp_type(
+            target_cpp_type
+        )
+
+        def emit_implicit_na_fallback() -> None:
+            """Reset a nullable ID when an expression has no matching arm."""
+            lines.append(f"{pad}else {{")
+            lines.append(
+                f"{pad}    {target} = {target_cpp_type}{{}};"
+            )
+            lines.append(f"{pad}}}")
+
         if isinstance(node, IfStmt):
             cond = self._visit_expr(node.condition)
             lines.append(f"{pad}if ({cond}) {{")
-            self._emit_body_with_assign(node.body, target, lines, indent + 1)
+            self._emit_block_with_assign(
+                node.body,
+                target,
+                lines,
+                indent + 1,
+                target_cpp_type=target_cpp_type,
+            )
             lines.append(f"{pad}}}")
             if node.else_body:
                 if len(node.else_body) == 1 and isinstance(node.else_body[0], IfStmt):
                     lines[-1] = f"{pad}}} else"
-                    self._visit_if_switch_expr(node.else_body[0], target, lines, indent)
+                    self._visit_if_switch_expr(
+                        node.else_body[0],
+                        target,
+                        lines,
+                        indent,
+                        target_cpp_type=target_cpp_type,
+                    )
                 else:
                     lines[-1] = f"{pad}}} else {{"
-                    self._emit_body_with_assign(node.else_body, target, lines, indent + 1)
+                    self._emit_block_with_assign(
+                        node.else_body,
+                        target,
+                        lines,
+                        indent + 1,
+                        target_cpp_type=target_cpp_type,
+                    )
                     lines.append(f"{pad}}}")
+            elif nullable_collection_target:
+                # A Pine if-expression without an else evaluates to ``na`` on
+                # the unmatched path.  This assignment is essential for
+                # non-var globals and reassignments: retaining the prior bar's
+                # map/matrix ID would turn the expression into implicit state.
+                emit_implicit_na_fallback()
         elif isinstance(node, SwitchStmt):
             if node.expr:
                 expr_var = f"__switch_val_{self._switch_counter}"
@@ -951,16 +1861,50 @@ class StmtVisitor:
                     prefix = "if" if i == 0 else "else if"
                     case_val = self._visit_expr(case_expr)
                     lines.append(f"{pad}{prefix} ({expr_var} == {case_val}) {{")
-                    self._emit_body_with_assign(case_body, target, lines, indent + 1)
+                    self._emit_block_with_assign(
+                        case_body,
+                        target,
+                        lines,
+                        indent + 1,
+                        target_cpp_type=target_cpp_type,
+                    )
                     lines.append(f"{pad}}}")
             else:
                 for i, (case_expr, case_body) in enumerate(node.cases):
                     prefix = "if" if i == 0 else "else if"
                     cond = self._visit_expr(case_expr)
                     lines.append(f"{pad}{prefix} ({cond}) {{")
-                    self._emit_body_with_assign(case_body, target, lines, indent + 1)
+                    self._emit_block_with_assign(
+                        case_body,
+                        target,
+                        lines,
+                        indent + 1,
+                        target_cpp_type=target_cpp_type,
+                    )
                     lines.append(f"{pad}}}")
             if node.default_body:
-                lines.append(f"{pad}else {{")
-                self._emit_body_with_assign(node.default_body, target, lines, indent + 1)
-                lines.append(f"{pad}}}")
+                if node.cases:
+                    lines.append(f"{pad}else {{")
+                    self._emit_block_with_assign(
+                        node.default_body,
+                        target,
+                        lines,
+                        indent + 1,
+                        target_cpp_type=target_cpp_type,
+                    )
+                    lines.append(f"{pad}}}")
+                else:
+                    self._emit_block_with_assign(
+                        node.default_body,
+                        target,
+                        lines,
+                        indent,
+                        target_cpp_type=target_cpp_type,
+                    )
+            elif nullable_collection_target:
+                if node.cases:
+                    emit_implicit_na_fallback()
+                else:
+                    lines.append(
+                        f"{pad}{target} = {target_cpp_type}{{}};"
+                    )