@pilatos/bitbucket-cli 1.7.1 → 1.8.0

package/dist/index.js

@@ -45103,6 +45103,101 @@ class OutputService {
     return this.format(text, source_default.underline);
   }
 }
+// src/types/config.ts
+var SETTABLE_CONFIG_KEYS = [
+  "defaultWorkspace",
+  "skipVersionCheck",
+  "versionCheckInterval"
+];
+var READABLE_CONFIG_KEYS = [
+  "username",
+  "defaultWorkspace",
+  "skipVersionCheck",
+  "versionCheckInterval"
+];
+function isSettableConfigKey(key) {
+  return SETTABLE_CONFIG_KEYS.includes(key);
+}
+function isReadableConfigKey(key) {
+  return READABLE_CONFIG_KEYS.includes(key);
+}
+function parseBooleanLiteral(value) {
+  const normalized = value.trim().toLowerCase();
+  if (normalized === "true") {
+    return true;
+  }
+  if (normalized === "false") {
+    return false;
+  }
+  return;
+}
+function parsePositiveIntegerLiteral(value) {
+  const normalized = value.trim();
+  if (!/^[1-9]\d*$/.test(normalized)) {
+    return;
+  }
+  const parsed = Number.parseInt(normalized, 10);
+  if (!Number.isSafeInteger(parsed)) {
+    return;
+  }
+  return parsed;
+}
+function parseSettableConfigValue(key, value) {
+  switch (key) {
+    case "defaultWorkspace":
+      return value;
+    case "skipVersionCheck": {
+      const parsed = parseBooleanLiteral(value);
+      if (parsed === undefined) {
+        throw new Error("Invalid value for 'skipVersionCheck'. Expected 'true' or 'false'.");
+      }
+      return parsed;
+    }
+    case "versionCheckInterval": {
+      const parsed = parsePositiveIntegerLiteral(value);
+      if (parsed === undefined) {
+        throw new Error("Invalid value for 'versionCheckInterval'. Expected a positive integer (1 or greater).");
+      }
+      return parsed;
+    }
+  }
+}
+function coerceSkipVersionCheckValue(value) {
+  if (typeof value === "boolean") {
+    return value;
+  }
+  if (typeof value === "string") {
+    return parseBooleanLiteral(value);
+  }
+  return;
+}
+function coerceVersionCheckIntervalValue(value) {
+  if (typeof value === "number") {
+    if (!Number.isSafeInteger(value) || value < 1) {
+      return;
+    }
+    return value;
+  }
+  if (typeof value === "string") {
+    return parsePositiveIntegerLiteral(value);
+  }
+  return;
+}
+function normalizeReadableConfigValue(key, value) {
+  if (value === undefined || value === null) {
+    return;
+  }
+  switch (key) {
+    case "skipVersionCheck":
+      return coerceSkipVersionCheckValue(value);
+    case "versionCheckInterval":
+      return coerceVersionCheckIntervalValue(value);
+    case "username":
+    case "defaultWorkspace":
+      return typeof value === "string" ? value : undefined;
+  }
+}
+
 // src/services/version.service.ts
 var NPM_REGISTRY_URL = "https://registry.npmjs.org/@pilatos/bitbucket-cli";
 var PACKAGE_NAME = "@pilatos/bitbucket-cli";
@@ -45115,7 +45210,8 @@ class VersionService {
     this.currentVersion = currentVersion;
   }
   async checkForUpdate() {
-    const skipCheck = await this.configService.getValue("skipVersionCheck");
+    const skipCheckRaw = await this.configService.getValue("skipVersionCheck");
+    const skipCheck = coerceSkipVersionCheckValue(skipCheckRaw);
     if (skipCheck === true) {
       return null;
     }
@@ -45148,7 +45244,7 @@ class VersionService {
     const now = new Date;
     const timeSinceLastCheck = now.getTime() - lastCheckDate.getTime();
     const intervalDays = await this.configService.getValue("versionCheckInterval");
-    const days = typeof intervalDays === "number" ? intervalDays : 1;
+    const days = coerceVersionCheckIntervalValue(intervalDays) ?? 1;
     const intervalMs = days * 24 * 60 * 60 * 1000;
     return timeSinceLastCheck >= intervalMs;
   }
@@ -52866,31 +52962,79 @@ class CommentPRCommand extends BaseCommand {
     this.contextService = contextService;
   }
   async execute(options, context) {
+    if ((options.lineTo || options.lineFrom) && !options.file) {
+      throw new BBError({
+        code: 5001 /* VALIDATION_REQUIRED */,
+        message: "--file is required when using --line-to or --line-from"
+      });
+    }
+    if (options.file && !options.lineTo && !options.lineFrom) {
+      throw new BBError({
+        code: 5001 /* VALIDATION_REQUIRED */,
+        message: "At least one of --line-to or --line-from is required when using --file"
+      });
+    }
+    if (options.lineTo) {
+      const parsed = Number.parseInt(options.lineTo, 10);
+      if (Number.isNaN(parsed) || parsed < 1) {
+        throw new BBError({
+          code: 5002 /* VALIDATION_INVALID */,
+          message: "--line-to must be a positive integer"
+        });
+      }
+    }
+    if (options.lineFrom) {
+      const parsed = Number.parseInt(options.lineFrom, 10);
+      if (Number.isNaN(parsed) || parsed < 1) {
+        throw new BBError({
+          code: 5002 /* VALIDATION_INVALID */,
+          message: "--line-from must be a positive integer"
+        });
+      }
+    }
     const repoContext = await this.contextService.requireRepoContext({
       ...context.globalOptions,
       ...options
     });
     const prId = Number.parseInt(options.id, 10);
+    const inline = options.file ? {
+      path: options.file,
+      ...options.lineTo ? { to: Number.parseInt(options.lineTo, 10) } : {},
+      ...options.lineFrom ? { from: Number.parseInt(options.lineFrom, 10) } : {}
+    } : undefined;
+    const body = {
+      content: {
+        raw: options.message
+      },
+      ...inline ? { inline } : {}
+    };
     const response = await this.pullrequestsApi.repositoriesWorkspaceRepoSlugPullrequestsPullRequestIdCommentsPost({
       workspace: repoContext.workspace,
       repoSlug: repoContext.repoSlug,
       pullRequestId: prId,
-      body: {
-        type: "pullrequest_comment",
-        content: {
-          raw: options.message
-        }
-      }
+      body
     });
     if (context.globalOptions.json) {
-      this.output.json({
+      const jsonOutput = {
         success: true,
         pullRequestId: prId,
         comment: response.data
-      });
+      };
+      if (inline) {
+        jsonOutput.inline = inline;
+      }
+      this.output.json(jsonOutput);
       return;
     }
-    this.output.success(`Added comment to pull request #${prId}`);
+    if (inline) {
+      if (inline.to) {
+        this.output.success(`Added inline comment on ${inline.path}:${inline.to} to pull request #${prId}`);
+      } else {
+        this.output.success(`Added inline comment on ${inline.path} (old line ${inline.from}) to pull request #${prId}`);
+      }
+    } else {
+      this.output.success(`Added comment to pull request #${prId}`);
+    }
   }
 }
 
@@ -53306,25 +53450,6 @@ class ChecksPRCommand extends BaseCommand {
   }
 }
 
-// src/types/config.ts
-var SETTABLE_CONFIG_KEYS = [
-  "defaultWorkspace",
-  "skipVersionCheck",
-  "versionCheckInterval"
-];
-var READABLE_CONFIG_KEYS = [
-  "username",
-  "defaultWorkspace",
-  "skipVersionCheck",
-  "versionCheckInterval"
-];
-function isSettableConfigKey(key) {
-  return SETTABLE_CONFIG_KEYS.includes(key);
-}
-function isReadableConfigKey(key) {
-  return READABLE_CONFIG_KEYS.includes(key);
-}
-
 // src/commands/config/get.command.ts
 class GetConfigCommand extends BaseCommand {
   configService;
@@ -53341,9 +53466,10 @@ class GetConfigCommand extends BaseCommand {
       throw new Error(`Cannot display '${key}' - use 'bb auth token' to get authentication credentials`);
     }
     if (!isReadableConfigKey(key)) {
-      throw new Error(`Unknown config key '${key}'. Valid keys: username, defaultWorkspace`);
+      throw new Error(`Unknown config key '${key}'. Valid keys: ${READABLE_CONFIG_KEYS.join(", ")}`);
     }
-    const value = await this.configService.getValue(key);
+    const rawValue = await this.configService.getValue(key);
+    const value = normalizeReadableConfigValue(key, rawValue);
     if (context.globalOptions.json) {
       this.output.json({
         key,
@@ -53351,7 +53477,7 @@ class GetConfigCommand extends BaseCommand {
       });
       return;
     }
-    this.output.text(String(value || ""));
+    this.output.text(String(value ?? ""));
   }
 }
 
@@ -53371,18 +53497,19 @@ class SetConfigCommand extends BaseCommand {
       throw new Error(`Cannot set '${key}' directly. Use 'bb auth login' to configure authentication.`);
     }
     if (!isSettableConfigKey(key)) {
-      throw new Error(`Unknown config key '${key}'. Valid keys: defaultWorkspace`);
+      throw new Error(`Unknown config key '${key}'. Valid keys: ${SETTABLE_CONFIG_KEYS.join(", ")}`);
     }
-    await this.configService.setValue(key, value);
+    const parsedValue = parseSettableConfigValue(key, value);
+    await this.configService.setValue(key, parsedValue);
     if (context.globalOptions.json) {
       this.output.json({
         success: true,
         key,
-        value
+        value: parsedValue
       });
       return;
     }
-    this.output.success(`Set ${key} = ${value}`);
+    this.output.success(`Set ${key} = ${parsedValue}`);
   }
 }
 
@@ -53397,21 +53524,37 @@ class ListConfigCommand extends BaseCommand {
   }
   async execute(_options, context) {
     const config = await this.configService.getConfig();
-    const displayConfig = {
-      username: config.username || "",
-      defaultWorkspace: config.defaultWorkspace || "",
-      apiToken: config.apiToken ? "********" : ""
-    };
+    const displayConfig = {};
+    if (config.username) {
+      displayConfig.username = config.username;
+    }
+    if (config.defaultWorkspace) {
+      displayConfig.defaultWorkspace = config.defaultWorkspace;
+    }
+    if (config.apiToken) {
+      displayConfig.apiToken = "********";
+    }
+    const skipVersionCheck = coerceSkipVersionCheckValue(config.skipVersionCheck);
+    if (skipVersionCheck !== undefined) {
+      displayConfig.skipVersionCheck = skipVersionCheck;
+    }
+    const versionCheckInterval = coerceVersionCheckIntervalValue(config.versionCheckInterval);
+    if (versionCheckInterval !== undefined) {
+      displayConfig.versionCheckInterval = versionCheckInterval;
+    }
     if (context.globalOptions.json) {
       this.output.json({
         configPath: this.configService.getConfigPath(),
-        config: Object.fromEntries(Object.entries(displayConfig).filter(([, value]) => value !== ""))
+        config: displayConfig
       });
       return;
     }
     this.output.text(this.output.dim(`Config file: ${this.configService.getConfigPath()}`));
     this.output.text("");
-    const rows = Object.entries(displayConfig).filter(([, value]) => value !== "").map(([key, value]) => [key, value]);
+    const rows = Object.entries(displayConfig).map(([key, value]) => [
+      key,
+      String(value)
+    ]);
     if (rows.length === 0) {
       this.output.text("No configuration set");
       return;
@@ -53907,9 +54050,9 @@ prCommentsCmd.command("list <id>").description("List comments on a pull request"
   const context = createContext(cli);
   await runCommand(ServiceTokens.ListCommentsPRCommand, withGlobalOptions({ id, ...options }, context), cli, context);
 });
-prCommentsCmd.command("add <id> <message>").description("Add a comment to a pull request").action(async (id, message, options) => {
+prCommentsCmd.command("add <id> <message>").description("Add a comment to a pull request").option("--file <path>", "File path in the diff for inline comment").option("--line-to <number>", "Line number in the new file version").option("--line-from <number>", "Line number in the old file version").action(async (id, message, options) => {
   const context = createContext(cli);
-  await runCommand(ServiceTokens.CommentPRCommand, withGlobalOptions({ id, message }, context), cli, context);
+  await runCommand(ServiceTokens.CommentPRCommand, withGlobalOptions({ id, message, ...options }, context), cli, context);
 });
 prCommentsCmd.command("edit <pr-id> <comment-id> <message>").description("Edit a comment on a pull request").action(async (prId, commentId, message, options) => {
   const context = createContext(cli);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pilatos/bitbucket-cli",
-  "version": "1.7.1",
+  "version": "1.8.0",
   "description": "A command-line interface for Bitbucket Cloud",
   "author": "",
   "license": "MIT",