@pikku/queue-pg-boss 0.12.6 → 0.12.7

package/CHANGELOG.md

@@ -1,3 +1,14 @@
+## 0.12.7
+
+### Patch Changes
+
+- 6c30861: fix workflow step retry backoff firing immediately
+  - `@pikku/queue-pg-boss`: `backoff: 'exponential'` mapped to `retryBackoff: true` without a base `retryDelay`; pg-boss computes exponential backoff as `retry_delay * 2^n` with a queue default of 0, so every retry fired immediately. Exponential backoff now gets a 1s base delay, and sub-second fixed delays round up to 1s instead of flooring to 0 (= immediate).
+  - `@pikku/core`: a duration-string `retryDelay` (e.g. `'15s'`) on a workflow step was silently dropped (only numbers were honored) and fell back to exponential. It now resolves to a fixed backoff via `getDurationInMilliseconds`.
+
+- Updated dependencies [6c30861]
+  - @pikku/core@0.12.56
+
 ## 0.12.6
 
 ### Patch Changes

package/dist/pg-boss-queue-service.js

@@ -15,16 +15,19 @@ export const mapPikkuJobToPgBoss = (options) => {
         pgBossOptions.retryLimit = options.attempts - 1;
     }
     if (options?.backoff !== undefined) {
-        if (typeof options.backoff === 'string') {
-            // If backoff is a string, assume it's 'exponential' or 'fixed'
-            pgBossOptions.retryBackoff = options.backoff === 'exponential';
+        const type = typeof options.backoff === 'string' ? options.backoff : options.backoff.type;
+        const delay = typeof options.backoff === 'object' ? options.backoff.delay : undefined;
+        pgBossOptions.retryBackoff = type === 'exponential';
+        if (delay !== undefined) {
+            // pg-boss uses seconds, we use milliseconds — never round a sub-second
+            // delay down to 0, which pg-boss treats as retry-immediately
+            pgBossOptions.retryDelay = Math.max(1, Math.round(delay / 1000));
         }
-        else if (typeof options.backoff === 'object') {
-            pgBossOptions.retryBackoff = options.backoff.type === 'exponential';
-            if (options.backoff.delay !== undefined) {
-                // pg-boss uses seconds, we use milliseconds
-                pgBossOptions.retryDelay = Math.floor(options.backoff.delay / 1000);
-            }
+        else if (type === 'exponential') {
+            // pg-boss computes exponential backoff as retry_delay * 2^n, and the
+            // queue-level retry_delay defaults to 0 — without an explicit base every
+            // "exponential" retry fires immediately. 1s base → ~1s, 2s, 4s, 8s…
+            pgBossOptions.retryDelay = 1;
         }
     }
     if (options?.removeOnComplete !== undefined) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pikku/queue-pg-boss",
-  "version": "0.12.6",
+  "version": "0.12.7",
   "author": "yasser.fadl@gmail.com",
   "license": "MIT",
   "module": "dist/index.js",
@@ -15,7 +15,7 @@
     "prepublishOnly": "yarn build"
   },
   "peerDependencies": {
-    "@pikku/core": "^0.12.44"
+    "@pikku/core": "^0.12.56"
   },
   "dependencies": {
     "pg-boss": "^12.14.0"

package/run-tests.sh

@@ -1,5 +1,56 @@
 #!/bin/bash
-cd "$(dirname "$0")"
+
+script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+cd "$script_dir"
+
+# Enable nullglob to handle cases where no files match the pattern
+shopt -s nullglob
+
+# Initialize variables for options
+watch_mode=false
+coverage_mode=false
+
+# Parse command-line options
+while [[ $# -gt 0 ]]; do
+  case $1 in
+    --watch)
+      watch_mode=true
+      shift
+      ;;
+    --coverage)
+      coverage_mode=true
+      shift
+      ;;
+    *)
+      echo "Unknown option: $1"
+      exit 1
+      ;;
+  esac
+done
+
+# Define the pattern to match your test files
+pattern="src/*.test.ts"
+
+# Expand the pattern into an array of files
 files=($(find src -type f -name "*.test.ts"))
-if [ ${#files[@]} -eq 0 ]; then echo "No test files found"; exit 0; fi
-node --import tsx --test "$@" "${files[@]}"
+
+# Check if any files matched the pattern
+if [ ${#files[@]} -eq 0 ]; then
+  echo "No test files found matching pattern: $pattern"
+  exit 0
+fi
+
+# Construct the node command
+node_cmd=(node --import tsx --test)
+
+# Append options based on flags
+if [ "$watch_mode" = true ]; then
+  node_cmd+=(--watch)
+fi
+
+if [ "$coverage_mode" = true ]; then
+  node_cmd+=(--test-coverage-include="src/**/*.{ts,js}" --test-coverage-exclude="**/dist/**" --experimental-test-coverage --test-reporter=lcov --test-reporter-destination=lcov.info)
+fi
+
+# Execute the node command with the expanded list of files
+"${node_cmd[@]}" "${files[@]}"

package/src/pg-boss-queue-service.test.ts

@@ -16,12 +16,20 @@ describe('mapPikkuJobToPgBoss — retry mapping', () => {
     assert.equal(mapPikkuJobToPgBoss({ attempts: 1 }).retryLimit, 0)
   })
 
-  test("backoff 'exponential' → retryBackoff true", () => {
-    assert.equal(
-      mapPikkuJobToPgBoss({ attempts: 6, backoff: 'exponential' })
-        .retryBackoff,
-      true
-    )
+  test("backoff 'exponential' → retryBackoff true + 1s base delay", () => {
+    const opts = mapPikkuJobToPgBoss({ attempts: 6, backoff: 'exponential' })
+    assert.equal(opts.retryBackoff, true)
+    // pg-boss multiplies retry_delay by 2^n and the queue default is 0 —
+    // without a base, "exponential" retries all fire immediately.
+    assert.equal(opts.retryDelay, 1)
+  })
+
+  test('sub-second fixed delay rounds up to 1s, not down to immediate', () => {
+    const opts = mapPikkuJobToPgBoss({
+      attempts: 4,
+      backoff: { type: 'fixed', delay: 300 },
+    })
+    assert.equal(opts.retryDelay, 1)
   })
 
   test('fixed backoff → retryBackoff false + retryDelay in seconds', () => {

package/src/pg-boss-queue-service.ts

@@ -25,15 +25,20 @@ export const mapPikkuJobToPgBoss = (
   }
 
   if (options?.backoff !== undefined) {
-    if (typeof options.backoff === 'string') {
-      // If backoff is a string, assume it's 'exponential' or 'fixed'
-      pgBossOptions.retryBackoff = options.backoff === 'exponential'
-    } else if (typeof options.backoff === 'object') {
-      pgBossOptions.retryBackoff = options.backoff.type === 'exponential'
-      if (options.backoff.delay !== undefined) {
-        // pg-boss uses seconds, we use milliseconds
-        pgBossOptions.retryDelay = Math.floor(options.backoff.delay / 1000)
-      }
+    const type =
+      typeof options.backoff === 'string' ? options.backoff : options.backoff.type
+    const delay =
+      typeof options.backoff === 'object' ? options.backoff.delay : undefined
+    pgBossOptions.retryBackoff = type === 'exponential'
+    if (delay !== undefined) {
+      // pg-boss uses seconds, we use milliseconds — never round a sub-second
+      // delay down to 0, which pg-boss treats as retry-immediately
+      pgBossOptions.retryDelay = Math.max(1, Math.round(delay / 1000))
+    } else if (type === 'exponential') {
+      // pg-boss computes exponential backoff as retry_delay * 2^n, and the
+      // queue-level retry_delay defaults to 0 — without an explicit base every
+      // "exponential" retry fires immediately. 1s base → ~1s, 2s, 4s, 8s…
+      pgBossOptions.retryDelay = 1
     }
   }