@pikku/queue-bullmq 0.12.5 → 0.12.7

package/CHANGELOG.md

@@ -1,3 +1,121 @@
+## 0.12.7
+
+### Patch Changes
+
+- 266e3bc: One door per name: `@pikku/core/ecosystem/*` and the package root are gone
+
+  `@pikku/core` published every module twice. `ecosystem/http` re-exported
+  `./http`, `ecosystem/services` re-exported `./services`, and a name was
+  reachable through either — so every addition had to be made in two places, and a
+  consumer's import said nothing about what it actually used. The package root was
+  the same problem at a larger scale: a single barrel of 206 names that no bundler
+  could take apart, and the one specifier that revealed nothing at all.
+
+  Both are deleted. Every name now lives on the subpath that owns it, and every
+  import carries that subpath — `@pikku/core/http`, `@pikku/core/services`,
+  `@pikku/core/errors`, `@pikku/core/types`.
+
+  Deleting the facades meant the raw subpaths had to become a superset of them,
+  which they were not: the facade tree had accumulated 25 names with no raw home
+  and about 26 more filed under a different area than the module they came from.
+  Those names moved to the area that owns them, and three areas were published as
+  new entry points rather than left on a root that is going away — `./types` (the
+  shared type surface, the largest single destination), `./state` and
+  `./classification`.
+
+  `./classification` is one door onto one subject: what a value is and how it must
+  be handled. Its three halves would each have been an entry point — the brands
+  and manifest types, the stored-form helpers (`hashToken`, `unsafeAsSealed` and
+  friends), and `SecretValue` — split by whether a name happens to be a type or a
+  value, which is the same defect as the facades. The duration and versioned-id
+  helpers went to `./utils`, which already published, and `PikkuRequest` went to
+  `./function`: it is the transport-agnostic request base, not an HTTP one — HTTP
+  has `PikkuHTTPAbstractRequest`, and the only thing outside core that extends
+  `PikkuRequest` is Azure's timer request.
+
+  `./types` inherited the root barrel's habit before it inherited its contents, so
+  the names with an owner elsewhere were moved off it. The middleware types and the
+  five middleware factories — `pikkuMiddleware`, `pikkuMiddlewareFactory`,
+  `pikkuChannelMiddleware`, `pikkuChannelMiddlewareFactory` and
+  `pikkuAgentMiddleware`, runtime values on a types entry point — are now
+  `@pikku/core/middleware`; the function meta types are `@pikku/core/function`;
+  `SerializedError` is `@pikku/core/errors`; and the generic TypeScript helpers
+  (`MakeRequired`, `PickRequired`, `PickOptional`, `RequireAtLeastOne`,
+  `JSONPrimitive`, `JSONValue`) are `@pikku/core/utils`. What is left on `./types`
+  is the vocabulary the wirings share, which no single module owns.
+
+  `pikku` was itself a root barrel — `export * from '@pikku/core'` — and
+  now exports only the services it bundles.
+
+  One module survives at the old specifier, and only for the bootstrap:
+  `packages/cli` is generated by the _published_ CLI pinned in its `build.sh`, and
+  that CLI still writes a bare `@pikku/core` into the files it generates for the
+  CLI itself. `bootstrap-compat/root.ts` carries the eight types it names, a test
+  in core fails if that list grows, and it goes when the pin moves to a CLI
+  released from this branch. The adapter names the pinned CLI reaches for —
+  `pikkuState` and `CreateWireServices` — are rewritten to `@pikku/core/state` and
+  `@pikku/core/types` by the same `build.sh` patch pass, so no second shim is
+  needed for them.
+
+  A guard test keeps the root shut: it parses imports and rejects a bare
+  `@pikku/core` rather than grepping for it, because several tests hold a user's
+  file as a template literal, where `import … from '@pikku/core'` is fixture text
+  rather than an import this repo makes.
+
+  An agent scaffold a project generated under an older CLI is refreshed rather
+  than left to fail: `pikku all` already deleted one importing an entry point
+  `@pikku/core` no longer publishes, and the `#pikku` hub joins that list.
+  Without it a project that scaffolds the agent endpoint but
+  declares no agents keeps the old file forever — the generator that would rewrite
+  it only runs when agents exist, and the file being present is what stops it
+  being regenerated as missing.
+
+  `pikku new addon` also wrote a tsconfig `paths` map naming only the deleted hub.
+  An addon's `imports` map points into `dist`, so `paths` is what resolves
+  `#pikku/<leaf>` for the addon's own source build — it now names the two leaf
+  patterns, in both the addon and its test harness.
+
+- 786dae5: Bump every dependency whose latest release is a major across the monorepo, and
+  port the code the majors broke: `cookie` 2's `parseCookie`/`stringifySetCookie`
+  API in `@pikku/core` and the three runtime HTTP adapters, and assistant-ui 0.15's
+  store client in `@pikku/assistant-ui`.
+- 6eef0a0: Bump every dependency to its latest compatible minor/patch across the monorepo.
+- Updated dependencies [7722ceb]
+- Updated dependencies [375c1ff]
+- Updated dependencies [02a70cd]
+- Updated dependencies [aeef159]
+- Updated dependencies [a281de6]
+- Updated dependencies [266e3bc]
+- Updated dependencies [02a70cd]
+- Updated dependencies [786dae5]
+- Updated dependencies [6eef0a0]
+- Updated dependencies [3561d67]
+- Updated dependencies [a91c433]
+- Updated dependencies [02a70cd]
+- Updated dependencies [9537f74]
+- Updated dependencies [2b57ca8]
+- Updated dependencies [266e3bc]
+- Updated dependencies [9fce0f1]
+- Updated dependencies [83683a0]
+- Updated dependencies [456c88b]
+- Updated dependencies [456c88b]
+- Updated dependencies [c127273]
+  - @pikku/core@0.12.85
+
+## 0.12.6
+
+### Patch Changes
+
+- 6794681: Publish the ecosystem surface as per-area sub-barrels under `@pikku/core/ecosystem/*`, and point generated code, the CLI, the inspector and the runtime adapters at them.
+
+  348 names that only generated code, the toolchain or a runtime adapter ever imports now have a second home on `@pikku/core/ecosystem/<area>` — one sub-barrel per area, matching how core already publishes its entrypoints, so no single barrel grows without bound and a consumer only pulls in the area it uses.
+
+  This step is additive: every name is still exported from the entrypoint it was published from before, so nothing downstream breaks. Removing them from the app-facing barrels is a later change, and needs a release carrying `./ecosystem/*` first.
+
+- Updated dependencies [7406bfe]
+- Updated dependencies [6794681]
+  - @pikku/core@0.12.84
+
 ## 0.12.5
 
 ### Patch Changes

package/LICENSE

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2021 - present Yasser Fadl and Pikku contributors
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

package/README.md

@@ -0,0 +1,29 @@
+# @pikku/queue-bullmq
+
+BullMQ queue, worker and scheduler services for Pikku. Backed by Redis, with
+job results, retries and priorities.
+
+## Install
+
+```bash
+npm install @pikku/queue-bullmq
+```
+
+## Usage
+
+```typescript
+import { BullQueueService, BullQueueWorkers } from '@pikku/queue-bullmq'
+
+const queue = new BullQueueService({ host: 'localhost', port: 6379 })
+
+const workers = new BullQueueWorkers({ host: 'localhost', port: 6379 })
+
+await workers.registerQueues()
+```
+
+Use `BullSchedulerService` for cron wirings. For a Postgres-backed alternative
+see `@pikku/queue-pg-boss`.
+
+## Docs
+
+https://pikku.dev/docs

package/dist/bull-queue-service.d.ts

@@ -1,6 +1,7 @@
 import type { ConnectionOptions, JobsOptions } from 'bullmq';
 import type Bull from 'bullmq';
-import type { QueueService, QueueJob, JobOptions } from '@pikku/core/queue';
+import type { QueueJob, QueueService } from '@pikku/core/queue';
+import type { JobOptions } from '@pikku/core/queue';
 export declare const mapPikkuJobToBull: (options?: JobOptions) => JobsOptions;
 /**
  * Bull/Redis queue service implementation
@@ -10,8 +11,8 @@ export declare class BullQueueService implements QueueService {
     private redisConnectionOptions;
     readonly name = "bull";
     readonly supportsResults = true;
-    protected queues: Map<string, Bull.Queue<any, any, string, any, any, string>>;
-    protected queueEvents: Map<string, Bull.QueueEvents>;
+    protected queues: Map<string, Bull.Queue<any, any, string, any, any, string, Bull.RedisQueueBackend>>;
+    protected queueEvents: Map<string, Bull.QueueEvents<any>>;
     constructor(redisConnectionOptions?: ConnectionOptions);
     /**
      * Create a Bull queue with translated configuration

package/dist/bull-queue-service.js

@@ -1,4 +1,4 @@
-import { Queue, QueueEvents, RedisConnection } from 'bullmq';
+import { Queue, QueueEvents } from 'bullmq';
 import { mapBullJobToQueueJob } from './utils.js';
 export const mapPikkuJobToBull = (options) => {
     const bullOptions = {};
@@ -30,14 +30,6 @@ export const mapPikkuJobToBull = (options) => {
     }
     return bullOptions;
 };
-class PikkuRedisConnection extends RedisConnection {
-    constructor(options) {
-        super(options);
-        this.on('error', (error) => {
-            console.error('Redis connection error:', error);
-        });
-    }
-}
 /**
  * Bull/Redis queue service implementation
  * Supports job results, retries, and most queue features
@@ -58,7 +50,10 @@ export class BullQueueService {
         if (this.queues.has(queueName)) {
             return this.queues.get(queueName);
         }
-        const queue = new Queue(queueName, config, PikkuRedisConnection);
+        const queue = new Queue(queueName, config);
+        queue.on('error', (error) => {
+            console.error('Redis connection error:', error);
+        });
         await queue.waitUntilReady();
         this.queues.set(queueName, queue);
         if (!this.queueEvents.has(queueName)) {

package/dist/bull-queue-worker.js

@@ -1,6 +1,7 @@
 import { Worker } from 'bullmq';
-import { registerQueueWorkers, runQueueJob, QueueJobFailedError, QueueJobDiscardedError, } from '@pikku/core/queue';
-import { pikkuState } from '@pikku/core/internal';
+import { runQueueJob } from '@pikku/core/queue';
+import { registerQueueWorkers, QueueJobFailedError, QueueJobDiscardedError, } from '@pikku/core/queue';
+import { pikkuState } from '@pikku/core/state';
 import { mapBullJobToQueueJob } from './utils.js';
 export const mapPikkuWorkerToBull = (workerConfig) => {
     const workerOptions = {};

package/dist/bull-scheduler-service.d.ts

@@ -1,12 +1,13 @@
 import type { ConnectionOptions } from 'bullmq';
-import type { ScheduledTaskInfo, ScheduledTaskSummary, CoreUserSession } from '@pikku/core';
-import { SchedulerService } from '@pikku/core';
+import { SchedulerService } from '@pikku/core/services';
+import type { CoreUserSession } from '@pikku/core/types';
+import type { ScheduledTaskInfo, ScheduledTaskSummary } from '@pikku/core/services';
 export declare class BullSchedulerService extends SchedulerService {
     private redisConnectionOptions;
     private queue;
     private recurringQueue;
     private recurringWorker?;
-    private repeatJobKeys;
+    private jobSchedulerIds;
     constructor(redisConnectionOptions: ConnectionOptions);
     /**
      * Initialize - wait for queue to be ready
@@ -39,7 +40,7 @@ export declare class BullSchedulerService extends SchedulerService {
      */
     start(): Promise<void>;
     /**
-     * Stop recurring scheduled tasks by removing repeat jobs.
+     * Stop recurring scheduled tasks by removing their job schedulers.
      */
     stop(): Promise<void>;
 }

package/dist/bull-scheduler-service.js

@@ -1,14 +1,16 @@
 import { Queue, Worker } from 'bullmq';
-import { SchedulerService, parseDurationString } from '@pikku/core';
-import { pikkuState } from '@pikku/core/internal';
-import { runScheduledTask, getScheduledTasks } from '@pikku/core/scheduler';
+import { runScheduledTask } from '@pikku/core/scheduler';
+import { SchedulerService } from '@pikku/core/services';
+import { parseDurationString } from '@pikku/core/utils';
+import { pikkuState } from '@pikku/core/state';
+import { getScheduledTasks } from '@pikku/core/scheduler';
 const RECURRING_QUEUE_NAME = 'pikku-recurring-scheduled-task';
 export class BullSchedulerService extends SchedulerService {
     redisConnectionOptions;
     queue;
     recurringQueue;
     recurringWorker;
-    repeatJobKeys = [];
+    jobSchedulerIds = [];
     constructor(redisConnectionOptions) {
         super();
         this.redisConnectionOptions = redisConnectionOptions;
@@ -125,23 +127,19 @@ export class BullSchedulerService extends SchedulerService {
             logger.error(`Recurring task worker error: ${err}`);
         });
         for (const [name, task] of scheduledTasks) {
-            const job = await this.recurringQueue.add(name, { rpcName: name }, {
-                repeat: { pattern: task.schedule },
-                jobId: `recurring:${name}`,
-            });
-            if (job.repeatJobKey) {
-                this.repeatJobKeys.push(job.repeatJobKey);
-            }
+            const jobSchedulerId = `recurring:${name}`;
+            await this.recurringQueue.upsertJobScheduler(jobSchedulerId, { pattern: task.schedule }, { name, data: { rpcName: name } });
+            this.jobSchedulerIds.push(jobSchedulerId);
         }
     }
     /**
-     * Stop recurring scheduled tasks by removing repeat jobs.
+     * Stop recurring scheduled tasks by removing their job schedulers.
      */
     async stop() {
-        for (const key of this.repeatJobKeys) {
-            await this.recurringQueue.removeRepeatableByKey(key);
+        for (const id of this.jobSchedulerIds) {
+            await this.recurringQueue.removeJobScheduler(id);
         }
-        this.repeatJobKeys = [];
+        this.jobSchedulerIds = [];
         if (this.recurringWorker) {
             await this.recurringWorker.close();
             this.recurringWorker = undefined;

package/dist/index.d.ts

@@ -8,4 +8,5 @@ export { BullServiceFactory } from './bull-service-factory.js';
 export { BullQueueService } from './bull-queue-service.js';
 export { BullQueueWorkers } from './bull-queue-worker.js';
 export { BullSchedulerService } from './bull-scheduler-service.js';
-export type { QueueService, PikkuWorkerConfig, PikkuJobConfig, QueueJob, JobOptions, } from '@pikku/core/queue';
+export type { QueueJob, QueueService } from '@pikku/core/queue';
+export type { PikkuWorkerConfig, PikkuJobConfig, JobOptions, } from '@pikku/core/queue';

package/package.json

@@ -1,6 +1,7 @@
 {
   "name": "@pikku/queue-bullmq",
-  "version": "0.12.5",
+  "version": "0.12.7",
+  "description": "BullMQ queue, worker and scheduler services for Pikku",
   "author": "yasser.fadl@gmail.com",
   "license": "MIT",
   "module": "dist/index.js",
@@ -15,11 +16,11 @@
     "prepublishOnly": "yarn build"
   },
   "peerDependencies": {
-    "@pikku/core": "^0.12.69"
+    "@pikku/core": "^0.12.85"
   },
   "dependencies": {
-    "bullmq": "^5.70.1",
-    "ioredis": "^5.10.0"
+    "bullmq": "^6.1.1",
+    "ioredis": "^6.0.0"
   },
   "devDependencies": {
     "typescript": "^6.0.3"
@@ -27,4 +28,4 @@
   "exports": {
     ".": "./dist/index.js"
   }
-}
+}

package/src/bull-queue-service.test.ts

@@ -13,9 +13,12 @@ describe('mapPikkuJobToBull — retry mapping', () => {
   })
 
   test("string backoff 'exponential' → { type: 'exponential' }", () => {
-    assert.deepEqual(mapPikkuJobToBull({ attempts: 6, backoff: 'exponential' }).backoff, {
-      type: 'exponential',
-    })
+    assert.deepEqual(
+      mapPikkuJobToBull({ attempts: 6, backoff: 'exponential' }).backoff,
+      {
+        type: 'exponential',
+      }
+    )
   })
 
   test('object backoff → { type, delay } (delay stays in ms)', () => {

package/src/bull-queue-service.ts

@@ -1,7 +1,8 @@
 import type { ConnectionOptions, JobsOptions } from 'bullmq'
 import type Bull from 'bullmq'
-import { Queue, QueueEvents, RedisConnection } from 'bullmq'
-import type { QueueService, QueueJob, JobOptions } from '@pikku/core/queue'
+import { Queue, QueueEvents } from 'bullmq'
+import type { QueueJob, QueueService } from '@pikku/core/queue'
+import type { JobOptions } from '@pikku/core/queue'
 import { mapBullJobToQueueJob } from './utils.js'
 
 export const mapPikkuJobToBull = (options?: JobOptions): JobsOptions => {
@@ -43,15 +44,6 @@ export const mapPikkuJobToBull = (options?: JobOptions): JobsOptions => {
   return bullOptions
 }
 
-class PikkuRedisConnection extends RedisConnection {
-  constructor(options: ConnectionOptions) {
-    super(options)
-    this.on('error', (error) => {
-      console.error('Redis connection error:', error)
-    })
-  }
-}
-
 /**
  * Bull/Redis queue service implementation
  * Supports job results, retries, and most queue features
@@ -75,7 +67,10 @@ export class BullQueueService implements QueueService {
       return this.queues.get(queueName)!
     }
 
-    const queue = new Queue(queueName, config, PikkuRedisConnection)
+    const queue = new Queue(queueName, config)
+    queue.on('error', (error) => {
+      console.error('Redis connection error:', error)
+    })
     await queue.waitUntilReady()
 
     this.queues.set(queueName, queue)

package/src/bull-queue-worker.ts

@@ -7,13 +7,13 @@ import type {
   QueueConfigMapping,
   ConfigValidationResult,
 } from '@pikku/core/queue'
+import { runQueueJob } from '@pikku/core/queue'
 import {
   registerQueueWorkers,
-  runQueueJob,
   QueueJobFailedError,
   QueueJobDiscardedError,
 } from '@pikku/core/queue'
-import { pikkuState } from '@pikku/core/internal'
+import { pikkuState } from '@pikku/core/state'
 import { mapBullJobToQueueJob } from './utils.js'
 
 export const mapPikkuWorkerToBull = (

package/src/bull-scheduler-service.ts

@@ -1,13 +1,15 @@
 import type { ConnectionOptions } from 'bullmq'
 import { Queue, Worker } from 'bullmq'
+import { runScheduledTask } from '@pikku/core/scheduler'
+import { SchedulerService } from '@pikku/core/services'
+import type { CoreUserSession } from '@pikku/core/types'
 import type {
   ScheduledTaskInfo,
   ScheduledTaskSummary,
-  CoreUserSession,
-} from '@pikku/core'
-import { SchedulerService, parseDurationString } from '@pikku/core'
-import { pikkuState } from '@pikku/core/internal'
-import { runScheduledTask, getScheduledTasks } from '@pikku/core/scheduler'
+} from '@pikku/core/services'
+import { parseDurationString } from '@pikku/core/utils'
+import { pikkuState } from '@pikku/core/state'
+import { getScheduledTasks } from '@pikku/core/scheduler'
 
 /**
  * Data stored in scheduled job
@@ -24,7 +26,7 @@ export class BullSchedulerService extends SchedulerService {
   private queue: Queue
   private recurringQueue: Queue
   private recurringWorker?: Worker
-  private repeatJobKeys: string[] = []
+  private jobSchedulerIds: string[] = []
 
   constructor(private redisConnectionOptions: ConnectionOptions) {
     super()
@@ -170,28 +172,24 @@ export class BullSchedulerService extends SchedulerService {
     })
 
     for (const [name, task] of scheduledTasks) {
-      const job = await this.recurringQueue.add(
-        name,
-        { rpcName: name } as ScheduledJobData,
-        {
-          repeat: { pattern: task.schedule },
-          jobId: `recurring:${name}`,
-        }
+      const jobSchedulerId = `recurring:${name}`
+      await this.recurringQueue.upsertJobScheduler(
+        jobSchedulerId,
+        { pattern: task.schedule },
+        { name, data: { rpcName: name } as ScheduledJobData }
       )
-      if (job.repeatJobKey) {
-        this.repeatJobKeys.push(job.repeatJobKey)
-      }
+      this.jobSchedulerIds.push(jobSchedulerId)
     }
   }
 
   /**
-   * Stop recurring scheduled tasks by removing repeat jobs.
+   * Stop recurring scheduled tasks by removing their job schedulers.
    */
   async stop(): Promise<void> {
-    for (const key of this.repeatJobKeys) {
-      await this.recurringQueue.removeRepeatableByKey(key)
+    for (const id of this.jobSchedulerIds) {
+      await this.recurringQueue.removeJobScheduler(id)
     }
-    this.repeatJobKeys = []
+    this.jobSchedulerIds = []
     if (this.recurringWorker) {
       await this.recurringWorker.close()
       this.recurringWorker = undefined

package/src/index.ts

@@ -11,10 +11,9 @@ export { BullQueueWorkers } from './bull-queue-worker.js'
 export { BullSchedulerService } from './bull-scheduler-service.js'
 
 // Re-export core queue types for convenience
+export type { QueueJob, QueueService } from '@pikku/core/queue'
 export type {
-  QueueService,
   PikkuWorkerConfig,
   PikkuJobConfig,
-  QueueJob,
   JobOptions,
 } from '@pikku/core/queue'