@pikku/queue-bullmq 0.11.2 → 0.12.1

package/CHANGELOG.md

@@ -1,3 +1,28 @@
+## 0.12.0
+
+## 0.12.1
+
+### Patch Changes
+
+- e04531f: Code quality improvements: resolve oxlint warnings and apply autofixes across the codebase (unused bindings, unnecessary constructors, prefer `const` over `let`, etc.). No behaviour changes.
+- Updated dependencies [62a8725]
+- Updated dependencies [a3bdb0d]
+- Updated dependencies [e0349ff]
+- Updated dependencies [62a8725]
+- Updated dependencies [e04531f]
+- Updated dependencies [62a8725]
+- Updated dependencies [a83efb8]
+- Updated dependencies [8eed717]
+- Updated dependencies [62a8725]
+- Updated dependencies [62a8725]
+- Updated dependencies [62a8725]
+  - @pikku/core@0.12.1
+
+### New Features
+
+- Recurring cron scheduled tasks support via `BullSchedulerService`
+- `setServices()`, `start()`, `stop()` lifecycle methods on scheduler and queue workers
+
 ## 0.11.0
 
 ## 0.11.2
@@ -8,8 +33,6 @@
 - Updated dependencies [db9c7bf]
   - @pikku/core@0.11.2
 
-## 0.11.2
-
 ### Fixes
 
 - ddd87eaf: Simplify CreateWireServices type signature for custom Config compatibility

package/dist/bull-queue-service.d.ts

@@ -1,4 +1,5 @@
-import Bull, { ConnectionOptions, JobsOptions } from 'bullmq';
+import type { ConnectionOptions, JobsOptions } from 'bullmq';
+import type Bull from 'bullmq';
 import type { QueueService, QueueJob, JobOptions } from '@pikku/core/queue';
 export declare const mapPikkuJobToBull: (options?: JobOptions) => JobsOptions;
 /**

package/dist/bull-queue-service.js

@@ -1,4 +1,4 @@
-import { Queue, RedisConnection, } from 'bullmq';
+import { Queue, QueueEvents, RedisConnection } from 'bullmq';
 import { mapBullJobToQueueJob } from './utils.js';
 export const mapPikkuJobToBull = (options) => {
     const bullOptions = {};
@@ -53,6 +53,13 @@ export class BullQueueService {
         const queue = new Queue(queueName, config, PikkuRedisConnection);
         await queue.waitUntilReady();
         this.queues.set(queueName, queue);
+        if (!this.queueEvents.has(queueName)) {
+            const queueEvents = new QueueEvents(queueName, this.redisConnectionOptions
+                ? { connection: this.redisConnectionOptions }
+                : undefined);
+            await queueEvents.waitUntilReady();
+            this.queueEvents.set(queueName, queueEvents);
+        }
         return queue;
     }
     /**

package/dist/bull-queue-worker.d.ts

@@ -1,6 +1,5 @@
-import { ConnectionOptions, WorkerOptions } from 'bullmq';
+import type { ConnectionOptions, WorkerOptions } from 'bullmq';
 import type { QueueWorkers, PikkuWorkerConfig, QueueConfigMapping, ConfigValidationResult } from '@pikku/core/queue';
-import type { CoreSingletonServices, CreateWireServices } from '@pikku/core';
 export declare const mapPikkuWorkerToBull: (workerConfig?: PikkuWorkerConfig) => Omit<WorkerOptions, "connection">;
 /**
  * Bull/Redis queue service implementation
@@ -8,8 +7,6 @@ export declare const mapPikkuWorkerToBull: (workerConfig?: PikkuWorkerConfig) =>
  */
 export declare class BullQueueWorkers implements QueueWorkers {
     private redisConnectionOptions;
-    private singletonServices;
-    private createWireServices?;
     readonly name = "bull";
     readonly supportsResults = true;
     /**
@@ -19,7 +16,7 @@ export declare class BullQueueWorkers implements QueueWorkers {
     readonly configMappings: QueueConfigMapping;
     private workers;
     private queueEvents;
-    constructor(redisConnectionOptions: ConnectionOptions, singletonServices: CoreSingletonServices, createWireServices?: CreateWireServices | undefined);
+    constructor(redisConnectionOptions: ConnectionOptions);
     /**
      * Scan state and register all compatible processors
      */

package/dist/bull-queue-worker.js

@@ -1,5 +1,6 @@
-import { Worker, } from 'bullmq';
-import { runQueueJob, registerQueueWorkers, QueueJobFailedError, QueueJobDiscardedError, } from '@pikku/core/queue';
+import { Worker } from 'bullmq';
+import { registerQueueWorkers, runQueueJob, QueueJobFailedError, QueueJobDiscardedError, } from '@pikku/core/queue';
+import { pikkuState } from '@pikku/core/internal';
 import { mapBullJobToQueueJob } from './utils.js';
 export const mapPikkuWorkerToBull = (workerConfig) => {
     const workerOptions = {};
@@ -37,8 +38,6 @@ export const mapPikkuWorkerToBull = (workerConfig) => {
  */
 export class BullQueueWorkers {
     redisConnectionOptions;
-    singletonServices;
-    createWireServices;
     name = 'bull';
     supportsResults = true;
     /**
@@ -101,21 +100,18 @@ export class BullQueueWorkers {
     };
     workers = new Map();
     queueEvents = new Map();
-    constructor(redisConnectionOptions, singletonServices, createWireServices) {
+    constructor(redisConnectionOptions) {
         this.redisConnectionOptions = redisConnectionOptions;
-        this.singletonServices = singletonServices;
-        this.createWireServices = createWireServices;
     }
     /**
      * Scan state and register all compatible processors
      */
     async registerQueues() {
-        return await registerQueueWorkers(this.configMappings, this.singletonServices.logger, async (queueName, processor) => {
-            const worker = new Worker(processor.queueName, async (job) => {
+        const logger = pikkuState(null, 'package', 'singletonServices').logger;
+        return await registerQueueWorkers(this.configMappings, logger, async (queueName, processor) => {
+            const worker = new Worker(processor.name, async (job) => {
                 try {
                     return await runQueueJob({
-                        singletonServices: this.singletonServices,
-                        createWireServices: this.createWireServices,
                         job: await mapBullJobToQueueJob(job, this.redisConnectionOptions, this.queueEvents),
                         updateProgress: async (progress) => {
                             await job.updateProgress(progress);

package/dist/bull-scheduler-service.d.ts

@@ -1,11 +1,12 @@
-import { ConnectionOptions } from 'bullmq';
-import { SchedulerService, ScheduledTaskInfo, ScheduledTaskSummary, CoreUserSession } from '@pikku/core';
-/**
- * BullMQ scheduler service implementation
- * Uses BullMQ's delayed jobs for one-time execution
- */
+import type { ConnectionOptions } from 'bullmq';
+import type { ScheduledTaskInfo, ScheduledTaskSummary, CoreUserSession } from '@pikku/core';
+import { SchedulerService } from '@pikku/core';
 export declare class BullSchedulerService extends SchedulerService {
+    private redisConnectionOptions;
     private queue;
+    private recurringQueue;
+    private recurringWorker?;
+    private repeatJobKeys;
     constructor(redisConnectionOptions: ConnectionOptions);
     /**
      * Initialize - wait for queue to be ready
@@ -32,4 +33,13 @@ export declare class BullSchedulerService extends SchedulerService {
      * Close the queue connection
      */
     close(): Promise<void>;
+    /**
+     * Start recurring scheduled tasks.
+     * Creates a BullMQ Worker to process repeat jobs via runScheduledTask.
+     */
+    start(): Promise<void>;
+    /**
+     * Stop recurring scheduled tasks by removing repeat jobs.
+     */
+    stop(): Promise<void>;
 }

package/dist/bull-scheduler-service.js

@@ -1,16 +1,23 @@
-import { Queue } from 'bullmq';
-import { SchedulerService, parseDurationString, } from '@pikku/core';
-/**
- * BullMQ scheduler service implementation
- * Uses BullMQ's delayed jobs for one-time execution
- */
+import { Queue, Worker } from 'bullmq';
+import { SchedulerService, parseDurationString } from '@pikku/core';
+import { pikkuState } from '@pikku/core/internal';
+import { runScheduledTask, getScheduledTasks } from '@pikku/core/scheduler';
+const RECURRING_QUEUE_NAME = 'pikku-recurring-scheduled-task';
 export class BullSchedulerService extends SchedulerService {
+    redisConnectionOptions;
     queue;
+    recurringQueue;
+    recurringWorker;
+    repeatJobKeys = [];
     constructor(redisConnectionOptions) {
         super();
+        this.redisConnectionOptions = redisConnectionOptions;
         this.queue = new Queue('pikku-remote-internal-rpc', {
             connection: redisConnectionOptions,
         });
+        this.recurringQueue = new Queue(RECURRING_QUEUE_NAME, {
+            connection: redisConnectionOptions,
+        });
     }
     /**
      * Initialize - wait for queue to be ready
@@ -95,6 +102,49 @@ export class BullSchedulerService extends SchedulerService {
      * Close the queue connection
      */
     async close() {
+        if (this.recurringWorker) {
+            await this.recurringWorker.close();
+        }
+        await this.recurringQueue.close();
         await this.queue.close();
     }
+    /**
+     * Start recurring scheduled tasks.
+     * Creates a BullMQ Worker to process repeat jobs via runScheduledTask.
+     */
+    async start() {
+        const logger = pikkuState(null, 'package', 'singletonServices').logger;
+        const scheduledTasks = getScheduledTasks();
+        // Create a worker to process recurring scheduled task jobs
+        this.recurringWorker = new Worker(RECURRING_QUEUE_NAME, async (job) => {
+            const { rpcName } = job.data;
+            logger.info(`Running scheduled task: ${rpcName}`);
+            await runScheduledTask({ name: rpcName });
+        }, { connection: this.redisConnectionOptions });
+        this.recurringWorker.on('error', (err) => {
+            logger.error(`Recurring task worker error: ${err}`);
+        });
+        for (const [name, task] of scheduledTasks) {
+            const job = await this.recurringQueue.add(name, { rpcName: name }, {
+                repeat: { pattern: task.schedule },
+                jobId: `recurring:${name}`,
+            });
+            if (job.repeatJobKey) {
+                this.repeatJobKeys.push(job.repeatJobKey);
+            }
+        }
+    }
+    /**
+     * Stop recurring scheduled tasks by removing repeat jobs.
+     */
+    async stop() {
+        for (const key of this.repeatJobKeys) {
+            await this.recurringQueue.removeRepeatableByKey(key);
+        }
+        this.repeatJobKeys = [];
+        if (this.recurringWorker) {
+            await this.recurringWorker.close();
+            this.recurringWorker = undefined;
+        }
+    }
 }

package/dist/bull-service-factory.d.ts

@@ -1,8 +1,7 @@
-import { ConnectionOptions } from 'bullmq';
+import type { ConnectionOptions } from 'bullmq';
 import { BullQueueService } from './bull-queue-service.js';
 import { BullQueueWorkers } from './bull-queue-worker.js';
 import { BullSchedulerService } from './bull-scheduler-service.js';
-import type { CoreSingletonServices, CreateWireServices } from '@pikku/core';
 /**
  * Factory class for BullMQ services
  * Manages Redis connection options shared across queue, worker, and scheduler services
@@ -24,7 +23,7 @@ export declare class BullServiceFactory {
     /**
      * Get the queue workers for processing jobs
      */
-    getQueueWorkers(singletonServices: CoreSingletonServices, createWireServices?: CreateWireServices): BullQueueWorkers;
+    getQueueWorkers(): BullQueueWorkers;
     /**
      * Get the scheduler service for managing delayed tasks
      */

package/dist/bull-service-factory.js

@@ -31,9 +31,9 @@ export class BullServiceFactory {
     /**
      * Get the queue workers for processing jobs
      */
-    getQueueWorkers(singletonServices, createWireServices) {
+    getQueueWorkers() {
         if (!this.queueWorkers) {
-            this.queueWorkers = new BullQueueWorkers(this.redisConnectionOptions, singletonServices, createWireServices);
+            this.queueWorkers = new BullQueueWorkers(this.redisConnectionOptions);
         }
         return this.queueWorkers;
     }

package/dist/utils.d.ts

@@ -1,5 +1,6 @@
-import { QueueJob } from '@pikku/core/queue';
-import { ConnectionOptions, Job, QueueEvents } from 'bullmq';
+import type { QueueJob } from '@pikku/core/queue';
+import type { ConnectionOptions, Job } from 'bullmq';
+import { QueueEvents } from 'bullmq';
 /**
  * Map Bull job to QueueJob interface
  */

package/dist/utils.js

@@ -29,10 +29,11 @@ export const mapBullJobToQueueJob = async (bullJob, redisConnection, queueEvents
         result: bullJob.returnvalue,
         status: async () => mapBullStateToStatus(await bullJob.getState()),
         waitForCompletion: async (ttl) => {
-            let queueEvents = queueEventsMap.get(bullJob.name);
+            let queueEvents = queueEventsMap.get(bullJob.queueName);
             if (!queueEvents) {
-                queueEvents = new QueueEvents(bullJob.name, redisConnection ? { connection: redisConnection } : undefined);
-                queueEventsMap.set(bullJob.name, queueEvents);
+                queueEvents = new QueueEvents(bullJob.queueName, redisConnection ? { connection: redisConnection } : undefined);
+                queueEventsMap.set(bullJob.queueName, queueEvents);
+                await queueEvents.waitUntilReady();
             }
             return await bullJob.waitUntilFinished(queueEvents, ttl);
         },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pikku/queue-bullmq",
-  "version": "0.11.2",
+  "version": "0.12.1",
   "author": "yasser.fadl@gmail.com",
   "license": "MIT",
   "module": "dist/index.js",
@@ -13,11 +13,11 @@
     "release": "npm run build && npm test"
   },
   "peerDependencies": {
-    "@pikku/core": "^0.11.2"
+    "@pikku/core": "^0.12.1"
   },
   "dependencies": {
-    "bullmq": "^5.63.2",
-    "ioredis": "^5.8.2"
+    "bullmq": "^5.67.3",
+    "ioredis": "^5.9.2"
   },
   "devDependencies": {
     "typescript": "^5.9"

package/src/bull-queue-service.ts

@@ -1,9 +1,6 @@
-import Bull, {
-  ConnectionOptions,
-  JobsOptions,
-  Queue,
-  RedisConnection,
-} from 'bullmq'
+import type { ConnectionOptions, JobsOptions } from 'bullmq'
+import type Bull from 'bullmq'
+import { Queue, QueueEvents, RedisConnection } from 'bullmq'
 import type { QueueService, QueueJob, JobOptions } from '@pikku/core/queue'
 import { mapBullJobToQueueJob } from './utils.js'
 
@@ -73,6 +70,18 @@ export class BullQueueService implements QueueService {
     await queue.waitUntilReady()
 
     this.queues.set(queueName, queue)
+
+    if (!this.queueEvents.has(queueName)) {
+      const queueEvents = new QueueEvents(
+        queueName,
+        this.redisConnectionOptions
+          ? { connection: this.redisConnectionOptions }
+          : undefined
+      )
+      await queueEvents.waitUntilReady()
+      this.queueEvents.set(queueName, queueEvents)
+    }
+
     return queue
   }
 

package/src/bull-queue-worker.test.ts

@@ -0,0 +1,15 @@
+import { describe, test } from 'node:test'
+import assert from 'node:assert/strict'
+
+import { BullQueueWorkers } from './bull-queue-worker.js'
+
+describe('BullQueueWorkers', () => {
+  test('requires setJobRunner before registerQueues', async () => {
+    const workers = new BullQueueWorkers({})
+
+    await assert.rejects(() => workers.registerQueues(), {
+      message:
+        'BullQueueWorkers requires setJobRunner() before registerQueues()',
+    })
+  })
+})

package/src/bull-queue-worker.ts

@@ -1,9 +1,6 @@
-import Bull, {
-  ConnectionOptions,
-  WorkerOptions,
-  Worker,
-  QueueEvents,
-} from 'bullmq'
+import type { ConnectionOptions, WorkerOptions, QueueEvents } from 'bullmq'
+import type Bull from 'bullmq'
+import { Worker } from 'bullmq'
 import type {
   QueueWorkers,
   PikkuWorkerConfig,
@@ -11,12 +8,12 @@ import type {
   ConfigValidationResult,
 } from '@pikku/core/queue'
 import {
-  runQueueJob,
   registerQueueWorkers,
+  runQueueJob,
   QueueJobFailedError,
   QueueJobDiscardedError,
 } from '@pikku/core/queue'
-import type { CoreSingletonServices, CreateWireServices } from '@pikku/core'
+import { pikkuState } from '@pikku/core/internal'
 import { mapBullJobToQueueJob } from './utils.js'
 
 export const mapPikkuWorkerToBull = (
@@ -138,27 +135,23 @@ export class BullQueueWorkers implements QueueWorkers {
   private workers = new Map<string, Bull.Worker>()
   private queueEvents = new Map<string, QueueEvents>()
 
-  constructor(
-    private redisConnectionOptions: ConnectionOptions,
-    private singletonServices: CoreSingletonServices,
-    private createWireServices?: CreateWireServices
-  ) {}
+  constructor(private redisConnectionOptions: ConnectionOptions) {}
 
   /**
    * Scan state and register all compatible processors
    */
   async registerQueues(): Promise<Record<string, ConfigValidationResult[]>> {
+    const logger = pikkuState(null, 'package', 'singletonServices')!.logger
+
     return await registerQueueWorkers(
       this.configMappings,
-      this.singletonServices.logger,
+      logger,
       async (queueName, processor) => {
         const worker = new Worker(
-          processor.queueName,
+          processor.name,
           async (job: Bull.Job) => {
             try {
               return await runQueueJob({
-                singletonServices: this.singletonServices,
-                createWireServices: this.createWireServices,
                 job: await mapBullJobToQueueJob(
                   job,
                   this.redisConnectionOptions,

package/src/bull-scheduler-service.ts

@@ -1,11 +1,13 @@
-import { ConnectionOptions, Queue } from 'bullmq'
-import {
-  SchedulerService,
+import type { ConnectionOptions } from 'bullmq'
+import { Queue, Worker } from 'bullmq'
+import type {
   ScheduledTaskInfo,
   ScheduledTaskSummary,
   CoreUserSession,
-  parseDurationString,
 } from '@pikku/core'
+import { SchedulerService, parseDurationString } from '@pikku/core'
+import { pikkuState } from '@pikku/core/internal'
+import { runScheduledTask, getScheduledTasks } from '@pikku/core/scheduler'
 
 /**
  * Data stored in scheduled job
@@ -16,18 +18,22 @@ interface ScheduledJobData {
   session?: CoreUserSession
 }
 
-/**
- * BullMQ scheduler service implementation
- * Uses BullMQ's delayed jobs for one-time execution
- */
+const RECURRING_QUEUE_NAME = 'pikku-recurring-scheduled-task'
+
 export class BullSchedulerService extends SchedulerService {
   private queue: Queue
+  private recurringQueue: Queue
+  private recurringWorker?: Worker
+  private repeatJobKeys: string[] = []
 
-  constructor(redisConnectionOptions: ConnectionOptions) {
+  constructor(private redisConnectionOptions: ConnectionOptions) {
     super()
     this.queue = new Queue('pikku-remote-internal-rpc', {
       connection: redisConnectionOptions,
     })
+    this.recurringQueue = new Queue(RECURRING_QUEUE_NAME, {
+      connection: redisConnectionOptions,
+    })
   }
 
   /**
@@ -134,6 +140,61 @@ export class BullSchedulerService extends SchedulerService {
    * Close the queue connection
    */
   async close(): Promise<void> {
+    if (this.recurringWorker) {
+      await this.recurringWorker.close()
+    }
+    await this.recurringQueue.close()
     await this.queue.close()
   }
+
+  /**
+   * Start recurring scheduled tasks.
+   * Creates a BullMQ Worker to process repeat jobs via runScheduledTask.
+   */
+  async start(): Promise<void> {
+    const logger = pikkuState(null, 'package', 'singletonServices')!.logger
+    const scheduledTasks = getScheduledTasks()
+
+    // Create a worker to process recurring scheduled task jobs
+    this.recurringWorker = new Worker(
+      RECURRING_QUEUE_NAME,
+      async (job) => {
+        const { rpcName } = job.data as ScheduledJobData
+        logger.info(`Running scheduled task: ${rpcName}`)
+        await runScheduledTask({ name: rpcName })
+      },
+      { connection: this.redisConnectionOptions }
+    )
+    this.recurringWorker.on('error', (err) => {
+      logger.error(`Recurring task worker error: ${err}`)
+    })
+
+    for (const [name, task] of scheduledTasks) {
+      const job = await this.recurringQueue.add(
+        name,
+        { rpcName: name } as ScheduledJobData,
+        {
+          repeat: { pattern: task.schedule },
+          jobId: `recurring:${name}`,
+        }
+      )
+      if (job.repeatJobKey) {
+        this.repeatJobKeys.push(job.repeatJobKey)
+      }
+    }
+  }
+
+  /**
+   * Stop recurring scheduled tasks by removing repeat jobs.
+   */
+  async stop(): Promise<void> {
+    for (const key of this.repeatJobKeys) {
+      await this.recurringQueue.removeRepeatableByKey(key)
+    }
+    this.repeatJobKeys = []
+    if (this.recurringWorker) {
+      await this.recurringWorker.close()
+      this.recurringWorker = undefined
+    }
+  }
 }

package/src/bull-service-factory.ts

@@ -1,8 +1,7 @@
-import { ConnectionOptions } from 'bullmq'
+import type { ConnectionOptions } from 'bullmq'
 import { BullQueueService } from './bull-queue-service.js'
 import { BullQueueWorkers } from './bull-queue-worker.js'
 import { BullSchedulerService } from './bull-scheduler-service.js'
-import type { CoreSingletonServices, CreateWireServices } from '@pikku/core'
 
 /**
  * Factory class for BullMQ services
@@ -35,16 +34,9 @@ export class BullServiceFactory {
   /**
    * Get the queue workers for processing jobs
    */
-  getQueueWorkers(
-    singletonServices: CoreSingletonServices,
-    createWireServices?: CreateWireServices
-  ): BullQueueWorkers {
+  getQueueWorkers(): BullQueueWorkers {
     if (!this.queueWorkers) {
-      this.queueWorkers = new BullQueueWorkers(
-        this.redisConnectionOptions,
-        singletonServices,
-        createWireServices
-      )
+      this.queueWorkers = new BullQueueWorkers(this.redisConnectionOptions)
     }
     return this.queueWorkers
   }

package/src/utils.ts

@@ -1,5 +1,6 @@
-import { QueueJob, QueueJobStatus } from '@pikku/core/queue'
-import { ConnectionOptions, Job, QueueEvents } from 'bullmq'
+import type { QueueJob, QueueJobStatus } from '@pikku/core/queue'
+import type { ConnectionOptions, Job } from 'bullmq'
+import { QueueEvents } from 'bullmq'
 
 /**
  * Map Bull job state to our queue job status
@@ -36,13 +37,14 @@ export const mapBullJobToQueueJob = async <In, Out>(
     result: bullJob.returnvalue as Out,
     status: async () => mapBullStateToStatus(await bullJob.getState()),
     waitForCompletion: async (ttl?: number): Promise<Out> => {
-      let queueEvents = queueEventsMap.get(bullJob.name)
+      let queueEvents = queueEventsMap.get(bullJob.queueName)
       if (!queueEvents) {
         queueEvents = new QueueEvents(
-          bullJob.name,
+          bullJob.queueName,
           redisConnection ? { connection: redisConnection } : undefined
         )
-        queueEventsMap.set(bullJob.name, queueEvents)
+        queueEventsMap.set(bullJob.queueName, queueEvents)
+        await queueEvents.waitUntilReady()
       }
       return await bullJob.waitUntilFinished(queueEvents, ttl)
     },