@pikku/kysely 0.13.12 → 0.13.13

package/CHANGELOG.md

@@ -1,3 +1,47 @@
+## 0.13.13
+
+### Patch Changes
+
+- 6dada45: fix(workflow,ai-agent): make a run's owner, entry node and step function authoritative
+
+  A graph run may only start at a node the graph declared in `meta.entryNodeIds`, and
+  the generated `POST /workflow/:workflowName/graph/:nodeId` route that let an HTTP
+  caller pick the entry node is gone. `startNode` stays for `PikkuTriggerService`,
+  which names a declared entry node anyway.
+
+  `StepState` now records the `rpcName` the workflow dispatched a step with, and the
+  step claim rejects a queue message naming a different function with
+  `WorkflowStepFunctionMismatchError` before mutating any status — a step runs under
+  the run owner's identity and without the `expose` gate, so the message must not
+  choose what runs.
+
+  `approveStep` takes the caller's session, and the generated status routes and
+  streams assert the same `assertWorkflowRunOwner` check: a run started through a
+  session may only be read and approved by that session's user. A run with no
+  recorded owner (trigger, scheduler, unauthenticated route) has nobody to compare
+  against and is still gated by the entrypoint's own `auth`/`permissions`.
+
+  `AIRunStateService.resolveApproval` is now a compare-and-swap returning whether
+  _this_ caller made the claim, and both agent resume paths run a tool only for the
+  approvals they claimed — concurrent approvals of one tool call no longer all
+  execute it.
+
+- Updated dependencies [41c1a95]
+- Updated dependencies [ce96383]
+- Updated dependencies [7e60867]
+- Updated dependencies [f8f1244]
+- Updated dependencies [dcf20cb]
+- Updated dependencies [6512384]
+- Updated dependencies [e3b4c14]
+- Updated dependencies [efd0ed1]
+- Updated dependencies [cba98fb]
+- Updated dependencies [ce96383]
+- Updated dependencies [f8f1244]
+- Updated dependencies [f8f1244]
+- Updated dependencies [6e93a35]
+- Updated dependencies [6dada45]
+  - @pikku/core@0.12.80
+
 ## 0.13.12
 
 ### Patch Changes

package/dist/src/kysely-ai-run-state-service.d.ts

@@ -11,7 +11,7 @@ export declare class KyselyAIRunStateService implements AIRunStateService {
     updateRun(runId: string, updates: Partial<AgentRunState>): Promise<void>;
     getRun(runId: string): Promise<AgentRunState | null>;
     getRunsByThread(threadId: string): Promise<AgentRunState[]>;
-    resolveApproval(toolCallId: string, status: 'approved' | 'denied'): Promise<void>;
+    resolveApproval(toolCallId: string, status: 'approved' | 'denied'): Promise<boolean>;
     findRunByToolCallId(toolCallId: string): Promise<{
         run: AgentRunState;
         approval: PendingApproval;

package/dist/src/kysely-ai-run-state-service.js

@@ -100,14 +100,19 @@ export class KyselyAIRunStateService {
                 if (filtered.length === 0) {
                     updates.status = status;
                 }
-                await this.db
+                // Compare-and-swap on the list we read: a concurrent approver that got
+                // there first has already rewritten it, and this update matches no row.
+                const result = await this.db
                     .updateTable('aiRun')
                     .set(updates)
                     .where('runId', '=', row.runId)
-                    .execute();
-                return;
+                    .where('status', '=', 'suspended')
+                    .where('pendingApprovals', '=', row.pendingApprovals)
+                    .executeTakeFirst();
+                return Number(result?.numUpdatedRows ?? 0) > 0;
             }
         }
+        return false;
     }
     async findRunByToolCallId(toolCallId) {
         const rows = await this.db

package/dist/src/kysely-ai-storage-service.d.ts

@@ -32,6 +32,6 @@ export declare class KyselyAIStorageService implements AIStorageService, AIRunSt
         run: AgentRunState;
         approval: NonNullable<AgentRunState['pendingApprovals']>[number];
     } | null>;
-    resolveApproval(toolCallId: string, status: 'approved' | 'denied'): Promise<void>;
+    resolveApproval(toolCallId: string, status: 'approved' | 'denied'): Promise<boolean>;
     close(): Promise<void>;
 }

package/dist/src/kysely-ai-storage-service.js

@@ -510,11 +510,14 @@ export class KyselyAIStorageService {
         return { run, approval };
     }
     async resolveApproval(toolCallId, status) {
-        await this.db
+        // Only the caller that moves the tool call off 'pending' has claimed it.
+        const result = await this.db
             .updateTable('aiToolCall')
             .set({ approvalStatus: status })
             .where('id', '=', toolCallId)
-            .execute();
+            .where('approvalStatus', '=', 'pending')
+            .executeTakeFirst();
+        return Number(result?.numUpdatedRows ?? 0) > 0;
     }
     async close() { }
 }

package/dist/src/kysely-workflow-service.js

@@ -78,6 +78,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
         return {
             stepId,
             status: 'pending',
+            rpcName,
             result: undefined,
             error: undefined,
             attemptCount: 1,
@@ -94,6 +95,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
             .select([
             'workflowStepId',
             'status',
+            'rpcName',
             'result',
             'error',
             'retries',
@@ -115,6 +117,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
         return {
             stepId: row.workflowStepId,
             status: row.status,
+            rpcName: row.rpcName ?? null,
             result: parseJson(row.result),
             error: parseJson(row.error),
             attemptCount: Number(row.currentAttempt ?? 1),
@@ -331,6 +334,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
             .select([
             'workflowStepId',
             'status',
+            'rpcName',
             'result',
             'error',
             'retries',
@@ -345,6 +349,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
         return {
             stepId: row.workflowStepId,
             status: row.status,
+            rpcName: row.rpcName ?? null,
             result: parseJson(row.result),
             error: parseJson(row.error),
             attemptCount: Number(row.currentAttempt ?? 1),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pikku/kysely",
-  "version": "0.13.12",
+  "version": "0.13.13",
   "description": "Kysely-backed Pikku services — workflow state, secrets, sessions, scopes and audit",
   "author": "yasser.fadl@gmail.com",
   "license": "MIT",
@@ -21,7 +21,7 @@
     "prepublishOnly": "yarn build"
   },
   "peerDependencies": {
-    "@pikku/core": "^0.12.79"
+    "@pikku/core": "^0.12.80"
   },
   "dependencies": {
     "kysely": "^0.29.0"

package/src/kysely-ai-run-state-service.ts

@@ -89,7 +89,7 @@ export class KyselyAIRunStateService implements AIRunStateService {
   async resolveApproval(
     toolCallId: string,
     status: 'approved' | 'denied'
-  ): Promise<void> {
+  ): Promise<boolean> {
     const rows = await this.db
       .selectFrom('aiRun')
       .select(['runId', 'pendingApprovals'])
@@ -117,14 +117,19 @@ export class KyselyAIRunStateService implements AIRunStateService {
         if (filtered.length === 0) {
           updates.status = status
         }
-        await this.db
+        // Compare-and-swap on the list we read: a concurrent approver that got
+        // there first has already rewritten it, and this update matches no row.
+        const result = await this.db
           .updateTable('aiRun')
           .set(updates as any)
           .where('runId', '=', row.runId)
-          .execute()
-        return
+          .where('status', '=', 'suspended')
+          .where('pendingApprovals', '=', row.pendingApprovals)
+          .executeTakeFirst()
+        return Number(result?.numUpdatedRows ?? 0) > 0
       }
     }
+    return false
   }
 
   async findRunByToolCallId(

package/src/kysely-ai-storage-service.ts

@@ -596,12 +596,15 @@ export class KyselyAIStorageService
   async resolveApproval(
     toolCallId: string,
     status: 'approved' | 'denied'
-  ): Promise<void> {
-    await this.db
+  ): Promise<boolean> {
+    // Only the caller that moves the tool call off 'pending' has claimed it.
+    const result = await this.db
       .updateTable('aiToolCall')
       .set({ approvalStatus: status })
       .where('id', '=', toolCallId)
-      .execute()
+      .where('approvalStatus', '=', 'pending')
+      .executeTakeFirst()
+    return Number(result?.numUpdatedRows ?? 0) > 0
   }
 
   public async close(): Promise<void> {}

package/src/kysely-webhook-service.test.ts

@@ -2,7 +2,7 @@ import { describe, test, beforeEach } from 'node:test'
 import assert from 'node:assert/strict'
 import { CamelCasePlugin, Kysely, SqliteDialect } from 'kysely'
 import Database from 'better-sqlite3'
-import { setSingletonServices } from '@pikku/core'
+import { setSingletonServices } from '@pikku/core/ecosystem'
 
 import type { KyselyPikkuDB } from './kysely-tables.js'
 import { SerializePlugin } from './serialize-plugin.js'

package/src/kysely-workflow-service.ts

@@ -123,6 +123,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
     return {
       stepId,
       status: 'pending',
+      rpcName,
       result: undefined,
       error: undefined,
       attemptCount: 1,
@@ -140,6 +141,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
       .select([
         'workflowStepId',
         'status',
+        'rpcName',
         'result',
         'error',
         'retries',
@@ -165,6 +167,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
     return {
       stepId: row.workflowStepId,
       status: row.status as StepState['status'],
+      rpcName: row.rpcName ?? null,
       result: parseJson(row.result),
       error: parseJson(row.error),
       attemptCount: Number(row.currentAttempt ?? 1),
@@ -425,6 +428,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
       .select([
         'workflowStepId',
         'status',
+        'rpcName',
         'result',
         'error',
         'retries',
@@ -440,6 +444,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
     return {
       stepId: row.workflowStepId,
       status: row.status as StepState['status'],
+      rpcName: row.rpcName ?? null,
       result: parseJson(row.result),
       error: parseJson(row.error),
       attemptCount: Number(row.currentAttempt ?? 1),